[PATCH v2 07/90] target/sparc: Use CPU_FEATURE_BIT_* for cpu properties

2023-10-17 Thread Richard Henderson
Use symbols not integer constants for the bit positions. Signed-off-by: Richard Henderson --- target/sparc/cpu.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 8ba96ae225..e4d1c552e5

[PATCH v2 59/90] target/sparc: Move EDGE* to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 22 ++- target/sparc/translate.c | 272 -- 2 files changed, 134 insertions(+), 160 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 42eb807e21..fb104e77d1

[PATCH v2 49/90] target/sparc: Move asi integer load/store to decodetree

2023-10-17 Thread Richard Henderson
Move LDDA, LDSBA, LDSHA, LDSWA, LDUBA, LDUHA, LDUWA, LDXA, STBA, STDA, STHA, STWA, STXA. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 31 + target/sparc/translate.c | 128 +- 2 files changed, 48 insertions(+), 111 deletions(-)

[PATCH v2 82/90] target/sparc: Move FiTOq, FsTOq to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 2 ++ target/sparc/translate.c | 44 +-- 2 files changed, 26 insertions(+), 20 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 249f03a075..0b54384af7

[PATCH v2 03/90] target/sparc: Avoid helper_raise_exception in helper_st_asi

2023-10-17 Thread Richard Henderson
Always use cpu_raise_exception_ra with GETPC for unwind. Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c index 246de86c98..09066d5487 100644 ---

[PATCH v2 55/90] target/sparc: Move simple fp load/store to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 19 target/sparc/translate.c | 194 ++ 2 files changed, 113 insertions(+), 100 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 86108679eb..ab311055da

[PATCH v2 45/90] target/sparc: Drop ifdef around get_asi and friends

2023-10-17 Thread Richard Henderson
Mark some of the functions as unused, temporarily. Fix up some tl vs i64 issues revealed in the process. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 187 +++ 1 file changed, 70 insertions(+), 117 deletions(-) diff --git

[PATCH v2 73/90] target/sparc: Move gen_fop_FFF insns to decodetree

2023-10-17 Thread Richard Henderson
Move FADDs, FSUBs, FMULs, FDIVs. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 54 +++ 2 files changed, 31 insertions(+), 27 deletions(-) diff --git a/target/sparc/insns.decode

[PATCH v2 37/90] target/sparc: Move SLL, SRL, SRA to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 14 +++ target/sparc/translate.c | 182 -- 2 files changed, 92 insertions(+), 104 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 18e2372928..fe0eacd779

[PATCH v2 44/90] target/sparc: Split out resolve_asi

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/translate.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 784a019dcf..1d3bfb724e 100644 --- a/target/sparc/translate.c +++

[PATCH v2 87/90] target/sparc: Move FPCMP* to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 9 target/sparc/translate.c | 94 +-- 2 files changed, 50 insertions(+), 53 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 3167797854..0a0c5b2505

[PATCH v2 41/90] target/sparc: Move JMPL, RETT, RETURN to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 6 ++ target/sparc/translate.c | 126 -- 2 files changed, 87 insertions(+), 45 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index bdbf6d987c..060ee79db0

[PATCH 16/20] target/sparc: Merge gen_op_next_insn into only caller

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/translate.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 18546d3bd2..8a92fa4a1a 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@

[PATCH 03/20] target/sparc: Remove CC_OP_DIV

2023-10-17 Thread Richard Henderson
Return both result and overflow from helper_[us]div. Compute all flags explicitly in gen_op_[us]divcc. Marginally improve the INT64_MIN special case in do_sdiv. Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 1 - target/sparc/helper.h| 4 +-- target/sparc/cc_helper.c |

[PATCH 10/20] target/sparc: Change DisasCompare.c2 to int

2023-10-17 Thread Richard Henderson
We don't require c2 to be variable, so emphasize that. We don't currently require c2 to be non-zero, but that will change. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git

[PATCH 01/20] target/sparc: Introduce cpu_put_psr_icc

2023-10-17 Thread Richard Henderson
Isolate linux-user from changes to icc representation. Signed-off-by: Richard Henderson --- target/sparc/cpu.h| 1 + linux-user/sparc/signal.c | 2 +- target/sparc/win_helper.c | 7 ++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/target/sparc/cpu.h

Re: [Virtio-fs] (no subject)

2023-10-17 Thread Hanna Czenczek
On 17.10.23 09:49, Viresh Kumar wrote: On 13-10-23, 20:02, Hanna Czenczek wrote: On 10.10.23 16:35, Alex Bennée wrote: I was going to say there is also the rust-vmm vhost-user-master crates which we've imported: https://github.com/vireshk/vhost for the Xen Vhost Frontend:

[PULL 34/38] migration/ram: Move xbzrle zero page handling into save_zero_page

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas It makes a bit more sense to have the zero page handling of xbzrle right where we save the zero page. Also invert the exit condition to remove one level of indentation which makes the next patch easier to grasp. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas

[PULL 25/38] migration/rdma: Declare for index variables local

2023-10-17 Thread Juan Quintela
Declare all variables that are only used inside a for loop inside the for statement. This makes clear that they are not used outside of the for loop. Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-13-quint...@redhat.com> ---

[PULL 18/38] migration/rdma: Unfold hook_ram_load()

2023-10-17 Thread Juan Quintela
There is only one flag called with: RAM_CONTROL_BLOCK_REG. Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-6-quint...@redhat.com> --- migration/qemu-file.h | 11 --- migration/rdma.h | 3 +++ migration/qemu-file.c | 10 --

[PULL 36/38] migration/multifd: Remove direct "socket" references

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas We're about to enable support for other transports in multifd, so remove direct references to sockets. Signed-off-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID:

[PULL 12/38] migration: hold the BQL during setup

2023-10-17 Thread Juan Quintela
From: Fiona Ebner This is intended to be a semantic revert of commit 9b09503752 ("migration: run setup callbacks out of big lock"). There have been so many changes since that commit (e.g. a new setup callback dirty_bitmap_save_setup() that also needs to be adapted now), it's easier to do the

[PULL 30/38] multifd: reset next_packet_len after sending pages

2023-10-17 Thread Juan Quintela
From: Elena Ufimtseva Sometimes multifd sends just sync packet with no pages (normal_num is 0). In this case the old value is being preserved and being accounted for while only packet_len is being transferred. Reset it to 0 after sending and accounting for. Signed-off-by: Elena Ufimtseva

[PULL 15/38] migration/rdma: Unfold ram_control_before_iterate()

2023-10-17 Thread Juan Quintela
Once there: - Remove unused data parameter - unfold it in its callers. - change all callers to call qemu_rdma_registration_start() - We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma() Reviewed-by: Li Zhijian Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID:

Re: [PATCH v2 2/3] backends: Initial support for SPDM socket support

2023-10-17 Thread Jonathan Cameron via
On Tue, 17 Oct 2023 15:21:54 +1000 Alistair Francis wrote: > From: Huai-Cheng Kuo > > SPDM enables authentication, attestation and key exchange to assist in > providing infrastructure security enablement. It's a standard published > by the DMTF [1]. > > SPDM supports multiple transports,

[PATCH v2 02/90] target/sparc: Implement check_align inline

2023-10-17 Thread Richard Henderson
Emit the exception at the end of the translation block, so that the non-exception case can fall through. Signed-off-by: Richard Henderson --- target/sparc/helper.h | 1 - target/sparc/ldst_helper.c | 7 ++-- target/sparc/translate.c | 68 +- 3 files

[PATCH v2 86/90] target/sparc: Convert FCMP, FCMPE to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 7 ++ target/sparc/translate.c | 145 +++--- 2 files changed, 96 insertions(+), 56 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 88d4b8529d..3167797854

[PATCH v2 47/90] target/sparc: Use tcg_gen_qemu_{ld, st}_i128 for GET_ASI_DTWINX

2023-10-17 Thread Richard Henderson
Perform one atomic 16-byte operation. The atomicity is required for the LDTXA instructions. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 48 +--- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/target/sparc/translate.c

[PATCH v2 06/90] target/sparc: Define features via cpu-feature.h.inc

2023-10-17 Thread Richard Henderson
Manage feature bits automatically. Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 32 +--- target/sparc/cpu-feature.h.inc | 19 +++ 2 files changed, 32 insertions(+), 19 deletions(-) create mode 100644

[PATCH v2 51/90] target/sparc: Move SWAP, SWAPA to decodetree

2023-10-17 Thread Richard Henderson
Remove gen_swap_asi. Rename gen_swap_asi0 to gen_swap_asi. Merge gen_swap into gen_swap_asi. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 58 +-- 2 files changed, 29 insertions(+), 33 deletions(-) diff

[PATCH v2 56/90] target/sparc: Move asi fp load/store to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 51 ++-- target/sparc/translate.c | 169 -- 2 files changed, 79 insertions(+), 141 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index

[PATCH v2 13/90] target/sparc: Move BPr to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 3 ++ target/sparc/translate.c | 70 --- 2 files changed, 32 insertions(+), 41 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 15cd975f4e..838f4cdb1d

[PATCH v2 65/90] target/sparc: Use tcg_gen_vec_{add,sub}*

2023-10-17 Thread Richard Henderson
Replace the local helpers for the same integer operations. Signed-off-by: Richard Henderson --- target/sparc/helper.h | 12 target/sparc/translate.c | 15 +- target/sparc/vis_helper.c | 59 --- 3 files changed, 7 insertions(+), 79

[PATCH v2 85/90] target/sparc: Move FMOVR, FMOVcc, FMOVfcc to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 12 +++ target/sparc/translate.c | 192 -- 2 files changed, 91 insertions(+), 113 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 23db453617..88d4b8529d

[PATCH v2 09/90] target/sparc: Add decodetree infrastructure

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 5 +++ target/sparc/translate.c | 69 ++- target/sparc/meson.build | 3 ++ 3 files changed, 55 insertions(+), 22 deletions(-) create mode 100644 target/sparc/insns.decode diff --git

[PATCH v2 66/90] target/sparc: Move gen_ne_fop_FFF insns to decodetree

2023-10-17 Thread Richard Henderson
Move FANDNOT1s, FANDNOT2s, FANDs, FNANDs, FNORs, FORNOT1s, FORNOT2s, FORs, FPADD16s, FPADD32s, FPSUB16s, FPSUB32s, FXNORs, FXORs. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 16 ++ target/sparc/translate.c | 116 ++ 2 files changed,

[PATCH v2 14/90] target/sparc: Move FBPfcc and FBfcc to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 ++ target/sparc/translate.c | 105 +++--- 2 files changed, 46 insertions(+), 63 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index 838f4cdb1d..9ab3f2eb82

[PATCH 00/20] target/sparc: Cleanup condition codes etc

2023-10-17 Thread Richard Henderson
This was part of my guess for some of the performance problems. I saw compute_all_sub quite high in the profile at some point, and I believe that the test case has a partially rotated loop such that "cmp" is in a delay slot, and so the gen_compare fast path for CC_OP_SUB is not visible to the

[PATCH 11/20] target/sparc: Always copy conditions into a new temporary

2023-10-17 Thread Richard Henderson
This will allow the condition to live across changes to the global cc variables. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index

[PATCH 07/20] target/sparc: Remove CC_OP_TADDTV, CC_OP_TSUBTV

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 2 - target/sparc/cc_helper.c | 267 +-- target/sparc/helper.c| 40 -- target/sparc/translate.c | 4 +- 4 files changed, 32 insertions(+), 281 deletions(-) diff --git

[PATCH 17/20] target/sparc: Record entire jump condition in DisasContext

2023-10-17 Thread Richard Henderson
Use the original condition instead of consuming cpu_cond, which will now only be live along exception paths. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/target/sparc/translate.c

[PATCH 15/20] target/sparc: Use DISAS_EXIT in do_wrpsr

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/translate.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 53a755874e..18546d3bd2 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -3207,10

Re: [PATCH v3 0/3] Add emulation of AmigaOne XE board

2023-10-17 Thread Cédric Le Goater
On 10/17/23 00:25, BALATON Zoltan wrote: On Sat, 14 Oct 2023, BALATON Zoltan wrote: Changes in v3: - Update values, comment and commit message in patch 1 again Changes in v2: - Update comment and commit message in patch 1 (Mark) - Fix irq mapping in patch 2 (Volker) Regards, BALATON Zoltan

Re: [PATCH v3 0/2] Add PowerNV I2C Controller Model

2023-10-17 Thread Cédric Le Goater
On 10/17/23 00:20, Glenn Miles wrote: Upstreams the PowerNV I2C controller model originally authored by Cédric Le Goater with minor changes by myself to split the actual addition of the model from wiring it up to a power processor model. This series only attaches the controller to the powernv9

Re: [PULL 11/38] tests/qtest: migration-test: Add tests for file-based migration

2023-10-17 Thread Juan Quintela
Fabiano Rosas wrote: D> Juan Quintela writes: > >> From: Fabiano Rosas >> >> Add basic tests for file-based migration. >> >> Note that we cannot use test_precopy_common because that routine >> expects it to be possible to run the migration live. With the file >> transport there is no live

[PATCH qemu v2 0/1] Switch memory management calls to new coding conventions

2023-10-17 Thread ~h0lyalg0rithm
Updated to change remaining free to g_free Suraj Shirvankar (1): Switch memory management calls to new coding conventions contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 4 ++--

[PATCH qemu v2 1/1] Switch memory management calls to new coding conventions

2023-10-17 Thread ~h0lyalg0rithm
From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 4 ++-- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git

Re: [Virtio-fs] (no subject)

2023-10-17 Thread Viresh Kumar
On 13-10-23, 20:02, Hanna Czenczek wrote: > On 10.10.23 16:35, Alex Bennée wrote: > > I was going to say there is also the rust-vmm vhost-user-master crates > > which we've imported: > > > >https://github.com/vireshk/vhost > > > > for the Xen Vhost Frontend: > > > >

Re: [PATCH 1/1] target/arm: Adding a check for the result of calling the CPU information check function

2023-10-17 Thread Миронов Сергей Владимирович
Yes, the warning was initially received in the static analyzer SVACE, the same type as Coverity. In this case, return value of a function 'get_arm_cp_reginfo' is referenced at helper.c without checking for ALL, but it is usually checked for this function (8/9).

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Albert Esteve
Hi! Thanks for the patch, and sorry for not noticing the flag had already been assigned. The patch looks good to me! BR, Albert On Tue, Oct 17, 2023 at 9:54 AM Viresh Kumar wrote: > On 17-10-23, 09:51, Hanna Czenczek wrote: > > Not that I’m really opposed to that, but I don’t see the problem

[PULL 09/38] migration: Fix analyze-migration read operation signedness

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The migration code uses unsigned values for 16, 32 and 64-bit operations. Fix the script to do the same. This was causing an issue when parsing the migration stream generated on the ppc64 target because one of instance_ids was larger than the 32bit signed maximum: Traceback

[PULL 06/38] migration: Fix analyze-migration.py 'configuration' parsing

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The 'configuration' state subsections are currently not being parsed and the script fails when analyzing an aarch64 stream: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 625, in dump.read(dump_memory = args.memory) File

[PULL 07/38] migration: Add capability parsing to analyze-migration.py

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The script is broken when the configuration/capabilities section is present. Add support for parsing the capabilities so we can fix it in the next patch. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID:

[PULL 16/38] migration/rdma: Unfold ram_control_after_iterate()

2023-10-17 Thread Juan Quintela
Once there: - Remove unused data parameter - unfold it in its callers - change all callers to call qemu_rdma_registration_stop() - We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma() Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID:

[PULL 31/38] migration/ram: Refactor precopy ram loading code

2023-10-17 Thread Juan Quintela
From: Nikolay Borisov Extract the ramblock parsing code into a routine that operates on the sequence of headers from the stream and another the parses the individual ramblock. This makes ram_load_precopy() easier to comprehend. Signed-off-by: Nikolay Borisov Reviewed-by: Philippe Mathieu-Daudé

[PULL 26/38] migration/rdma: Remove all "ret" variables that are used only once

2023-10-17 Thread Juan Quintela
Change code that is: int ret; ... ret = foo(); if (ret[ < 0]?) { to: if (foo()[ < 0]) { Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-14-quint...@redhat.com> --- migration/rdma.c | 29 - 1 file

[PULL 38/38] migration/multifd: Clarify Error usage in multifd_channel_connect

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The function is currently called from two sites, one always gives it a NULL Error and the other always gives it a non-NULL Error. In the non-NULL case, all it does it trace the error and return. One of the callers already have tracing, add a tracepoint to the other and stop

[PULL 23/38] migration/rdma: Check sooner if we are in postcopy for save_page()

2023-10-17 Thread Juan Quintela
Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-11-quint...@redhat.com> --- migration/rdma.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index c147c94b08..e973579a52

[PULL 35/38] migration/ram: Merge save_zero_page functions

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas We don't need to do this in two pieces. One single function makes it easier to grasp, specially since it removes the indirection on the return value handling. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela

Re: [RFC/PATCH v0 12/12] gunyah: Documentation

2023-10-17 Thread Srivatsa Vaddagiri
* Alex Benn?e [2023-10-12 15:55:59]: > > Hi Phil, > > We do want to see Gunyah support merged in Qemu at the earliest (as soon > > as the kernel driver is merged upstream that is), so any dependent change in > > Qemu for Gunyah would be of much interest to us! I am not sure though if > >

[PATCH v2 31/90] target/sparc: Move MULX to decodetree

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 1 + target/sparc/translate.c | 6 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index abcee27fd4..d9474d2a20 100644 --- a/target/sparc/insns.decode +++

[PATCH v2 50/90] target/sparc: Move LDSTUB, LDSTUBA to decodetree

2023-10-17 Thread Richard Henderson
Remove gen_ldstub_asi. Rename gen_ldstub_asi0 to gen_ldstub_asi. Merge gen_ldstub into gen_ldstub_asi. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 target/sparc/translate.c | 46 +++ 2 files changed, 26 insertions(+), 24

Re: [PATCH v3 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash

2023-10-17 Thread Markus Armbruster
Peter Xu writes: > On Mon, Oct 16, 2023 at 09:08:40AM +0200, Markus Armbruster wrote: >> Let me try to summarize our findings so far. > > Thanks. I'll reply here instead of all the rest places. > >> >> PATCH 1 has been merged. PATCH 2 has been queued, but not merged (not >> sure why,

[PATCH 12/20] target/sparc: Do flush_cond in advance_jump_cond

2023-10-17 Thread Richard Henderson
Do this here instead of in each caller. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index a75f75dfb9..74a0972bda 100644 ---

[PATCH 08/20] target/sparc: Remove CC_OP leftovers

2023-10-17 Thread Richard Henderson
All instructions have been converted to generate full condition codes explicitly. Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 21 --- target/sparc/helper.h | 2 - linux-user/sparc/cpu_loop.c | 5 -- target/sparc/cc_helper.c| 42 -

[PATCH 20/20] target/sparc: Implement UDIV inline

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/helper.h| 1 - target/sparc/helper.c| 29 +++--- target/sparc/translate.c | 52 +++- 3 files changed, 54 insertions(+), 28 deletions(-) diff --git a/target/sparc/helper.h

[PATCH 19/20] target/sparc: Implement UDIVX and SDIVX inline

2023-10-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/helper.h| 4 -- target/sparc/helper.c| 24 - target/sparc/translate.c | 109 ++- 3 files changed, 95 insertions(+), 42 deletions(-) diff --git a/target/sparc/helper.h b/target/sparc/helper.h

[PATCH 05/20] target/sparc: Remove CC_OP_ADD, CC_OP_ADDX, CC_OP_TADD

2023-10-17 Thread Richard Henderson
These are all related and implementable with common code. Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 3 - target/sparc/cc_helper.c | 59 target/sparc/translate.c | 199 +++ 3 files changed, 95 insertions(+), 166

[PATCH 18/20] target/sparc: Discard cpu_cond at the end of each insn

2023-10-17 Thread Richard Henderson
If the insn raises no exceptions, there will be no path in which cpu_cond is used, and so the computation may be optimized away. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 27 +++ 1 file changed, 27 insertions(+) diff --git

Re: [PULL 00/38] Migration 20231016 patches

2023-10-17 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Mon, 16 Oct 2023 at 06:11, Juan Quintela wrote: >> >> The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56: >> >> Merge tag 'pull-riscv-to-apply-20231012-1' of >> https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400) >>

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Hanna Czenczek
On 17.10.23 07:36, Viresh Kumar wrote: On 16-10-23, 12:40, Alex Bennée wrote: Viresh Kumar writes: On 16-10-23, 11:45, Manos Pitsidianakis wrote: On Mon, 16 Oct 2023 11:32, Hanna Czenczek wrote: diff --git a/include/hw/virtio/vhost-user.h b/include/hw/virtio/vhost-user.h index

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Hanna Czenczek
On 17.10.23 09:53, Viresh Kumar wrote: On 17-10-23, 09:51, Hanna Czenczek wrote: Not that I’m really opposed to that, but I don’t see the problem with just doing that in the same work that makes qemu actually use this flag, exactly because it’s just a -1/+1 change. I can send a v2, but should

Re: [PULL 00/38] Migration 20231016 patches

2023-10-17 Thread Thomas Huth
On 17/10/2023 09.24, Juan Quintela wrote: Stefan Hajnoczi wrote: On Mon, 16 Oct 2023 at 06:11, Juan Quintela wrote: The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56: Merge tag 'pull-riscv-to-apply-20231012-1' of https://github.com/alistair23/qemu into staging

[PULL 28/38] migration: check for rate_limit_max for RATE_LIMIT_DISABLED

2023-10-17 Thread Juan Quintela
From: Elena Ufimtseva In migration rate limiting atomic operations are used to read the rate limit variables and transferred bytes and they are expensive. Check first if rate_limit_max is equal to RATE_LIMIT_DISABLED and return false immediately if so. Note that with this patch we will also

[PULL 08/38] migration: Fix analyze-migration.py when ignore-shared is used

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The script is currently broken when the x-ignore-shared capability is used: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 656, in dump.read(dump_memory = args.memory) File "./scripts/analyze-migration.py", line 593, in read

[PULL 27/38] migration: Improve json and formatting

2023-10-17 Thread Juan Quintela
Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231013104736.31722-2-quint...@redhat.com> --- qapi/migration.json | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 360e609f66..db3df12d6c 100644

[PULL 20/38] qemu-file: Remove QEMUFileHooks

2023-10-17 Thread Juan Quintela
The only user was rdma, and its use is gone. Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-8-quint...@redhat.com> --- migration/qemu-file.h | 4 migration/qemu-file.c | 6 -- migration/rdma.c | 9 - 3 files

[PULL 22/38] migration/rdma: Remove qemu_ prefix from exported functions

2023-10-17 Thread Juan Quintela
Functions are long enough even without this. Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-10-quint...@redhat.com> --- migration/rdma.h | 12 ++-- migration/ram.c| 14 +++--- migration/rdma.c |

[PULL 21/38] migration/rdma: Move rdma constants from qemu-file.h to rdma.h

2023-10-17 Thread Juan Quintela
Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-9-quint...@redhat.com> --- migration/qemu-file.h | 17 - migration/rdma.h | 16 migration/ram.c | 2 +- 3 files changed, 17 insertions(+), 18

[PULL 17/38] migration/rdma: Remove all uses of RAM_CONTROL_HOOK

2023-10-17 Thread Juan Quintela
Instead of going through ram_control_load_hook(), call qemu_rdma_registration_handle() directly. Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-5-quint...@redhat.com> --- migration/qemu-file.h | 1 - migration/rdma.h | 3 +++ migration/ram.c

Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()

2023-10-17 Thread Kevin Wolf
Am 17.10.2023 um 07:19 hat Michael Tokarev geschrieben: > 05.09.2023 17:50, Kevin Wolf wrote: > > virtio_load() as a whole should run in coroutine context because it > > reads from the migration stream and we don't want this to block. > > > > However, it calls virtio_set_features_nocheck() and

Re: [PULL 1/1] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-17 Thread Fiona Ebner
Am 16.10.23 um 21:40 schrieb Stefan Hajnoczi: > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 39e7f23fab..c2d59389cb 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -1166,7 +1166,7 @@ static void virtio_blk_handle_output(VirtIODevice > *vdev, VirtQueue

Re: [PULL 1/1] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-17 Thread Kevin Wolf
Am 17.10.2023 um 11:01 hat Fiona Ebner geschrieben: > Am 16.10.23 um 21:40 schrieb Stefan Hajnoczi: > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > > index 39e7f23fab..c2d59389cb 100644 > > --- a/hw/block/virtio-blk.c > > +++ b/hw/block/virtio-blk.c > > @@ -1166,7 +1166,7 @@

Re: deadlock when using iothread during backup_clean()

2023-10-17 Thread Fiona Ebner
Am 06.10.23 um 14:18 schrieb Fiona Ebner: > Am 04.10.23 um 19:08 schrieb Vladimir Sementsov-Ogievskiy: >> On 28.09.23 11:06, Fiona Ebner wrote: >>> For fixing the backup cancel deadlock, I tried the following: >>> diff --git a/blockjob.c b/blockjob.c index 58c5d64539..fd6132ebfe 100644

[PATCH qemu v3 0/1] Elf2dmp: Conversion of conversions of malloc/calloc/free to g_malloc/g_new/g_free

2023-10-17 Thread ~h0lyalg0rithm
Remove NULL check for g_new changes Suraj Shirvankar (1): Switch memory management calls to new coding conventions contrib/elf2dmp/addrspace.c | 7 ++- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 7 ++- 4

[PATCH qemu v3 1/1] Switch memory management calls to new coding conventions

2023-10-17 Thread ~h0lyalg0rithm
From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 7 ++- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 7 ++- 4 files changed, 15 insertions(+), 21 deletions(-) diff

Re: [PATCH v26 01/21] qapi: machine.json: change docs regarding CPU topology

2023-10-17 Thread Thomas Huth
On 17/10/2023 11.40, Markus Armbruster wrote: Nina Schoetterl-Glausch writes: Clarify roles of different architectures. Also change things a bit in anticipation of additional members being added. Suggested-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine.json

Re: [PATCH v26 00/21] s390x: CPU Topology

2023-10-17 Thread Markus Armbruster
QAPI schema looks ready apart from the a few minor things in PATCH 01. Perhaps the maintainer could address them without a respin. Up to you guys. This was a long, hard push, but you persevered. Respect!

[PATCH] gtk: force realization of drawing area

2023-10-17 Thread marcandre . lureau
From: Marc-André Lureau Fixes the GL context creation from a widget that isn't yet realized (in a hidden tab for example). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1727 Signed-off-by: Marc-André Lureau --- ui/gtk.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: deadlock when using iothread during backup_clean()

2023-10-17 Thread Kevin Wolf
Am 17.10.2023 um 12:18 hat Fiona Ebner geschrieben: > Am 06.10.23 um 14:18 schrieb Fiona Ebner: > > Am 04.10.23 um 19:08 schrieb Vladimir Sementsov-Ogievskiy: > >> On 28.09.23 11:06, Fiona Ebner wrote: > >>> For fixing the backup cancel deadlock, I tried the following: > >>> > diff --git

[PATCH v4] virtio: add VIRTQUEUE_ERROR QAPI event

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dumps or do some other debugging - inform the user through a management API or UI, so that (s)he

Re: [PATCH 0/2] target/arm: Implement Neoverse-N2

2023-10-17 Thread Peter Maydell
Ping for code review -- Richard or Alex, maybe ? thanks -- PMM On Fri, 15 Sept 2023 at 19:54, Peter Maydell wrote: > > This patchset implements a model of the Neoverse-N2 CPU. > Because it's very similar to the Cortex-A710 we don't > need to implement any new features for it; but because it >

Re: [PATCH 4/6] hw/input/stellaris_gamepad: Remove StellarisGamepadButton struct

2023-10-17 Thread Peter Maydell
On Tue, 17 Oct 2023 at 13:44, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 17/10/23 14:23, Peter Maydell wrote: > > Currently for each button on the device we have a > > StellarisGamepadButton struct which has the irq, keycode and pressed > > state for it. When we convert to qdev, the qdev

Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()

2023-10-17 Thread Juan Quintela
Michael Tokarev wrote: > 05.09.2023 17:50, Kevin Wolf wrote: >> virtio_load() as a whole should run in coroutine context because it >> reads from the migration stream and we don't want this to block. >> However, it calls virtio_set_features_nocheck() and devices don't >> expect their

[PATCH] ARM: Use normal types

2023-10-17 Thread Juan Quintela
A bit of history from Warner: This has been that way the bsd-user sources were reorganized in 2015. I can find no good reason in the FreeBSD sources to do this (we've been transitioning from the pre-standardized BSD convention of u_intXX_t -> uintXX_t for 25 years now it seems). I don't see any

Re: [PATCH 1/2] target/arm: Correct minor errors in Cortex-A710 definition

2023-10-17 Thread Alex Bennée
Peter Maydell writes: > Correct a couple of minor errors in the Cortex-A710 definition: > * ID_AA64DFR0_EL1.DebugVer is 9 (indicating Armv8.4 debug architecture) > * ID_AA64ISAR1_EL1.APA is 5 (indicating more PAuth support) > * there is an IMPDEF CPUCFR_EL1, like that on the Neoverse-N1 > >

[PATCH 6/6] docs/migration: Add the dirty limit section

2023-10-17 Thread Hyman Huang
The dirty limit feature has been introduced since the 8.1 QEMU release but has not reflected in the document, add a section for that. Signed-off-by: Hyman Huang --- docs/devel/migration.rst | 71 1 file changed, 71 insertions(+) diff --git

[PATCH 3/6] tests: Add migration dirty-limit capability test

2023-10-17 Thread Hyman Huang
Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The test case does the

[PATCH 1/6] system/dirtylimit: Fix a race situation

2023-10-17 Thread Hyman Huang
Fix a race situation for global variable dirtylimit_state. Also, replace usleep by g_usleep to increase platform accessibility to the sleep function. Signed-off-by: Hyman Huang --- system/dirtylimit.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

[PATCH 0/6] dirtylimit: miscellaneous patches

2023-10-17 Thread Hyman Huang
This is a miscellaneous patchset for dirtylimit that contains the following parts: 1. dirtylimit module: fix for a race situation and replace usleep by g_usleep. 2. migration test: add dirtylimit test case. 3. guestperf for migration: add support for dirtylimit migration. 4. docs for

<    1   2   3   4   5   6   >