Re: [Qemu-devel] OpenBSD progress.. available for testing

2009-12-15 Thread Todd T. Fries
Penned by Todd T. Fries on 20091216 1:15.06, we have: | For anyone lurking wanting a newer port of qemu to OpenBSD, I've determined | that -O0 is required for cpu-exec.o and suddely things start working! | | Will try to determine why while updating other diffs to current qemu perhaps | in time fo

[Qemu-devel] OpenBSD progress.. available for testing

2009-12-15 Thread Todd T. Fries
For anyone lurking wanting a newer port of qemu to OpenBSD, I've determined that -O0 is required for cpu-exec.o and suddely things start working! Will try to determine why while updating other diffs to current qemu perhaps in time for the 0.12.0 release, but at least finally I can run the 0.12.0rc

Re: [Qemu-devel] [PATCH] experimental sh4 host support V2

2009-12-15 Thread Paul Mundt
On Wed, Dec 02, 2009 at 09:36:58AM +0100, Aurelien Jarno wrote: > On Sun, Nov 15, 2009 at 08:53:55PM +0900, Magnus Damm wrote: > > This is V2 of the QEMU sh4 host support patch. > > > > The code is of a somewhat experimental nature, which means that > > only the bare essentials are in place. The s

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Kevin O'Connor
On Tue, Dec 15, 2009 at 03:41:02PM -0600, Anthony Liguori wrote: > SeaBIOS can also load roms from up to two fixed physical addresses (when > !CONFIG_OPTIONROMS_DEPLOYED) or from a CBFS payload. The support for loading of two static option roms wont work well for qemu - it requires compiling in

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Kevin O'Connor
On Tue, Dec 15, 2009 at 10:24:29PM +0100, Sebastian Herbszt wrote: > Keep loading custom roms (e.g. from -option-rom) with rom_add_file > starting at 0xc8000. Modify SeaBIOS to scan the memory range for > pre-deployed option roms before deploying PCI roms. SeaBIOS will > find the last pre-deployed

Re: [SeaBIOS] Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Kevin O'Connor
On Tue, Dec 15, 2009 at 06:41:33PM -0600, Anthony Liguori wrote: > Kevin OConnor wrote: >> SeaBIOS is currently using over 64K of space. So, it is extending >> into the e-segment and thus needs to have the e-segment copied >> properly (I missed that in my earlier email). > > Okay. So I assume thi

Re: [Qemu-devel] [ANNOUNCE][Call-For-Testing] Release 0.12.0-rc1 of QEMU

2009-12-15 Thread Ryan Harper
* Anthony Liguori [2009-12-14 08:33]: > The QEMU team is pleased to announce the availability of the 0.12.0-rc2 > release. This is the second release candidate for the 0.12.0 release. > This release is not intended for production use. > > Testing release candidates is a great way to contribute t

Re: [Qemu-devel] Networking hangs

2009-12-15 Thread Scott Tsai
On Fri, Dec 4, 2009 at 8:55 AM, Christoffer Dall wrote: > I tried to verify if the bug existed with Realview, but I just can't get the > guest to mount an sd-card, which I created with qemu-img and copied a roots > onto there and the guest kernel cannot be configured with PCI/SCSI support > for th

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: BTW, I'm pretty sure this style of option rom loading (from a PCI device) is going to be required for device passthrough if we want to support running those roms in the guests. I think so too. In fact, it should

[Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register

2009-12-15 Thread Jan Kiszka
TeLeMan wrote: >> Now to the content: env already equals single_cpu_env, so there is no >> need in writing it back. That's because break/watchpoints are triggered >> synchronously over the context in which they may raise an exception as >> result. > env in op_help.c is asm(AREG0) not single_cpu_env

Re: [SeaBIOS] Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Kevin OConnor wrote: On Tue, Dec 15, 2009 at 12:35 PM, Anthony Liguori mailto:anth...@codemonkey.ws>> wrote: Avi Kivity wrote: bochs bios required all 128kB, so this is probably a leftover. This is apparently well defined in the PIIX spec. There is a bit of a difference

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: > BTW, I'm pretty sure this style of option rom loading (from a PCI > device) is going to be required for device passthrough if we want to > support running those roms in the guests. I think so too. > In fact, it should Just > Work with my patches

[Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register

2009-12-15 Thread TeLeMan
> Now to the content: env already equals single_cpu_env, so there is no > need in writing it back. That's because break/watchpoints are triggered > synchronously over the context in which they may raise an exception as > result. env in op_help.c is asm(AREG0) not single_cpu_env. Did you test your c

Re: [SeaBIOS] Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Kevin OConnor
On Tue, Dec 15, 2009 at 12:35 PM, Anthony Liguori wrote: > Avi Kivity wrote: > >> bochs bios required all 128kB, so this is probably a leftover. >> > > This is apparently well defined in the PIIX spec. There is a bit of a > difference between the lower half and upper half of the BIOS region thoug

[Qemu-devel] Re: i386 emulation bug: mov reg, [addr]

2009-12-15 Thread Paolo Bonzini
On 12/15/2009 10:26 PM, Jamie Lokier wrote: But that said, I'm not sure if this line from earlier breaks the test: index = ((code>> 3)& 7) | REX_X(s); When is REX_X(s) not zero, and does it break the index != 4 test? When %r12 (4+8=12) is used as an index. That's a valid state

Re: [Qemu-devel] [PATCH VERSION 3] Disk image exclusive and shared locks.

2009-12-15 Thread Jamie Lokier
Jamie Lokier wrote: > > At Kevin Wolf's suggestion, > > lock=exclusive|shared => all backing disks are locked shared > > lock=none => no locks are acquired on any front or back disks > > What do you recommend when backing disks are shared? Please ignore that part of my reply. It was meant to be

[Qemu-devel] Re: [FOR 0.12][PATCH] target-i386: Fix evaluation of DR7 register

2009-12-15 Thread Jan Kiszka
TeLeMan wrote: > raise_exception() in op_helper.c should not be used outside > op_helper.c because of tcg. This patch uses raise_exception2() instead > of raise_exception(). Please do not post new patches as reply to others if they are not directly related. Please do not attach patches and do not

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Sebastian Herbszt
Anthony Liguori wrote: Michael S. Tsirkin wrote: I think it's stable-0.12 material because it's badly broken right now I thought the rule was no guest visible changes in stable series? Yeah, good point, so we need to figure out something for 0.12.0. Sebastian's suggestion of loadin

Re: [Qemu-devel] Adding support for Mac OS X ppc64 host

2009-12-15 Thread Andreas Färber
Am 15.12.2009 um 18:00 schrieb malc: On Fri, 11 Dec 2009, Andreas F?rber wrote: I've tried Debian 4.0r4a ppc netinst CD on Linux/ppc64 and spotted [...] deviations: ppc64 qemu-system-ppc segfaults after "returning from prom_init". Should be fixed by 591d6f1dfdb60ab0a4cc487cd5781fa799dcac

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Michael S. Tsirkin wrote: I think it's stable-0.12 material because it's badly broken right now I thought the rule was no guest visible changes in stable series? Yeah, good point, so we need to figure out something for 0.12.0. Sebastian's suggestion of loading roms from 0xc firs

Re: [Qemu-devel] i386 emulation bug: mov reg, [addr]

2009-12-15 Thread malc
On Tue, 15 Dec 2009, Jamie Lokier wrote: > Clemens Kolbitsch wrote: > > /* XXX: index == 4 is always invalid */ > > if (havesib && (index != 4 || scale != 0)) { > > #ifdef TARGET_X86_64 > > if (s->aflag == 2) { > > gen_op_addq_A0_reg_sN(scale, index); >

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-15 Thread Stefan Weil
Jamie Lokier schrieb: > Stefan Weil wrote: > >> So here are my suggestions: >> >> read_write=rw >> read_write=ro >> read_write=rw-ro >> >> or >> >> access=rw >> access=ro >> access=rw-ro >> > > Mine: > > access=rw > access=ro > access=auto (default) > > -- Jamie Looks good. Best suggestio

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 03:57:30PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >>> Heh, this is going to be really broken with my patches :-) >>> >>> We're during qemu_ram_alloc() and we currently don't have a means to >>> associate ram with anything meaningful. This means that if

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Sebastian Herbszt wrote: What about isapc? Or (pci)pc with isa card? I'm not sure how the bios enumerates isa option roms on bare metal. That said, I don't know that it's all that important to support -option-rom, -kernel, or extboot on isapc. The isa version of cirrus-vga will still load

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Michael S. Tsirkin wrote: Heh, this is going to be really broken with my patches :-) We're during qemu_ram_alloc() and we currently don't have a means to associate ram with anything meaningful. This means that if you hot plug on two ends in different orders (even with fixed slots), the retu

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 03:45:24PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> On Tue, Dec 15, 2009 at 01:21:38PM -0600, Anthony Liguori wrote: >> >>> Gerd Hoffmann wrote: >>> On 12/15/09 03:37, Anthony Liguori wrote: > Okay, I think I've figured out ho

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Michael S. Tsirkin wrote: On Tue, Dec 15, 2009 at 01:21:38PM -0600, Anthony Liguori wrote: Gerd Hoffmann wrote: On 12/15/09 03:37, Anthony Liguori wrote: Okay, I think I've figured out how this is supposed to work. With these two patches to SeaBIOS and the patch to qemu, I can r

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Michael S. Tsirkin wrote: On Tue, Dec 15, 2009 at 01:35:52PM -0600, Anthony Liguori wrote: Gerd Hoffmann wrote: -kernel didn't work on a quick test. Thinking about how to fix this, we have two options. Hmm, can you pls explain why it stops working? Sure. SeaBIOS loa

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Sebastian Herbszt
Anthony Liguori wrote: Sebastian Herbszt wrote: Anthony Liguori wrote: Gerd Hoffmann wrote: I'm more worried about the CONFIG_OPTIONROMS_DEPLOYED patches for seabios, although I don't fully understand what they are doing. There are non-pci option roms (linuxboot, multiboot, extboot) which q

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Sebastian Herbszt wrote: Anthony Liguori wrote: Gerd Hoffmann wrote: I'm more worried about the CONFIG_OPTIONROMS_DEPLOYED patches for seabios, although I don't fully understand what they are doing. There are non-pci option roms (linuxboot, multiboot, extboot) which qemu will continue to dep

Re: [Qemu-devel] i386 emulation bug: mov reg, [addr]

2009-12-15 Thread Jamie Lokier
Clemens Kolbitsch wrote: > /* XXX: index == 4 is always invalid */ > if (havesib && (index != 4 || scale != 0)) { > #ifdef TARGET_X86_64 > if (s->aflag == 2) { > gen_op_addq_A0_reg_sN(scale, index); > } else > #endif > { >

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Sebastian Herbszt
Anthony Liguori wrote: Gerd Hoffmann wrote: I'm more worried about the CONFIG_OPTIONROMS_DEPLOYED patches for seabios, although I don't fully understand what they are doing. There are non-pci option roms (linuxboot, multiboot, extboot) which qemu will continue to deploy the way roms are deplo

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 01:21:38PM -0600, Anthony Liguori wrote: > Gerd Hoffmann wrote: >> On 12/15/09 03:37, Anthony Liguori wrote: >>> Okay, I think I've figured out how this is supposed to work. With these >>> two patches to SeaBIOS and the patch to qemu, I can run: >>> >>> qemu -net nic,model=r

Re: [Qemu-devel] i386 emulation bug: mov reg, [addr]

2009-12-15 Thread Jamie Lokier
Avi Kivity wrote: > On 12/15/2009 08:48 PM, Clemens Kolbitsch wrote: > >Hi list, > > > >I'm experiencing a strange emulation bug with the op-code below. The > >instruction raises a segfault in the application (running on the guest), > >however, if I enable KVM to run the exact same application, no

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 01:35:52PM -0600, Anthony Liguori wrote: > Gerd Hoffmann wrote: >> -kernel didn't work on a quick test. > > Thinking about how to fix this, we have two options. Hmm, can you pls explain why it stops working? > The first would be > to use the support in SeaBIOS for static

[Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie

2009-12-15 Thread Juan Quintela
"Kirill A. Shutemov" wrote: > Please, apply it. > > On Tue, Dec 15, 2009 at 3:10 AM, Kirill A. Shutemov > wrote: >> We really need compile _all_ sources for user target with -fpie when >> use --enable-user-pie. >> >> It's regression introduced by commit add16157d72454. >> Please, do not break it

Re: [Qemu-devel] i386 emulation bug: mov reg, [addr]

2009-12-15 Thread Avi Kivity
On 12/15/2009 08:48 PM, Clemens Kolbitsch wrote: Hi list, I'm experiencing a strange emulation bug with the op-code below. The instruction raises a segfault in the application (running on the guest), however, if I enable KVM to run the exact same application, no segfault is raised. 0x0080023b:

[Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie

2009-12-15 Thread Kirill A. Shutemov
Please, apply it. On Tue, Dec 15, 2009 at 3:10 AM, Kirill A. Shutemov wrote: > We really need compile _all_ sources for user target with -fpie when > use --enable-user-pie. > > It's regression introduced by commit add16157d72454. > Please, do not break it any more. > > Signed-off-by: Kirill A. Sh

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Gerd Hoffmann wrote: -kernel didn't work on a quick test. Thinking about how to fix this, we have two options. The first would be to use the support in SeaBIOS for static roms but that would limit us to two user supplied option roms (including kernel/multiboot/extboot). We could extend thi

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Gerd Hoffmann wrote: On 12/15/09 03:37, Anthony Liguori wrote: Okay, I think I've figured out how this is supposed to work. With these two patches to SeaBIOS and the patch to qemu, I can run: qemu -net nic,model=rtl8139 -net nic,model=virtio -net nic,model=e1000 -boot menu=on And all three opt

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Gerd Hoffmann wrote: Hi, We could also add a "romfile" property to the pci bus and do everything (except setting the default filename) in generic pci code. Patch attached (incremental to yours). Sounds great, but no patch is attached. Regards, Anthony Liguori

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Anthony Liguori wrote: Michael S. Tsirkin wrote: From a quick overview, I see register memory but no unregister? There's no cpu_unregister_physical_memory() in qemu. Devices can unregister an io memory type but this is not io memory, this is ram. We should qemu_ram_free() though. Exce

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Michael S. Tsirkin wrote: From a quick overview, I see register memory but no unregister? There's no cpu_unregister_physical_memory() in qemu. Devices can unregister an io memory type but this is not io memory, this is ram. We should qemu_ram_free() though. Regards, Anthony Liguori

[Qemu-devel] i386 emulation bug: mov reg, [addr]

2009-12-15 Thread Clemens Kolbitsch
Hi list, I'm experiencing a strange emulation bug with the op-code below. The instruction raises a segfault in the application (running on the guest), however, if I enable KVM to run the exact same application, no segfault is raised. 0x0080023b: 8b 04 65 11 22 33 44mov regEAX, [0x443

Re: [Qemu-devel] [PATCH VERSION 3] Disk image exclusive and shared locks.

2009-12-15 Thread Anthony Liguori
Richard W.M. Jones wrote: Thanks for looking at this. Thanks for following up :-) The use case is "cluster filesystem with an admin tool that must be run exclusively". Cluster nodes open the block device for write, but with a shared lock. The admin tool needs exclusive access (no nodes m

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-15 Thread Jamie Lokier
Stefan Weil wrote: > So here are my suggestions: > > read_write=rw > read_write=ro > read_write=rw-ro > > or > > access=rw > access=ro > access=rw-ro Mine: access=rw access=ro access=auto (default) -- Jamie

Re: [Qemu-devel] [PATCH VERSION 3] Disk image exclusive and shared locks.

2009-12-15 Thread Jamie Lokier
Richard W.M. Jones wrote: > This is v3 of the lock patch, previously discussed here: > > http://lists.gnu.org/archive/html/qemu-devel/2009-12/threads.html#00461 > > In this version I've reverted back to the simpler interface. There is > now only one "lock" option, which can be lock=exclusive|sha

Re: [Qemu-devel] Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-15 Thread Luiz Capitulino
On Tue, 15 Dec 2009 15:41:33 +0100 Gerd Hoffmann wrote: > > >> 2.) If you specify an USB device at the command line like -usbdevice > >> host:0421:00ab and the device is not available (not plugged-in) when you > >> start the guest, qemu segfaults. > > > > Haven't heard this one yet. I'm assuming

Re: [Qemu-devel] [PATCH VERSION 3] Disk image exclusive and shared locks.

2009-12-15 Thread Richard W.M. Jones
On Tue, Dec 15, 2009 at 12:02:04PM -0600, Anthony Liguori wrote: > Richard W.M. Jones wrote: >> This is v3 of the lock patch, previously discussed here: >> >> http://lists.gnu.org/archive/html/qemu-devel/2009-12/threads.html#00461 >> >> In this version I've reverted back to the simpler interface.

Re: [Qemu-devel] [PATCH VERSION 3] Disk image exclusive and shared locks.

2009-12-15 Thread Anthony Liguori
Richard W.M. Jones wrote: This is v3 of the lock patch, previously discussed here: http://lists.gnu.org/archive/html/qemu-devel/2009-12/threads.html#00461 In this version I've reverted back to the simpler interface. There is now only one "lock" option, which can be lock=exclusive|shared|none.

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 11:37:34AM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> I don't think it does: cpuid is an unpriveledged operation, >> is it not? >> > > We (qemu) ask the kernel (kvm.ko) to filter out the features bits from > the cpuid we expose to the guest in order to

Re: [Qemu-devel] [PATCH] A different way to ask for readonly drive

2009-12-15 Thread Kevin Wolf
Am 14.12.2009 14:35, schrieb Naphtali Sprei: > Hi, > After feedback from Red Hat guys, I've decided to slightly modify the > approach to drive's readonly. > The new approach also addresses the silent fall-back to open the drives' file > as read-only when read-write fails > (permission denied) tha

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-15 Thread Anthony Liguori
Michael S. Tsirkin wrote: I don't think it does: cpuid is an unpriveledged operation, is it not? We (qemu) ask the kernel (kvm.ko) to filter out the features bits from the cpuid we expose to the guest in order to remove feature bits it (kvm.ko) does not support. Regards, Anthony Liguori

Re: [SeaBIOS] Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Avi Kivity wrote: On 12/15/2009 04:20 PM, Anthony Liguori wrote: Anthony Liguori wrote: The bios gets mapped in 0xe .. 0x10 so if SeaBIOS fills the 0xc-0xf space it will write over half of the bios. I'm a little confused by this. SeaBIOS seems to assume that it only has to

Re: [Qemu-devel] target-alpha: An approach to fp insn qualifiers

2009-12-15 Thread Vince Weaver
On Mon, 14 Dec 2009, Richard Henderson wrote: > On 12/14/2009 04:31 PM, Richard Henderson wrote: > > Hmph. One more patch for correctness. With this 183.equake runs correctly. > I couldn't remember all the hoops to get runspec.pl to work, to do the whole > testsuite, but I did run this one by h

[Qemu-devel] [PATCH, RFC] Allow adding empty SCSI controllers

2009-12-15 Thread Wolfgang Mauerer
Hi Gerd, in commit 5b684b5a56e81f6f, you introduced an explicit check to prevent adding SCSI controllers without attached disks to the system. Is there any other method to introduce disk-less controllers into the system? If not, I'd suggest to remove the check (patch is attached) -- there are some

Re: [Qemu-devel] Adding support for Mac OS X ppc64 host

2009-12-15 Thread malc
On Fri, 11 Dec 2009, Andreas F?rber wrote: > > Am 06.12.2009 um 07:37 schrieb malc: > > > will try system-ppc later.. > > I've tried Debian 4.0r4a ppc netinst CD on Linux/ppc64 and spotted different > but similar deviations: > > ppc64 qemu-system-ppc segfaults after "returning from prom_init".

[Qemu-devel] [PATCH VERSION 3] Disk image exclusive and shared locks.

2009-12-15 Thread Richard W.M. Jones
This is v3 of the lock patch, previously discussed here: http://lists.gnu.org/archive/html/qemu-devel/2009-12/threads.html#00461 In this version I've reverted back to the simpler interface. There is now only one "lock" option, which can be lock=exclusive|shared|none. At Kevin Wolf's suggestion,

Re: [Qemu-devel] target-alpha: An approach to fp insn qualifiers

2009-12-15 Thread Richard Henderson
On 12/15/2009 03:31 AM, Laurent Desnogues wrote: Well equake works me with the last set of patches you sent (that is without using this FPU patch you just sent). Can you confirm? GCC testsuite breaks with the saturating cvttq so I didn't even try. If equake works, it just means that it doesn't

[Qemu-devel] Re: [PATCH] eepro100: Better documentation for temporary data

2009-12-15 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 10:25:34AM +0100, Stefan Weil wrote: > Michael S. Tsirkin suggested more documentation for > two temporary status values. Well, here it is. > > Signed-off-by: Stefan Weil Looks good to me. > --- > hw/eepro100.c |7 --- > 1 files changed, 4 insertions(+), 3 delet

[Qemu-devel] Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-15 Thread Dustin Kirkland
On Tue, 2009-12-15 at 11:10 +0200, Avi Kivity wrote: > Well, binaries are shipped, but I guess you'd like to build from source. Right, sorry I was ambiguous. > We have several options: ... > - fetch the submodules and include them in the tarball ... I think this option would help keep us all on

[Qemu-devel] [PATCH] fdc: fix drive property handling.

2009-12-15 Thread Gerd Hoffmann
Fix the floppy controller init wrappers to set the drive properties only in case the DriveInfo pointers passed in are non NULL. This allows to set the properties using -global. Signed-off-by: Gerd Hoffmann --- hw/fdc.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) d

[Qemu-devel] Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-15 Thread Gerd Hoffmann
2.) If you specify an USB device at the command line like -usbdevice host:0421:00ab and the device is not available (not plugged-in) when you start the guest, qemu segfaults. Haven't heard this one yet. I'm assuming it's a qdev interaction. No. It is monitor_printf(NULL, ... Patch adding c

Re: [SeaBIOS] Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Avi Kivity
On 12/15/2009 04:20 PM, Anthony Liguori wrote: Anthony Liguori wrote: The bios gets mapped in 0xe .. 0x10 so if SeaBIOS fills the 0xc-0xf space it will write over half of the bios. I'm a little confused by this. SeaBIOS seems to assume that it only has to deal with the 0xf0

[Qemu-devel] Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-15 Thread Anthony Liguori
Ingmar Schraub wrote: Hi, after upgrading from qemu-kvm-0.11.1 to qemu-kvm-0.12.0-rc2 I noticed two immediate problems on two different hosts: 1.) The e1000 driver doesn't work anymore. The Guest OS detects it (tested with Ubuntu Karmic 64-Bit and Windows 7 64 Bit), but it doesn't work. DHCP do

[Qemu-devel] Re: Bug in Sparc64/IDE Code

2009-12-15 Thread Nick Couchman
Did these patches ever get committed to the Qemu repo? I tried applying them to the latest git repo, and they don't apply. Furthermore, building qemu out of the latest version of the repository causes very similar messages, just a few more of them. OpenBIOS for Sparc64 Configuration device id QE

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2009-12-15 Thread Michael S. Tsirkin
On Mon, Dec 14, 2009 at 03:49:39PM -0600, Anthony Liguori wrote: > Michael S. Tsirkin wrote: >> On Mon, Dec 14, 2009 at 02:54:49PM -0600, Anthony Liguori wrote: >> >>> Michael S. Tsirkin wrote: >>> On Mon, Dec 14, 2009 at 02:18:33PM -0600, Anthony Liguori wrote: > Mic

[Qemu-devel] Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-15 Thread Anthony Liguori
Avi Kivity wrote: On 12/14/2009 11:58 PM, Dustin Kirkland wrote: I'm working on the packaging updates for Ubuntu Lucid, and I'm having trouble with the BIOS bits of qemu-kvm. It seems that a fair amount of the BIOS submodules are missing. The roms/ tree is basically empty. Well, binari

Re: [Qemu-devel] Re: [ANNOUNCE] qemu-kvm-0.12.0-rc2 released

2009-12-15 Thread Lennart Sorensen
On Tue, Dec 15, 2009 at 11:10:54AM +0200, Avi Kivity wrote: > Well, binaries are shipped, but I guess you'd like to build from source. > > We have several options: > > - do nothing > - ship a generated SOURCES file which contains git URLs and commit > hashes, rely on the interested user to fetch

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Anthony Liguori wrote: The bios gets mapped in 0xe .. 0x10 so if SeaBIOS fills the 0xc-0xf space it will write over half of the bios. I'm a little confused by this. SeaBIOS seems to assume that it only has to deal with the 0xf .. 0x10 space as the bios which is cert

[Qemu-devel] Re: [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-15 Thread Jan Kiszka
Luiz Capitulino wrote: > On Tue, 15 Dec 2009 10:54:23 +0100 > Markus Armbruster wrote: > >> Markus Armbruster writes: >> >>> Luiz Capitulino writes: >>> The monitor_read_command() function is readline specific and should only be used when readline is available. Signed-off-by

Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 15 Dec 2009 10:54:23 +0100 > Markus Armbruster wrote: > >> Markus Armbruster writes: >> >> > Luiz Capitulino writes: >> > >> >> The monitor_read_command() function is readline specific >> >> and should only be used when readline is available. >> >> >> >> Sign

Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor

2009-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 15 Dec 2009 10:42:46 +0100 > Markus Armbruster wrote: > >> Before the code motion, we throw QERR_UNDEFINED_ERROR on >> monitor_vprintf(NULL, ...). Afterwards, we don't. Could you explain >> why that's okay? > > We never did that. A call like that will just se

[Qemu-devel] [PATCH] target-mips: 4Kc, 4KEc cores do not support MIPS16

2009-12-15 Thread Stefan Weil
4Kc, 4KEc cores do not support MIPS16, so not only the CP0_Config1 had to be fixed (see previous patch), but also MIPS16 instructions must not be executed. (Hint from Nathan Froyd, thanks). Signed-off-by: Stefan Weil --- target-mips/translate_init.c |6 +++--- 1 files changed, 3 insertions(

[Qemu-devel] [PATCH 2/2] fdc: fix migration from 0.11

2009-12-15 Thread Juan Quintela
0.11 uses as instance ide io_base, get it back Signed-off-by: Juan Quintela --- hw/fdc.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 1352dc4..0579b03 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1907,7 +1907,7 @@ fdctrl_t *sun4m_fdctr

[Qemu-devel] [PATCH 1/2] Revert "fdc: fix vmstate variable passed"

2009-12-15 Thread Juan Quintela
Floppy used the io_base address to register savevm region. This reverts commit 2966b390d0f7cd5e5b971290fcc20685de374228. Signed-off-by: Juan Quintela --- hw/fdc.c | 33 - 1 files changed, 4 insertions(+), 29 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index

[Qemu-devel] [PATCH 0/2] fdc: fix migration from 0.11

2009-12-15 Thread Juan Quintela
Hi fdc in 0.11 used io_base as instance id. Revert the part that changed the io_base to one instance_id of -1. This makes migration from 0.11 -> 0.12 to not fail. I still have to fix the problem with clock (since -rtc clock=host is default, migration from older qemu's don't work well). Later,

Re: [Qemu-devel] [PATCH] mips: No MIPS16 support for 4Kc, 4KEc cores

2009-12-15 Thread Nathan Froyd
On Tue, Dec 15, 2009 at 02:03:03PM +0100, Stefan Weil wrote: > Fix regression introduced by d19954f46dfc262612c30e9534e660e953049487. > > 4Kc and 4KEc don't support MIPS16. Nice catch. Can you please also remove ASE_MIPS16 from .insn_flags for those same CPUs, then? Thanks, -Nathan

Re: [Qemu-devel] Re: Spice project is now open

2009-12-15 Thread Soeren Sandmann
Anthony Liguori writes: > So that's what I'm trying to understand. How far does the guest's > visibility go? Is the guest totally ignorant of anything other than > QXL? If so, that's good, and I'm very happy about it :-) The guest only sees a QXL video device. This video device accepts comman

Re: [Qemu-devel] approaches to 3D virtualisation

2009-12-15 Thread Avi Kivity
On 12/14/2009 02:03 PM, Paul Brook wrote: [3] Obviously if you emulate lame hardware like ne2k or IDE then performance will suck. However emulation of a high-end NIC of SCSI HBA should get within spitting distance of virtio. Practically the only difference performance-wise between virtio a

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Gerd Hoffmann wrote: On 12/15/09 03:37, Anthony Liguori wrote: Okay, I think I've figured out how this is supposed to work. With these two patches to SeaBIOS and the patch to qemu, I can run: qemu -net nic,model=rtl8139 -net nic,model=virtio -net nic,model=e1000 -boot menu=on And all three opt

Re: Proper support for PCI-based option rom loading (was Re: [Qemu-devel] Re: qdev property bug?)

2009-12-15 Thread Anthony Liguori
Kevin O'Connor wrote: On Mon, Dec 14, 2009 at 08:37:44PM -0600, Anthony Liguori wrote: Okay, I think I've figured out how this is supposed to work. With these two patches to SeaBIOS and the patch to qemu, I can run: I'm not sure why "Do not guard qemu shadow ram work around in CONFIG

[Qemu-devel] [PATCH] mips: No MIPS16 support for 4Kc, 4KEc cores

2009-12-15 Thread Stefan Weil
Fix regression introduced by d19954f46dfc262612c30e9534e660e953049487. 4Kc and 4KEc don't support MIPS16. Signed-off-by: Stefan Weil --- target-mips/translate_init.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translat

[Qemu-devel] [PULL] stable-0.12: pci fix

2009-12-15 Thread Michael S. Tsirkin
The following pci fix is a must on stable-0.12 now that we are not ignoring interrupt disable bit. Even if we do, it is cleaner to have PCI STATUS correct. The following changes since commit 910628f39676ee65211727245809eec7ca4d75f5: Andre Przywara (1): target-i386: Update CPUID feature s

Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

2009-12-15 Thread Luiz Capitulino
On Tue, 15 Dec 2009 10:54:23 +0100 Markus Armbruster wrote: > Markus Armbruster writes: > > > Luiz Capitulino writes: > > > >> The monitor_read_command() function is readline specific > >> and should only be used when readline is available. > >> > >> Signed-off-by: Luiz Capitulino > > > > I f

[Qemu-devel] [PULL] master: pci fixes and cleanups

2009-12-15 Thread Michael S. Tsirkin
Please pull the following into master branch. Pull request for stable-0.12 will follow. There's an important bugfix, the rest are trivial. Have not been out a lot of time, but keeping them out of master adds conflicts. The following changes since commit d9a50a366f2178a4ddaada87bcf67764c9d0af87:

Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor

2009-12-15 Thread Luiz Capitulino
On Tue, 15 Dec 2009 10:42:46 +0100 Markus Armbruster wrote: > Before the code motion, we throw QERR_UNDEFINED_ERROR on > monitor_vprintf(NULL, ...). Afterwards, we don't. Could you explain > why that's okay? We never did that. A call like that will just segfault QEMU w/o this fix.

Re: [Qemu-devel] [PATCH] target-alpha: Fix compiler warning for gcc-4.3 (and older)

2009-12-15 Thread Laurent Desnogues
On Mon, Dec 14, 2009 at 10:54 AM, Stefan Weil wrote: > "Old" compilers obviously are not able to recognise > that all cases are handled here: > > qemu/target-alpha/helper.c:70: error: ‘round_mode’ may be used uninitialized > in this function > > A small modification helps the compiler to do its j

[Qemu-devel] Re: [PATCH V2 00/10] various pci clean ups.

2009-12-15 Thread Michael S. Tsirkin
On Tue, Dec 15, 2009 at 08:25:57PM +0900, Isaku Yamahata wrote: > This patch series is for various somewhat atrandom clean up. > > - the patch "piix_pci: define symbolic value for PAM0, PAM6 and SMRAM." > doesn't cause binary difference. > I checked the piix_pci.o binary doesn't changed with t

Re: [Qemu-devel] target-alpha: An approach to fp insn qualifiers

2009-12-15 Thread Laurent Desnogues
On Tue, Dec 15, 2009 at 4:50 AM, Richard Henderson wrote: > On 12/14/2009 04:31 PM, Richard Henderson wrote: >> >> On 12/14/2009 12:11 PM, Laurent Desnogues wrote: >>> >>> I'll take a closer look at your patch tomorrow. >> >> For the record, I believe this finishes what I had in mind for the >> ex

[Qemu-devel] [PATCH V2 10/10] piix_pci: add link to i440fx data sheet.

2009-12-15 Thread Isaku Yamahata
add link to i440fx data sheet. Signed-off-by: Isaku Yamahata --- hw/piix_pci.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 384d31c..cd12212 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -29,6 +29,11 @@ #include "isa.h" #i

[Qemu-devel] [PATCH V2 03/10] pci: import Linux pci_regs.h

2009-12-15 Thread Isaku Yamahata
Import Linux pci_regs.h. Later PCI register definitions in pci.h will be eliminated. Signed-off-by: Isaku Yamahata --- hw/pci_regs.h | 665 + 1 files changed, 665 insertions(+), 0 deletions(-) create mode 100644 hw/pci_regs.h diff --git

[Qemu-devel] [PATCH V2 08/10] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM.

2009-12-15 Thread Isaku Yamahata
Define symbolic value in i440fx configuration space for 0x59, 0x5f and 0x7f and use them. Signed-off-by: Isaku Yamahata --- hw/piix_pci.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 1b67475..0dae6f9 100644 --- a/hw

[Qemu-devel] [PATCH V2 01/10] pci: remove PCIBus::config_reg.

2009-12-15 Thread Isaku Yamahata
PCIBus::config_reg isn't used anymore, so remove it. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 404eead..aed3a24 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -40,7 +40,6 @@

[Qemu-devel] [PATCH V2 04/10] pci: use pci_regs.h

2009-12-15 Thread Isaku Yamahata
include pci_regs.h and remove duplicated defines. And remove unused PCI_REVISION and PCI_SUBDEVICE_ID. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.h | 77 ++--- 1 files changed, 3 insertions(+), 74 deletions(-)

[Qemu-devel] [PATCH V2 09/10] piix_pci: use range helper function

2009-12-15 Thread Isaku Yamahata
use range helper function in i440fx_write_config(). Signed-off-by: Isaku Yamahata --- hw/piix_pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 0dae6f9..384d31c 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -137,10 +137,10

[Qemu-devel] [PATCH V2 05/10] gt64xxx: remove gt64120_{read, write}_config().

2009-12-15 Thread Isaku Yamahata
They call only pci_default_{read, write}_config(). So they aren't necessary. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/gt64xxx.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c index fb7f5bd..c8034e2 10064

[Qemu-devel] [PATCH V2 07/10] msix: use range helper function.

2009-12-15 Thread Isaku Yamahata
use range helper function in msix_write_config(). Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/msix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 0baedef..2ca0900 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -175,7 +175

[Qemu-devel] [PATCH V2 02/10] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g

2009-12-15 Thread Isaku Yamahata
To match Linux PCI register definition, rename PCI_SUBVENDOR_ID to PCI_SUBSYSTEM_VENDOR_ID. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/pci.c |2 +- hw/pci.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index aed3a24..c4

[Qemu-devel] [PATCH V2 00/10] various pci clean ups.

2009-12-15 Thread Isaku Yamahata
This patch series is for various somewhat atrandom clean up. - the patch "piix_pci: define symbolic value for PAM0, PAM6 and SMRAM." doesn't cause binary difference. I checked the piix_pci.o binary doesn't changed with the patch applied or not by diffing results of disassembling object files

  1   2   >