Anthony Liguori anth...@codemonkey.ws writes:
On 01/11/2010 06:04 PM, Luiz Capitulino wrote:
[...]
3. We should add command(s) to enable/disable protocol features
4. Proper feature negotiation is done in pause mode. That's, clients
interested in enabling new protocol features should start
Luiz Capitulino lcapitul...@redhat.com writes:
On Tue, 29 Dec 2009 19:25:24 +
Nathan Baum nat...@parenthephobia.org.uk wrote:
On Tue, 2009-12-29 at 15:15 -0200, Luiz Capitulino wrote:
On Sat, 26 Dec 2009 21:19:22 +
Nathan Baum nat...@parenthephobia.org.uk wrote:
On 01/12/2010 09:23 AM, Gleb Natapov wrote:
On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote:
On 01/07/2010 10:24 AM, Gleb Natapov wrote:
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 4084503..6a841de 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@
On 01/11/2010 09:18 PM, Anthony Liguori wrote:
On 01/07/2010 10:24 AM, Gleb Natapov wrote:
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 4084503..6a841de 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -17,6 +17,7 @@
#includesys/mman.h
#includelinux/kvm.h
On 01/11/2010 08:40 PM, Anthony Liguori wrote:
Wouldn't it make more sense to try to use pkg-config always and if it's
not available, fall back on sdl-config?
That means we don't have a separate code path for cross compiling which
means it's less likely to break.
I certainly can make that, I
Introduce PCIAddress, PCIConfigAddress and helper functions.
They will be used later to clean up pci_data_{read, write}().
Cc: Alexander Graf ag...@suse.de
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h |7 +++
hw/pci_host.c | 32
Move out pci address decoding logic from pci_data_{write, read}()
by making pci_data_{write, read}() get PCIConfigAddress.
Cc: Blue Swirl blauwir...@gmail.com
Cc: Aurelien Jarno aurel...@aurel32.net
Cc: Paul Brook p...@codesourcery.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Remove code duplication in pci_host_template.h
by using cpp trick.
Based on Alexander Graf patch.
Cc: Alexander Graf ag...@suse.de
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci_host.c |4 +-
hw/pci_host_template.h | 82
rename sh_pci_data_write to sh_pci_mem_write for consistency.
Later sh_pci_data_write will be introduced again, so this patch
is preliminary patch.
Cc: Takashi YOSHII takas...@ops.dti.ne.jp
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/sh_pci.c |8
1 files changed, 4
To use pci host framework, use PCIHostState instead of PCIBus in PCIVPBState.
Cc: Paul Brook p...@codesourcery.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/versatile_pci.c | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git
To use pci_host framework, use PCIHostState instead of PCIBus.
Cc: Takashi YOSHII takas...@ops.dti.ne.jp
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/sh_pci.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/sh_pci.c b/hw/sh_pci.c
index
On 01/12/2010 04:33 AM, Chris Wright wrote:
Please send in any agenda items you are interested in covering.
1) administrivia
2) qemu 0.13 kvm feature merge issues
3) vhost-net todo's
3.1) vhost-net dma engine integration
--
error compiling committee.c: too many arguments to function
On 12/24/2009 01:29 AM, Kevin O'Connor wrote:
On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote:
--- a/src/acpi.c
+++ b/src/acpi.c
@@ -464,10 +464,12 @@ build_ssdt(void)
// build processor scope header
*(ssdt_ptr++) = 0x10; // ScopeOp
if (cpu_length=
Am 11.01.2010 18:47, schrieb Christoph Hellwig:
On Mon, Jan 11, 2010 at 03:11:52PM +0100, Kevin Wolf wrote:
Ok, if you start talking about layering, we can have a fundamental
discussion on this topic and why the layering is broken anyway.
Logically, we have image formats like qcow2, VMDK and
On 12 janv. 2010, at 09:27, Liran Schour wrote:
Move to stage3 only when remaining work can be done below max downtime.
To make sure the process will converge we will try only MAX_DIRTY_ITERATIONS.
Signed-off-by: Liran Schour lir...@il.ibm.com
---
block-migration.c | 67
On Tue, Jan 12, 2010 at 05:52:57PM +0900, Isaku Yamahata wrote:
Introduce PCIAddress, PCIConfigAddress and helper functions.
They will be used later to clean up pci_data_{read, write}().
Cc: Alexander Graf ag...@suse.de
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h
On Tue, Jan 12, 2010 at 05:52:57PM +0900, Isaku Yamahata wrote:
Introduce PCIAddress, PCIConfigAddress and helper functions.
They will be used later to clean up pci_data_{read, write}().
Cc: Alexander Graf ag...@suse.de
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h
On Mon, Jan 11, 2010 at 01:30:19PM -0500, Cole Robinson wrote:
Current IDE floppy detection is hardcoded based on source file name.
Make this smarter by attempting a floppy specific ioctl.
IDE floppys show up as /dev/hd?, these are old legacy floppies.
Otherwise looks good except that I think
On Tue, Jan 12, 2010 at 05:52:52PM +0900, Isaku Yamahata wrote:
During reviewing Alexander's PPC patches, it proved that
pci_data_{read, write}() should take PCIConfigAddress as an argument.
this patch series is inspired by his patch and some of them
are based on it.
This patch would make
Am 11.01.2010 22:18, schrieb Stefan Weil:
The current names of GPXE romfiles are something like
pxe-e1000.bin, pxe-ne2k_pci.bin, pxe-rtl8139.bin.
This was adequate when these names were computed
by a simple rule using the device name.
Today, an ethernet device can be associated to any
On Tue, Jan 12, 2010 at 05:52:58PM +0900, Isaku Yamahata wrote:
Move out pci address decoding logic from pci_data_{write, read}()
by making pci_data_{write, read}() get PCIConfigAddress.
Cc: Blue Swirl blauwir...@gmail.com
Cc: Aurelien Jarno aurel...@aurel32.net
Cc: Paul Brook
On 12.01.2010, at 11:18, Michael S. Tsirkin wrote:
On Tue, Jan 12, 2010 at 05:52:52PM +0900, Isaku Yamahata wrote:
During reviewing Alexander's PPC patches, it proved that
pci_data_{read, write}() should take PCIConfigAddress as an argument.
this patch series is inspired by his patch and
On 05.01.2010, at 13:46, Isaku Yamahata wrote:
Basically it looks good.
Some minor comments below.
Although further clean up is possible,
this is first small step.
On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote:
Different host buses may have different layouts for
On 05.01.2010, at 23:16, Michael S. Tsirkin wrote:
On Mon, Jan 04, 2010 at 08:32:50AM +0100, Alexander Graf wrote:
+typedef void (*pci_config_reg_fn)(PCIHostState *s, uint32_t config_reg,
+ PCIConfigAddress *conf);
+
pci_decode_config_addr_fn would be a
On 12.01.2010, at 11:18, Michael S. Tsirkin wrote:
On Tue, Jan 12, 2010 at 05:52:52PM +0900, Isaku Yamahata wrote:
During reviewing Alexander's PPC patches, it proved that
pci_data_{read, write}() should take PCIConfigAddress as an argument.
this patch series is inspired by his patch and
On Tue, Jan 12, 2010 at 12:12:36PM +0200, Michael S. Tsirkin wrote:
On Tue, Jan 12, 2010 at 05:52:58PM +0900, Isaku Yamahata wrote:
diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c
index d99b7fa..14a728a 100644
--- a/hw/versatile_pci.c
+++ b/hw/versatile_pci.c
@@ -23,11 +23,29 @@
On Tue, Jan 12, 2010 at 11:36:58AM +0100, Alexander Graf wrote:
On 05.01.2010, at 13:46, Isaku Yamahata wrote:
Basically it looks good.
Some minor comments below.
Although further clean up is possible,
this is first small step.
On Mon, Jan 04, 2010 at 08:32:50AM +0100,
On Tue, 12 Jan 2010 09:25:05 +0100
Markus Armbruster arm...@redhat.com wrote:
We were considering something along these lines
but we didn't consider having the description as part of the dict,
for example.
We did, actually :)
That's good then!
This solves
Liran Schour wrote:
blk_mig_save_bulked_block is never called with sync flag. Remove the sync
flag. Calculate bulk completion during blk_mig_save_bulked_block.
Signed-off-by: Liran Schour lir...@il.ibm.com
---
block-migration.c | 63
Liran Schour wrote:
Move to stage3 only when remaining work can be done below max downtime.
To make sure the process will converge we will try only MAX_DIRTY_ITERATIONS.
OK, that explains now patch 2. But do we have such barrier for memory
migration as well? I don't thinks so, and I don't think
Liran Schour wrote:
This will manage dirty counter for each device and will allow to get the
dirty counter from above.
Signed-off-by: Liran Schour lir...@il.ibm.com
---
block.c | 20
block.h |1 +
block_int.h |1 +
3 files changed, 18
Liran Schour wrote:
Start transfer dirty blocks during the iterative stage. That will
reduce the time that the guest will be suspended
Signed-off-by: Liran Schour lir...@il.ibm.com
---
block-migration.c | 158
+++--
1 files changed, 116
Introduce the functions needed to change the backing file of an image. The
function is implemented for qcow2.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 20 +++
block.h |2 +
block/qcow2.c | 101 +
This patch series adds the functionality to change the backing file of existing
images. This includes simple renaming of a backing file without converting the
COW image as well as safe rebasing onto a different backing file that has some
changes compared to the current backing file.
v2:
- Added
If an image references a backing file that doesn't exist, qemu-img info fails
to open this image. Exactly in this case the info would be valuable, though:
the user might want to find out which file is missing.
This patch introduces a BDRV_O_NO_BACKING flag to ignore the backing file when
opening
This adds a rebase subcommand to qemu-img which allows to change the backing
file of an image.
In default mode, both the current and the new backing file need to exist, and
after the rebase, the COW image is guaranteed to have the same guest visible
content as before. To achieve this, old and new
Pierre Riteau pierre.rit...@irisa.fr wrote on 12/01/2010 11:52:18:
On 12 janv. 2010, at 09:27, Liran Schour wrote:
Move to stage3 only when remaining work can be done below max downtime.
To make sure the process will converge we will try only
MAX_DIRTY_ITERATIONS.
Signed-off-by: Liran
Our guest systems need to know by how much the timebase increases every second,
so there usually is a timebase-frequency property in the cpu leaf of the
device tree.
This property is missing in OpenBIOS.
With qemu, Linux's fallback timebase speed and qemu's internal timebase speed
match up. With
While trying to find the right channel number for the DBDMA emulation I
stumbled across segmentation faults that were purely triggered by the guest.
The guest should never have the possiblity to segfault us, so let's check
all indirect function calls on a channel, so the code even works for
I'm trying to get the PPC64 system emulation target working finally.
While doing so, I ran into several issues, all related to PCI this time.
This patchset fixes all the PCI config space access and PCI interrupt
mapping issues I've found on PPC64. Using this and a patched OpenBIOS
version, I can
Different host buses may have different layouts for config space accessors.
The Mac U3 for example uses the following define to access Type 0 (directly
attached) devices:
#define MACRISC_CFA0(devfn, off)\
((1 (unsigned int)PCI_SLOT(dev_fn)) \
| (((unsigned
Linux with CONFIG_PPC64 doesn't support ADB devices anymore, so we have to
use USB for keyboard and mouse.
This patch enables USB per default on U3 and adds a virtual keyboard and mouse
there.
Signed-off-by: Alexander Graf ag...@suse.de
---
hw/ppc_newworld.c | 12 +++-
1 files
The interrupt code as is didn't really work for me. I couldn't even convince
Linux to take interrupt 9 in an interrupt-map.
So let's do this right. Let's map all PCI interrupts to 0x1b - 0x1e. That way
we're at least a small step closer to what real hardware does.
I also took the interrupt pin
To ease debugging and to know what we're lacking, I found it really useful to
have an lspci dump of a real U3 based G5 around. So I added a comment for it.
If people don't think it's important enough to include this information in the
sources, just don't apply this patch.
Signed-off-by:
The Mac99 type so far defines a U2 based configuration. Unfortunately,
there have never been any U2 based PPC64 machines. That's what the U3 was
developed for.
So let's split the Mac99 machine in a PPC64 and a PPC32 machine. The PPC32
machine stays Mac99, while the PPC64 one becomes Mac99_U3. All
As stated in the previous patch, the Uninorth PCI bridge requires different
layouts in its PCI config space accessors.
This patch introduces a conversion function that makes it compatible with
the way Linux accesses it.
I also kept an OpenBIOS compatibility hack in. I think it'd be better to
Per default Linux doesn't come with a lot of storage adapters enabled on
Mac configurations. The one that's pretty much always present is the pmac-ide,
while the cmd64x is almost never included in any distribution.
So let's switch to use the MacIO based IDE controller. There is corresponding
On Mon, 11 Jan 2010 18:24:24 -0600
Anthony Liguori anth...@codemonkey.ws wrote:
On 01/11/2010 06:04 PM, Luiz Capitulino wrote:
As async messages were one of the reasons for having QMP, I thought
that there was a consensus that making it part of the original
protocol was ok, meaning
On Tue, 12 Jan 2010 09:16:43 +0100
Markus Armbruster arm...@redhat.com wrote:
Now, if everything is disabled by default and qemu might be running
already, do we really need to have a handshake?
I think it's valuable to have a discrete period of time when no
commands have been
The backing device is only modified from bdrv_commit. So instead of
flushing it every time bdrv_flush is called for the front-end device
only flush it after we're written data to it in bdrv_commit.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: qemu/block.c
From: Kevin Wolf kw...@redhat.com
Now that we do not have to flush the backing device anymore implementing
the bdrv_aio_flush method for image formats is trivial.
[hch: forward ported to qemu mainline from a product tree]
Signed-off-by: Kevin Wolf kw...@redhat.com
Signed-off-by: Christoph
On Tue, Jan 12, 2010 at 10:10:41AM +0100, Magnus Christensson wrote:
On 12/24/2009 01:29 AM, Kevin O'Connor wrote:
On Mon, Dec 14, 2009 at 10:25:14AM +0100, Magnus Christensson wrote:
Should be cpu_length + 2 as far as I can tell. The current code is
definitely broken.
Right. That should be
On Tue, Jan 05, 2010 at 06:43:11AM -0600, Anthony Liguori wrote:
Hi,
I hope everyone had a happy new year! Now that we've finished the 0.12
release and most of us have had a nice break, I think it's time to start
planning for the next release.
0.12 felt a bit rushed to me. I'd like to
As promised this is a resend of a patch I posted 2008-12-12.
At some point linux MTD started using random data reads and my NAND
boards stopped working. This patch fixed the issue.
I received a comment regarding sequential reads that cross page boundaries.
Those won't work but they don't work
Random reading depends on having the last row/page latched and not beeing
clobbered between read and any following random reads.
Also, s-iolen must be updated when loading the io/data register with
randomly accessed flash data.
Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com
---
On 01/12/2010 05:16 AM, Christoph Hellwig wrote:
On Mon, Jan 11, 2010 at 01:30:19PM -0500, Cole Robinson wrote:
Current IDE floppy detection is hardcoded based on source file name.
Make this smarter by attempting a floppy specific ioctl.
IDE floppys show up as /dev/hd?, these are old legacy
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want this too, I can get rid of it if everyone agrees
we won't support clipboard writes 4k over vnc or if there's a better
idea.
Why bother trying to preserve message boundaries? I think that's the
fundamental question.
On 01/12/2010 02:46 AM, Paolo Bonzini wrote:
On 01/11/2010 08:40 PM, Anthony Liguori wrote:
Wouldn't it make more sense to try to use pkg-config always and if it's
not available, fall back on sdl-config?
That means we don't have a separate code path for cross compiling which
means it's less
On Tue, 12 Jan 2010, Pasi Kärkkäinen wrote:
On Tue, Jan 05, 2010 at 06:43:11AM -0600, Anthony Liguori wrote:
Hi,
I hope everyone had a happy new year! Now that we've finished the 0.12
release and most of us have had a nice break, I think it's time to start
planning for the next
On 01/12/2010 05:51 AM, Jan Kiszka wrote:
Liran Schour wrote:
Move to stage3 only when remaining work can be done below max downtime.
To make sure the process will converge we will try only MAX_DIRTY_ITERATIONS.
OK, that explains now patch 2. But do we have such barrier for memory
Jan Kiszka jan.kis...@siemens.com wrote on 12/01/2010 13:51:09:
Liran Schour wrote:
Move to stage3 only when remaining work can be done below max downtime.
To make sure the process will converge we will try only
MAX_DIRTY_ITERATIONS.
OK, that explains now patch 2. But do we have such
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want this too, I can get rid of it if everyone agrees
we won't support clipboard writes 4k over vnc or if there's a better
idea.
Why bother trying to preserve message
Current CDROM detection is hardcoded based on source file name.
Make this smarter by attempting a CDROM specific ioctl.
This makes '-cdrom /dev/sr0' succeed with no media present.
v2: Give ioctl check higher priority than filename check
Signed-off-by: Cole Robinson crobi...@redhat.com
---
Current legacy floppy detection is hardcoded based on source file
name. Make this smarter by attempting a floppy specific ioctl.
v2: Give ioctl check higher priority than filename check,
s/IDE/legacy/
Signed-off-by: Cole Robinson crobi...@redhat.com
---
block/raw-posix.c | 20
On 01/12/2010 09:13 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want this too, I can get rid of it if everyone agrees
we won't support clipboard writes 4k over vnc or if there's a better
On (Tue) Jan 12 2010 [09:46:55], Anthony Liguori wrote:
On 01/12/2010 09:13 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want this too, I can get rid of it if everyone agrees
we won't
On 01/12/2010 09:49 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:46:55], Anthony Liguori wrote:
On 01/12/2010 09:13 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want
Edgar E. Iglesias wrote:
As promised this is a resend of a patch I posted 2008-12-12.
Thanks.
At some point linux MTD started using random data reads and my NAND
boards stopped working. This patch fixed the issue.
I received a comment regarding sequential reads that cross page boundaries.
Am 11.01.2010 18:51, schrieb Christoph Hellwig:
Check the whitelist as early as possible instead of continuing the
setup, and move all the error handling code to the end of the
function.
Signed-off-by: Christoph Hellwig h...@lst.de
Index: qemu/block.c
On (Tue) Jan 12 2010 [09:55:41], Anthony Liguori wrote:
On 01/12/2010 09:49 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:46:55], Anthony Liguori wrote:
On 01/12/2010 09:13 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16
Attendees: Avi, Dor, Gleb, Michael, Chris, Juan, John, Kevin, Armbru, Amit,
Anthony, Glauber, AlexW, AlexG, Luiz, Jes
Minutes (please reply w/ corrections or follow-ups):
- administrivia
- no plan to do formal attendance
- above attendance list is approximate
- discussion focused on
Hi,
+#define DEFINE_VIRTIO_NET_FEATURES(_state, _field) \
+DEFINE_VIRTIO_COMMON_FEATURES(_state, _field), \
+DEFINE_PROP_BIT(csum, _state, _field, VIRTIO_NET_F_CSUM, true), \
+DEFINE_PROP_BIT(guest_csum, _state, _field, VIRTIO_NET_F_GUEST_CSUM,
true), \
+
On 01/11/10 20:50, Anthony Liguori wrote:
On 01/08/2010 08:25 AM, Gerd Hoffmann wrote:
Add a new machine type for qemu 0.12.
Also fixup the 0.11 machine type: msi for virtio-blk-pci was enabled
after the 0.11 release, so turn it off in the 0.11 machine type.
Signed-off-by: Gerd
On Tue, Jan 12, 2010 at 10:29:11AM -0500, Cole Robinson wrote:
static int cdrom_probe_device(const char *filename)
{
+int fd, ret, prio;
+
if (strstart(filename, /dev/cd, NULL))
-return 100;
-return 0;
+prio = 50;
+
+fd = open(filename, O_RDONLY |
Looks good,
same comment applies as to the cdrom one.
Am 12.01.2010 18:09, schrieb Christoph Hellwig:
On Tue, Jan 12, 2010 at 05:04:00PM +0100, Kevin Wolf wrote:
To keep the behaviour as previously you'd need to set at least bs-drv
in the unlink_and_fail case, too. I have no clue why it's important to
set it to NULL when bs isn't going to be used
Am 11.01.2010 18:52, schrieb Christoph Hellwig:
Untangle the open flag manipulation in bdrv_open2 and document why we
are clearing the various flags in the different flag combinations.
Signed-off-by: Christoph Hellwig h...@lst.de
Nice cleanup.
Acked-by: Kevin Wolf kw...@redhat.com
+
On Tue, Jan 12, 2010 at 06:32:13PM +0100, Kevin Wolf wrote:
Am 11.01.2010 18:52, schrieb Christoph Hellwig:
Untangle the open flag manipulation in bdrv_open2 and document why we
are clearing the various flags in the different flag combinations.
Signed-off-by: Christoph Hellwig
Am 12.01.2010 13:49, schrieb Christoph Hellwig:
The backing device is only modified from bdrv_commit. So instead of
flushing it every time bdrv_flush is called for the front-end device
only flush it after we're written data to it in bdrv_commit.
Signed-off-by: Christoph Hellwig
On Tue, Jan 12, 2010 at 06:42:20PM +0100, Kevin Wolf wrote:
@@ -623,6 +623,12 @@ int bdrv_commit(BlockDriverState *bs)
if (drv-bdrv_make_empty)
return drv-bdrv_make_empty(bs);
+/*
+ * Make sure all data we wrote to the backing device is actually
+ * stable on
Isaku Yamahata wrote:
Move out pci address decoding logic from pci_data_{write, read}()
by making pci_data_{write, read}() get PCIConfigAddress.
I think this is going in the wrong direction. You are keeping the device
specific MMIO/PIO based config space access handlers and just move the
Isaku Yamahata wrote:
On Tue, Jan 12, 2010 at 12:12:36PM +0200, Michael S. Tsirkin wrote:
On Tue, Jan 12, 2010 at 05:52:58PM +0900, Isaku Yamahata wrote:
diff --git a/hw/versatile_pci.c b/hw/versatile_pci.c
index d99b7fa..14a728a 100644
--- a/hw/versatile_pci.c
+++
This patch causes 100% reproducible boot panics in a Linux guest using
virtio.
My qemu command line is:
/opt/qemu/bin/qemu-system-x86_64 \
-m 1500 \
-enable-kvm \
-drive
file=/dev/vg00/qemu-root,if=virtio,media=disk,cache=none,aio=threads \
-kernel
The backing device is only modified from bdrv_commit. So instead of
flushing it every time bdrv_flush is called for the front-end device
only flush it after we're written data to it in bdrv_commit.
Also flush the frontend image if we have a make_empty method that
possibly writes to it.
Hello,
Here's a run of the clang analyzer on qemu sources for the x86_64
target.
See
http://amitshah.fedorapeople.org/clang-output/2010-01-12-9/
for the results.
There are a few results there which look dubious but a lot of the output
can be useful to fix the bugs.
What's nice about the tool
Guys, I was wondering whether the following helper function will be
helpful, as a lot of common code seems to be around identical b/w/l
callbacks. Comments?
diff --git a/cpu-common.h b/cpu-common.h
index 0ec9b72..be7e992 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -42,6 +42,24 @@ int
Mac feature bit isn't going to work as all network cards already have a
'mac' property to set the mac address. Remove it from mask and add in
get_features.
Reported-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/virtio-net.c |2 ++
On Tue, Jan 12, 2010 at 06:05:54PM +0100, Gerd Hoffmann wrote:
Hi,
+#define DEFINE_VIRTIO_NET_FEATURES(_state, _field) \
+DEFINE_VIRTIO_COMMON_FEATURES(_state, _field), \
+DEFINE_PROP_BIT(csum, _state, _field, VIRTIO_NET_F_CSUM, true), \
+DEFINE_PROP_BIT(guest_csum,
Will be required for upcoming KVM cpuid leaf. Host kernels = 2.6.32 as
well as future kvm-kmod releases (more recent than kvm-kmod-2.6.32.3)
do/will provide them.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
configure | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
Since kvm-kmod-2.6.32.2 we have an alternative source for recent KVM
kernel headers. Use it when available and not overruled by --kerneldir.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
Note: This is the upstream version first. qemu-kvm differs in this area,
I will post corresponding
On Tue, Jan 12, 2010 at 07:09:27PM +0100, Christoph Hellwig wrote:
This patch causes 100% reproducible boot panics in a Linux guest using
virtio.
My qemu command line is:
/opt/qemu/bin/qemu-system-x86_64 \
-m 1500 \
-enable-kvm \
-drive
I'd like to make QMP self-documenting, i.e. make documentation
available within QMP, in structured form, so that clients can discover
available capabilities, commands, their arguments, possible responses
and errors, and so forth.
The core protocol is outside the scope of self-documentation. By
On Tue, 12 Jan 2010, Amit Shah wrote:
Hello,
Here's a run of the clang analyzer on qemu sources for the x86_64
target.
See
http://amitshah.fedorapeople.org/clang-output/2010-01-12-9/
for the results.
There are a few results there which look dubious but a lot of the output
can be
On 01/12/2010 11:10 AM, Gerd Hoffmann wrote:
On 01/11/10 20:50, Anthony Liguori wrote:
On 01/08/2010 08:25 AM, Gerd Hoffmann wrote:
Add a new machine type for qemu 0.12.
Also fixup the 0.11 machine type: msi for virtio-blk-pci was enabled
after the 0.11 release, so turn it off in the 0.11
Without this fix, guest crashes with drive=virtio.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Anthony, could you please apply this patch quickly?
It's an obvious one and it fixes guest crashes.
Also, sorry about missing this in my testing.
hw/qdev-properties.c |2 +-
1 files
On Mon, Jan 11, 2010 at 10:33 PM, Igor Kovalenko
igor.v.kovale...@gmail.com wrote:
On Tue, Jan 12, 2010 at 12:29 AM, Blue Swirl blauwir...@gmail.com wrote:
On Sun, Jan 10, 2010 at 6:41 PM, Blue Swirl blauwir...@gmail.com wrote:
On Sun, Jan 3, 2010 at 7:18 PM, Blue Swirl blauwir...@gmail.com
On 01/08/2010 12:45 PM, Luiz Capitulino wrote:
The monitor_protocol_event() function will free the
event's data, this is wrong as 'data' management is up
to the caller.
Signed-off-by: Luiz Capitulinolcapitul...@redhat.com
Applied. Thanks.
Regards,
Anthony Liguori
---
monitor.c |
On Tue, Jan 12, 2010 at 6:13 PM, Amit Shah amit.s...@redhat.com wrote:
Hello,
Here's a run of the clang analyzer on qemu sources for the x86_64
target.
See
http://amitshah.fedorapeople.org/clang-output/2010-01-12-9/
for the results.
There are a few results there which look dubious but
On 01/11/2010 11:30 AM, Stefano Stabellini wrote:
Hi all,
calling vnc_update_client in vnc_refresh might have the unlikely side
effect of setting vd-timer = NULL, if the last vnc client disconnected.
In this case we have to return from vnc_refresh without updating the
timer, otherwise we cause a
On 01/12/2010 01:16 PM, Michael S. Tsirkin wrote:
Without this fix, guest crashes with drive=virtio.
Signed-off-by: Michael S. Tsirkinm...@redhat.com
Applied. Thanks.
Regards,
Anthony Liguori
---
Anthony, could you please apply this patch quickly?
It's an obvious one and it fixes
1 - 100 of 132 matches
Mail list logo
