A lot of people copy libvirt's command line from ps -ef and then wonder why the
VM isn't working correctly. Let's be kind and tell them what they should do
instead.
Without this patch, if you run with an invalid -net tap,fd=X, the guest still
runs and we poll 100% on a bad file descriptor. With
On 10/08/2010 06:28 PM, Alexander Graf wrote:
On 09.10.2010, at 00:04, Anthony Liguori wrote:
A lot of people copy libvirt's command line from ps -ef and then wonder why the
VM isn't working correctly. Let's be kind and tell them what they should do
instead.
Without this patch, if you run
On 09.10.2010, at 00:04, Anthony Liguori wrote:
> A lot of people copy libvirt's command line from ps -ef and then wonder why
> the
> VM isn't working correctly. Let's be kind and tell them what they should do
> instead.
>
> Without this patch, if you run with an invalid -net tap,fd=X, the gue
A lot of people copy libvirt's command line from ps -ef and then wonder why the
VM isn't working correctly. Let's be kind and tell them what they should do
instead.
Without this patch, if you run with an invalid -net tap,fd=X, the guest still
runs and we poll 100% on a bad file descriptor. With
Am 08.10.2010 18:57, schrieb Hollis Blanchard:
On Fri, Oct 8, 2010 at 1:32 AM, Stefan Weil wrote:
When qemu is configured with --enable-debug-tcg,
gcc throws this warning (or error with -Werror):
tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is
always true
Fix it by removing
Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
/src/qemu/target-mips/translate.c: In function 'gen_ld':
/src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set
but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the variable is not unu
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-i386/op_helper.c: In function 'switch_tss':
/src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap'
set but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the variable is not unused. A
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/ui/vnc.c: In function 'vnc_client_cache_auth':
/src/qemu/ui/vnc.c:217:12: error: variable 'qdict' set but not used
[-Werror=unused-but-set-variable]
/src/qemu/ui/vnc.c: In function 'vnc_display_open':
/src/qemu/ui/vnc.c:2526:9: error: v
Compiling with GCC 4.6.0 20100925 produced warnings like:
/src/qemu/hw/mips_fulong2e.c: In function 'mips_fulong2e_init':
/src/qemu/hw/mips_fulong2e.c:274:16: error: variable 'rtc_state' set
but not used [-Werror=unused-but-set-variable]
/src/qemu/hw/mips_fulong2e.c:268:16: error: variable 'isa_dev
Compiling with GCC 4.6.0 20100925 produced a warning:
In file included from /src/qemu/target-cris/translate.c:3154:0:
/src/qemu/target-cris/translate_v10.c: In function 'dec10_prep_move_m':
/src/qemu/target-cris/translate_v10.c:111:22: error: variable 'rd' set
but not used [-Werror=unused-but-set-v
Compiling with GCC 4.6.0 20100925 produced warnings like:
/src/qemu/net/tap-win32.c: In function 'tap_win32_open':
/src/qemu/net/tap-win32.c:582:12: error: variable 'hThread' set but
not used [-Werror=unused-but-set-variable]
Fix by removing the unused variables.
Signed-off-by: Blue Swirl
---
h
On 08.10.2010, at 23:25, Blue Swirl wrote:
> Compiling with GCC 4.6.0 20100925 produced warnings:
> /src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':
> /src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but
> not used [-Werror=unused-but-set-variable]
> /src/qemu/target
Only Mac-on-Linux stuff used video.x, OpenBIOS does not need it.
Remove video.x MoL hacks.
Signed-off-by: Alexander Graf
Signed-off-by: Blue Swirl
---
Makefile|3 +-
configure |2 +-
hw/ppc_mac.h|1 -
hw/ppc_newworld.c | 41 +-
hw/p
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
/src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not
used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the variable is not unused for
non-debug case.
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/hw/eepro100.c: In function 'eepro100_read4':
/src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used
uninitialized in this function [-Werror=uninitialized]
/src/qemu/hw/eepro100.c: In function 'eepro100_read2':
/src/qemu/hw/eepro100.c
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':
/src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but
not used [-Werror=unused-but-set-variable]
/src/qemu/target-ppc/op_helper.c: In function 'do_6xx_tlb':
/src/qemu/t
Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
In file included from /src/qemu/hw/cirrus_vga_rop.h:174:0,
from /src/qemu/hw/cirrus_vga.c:284:
/src/qemu/hw/cirrus_vga_rop2.h: In function 'cirrus_patternfill_0_8':
/src/qemu/hw/cirrus_vga_rop2.h:48:18: error: varia
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/block/qcow2-refcount.c: In function 'update_refcount':
/src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set
but not used [-Werror=unused-but-set-variable]
Fix by adding a dummy cast so that the result is not unused.
S
*** BLURB HERE ***
Blue Swirl (12):
block: avoid a write only variable
cirrus: avoid write only variables
eepro100: initialize a variable in all cases
lsi53c895a: avoid a write only variable
ppc: remove video.x
Delete write only variables
mips_fulong2e: Delete write only variables
I made a mistake, there are 2 irq : 11 and 15 and best_irq = 11 after svc call
So it should launch vPortSVCHandler but it does not.
--
arm - svc instruction
https://bugs.launchpad.net/bugs/657006
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to
Markus, thanks for looking into it.
Will look into the errors and fix them asap..at least it should fail gracefully
if the arguments
are not correct/insufficient.
BTW, we added a setup help page under QEMU documentation..and it can get you
started..
http://wiki.qemu.org/Documentation/9psetup
Th
This patch adds code to look up data cluster offsets in the image via
the L1/L2 tables. The L2 tables are writethrough cached in memory for
performance (each read/write requires a lookup so it is essential to
cache the tables).
With cluster lookup code in place it is possible to implement
bdrv_is
This patch adds support for the qemu-img check command. It also
introduces a dirty bit in the qed header to mark modified images as
needing a check. This bit is cleared when the image file is closed
cleanly.
If an image file is opened and it has the dirty bit set, a consistency
check will run an
The get_bits_from_size() calculates the log base-2 of a number. This is
useful in bit manipulation code working with power-of-2s.
Currently used by qcow2 and needed by qed in a follow-on patch.
Signed-off-by: Stefan Hajnoczi
---
block/qcow2.c | 22 --
cutils.c | 18
QEMU Enhanced Disk format is a disk image format that forgoes features
found in qcow2 in favor of better levels of performance and data
integrity. Due to its simpler on-disk layout, it is possible to safely
perform metadata updates more efficiently.
Installations, suspend-to-disk, and other alloc
From: Christian Brunner
Hi Anthony,
Here's an updated rbd driver, that fixes the issues you pointed at. Main issue
that has been
delt with is moving the main aio handling from the librados callback to the
reader handler
that runs in the qemu context. All the librados callback does now is sendi
From: Anthony Liguori
This common function converts byte counts to human-readable strings with
proper units.
Signed-off-by: Anthony Liguori
Signed-off-by: Stefan Hajnoczi
---
cutils.c | 15 +++
qemu-common.h |1 +
2 files changed, 16 insertions(+), 0 deletions(-)
diff
This patch implements the read/write state machine. Operations are
fully asynchronous and multiple operations may be active at any time.
Allocating writes lock tables to ensure metadata updates do not
interfere with each other. If two allocating writes need to update the
same L2 table they will
How is this different than usb_del? Is it that it detaches it but does
not delete the device?
Regards,
Anthony Liguori
On 10/05/2010 09:40 AM, Alon Levy wrote:
Signed-off-by: Alon Levy
---
qemu-monitor.hx | 17 +
sysemu.h|1 +
vl.c| 41 +++
Public bug reported:
The svc instruction doesn't work as expected.
-> qemu 0.13.0 rc1 (git)
Test : demo with freeRTOS (for example
FreeRTOS-6.0.5/Demo/CORTEX_LM3S811_GCC) with the card lm3s811evb.
If we start the scheduler, it will call that function (__attribute__ ((
naked ))) :
void vPortSta
On Tue, 5 Oct 2010 16:40:29 +0200
Alon Levy wrote:
> Signed-off-by: Alon Levy
This needs to be rebased as it now conflicts with my last series merged
on master.
I have some minor comments (below), but in general seems ok to me. However,
I'd like to get an ACK from someone familiar with QEMU's
On 08.10.2010, at 20:06, Blue Swirl wrote:
> On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote:
>>
>> On 08.10.2010, at 19:28, Paolo Bonzini wrote:
>>
>>> On 10/07/2010 07:24 PM, Blue Swirl wrote:
>> On 10/06/2010 11:32 PM, Blue Swirl wrote:
@@ -91,8 +90,6 @@ static
On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf wrote:
>
> On 08.10.2010, at 19:28, Paolo Bonzini wrote:
>
>> On 10/07/2010 07:24 PM, Blue Swirl wrote:
> On 10/06/2010 11:32 PM, Blue Swirl wrote:
> >>
> >> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
> >>
On 10/08/2010 10:48 AM, Stefan Hajnoczi wrote:
The get_bits_from_size() calculates the log base-2 of a number. This is
useful in bit manipulation code working with power-of-2s.
Currently used by qcow2 and needed by qed in a follow-on patch.
Signed-off-by: Stefan Hajnoczi
Acked-by: Anthon
On 10/07/2010 07:24 PM, Blue Swirl wrote:
> On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>
>> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>>env->gpr[3] = 0;
>>break;
>>case 39: /* video_ctrl */
>> -if (env->gpr[6] == 0 || env->gpr[6] == 1)
>
On Fri, Oct 08, 2010 at 12:14:07PM +0200, Kevin Wolf wrote:
> Am 07.10.2010 22:25, schrieb Eduardo Habkost:
> > Errors when closing the file we just created should not be ignored. I/O
> > errors
> > may happen and "qemu-img create" should fail in those cases.
> >
> > If we are already exiting due
On 08.10.2010, at 19:28, Paolo Bonzini wrote:
> On 10/07/2010 07:24 PM, Blue Swirl wrote:
>>> > On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>
>> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env)
>>env->gpr[3] = 0;
>>break;
>>case 3
On Tue, 28 Sep 2010 16:57:44 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Sep 28, 2010 at 11:53:43AM -0300, Luiz Capitulino wrote:
> > On Mon, 27 Sep 2010 15:52:44 +0800
> > Jason Wang wrote:
> >
> > > monitor_get_fd() may also be used to parse fd or vhostfd from command
> > > line, so
> > > we
On Thu, Oct 7, 2010 at 8:34 PM, Lluís wrote:
> Blue Swirl writes:
>
>> The patches there seem to be fixes or small changes to your other
>> patches. This makes any review very difficult.
>
> Sorry, I'm really new to git, so I don't really know how to maintain and
> "grow" an organized set of patch
This patch introduces the qed on-disk layout and implements image
creation. Later patches add read/write and other functionality.
Signed-off-by: Stefan Hajnoczi
---
Makefile.objs |1 +
block/qed.c | 530 +
block/qed.h | 148 +
On Fri, Oct 8, 2010 at 1:32 AM, Stefan Weil wrote:
> When qemu is configured with --enable-debug-tcg,
> gcc throws this warning (or error with -Werror):
>
> tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is always true
>
> Fix it by removing the >= 0 part.
> The type cast to 'unsign
On 10/08/2010 10:50 AM, Yehuda Sadeh Weinraub wrote:
Oh, that makes it more clean. Considering that we did it for kvm, and
looking at the kvm qemu_bh_schedule() implementation, it does look
thread safe (there might be an issue though with canceling the bh
though, haven't looked at it, not really
On Fri, Oct 8, 2010 at 7:06 AM, Anthony Liguori wrote:
> On 10/07/2010 05:45 PM, Sage Weil wrote:
>>
>> I'm sorry, I'm having a hard time understanding what it is you're
>> objecting to, or what you would prefer, as there are two different things
>> we're talking about here (callbacks and fd glue/
On 10/07/2010 08:53 PM, Blue Swirl wrote:
On Thu, Oct 7, 2010 at 9:20 AM, Markus Armbruster wrote:
Paolo Bonzini writes:
On 10/06/2010 11:32 PM, Blue Swirl wrote:
Compiling with GCC 4.6.0 20100925 produced a warning:
/src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
/src/qemu/hw/lsi53
"-device ivshmem" makes pci_ivshmem_init() pass null pointer to
shm_open(). Suspect the "Must specify 'chardev' or 'shm' to ivshmem"
error should be fatal.
By the way, that error message can be misleading: the chardev must be
"unix:" to be recognized. For instance, "-chardev null,id=chr0 -device
On 10/08/2010 11:15 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
hmp-commands.hx |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 95bdb91..f138a76 100644
--- a/hmp-commands.hx
+++ b/hmp-
Signed-off-by: Stefan Hajnoczi
---
docs/specs/qed_spec.txt | 94 +++
1 files changed, 94 insertions(+), 0 deletions(-)
create mode 100644 docs/specs/qed_spec.txt
diff --git a/docs/specs/qed_spec.txt b/docs/specs/qed_spec.txt
new file mode 100644
ind
Hi.
I am trying to emulate the Beagle platform using the version of qemu (meego
qemu) from here (I'm currently in sync with commit caacc3f):
git://gitorious.org/qemu-maemo/qemu.git.
I'm faced with the following problem. I'm running a microkernel underneath
Linux and when I try to use invasive
On Thu, Oct 7, 2010 at 8:08 PM, Alexander Graf wrote:
>
> Am 07.10.2010 um 20:59 schrieb Blue Swirl :
>
>> On Wed, Oct 6, 2010 at 9:39 PM, Alexander Graf wrote:
>>>
>>> On 06.10.2010, at 23:34, Blue Swirl wrote:
>>>
Compiling with GCC 4.6.0 20100925 produced warnings:
/src/qemu/target-p
On Fri, Oct 08, 2010 at 10:28:37AM +0100, Stefan Hajnoczi wrote:
> > exit_close:
> > - close(fd);
> > + cret = close(fd);
> > + if (ret == 0 && cret < 0)
>
> if (close(fd) < 0 && ret == 0) {
>
> Does the same without variable cret.
Yes. I used the variable just for readability. I perso
No idea how this stuff works, just playing with the options. Crashes
left & right:
* -device virtio-9p-pci
Virtio-9p device couldn't find fsdev with the id (null)
Passes null pointer for %s, crash on some systems.
By the way, shouldn't fsdev work more like netdev, drive, chr?
I.e. make
On 10/07/2010 05:45 PM, Sage Weil wrote:
On Thu, 7 Oct 2010, Anthony Liguori wrote:
On 10/07/2010 04:49 PM, Yehuda Sadeh Weinraub wrote:
On Thu, Oct 7, 2010 at 2:04 PM, Anthony Liguori
wrote:
On 10/07/2010 03:47 PM, Yehuda Sadeh Weinraub wrote:
How is that possi
Am 04.10.2010 15:29, schrieb Christoph Hellwig:
> ATA does not only have the WCACHE enabled bit in identify word 85, but also
> a WCACHE supported bit in word 82. While the Linux kernel is fine with the
> latter at least hdparm also needs the former before correctly displaying
> the cache settings
On 10/07/2010 10:15 PM, Huang Ying wrote:
Hi, Seto,
On Thu, 2010-10-07 at 11:41 +0800, Hidetoshi Seto wrote:
(2010/10/07 3:10), Dean Nelson wrote:
When I applied a patch to the guest's kernel which forces mce_ser to be
set, as if MCG_SER_P was set (see __mcheck_cpu_cap_init()), I found
that
From: Yonit Halperin
This patch adds options to the -spice command line switch to
configure image compression.
[ v2: speling fix in the documentation ]
Signed-off-by: Gerd Hoffmann
---
qemu-config.c |9 ++
qemu-options.hx |9 ++
ui/spice-core.c | 77 +++
This patch adds a few more options to tweak spice server behavior.
The documentation update chunk has the details ;)
Signed-off-by: Gerd Hoffmann
---
qemu-config.c |9 +
qemu-options.hx |9 +
ui/spice-core.c | 29 -
3 files changed, 46 inse
This allows to enforce tls or plaintext usage for certain spice
channels.
[ v2: code style fixup ]
Signed-off-by: Gerd Hoffmann
---
qemu-config.c |6 ++
qemu-options.hx |8
ui/spice-core.c | 28
3 files changed, 42 insertions(+), 0 deletions
Make listening address configurable. Also add options to
force using IPv4 or IPv6.
Signed-off-by: Gerd Hoffmann
---
qemu-config.c |9 +
qemu-options.hx |7 +++
ui/spice-core.c | 13 +++--
3 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/qemu-config
Add options to the -spice command line switch to setup tls.
Signed-off-by: Gerd Hoffmann
---
qemu-config.c | 24 +++
qemu-options.hx | 18 ++-
ui/spice-core.c | 67 +++---
3 files changed, 104 insertions(+), 5 de
Hi,
This patch series adds a bunch of config options to spice, most notably
it enables to configure TLS and thus using spice encrypted. The commit
messages are not that verbose, but every patch comes with a patch chunk
updating the spice section in the documentation. Please look there when
rev
Add qemu_activate_mouse_event_handler() calls to the usb wavom tablet so
it actually receives events. Also make sure we only remove the handler
if we registered it before.
Signed-off-by: Gerd Hoffmann
---
hw/usb-wacom.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
di
This patch updates the vmmouse handler registration and activation.
Old behavior:
vmmouse_read_id, vmmouse_request_relative and vmmouse_request_absolute
unregister the handler and re-register it.
New behavior:
vmmouse_request_relative and vmmouse_request_absolute will unregister
the handl
Hi,
In the 0.13 devel cycle the mouse handler activation code has been
updated, but (at least) two drivers have not been updated accordingly:
vmmouse and usb-wacom. This patch series updates them so they are
functional again.
IMHO the patches should also be cherry-picked into stable.
The patc
Am 07.10.2010 22:25, schrieb Eduardo Habkost:
> From: Eduardo Habkost
>
> Hi,
>
> Here are two small fixes on qcow2_create() error handling.
>
> Eduardo Habkost (2):
> fix fd leak on a qcow2_create2() error path
> check for close() errors on qcow2_create()
A while ago I sent a patch to com
Am 07.10.2010 22:25, schrieb Eduardo Habkost:
> Errors when closing the file we just created should not be ignored. I/O errors
> may happen and "qemu-img create" should fail in those cases.
>
> If we are already exiting due to an error, we will still return the original
> error number, though.
>
On Thu, Oct 07, 2010 at 02:53:05PM -0500, Anthony Liguori wrote:
> On 10/07/2010 06:15 AM, Gerd Hoffmann wrote:
> >This patch adds support for expiring passwords to vnc. It adds a new
> >lifetime parameter to the vnc_display_password() function, which
> >specifies the number of seconds the new pas
Am 08.10.2010 11:15, schrieb jes.soren...@redhat.com:
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
cutils.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/cutils.c b/cutils.c
index 0782032..e5a135e 100644
--- a/cutils.c
+++ b/cutils.c
@@ -292,6 +292,7
Am 08.10.2010 11:15, schrieb jes.soren...@redhat.com:
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
cutils.c | 34 ++
1 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/cutils.c b/cutils.c
index ee591c5..0782032 100644
--- a/cutils.c
+++ b/c
On Thu, Oct 7, 2010 at 9:25 PM, Eduardo Habkost wrote:
> Errors when closing the file we just created should not be ignored. I/O errors
> may happen and "qemu-img create" should fail in those cases.
>
> If we are already exiting due to an error, we will still return the original
> error number, th
On Thu, Oct 7, 2010 at 9:25 PM, Eduardo Habkost wrote:
> When getting an invalid cluster size, the open fd must be closed before
> qcow2_create() returns an error.
>
> Signed-off-by: Eduardo Habkost
> ---
> block/qcow2.c | 5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
Looks goo
From: Jes Sorensen
'f' double is no longer used, and we should be using floating point
variables to store byte sizes. Remove it.
Signed-off-by: Jes Sorensen
---
monitor.c | 18 +-
1 files changed, 1 insertions(+), 17 deletions(-)
diff --git a/monitor.c b/monitor.c
index 6dd1
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
hmp-commands.hx |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 95bdb91..f138a76 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -756,7 +756,8 @@ ETEXI
.name
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
hmp-commands.hx |2 +-
migration.c |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 81999aa..95bdb91 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -754,7 +754,7
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
cutils.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/cutils.c b/cutils.c
index 0782032..e5a135e 100644
--- a/cutils.c
+++ b/cutils.c
@@ -292,6 +292,7 @@ int fcntl_setfl(int fd, int flag)
ssize_t strtosz(co
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
cutils.c | 34 ++
1 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/cutils.c b/cutils.c
index ee591c5..0782032 100644
--- a/cutils.c
+++ b/cutils.c
@@ -291,34 +291,52 @@ int fcntl_setfl(int fd, in
From: Jes Sorensen
Octet format relies on strtosz which supports K/k, M/m, G/g, T/t
suffixes and unit support for humans, like 1.3G
Signed-off-by: Jes Sorensen
---
monitor.c | 28
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor
From: Jes Sorensen
strtosz() returns -1 on error.
v2 renamed from strtobytes() to strtosz() as suggested by Markus.
Signed-off-by: Jes Sorensen
---
cutils.c | 39 +++
qemu-common.h |1 +
vl.c | 31 ++-
3 fil
From: Jes Sorensen
This patch introduces cutils.c: strtosz() and gets rid of the
multiple custom hacks for parsing byte sizes. In addition it adds
supports for specifying human style sizes such as 1.5G. Last it
eliminates the horrible abuse of a float to store the byte size for
migrate_set_speed
On 10/07/10 18:03, Paolo Bonzini wrote:
> On 10/07/2010 05:01 PM, jes.soren...@redhat.com wrote:
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index 81999aa..95bdb91 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -754,7 +754,7 @@ ETEXI
>>
>> {
>> .name =
When qemu is configured with --enable-debug-tcg,
gcc throws this warning (or error with -Werror):
tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is always true
Fix it by removing the >= 0 part.
The type cast to 'unsigned' catches negative values of op
(which should never happen).
80 matches
Mail list logo
