Re: [Qemu-devel] [PATCHv2] fix linuxboot.bin and multiboot.bin to not hijack int19

2011-03-22 Thread Aurelien Jarno
On Mon, Jan 31, 2011 at 03:11:01PM +0200, Gleb Natapov wrote: Currently linuxboot.bin and multiboot.bin option roms override int19 vector to intercept boot process. No sane option rom should do that. Provide bev entry instead that will be called by BIOS if option rom is selected for booting.

Re: [Qemu-devel] Re: [PATCH 2/9] vmstate: Fix varrays with uint8 indexes

2011-03-22 Thread Yoshiaki Tamura
2011/3/18 Juan Quintela quint...@redhat.com: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: Juan, Anthony, It seems this patch broke live migration in my environment.  The guest hangs after switching to remote.  The following is parameters of the guest. -L /usr/local/seabios

Re: [Qemu-devel] [PATCH] [PPC] Add support for 6 SPE instructions (evmra, evmwsmi{a{a}}, evmwumi{a{a}})

2011-03-22 Thread Aurelien Jarno
On Wed, Mar 16, 2011 at 11:21:22AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com --- target-ppc/translate.c | 201 +++- 1 files changed, 197 insertions(+), 4 deletions(-) Thanks, applied. diff --git

Re: [Qemu-devel] [PATCH] target-arm: Fix TCG temporary leaks for scalar VMULL

2011-03-22 Thread Aurelien Jarno
On Fri, Mar 11, 2011 at 01:32:34PM +, Peter Maydell wrote: Fix a TCG temporary leak when translating 32-bit scalar VMULL. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- This was found by the TCG leak-checking support that was committed a little while back. Score one for debug

Re: [Qemu-devel] [PATCH v2 0/2] Fix VRECPS edge cases handling

2011-03-22 Thread Aurelien Jarno
On Mon, Mar 14, 2011 at 03:37:11PM +, Peter Maydell wrote: This patchset fixes the edge case handling of VRECPS. Patch 2/2 is just a bit of cleanup of the neighbouring vrsqrts helper which can then use the float32_two introduced by 1/1. Tested in the usual random-insn-generation way and

Re: [Qemu-devel] How to do qemu profiling?

2011-03-22 Thread Aurelien Jarno
On Fri, Mar 11, 2011 at 03:16:27PM +0530, मनीष शर्मा wrote: Hi All, To enable profiling of qemu, I used the option -pg. while compiling I got following error. CCarm-softmmu/arch_init.o CCarm-softmmu/cpus.o CCarm-softmmu/monitor.o CCarm-softmmu/cpu-exec.o gcc: -pg

Re: [Qemu-devel] [PATCH] vmmouse: Fix initialization

2011-03-22 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 10:52:24AM +0100, Jan Kiszka wrote: Latest refactorings left vmmouse nonfunctional behind. Fix it by adding the required device initialization. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH] target-arm: Fix GE bits for v6media signed modulo arithmetic

2011-03-22 Thread Aurelien Jarno
On Thu, Mar 10, 2011 at 06:51:49PM +, Peter Maydell wrote: Fix the signed modulo arithmetic helpers for the v6media instructions (SADD8, SSUB8, SADD16, SSUB16, SASX, SSAX) to set the GE bits correctly (based on the result of the add or subtract before it is truncated to 16 bits, not

Re: [Qemu-devel] [PATCH] linux-user: Fix unlock_user() call in return from poll()

2011-03-22 Thread Aurelien Jarno
On Fri, Feb 25, 2011 at 10:27:40AM +, Peter Maydell wrote: Correct the broken attempt to calculate the third argument to unlock_user() in the code path which unlocked the pollfd array on return from poll() and ppoll() emulation. (This only caused a problem if unlock_user() wasn't a no-op,

Re: [Qemu-devel] [PATCH] vmmouse: Register vmstate via qdev

2011-03-22 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 10:53:00AM +0100, Jan Kiszka wrote: Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmmouse.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied. diff --git a/hw/vmmouse.c b/hw/vmmouse.c index ab8dbd6..1113f33 100644 ---

Re: [Qemu-devel] [PATCH] target-arm: Set Q bit for overflow in SMUAD and SMLAD

2011-03-22 Thread Aurelien Jarno
On Fri, Mar 11, 2011 at 10:09:58AM +, Peter Maydell wrote: SMUAD and SMLAD are supposed to set the Q bit if the addition of the two 16x16 multiply products and optional accumulator overflows considered as a signed value. However we were only doing this check for the addition of the

Re: [Qemu-devel] [PATCH] target-arm: Fix UNDEF cases in Thumb load/store

2011-03-22 Thread Aurelien Jarno
On Thu, Mar 10, 2011 at 04:48:49PM +, Peter Maydell wrote: Decode of Thumb load/store was merging together the cases of 'bit 11==0' (reg+reg LSL imm) and 'bit 11==1' (reg+imm). This happens to work for valid instruction patterns but meant that we would not UNDEF for the cases the

[Qemu-devel] Re: CPU type qemu64 breaks guest code

2011-03-22 Thread Alexander Graf
On 21.03.2011, at 22:46, Andre Przywara wrote: On 03/14/2011 03:13 PM, Alexander Graf wrote: Hi guys, While I was off on vacation a pretty nasty bug emerged. It's our old friend the non-existent -cpu qemu64 CPU type. To refresh your memories, this is the definition of the default 64-bit

Re: [Qemu-devel] [PATCH] vmmouse: Fix typo preventing x86-64 build

2011-03-22 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 10:52:10AM +0100, Jan Kiszka wrote: Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- default-configs/x86_64-softmmu.mak |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied. diff --git a/default-configs/x86_64-softmmu.mak

Re: [Qemu-devel] [PATCH] fix applesmc REV key

2011-03-22 Thread Aurelien Jarno
On Mon, Mar 21, 2011 at 11:33:21AM +0100, René Rebe wrote: Fix applesmc REV key string literal hex encoding. Signed-off-by: René Rebe r...@exactcode.de --- qemu-kvm-0.14.0/hw/applesmc.c.vanilla 2011-02-22 18:55:03.73225 + +++ qemu-kvm-0.14.0/hw/applesmc.c 2011-02-22

[Qemu-devel] [PATCH] target-ppc: ext32u instead of andi with constant

2011-03-22 Thread Aurelien Jarno
Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-ppc/translate.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 3d265e3..49eab28 100644 --- a/target-ppc/translate.c

[Qemu-devel] Re: [PATCH] target-ppc: ext32u instead of andi with constant

2011-03-22 Thread Alexander Graf
On 22.03.2011, at 07:41, Aurelien Jarno wrote: Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-ppc/translate.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-22 Thread Gleb Natapov
On Mon, Mar 21, 2011 at 02:23:31PM -0700, Jordan Justen wrote: On Mon, Mar 21, 2011 at 11:27, Anthony Liguori anth...@codemonkey.ws wrote: On 03/21/2011 01:14 PM, Jordan Justen wrote: This weekend I spent some time working on loading SeaBIOS from OVMF to start a legacy boot.  I was able

Re: [Qemu-devel] [PATCH v22 00/11] usb-ccid

2011-03-22 Thread Hans de Goede
ACK Series Acked-by: Hans de Goede hdego...@redhat.com On 03/21/2011 11:07 PM, Alon Levy wrote: This patchset adds three new devices, usb-ccid, ccid-card-passthru and ccid-card-emulated, providing a CCID bus, a simple passthru protocol implementing card requiring a client, and a standalone

[Qemu-devel] [Bug 740014] [NEW] The Multiboot information data structure contains the wrong address to the module structure

2011-03-22 Thread Stefan Lankes
Public bug reported: I think that I have found a bug in qemu 0.13.0 and 0.14.0. I am developing an own microkernel and use the Multiboot specification. I load the kernel and its initrd directly with the flags -kernel and -initrd. With qemu 0.12.5, my code works correctly and I have access to my

Re: [Qemu-devel] [PATCH v3 2/2] hw/vexpress.c: Add model of ARM Versatile Express board

2011-03-22 Thread Peter Maydell
On 22 March 2011 05:50, Aurelien Jarno aurel...@aurel32.net wrote: On Mon, Mar 21, 2011 at 09:19:56PM +, Peter Maydell wrote: (hw/versatilepb.c is even worse, if I'm reading the code right it creates rtl8139 cards regardless of what model you ask for...) IIRC it's because versatilepb

Re: [Qemu-devel] Re: [PATCH] target-ppc: ext32u instead of andi with constant

2011-03-22 Thread Aurelien Jarno
On Tue, Mar 22, 2011 at 08:36:26AM +0100, Alexander Graf wrote: On 22.03.2011, at 07:41, Aurelien Jarno wrote: Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- target-ppc/translate.c |8 1 files changed, 4 insertions(+), 4

Re: [Qemu-devel] Re: [PATCH] target-ppc: ext32u instead of andi with constant

2011-03-22 Thread Alexander Graf
Am 22.03.2011 um 10:09 schrieb Aurelien Jarno aurel...@aurel32.net: On Tue, Mar 22, 2011 at 08:36:26AM +0100, Alexander Graf wrote: On 22.03.2011, at 07:41, Aurelien Jarno wrote: Cc: Alexander Graf ag...@suse.de Signed-off-by: Aurelien Jarno aurel...@aurel32.net ---

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for UINT8 indexes. Anthony, please apply,

[Qemu-devel] Re: [PATCH 1/3] alleviate time drift with HPET periodic timers

2011-03-22 Thread Ulrich Obergfell
Part 1 of the patch implements the following QEMU command line option. -hpet [device=none|present][,driftfix=none|slew] Just define driftfix as property of the hpet device. That way it can be controlled both globally (-global hpet.driftfix=...) and per hpet block (once we support

[Qemu-devel] [PATCH] gdbstub: Catch and report more vmstop reasons

2011-03-22 Thread Jan Kiszka
When the VM goes into stop state while there is a gdb frontend attached, it makes sense to inform gdb about this fact and at least a bit about the stop reason. Basically, all stops are interesting except for the temporary VMSTOP_SAVE/LOADVM. The patch maps the relevant VMSTOP reasons on unique

[Qemu-devel] Re: [PATCH 3/3] alleviate time drift with HPET periodic timers

2011-03-22 Thread Ulrich Obergfell
Part 3 of the patch implements the following options for the 'configure' script. --disable-hpet-driftfix --enable-hpet-driftfix I see no benefit in this configurability. Just make the driftfix unconditionally available, runtime-disabled by default for now until it matured and there is

[Qemu-devel] Re: [PATCH 3/3] alleviate time drift with HPET periodic timers

2011-03-22 Thread Jan Kiszka
On 2011-03-22 11:03, Ulrich Obergfell wrote: Part 3 of the patch implements the following options for the 'configure' script. --disable-hpet-driftfix --enable-hpet-driftfix I see no benefit in this configurability. Just make the driftfix unconditionally available, runtime-disabled by

[Qemu-devel] Re: [PATCH 0/3] alleviate time drift with HPET periodic timers

2011-03-22 Thread Avi Kivity
On 03/18/2011 05:54 PM, Ulrich Obergfell wrote: Please review and please comment. Some procedural remarks: - put all patches in the same thread. 'git send-email' can do that automatically for you. This really helps reviewers, at least with some email readers - give individual patches

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half of the fix. It forgots the save state fix for

Re: [Qemu-devel] [arm] Integrator/CP keyboard layout

2011-03-22 Thread Peter Maydell
On 21 March 2011 23:03, Jakub Jermar ja...@jermar.eu wrote: I noticed that the layout of the PL050 keyboard used on Integrator/CP incompatibly changed sometime between Qemu 0.10.5 and Qemu 0.11.1. The current layout used in Qemu's model of Integrator/CP is the standard PC layout. What puzzles

Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit 82fa39b75181b730d6d4d09f443bd26bcfcd045c only contains half

Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM, Juan Quintela wrote: commit

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Stefan Berger
On 03/22/2011 07:50 AM, Stefan Berger wrote: On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM, Stefan Berger wrote: On 03/15/2011 10:53 AM,

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Jan Kiszka
On 2011-03-22 12:56, Stefan Berger wrote: On 03/22/2011 07:50 AM, Stefan Berger wrote: On 03/22/2011 06:40 AM, Avi Kivity wrote: On 03/22/2011 12:23 PM, Stefan Berger wrote: On 03/22/2011 05:28 AM, Avi Kivity wrote: On 03/22/2011 03:46 AM, Anthony Liguori wrote: On 03/21/2011 07:25 PM,

Re: [Qemu-devel] QEMU patch for non-NPTL mode

2011-03-22 Thread Laurent Vivier
Le vendredi 18 mars 2011 à 14:55 +0300, Alexander Paramonov a écrit : Hello! We use QEMU to run ARM-compiled soft on PC Linux OS. Our soft is linked with uClibc library in non-NPTL mode. So there are some problems in running multi-threaded applications under QEMU: 1. Both uClibc and gLibc

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 02:00 PM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version? Autotest did catch the uint8 varray thing. c995b4 isn't yet in qemu-kvm.git, so it

[Qemu-devel] Re: PRoot: A Step Forward for QEMU User-Mode

2011-03-22 Thread Cédric VINCENT
Hi Riku, Riku Voipio riku.voipio at iki.fi writes: Similar thing is done with scratchbox2, but with LD_PRELOAD instead of ptrace. LD_PRELOAD for all around the corners (static binaries etc) and the slowdown is major. ptrace would make at least the former problem go away. However, why do

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Jan Kiszka
On 2011-03-22 13:21, Avi Kivity wrote: On 03/22/2011 02:00 PM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version? Autotest did catch the uint8 varray thing.

Re: [Qemu-devel] CPU type qemu64 breaks guest code

2011-03-22 Thread Avi Kivity
On 03/14/2011 04:13 PM, Alexander Graf wrote: Hi guys, While I was off on vacation a pretty nasty bug emerged. It's our old friend the non-existent -cpu qemu64 CPU type. To refresh your memories, this is the definition of the default 64-bit CPU type in Qemu: { .name = qemu64,

[Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: Re: [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Juan Quintela
Jan Kiszka jan.kis...@siemens.com wrote: VMSTATE_UINT64_V(pat, CPUState, 13), Ouch, indeed. Moreover, CPU_SAVE_VERSION was not updated (likely the reason for the breakage). Thanks for debugging this! Anthony (or whoever), please revert this unneeded commit in qemu.git. We had

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Avi Kivity
On 03/22/2011 02:30 PM, Jan Kiszka wrote: On 2011-03-22 13:21, Avi Kivity wrote: On 03/22/2011 02:00 PM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version?

[Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: Re: [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Jan Kiszka
On 2011-03-22 13:33, Juan Quintela wrote: Jan Kiszka jan.kis...@siemens.com wrote: VMSTATE_UINT64_V(pat, CPUState, 13), Ouch, indeed. Moreover, CPU_SAVE_VERSION was not updated (likely the reason for the breakage). Thanks for debugging this! Anthony (or whoever), please revert

[Qemu-devel] [PATCH] Few new QMP features

2011-03-22 Thread Dmitry Konishchev
Hi! I use QEMU via QMP and I've discovered that for some tasks there is no proper way to do them via QMP. I've written few patches: * One of them modifies pci_add command to return pci address of the added device, when user hasn't specified it (to be able to delete it via pci_del in the future). *

Re: [Qemu-devel] KVM call agenda for Mars 21th

2011-03-22 Thread Luiz Capitulino
On Mon, 21 Mar 2011 13:58:35 +0100 Juan Quintela quint...@redhat.com wrote: Please, send in any agenda items you are interested in covening. - Merge patches speed. I just feel, that patches are not being handled fast enough, so ... I looked how much patches have been integrated since

Re: [Qemu-devel] [RFC] QCFG: a new mechanism to replace QemuOpts and option handling

2011-03-22 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 03/18/2011 09:04 AM, Markus Armbruster wrote: Initial code is in my QAPI tree. I'm not going to start converting things until we get closer to the end of 0.15 and QAPI is fully merged. My plan is to focus on this for 0.16 and do a full

[Qemu-devel] [PATCH 3/3] spice-chardev: listen to frontend guest open / close

2011-03-22 Thread Hans de Goede
Note the vmc_register_interface() in spice_chr_write is left in place in case someone uses spice-chardev with a frontend which does not have guest open / close notification. Signed-off-by: Hans de Goede hdego...@redhat.com --- spice-qemu-char.c | 14 ++ 1 files changed, 14

[Qemu-devel] [PATCH 1/3] chardev: Allow frontends to notify backends of guest open / close

2011-03-22 Thread Hans de Goede
Some frontends know when the guest has opened the channel and is actively listening to it, for example virtio-serial. This patch adds 2 new qemu-chardev functions which can be used by frontends to signal guest open / close, and allows interested backends to listen to this. Signed-off-by: Hans de

[Qemu-devel] [PATCH 0/3] spicevmc - chardev: restore guest open / close notifcation

2011-03-22 Thread Hans de Goede
Hi All, When we moved from the spicevmc device (which directly implemented a virtio serial port) to doing spicevmc as a chardev backend we lost the notification of the guest opening / closing the port to spice server. This causes the server to not fall back to server mouse mode when the agent

[Qemu-devel] [PATCH 2/3] virtio-console: notify backend of guest open / close

2011-03-22 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/virtio-console.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index c235b27..a23ef5a 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -27,6

[Qemu-devel] [Bug 658610] Re: Check whether images have write permissions

2011-03-22 Thread Stefan Hajnoczi
Can you please add steps to reproduce this bug? It's not clear to me when this happens. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/658610 Title: Check whether images have write permissions

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-22 Thread Michael S. Tsirkin
On Tue, Mar 22, 2011 at 09:50:37AM +0900, Isaku Yamahata wrote: On Mon, Mar 21, 2011 at 04:10:22PM +0200, Michael S. Tsirkin wrote: @@ -37,8 +37,27 @@ typedef PCIHostState I440FXState; +#define PIIX_NUM_PIC_IRQS 16 /* i8259 * 2 */ +#define PIIX_NUM_PIRQS

Re: Supsend/resume regression in c995b4 WAS: Re: [Qemu-devel] [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Anthony Liguori
On 03/22/2011 07:00 AM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version? Autotest is too late and also not nearly rigorous enough for what you're trying to catch.

[Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: Re: [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Juan Quintela
Anthony Liguori aligu...@us.ibm.com wrote: On 03/22/2011 07:00 AM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version? Autotest is too late and also not nearly

[Qemu-devel] Re: Supsend/resume regression in c995b4 WAS: Re: [PATCH] Fix migration uint8 arrys handled

2011-03-22 Thread Anthony Liguori
On 03/22/2011 08:55 AM, Juan Quintela wrote: Anthony Liguorialigu...@us.ibm.com wrote: On 03/22/2011 07:00 AM, Jan Kiszka wrote: We had a few migration related regressions recently. Do we have sufficient test cases in autotest for them? Also for migrating from older to the latest version?

[Qemu-devel] Re: [PATCH RESEND v3] fix vnc regression

2011-03-22 Thread Anthony Liguori
On 03/11/2011 03:10 AM, Wen Congyang wrote: This patch fix the following regression: 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits(). Signed-off-by: Wen Congyangwe...@cn.fujitsu.com --- ui/vnc.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-)

[Qemu-devel] Re: [PATCH RESEND v3] fix vnc regression

2011-03-22 Thread Corentin Chary
16); +            bitmap_set(vs-dirty[y_position + i], 0, width); +            bitmap_clear(vs-dirty[y_position + i], width, +                         VNC_DIRTY_WORDS * BITS_PER_LONG - width);          } VNC_DIRTY_WORDS in not a valid symbol in the latest tip. Regards, Patch updated

Re: [Qemu-devel] [PATCH 0/3] spicevmc - chardev: restore guest open / close notifcation

2011-03-22 Thread Amit Shah
On (Tue) 22 Mar 2011 [14:15:20], Hans de Goede wrote: Hi All, When we moved from the spicevmc device (which directly implemented a virtio serial port) to doing spicevmc as a chardev backend we lost the notification of the guest opening / closing the port to spice server. This causes the

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-22 Thread Isaku Yamahata
On Tue, Mar 22, 2011 at 03:40:16PM +0200, Michael S. Tsirkin wrote: On Tue, Mar 22, 2011 at 09:50:37AM +0900, Isaku Yamahata wrote: On Mon, Mar 21, 2011 at 04:10:22PM +0200, Michael S. Tsirkin wrote: @@ -37,8 +37,27 @@ typedef PCIHostState I440FXState; +#define

Re: [Qemu-devel] Re: [PATCH RESEND v3] fix vnc regression

2011-03-22 Thread Anthony Liguori
On 03/22/2011 09:04 AM, Corentin Chary wrote: 16); +bitmap_set(vs-dirty[y_position + i], 0, width); +bitmap_clear(vs-dirty[y_position + i], width, + VNC_DIRTY_WORDS * BITS_PER_LONG - width); } VNC_DIRTY_WORDS in not a valid symbol in the

[Qemu-devel] Re: CPU type qemu64 breaks guest code

2011-03-22 Thread Michael Matz
Hi, On Mon, 21 Mar 2011, Andre Przywara wrote: .name = qemu64, .level = 4, .vendor1 = CPUID_VENDOR_AMD_1, .vendor2 = CPUID_VENDOR_AMD_2, .vendor3 = CPUID_VENDOR_AMD_3, .family = 6, .model = 2, .stepping = 3,

Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

2011-03-22 Thread Alexander Graf
On 03/01/2011 07:35 PM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Hi all, Here is the few change since the V10: - Add braces for blocks with single statement in the clean-up patch; - the patch that builds Xen only for x86 have been removed, instead,

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

2011-03-22 Thread Anthony PERARD
On Tue, Mar 22, 2011 at 14:23, Alexander Graf ag...@suse.de wrote: On 03/01/2011 07:35 PM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Hi all, Here is the few change since the V10:   - Add braces for blocks with single statement in the clean-up patch;  

[Qemu-devel] [PATCH 1/2] Implement basic part of SA-1110/SA-1100

2011-03-22 Thread Dmitry Eremin-Solenikov
Basic implementation of DEC/Intel SA-1100/SA-1110 chips emulation. Implemented: - IRQs - GPIO - PPC - RTC - UARTs (no IrDA/etc.) - OST reused from pxa25x Everything else is TODO (esp. PM/idle/sleep!) - see the todo in the hw/strongarm.c Signed-off-by: Dmitry Eremin-Solenikov

[Qemu-devel] KVM call minutes Mars 22

2011-03-22 Thread Juan Quintela
Minutes of today call: - Patch integration * Anthony thinks that we need more reviews * chicken-eng problem to become a maintainer * more patch reviews * need for autotest to run faster * not everybody use autotest * use patches for infrastructure * we need to get better

[Qemu-devel] [PATCH 2/2] Basic implementation of Sharp Zaurus SL-5500 collie PDA

2011-03-22 Thread Dmitry Eremin-Solenikov
Add very basic implementation of collie PDA emulation. The system lacks LoCoMo and graphics/sound emulation. Linux kernel boots up to mounting rootfs (theoretically it can be provided in pflash images). Signed-off-by: Dmitry Eremin-Solenikov dbarysh...@gmail.com --- Makefile.target |1 +

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

2011-03-22 Thread Alexander Graf
On 03/22/2011 03:47 PM, Anthony PERARD wrote: On Tue, Mar 22, 2011 at 14:23, Alexander Grafag...@suse.de wrote: On 03/01/2011 07:35 PM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Hi all, Here is the few change since the V10: - Add braces for blocks

Re: [Qemu-devel] [arm] Integrator/CP keyboard layout

2011-03-22 Thread jakub
Quoting Peter Maydell peter.mayd...@linaro.org: On 21 March 2011 23:03, Jakub Jermar ja...@jermar.eu wrote: I noticed that the layout of the PL050 keyboard used on Integrator/CP incompatibly changed sometime between Qemu 0.10.5 and Qemu 0.11.1. The current layout used in Qemu's model of

Re: [Qemu-devel] [PATCH v22 06/11] libcacard: initial commit

2011-03-22 Thread Stefan Hajnoczi
On Mon, Mar 21, 2011 at 10:07 PM, Alon Levy al...@redhat.com wrote: +# check for libcacard for smartcard support +if test $smartcard != no ; then +    smartcard=yes +    smartcard_cflags= +    # TODO - what's the minimal nss version we support? +    if test $smartcard_nss != no; then +      

Re: [Qemu-devel] [PATCH v22 06/11] libcacard: initial commit

2011-03-22 Thread Alon Levy
On Tue, Mar 22, 2011 at 03:25:11PM +, Stefan Hajnoczi wrote: On Mon, Mar 21, 2011 at 10:07 PM, Alon Levy al...@redhat.com wrote: +# check for libcacard for smartcard support +if test $smartcard != no ; then +    smartcard=yes +    smartcard_cflags= +    # TODO - what's the minimal

[Qemu-devel] [PATCH] spice-qemu-char: Fix flow control in client - guest direction

2011-03-22 Thread Hans de Goede
In the old spice-vmc device we used to have: last_out = virtio_serial_write(svc-port, p, MIN(len, VMC_MAX_HOST_WRITE)); if (last_out 0) ... Now in the chardev backend we have: last_out = MIN(len, VMC_MAX_HOST_WRITE); qemu_chr_read(scd-chr, p, last_out); if (last_out 0) { ... Which causes

Re: [Qemu-devel] [PATCH 1/2] Implement basic part of SA-1110/SA-1100

2011-03-22 Thread Peter Maydell
On 22 March 2011 14:53, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote:  static inline int arm_feature(CPUARMState *env, int feature) @@ -391,6 +392,19 @@ void cpu_arm_set_cp_io(CPUARMState *env, int cpnum,  #define ARM_CPUID_ARM946      0x41059461  #define ARM_CPUID_TI915T      

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

2011-03-22 Thread Alexander Graf
On 03/22/2011 03:47 PM, Anthony PERARD wrote: On Tue, Mar 22, 2011 at 14:23, Alexander Grafag...@suse.de wrote: On 03/01/2011 07:35 PM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Hi all, Here is the few change since the V10: - Add braces for blocks

Re: [Qemu-devel] [RFC] QCFG: a new mechanism to replace QemuOpts and option handling

2011-03-22 Thread Anthony Liguori
On 03/22/2011 08:01 AM, Markus Armbruster wrote: Type checking macros are feasible (see [*] for an existence proof), but things do get hairy, and the resulting error messages can be less than clear at times. That just gives you a warning. You can do much better things with

Re: [Qemu-devel] [arm] Integrator/CP keyboard layout

2011-03-22 Thread Peter Maydell
On 22 March 2011 15:19, ja...@jermar.eu wrote: Quoting Peter Maydell peter.mayd...@linaro.org: On 21 March 2011 23:03, Jakub Jermar ja...@jermar.eu wrote: I noticed that the layout of the PL050 keyboard used on Integrator/CP incompatibly changed sometime between Qemu 0.10.5 and Qemu 0.11.1.

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

2011-03-22 Thread Alexander Graf
On 03/22/2011 04:40 PM, Alexander Graf wrote: On 03/22/2011 03:47 PM, Anthony PERARD wrote: On Tue, Mar 22, 2011 at 14:23, Alexander Grafag...@suse.de wrote: On 03/01/2011 07:35 PM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com Hi all, Here is the few

Re: [Qemu-devel] [PATCH 1/2] Implement basic part of SA-1110/SA-1100

2011-03-22 Thread Dmitry Eremin-Solenikov
Hello, On 3/22/11, Peter Maydell peter.mayd...@linaro.org wrote: On 22 March 2011 14:53, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: static inline int arm_feature(CPUARMState *env, int feature) @@ -391,6 +392,19 @@ void cpu_arm_set_cp_io(CPUARMState *env, int cpnum, #define

[Qemu-devel] Re: [PATCH v3 3/3] piix_pci: optimize set irq path

2011-03-22 Thread Michael S. Tsirkin
On Tue, Mar 22, 2011 at 11:07:03PM +0900, Isaku Yamahata wrote: On Tue, Mar 22, 2011 at 03:40:16PM +0200, Michael S. Tsirkin wrote: On Tue, Mar 22, 2011 at 09:50:37AM +0900, Isaku Yamahata wrote: On Mon, Mar 21, 2011 at 04:10:22PM +0200, Michael S. Tsirkin wrote: @@ -37,8 +37,27 @@

[Qemu-devel] Re: [PATCH RESEND v3] fix vnc regression

2011-03-22 Thread Anthony Liguori
On 03/11/2011 03:10 AM, Wen Congyang wrote: This patch fix the following regression: 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits(). Signed-off-by: Wen Congyangwe...@cn.fujitsu.com Applied (version that used VNC_DIRTY_BITS). Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH] virtio-serial: don't crash on invalid input

2011-03-22 Thread Michael S. Tsirkin
Fix crash on invalid input in virtio-serial. Discovered by code review, untested. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-serial-bus.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index

Re: [Qemu-devel] [PATCH] qmp-commands.hx: Clean up mess of client_migrate_info

2011-03-22 Thread Anthony Liguori
On 03/09/2011 07:31 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com client_migrate_info was put into qmp-commands.hx in the middle of migrate_set_speed, between the command and it's description. In addition client_migrate_info put the description before the command

Re: [Qemu-devel] [PATCH v5 0/7] Introduce -display and make VNC optional

2011-03-22 Thread Anthony Liguori
On 03/16/2011 07:33 AM, jes.soren...@redhat.com wrote: From: Jes Sorensenjes.soren...@redhat.com Hi, This is v5 version of the -display patches and the option to make VNC optional. It introduces a new -display argument to consolidate the current -sdl/-curses/-nographic/-vnc arguments. v5

Re: [Qemu-devel] [arm] Integrator/CP keyboard layout

2011-03-22 Thread jakub
Quoting Peter Maydell peter.mayd...@linaro.org: I would tend to think that there is only one correct set of key codes that the keyboard on Integrator/CP may generate. Why do you think this? The keyboard isn't built in to the hardware, so the set of keycodes you get depends on the keyboard, not

[Qemu-devel] Re: [PATCH] virtio-serial: don't crash on invalid input

2011-03-22 Thread Amit Shah
On (Tue) 22 Mar 2011 [18:32:50], Michael S. Tsirkin wrote: Fix crash on invalid input in virtio-serial. Discovered by code review, untested. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-serial-bus.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/2] Implement basic part of SA-1110/SA-1100

2011-03-22 Thread Peter Maydell
On 22 March 2011 14:53, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: Basic implementation of DEC/Intel SA-1100/SA-1110 chips emulation. The other important point is that these cores are ARMv4, and at the moment target-arm/ kind of assumes ARMv5. I believe there have been patches proposed

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

2011-03-22 Thread Anthony PERARD
On Tue, 22 Mar 2011, Alexander Graf wrote: On 03/22/2011 04:40 PM, Alexander Graf wrote: make[1]: *** [qemu-system-x86_64] Error 1 This should be the correct fix: diff --git a/Makefile.target b/Makefile.target index c0db745..91bbf39 100644 --- a/Makefile.target +++ b/Makefile.target

Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 00/15] Xen device model support

2011-03-22 Thread Alexander Graf
On 03/22/2011 06:22 PM, Anthony PERARD wrote: On Tue, 22 Mar 2011, Alexander Graf wrote: On 03/22/2011 04:40 PM, Alexander Graf wrote: make[1]: *** [qemu-system-x86_64] Error 1 This should be the correct fix: diff --git a/Makefile.target b/Makefile.target index c0db745..91bbf39 100644 ---

[Qemu-devel] [PATCH] hw/versatilepb, realview: Fix condition for instantiation of onboard NIC

2011-03-22 Thread Peter Maydell
Correct the condition determining whether we instantiate the onboard NIC or a PCI card NIC on VersatilePB and Realview boards. This was broken in two ways: (1) if the user asked for two default NICs (-net nic -net nic) we would crash trying to strcmp() a NULL pointer (2) if the user asked for

[Qemu-devel] [PATCH] net: Improve the warnings for dubious command line option combinations

2011-03-22 Thread Peter Maydell
Improve the warnings we give if the user specified a combination of -net options which don't make much sense: * Fix a bug where we would only complain about the first VLAN having no NIC or no host network connection; we now diagnose this situation for all VLANs * Don't warn about anything

[Qemu-devel] Re: [PATCH 1/2] Implement basic part of SA-1110/SA-1100

2011-03-22 Thread Juan Quintela
Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: +static inline void strongarm_rtc_alarm_tick(void *opaque) +{ +StrongARMRTCState *s = (StrongARMRTCState *) opaque; cast is not needed. Just a NOP in C. (lost of places) +static const VMStateDescription vmstate_strongarm_rtc_regs = {

[Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-22 Thread Peter Maydell
On 5 March 2011 16:50, Peter Maydell peter.mayd...@linaro.org wrote: I've appended a draft of a suggested extra section for docs/migration.txt so you can tell me if I've misunderstood it all :-) Ping? In particular if somebody can fill in the [XXX] bit for me (and correct any other mistakes!)

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-22 Thread Jordan Justen
2011/3/22 Gleb Natapov g...@redhat.com: On Mon, Mar 21, 2011 at 02:23:31PM -0700, Jordan Justen wrote: There is one big difference here between how VM's generally specify the boot disk vs. a UEFI system.  In a UEFI system, normally the boot path is not known during the first boot of the

[Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-22 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 5 March 2011 14:59, Paolo Bonzini pbonz...@redhat.com wrote: On 03/05/2011 01:34 PM, Peter Maydell wrote: sorry, I miss this email before. Ah. I was just following Juan's suggestion: - if you don't care about backward compatibility, just add

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-22 Thread Gleb Natapov
On Tue, Mar 22, 2011 at 12:28:51PM -0700, Jordan Justen wrote: 2011/3/22 Gleb Natapov g...@redhat.com: On Mon, Mar 21, 2011 at 02:23:31PM -0700, Jordan Justen wrote: There is one big difference here between how VM's generally specify the boot disk vs. a UEFI system.  In a UEFI system,

[Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers

2011-03-22 Thread Peter Maydell
On 22 March 2011 19:53, Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: Migration from the old version to the new version can be supported if it is OK for the new fields to remain in their default state [XXX is this right? are they zeroed, or do they get

Re: [Qemu-devel] eepro100: feature is missing in this emulation: unknown word write

2011-03-22 Thread Sébastien BRICE
Le 21 mars 2011 22:48, Alex Williamson alex.william...@redhat.com a écrit : 2011/3/21 Sébastien BRICE s...@so-sweet.org: Hi everyone I have been using qemu-kvm with success the last two years and its really amazing. I am new to this mailing list and i am requesting your assistance

[Qemu-devel] Presito Personale assicurativo

2011-03-22 Thread Lidia
Prestiti aziendali - Finanziamenti ai privati - Agevolazioni per le aziende in crisi - Servizi innovativi Prestito con piano assicurativo ( per tutte le categorie ) E' un prestito personale per tutti coloro che desiderano ottenere un finanziamento in tempi rapidi con la presentazione di pochi

Re: [Qemu-devel] OVMF, SeaBIOS non-CSM based legacy boot

2011-03-22 Thread Jordan Justen
2011/3/22 Gleb Natapov g...@redhat.com: On Tue, Mar 22, 2011 at 12:28:51PM -0700, Jordan Justen wrote: Can this cover a full path like this? /pci@i0cf8/ide@1,1/drive@1/disk@0 = partition0 = /path/abc.efi Open Firmware have syntax for that. /pci@i0cf8/ide@1,1/drive@1/disk@0:0,/path/abc.efi

[Qemu-devel] [PATCH v4 0/4] piix_pci: optimize irq data path

2011-03-22 Thread Isaku Yamahata
Okay now v4. Main changes is - use pirq, pci_intx instead of irq_num in piix_pci.c - patch 4/4 cleans the code a bit 4/4 needs more extensive tests. So please feel free to pick it up now or drop it for now. patch description: This patch series optimizes irq data path of piix_pci. So far piix3

[Qemu-devel] [PATCH v4 4/4] piix_pci: load path clean up

2011-03-22 Thread Isaku Yamahata
The previous patch didn't change the behavior when load, it resulted in ugly code. This patch cleans it up. With this patch, pic irq lines are manipulated when loaded. It is expected that it won't change the behaviour because the interrupts are level: at the moment e.g. pci devices already

  1   2   >