Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Gerd Hoffmann
On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api -

Re: [Qemu-devel] [RFC v3 30/56] rtl8139: convert to memory API

2011-07-13 Thread Avi Kivity
On 07/13/2011 01:41 AM, Alex Williamson wrote: static int rtl8139_post_load(void *opaque, int version_id) { @@ -3283,7 +3242,7 @@ static void rtl8139_pre_save(void *opaque) rtl8139_set_next_tctr_time(s, current_time); s-TCTR = muldiv64(current_time - s-TCTR_base,

Re: [Qemu-devel] [PATCHv3] qxl: QXL_IO_UPDATE_AREA: pass ram-update_area directly to update_area

2011-07-13 Thread Gerd Hoffmann
Hi, -QXLRect update = d-ram-update_area; qxl_spice_update_area(d, d-ram-update_surface, -update, NULL, 0, 0); +d-ram-update_area, NULL, 0, 1); No, -ESECURITY. With this in place the guest can change the update rect while spice-server is working with it. cheers, Gerd

Re: [Qemu-devel] PCI with Xilinx virtex-ml507 board

2011-07-13 Thread Edgar E. Iglesias
Hi, Hi the ethlite driver is this one: http://lxr.linux.no/linux+v2.6.39/drivers/net/xilinx_emaclite.c The easy way is probably to look at the petalogix s3adsp board dtb distributed with qemu. Iirc, the command to make readable is dtc -I dtb -O dts -o tree.dts tree.dtb. It should be possible to

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Gerd Hoffmann
On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with update_area_async correctly reverted change to update_area api -

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the monitor command finishes though, which I think we should avoid. cheers, Gerd

Re: [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete

2011-07-13 Thread Gerd Hoffmann
Hi, +void qxl_render_primary_updated(PCIQXLDevice *qxl, QXLRect *dirty, +uint32_t num_dirty); @@ -65,6 +65,10 @@ struct SimpleSpiceDisplay { int notify; int running; +#if SPICE_INTERFACE_QXL_MINOR= 1 +QXLRect *dirty_rects; +uint32_t

Re: [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort)

2011-07-13 Thread Gerd Hoffmann
Hi, The solution of ignoring the request is bad, but better then aborting and a real solution would probably be in spice to not call get_command in the first place. Isn't the plan to fix spice-server this way? cheers, Gerd

Re: [Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

2011-07-13 Thread Kevin Wolf
Am 12.07.2011 22:35, schrieb Luiz Capitulino: Please, see individual patches for details. v2 o Correct man-page text o Document -drive options in qemu-config.c qemu-config.c |6 ++ qemu-options.hx |8 2 files changed, 14 insertions(+), 0 deletions(-) Thanks,

Re: [Qemu-devel] Fwd: [PATCH] Introduce info migrate-times monitor command

2011-07-13 Thread Michal Novotny
Hi Markus, I'd like to but when I tried to send it to the qemu-devel@nongnu.org using `git send-email` just a copy was going to my mailbox but nothing was going to the qemu-devel list. Any idea what may be wrong and how to fix it? Thanks, Michal On 07/13/2011 07:48 AM, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread Artyom Tarasenko
Hi, On Wed, Jul 13, 2011 at 5:30 AM, Tsuneo Saito tsnsa...@gmail.com wrote: Hi, This patch series implements sparcv9 stfa/ldfa instructions with non block-transfer ASIs that implementations seem to be left unfinished. This patch also adds fp_disabled exception checks on stfa/ldfa as they

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:11:35AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack qxl-render updated to work with

Re: [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort)

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:54:55AM +0200, Gerd Hoffmann wrote: Hi, The solution of ignoring the request is bad, but better then aborting and a real solution would probably be in spice to not call get_command in the first place. Isn't the plan to fix spice-server this way? I can't

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the monitor command finishes though,

Re: [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:51:14AM +0200, Gerd Hoffmann wrote: Hi, +void qxl_render_primary_updated(PCIQXLDevice *qxl, QXLRect *dirty, +uint32_t num_dirty); @@ -65,6 +65,10 @@ struct SimpleSpiceDisplay { int notify; int running; +#if

Re: [Qemu-devel] [PATCHv3] qxl: QXL_IO_UPDATE_AREA: pass ram-update_area directly to update_area

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 08:56:27AM +0200, Gerd Hoffmann wrote: Hi, -QXLRect update = d-ram-update_area; qxl_spice_update_area(d, d-ram-update_surface, -update, NULL, 0, 0); +d-ram-update_area, NULL, 0, 1); No, -ESECURITY. With this in place the guest can change the

Re: [Qemu-devel] live block copy/stream/snapshot discussion

2011-07-13 Thread Stefan Hajnoczi
On Tue, Jul 12, 2011 at 5:10 PM, Kevin Wolf kw...@redhat.com wrote: Am 12.07.2011 17:45, schrieb Stefan Hajnoczi: The command synopses are as follows: block_stream Copy data from a backing file into a block device. If the optional 'all' argument is true, this operation is

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
# ps axwu ... qemu00 29957 0.5 9.8 480568 405228 ? Sl Jul12 7:41 /usr/bin/qemu-system-x86_64 -runas ... ... # ps axwu -L ... qemu00 29957 29957 0.23 9.8 480568 405228 ? Sl Jul12 2:49 /usr/bin/qemu-system-x86_64 -runas ... root 29957 29959 0.33 9.8

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
correction: s/other distro's/other operating systems/g -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/807893 Title: qemu privilege escalation Status in QEMU: Confirmed Bug description: If

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
Once you have code execution in the process, you can modify the others threads execution (if required) to execute your own code. With full capabilities, it would be trivial to escape from a chroot on a normal Linux kernel (grsecurity with appropriate kernel chroot restrictions enabled would reduce

Re: [Qemu-devel] [PATCH v2 3/5] block: add bdrv_get_mapping()

2011-07-13 Thread Kevin Wolf
Am 11.07.2011 21:55, schrieb Devin Nakamura: Signed-off-by: Devin Nakamura devin...@gmail.com --- block.c | 14 ++ block.h |2 ++ 2 files changed, 16 insertions(+), 0 deletions(-) I only received patches 3-5 for v2, the first two seem to be missing. Kevin

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the

Re: [Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Stefan Hajnoczi
On Wed, Jul 13, 2011 at 11:12 AM, Andrew Griffiths 807...@bugs.launchpad.net wrote: Once you have code execution in the process, you can modify the others threads execution (if required) to execute your own code. With full capabilities, it would be trivial to escape from a chroot on a normal

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 10:51, Alon Levy wrote: On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl driver. fixed update_area_async to not use QXLRect on stack

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Daniel P. Berrange
On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Daniel P. Berrange
On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why you are doing that. It makes the file being written *after* the monitor command finishes though,

Re: [Qemu-devel] [PULL 0/8] ARM patch queue

2011-07-13 Thread Peter Maydell
Ping^2 ? -- PMM On 30 June 2011 10:24, Peter Maydell peter.mayd...@linaro.org wrote: Ping? thanks -- PMM On 22 June 2011 18:33, Peter Maydell peter.mayd...@linaro.org wrote: This is a pull request for various ARM related patches which have been on the list for a while (mostly but not

[Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Andrew Griffiths
Hello Stefan, I was explaining the threads / uids per thread issue, in case it wasn't obvious of what the impact was, or how to exploit that issue (in case someone was wondering about that). It was not directed at Chris in any shape or form, nor was it about libvirt. -- You received this bug

Re: [Qemu-devel] [PATCH] tcg/README: Expand advice on number of TCG ops per target insn

2011-07-13 Thread Peter Maydell
Ping? On 22 June 2011 15:40, Peter Maydell peter.mayd...@linaro.org wrote: Expand the note on the number of TCG ops generated per target insn, to be clearer about the range of applicability of the 20 op rule of thumb. Also add a note about the hard MAX_OP_PER_INSTR limit. Signed-off-by:

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread tsnsaito
Hi, At Wed, 13 Jul 2011 10:57:19 +0200, Artyom Tarasenko wrote: On Wed, Jul 13, 2011 at 5:30 AM, Tsuneo Saito tsnsa...@gmail.com wrote: Hi, This patch series implements sparcv9 stfa/ldfa instructions with non block-transfer ASIs that implementations seem to be left unfinished. This

Re: [Qemu-devel] [Bug 807893] Re: qemu privilege escalation

2011-07-13 Thread Stefan Hajnoczi
On Wed, Jul 13, 2011 at 11:50 AM, Andrew Griffiths 807...@bugs.launchpad.net wrote: I was explaining the threads / uids per thread issue, in case it wasn't obvious of what the impact was, or how to exploit that issue (in case someone was wondering about that). It was not directed at Chris in

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm. I can see why

Re: [Qemu-devel] [PATCHv3] async + suspend reworked

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 12:45:24PM +0200, Gerd Hoffmann wrote: On 07/13/11 10:51, Alon Levy wrote: On Wed, Jul 13, 2011 at 08:43:57AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: v2-v3: builds correctly with older and newer spice, and runs with older and newer qxl

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
Hi, I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's becoming pretty ugly. Also I guess what Daniel described is possible, but it changes the usage of screendump even more. Is turning do_screen_dump to async viable? I think I'll work on it. Daniel's suggestion is a

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread Mark Cave-Ayland
On 13/07/11 12:06, tsnsa...@gmail.com wrote: Nice series! May I ask what have you used as a test case to discover the problem? I found the problem when I was trying to run the linux/sparc64 kernel. It seemed that copy_to_user() did not work as expected. That's good to hear. How far have you

Re: [Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 10:01:49 +0200 Kevin Wolf kw...@redhat.com wrote: Am 12.07.2011 22:35, schrieb Luiz Capitulino: Please, see individual patches for details. v2 o Correct man-page text o Document -drive options in qemu-config.c qemu-config.c |6 ++

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 12:41:48 +0200 Gerd Hoffmann kra...@redhat.com wrote: On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will happen asynchronously on surface_updated callback. Hmm.

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 13:46:50 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, I'd rather try the MONITOR_CMD_ASYNC thing then the cond variable, it's becoming pretty ugly. Also I guess what Daniel described is possible, but it changes the usage of screendump even more. Is

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 14:29:16 +0300 Alon Levy al...@redhat.com wrote: On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote: On 07/12/11 15:55, Alon Levy wrote: Later the save will

Re: [Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-13 Thread tsnsaito
Hi, At Wed, 13 Jul 2011 13:09:28 +0100, Mark Cave-Ayland wrote: Nice series! May I ask what have you used as a test case to discover the problem? I found the problem when I was trying to run the linux/sparc64 kernel. It seemed that copy_to_user() did not work as expected. That's good

Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command block_set for dynamic block params change

2011-07-13 Thread Supriya Kannery
Updated block_set command to accept multiple -drive parameters. Also, added code for re-opening of device file with original flags, incase opening file using changed hostcache setting fails. -- New command block_set added for

[Qemu-devel] [PATCH v3 2/6] block: add bdrv_get_conversion_options()

2011-07-13 Thread Devin Nakamura
Signed-off-by: Devin Nakamura devin...@gmail.com --- block.c | 13 + block.h |2 ++ 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 24a25d5..5c0ba2d 100644 --- a/block.c +++ b/block.c @@ -3018,3 +3018,16 @@ out: return ret; } +

[Qemu-devel] [PATCH v3 6/6] block: add bdrv_copy_header()

2011-07-13 Thread Devin Nakamura
Signed-off-by: Devin Nakamura devin...@gmail.com --- block.c | 12 block.h |2 ++ 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 86a4752..0f38aff 100644 --- a/block.c +++ b/block.c @@ -3105,3 +3105,15 @@ int bdrv_map(BlockDriverState

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote: On Wed, 13 Jul 2011 14:29:16 +0300 Alon Levy al...@redhat.com wrote: On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: On 07/13/11 11:29, Alon Levy wrote: On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd

[Qemu-devel] [PATCH v3 1/6] block: add basic conversion api

2011-07-13 Thread Devin Nakamura
add functions to block driver interface to support inplace image conversion Signed-off-by: Devin Nakamura devin...@gmail.com --- block_int.h | 70 +++ 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/block_int.h

[Qemu-devel] [PATCH v3 3/6] block: add bdrv_open_conversion_target()

2011-07-13 Thread Devin Nakamura
Conflicts: block.h Signed-off-by: Devin Nakamura devin...@gmail.com --- block.c | 31 +++ block.h |3 +++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 5c0ba2d..7d3bc67 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [PATCH v3 4/6] block: add bdrv_get_mapping()

2011-07-13 Thread Devin Nakamura
Conflicts: block.h Signed-off-by: Devin Nakamura devin...@gmail.com --- block.c | 29 + block.h |2 ++ 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 7d3bc67..cda600b 100644 --- a/block.c +++ b/block.c @@ -3062,3

Re: [Qemu-devel] [QAPI+QGA 3/3] QEMU Guest Agent (virtagent) v6

2011-07-13 Thread Daniel P. Berrange
On Tue, Jul 05, 2011 at 08:21:36AM -0500, Michael Roth wrote: BUILD/USAGE build: ./configure --target-list=x86_64-softmmu make make qemu-ga #should be built on|for target guest start guest: qemu \ -drive file=/home/mdroth/vm/rhel6_64_base.raw,snapshot=off,if=virtio \ -net

[Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-13 Thread Michal Novotny
Hi, this is the implementation of the info migrate-times command I did to get the times for the migration to get times for each migration stage. Based on the fact migration itself is just the vmsave on the source host and vmload on destination host this function can be also useful to get the save

[Qemu-devel] [PATCH v3 5/6] block: add bdrv_map()

2011-07-13 Thread Devin Nakamura
Signed-off-by: Devin Nakamura devin...@gmail.com --- block.c | 14 ++ block.h |2 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index cda600b..86a4752 100644 --- a/block.c +++ b/block.c @@ -3091,3 +3091,17 @@ int

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 15:56:55 +0300 Alon Levy al...@redhat.com wrote: On Wed, Jul 13, 2011 at 09:33:26AM -0300, Luiz Capitulino wrote: On Wed, 13 Jul 2011 14:29:16 +0300 Alon Levy al...@redhat.com wrote: On Wed, Jul 13, 2011 at 12:41:48PM +0200, Gerd Hoffmann wrote: On 07/13/11

Re: [Qemu-devel] PCI with Xilinx virtex-ml507 board

2011-07-13 Thread Lê Đức Tài
On Jul 13, 2011 14:09, Edgar E. Iglesias edgar.igles...@gmail.com wrote: Hi, Hi the ethlite driver is this one: http://lxr.linux.no/linux+v2.6.39/drivers/net/xilinx_emaclite.c The easy way is probably to look at the petalogix s3adsp board dtb distributed with qemu. Iirc, the command

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
On 07/13/11 14:32, Luiz Capitulino wrote: Not sure. Luiz, do we have async monitor commands meanwhile? Not yet, this is a QAPI feature that should land soon, but it's not available yet. Hmm. Alon, is it an option to just leave the whole qxl-render stuff in sync mode for now and convert it

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Alon Levy
On Wed, Jul 13, 2011 at 03:45:16PM +0200, Gerd Hoffmann wrote: On 07/13/11 14:32, Luiz Capitulino wrote: Not sure. Luiz, do we have async monitor commands meanwhile? Not yet, this is a QAPI feature that should land soon, but it's not available yet. Hmm. Alon, is it an option to just

Re: [Qemu-devel] [PATCH] Introduce info migrate-times monitor command

2011-07-13 Thread Paolo Bonzini
On 07/13/2011 03:06 PM, Michal Novotny wrote: +uint64_t time_get(const char *name, int stage); +void time_set(const char *name, int stage, uint64_t tv); +void time_add(const char *name, int stage, uint64_t tv); +void time_add2(const char *name, int stage, uint64_t time1, uint64_t time2);

[Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Luiz Capitulino
From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple header files that depend only on the compiler macros, so including qemu-common.h is overkill. Besides, qemu-common.h is bloated

Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

2011-07-13 Thread Gerd Hoffmann
Hi, Hmm. Alon, is it an option to just leave the whole qxl-render stuff in sync mode for now and convert it later? Or will that have bad interactions with QXL_IO_UPDATE_AREA_ASYNC being used by the guest? It's not a problem. I do have a working version using async monitor command, but I

[Qemu-devel] [PATCH 3/4] Add generic drive hotplugging

2011-07-13 Thread Alexander Graf
The monitor command for hotplugging is in i386 specific code. This is just plain wrong, as S390 just learned how to do hotplugging too and needs to get drives for that. So let's add a generic copy to generic code that handles drive_add in a way that doesn't have pci dependencies. All pci specific

[Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included

2011-07-13 Thread Luiz Capitulino
From: Luiz Capitulino lcapitul...@gmail.com Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of the macro GCC_FMT_ATTR to error.h, however compiler.h is not included by error.h This will cause a build error when files including error.h don't include qemu-common.h (or compiler.h).

[Qemu-devel] [PATCH 0/4] S390 virtio hotplug v2

2011-07-13 Thread Alexander Graf
Hey guys, this patch set adds support for hotplug add on S390. Apparently it's the first non-x86 platform receiving so much love in Qemu, so I've stumbled over some very basic #if defined(TARGET_I386) cases that just shouldn't be there. It's trying to make things as generic as possible. I've

[Qemu-devel] [PATCH v2 0/3]: Fix build issue with error.h

2011-07-13 Thread Luiz Capitulino
A .c file including error.h and not including qemu-common.h will break the build, because error.h uses a macro defined in qemu-common.h. The simple and obvious fix would be to change error.h to include qemu-common.h. But this is overkill, so this series does some splitting in qemu-common.h and

[Qemu-devel] [PATCH 1/4] [S390] Add hotplug support

2011-07-13 Thread Alexander Graf
I just submitted a few patches that enable the s390 virtio bus to receive a hotplug add event. This patch implements the qemu side of it, so that new hotplug events can be submitted to the guest. Signed-off-by: Alexander Graf ag...@suse.de --- v1 - v2: - make s390 virtio hoplug code

[Qemu-devel] [PATCH 2/4] Compile device-hotplug on all targets

2011-07-13 Thread Alexander Graf
All guest targets could potentially implement hotplugging. With the next patches in this set I will also reflect this in the monitor interface. So let's always compile it in. It shouldn't hurt. Signed-off-by: Alexander Graf ag...@suse.de --- Makefile.target |5 - 1 files changed, 4

[Qemu-devel] [PATCH 4/4] Expose drive_add on all architectures

2011-07-13 Thread Alexander Graf
All architectures can now use drive_add on the monitor. This of course does not mean that there is hotplug support for the specific platform, so in order to actually make use of the new drives you still need to have a hotplug capable device. Signed-off-by: Alexander Graf ag...@suse.de ---

[Qemu-devel] [PATCH 01/15] arm-semi: Provide access to CLI arguments passed through the -append option

2011-07-13 Thread riku . voipio
From: Cédric VINCENT cedric.vinc...@st.com This patch basically adapts the new semi-hosting command-line support -- introduced by Wolfgang Schildbach in the commit 2e8785ac -- for use in system-mode. Note that the arm_cmdline_len and host_cmdline_len variables were renamed respectively

[Qemu-devel] [Bug 809912] [NEW] qemu-kvm -m bigger 4096 aborts with 'Bad ram offset'

2011-07-13 Thread Lutz Vieweg
Public bug reported: When I try to start a virtual machine (x86_64 guest on a x86_64 host that has 32GB memory, using kvm_amd module, both host and guest running linux-2.6.39 kernels) with qemu-system-x86_64 -cpu host -smp 2 -m 4096 ..., shortly after the guest kernel starts, qemu aborts with a

[Qemu-devel] [PATCH 00/15] v2: pending linux-user patches

2011-07-13 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org This time including Wesleys patches I missed last time, replacing his mips: eabi syscall support for 64-bit args patch with a my version, and fixing cacheflush syscall as requested bt Cédric. Patches also available in the git repository at:

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread malc
On Wed, 13 Jul 2011, Luiz Capitulino wrote: From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple header files that depend only on the compiler macros, so including qemu-common.h

[Qemu-devel] [PATCH 02/15] linux-user: Add support for KD...LED ioctls

2011-07-13 Thread riku . voipio
From: Cédric VINCENT cedric.vinc...@st.com DirectFB-1.0 uses at least one of the four added ioctls, and the three others were added for completeness. This patch was validated with the program setleds and the following Makefile: SETLEDS_INIT = setleds -v -num -caps -scroll SETLEDS_TESTS

[Qemu-devel] [PATCH 06/15] linux-user: Implement prlimit64 syscall

2011-07-13 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Implement the prlimit64 syscall. Slightly modified to apply upstream -Riku Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/syscall.c | 43

[Qemu-devel] [PATCH 08/15] mips: sigaltstack args

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra terps...@debian.org The syscall sigaltstack takes two parameters, not zero. This patch should have no impact as only values above 4 influence the runtime behaviour. Nevertheless, it is wrong. Signed-off-by: Wesley W. Terpstra terps...@debian.org Signed-off-by: Riku

[Qemu-devel] [PATCH 07/15] linux-user/syscall.c: Enforce pselect6 sigset size restrictions

2011-07-13 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Enforce the same restriction on the size of the sigset passed to pselect6 as the Linux kernel does. This is both correct and silences a gcc 4.6 warning about a write-only variable. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by:

[Qemu-devel] [PATCH 09/15] mips: missing syscall returns wrong errno

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra terps...@debian.org Return -TARGET_ENOSYS instead of -ENOSYS from linux-user/main.c * Caused strange 'Level 2 synchronization messages' instead of correctly reporting the syscall was missing. * Made glibc simply fail instead of using older syscalls Signed-off-by:

[Qemu-devel] [PATCH 13/15] linux-user: correct syscall 123 on sh4

2011-07-13 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org As reported by Cédric VINCENT: The syscall #123 on SH4 should be TARGET_NR_cacheflush instead of TARGET_NR_modify_ldt [1]. The only consequence of this misnaming is that many Unsupported syscall warnings are issued when emulating JIT compilers.

[Qemu-devel] [PATCH 03/15] linux-user: Add support for more VT ioctls

2011-07-13 Thread riku . voipio
From: Cédric VINCENT cedric.vinc...@st.com DirectFB-1.0 uses at least two of the four added ioctls, and the two others were added for completeness. This patch was validated with the program vlock -all/-new. Signed-off-by: Cédric VINCENT cedric.vinc...@st.com Cc: Riku Voipio riku.voi...@iki.fi

[Qemu-devel] [PATCH 15/15] linux-user/signal.c: Rename s390 target_ucontext fields to fix ia64

2011-07-13 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org The ia64 sys/ucontext.h defines macros 'uc_link', 'uc_sigmask' and 'uc_stack'. Rename the s390 target_ucontext struct members to tuc_*, bringing them into line with the other targets and fixing a compile failure on ia64 hosts caused by this clash.

[Qemu-devel] [PATCH 10/15] mips: null pointer deref should segfault

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra terps...@debian.org Dereferencing a null pointer causes an exception 0xC (EXCP_AdEL) instead of EXCP_TLBL. This should also trigger a segfault. Signed-off-by: Wesley W. Terpstra terps...@debian.org Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/main.c

[Qemu-devel] [PATCH 14/15] linux-user: make MIPS and ARM eabi use same argument reordering

2011-07-13 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org MIPS uses similar calling convention than ARM eabi, where when using 64-bit values some registers are skipped. This patch makes MIPS and ARM eabi share the argument reordering code. This affects ftruncate64, creating insane sized fails (or just failing).

[Qemu-devel] [PATCH 04/15] linux-user: Add support for even more FB ioctls

2011-07-13 Thread riku . voipio
From: Cédric VINCENT cedric.vinc...@st.com This patch was validated with programs from DirectFB-1.0 and WebKit/DirectFB. Signed-off-by: Cédric VINCENT cedric.vinc...@st.com Cc: Riku Voipio riku.voi...@iki.fi Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/ioctls.h|5

[Qemu-devel] [PATCHv4 08/11] qxl: bump pci rev

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann kra...@redhat.com Inform guest drivers about the new features I/O commands we have now (async commands, S3 support) if building with newer spice, i.e. if SPICE_INTERFACE_QXL_MINOR = 1. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c | 25

[Qemu-devel] [PATCH 12/15] mips: rlimit codes are not the same

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra terps...@debian.org The codes for get/setrlimit differ between linux target platforms. This patch adds conversion. This is important else programs (rsyslog, python, ...) can go into a near infinite loop trying to close all the file descriptors from 0 to -1.

[Qemu-devel] [PATCHv4 05/11] qxl: add io_port_to_string

2011-07-13 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 61 - 1 files changed, 60 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index e41f8cc..2ecc932 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -408,6 +408,64 @@ static

[Qemu-devel] [PATCH 05/15] linux-user: Add syscall numbers from kernel 2.6.39.2

2011-07-13 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Add syscall numbers for new syscall numbers; this brings us into line with Linux 2.6.39.2. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/alpha/syscall_nr.h | 23

[Qemu-devel] [PATCHv4 02/11] spice: add qemu_spice_display_init_common

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann kra...@redhat.com Factor out SimpleSpiceDisplay initialization into qemu_spice_display_init_common() and call it from both qxl.c (for vga mode) and spice-display.c Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c |7 +-- ui/spice-display.c | 17

[Qemu-devel] [PATCHv4 06/11] qxl: error handling fixes and cleanups.

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann kra...@redhat.com Add qxl_guest_bug() function which is supposed to be called in case sanity checks of guest requests fail. It raises an error IRQ and logs a message in case guest debugging is enabled. Make PANIC_ON() abort instead of exit. That macro should be used for

[Qemu-devel] [PATCH 11/15] mips: rlimit incorrectly converts values

2011-07-13 Thread riku . voipio
From: Wesley W. Terpstra terps...@debian.org Byte swap was applied in the wrong order with testing for RLIM_INFINITY. On mips bigendian from an amd64 system this results in infinity being misinterpretted as 2^31-1. This is a serious bug because it causes setrlimit stack size to kill all child

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Peter Maydell
On 13 July 2011 15:23, Luiz Capitulino lcapitul...@redhat.com wrote: diff --git a/compiler.h b/compiler.h new file mode 100644 index 000..2dfc2c6 --- /dev/null +++ b/compiler.h @@ -0,0 +1,31 @@ +#ifndef COMPILER_H +#define COMPILER_H If we don't have a rule that says that all new

[Qemu-devel] [PATCHv4 04/11] qxl: fix surface tracking locking

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann kra...@redhat.com Surface tracking needs proper locking since it is used from vcpu and spice worker threads, add it. Also reset the surface counter when zapping all surfaces. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl.c | 13 - hw/qxl.h |2

[Qemu-devel] [PATCHv4 09/11] qxl: use QXL_REVISION_*

2011-07-13 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 252 +++- hw/qxl.h | 15 +++- ui/spice-display.c | 46 -- ui/spice-display.h | 25 +- 4 files changed, 282 insertions(+), 56 deletions(-) diff --git

[Qemu-devel] [PATCHv4 01/11] spice: add worker wrapper functions.

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann kra...@redhat.com Add wrapper functions for all spice worker calls. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl-render.c|4 +- hw/qxl.c | 32 +- ui/spice-display.c | 95 ---

[Qemu-devel] [PATCHv4 07/11] qxl: make qxl_guest_bug take variable arguments

2011-07-13 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 19 --- hw/qxl.h |2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 3d1f108..34a5f78 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -124,11 +124,15 @@ static void

[Qemu-devel] [PATCHv4 00/11] async + suspend reworked

2011-07-13 Thread Alon Levy
v3-v4 changes: * drop all qxl-render changes, it will still use sync update_area. This means: 1. running with vnc and spice together can still trigger lockup with libvirt due to [vcpu block on pipe; worker wait for pipe release; iothread blocked because vcpu holding mutex] and client side

[Qemu-devel] [PATCHv4 03/11] qxl: remove qxl_destroy_primary()

2011-07-13 Thread Alon Levy
From: Gerd Hoffmann kra...@redhat.com We'll have to move qemu_spice_destroy_primary_surface() out of qxl_destroy_primary(). That makes the function pretty pointless, so zap it and open code the two lines instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl-render.c|4 +-

[Qemu-devel] [PATCHv4 11/11] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3S4 support

2011-07-13 Thread Alon Levy
Add two new IOs. QXL_IO_FLUSH_SURFACES - equivalent to update area for all surfaces, used to reduce vmexits from NumSurfaces to 1 on guest S3, S4 and resolution change (windows driver implementation is such that this is done on each of those occasions). QXL_IO_FLUSH_RELEASE - used to ensure

[Qemu-devel] [PATCHv4 10/11] qxl: only disallow specific io's in vga mode

2011-07-13 Thread Alon Levy
Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b34e8d0..5ea4c76 100644 ---

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread malc
On Wed, 13 Jul 2011, Luiz Capitulino wrote: On Wed, 13 Jul 2011 18:37:31 +0400 (MSD) malc av1...@comtv.ru wrote: On Wed, 13 Jul 2011, Luiz Capitulino wrote: From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h.

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 18:37:31 +0400 (MSD) malc av1...@comtv.ru wrote: On Wed, 13 Jul 2011, Luiz Capitulino wrote: From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-13 Thread Luiz Capitulino
On Wed, 13 Jul 2011 16:04:52 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 13 July 2011 15:23, Luiz Capitulino lcapitul...@redhat.com wrote: diff --git a/compiler.h b/compiler.h new file mode 100644 index 000..2dfc2c6 --- /dev/null +++ b/compiler.h @@ -0,0 +1,31 @@

Re: [Qemu-devel] [PATCH 1/4] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly

2011-07-13 Thread Blue Swirl
On Wed, Jul 13, 2011 at 6:30 AM, Tsuneo Saito tsnsa...@gmail.com wrote: This patch implements sparcv9 ldfa/lddfa/ldqfa instructions with non block-load ASIs. Signed-off-by: Tsuneo Saito tsnsa...@gmail.com ---  target-sparc/op_helper.c |   16 +++-  1 files changed, 11

  1   2   >