[Qemu-devel] [PATCH 03/32] vvfat: Fix partition table

2012-07-05 Thread Markus Armbruster
Unless parameter ":floppy:" is given, vvfat creates a virtual image with DOS MBR defining a single partition which holds the FAT file system. The size of the virtual image depends on the width of the FAT: 32 MiB (CHS 64, 16, 63) for 12 bit FAT, 504 MiB (CHS 1024, 16, 63) for 16 and 32 bit FAT, lea

[Qemu-devel] [PATCH 31/32] blockdev: Drop redundant CHS validation for if=ide

2012-07-05 Thread Markus Armbruster
Leave it to ide_init_drive(). Signed-off-by: Markus Armbruster --- blockdev.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 3274923..201c641 100644 --- a/blockdev.c +++ b/blockdev.c @@ -330,15 +330,15 @@ DriveInfo *drive_init(QemuOpts

[Qemu-devel] [PATCH 11/32] hd-geometry: Factor out guess_chs_for_size()

2012-07-05 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/hd-geometry.c | 32 1 files changed, 20 insertions(+), 12 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index db47846..1a58894 100644 --- a/hw/hd-geometry.c +++ b/hw/hd-geometry.c @@ -97,14 +97,31 @@ stat

Re: [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message

2012-07-05 Thread Michael Tokarev
On 06.07.2012 06:42, Amos Kong wrote: > On 30/06/12 10:02, ak...@redhat.com wrote: >> From: Amos Kong >> >> Currently qemu outputs some low-level error in qemu-sockets.c >> when failed to start vnc server. >> eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known' >> >> Some libvirt users coul

Re: [Qemu-devel] [PATCH v2] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Jan Kiszka
On 2012-07-06 08:04, Dunrong Huang wrote: > Users may pass the following parameters to qemu: > $ qemu-kvm -net nic -net user,smb= ... > $ qemu-kvm -net nic -net user,smb ... > $ qemu-kvm -net nic -net user,smb=bad_directory ... > > In these cases, qemu started successfully while samba

Re: [Qemu-devel] status of pvscsi patches

2012-07-05 Thread Paolo Bonzini
Il 05/07/2012 20:40, Deep Debroy ha scritto: > Hi, I was wondering what would be the steps necessary to get the > patches for vmware's pvscsi implementation submitted by Dmitry > Fleytman on 18th March, 2012 applied to qemu? Here's a link to the > intro to the patchset I am referring to: > http://l

[Qemu-devel] [PATCH v2] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Dunrong Huang
Users may pass the following parameters to qemu: $ qemu-kvm -net nic -net user,smb= ... $ qemu-kvm -net nic -net user,smb ... $ qemu-kvm -net nic -net user,smb=bad_directory ... In these cases, qemu started successfully while samba server failed to start. Users will confuse since samba

Re: [Qemu-devel] [PATCH] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Dunrong Huang
Thanks for your reply. 2012/7/6 Jan Kiszka : >> diff --git a/net/slirp.c b/net/slirp.c >> index 37b6ccf..a672cff 100644 >> --- a/net/slirp.c >> +++ b/net/slirp.c >> @@ -489,6 +489,20 @@ static int slirp_smb(SlirpState* s, const char >> *exported_dir, >> char smb_cmdline[128]; >> FILE *

Re: [Qemu-devel] [PATCH 3/3] target-i386: make it clearer that op table accesses don't overrun

2012-07-05 Thread Stefan Weil
Please see comments below. Am 05.07.2012 23:29, schrieb Peter Maydell: Rephrase some of the expressions used to select an entry in the SSE op table arrays so that it's clearer that they don't overrun the op table array size. Signed-off-by: Peter Maydell --- target-i386/translate.c | 12 +++

Re: [Qemu-devel] [RFC PATCH 0/3] GlusterFS support in QEMU

2012-07-05 Thread Bharata B Rao
On Mon, Jun 11, 2012 at 07:48:07PM +0530, Bharata B Rao wrote: > > # qemu-system-x86_64 --enable-kvm --nographic -smp 4 -m 1024 -drive > file=gluster:c-qemu.vol:/F16,format=gluster > If you notice above, I am directly feeding the gluster volume file to QEMU. During my discussions with GlusterFS

Re: [Qemu-devel] [PATCH 1/3] target-i386: Remove unused macros

2012-07-05 Thread Stefan Weil
Am 05.07.2012 23:28, schrieb Peter Maydell: Commit 11f8cdb removed all the uses of the X86_64_ONLY macro. The BUGGY_64() macro has been unused for a long time: it originally marked some ops which couldn't be enabled because of issues with the pre-TCG code generation scheme. Remove the now-unneces

Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command

2012-07-05 Thread Orit Wasserman
On 07/05/2012 05:14 PM, Eric Blake wrote: > On 07/05/2012 06:51 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >

Re: [Qemu-devel] [PATCH v15 7/9] Add XBZRLE to ram_save_block and ram_save_live

2012-07-05 Thread Orit Wasserman
On 07/05/2012 05:04 PM, Eric Blake wrote: > On 07/05/2012 06:51 AM, Orit Wasserman wrote: >> In the outgoing migration check to see if the page is cached and >> changed than send compressed page by using save_xbrle_page function. >> In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is s

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-07-05 Thread Markus Armbruster
Marcelo Tosatti writes: > On Mon, May 21, 2012 at 01:53:36PM -0400, Jason Baron wrote: >> On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: >> > Add a command line parameter to not dump guest memory in the core dump, the >> > command line is: -dont-dump-guest. This brought the core dum

[Qemu-devel] [BUG] guest os oops when run in upstream qemu x86_64

2012-07-05 Thread Wanpeng Li
Hi all, the upstream qemu v1.1.0-rc4 x86_64 /opt/qemu/bin/qemu-system-x86-64 -s -kernel vmlinuz-3.0.0-22-generic -initrd initrd.img-3.0.0-22-generic -hda ./linux-0.2.img -append root=/dev/sda -boot c -monitor stdio --enable-kvm no --enable-kvm no -m guest os will oops (out of memory) during

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Evgeny Voevodin
On 05.07.2012 17:55, Andreas Färber wrote: Am 05.07.2012 15:23, schrieb Yeongkyoon Lee: Add an option "--enable-ldst-optimization" to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. Sign

[Qemu-devel] [PATCH v2] vnc: add a more descriptive error message

2012-07-05 Thread Amos Kong
On 30/06/12 10:02, ak...@redhat.com wrote: From: Amos Kong Currently qemu outputs some low-level error in qemu-sockets.c when failed to start vnc server. eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known' Some libvirt users could not know what's happened with this unclear error messag

Re: [Qemu-devel] [PATCH 5/6] hw/arm_boot.c: Support DTBs which use 64 bit addresses

2012-07-05 Thread Peter Crosthwaite
On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell wrote: > Support the case where the device tree blob specifies that > #address-cells and #size-cells are greater than 1. (This > is needed for device trees which can handle 64 bit physical > addresses and thus total RAM sizes over 4GB.) > > Signed-off-

Re: [Qemu-devel] [PATCH 3/6] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity

2012-07-05 Thread Peter Crosthwaite
On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell wrote: > The legacy ATAGS format for passing information to the kernel only > allows RAM sizes which fit in 32 bits; enforce this restriction > rather than silently doing something weird. > > Signed-off-by: Peter Maydell > --- > hw/arm_boot.c |5

Re: [Qemu-devel] [PATCH 2/6] hw/arm_boot.c: Consistently use ram_size from arm_boot_info struct

2012-07-05 Thread Peter Crosthwaite
On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell wrote: > Clean up the mix of getting the RAM size from the global ram_size > and from the ram_size field in the arm_boot_info structure, so > that we always use the structure field. > > Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwait

Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t

2012-07-05 Thread Peter Crosthwaite
On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell wrote: > Make the RAM size in arm_boot_info a target_phys_addr_t so > it can express RAM sizes up to the limit imposed by the > physical address size. > > Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite > --- > hw/arm-misc.h |

Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties

2012-07-05 Thread Peter Crosthwaite
On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell wrote: > Add support for reading device tree properties (both generic > and single-cell ones) to QEMU's convenience wrapper layer. > > Signed-off-by: Peter Maydell > --- > device_tree.c | 30 ++ > device_tree.h |4 ++

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-07-05 Thread Peter Crosthwaite
>>> >> ACK - Igor, my test vector has no interrupts, Are you able to zip up >> and send my your exynos test vectorif its touching interrupt >> behaviour? > > > We only tested DMAC by connecting audio codec model to its peripheral > request inputs, this model > doesn't use DMAC interrupts either. >

Re: [Qemu-devel] [PATCH v8 08/16] target-or32: Add instruction translation

2012-07-05 Thread Jia Liu
Hi Blue, On Fri, Jul 6, 2012 at 2:45 AM, Blue Swirl wrote: > On Wed, Jul 4, 2012 at 11:59 PM, Jia Liu wrote: >> On Wed, Jul 4, 2012 at 10:23 AM, Jia Liu wrote: >>> Hi Blue, >>> >>> On Wed, Jul 4, 2012 at 2:48 AM, Blue Swirl wrote: On Sun, Jul 1, 2012 at 2:45 AM, Jia Liu wrote: > +

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-07-05 Thread Marcelo Tosatti
On Mon, May 21, 2012 at 01:53:36PM -0400, Jason Baron wrote: > On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: > > Add a command line parameter to not dump guest memory in the core dump, the > > command line is: -dont-dump-guest. This brought the core dump down from > > 383MB to 13 MB

[Qemu-devel] [PATCH] slirp: Enforce host-side user of smb share

2012-07-05 Thread Jan Kiszka
From: Jan Kiszka Windows 7 (and possibly other versions) cannot connect to the samba share if the exported host directory is not world-readable. This can be resolved by forcing the username used for access checks to the one under which QEMU and smbd are running. Signed-off-by: Jan Kiszka --- n

Re: [Qemu-devel] [PATCH] slirp: add 'cmd:' target for guestfwd

2012-07-05 Thread Jan Kiszka
On 2012-06-03 09:45, Alexander Graf wrote: > When using guestfwd=, Qemu only connects the virtual server's TCP port > to a single chardev. This is useless in most cases, as we usually want > to have more than a single connection from the guest to the outside world. > > This patch adds a new cmd: t

Re: [Qemu-devel] [PATCH] slirp: Handle whole 127.0.0.0/8 network as local addresses.

2012-07-05 Thread Jan Kiszka
On 2012-06-12 14:12, Anders Waldenborg wrote: > Changes so translation of remote address to the host's ip address in > the virtual network happens for all addresses in the 127.0.0.0/8 > network, not just 127.0.0.1. > > This fixes hostfwd bound to addresses such as 127.0.0.2 works Looks good, just

[Qemu-devel] [Bug 1010484] Re: slirp to accept non-local dns server

2012-07-05 Thread Jan Kiszka
The feature makes sense and would be acceptable. But please - post a patch on qemu-devel, following http://wiki.qemu.org/Contribute/SubmitAPatch - reject non-local DNS servers if restrict=on is selected Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, wh

Re: [Qemu-devel] [PATCH] slirp: Ensure smbd and shared directory exist when enable smb

2012-07-05 Thread Jan Kiszka
Sorry for the late review. Two comments below. On 2012-07-03 15:13, Dunrong Huang wrote: > Users may pass the following parameters to qemu: > $ qemu-kvm -net nic -net user,smb= ... > $ qemu-kvm -net nic -net user,smb ... > $ qemu-kvm -net nic -net user,smb=bad_directory ... > > In the

Re: [Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Jan Kiszka
On 2012-07-05 22:47, Michael S. Tsirkin wrote: > On Thu, Jul 05, 2012 at 04:27:33PM +0200, Jan Kiszka wrote: >> On 2012-07-05 15:17, Michael S. Tsirkin wrote: >>> On Thu, Jul 05, 2012 at 11:42:14AM +0200, Jan Kiszka wrote: This optimization was once used in qemu-kvm to keep KVM route usage low

[Qemu-devel] [PATCH 0/3] target-i386: minor code cleanups

2012-07-05 Thread Peter Maydell
These three patches fix some minor code cleanliness issues I noticed while reviewing Stefan Weil's recent build-breakage fixing patch. No behavioural changes. Peter Maydell (3): target-i386: Remove unused macros target-i386: Remove confusing X86_64_DEF macro target-i386: make it clearer that

[Qemu-devel] [PATCH 2/3] target-i386: Remove confusing X86_64_DEF macro

2012-07-05 Thread Peter Maydell
The X86_64_DEF macro is a confusing way of making some terms in a conditional only appear if TARGET_X86_64 is defined. We only use it in two places, and in both cases this is for making the same test, so abstract that check out into a function where we can use a more conventional #ifdef. Signed-of

[Qemu-devel] [PATCH 3/3] target-i386: make it clearer that op table accesses don't overrun

2012-07-05 Thread Peter Maydell
Rephrase some of the expressions used to select an entry in the SSE op table arrays so that it's clearer that they don't overrun the op table array size. Signed-off-by: Peter Maydell --- target-i386/translate.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/t

[Qemu-devel] [PATCH 1/3] target-i386: Remove unused macros

2012-07-05 Thread Peter Maydell
Commit 11f8cdb removed all the uses of the X86_64_ONLY macro. The BUGGY_64() macro has been unused for a long time: it originally marked some ops which couldn't be enabled because of issues with the pre-TCG code generation scheme. Remove the now-unnecessary definitions of both macros. Signed-off-b

[Qemu-devel] status of pvscsi patches

2012-07-05 Thread Deep Debroy
Hi, I was wondering what would be the steps necessary to get the patches for vmware's pvscsi implementation submitted by Dmitry Fleytman on 18th March, 2012 applied to qemu? Here's a link to the intro to the patchset I am referring to: http://lists.gnu.org/archive/html/qemu-devel/2012-03/msg03438.h

Re: [Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 04:27:33PM +0200, Jan Kiszka wrote: > On 2012-07-05 15:17, Michael S. Tsirkin wrote: > > On Thu, Jul 05, 2012 at 11:42:14AM +0200, Jan Kiszka wrote: > >> This optimization was once used in qemu-kvm to keep KVM route usage low. > >> But now we solved that problem via lazy upd

Re: [Qemu-devel] [PATCH] target-i386: Fix compilation with --enable-debug

2012-07-05 Thread Blue Swirl
Thanks, applied. On Fri, Jun 29, 2012 at 8:38 PM, Stefan Weil wrote: > commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table > type safety which now raises compiler errors when latest QEMU was > configured with --enable-debug. > > Fix this by splitting the SSE tables even further to

Re: [Qemu-devel] [PATCH 5/6] hw/arm_boot.c: Support DTBs which use 64 bit addresses

2012-07-05 Thread Peter Maydell
On 5 July 2012 19:53, Blue Swirl wrote: > On Thu, Jul 5, 2012 at 5:00 PM, Peter Maydell > wrote: >> @@ -236,8 +237,37 @@ static int load_dtb(target_phys_addr_t addr, const >> struct arm_boot_info *binfo) >> } >> g_free(filename); >> >> +acells = qemu_devtree_getprop_cell(fdt, "/",

Re: [Qemu-devel] [PATCH 5/6] hw/arm_boot.c: Support DTBs which use 64 bit addresses

2012-07-05 Thread Blue Swirl
On Thu, Jul 5, 2012 at 5:00 PM, Peter Maydell wrote: > Support the case where the device tree blob specifies that > #address-cells and #size-cells are greater than 1. (This > is needed for device trees which can handle 64 bit physical > addresses and thus total RAM sizes over 4GB.) > > Signed-off-

Re: [Qemu-devel] [RFC][PATCH v2 2/4] tcg: add extended MMU helpers to softmmu targets

2012-07-05 Thread Blue Swirl
On Thu, Jul 5, 2012 at 1:43 PM, Peter Maydell wrote: > On 5 July 2012 14:23, Yeongkyoon Lee wrote: >> Add extended MMU helpers to softmmu targets, where the targets are alpha, >> arm, cris, i386, lm32, m68k, microblaze, mips, ppc, s390x, sh4, sparc and >> xtensa. >> >> Signed-off-by: Yeongkyoon

Re: [Qemu-devel] [PATCH v8 08/16] target-or32: Add instruction translation

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 11:59 PM, Jia Liu wrote: > On Wed, Jul 4, 2012 at 10:23 AM, Jia Liu wrote: >> Hi Blue, >> >> On Wed, Jul 4, 2012 at 2:48 AM, Blue Swirl wrote: >>> On Sun, Jul 1, 2012 at 2:45 AM, Jia Liu wrote: +switch (op0) { +case 0x00:/* l.j */ +LOG_D

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 4:36 PM, Eric Blake wrote: > On 07/04/2012 10:19 AM, Paolo Bonzini wrote: >> Il 03/07/2012 22:15, Andreas Färber ha scritto: > > I'd also vote for %u. PRI*32 do not seem very useful compared to plain > int versions. >>> If it's not useful we should use unsigned i

Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-05 Thread Blue Swirl
On Tue, Jul 3, 2012 at 8:15 PM, Andreas Färber wrote: > Am 03.07.2012 21:11, schrieb Blue Swirl: >> On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote: >>> On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote: Andreas Färber writes: > Am 02.07.2012 14:55, schrieb Stefan Hajn

Re: [Qemu-devel] plan for device assignment upstream

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 8:05 AM, Avi Kivity wrote: > On 07/03/2012 10:06 PM, Blue Swirl wrote: >> On Mon, Jul 2, 2012 at 9:43 AM, Avi Kivity wrote: >>> On 07/02/2012 12:30 PM, Jan Kiszka wrote: On 2012-07-02 11:18, Michael S. Tsirkin wrote: > I've been thinking hard about Jan's patches fo

Re: [Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 8:34 AM, Kevin Wolf wrote: > Am 03.07.2012 21:19, schrieb Blue Swirl: >> On Tue, Jul 3, 2012 at 10:07 AM, Kevin Wolf wrote: >>> Am 09.06.2012 14:12, schrieb Blue Swirl: Move logging functions from exec.c to qemu-log.c, compile it only once. Signed-off-by

Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-05 Thread Blue Swirl
On Wed, Jul 4, 2012 at 7:33 AM, Paolo Bonzini wrote: > Il 03/07/2012 21:09, Blue Swirl ha scritto: >>> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest >>> > *req, uint8_t *outbuf) >>> > outbuf[buflen++] = 0; // not officially assigned >>> > outb

Re: [Qemu-devel] [PATCH v15 6/9] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-05 Thread Orit Wasserman
On 07/05/2012 04:55 PM, Eric Blake wrote: > On 07/05/2012 06:51 AM, Orit Wasserman wrote: > > This commit message is a bit sparse. I'd document at least the fact > that our nzrun detection code in xbzrle_encode_buffer borrows > long-word-at-a-time NUL-detection tricks from strcmp(), as it is not

Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-07-05 Thread Igor Mitsyanko
On 07/05/2012 08:44 AM, Peter Crosthwaite wrote: On Tue, Jul 3, 2012 at 9:30 PM, Igor Mitsyanko wrote: Hi Peter, here's a few review comments for your patch On 06/18/2012 04:42 AM, Peter A. G. Crosthwaite wrote: Device model for Primecell PL330 dma controller. Signed-off-by: Peter A. G. Cro

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Corey Bryant
On 07/05/2012 01:00 PM, Eric Blake wrote: On 07/05/2012 10:35 AM, Corey Bryant wrote: 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with refcount of 0; fd=4's in-use flag is turned on 2. client calls 'device-add' with /dev/fdset/1 as the backing filename, so qemu_open() increm

[Qemu-devel] [PATCH 2/6] hw/arm_boot.c: Consistently use ram_size from arm_boot_info struct

2012-07-05 Thread Peter Maydell
Clean up the mix of getting the RAM size from the global ram_size and from the ram_size field in the arm_boot_info structure, so that we always use the structure field. Signed-off-by: Peter Maydell --- hw/arm_boot.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH 0/6] arm_boot/vexpress-a15: Support >4GB of RAM

2012-07-05 Thread Peter Maydell
This patchset adds support for booting with >4GB of RAM on the Versatile Express Cortex-A15 model. There are some caveats: * you need an LPAE A15 kernel * you need to be booting with device tree * your device tree blob needs to specify #address-cells and #size-cells as 2 (so addresses and siz

[Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties

2012-07-05 Thread Peter Maydell
Add support for reading device tree properties (both generic and single-cell ones) to QEMU's convenience wrapper layer. Signed-off-by: Peter Maydell --- device_tree.c | 30 ++ device_tree.h |4 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a

[Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t

2012-07-05 Thread Peter Maydell
Make the RAM size in arm_boot_info a target_phys_addr_t so it can express RAM sizes up to the limit imposed by the physical address size. Signed-off-by: Peter Maydell --- hw/arm-misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm-misc.h b/hw/arm-misc.h index 1

[Qemu-devel] [PATCH 6/6] hw/vexpress.c: Allow >4GB of RAM for Cortex-A15 daughterboard

2012-07-05 Thread Peter Maydell
Now that we have LPAE support and can handle passing 64 bit RAM sizes to Linux via the device tree, we can lift the restriction in the Versatile Express A15 daughterboard model on not having more than 2GB of RAM. Allow up to 30GB, which is the maximum that can fit in the address map before running

Re: [Qemu-devel] [PATCH v15 2/9] Add XBZRLE documentation

2012-07-05 Thread Orit Wasserman
On 07/05/2012 04:24 PM, Eric Blake wrote: > On 07/05/2012 06:51 AM, Orit Wasserman wrote: >> Signed-off-by: Orit Wasserman >> --- >> docs/xbzrle.txt | 136 >> +++ >> 1 files changed, 136 insertions(+), 0 deletions(-) >> create mode 100644 doc

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Eric Blake
On 07/05/2012 10:35 AM, Corey Bryant wrote: > 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with > refcount of 0; fd=4's in-use flag is turned on > 2. client calls 'device-add' with /dev/fdset/1 as the backing filename, > so qemu_open() increments the refcount of fdset1 to 1 > 3. c

[Qemu-devel] [PATCH 5/6] hw/arm_boot.c: Support DTBs which use 64 bit addresses

2012-07-05 Thread Peter Maydell
Support the case where the device tree blob specifies that #address-cells and #size-cells are greater than 1. (This is needed for device trees which can handle 64 bit physical addresses and thus total RAM sizes over 4GB.) Signed-off-by: Peter Maydell --- hw/arm_boot.c | 36

[Qemu-devel] [PATCH 3/6] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity

2012-07-05 Thread Peter Maydell
The legacy ATAGS format for passing information to the kernel only allows RAM sizes which fit in 32 bits; enforce this restriction rather than silently doing something weird. Signed-off-by: Peter Maydell --- hw/arm_boot.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v3] Fixes related to processing of qemu's -numa option

2012-07-05 Thread Chegu Vinod
Changes since v2: - Using "unsigned long *" for the node_cpumask[]. - Use bitmap_new() instead of g_malloc0() for allocation. - Don't rely on "max_cpus" since it may not be initialized before the numa related qemu options are parsed & processed. Note: Continuing to use a new constant

Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-05 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 29.06.2012 17:34, schrieb Markus Armbruster: >>> New limits straight from ATA4 6.2 Register delivered data transfer >>> command sector addressing. >>> >>> I figure the old sector limit 63 was blindly copied from the BIOS >>> int 13 limit.

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Corey Bryant
On 07/05/2012 12:35 PM, Corey Bryant wrote: On 07/05/2012 10:51 AM, Kevin Wolf wrote: Am 05.07.2012 16:22, schrieb Corey Bryant: For some examples: 1. client calls 'add-fd', qemu is now tracking fd=4 with refcount 1, in use by monitor, as member of fdset1 2. client crashes, so all tracked

Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting

2012-07-05 Thread Jeff Cody
On 06/15/2012 04:47 PM, Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. > > Example: > (qemu) info block > ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 > > Enhanced to display "hostcache" setting: > (qemu) info block > ide

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Corey Bryant
On 07/05/2012 10:51 AM, Kevin Wolf wrote: Am 05.07.2012 16:22, schrieb Corey Bryant: For some examples: 1. client calls 'add-fd', qemu is now tracking fd=4 with refcount 1, in use by monitor, as member of fdset1 2. client crashes, so all tracked fds are visited; fd=4 had not yet been passed t

[Qemu-devel] [PATCH uq/master 3/9] event_notifier: add event_notifier_init_fd

2012-07-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- event_notifier.c |7 +++ event_notifier.h |3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/event_notifier.c b/event_notifier.c index c339bfe..99c376c 100644 --- a/event_notifier.c +++ b/event_notifier.c @@ -10,11 +10,18 @@ * See

[Qemu-devel] [PATCH uq/master 9/9] virtio: move common irqfd handling out of virtio-pci

2012-07-05 Thread Paolo Bonzini
All transports can use the same event handler for the irqfd, though the exact mechanics of the assignment will be specific. Note that there are three states: handled by the kernel, handled in userspace, disabled. This also lets virtio use event_notifier_set_handler. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH uq/master 2/9] event_notifier: remove event_notifier_test

2012-07-05 Thread Paolo Bonzini
This is broken; since the eventfd is used in nonblocking mode there is a race between reading and writing. Signed-off-by: Paolo Bonzini --- event_notifier.c | 15 --- event_notifier.h |1 - 2 files changed, 16 deletions(-) diff --git a/event_notifier.c b/event_notifier.c index

[Qemu-devel] [PATCH uq/master 7/9] event_notifier: add event_notifier_set_handler

2012-07-05 Thread Paolo Bonzini
Win32 event notifiers are not file descriptors, so they will not be able to use qemu_set_fd_handler. But even if for now we only have a POSIX version of EventNotifier, we can add a specific function that wraps the call. The wrapper passes the EventNotifier as the opaque value so that it will be u

Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 29.06.2012 17:34, schrieb Markus Armbruster: >> New limits straight from ATA4 6.2 Register delivered data transfer >> command sector addressing. >> >> I figure the old sector limit 63 was blindly copied from the BIOS >> int 13 limit. Doesn't apply to the hardware. No id

[Qemu-devel] [PATCH uq/master 5/9] ivshmem: wrap ivshmem_del_eventfd loops with transaction

2012-07-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ivshmem.c |4 1 file changed, 4 insertions(+) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 3cdbea2..19e164a 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -369,8 +369,12 @@ static void close_guest_eventfds(IVShmemState *s, int posn) guest_cu

[Qemu-devel] [PATCH uq/master 4/9] ivshmem: use EventNotifier and memory API

2012-07-05 Thread Paolo Bonzini
All of ivshmem's usage of eventfd now has a corresponding API in EventNotifier. Simplify the code by using it, and also use the memory API consistently to set up and tear down the ioeventfds. Signed-off-by: Paolo Bonzini --- hw/ivshmem.c | 63 --

[Qemu-devel] [PATCH uq/master 8/9] virtio: move common ioeventfd handling out of virtio-pci

2012-07-05 Thread Paolo Bonzini
All transports can use the same event handler for the ioeventfd, though the exact setup (address/memory region) will be specific. This lets virtio use event_notifier_set_handler. Signed-off-by: Paolo Bonzini --- hw/virtio-pci.c | 36 ++-- hw/virtio.c | 22

Re: [Qemu-devel] [PATCH v8 01/16] target-or32: Add target stubs and QOM cpu

2012-07-05 Thread Andreas Färber
Am 05.07.2012 15:31, schrieb Paolo Bonzini: > Il 05/07/2012 15:22, Andreas Färber ha scritto: +static void openrisc_any_initfn(Object *obj) +{ +OpenRISCCPU *cpu = OPENRISC_CPU(obj); + +set_feature(cpu, OPENRISC_FEATURE_OB32S); +set_feature(cpu, OPENRISC_FEA

Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-05 Thread Kevin Wolf
Am 29.06.2012 17:34, schrieb Markus Armbruster: > New limits straight from ATA4 6.2 Register delivered data transfer > command sector addressing. > > I figure the old sector limit 63 was blindly copied from the BIOS > int 13 limit. Doesn't apply to the hardware. No idea where the old > cylinder

Re: [Qemu-devel] [PATCH v3 01/14] pci: Make host bridge TypeInfos const

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 12:51:12AM +0200, Andreas Färber wrote: > Am 04.07.2012 23:20, schrieb Michael S. Tsirkin: > > On Wed, Jul 04, 2012 at 07:19:20PM +0200, Andreas Färber wrote: > >> Also give the sPAPR host bridge type registration functions a unique > >> name. > >> > >> Signed-off-by: Andrea

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 05:00:00PM +0200, Andreas Färber wrote: > (Dropping some borked CCs) > > Am 05.07.2012 16:15, schrieb Michael S. Tsirkin: > > On Thu, Jul 05, 2012 at 08:54:21AM -0500, Anthony Liguori wrote: > >> On 07/05/2012 08:34 AM, Michael S. Tsirkin wrote: > >>> On Thu, Jul 05, 2012 a

[Qemu-devel] [PATCH uq/master 6/9] memory: pass EventNotifier, not eventfd

2012-07-05 Thread Paolo Bonzini
Under Win32, EventNotifiers will not have event_notifier_get_fd, so we cannot call it in common code such as hw/virtio-pci.c. Pass a pointer to the notifier, and only retrieve the file descriptor in kvm-specific code. Signed-off-by: Paolo Bonzini --- exec.c |8 hw/ivshmem.

[Qemu-devel] [PATCH uq/master 1/9] event_notifier: add event_notifier_set

2012-07-05 Thread Paolo Bonzini
EventNotifier right now cannot be used as an inter-thread communication primitive. It only works if something else (the kernel) sets the eventfd. Add a primitive to signal an EventNotifier that another thread is waiting on. Signed-off-by: Paolo Bonzini --- event_notifier.c |7 +++ event

[Qemu-devel] [PATCH uq/master 0/9] remove event_notifier_get_fd from non-KVM code

2012-07-05 Thread Paolo Bonzini
This is part 1 of a three-part series that expands usage of EventNotifier in QEMU (including AIO and the main loop). I started working on this when playing with the threaded block layer; the part of that work that I hope will be in 1.2 is generalizing posix-aio-compat.c to be a generic portable th

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Corey Bryant
On 07/04/2012 04:09 AM, Kevin Wolf wrote: Am 03.07.2012 20:21, schrieb Corey Bryant: On 07/03/2012 02:00 PM, Eric Blake wrote: On 07/03/2012 11:46 AM, Corey Bryant wrote: Yes, I think adding a +1 to the refcount for the monitor makes sense. I'm a bit unsure how to increment the refcount w

Re: [Qemu-devel] q35 and ahci

2012-07-05 Thread Alexander Graf
On 07/05/2012 04:06 PM, Jason Baron wrote: On Wed, Jul 04, 2012 at 10:33:18AM +0200, Alexander Graf wrote: On 04.07.2012, at 03:29, Jason Baron wrote: On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: On 03.07.2012, at 22:37, Jason Baron wrote: On Tue, Jul 03, 2012 at 08:52:50

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Andreas Färber
(Dropping some borked CCs) Am 05.07.2012 16:15, schrieb Michael S. Tsirkin: > On Thu, Jul 05, 2012 at 08:54:21AM -0500, Anthony Liguori wrote: >> On 07/05/2012 08:34 AM, Michael S. Tsirkin wrote: >>> On Thu, Jul 05, 2012 at 12:34:20AM +0200, Andreas Färber wrote: Am 04.07.2012 23:26, schrieb

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Kevin Wolf
Am 05.07.2012 16:22, schrieb Corey Bryant: >>> For some examples: >>> >>> 1. client calls 'add-fd', qemu is now tracking fd=4 with refcount 1, in >>> use by monitor, as member of fdset1 >>> 2. client crashes, so all tracked fds are visited; fd=4 had not yet been >>> passed to 'remove-fd', so qemu d

Re: [Qemu-devel] [PATCH] msix: Drop tracking of used vectors

2012-07-05 Thread Jan Kiszka
On 2012-07-05 15:17, Michael S. Tsirkin wrote: > On Thu, Jul 05, 2012 at 11:42:14AM +0200, Jan Kiszka wrote: >> This optimization was once used in qemu-kvm to keep KVM route usage low. >> But now we solved that problem via lazy updates. > > What if we are using vhost which AFAIK can't use the lazy

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-05 Thread Richard W.M. Jones
On Thu, Jul 05, 2012 at 03:16:12PM +0100, Peter Maydell wrote: > On 5 July 2012 14:32, Richard W.M. Jones wrote: > > From: "Richard W.M. Jones" > > > > glibc 2.16 will remove the undocumented definition of 'struct siginfo' > > from . > > Progress marches on, trampling all in its wake. Hey, don'

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Laurent Desnogues
On Thu, Jul 5, 2012 at 4:06 PM, Peter Maydell wrote: [...] >> case "$target_arch2" in >>alpha | sparc* | xtensa* | ppc*) >> echo "CONFIG_TCG_PASS_AREG0=y" >> $config_target_mak >> +# qemu_ld/st optimization is not available with CONFIG_TCG_PASS_AREG0 >> +target_ldst_optimization=

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-05 Thread Corey Bryant
On 07/04/2012 04:00 AM, Kevin Wolf wrote: Am 03.07.2012 19:03, schrieb Eric Blake: 2. drive_add file=/dev/fdset/1 -> qemu_open uses the first fd from the set that has access flags matching the qemu_open action flags. qemu_open increments refcount for this fd. 3. add-fd /dev/fdset/1 FDSET={M} -

Re: [Qemu-devel] [PATCH v15 9/9] Add XBZRLE statistics

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > +++ b/arch_init.c > @@ -202,8 +202,66 @@ int64_t xbzrle_cache_resize(int64_t new_size) > return pow2floor(new_size);

Re: [Qemu-devel] [PATCH] Replace 'struct siginfo' with 'siginfo_t'.

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:32, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > glibc 2.16 will remove the undocumented definition of 'struct siginfo' > from . Progress marches on, trampling all in its wake. > This change is already present in glibc 2.15.90, so qemu compilation > of certain ta

Re: [Qemu-devel] [PATCH v3 14/14] pci: Tidy up PCI host bridges

2012-07-05 Thread Michael S. Tsirkin
On Thu, Jul 05, 2012 at 08:54:21AM -0500, Anthony Liguori wrote: > On 07/05/2012 08:34 AM, Michael S. Tsirkin wrote: > >On Thu, Jul 05, 2012 at 12:34:20AM +0200, Andreas Färber wrote: > >>Am 04.07.2012 23:26, schrieb Michael S. Tsirkin: > >>>On Thu, Jul 05, 2012 at 12:17:17AM +0300, Michael S. Tsir

Re: [Qemu-devel] [PATCH v15 8/9] Add set_cachesize command

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by:

Re: [Qemu-devel] q35 and ahci

2012-07-05 Thread Jason Baron
On Wed, Jul 04, 2012 at 10:33:18AM +0200, Alexander Graf wrote: > On 04.07.2012, at 03:29, Jason Baron wrote: > > > On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: > >> On 03.07.2012, at 22:37, Jason Baron wrote: > >> > >>> On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:23, Yeongkyoon Lee wrote: > Add an option "--enable-ldst-optimization" to enable > CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only > works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. This shouldn't be a user settable config opt

Re: [Qemu-devel] [PATCH v15 7/9] Add XBZRLE to ram_save_block and ram_save_live

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: > In the outgoing migration check to see if the page is cached and > changed than send compressed page by using save_xbrle_page function. > In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set > and decompress the page (by using load_xbr

Re: [Qemu-devel] [RFC][PATCH v2 3/4] tcg: add optimized TCG qemu_ld/st generation

2012-07-05 Thread Peter Maydell
On 5 July 2012 14:23, Yeongkyoon Lee wrote: > Add optimized TCG qemu_ld/st generation which generates the code for TLB miss > case handling at the end of TB after generating other IRs. > > Signed-off-by: Yeongkyoon Lee > --- > tcg/i386/tcg-target.c | 328 >

[Qemu-devel] [PATCH v4 2/6] monitor: rename keyname '<' to 'less'

2012-07-05 Thread Amos Kong
There are many maps of keycode 0x56 in pc-bios/keymaps/* pc-bios/keymaps/common:less 0x56 pc-bios/keymaps/common:greater 0x56 shift pc-bios/keymaps/common:bar 0x56 altgr pc-bios/keymaps/common:brokenbar 0x56 shift altgr This patch just renames '<' to 'less', QAPI would add new variable by

[Qemu-devel] [PATCH v4 0/6] convert sendkey to qapi

2012-07-05 Thread Amos Kong
This series converted 'sendkey' command to qapi. The raw value in hexadecimal format is not supported by 'send-key' of qmp. Amos Kong (6): fix doc of using raw values with sendkey monitor: rename keyname '<' to 'less' hmp: rename arguments qapi: generate list struct and visit_list for enum

[Qemu-devel] [RFC][PATCH v2 3/4] tcg: add optimized TCG qemu_ld/st generation

2012-07-05 Thread Yeongkyoon Lee
Add optimized TCG qemu_ld/st generation which generates the code for TLB miss case handling at the end of TB after generating other IRs. Signed-off-by: Yeongkyoon Lee --- tcg/i386/tcg-target.c | 328 + tcg/tcg.c | 12 ++ tcg/tcg.h

Re: [Qemu-devel] [PATCH v15 6/9] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-07-05 Thread Eric Blake
On 07/05/2012 06:51 AM, Orit Wasserman wrote: This commit message is a bit sparse. I'd document at least the fact that our nzrun detection code in xbzrle_encode_buffer borrows long-word-at-a-time NUL-detection tricks from strcmp(), as it is not an intuitive trick known by all developers. > Signe

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-05 Thread Andreas Färber
Am 05.07.2012 15:23, schrieb Yeongkyoon Lee: > Add an option "--enable-ldst-optimization" to enable > CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only > works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. > > Signed-off-by: Yeongkyoon Lee > --- >

  1   2   >