On Thu, Aug 16, 2012 at 10:24 AM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Tue, Aug 14, 2012 at 2:37 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
On Thu, Aug 2, 2012 at 1:22 PM, Stefan Hajnoczi stefa...@gmail.com wrote:
I have set up the QEMU 1.2 Testing wiki page and suggest August 16 as
Hi,
On 08/16/2012 09:26 PM, Gerd Hoffmann wrote:
snip
I can get things working by turning ehci_fill_queue() into a nop...
Investigating this further. But if you've any insights they would be
appreciated. I'm thinking this may be caused by packets completing
out of order, which could be caused
On Fri, Aug 17, 2012 at 9:38 AM, Steven wangwangk...@gmail.com wrote:
Hi, Max,
I appreciate your help and got some results using your patch. But I
still have two questions as blow.
I see that with the following patch
diff --git a/softmmu_template.h b/softmmu_template.h
index
Hi,
2) happens when a packet fails, and the queue should be halted, in
this case
Should we just cancel all queued packets on endpoint halts then? If the
guest decides to go on we'll easily re-queue everything (with the
existing code). If the guest does something else we don't have to do
On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote:
On 16.08.2012 18:58, Iustin Pop wrote:
Commit 947995c (block: protect path_has_protocol from filenames with
colons) introduced a way to handle filenames with colons based on
whether the path contains a slash or not. IMHO this
Hi,
On 08/17/2012 09:07 AM, Gerd Hoffmann wrote:
Hi,
2) happens when a packet fails, and the queue should be halted, in
this case
Should we just cancel all queued packets on endpoint halts then? If the
guest decides to go on we'll easily re-queue everything (with the
existing code). If
CC'ed to linux-user maintainer, Riku.
On Fri, Aug 17, 2012 at 01:20:19AM +0400, Dmitry V. Levin wrote:
In case when TARGET_ABI_BITS == 32 HOST_LONG_BITS == 64, the last
byte of the target dirent structure (aka d_type byte) was never copied
from the native dirent structure, thus breaking
On Fri, Aug 17, 2012 at 10:52 AM, liu ping fan qemul...@gmail.com wrote:
On Thu, Aug 16, 2012 at 5:23 PM, Avi Kivity a...@redhat.com wrote:
On 08/16/2012 06:22 AM, liu ping fan wrote:
On Tue, Aug 14, 2012 at 6:49 PM, Avi Kivity a...@redhat.com wrote:
On 08/14/2012 11:30 AM, liu ping fan wrote:
- Original Message -
On 08/16/2012 11:53 AM, Alan Cox wrote:
Yes, if I remove the break statement (introduced by this commit),
it works fine.
What version of qemu is this - do we have qemu bug here I wonder.
Also, is it 32 or 64 bits?
It's 64-bit.
Regards,
Tomas
Am 17.08.2012 09:15, schrieb Iustin Pop:
On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote:
On 16.08.2012 18:58, Iustin Pop wrote:
Commit 947995c (block: protect path_has_protocol from filenames with
colons) introduced a way to handle filenames with colons based on
whether the
On Fri, Aug 17, 2012 at 03:43:56AM -0400, Tomas Racek wrote:
Well, I've added some debug statements to the code:
void __init arch_init_ideal_nops(void)
{
switch (boot_cpu_data.x86_vendor) {
case X86_VENDOR_INTEL:
/*
* Due to a decoder
On Thursday, August 16, 2012, Oi Khote oikh...@hotmail.com wrote:
So how exactly does VFP is being emulated.
QEMU uses a library for FP computations, based on the softfloat package.
Laurent
Instead of add rom blobs, this patch just write them directly to memory.
This patch registers reset handler uimage_reset() and image_file_reset()
which load images into RAM during initial bootup and VM reset.
v2: use g_file_get_content() to load load image file.
Signed-off-by: Olivia Yin
Am 15.08.2012 20:48, schrieb Benoît Canet:
This additionnal --machine=json option make qemu-img info output on
stdout a JSON formated representation of the image informations.
--machine=json was choosen instead of --format=json because the
info command already have a -f parameter.
Which is
For controllers which queue up more then 1 packet at a time, we must halt the
ep queue, and inside the controller code cancel all pending packets on an
error.
There are multiple reasons for this:
1) Guests expect the controllers to halt ep queues on error, so that they
get the opportunity to
ehci_state_executing does not need to check for p-usb_status == USB_RET_ASYNC
or USB_RET_PROCERR, since ehci_execute_complete already does a similar check
and will trigger an assert if either value is encountered.
USB_RET_ASYNC should never be the packet status when execute_complete runs
for
If an (emulated) usb-device tries to write more data to a packet then
its iov len, this will trigger an assert in usb_packet_copy(), and if
a driver somehow circumvents that check and writes more data to the
iov then there is space, we have a much bigger problem then not correctly
reporting babble
Hi Peter,
Thanks for the reminder. I'll update the second patch to use
g_file_get_contents().
Best Regards,
Olivia
-Original Message-
From: Peter Maydell [mailto:peter.mayd...@linaro.org]
Sent: Thursday, August 16, 2012 7:36 PM
To: Yin Olivia-R63875
Cc: qemu-...@nongnu.org;
Hi Avi,
Thanks. Exactly the second patch is more important which saves the QEMU memory.
Best Regards,
Olivia
-Original Message-
From: Avi Kivity [mailto:a...@redhat.com]
Sent: Thursday, August 16, 2012 7:23 PM
To: Yin Olivia-R63875
Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org;
apport information
** Attachment added: ProcModules.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265239/+files/ProcModules.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
apport information
** Attachment added: WifiSyslog.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265242/+files/WifiSyslog.txt
** Description changed:
vmwgfx driver fails to initialize inside kvm.
- tried: kvm -m 2048 -vga vmware -cdrom RebeccaBlackLinux.iso (Ubuntu based,
apport information
** Attachment added: ProcCpuinfo.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265237/+files/ProcCpuinfo.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
apport information
** Attachment added: UdevDb.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265240/+files/UdevDb.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
Title:
apport information
** Attachment added: ProcInterrupts.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265238/+files/ProcInterrupts.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On Fri, Aug 17, 2012 at 09:56:35AM +0200, Kevin Wolf wrote:
Am 17.08.2012 09:15, schrieb Iustin Pop:
On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote:
On 16.08.2012 18:58, Iustin Pop wrote:
Commit 947995c (block: protect path_has_protocol from filenames with
colons)
apport information
** Tags added: apport-collected quantal
** Description changed:
vmwgfx driver fails to initialize inside kvm.
- tried: kvm -m 2048 -vga vmware -cdrom RebeccaBlackLinux.iso (Ubuntu
- based, any Ubuntu live CD would do)
+ tried: kvm -m 2048 -vga vmware -cdrom
Am 17.08.2012 12:05, schrieb Iustin Pop:
On Fri, Aug 17, 2012 at 09:56:35AM +0200, Kevin Wolf wrote:
Am 17.08.2012 09:15, schrieb Iustin Pop:
On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote:
On 16.08.2012 18:58, Iustin Pop wrote:
Commit 947995c (block: protect
apport information
** Attachment added: UdevLog.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265241/+files/UdevLog.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
Title:
apport information
** Attachment added: CurrentDmesg.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265235/+files/CurrentDmesg.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
apport information
** Attachment added: Lspci.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265236/+files/Lspci.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
Title:
To verify what is translation time and what is the run time, I log the
register information before disassembling each guest code. I copied
some results from the log file, which is generated at run time of a
guest machine.
EAX= EBX=6ffc
IN:
Hi,
Note this patch only touches the ehci and uhci controller changes, since AFAIK
no other controllers actually queue up multiple transfer. If I'm wrong on this
other controllers need to be updated too!
xhci does it too (although it is hard to test as xhci can happily submit
256k transfers
apport information
** Attachment added: BootDmesg.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265234/+files/BootDmesg.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
apport information
** Attachment added: AlsaInfo.txt
https://bugs.launchpad.net/bugs/1037606/+attachment/3265233/+files/AlsaInfo.txt
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1037606
Title:
sorry for the not very usefull information i provides above.
i will try to reproduce the the failure with a vailla kernel (host) in
a few days. currently the server is in use and cannot be restarted.
the kernel panic was in the guest (thought this is clear by my vm
panic). If it is reproducable
On 2012-07-10 12:41, Jan Kiszka wrote:
On 2012-07-02 11:07, Avi Kivity wrote:
On 06/29/2012 07:37 PM, Jan Kiszka wrote:
Instead of flushing pending coalesced MMIO requests on every vmexit,
this provides a mechanism to selectively flush when memory regions
related to the coalesced one are
This MMIO area is an entry gate to legacy PC ISA devices, addressed via
PIO over there. Quite a few of the PIO ports have side effects on access
like starting/stopping timers that must be executed properly ordered
/wrt the CPU. So we have to remove the coalescing mark.
Acked-by: Hervé Poussineau
On 17.08.2012 14:56, Jan Kiszka wrote:
This MMIO area is an entry gate to legacy PC ISA devices, addressed via
PIO over there. Quite a few of the PIO ports have side effects on access
like starting/stopping timers that must be executed properly ordered
/wrt the CPU. So we have to remove the
On Thu, Aug 16, 2012 at 7:49 PM, Steven wangwangk...@gmail.com wrote:
[...]
I want to get the guest memory address in the instruction mov
0x4(%ebx) %eax, whic is 0x4(%ebx).
Since %ebx is not resolved until the execution time, the code in
softmmu_header.h does not generate any hit or
On 08/16/2012 05:50 AM, Kevin Wolf wrote:
The footer takes precedence over the header when it exists. It contains
the real grain directory offset that is missing in the header. Without
this patch, streamOptimized images with a footer cannot be read.
Signed-off-by: Kevin Wolf kw...@redhat.com
On Fri, Aug 17, 2012 at 10:29:24AM +0200, Laurent Desnogues wrote:
On Thursday, August 16, 2012, Oi Khote oikh...@hotmail.com wrote:
So how exactly does VFP is being emulated.
QEMU uses a library for FP computations, based on the softfloat package.
I thought QEMU emulates VFP itself,
Hi Gerd,
Rebased on the lastest, redid ifdefs to use a single line,
QXL_HAS_IO_MONITORS_CONFIG_ASYNC is 0 by default, 1 if spice-protocol is new
enough.
Also available at
git://people.freedesktop.org/~alon/qemu qxl/pull
Alon Levy (4):
qxl/update_area_io: guest_bug on invalid
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index c2dd3b4..6c48eb9 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1385,6 +1385,18 @@ async_common:
QXLCookie *cookie = NULL;
QXLRect update
Signed-off-by: Alon Levy al...@redhat.com
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index dbf3af6..af4f68d 100755
--- a/configure
+++ b/configure
@@ -2657,6 +2657,8 @@ EOF
spice=yes
libs_softmmu=$libs_softmmu $spice_libs
Signed-off-by: Alon Levy al...@redhat.com
---
hw/qxl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c48eb9..c978f5e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl)
io_size =
Revision bumped to 4 for new IO support, enabled for spice-server =
0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol =
0.12.0.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy al...@redhat.com
---
configure | 3 +++
hw/qxl.c
On Fri, Aug 17, 2012 at 3:14 PM, 陳韋任 (Wei-Ren Chen)
che...@iis.sinica.edu.tw wrote:
On Thu, Aug 16, 2012 at 7:49 PM, Steven wangwangk...@gmail.com wrote:
[...]
I want to get the guest memory address in the instruction mov
0x4(%ebx) %eax, whic is 0x4(%ebx).
Since %ebx is not resolved
On 17 August 2012 12:27, 陳韋任 (Wei-Ren Chen) che...@iis.sinica.edu.tw wrote:
On Fri, Aug 17, 2012 at 10:29:24AM +0200, Laurent Desnogues wrote:
On Thursday, August 16, 2012, Oi Khote oikh...@hotmail.com wrote:
So how exactly does VFP is being emulated.
QEMU uses a library for FP computations,
On 2012-08-17 13:13, Michael Tokarev wrote:
On 17.08.2012 14:56, Jan Kiszka wrote:
This MMIO area is an entry gate to legacy PC ISA devices, addressed via
PIO over there. Quite a few of the PIO ports have side effects on access
like starting/stopping timers that must be executed properly
On 17.08.2012 06:55, Marek Vasut wrote:
Disallow negative value boundaries of the redraw rectangle.
This fixes a segfault when using -vga vmware.
Signed-off-by: Marek Vasut ma...@denx.de
---
hw/vmware_vga.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
NOTE: I tested
Hi Avi,
Thanks to you and several others for offering help. We will work with Avi at
first, but are grateful for all the other offers of help. We have a number
of other qemu-related projects which we'd be interested in getting done, and
will get in touch with these names (and anyone else who
Dear Michael Tokarev,
On 17.08.2012 06:55, Marek Vasut wrote:
Disallow negative value boundaries of the redraw rectangle.
This fixes a segfault when using -vga vmware.
Signed-off-by: Marek Vasut ma...@denx.de
---
hw/vmware_vga.c |4 ++--
1 file changed, 2 insertions(+), 2
Revision bumped to 4 for new IO support, enabled for spice-server =
0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol =
0.12.0.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy al...@redhat.com
---
Left in one defined, fixed here.
Hi,
On 08/17/2012 12:30 PM, Gerd Hoffmann wrote:
Hi,
Note this patch only touches the ehci and uhci controller changes, since AFAIK
no other controllers actually queue up multiple transfer. If I'm wrong on this
other controllers need to be updated too!
xhci does it too (although it is
On 2012-08-06 17:11, Stefan Hajnoczi wrote:
On Thu, Jun 28, 2012 at 2:05 PM, Peter Lieven p...@dlhnet.de wrote:
i debugged my initial problem further and found out that the problem happens
to be that
the main thread is stuck in pause_all_vcpus() on reset or quit commands in
the monitor
if
The function is called interface_release_resource.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
ui/spice-display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index 3e8f0b3..277843c 100644
--- a/ui/spice-display.c
+++
ccc-analyzer reports these warnings:
block/vdi.c:704:13: warning: Dereference of null pointer
bmap[i] = VDI_UNALLOCATED;
^
block/vdi.c:702:13: warning: Dereference of null pointer
bmap[i] = i;
^
Moving some code into the if block fixes this.
It
For controllers which queue up more then 1 packet at a time, we must halt the
ep queue, and inside the controller code cancel all pending packets on an
error.
There are multiple reasons for this:
1) Guests expect the controllers to halt ep queues on error, so that they
get the opportunity to
Kevin Wolf wrote:
Am 16.05.2012 15:07, schrieb Jim Meyering:
From: Jim Meyering meyer...@redhat.com
Signed-off-by: Jim Meyering meyer...@redhat.com
Acked-by: Kevin Wolf kw...@redhat.com
Hi Kevin,
AFAICS, only one of these 6 patches has been applied.
From what I recall (it's been nearly
ccc-analyzer reports these warnings:
monitor.c:3532:21: warning: Division by zero
val %= val2;
^
monitor.c:3530:21: warning: Division by zero
val /= val2;
^
Rewriting the code fixes this (and also a style issue).
Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
Without this, envlist_to_environ may silently fail to copy all
strings into the destination buffer, and both callers would leak
any env strings allocated after a failing strdup, because the
freeing code stops at the first NULL
Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
Following up on discussion here,
http://marc.info/?t=13375948768r=1w=2
here are patches to limit the scope of the remaining global variables.
Most changes simply added a preceding static. However, in some cases,
I've made
Am 17.08.2012 15:30, schrieb Jim Meyering:
Kevin Wolf wrote:
Am 16.05.2012 15:07, schrieb Jim Meyering:
From: Jim Meyering meyer...@redhat.com
Signed-off-by: Jim Meyering meyer...@redhat.com
Acked-by: Kevin Wolf kw...@redhat.com
Hi Kevin,
AFAICS, only one of these 6 patches has been
Kevin Wolf wrote:
Am 17.08.2012 15:30, schrieb Jim Meyering:
Kevin Wolf wrote:
Am 16.05.2012 15:07, schrieb Jim Meyering:
From: Jim Meyering meyer...@redhat.com
Signed-off-by: Jim Meyering meyer...@redhat.com
Acked-by: Kevin Wolf kw...@redhat.com
Hi Kevin,
AFAICS, only one of these 6
Am 17.08.2012 15:37, schrieb Jim Meyering:
Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
Following up on discussion here,
http://marc.info/?t=13375948768r=1w=2
here are patches to limit the scope of the remaining global variables.
Most changes simply added a preceding
ccc-analyzer reports this warning:
console.c:1090:29: warning: Dereference of null pointer
if (active_console-cursor_timer) {
^
Function console_select allows active_console to be NULL,
but would crash when accessing cursor_timer. Fix this.
Signed-off-by:
On Fri, 17 Aug 2012 15:34:04 +0200
Stefan Weil s...@weilnetz.de wrote:
ccc-analyzer reports these warnings:
monitor.c:3532:21: warning: Division by zero
val %= val2;
^
monitor.c:3530:21: warning: Division by zero
val /= val2;
On 08/15/2012 06:33 AM, David Gibson wrote:
At least when invoked with high enough 'level' arguments,
kvm_arch_put_registers() is supposed to copy essentially all the cpu state
as encoded in qemu's internal structures into the kvm state. Currently
the ppc version does not do this - it never
Stefan Weil s...@weilnetz.de writes:
ccc-analyzer reports these warnings:
monitor.c:3532:21: warning: Division by zero
val %= val2;
^
monitor.c:3530:21: warning: Division by zero
val /= val2;
^
Rewriting the code
On 2012-08-17 15:50, Stefan Weil wrote:
ccc-analyzer reports this warning:
console.c:1090:29: warning: Dereference of null pointer
if (active_console-cursor_timer) {
^
Function console_select allows active_console to be NULL,
but would crash when
On Fri, 17 Aug 2012 16:10:12 +0200
Markus Armbruster arm...@redhat.com wrote:
Stefan Weil s...@weilnetz.de writes:
ccc-analyzer reports these warnings:
monitor.c:3532:21: warning: Division by zero
val %= val2;
^
monitor.c:3530:21: warning:
On Fri, Jun 22, 2012 at 6:16 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote:
On 07/06/12 09:17, Alex Williamson wrote:
On Fri, 2012-05-25 at 17:35 +1000, Alexey Kardashevskiy wrote:
Some adapters (like NEC PCI USB controller) do not flush their config
on a sioftware reset and remember DMA
On 2012-08-17 15:11, Jan Kiszka wrote:
On 2012-08-06 17:11, Stefan Hajnoczi wrote:
On Thu, Jun 28, 2012 at 2:05 PM, Peter Lieven p...@dlhnet.de wrote:
i debugged my initial problem further and found out that the problem happens
to be that
the main thread is stuck in pause_all_vcpus() on reset
On 2012-08-17 16:36, Jan Kiszka wrote:
On 2012-08-17 15:11, Jan Kiszka wrote:
On 2012-08-06 17:11, Stefan Hajnoczi wrote:
On Thu, Jun 28, 2012 at 2:05 PM, Peter Lieven p...@dlhnet.de wrote:
i debugged my initial problem further and found out that the problem
happens
to be that
the main
Luiz Capitulino lcapitul...@redhat.com writes:
On Fri, 17 Aug 2012 16:10:12 +0200
Markus Armbruster arm...@redhat.com wrote:
Stefan Weil s...@weilnetz.de writes:
ccc-analyzer reports these warnings:
monitor.c:3532:21: warning: Division by zero
val %= val2;
On Fri, 17 Aug 2012 16:41:34 +0200
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
On Fri, 17 Aug 2012 16:10:12 +0200
Markus Armbruster arm...@redhat.com wrote:
Stefan Weil s...@weilnetz.de writes:
ccc-analyzer reports these warnings:
On 2012-08-17 16:41, Jan Kiszka wrote:
On 2012-08-17 16:36, Jan Kiszka wrote:
On 2012-08-17 15:11, Jan Kiszka wrote:
On 2012-08-06 17:11, Stefan Hajnoczi wrote:
On Thu, Jun 28, 2012 at 2:05 PM, Peter Lieven p...@dlhnet.de wrote:
i debugged my initial problem further and found out that the
Am 17.08.2012 15:35, schrieb Jim Meyering:
Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
Without this, envlist_to_environ may silently fail to copy all
strings into the destination buffer, and both callers would leak
any env strings allocated after a failing strdup, because the
USB_RET_NAK is not a valid response for async handled packets (and will
trigger an assert as such).
Also drop the warning when receiving a status of cancelled for packets not
cancelled by qemu itself, this can happen when a device gets unredirected
by the usbredir-host while transfers are
Andreas Färber wrote:
Am 17.08.2012 15:35, schrieb Jim Meyering:
Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
Without this, envlist_to_environ may silently fail to copy all
strings into the destination buffer, and both callers would leak
any env strings allocated after a
Revision bumped to 4 for new IO support, enabled for spice-server =
0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol =
0.12.0.
On migration reissue spice_qxl_monitors_config_async.
RHBZ: 770842
Signed-off-by: Alon Levy al...@redhat.com
---
Fixed another defined I missed. This
Am 22.05.2012 12:16, schrieb Jim Meyering:
From: Jim Meyering meyer...@redhat.com
Signed-off-by: Jim Meyering meyer...@redhat.com
---
envlist.c | 256
+++---
1 file changed, 128 insertions(+), 128 deletions(-)
diff --git
Am 22.05.2012 12:16, schrieb Jim Meyering:
From: Jim Meyering meyer...@redhat.com
Without this, envlist_to_environ may silently fail to copy all
strings into the destination buffer, and both callers would leak
any env strings allocated after a failing strdup, because the
freeing code stops
Am 17.08.2012 17:34, schrieb Jim Meyering:
Andreas Färber wrote:
Am 17.08.2012 15:35, schrieb Jim Meyering:
Jim Meyering wrote:
From: Jim Meyering meyer...@redhat.com
Without this, envlist_to_environ may silently fail to copy all
strings into the destination buffer, and both callers would
Am 17.08.2012 12:56, schrieb Jan Kiszka:
This MMIO area is an entry gate to legacy PC ISA devices, addressed via
PIO over there. Quite a few of the PIO ports have side effects on access
like starting/stopping timers that must be executed properly ordered
/wrt the CPU. So we have to remove the
Not being too familiar with the USB code I wonder if $subject was
supposed to say and cancel?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Guest-Agent : Windows 2008 Error : Relase 1.1.90
error : internal error unable to execute QEMU command 'guest-fsfreeze-freeze':
this feature or command is not currently supported.
Guest-info shows the command is available. Is there any information available
on the list of commands supported
On Thu, Aug 16, 2012 at 03:10:50PM -0300, Eduardo Habkost wrote:
On Wed, Aug 15, 2012 at 06:13:27PM +0200, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov imamm...@redhat.com
--
v2:
* replaced mask/ffs tricks by plain 'for (bit = 0; bit 32; bit++)'
as suggested by Eduardo
On Wed, 15 Aug 2012 17:05:44 +0200
Alexander Graf ag...@suse.de wrote:
BSD
---
Luiz tested these for me.
OpenBSD 5.1, FreeBSD 9.0 and NetBSD all worked with the ide controller
passed on the command line. AHCI didn't work.
Sorry if I wasn't clear in my report, I've only tried
Instea of using a hardcoded hex constant, define CPUID_EXT2_AMD_ALIASES
as the set of CPUID[8000_0001].EDX bits that on AMD are the same as the
bits of CPUID[1].EDX.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.h | 12
target-i386/kvm.c | 2 +-
2 files
It's nice to have a flexible system to maintain CPU models as data, but
this is holding us from making improvements in the CPU code because it's
not using the common infra-structure, and because the machine-type data
is still inside C code.
Users who want to configure CPU features directly may
The problem:
- Some features are report at the same time on both CPUID[1].EDX and
CPUID[8000_0001].EDX on AMD CPUs (e.g. fpu, tsc, msr, pae, mmx).
- -cpu model,+feature should enable the bit only on CPUID[1] if
it's not an AMD CPU, but it should enable the bit on both CPUID[1] and
Bit 10 of CPUID[8000_0001].EDX is not defined as an alias of
CPUID[1].EDX[10], so do not duplicate it on
kvm_arch_get_supported_cpuid().
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/kvm.c
The -cpu configuration interface is based on a list of feature names or
properties, on a single namespace, so there's no need to mention on
which CPUID leaf/register each flag is located.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 8
1 file changed, 4
Make source code lines shorter.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
target-i386/cpu.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 96ec9e6..519a104 100644
--- a/target-i386/cpu.c
+++
Instead of having duplicate feature names on the ext2_feature array for
the AMD feature bit aliases, we keep the feature names only on the
feature_name[] array, and copy the corresponding bits to
cpuid_ext2_features in case the CPU vendor is AMD.
This will:
- Make sure we don't set the feature
From: Jim Meyering meyer...@redhat.com
Differences from v3 (no semantic change):
- change 1/2 so this file conforms more closely to QEMU's coding style,
by adding braces around each one-line if body (there was no one-line
else- or while-block).
- move an indentation correction from
From: Jim Meyering meyer...@redhat.com
Convert each TAB(width-4) to equivalent spaces.
Put braces around each one-line if-body.
Signed-off-by: Jim Meyering meyer...@redhat.com
---
envlist.c | 268 --
1 file changed, 140 insertions(+),
From: Jim Meyering meyer...@redhat.com
Without this, envlist_to_environ may silently fail to copy all
strings into the destination buffer, and both callers would leak
any env strings allocated after a failing strdup, because the
freeing code stops at the first NULL pointer.
Signed-off-by: Jim
Andreas Färber wrote:
Am 22.05.2012 12:16, schrieb Jim Meyering:
From: Jim Meyering meyer...@redhat.com
Without this, envlist_to_environ may silently fail to copy all
strings into the destination buffer, and both callers would leak
any env strings allocated after a failing strdup, because
1 - 100 of 113 matches
Mail list logo
