Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Another hint: I've never seens this using qemu 1.3.1 Stefan Am 13.02.2013 08:49, schrieb Stefan Priebe - Profihost AG: Hi Paolo, sadly no luck. A VM crashed again. [ ~]# addr2line -e /usr/lib/debug/usr/bin/kvm -f 24040c virtio_scsi_command_complete hw/virtio-scsi.c:429 Same point

Re: [Qemu-devel] [PATCH v10 0/4] Add subcommand compare for qemu-img

2013-02-13 Thread Miroslav Rezanina
Please ignore this serie. It's resended v10 instead of v11. Sorry for spam. - Original Message - From: Miroslav Rezanina mreza...@redhat.com To: qemu-devel@nongnu.org, qemu-devel@nongnu.org Cc: kw...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com, ebl...@redhat.com, Miroslav

[Qemu-devel] [PATCH v11 0/4] Add subcommand compare for qemu-img

2013-02-13 Thread Miroslav Rezanina
This is 11th version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - qemu-img returns: - 0 if images are identical - 1 if images differ - 2 error on execution v11: - add

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Hi, could this be this one? commit 47a150a4bbb06e45ef439a8222e9f46a7c4cca3f Author: Paolo Bonzini pbonz...@redhat.com Date: Thu Jan 10 15:49:08 2013 +0100 virtio-scsi: abort in-flight I/O when the device is reset When the device is reset, the SCSI bus should also be reset so that

[Qemu-devel] [PATCH v11 2/4] qemu-img: Add Quiet mode option

2013-02-13 Thread Miroslav Rezanina
There can be a need to turn output to stdout off. This patch adds a -q option that enable Quiet mode. In Quiet mode, only errors are printed out. Signed-off-by: Miroslav Rezanina mreza...@redhat.com --- block.c | 12 ++-- blockdev.c|6 +- include/block/block.h |

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 2/6] create migration-rdma.c for core RDMA migration code

2013-02-13 Thread Orit Wasserman
Hi Michael, I would prefer that only migration specific code will be included in migration-rdma.c. The general RDMA code should be in rdma.c file (like the rdma.h header file). Thanks, Orit On 02/12/2013 12:49 AM, Michael R. Hines wrote: From: Michael R. Hines mrhi...@us.ibm.com

Re: [Qemu-devel] [PATCH for-1.4 stable] block/curl: disable extra protocols to prevent CVE-2013-0249

2013-02-13 Thread Stefan Hajnoczi
On Tue, Feb 12, 2013 at 08:31:38PM +0100, Andreas Färber wrote: Am 08.02.2013 08:49, schrieb Stefan Hajnoczi: There is a buffer overflow in libcurl POP3/SMTP/IMAP. The workaround is simple: disable extra protocols so that they cannot be exploited. Full details here:

[Qemu-devel] [PATCH for-1.4] block/curl: only restrict protocols with libcurl=7.19.4

2013-02-13 Thread Stefan Hajnoczi
The curl_easy_setopt(state-curl, CURLOPT_PROTOCOLS, ...) interface was introduced in libcurl 7.19.4. Therefore we cannot protect against CVE-2013-0249 when linking against an older libcurl. This fixes the build failure introduced by fb6d1bbd246c7a57ef53d3847ef225cd1349d602. Reported-by: Andreas

Re: [Qemu-devel] [PATCH for-1.4] net: Avoid NULL function pointer dereference on cleanup

2013-02-13 Thread Stefan Hajnoczi
On Tue, Feb 12, 2013 at 11:16:06PM +0100, Andreas Färber wrote: The pSeries machine and some other devices don't supply a cleanup callback. Revert part of 1ceef9f27359cbe92ef124bf74de6f792e71f6fb that started calling it unconditionally. Cc: Jason Wang jasow...@redhat.com Signed-off-by:

Re: [Qemu-devel] [Qemu-ppc] [0/8] RFC: target-ppc: Start disentangling different MMU types

2013-02-13 Thread David Gibson
On Tue, Feb 12, 2013 at 11:40:37AM +0100, Andreas Färber wrote: Am 12.02.2013 03:00, schrieb David Gibson: The target-ppc code supports CPUs with a number of different MMU types: there's both the 32-bit and 64-bit versions of the classic hash page table based powerpc mmu and there's also

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server

2013-02-13 Thread Orit Wasserman
On 02/12/2013 12:49 AM, Michael R. Hines wrote: From: Michael R. Hines mrhi...@us.ibm.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- migration-tcp.c | 19 +++ migration.c | 53 - 2 files changed, 71

Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-13 Thread Stefan Hajnoczi
On Tue, Feb 12, 2013 at 05:33:30PM +, Peter Maydell wrote: Switch the default for qemu_log logging output from /tmp/qemu.log to stderr. This is an incompatible change in some sense, but logging is mostly used for debugging purposes so it shouldn't affect production use. The previous

Re: [Qemu-devel] [Qemu-trivial] [PATCH] xilinx_axienet.c: Assert no error when making link

2013-02-13 Thread Stefan Hajnoczi
On Mon, Feb 11, 2013 at 05:16:05PM +1000, Peter Crosthwaite wrote: This gives an awful silent failure when it doesn't work. Assert against link creation failure. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_axienet.c |4 +++- 1 files changed, 3

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Paolo Bonzini
Il 13/02/2013 09:19, Stefan Priebe - Profihost AG ha scritto: Hi, could this be this one? commit 47a150a4bbb06e45ef439a8222e9f46a7c4cca3f Author: Paolo Bonzini pbonz...@redhat.com Date: Thu Jan 10 15:49:08 2013 +0100 virtio-scsi: abort in-flight I/O when the device is reset

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Hi, Am 13.02.2013 09:57, schrieb Paolo Bonzini: Il 13/02/2013 09:19, Stefan Priebe - Profihost AG ha scritto: Hi, could this be this one? commit 47a150a4bbb06e45ef439a8222e9f46a7c4cca3f ... You can certainly try reverting it, but this patch is fixing a real bug. Will try that. Yes but even

[Qemu-devel] [PATCH v11 3/4] qemu-img: Add compare subcommand

2013-02-13 Thread Miroslav Rezanina
This patch adds new qemu-img subcommand that compares content of two disk images. Signed-off-by: Miroslav Rezanina mreza...@redhat.com --- qemu-img-cmds.hx |6 + qemu-img.c | 290 +- qemu-img.texi| 53 ++ 3 files

Re: [Qemu-devel] [PATCH v11 4/4] qemu-iotests: Add qemu-img compare test

2013-02-13 Thread Kevin Wolf
Am 13.02.2013 09:09, schrieb Miroslav Rezanina: Simple test for qemu-img compare to check it's working correctly. Signed-off-by: Miroslav Rezanina mreza...@redhat.com --- tests/qemu-iotests/048 | 78 tests/qemu-iotests/048.out | 31

Re: [Qemu-devel] [PATCH v11 0/4] Add subcommand compare for qemu-img

2013-02-13 Thread Kevin Wolf
Am 13.02.2013 09:09, schrieb Miroslav Rezanina: This is 11th version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - qemu-img returns: - 0 if images are identical - 1

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2013-02-13 Thread Muelli
FWIW: there is a downstream report here https://bugzilla.redhat.com/show_bug.cgi?id=785293 ** Bug watch added: Red Hat Bugzilla #785293 https://bugzilla.redhat.com/show_bug.cgi?id=785293 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [PATCH v11 1/4] block: Add synchronous wrapper for bdrv_co_is_allocated_above

2013-02-13 Thread Miroslav Rezanina
There's no synchronous wrapper for bdrv_co_is_allocated_above function so it's not possible to check for sector allocation in an image with a backing file. Signed-off-by: Miroslav Rezanina mreza...@redhat.com --- block.c | 39 +++

[Qemu-devel] [PATCH v11 4/4] qemu-iotests: Add qemu-img compare test

2013-02-13 Thread Miroslav Rezanina
Simple test for qemu-img compare to check it's working correctly. Signed-off-by: Miroslav Rezanina mreza...@redhat.com --- tests/qemu-iotests/048 | 78 tests/qemu-iotests/048.out | 31 + tests/qemu-iotests/group |1 + 3

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 6/6] send memory over RDMA as blocks are iterated

2013-02-13 Thread Orit Wasserman
On 02/12/2013 12:49 AM, Michael R. Hines wrote: From: Michael R. Hines mrhi...@us.ibm.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- arch_init.c | 84 --- savevm.c| 59 -

Re: [Qemu-devel] [BUG] Guest OS hangs on boot when 64bit BAR present (kvm-apic -msi resource conflict)

2013-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2013 at 06:06:37PM +1300, Alexey Korolev wrote: Sometime ago I reported an issue about guest OS hang when 64bit BAR present. http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03189.html http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg00413.html Some more

Re: [Qemu-devel] [PATCH] Fix guest OS hangs on boot when 64bit PCI BAR present

2013-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2013 at 06:14:33PM +1300, Alexey Korolev wrote: At the moment may_overlap flag of MemoryRegion structure is ignored by the address range assignment process. This may lead to guest OS hangs if critical qemu resources are overlapped by PCI BARs. For example ivshmem 64bit PCI BAR

Re: [Qemu-devel] [PATCH 2/5] blockdev: add discard suboption to -drive

2013-02-13 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 02:06:12PM +0100, Paolo Bonzini wrote: @@ -1489,6 +1496,10 @@ QemuOptsList qemu_drive_opts = { .type = QEMU_OPT_STRING, .help = disk image, },{ +.name = discard, +.type = QEMU_OPT_STRING, +.help =

[Qemu-devel] [PATCH v2] ui/vnc: VA API based H.264 encoding for VNC

2013-02-13 Thread David Verbeiren
This patch implements H.264 encoding of the VNC framebuffer updates using hardware acceleration through the VA API. This is experimental support to let the community explore the possibilities offered by the potential bandwidth and latency reductions that H.264 encoding allows. This may be

Re: [Qemu-devel] [BUG] Guest OS hangs on boot when 64bit BAR present (kvm-apic -msi resource conflict)

2013-02-13 Thread Jan Kiszka
On 2013-02-13 11:24, Michael S. Tsirkin wrote: On Wed, Feb 13, 2013 at 06:06:37PM +1300, Alexey Korolev wrote: Sometime ago I reported an issue about guest OS hang when 64bit BAR present. http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03189.html

Re: [Qemu-devel] [BUG] Guest OS hangs on boot when 64bit BAR present (kvm-apic -msi resource conflict)

2013-02-13 Thread Michael S. Tsirkin
On Wed, Feb 13, 2013 at 11:34:52AM +0100, Jan Kiszka wrote: On 2013-02-13 11:24, Michael S. Tsirkin wrote: On Wed, Feb 13, 2013 at 06:06:37PM +1300, Alexey Korolev wrote: Sometime ago I reported an issue about guest OS hang when 64bit BAR present.

Re: [Qemu-devel] [Qemu-ppc] [PATCH ppc-next 37/39] target-ppc: Extract POWER7 alias

2013-02-13 Thread David Gibson
On Tue, Feb 12, 2013 at 11:13:30AM +0100, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/translate_init.c |3 +-- 1 Datei geändert, 1 Zeile hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c

Re: [Qemu-devel] [RFC PATCH 0/5] Make discard visible to the guests

2013-02-13 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 02:06:10PM +0100, Paolo Bonzini wrote: The major missing step in order to implement thin provisioning is exposing discard commands to the guest. This series implements minimal control of this capability. Whether to enable discard or not is made a host parameter, so

Re: [Qemu-devel] [Qemu-ppc] [PATCH ppc-next 37/39] target-ppc: Extract POWER7 alias

2013-02-13 Thread Alexander Graf
On 13.02.2013, at 11:57, David Gibson wrote: On Tue, Feb 12, 2013 at 11:13:30AM +0100, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/translate_init.c |3 +-- 1 Datei geändert, 1 Zeile hinzugefügt(+), 2 Zeilen entfernt(-) diff --git

Re: [Qemu-devel] [PATCH ppc-next 00/39] PowerPCCPU subclasses, remixed

2013-02-13 Thread Alexander Graf
On 12.02.2013, at 11:12, Andreas Färber wrote: Hi Alex, Here's a polished and squashed series of POWERPC_DEF() QOM'ifications. In light of David's patch I am sending this out in the hope that it can be applied to ppc-next before David's significantly smaller patch gets applied (or that

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Paolo Bonzini
Il 13/02/2013 10:07, Stefan Priebe - Profihost AG ha scritto: commit 47a150a4bbb06e45ef439a8222e9f46a7c4cca3f ... You can certainly try reverting it, but this patch is fixing a real bug. Will try that. Yes but even if it fixes a bug and raises another one (kvm segfault) which is the worst

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-02-13 Thread Jan Kiszka
On 2013-02-11 23:49, Marcelo Tosatti wrote: On Fri, Feb 01, 2013 at 10:47:37AM -0500, Jason J. Herne wrote: On 01/24/2013 07:40 AM, Alexander Graf wrote: I think for now the best choice for get_regs() would be to ignore the FULL/RESET bits and always keep the syncing as it happens today under

[Qemu-devel] [PATCH][QEMU] vmxcap: Open MSR file in unbuffered mode

2013-02-13 Thread Jan Kiszka
Python may otherwise decide to to read larger chunks, applying the seek only on the software buffer. This will return results from the wrong MSRs. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- scripts/kvm/vmxcap |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH][QEMU] vmxcap: Augment reported information

2013-02-13 Thread Jan Kiszka
Parse the Basic VMX Information MSR and add the bit for the new posted interrupts. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- scripts/kvm/vmxcap | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index

Re: [Qemu-devel] [Qemu-ppc] [PATCH ppc-next 37/39] target-ppc: Extract POWER7 alias

2013-02-13 Thread David Gibson
On Wed, Feb 13, 2013 at 12:15:41PM +0100, Alexander Graf wrote: On 13.02.2013, at 11:57, David Gibson wrote: On Tue, Feb 12, 2013 at 11:13:30AM +0100, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/translate_init.c |3 +-- 1 Datei geändert, 1

Re: [Qemu-devel] [RFC v1 3/3] make address_space_map safe

2013-02-13 Thread Vasilis Liaskovitis
Hi, I am looking at this old ref/unref patchset for safely removing hot-plugged dimms/MemoryRegions. I am not sure if the set is still actively worked on or relevant for qemu-master, but I had a small comment below: On Fri, Nov 09, 2012 at 11:14:30AM +0800, Liu Ping Fan wrote: From: Liu Ping

Re: [Qemu-devel] [PATCH for-1.4 1/2] trace: use glib atomic int types

2013-02-13 Thread Juan Quintela
Markus Armbruster arm...@redhat.com wrote: Stefan Hajnoczi stefa...@redhat.com writes: Juan reported that RHEL 6.4 hosts give compiler warnings because we use unsigned int while glib prototypes use volatile gint in trace/simple.c. trace/simple.c:223: error: pointer targets in passing

Re: [Qemu-devel] [PATCH for-1.4 1/2] trace: use glib atomic int types

2013-02-13 Thread Stefan Hajnoczi
On Wed, Feb 13, 2013 at 01:25:02PM +0100, Juan Quintela wrote: Markus Armbruster arm...@redhat.com wrote: Stefan Hajnoczi stefa...@redhat.com writes: Juan reported that RHEL 6.4 hosts give compiler warnings because we use unsigned int while glib prototypes use volatile gint in

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Hi, Am 13.02.2013 12:36, schrieb Paolo Bonzini: Il 13/02/2013 10:07, Stefan Priebe - Profihost AG ha scritto: commit 47a150a4bbb06e45ef439a8222e9f46a7c4cca3f ... You can certainly try reverting it, but this patch is fixing a real bug. Will try that. Yes but even if it fixes a bug and raises

Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-13 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Switch the default for qemu_log logging output from /tmp/qemu.log to stderr. This is an incompatible change in some sense, but logging is mostly used for debugging purposes so it shouldn't affect production use. The previous behaviour can be

[Qemu-devel] [RFC PATCH v2 01/23] qcow2: Handle dependencies earlier

2013-02-13 Thread Kevin Wolf
Handling overlapping allocations isn't just a detail of cluster allocation. It is rather one of three ways to get the host cluster offset for a write request: 1. If a request overlaps an in-flight allocations, the cluster offset can be taken from there (this is what handle_dependencies will

[Qemu-devel] [RFC PATCH v2 02/23] qcow2: Improve check for overlapping allocations

2013-02-13 Thread Kevin Wolf
The old code detected an overlapping allocation even when the allocations didn't actually overlap, but were only adjacent. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |2 +- tests/qemu-iotests/038.out | 10 +- 2 files changed, 6 insertions(+), 6

[Qemu-devel] [RFC PATCH v2 14/23] qcow2: Use byte granularity in qcow2_alloc_cluster_offset()

2013-02-13 Thread Kevin Wolf
This gets rid of the nb_clusters and keep_clusters and the associated complicated calculations. Just advance the number of bytes that have been processed and everything is fine. This patch advances the variables even after the last operation even though they aren't used any more afterwards to

[Qemu-devel] [RFC PATCH v2 19/23] qcow2: Add error handling to the l2meta coroutine

2013-02-13 Thread Kevin Wolf
Not exactly bisectable, but one large patch isn't much better either :-( m-error is used to allow bdrv_drain() to stop with l2meta in error state rather than go into an endless loop. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 44

[Qemu-devel] [RFC PATCH v2 17/23] qcow2: Move COW and L2 update into own coroutine

2013-02-13 Thread Kevin Wolf
This creates a separate coroutine for processing the COW and the L2 table update of allocating requests. The request itself can then complete while the second part is still being processed. We need a qemu_aio_flush() hook in order to ensure that these coroutines for the second part aren't still

[Qemu-devel] [RFC PATCH v2 22/23] qcow2: Move cluster gathering to a non-looping loop

2013-02-13 Thread Kevin Wolf
This patch is mainly to separate the indentation change from the semantic changes. All that really changes here is that everything moves into a while loop, all 'goto done' become 'break' and at the end of the loop a new 'break is inserted. Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-13 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: mdroth mdr...@linux.vnet.ibm.com writes: On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: Gerd Hoffmann kra...@redhat.com writes: Hi, But why nested discriminators? regular files: type=file serial :

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Paolo Bonzini
Il 13/02/2013 13:55, Stefan Priebe - Profihost AG ha scritto: Hi, Am 13.02.2013 12:36, schrieb Paolo Bonzini: Il 13/02/2013 10:07, Stefan Priebe - Profihost AG ha scritto: commit 47a150a4bbb06e45ef439a8222e9f46a7c4cca3f ... You can certainly try reverting it, but this patch is fixing a real

Re: [Qemu-devel] [PATCH v11 3/4] qemu-img: Add compare subcommand

2013-02-13 Thread Eric Blake
On 02/13/2013 01:09 AM, Miroslav Rezanina wrote: This patch adds new qemu-img subcommand that compares content of two disk images. Signed-off-by: Miroslav Rezanina mreza...@redhat.com --- +Compare exits with @code{0} in case the images are equal and with @code{1} +in case the images

Re: [Qemu-devel] [PATCH for-1.4] block/curl: only restrict protocols with libcurl=7.19.4

2013-02-13 Thread Andreas Färber
Am 13.02.2013 09:25, schrieb Stefan Hajnoczi: The curl_easy_setopt(state-curl, CURLOPT_PROTOCOLS, ...) interface was introduced in libcurl 7.19.4. Therefore we cannot protect against CVE-2013-0249 when linking against an older libcurl. This fixes the build failure introduced by

[Qemu-devel] [RFC PATCH v2 16/23] qcow2: Reading from areas not in L2 tables yet

2013-02-13 Thread Kevin Wolf
In preparation of delayed COW (i.e. completing the guest write request before the associated COWs have completed) we must make sure that after the guest data has written the new data is read back, even if the COW hasn't completed and the new cluster isn't linked in the L2 table yet.

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Hi paolo, thanks for your work. Should i still apply your old patch to scsi-disk or should i remove it? Stefan Am 13.02.2013 14:39, schrieb Paolo Bonzini: Il 13/02/2013 13:55, Stefan Priebe - Profihost AG ha scritto: Hi, Am 13.02.2013 12:36, schrieb Paolo Bonzini: Il 13/02/2013 10:07, Stefan

[Qemu-devel] [RFC PATCH v2 11/23] qcow2: handle_copied(): Get rid of nb_clusters parameter

2013-02-13 Thread Kevin Wolf
handle_copied() uses its bytes parameter now to determine how many clusters it should try to find. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/block/qcow2-cluster.c

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 6/6] send memory over RDMA as blocks are iterated

2013-02-13 Thread Michael R. Hines
Very helpful, thank you. I'll implement these and all the other ones soon. - Michael On 02/13/2013 04:50 AM, Orit Wasserman wrote: On 02/12/2013 12:49 AM, Michael R. Hines wrote: From: Michael R. Hines mrhi...@us.ibm.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- arch_init.c |

[Qemu-devel] [PATCH v2] qemu-iotests: Test qcow2 image creation options

2013-02-13 Thread Kevin Wolf
Just create lots of images and try out each of the creation options that qcow2 provides (except backing_file/fmt for now) I'm not totally happy with the behaviour of qemu-img in each of the cases, but let's be explicit and update the test when we do change things later. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Output of cat: [: ~]# cat /sys/block/*/device/scsi_disk/*/provisioning_mode writesame_16 Stefan Am 13.02.2013 14:39, schrieb Paolo Bonzini: Il 13/02/2013 13:55, Stefan Priebe - Profihost AG ha scritto: Hi, Am 13.02.2013 12:36, schrieb Paolo Bonzini: Il 13/02/2013 10:07, Stefan Priebe -

[Qemu-devel] [RFC PATCH v2 00/23] qcow2: Delayed COW

2013-02-13 Thread Kevin Wolf
During the last few releases we have got rid of most of the overhead of metadata writes during cluster allocation. What's left is the COW for unaligned allocating write requests, and it's quite expensive. In the general case, this cost cannot be avoided. However, if we're lucky enough that before

[Qemu-devel] [RFC PATCH v2 08/23] qcow2: Finalise interface of handle_alloc()

2013-02-13 Thread Kevin Wolf
The interface works completely on a byte granularity now and duplicated parameters are removed. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 29 - block/qcow2.h |5 + 2 files changed, 21 insertions(+), 13 deletions(-) diff

Re: [Qemu-devel] [PATCH v11 3/4] qemu-img: Add compare subcommand

2013-02-13 Thread Miroslav Rezanina
- Original Message - From: Eric Blake ebl...@redhat.com To: Miroslav Rezanina mreza...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com, stefa...@redhat.com Sent: Wednesday, February 13, 2013 2:39:59 PM Subject: Re: [PATCH v11 3/4] qemu-img: Add compare

[Qemu-devel] [RFC PATCH v2 05/23] qcow2: Factor out handle_alloc()

2013-02-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 240 +++-- trace-events |1 + 2 files changed, 152 insertions(+), 89 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 5c4b7cc..919cb39

[Qemu-devel] [RFC PATCH v2 20/23] qcow2: Cancel COW when overwritten

2013-02-13 Thread Kevin Wolf
This is the first part of an optimisation to improve the performance of sequential cluster allocations. Typically, write requests aren't aligned to cluster boundaries, so sequential allocation means that every other request has to wait for the COW of the previous request to complete. We can do

[Qemu-devel] [RFC PATCH v2 06/23] qcow2: handle_alloc(): Get rid of nb_clusters parameter

2013-02-13 Thread Kevin Wolf
We already communicate the same information in *bytes. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 919cb39..2492235 100644 ---

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 2/6] create migration-rdma.c for core RDMA migration code

2013-02-13 Thread Michael R. Hines
Acknowledged. On 02/13/2013 03:23 AM, Orit Wasserman wrote: Hi Michael, I would prefer that only migration specific code will be included in migration-rdma.c. The general RDMA code should be in rdma.c file (like the rdma.h header file). Thanks, Orit On 02/12/2013 12:49 AM, Michael R. Hines

[Qemu-devel] [RFC PATCH v2 10/23] qcow2: Factor out handle_copied()

2013-02-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 133 ++--- trace-events |1 + 2 files changed, 94 insertions(+), 40 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 0642ffa..cdbce20

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Stefan Priebe - Profihost AG
Hi, I added this: -trace events=/tmp/events,file=/root/qemu.123.trace and put the events in the events file as i couldn't handle \n in my app starting the kvm process. But even when doing an fstrim the trace file stays at 24 bytes - is this correct? Stefan Am 13.02.2013 14:39, schrieb Paolo

[Qemu-devel] [RFC PATCH v2 04/23] qcow2: Decouple cluster allocation from cluster reuse code

2013-02-13 Thread Kevin Wolf
This moves some code that prepares the allocation of new clusters to where the actual allocation happens. This is the minimum required to be able to move it to a separate function in the next patch. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 35

[Qemu-devel] [RFC PATCH v2 18/23] qcow2: Delay the COW

2013-02-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 47 +++ block/qcow2.c | 28 +--- block/qcow2.h | 14 ++ 3 files changed, 86 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] using -net dump with tap networking

2013-02-13 Thread Alexey Kardashevskiy
Hi! I am running qemu as: qemu/ppc64-softmmu/qemu-system-ppc64 -m 1024 -M pseries -trace events=trace_events -netdev user,id=virtnet,hostfwd=tcp::5000-:22 -device virtio-net-pci,netdev=virtnet -nographic -vga none -enable-kvm -kernel vml36_64k -initrd 1.cpio Now I want to enable network

[Qemu-devel] [PATCH for-1.4 1/2] chardev: Fix manual page and qemu-doc for -chardev tty

2013-02-13 Thread Markus Armbruster
Broken in commit d59044ef. Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 046bdc0..9d7131a 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1956,7 +1956,7 @@

[Qemu-devel] [PATCH for-1.4 2/2] qapi: Flatten away ChardevPort

2013-02-13 Thread Markus Armbruster
Simplifies the schema and the code. QMP command { execute : chardev-add, arguments : { id : ser0, backend : { type : port, data : { type: serial, device:/dev/ttyS0} } } } becomes

[Qemu-devel] [PATCH for-1.4 0/2] chardev-add

2013-02-13 Thread Markus Armbruster
Why am I proposing these patches for 1.4? PATCH 1/2 is a straightforward doc fix. PATCH 2/2 cleans up a part of QAPI that has never been released, before it's too late. If we're already beyond the point where we can do that, too bad, we'll live. Please consider seriously. Markus Armbruster

[Qemu-devel] [RFC PATCH v2 21/23] qemu-iotests: Another concurrent multicluster allocation case

2013-02-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/046 | 19 +++ tests/qemu-iotests/046.out | 16 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/tests/qemu-iotests/046 b/tests/qemu-iotests/046 index e0176f4..6c73675 100755

[Qemu-devel] [RFC PATCH v2 15/23] qcow2: Allow requests with multiple l2metas

2013-02-13 Thread Kevin Wolf
Instead of expecting a single l2meta, have a list of them. This allows to still have a single I/O request for the guest data, even though multiple l2meta may be needed in order to describe both a COW overwrite and a new cluster allocation (typical sequential write case). Signed-off-by: Kevin Wolf

[Qemu-devel] [RFC PATCH v2 23/23] qcow2: Gather clusters in a looping loop

2013-02-13 Thread Kevin Wolf
Instead of just checking once in exactly this order if there are dependendies, non-COW clusters and new allocation, this starts looping around these. This way we can, for example, gather non-COW clusters after new allocations as long as the host cluster offsets stay contiguous. More importantly,

[Qemu-devel] [RFC PATCH v2 13/23] qcow2: handle_copied(): Implement non-zero host_offset

2013-02-13 Thread Kevin Wolf
Look only for clusters that start at a given physical offset. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 26 ++ 1 files changed, 18 insertions(+), 8 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-13 Thread Igor Mammedov
On Tue, 12 Feb 2013 12:48:47 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Feb 11, 2013 at 02:52:49AM +0100, Igor Mammedov wrote: On Fri, 8 Feb 2013 16:13:02 -0200 Eduardo Habkost ehabk...@redhat.com wrote: On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote:

Re: [Qemu-devel] kvm segfaulting

2013-02-13 Thread Paolo Bonzini
Il 13/02/2013 15:30, Stefan Priebe - Profihost AG ha scritto: I added this: -trace events=/tmp/events,file=/root/qemu.123.trace and put the events in the events file as i couldn't handle \n in my app starting the kvm process. But even when doing an fstrim the trace file stays at 24 bytes -

[Qemu-devel] [RFC PATCH v2 03/23] qcow2: Change handle_dependency to byte granularity

2013-02-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 40 block/qcow2.h | 11 +++ 2 files changed, 39 insertions(+), 12 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 0e804ba..a3b2447

[Qemu-devel] [RFC PATCH v2 12/23] qcow2: handle_copied(): Get rid of keep_clusters parameter

2013-02-13 Thread Kevin Wolf
Now *bytes is used to return the length of the area that can be written to without performing an allocation or COW. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 23 +-- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [RFC v5] target-i386: Slim conversion to X86CPU subclasses + KVM subclasses

2013-02-13 Thread Igor Mammedov
From: Andreas Färber afaer...@suse.de Depends on http://lists.gnu.org/archive/html/qemu-devel/2013-02/msg00677.html Move x86_def_t definition to header and embed into X86CPUClass. Register types per built-in model definition. Move version initialization from x86_cpudef_setup() to class_init().

[Qemu-devel] [RFC PATCH v2 09/23] qcow2: Clean up handle_alloc()

2013-02-13 Thread Kevin Wolf
Things can be simplified a bit now. No semantic changes. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 110 +++- 1 files changed, 53 insertions(+), 57 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c

[Qemu-devel] [RFC PATCH v2 07/23] qcow2: handle_alloc(): Get rid of keep_clusters parameter

2013-02-13 Thread Kevin Wolf
handle_alloc() is now called with the offset at which the actual new allocation starts instead of the offset at which the whole write request starts, part of which may already be processed. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 44

[Qemu-devel] [PATCH 1/2] block: use Error in do_check_io_limits()

2013-02-13 Thread Stefan Hajnoczi
The do_check_io_limits() function returns false when I/O limits are invalid but it doesn't set an Error to indicate why. The two do_check_io_limits() callers duplicate error reporting. Solve this by passing an Error pointer into do_check_io_limits(). Note that the two callers report slightly

[Qemu-devel] [PATCH 2/2] block: refuse negative iops and bps values

2013-02-13 Thread Stefan Hajnoczi
Negative I/O throttling iops and bps values do not make sense so reject them with an error message. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- blockdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/blockdev.c b/blockdev.c index 9b03513..ba3759c 100644 ---

[Qemu-devel] [PATCH 0/2] block: refuse negative iops and bps values

2013-02-13 Thread Stefan Hajnoczi
These patches report an error if negative values are given for I/O throttling iops or bps. Patch 1 gets do_check_io_limits() into shape so that we can add checks. Patch 2 adds the negative check. Stefan Hajnoczi (2): block: use Error in do_check_io_limits() block: refuse negative iops and

Re: [Qemu-devel] [RFC ppc-next 39/39] target-ppc: Convert CPU definitions

2013-02-13 Thread Andreas Färber
Am 12.02.2013 17:48, schrieb Andreas Färber: Am 12.02.2013 11:13, schrieb Andreas Färber: Turn the array of model definitions into a set of self-registering QOM types with their own class_init. Unique identifiers are obtained from the combination of PVR, SVR and family identifiers; this

Re: [Qemu-devel] [PATCH 0/2] block: refuse negative iops and bps values

2013-02-13 Thread Kevin Wolf
Am 13.02.2013 16:53, schrieb Stefan Hajnoczi: These patches report an error if negative values are given for I/O throttling iops or bps. Patch 1 gets do_check_io_limits() into shape so that we can add checks. Patch 2 adds the negative check. Stefan Hajnoczi (2): block: use Error in

Re: [Qemu-devel] [PATCH for-1.4 0/2] chardev-add

2013-02-13 Thread Laszlo Ersek
On 02/13/13 15:54, Markus Armbruster wrote: Why am I proposing these patches for 1.4? PATCH 1/2 is a straightforward doc fix. PATCH 2/2 cleans up a part of QAPI that has never been released, before it's too late. If we're already beyond the point where we can do that, too bad, we'll

Re: [Qemu-devel] [PATCH for-1.4 0/2] chardev-add

2013-02-13 Thread Eric Blake
On 02/13/2013 07:54 AM, Markus Armbruster wrote: Why am I proposing these patches for 1.4? PATCH 1/2 is a straightforward doc fix. PATCH 2/2 cleans up a part of QAPI that has never been released, before it's too late. If we're already beyond the point where we can do that, too bad, we'll

Re: [Qemu-devel] [PATCH] pseries: Add cleanup hook for PAPR virtual LAN device

2013-02-13 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Am 11.02.2013 05:59, schrieb David Gibson: Currently the spapr-vlan device does not supply a cleanup call for its NetClientInfo structure. With current qemu versions, that leads to a SEGV on exit, when net_cleanup() attempts to call the cleanup

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix circular dependency for HOST_LONG_BITS qemu-common.h - bswap.h

2013-02-13 Thread Anthony Liguori
David Gibson d...@au1.ibm.com writes: On Tue, Feb 05, 2013 at 11:42:30AM +0100, Andreas Färber wrote: Am 05.02.2013 01:07, schrieb Peter Maydell: On 4 February 2013 23:52, Richard Henderson r...@twiddle.net wrote: On 2013-02-04 15:30, David Gibson wrote: Anthony, Richard, anyone?

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Fix circular dependency for HOST_LONG_BITS qemu-common.h - bswap.h

2013-02-13 Thread Andreas Färber
Am 13.02.2013 18:41, schrieb Anthony Liguori: David Gibson d...@au1.ibm.com writes: On Tue, Feb 05, 2013 at 11:42:30AM +0100, Andreas Färber wrote: Am 05.02.2013 01:07, schrieb Peter Maydell: On 4 February 2013 23:52, Richard Henderson r...@twiddle.net wrote: On 2013-02-04 15:30, David

Re: [Qemu-devel] using -net dump with tap networking

2013-02-13 Thread Laszlo Ersek
On 02/13/13 15:48, Alexey Kardashevskiy wrote: Hi! I am running qemu as: qemu/ppc64-softmmu/qemu-system-ppc64 -m 1024 -M pseries -trace events=trace_events -netdev user,id=virtnet,hostfwd=tcp::5000-:22 -device virtio-net-pci,netdev=virtnet -nographic -vga none -enable-kvm -kernel vml36_64k

Re: [Qemu-devel] [PATCH for-1.4 0/2] chardev-add

2013-02-13 Thread Anthony Liguori
Eric Blake ebl...@redhat.com writes: On 02/13/2013 07:54 AM, Markus Armbruster wrote: Why am I proposing these patches for 1.4? PATCH 1/2 is a straightforward doc fix. PATCH 2/2 cleans up a part of QAPI that has never been released, before it's too late. If we're already beyond the

[Qemu-devel] [PATCH for-1.4 1/7] help: Drop bogus help on -qtest and -qtest-log

2013-02-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-options.hx | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 046bdc0..3800c9c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2928,13 +2928,9 @@ the

[Qemu-devel] [PATCH for-1.4 5/7] help: Fix markup of heading USB options so it appears in -help

2013-02-13 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-options.hx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8d288f5..071b1b3 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -538,9 +538,10 @@ ETEXI STEXI @end table

[Qemu-devel] qemu / KVM modification to yield to external component (how to make it ignore the time the external component is running)

2013-02-13 Thread Lloret, Luis
Hi, qemu experts, We are using qemu with KVM for some experiments that involve qemu yielding to an external process periodically. By yielding, what I mean is that qemu will stop executing for some time while the external process does its job and reports back to qemu. The external process is a

[Qemu-devel] [Bug 1123975] [NEW] QEmu 1.3.90 cannot restore a 1.1.2 live snapshot

2013-02-13 Thread Francois Gouget
Public bug reported: I have upgraded to QEmu 1.3.90 (Debian 1.4.0~rc0+dfsg-1exp) but now when I try to restore a live snapshot made in QEmu 1.1.2 (Debian 1.1.2+dfsg-5) I get the following message: virsh # snapshot-revert fgtbbuild wtb error: operation failed: Error -22 while loading VM state I

  1   2   >