Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with ETP enabled

2013-08-01 Thread Gleb Natapov
On Tue, Jul 30, 2013 at 09:04:56AM +, Zhanghaoyu (A) wrote: hi all, I met similar problem to these, while performing live migration or save-restore test on the kvm platform (qemu:1.4.0, host:suse11sp2, guest:suse11sp2), running tele-communication software suite in

[Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Fam Zheng
We call strtoull(3) to parse a string to int. the range we can accept with our local variable int64_t n is (-9223372036854775808 ~ 9223372036854775807), but strtoull(3) can return (0 ~ 18446744073709551615UL). So when we pass a int from HMP within the range of 9223372036854775808 ~

[Qemu-devel] [PATCH] memory.c: drop kvm.h dependency

2013-08-01 Thread Michael S. Tsirkin
memory.c does not use any kvm specific interfaces, don't include kvm.h Signed-off-by: Michael S. Tsirkin m...@redhat.com --- memory.c | 1 - 1 file changed, 1 deletion(-) diff --git a/memory.c b/memory.c index 01846c9..6b5c420 100644 --- a/memory.c +++ b/memory.c @@ -18,7 +18,6 @@ #include

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-08-01 Thread Christoph Hellwig
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. The coded was intended to be GPLv2.

Re: [Qemu-devel] [PATCH 2/2] LICENSE: clarify

2013-08-01 Thread Paolo Bonzini
On Wed, Jul 31, 2013 at 1:19 AM, Paolo Bonzini pbonz...@redhat.com wrote: 1) The GPL says that if the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation. This is not true, QEMU includes parts that are

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-08-01 Thread Paolo Bonzini
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. The coded was intended to be GPLv2. I guess some day

Re: [Qemu-devel] [PATCH] memory.c: drop kvm.h dependency

2013-08-01 Thread Paolo Bonzini
memory.c does not use any kvm specific interfaces, don't include kvm.h Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Paolo Bonzini pbonz...@redhat.com and adding qemu-trivial. Paolo --- memory.c | 1 - 1 file changed, 1 deletion(-) diff --git a/memory.c b/memory.c

Re: [Qemu-devel] [PATCH 2/2] LICENSE: clarify

2013-08-01 Thread Paolo Bonzini
-1) QEMU as a whole is released under the GNU General Public License +1) QEMU as a whole is released under the GNU General Public License, +version 2. I appreciate these clarifications. For point 1, I suggest ... version 2 or (at your option) any later version. As Eric explained, I

Re: [Qemu-devel] [PATCH for mst/pci] output nc-name in NIC_RX_FILTER_CHANGED event

2013-08-01 Thread Michael S. Tsirkin
On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: netclient 'name' entry in event is useful for management to know which device is changed. n-netclient_name is not always set. This patch changes to use nc-name. If we don't assign 'id', qemu will set a generated name to nc-name.

Re: [Qemu-devel] [PATCH] spapr-pci: rework MSI/MSIX

2013-08-01 Thread Michael S. Tsirkin
On Fri, Jul 12, 2013 at 05:38:24PM +1000, Alexey Kardashevskiy wrote: On the sPAPR platform a guest allocates MSI/MSIX vectors via RTAS hypercalls which return global IRQ numbers to a guest so it only operates with those and never touches MSIMessage. Therefore MSIMessage handling is

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Paolo Bonzini
Hmm, do we even need clock-using at this point? For example: qemu_clock_enable() { clock-enabled = enabled; ... if (!enabled) { /* If another thread is within qemu_run_timers, * wait for it to finish. */

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Alex Bligh
--On 1 August 2013 04:57:52 -0400 Paolo Bonzini pbonz...@redhat.com wrote: True, qemu_event basically works only when a single thread resets it. But there is no race condition here because qemu_run_timers cannot be executed concurrently by multiple threads (like aio_poll in your bottom half

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 05:51:17PM +0800, Fam Zheng wrote: On Tue, 07/30 16:58, Stefan Hajnoczi wrote: On Tue, Jul 30, 2013 at 03:52:53PM +0800, Fam Zheng wrote: @@ -1518,6 +1519,9 @@ static void bdrv_move_feature_fields(BlockDriverState *bs_dest, /* dirty bitmap */

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Peter Maydell
On 31 July 2013 23:45, Richard W.M. Jones rjo...@redhat.com wrote: ~/d/qemu/arm-softmmu/qemu-system-arm \ -m 512 -M vexpress-a9 -machine kernel_irqchip=on \ The combination of 'vexpress-a9' and kernel_irqchip=on don't make any sense -- the former implies not using KVM because KVM needs an A15

Re: [Qemu-devel] [PATCH 0/4] target-arm: Implement support for generic timers

2013-08-01 Thread Laurent Desnogues
Hi, On Tue, Jul 30, 2013 at 7:55 PM, Peter Maydell peter.mayd...@linaro.org wrote: This patch series implements support for the 'generic timers', which are a set of timers defined in the ARM Architecture Reference Manual and implemented by the Cortex-A15. We've got away without these up til

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: Ok, but it's unclear how do you prefer to create and empty PC_COMPAT_1_6 in Patch 1. If you want to keep this declaration form [...] .compat_props = (GlobalProperty[]) { PC_COMPAT_1_6, { /* end of list */ }

Re: [Qemu-devel] qemu virtfs 9p not working on arm?

2013-08-01 Thread Peter Maydell
On 1 August 2013 00:25, Rich Felker dal...@aerifal.cx wrote: I'm not sure whether this is a kernel problem or a qemu problem (or even a user problem). The folks on OFTC #qemu suggested I email the list and relevant section maintainers so that's what I'm doing -- hope it's okay. I'm trying to

[Qemu-devel] [PATCH] target-mips: fix decoding of microMIPS POOL32Axf instructions

2013-08-01 Thread Leon Alrae
These are not DSP instructions, thus there is no ac field. For more details please refer to instruction encoding of MULT, MULTU, MADD, MADDU, MSUB, MSUBU, MFHI, MFLO, MTHI, MTLO in MIPS Architecture for Programmers Volume II-B: The microMIPS32 Instruction Set Signed-off-by: Leon Alrae

[Qemu-devel] [PATCH] vmdk: fix comment for vmdk_co_write_zeroes

2013-08-01 Thread Fam Zheng
The comment was truncated. Add the missing parts, especially explain why we need zero_dry_run. Signed-off-by: Fam Zheng f...@redhat.com --- block/vmdk.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3756333..e6c50b1 100644 ---

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] block/iscsi.c: Fix printf format error.

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 10:20:26PM +0100, Richard W.M. Jones wrote: From: Richard W.M. Jones rjo...@redhat.com The error on armv7hl was: block/iscsi.c: In function ‘is_request_lun_aligned’: block/iscsi.c:251:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has

[Qemu-devel] [PATCH] target-mips: fix 34Kf configuration for DSP ASE

2013-08-01 Thread Yongbok Kim
34Kf core does support DSP ASE. CP0_Config3 configuration for 34Kf and description are wrong. Please refer to MIPS32(R) 34Kf(TM) Processor Core Datasheet Signed-off-by: Yongbok Kim yongbok@imgtec.com --- target-mips/translate_init.c |5 ++--- 1 files changed, 2 insertions(+), 3

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Richard W.M. Jones
On Thu, Aug 01, 2013 at 10:32:14AM +0100, Peter Maydell wrote: On 31 July 2013 23:45, Richard W.M. Jones rjo...@redhat.com wrote: ~/d/qemu/arm-softmmu/qemu-system-arm \ -m 512 -M vexpress-a9 -machine kernel_irqchip=on \ The combination of 'vexpress-a9' and kernel_irqchip=on don't make

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Peter Maydell
On 1 August 2013 11:41, Richard W.M. Jones rjo...@redhat.com wrote: On Thu, Aug 01, 2013 at 10:32:14AM +0100, Peter Maydell wrote: You might want to consider -M vexpress-a15, if you want a setup that will let you use KVM (will probably need to reconfig your kernel appropriately; may need to

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread “tiejun.chen”
On 07/26/2013 04:47 PM, Tiejun Chen wrote: It makes more sense and simple later. Any feedback :) Tiejun Signed-off-by: Tiejun Chen tiejun.c...@windriver.com --- cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread Andreas Färber
Hi, Am 26.07.2013 10:47, schrieb Tiejun Chen: It makes more sense and simple later. Signed-off-by: Tiejun Chen tiejun.c...@windriver.com --- cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index c232265..a997632 100644 ---

Re: [Qemu-devel] [PATCH for mst/pci] output nc-name in NIC_RX_FILTER_CHANGED event

2013-08-01 Thread Amos Kong
On Thu, Aug 01, 2013 at 11:59:14AM +0300, Michael S. Tsirkin wrote: On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: netclient 'name' entry in event is useful for management to know which device is changed. n-netclient_name is not always set. This patch changes to use nc-name. If

Re: [Qemu-devel] [RFC] [PATCHv4 01/13] aio / timers: add qemu-timer.c utility functions

2013-08-01 Thread Paolo Bonzini
On Jul 26 2013, Alex Bligh wrote: Add qemu_free_clock and expose qemu_new_clock and clock types. Add utility functions to qemu-timer.c for nanosecond timing. Add qemu_clock_deadline_ns to calculate deadlines to nanosecond accuracy. Add utility function qemu_soonest_timeout to calculate

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: BlockDriverState lifecycle management is needed by future features such as image fleecing and blockdev-add. This series adds reference count to BlockDriverState. The first two patches clean up two odd BlockDriverState use cases, so

Re: [Qemu-devel] Using virtio-mmio

2013-08-01 Thread Richard W.M. Jones
On Thu, Aug 01, 2013 at 11:58:15AM +0100, Peter Maydell wrote: Unfortunately at this point you run into the classic issue of trying to get an ARM kernel running, which is that a huge class of config errors all have the failure mode just sits there with no serial output. This is remarkably

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Paolo Bonzini
True, qemu_event basically works only when a single thread resets it. But there is no race condition here because qemu_run_timers cannot be executed concurrently by multiple threads (like aio_poll in your bottom half patches). ... or, if rebasing on top of my patches, qemu_run_timers

Re: [Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 06:13:53PM +0800, Fam Zheng wrote: BlockDriverState lifecycle management is needed by future features such as image fleecing and blockdev-add. This series adds reference count to BlockDriverState. The first two patches clean up two odd BlockDriverState use cases, so

Re: [Qemu-devel] [RFC] [PATCHv4 10/13] aio / timers: Convert mainloop to use timeout

2013-08-01 Thread Paolo Bonzini
On Jul 26 2013, Alex Bligh wrote: Convert mainloop to use timeout from 3 static timers. Signed-off-by: Alex Bligh a...@alex.org.uk --- main-loop.c | 48 +--- 1 file changed, 37 insertions(+), 11 deletions(-) diff --git a/main-loop.c

Re: [Qemu-devel] [PATCH 2/2] KVM: s390: add floating irq controller

2013-08-01 Thread Jens Freimann
Am 2013 8 1 07:21 schrieb Heiko Carstens heiko.carst...@de.ibm.com: On Wed, Jul 31, 2013 at 11:08:15AM +0200, Cornelia Huck wrote: On Mon, 29 Jul 2013 15:59:53 +0200 Jens Freimann jf...@linux.vnet.ibm.com wrote: This patch adds a floating irq controller as a kvm_device. It will be

[Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Marcel Apfelbaum
Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic). The outcome may be, for example: in Windows(let's say XP) the Device manager will open a

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Gleb Natapov
On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: KVM disabled HW counters when outside of a guest mode (otherwise result will be useless), so I do not see how the problem you describe can happen. Yes, you're right. On the other hand MPU emulation assumes that counter

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Alex Bligh
Paolo, --On 1 August 2013 08:19:34 -0400 Paolo Bonzini pbonz...@redhat.com wrote: True, qemu_event basically works only when a single thread resets it. But there is no race condition here because qemu_run_timers cannot be executed concurrently by multiple threads (like aio_poll in your

Re: [Qemu-devel] [PATCH for mst/pci] output nc-name in NIC_RX_FILTER_CHANGED event

2013-08-01 Thread Andreas Färber
Am 01.07.2013 04:55, schrieb Amos Kong: On Wed, Jun 26, 2013 at 12:07:53PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: netclient 'name' entry in event is useful for management to know which device is changed.

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Gleb Natapov wrote: On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: KVM disabled HW counters when outside of a guest mode (otherwise result will be useless), so I do not see how the problem you describe can happen. Yes, you're right. On the

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Gleb Natapov
On Thu, Aug 01, 2013 at 03:48:29PM +0200, Paolo Bonzini wrote: On Aug 01 2013, Gleb Natapov wrote: On Thu, Aug 01, 2013 at 03:03:12PM +0200, Paolo Bonzini wrote: KVM disabled HW counters when outside of a guest mode (otherwise result will be useless), so I do not see how the problem

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Eric Blake
On 08/01/2013 12:31 AM, Fam Zheng wrote: Fix it by calling strtoll instead, which will report ERANGE as expected. (HMP) block_set_io_throttle ide0-hd0 99 0 0 0 0 0 (HMP) block_set_io_throttle ide0-hd0 999 0 0 0 0 0 number too large (HMP)

Re: [Qemu-devel] [RFC] [PATCHv4 10/13] aio / timers: Convert mainloop to use timeout

2013-08-01 Thread Alex Bligh
Paolo, @@ -449,6 +460,7 @@ int main_loop_wait(int nonblocking) { int ret; uint32_t timeout = UINT32_MAX; +int64_t timeout_ns; if (nonblocking) { timeout = 0; @@ -462,7 +474,21 @@ int main_loop_wait(int nonblocking) slirp_pollfds_fill(gpollfds); # endif

[Qemu-devel] qemu virtfs 9p not working on arm?

2013-08-01 Thread Rich Felker
Hi, I'm not sure whether this is a kernel problem or a qemu problem (or even a user problem). The folks on OFTC #qemu suggested I email the list and relevant section maintainers so that's what I'm doing -- hope it's okay. I'm trying to boot qemu-system-arm with rootfs on 9p, and experiencing the

[Qemu-devel] [Bug 1207228] [NEW] Qemu (trunk code) crashes when using --soundhw all option in ioport.c

2013-08-01 Thread FredBezies
Public bug reported: After not building qemu (git version) for about 3 weeks, I've done it again this morning. With up-to-date trunk code, I got this error on start, when using --soundhw all option $ qemu-system-i386 -soundhw all qemu-system-i386:

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Alex Bligh wrote: So actually there is another problem with this patch (both the condvar and the event approach are equally buggy). If a timer on clock X disables clock X, qemu_clock_enable will deadlock. Yes. I believe there will be a similar problem if a timer created or

[Qemu-devel] [PATCH 3/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP Event integration

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Add an sclp event for cpu was hot plugged. This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/Makefile.objs|2 +-

[Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/sclp.c |2 +- include/hw/s390x/sclp.h |8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hmp-commands.hx | 13 + hmp.c | 10 ++ hmp.h |1 + 3 files changed, 24 insertions(+) diff

Re: [Qemu-devel] [RFC] [PATCHv4 10/13] aio / timers: Convert mainloop to use timeout

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Alex Bligh wrote: Paolo, @@ -449,6 +460,7 @@ int main_loop_wait(int nonblocking) { int ret; uint32_t timeout = UINT32_MAX; +int64_t timeout_ns; if (nonblocking) { timeout = 0; @@ -462,7 +474,21 @@ int main_loop_wait(int nonblocking)

[Qemu-devel] [PATCH 6/8] [PATCH RFC v3] s390-qemu: cpu hotplug - s390 cpu init improvements for hotplug

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com s390_new_cpu is created to encapsulate the creation of a new QOM S390CPU object given a cpuid and a model string. All actual cpu initialization code is moved from boot time specific functions to s390_cpu_initfn (qom init routine) or to

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Alex Bligh
Paolo, --On 1 August 2013 15:51:11 +0200 Paolo Bonzini pbonz...@redhat.com wrote: So actually there is another problem with this patch (both the condvar and the event approach are equally buggy). If a timer on clock X disables clock X, qemu_clock_enable will deadlock. Yes. I believe there

Re: [Qemu-devel] [RFC v2 3/5] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-01 Thread Paolo Bonzini
On Aug 01 2013, Alex Bligh wrote: Paolo, --On 1 August 2013 15:51:11 +0200 Paolo Bonzini pbonz...@redhat.com wrote: So actually there is another problem with this patch (both the condvar and the event approach are equally buggy). If a timer on clock X disables clock X,

[Qemu-devel] [PULL 1/2] migration: send total time in QMP at completed stage

2013-08-01 Thread Luiz Capitulino
From: Pawit Pornkitprasan p.pa...@gmail.com The completed stage sets total_time but not has_total_time and thus it is not sent via QMP reply (but sent via HMP nevertheless) Signed-off-by: Pawit Pornkitprasan p.pa...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Orit Wasserman

[Qemu-devel] [PULL for-1.6 0/2] QMP queue

2013-08-01 Thread Luiz Capitulino
The following changes since commit 1197cbb9eda1dc82e2fa1815ca62bc3de158353e: qdev: Use clz in print_size (2013-07-31 07:54:21 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to

[Qemu-devel] [PULL 2/2] migration: don't use uninitialized variables

2013-08-01 Thread Luiz Capitulino
From: Pawit Pornkitprasan p.pa...@gmail.com The qmp_migrate method uses the 'blk' and 'inc' parameter without checking if they're valid or not (they may be uninitialized if command is received via QMP) Signed-off-by: Pawit Pornkitprasan p.pa...@gmail.com Reviewed-by: Eric Blake ebl...@redhat.com

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-08-01 Thread Luiz Capitulino
On Thu, 1 Aug 2013 09:41:07 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: Applied to the qmp branch, thanks. Hmm, it brakes the build. Dropping it from the queue for now: /home/lcapitulino/work/src/upstream/qmp-unstable/target-s390x/arch_dump.c:179:5: error: conflicting types for

Re: [Qemu-devel] [PATCH v2 5/9] block: vhdx - break endian translation functions out

2013-08-01 Thread Jeff Cody
On Thu, Aug 01, 2013 at 05:03:39PM +0200, Stefan Hajnoczi wrote: On Wed, Jul 31, 2013 at 11:23:50PM -0400, Jeff Cody wrote: diff --git a/block/vhdx.h b/block/vhdx.h index 2db6615..5e0a1d3 100644 --- a/block/vhdx.h +++ b/block/vhdx.h @@ -398,4 +398,17 @@ static inline void

Re: [Qemu-devel] [PATCH v2 6/9] block: vhdx - update log guid in header, and first write tracker

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:51PM -0400, Jeff Cody wrote: @@ -998,6 +1006,16 @@ exit: +/* Per the spec, on the first write of guest-visible data to the file the + * data write guid must be updated in the header */ +void vhdx_user_visible_write(BlockDriverState *bs, BDRVVHDXState *s)

[Qemu-devel] [PATCH 2/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP CPU Info

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Implement the CPU data in SCLP Read SCP Info. And implement Read CPU Info SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/sclp.c | 51

Re: [Qemu-devel] [PATCH v2 5/9] block: vhdx - break endian translation functions out

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:50PM -0400, Jeff Cody wrote: diff --git a/block/vhdx.h b/block/vhdx.h index 2db6615..5e0a1d3 100644 --- a/block/vhdx.h +++ b/block/vhdx.h @@ -398,4 +398,17 @@ static inline void cpu_to_leguids(MSGUID *guid) cpu_to_le16s(guid-data3); } +void

Re: [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines

2013-08-01 Thread Jeff Cody
On Thu, Aug 01, 2013 at 05:00:05PM +0200, Stefan Hajnoczi wrote: On Wed, Jul 31, 2013 at 11:23:49PM -0400, Jeff Cody wrote: @@ -318,6 +323,18 @@ typedef struct VHDXMetadataEntries { uint16_t present; } VHDXMetadataEntries; +typedef struct VHDXLogEntries { +uint64_t offset;

[Qemu-devel] [PATCH 7/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Implement hot_add_cpu hook

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Implement hot_add_cpu for S390 to allow hot plugging of cpus. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c |3 +++ target-s390x/cpu.c | 32 target-s390x/cpu.h |2

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Gerd Hoffmann
On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic). The outcome may be, for example: in

Re: [Qemu-devel] qemu virtfs 9p not working on arm?

2013-08-01 Thread Rich Felker
On Thu, Aug 01, 2013 at 10:43:01AM +0100, Peter Maydell wrote: On 1 August 2013 00:25, Rich Felker dal...@aerifal.cx wrote: I'm not sure whether this is a kernel problem or a qemu problem (or even a user problem). The folks on OFTC #qemu suggested I email the list and relevant section

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

2013-08-01 Thread Andreas Färber
Luiz, Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com What are your thoughts on this? Thanks, Andreas --- hmp-commands.hx | 13

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Eric Blake
On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic).

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Marcel Apfelbaum
On Thu, 2013-08-01 at 19:31 +0300, Michael S. Tsirkin wrote: On Thu, Aug 01, 2013 at 10:26:53AM -0600, Eric Blake wrote: On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running

Re: [Qemu-devel] qemu virtfs 9p not working on arm?

2013-08-01 Thread Peter Maydell
On 1 August 2013 16:59, Rich Felker dal...@aerifal.cx wrote: I'm using -M versatilepb -cpu arm1136-r2, also copied from the Aboriginal Linux image since that's what the kernel was intended to run on. I'm on the software side, not the hardware side, so I'm far from an expert in understanding

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2013 at 10:26:53AM -0600, Eric Blake wrote: On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have

[Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-01 Thread Jan Kiszka
Hi all, I'm tracking down a nasty stall of tap input over a custom 1.3.x QEMU version. Under certain load, our tap backend stops reading from the char device, and that even if we reset the guest. The frontend device (pcnet32) is able to receive (can_receive would return 0), but the tap's fd is

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v3] qemu-monitor: HMP cpu-add wrapper

2013-08-01 Thread Luiz Capitulino
On Thu, 01 Aug 2013 18:02:08 +0200 Andreas Färber afaer...@suse.de wrote: Luiz, Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Add HMP cpu-add wrapper to allow cpu hot plugging via monitor. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com

Re: [Qemu-devel] net/tap.c: Possibly a way to stall tap input

2013-08-01 Thread Jan Kiszka
On 2013-08-01 19:15, Jan Kiszka wrote: Hi all, I'm tracking down a nasty stall of tap input over a custom 1.3.x QEMU version. Under certain load, our tap backend stops reading from the char device, and that even if we reset the guest. The frontend device (pcnet32) is able to receive

[Qemu-devel] [PATCH] xhci: implement warm port reset

2013-08-01 Thread Gerd Hoffmann
Without this patch windows can't do port resets for usb3 devices. https://bugzilla.redhat.com/show_bug.cgi?id=949514 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c

Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability.

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:47PM -0400, Jeff Cody wrote: @@ -212,6 +242,24 @@ bool vhdx_checksum_is_valid(uint8_t *buf, size_t size, int crc_offset) /* + * This generates a UUID that is compliant with the MS GUIDs used + * in the VHDX spec (and elsewhere). + * + * We can do this

[Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have decided to avoid the command line specification of -device s390-cpu. The last version can be found here:

[Qemu-devel] default slot used for vga device on q35 machines

2013-08-01 Thread Laine Stump
libvirt makes an assumption that if you specify -vga qxl instead of -device qxl-vga,..., the vga device will be connected to slot 2. I learned this in a recent discussion about a bug caused by switching over to using the former syntax (in order to support multiheaded QXL):

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Vincenzo Maffione
Ok, so back to the one-patch version! :) I'll prepare it asap. Thanks, Vincenzo 2013/8/1 Andreas Färber afaer...@suse.de: Am 01.08.2013 11:38, schrieb Stefan Hajnoczi: On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: Ok, but it's unclear how do you prefer to create and

Re: [Qemu-devel] [PATCH] target-mips: fix 34Kf configuration for DSP ASE

2013-08-01 Thread Eric Johnson
Hi Yongbok, You need to make Status.MX writeable as well. - .CP0_Status_rw_bitmask = 0x3678FF1F, + .CP0_Status_rw_bitmask = 0x3778FF1F, -Eric -Original Message- From: qemu-devel-bounces+eric.johnson=imgtec@nongnu.org [mailto:qemu-devel-

[Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Modify s390_cpu_addr2state to allow fetching state information for cpu addresses above smp_cpus. Hotplug requires this capability. Also add s390_cpu_set_state function to allow modification of ipi_state entries during hotplug. Signed-off-by: Jason J.

[Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc1 is now available

2013-08-01 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 1.6 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.6.0-rc1.tar.bz2 You can help

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Paolo Bonzini
On 08/01/2013 06:26 PM, Eric Blake wrote: On 08/01/2013 08:18 AM, Gerd Hoffmann wrote: On 08/01/13 15:08, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be

Re: [Qemu-devel] [PATCH v3] semaphore: fix a hangup problem under load on NetBSD hosts.

2013-08-01 Thread Paolo Bonzini
On 08/01/2013 05:24 AM, Brad wrote: On 03/07/13 5:41 AM, Laszlo Ersek wrote: On 07/03/13 10:58, Izumi Tsutsui wrote: Fix following bugs in fallback implementation of counting semaphores with mutex+condvar added in c166cb72f1676855816340666c3b618beef4b976: - waiting threads are not restarted

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Eric Blake
On 08/01/2013 04:23 PM, Paolo Bonzini wrote: Automatic devices with no command line argument have proven to be a nightmare for libvirt as well. Although the just-released libvirt 1.1.1 now supports the on_crash element for controlling the command line parameters of qemu related to how qemu

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Michael S. Tsirkin
On Thu, Aug 01, 2013 at 04:08:57PM +0300, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will be upgraded (from qemu without this pvpanic). The outcome may

Re: [Qemu-devel] [PATCH v2 2/2] kvm: migrate vPMU state

2013-08-01 Thread Paolo Bonzini
KVM disabled HW counters when outside of a guest mode (otherwise result will be useless), so I do not see how the problem you describe can happen. Yes, you're right. On the other hand MPU emulation assumes that counter have to be disabled while MSR_IA32_PERFCTR0 is written since write to

Re: [Qemu-devel] [edk2] SetVirtualAddressMap and NX bit

2013-08-01 Thread Borislav Petkov
+ Matt. On Wed, Jul 31, 2013 at 02:10:04PM +0200, Laszlo Ersek wrote: Just random ideas... First of all, thanks for looking. You made me look too and find the fun :-) The fact that you guys didn't say Oh yeah, we do this because... but simply shruggingly suggested ideas should've been enough

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread Marcelo Tosatti
On Thu, Aug 01, 2013 at 04:12:03PM +0800, “tiejun.chen” wrote: On 07/26/2013 04:47 PM, Tiejun Chen wrote: It makes more sense and simple later. Any feedback :) Tiejun Reviewed-by: Marcelo Tosatti mtosa...@redhat.com

[Qemu-devel] [PULL for-1.6 0/2] usb fixes

2013-08-01 Thread Gerd Hoffmann
Hi, Two more little usb fixes for 1.6. please pull, Gerd The following changes since commit 75e2a4baf1536682d111d9bee0261806737a32dc: Merge remote-tracking branch 'spice/spice.v72' into staging (2013-07-30 18:48:58 -0500) are available in the git repository at:

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

2013-08-01 Thread Luiz Capitulino
On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek ler...@redhat.com wrote: (Apologies for the long To: list, I'm including everyone who participated in https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02607.html). Conceptually, the dump-guest-memory command works as follows: (a)

Re: [Qemu-devel] pvpanic device should not be automatically included as an internal device

2013-08-01 Thread Marcel Apfelbaum
On Thu, 2013-08-01 at 16:32 +0300, Michael S. Tsirkin wrote: On Thu, Aug 01, 2013 at 04:08:57PM +0300, Marcel Apfelbaum wrote: Hi, The problem with pvpanic being an internal device is that VMs running operating systems without a driver for this device will have problems when qemu will

[Qemu-devel] [PATCH 1/2] xhci: fix segfault

2013-08-01 Thread Gerd Hoffmann
Guest trying to reset a endpoint of a disconnected device resulted in xhci trying to dereference uport while being NULL, thereby crashing qemu. Fix that by adding a check. Drop unused dev variable while touching that code bit. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-08-01 Thread Andreas Färber
Am 01.08.2013 11:38, schrieb Stefan Hajnoczi: On Wed, Jul 31, 2013 at 03:39:05PM +0200, Vincenzo Maffione wrote: Ok, but it's unclear how do you prefer to create and empty PC_COMPAT_1_6 in Patch 1. If you want to keep this declaration form [...] .compat_props = (GlobalProperty[]) {

Re: [Qemu-devel] [PATCH for mst/pci] output nc-name in NIC_RX_FILTER_CHANGED event

2013-08-01 Thread Amos Kong
On Thu, Aug 01, 2013 at 03:30:53PM +0200, Andreas Färber wrote: Am 01.07.2013 04:55, schrieb Amos Kong: On Wed, Jun 26, 2013 at 12:07:53PM +0200, Markus Armbruster wrote: Amos Kong ak...@redhat.com writes: On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: netclient 'name' entry

[Qemu-devel] [v2][PATCH 1/1] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread Tiejun Chen
It makes more sense and simple later. Signed-off-by: Tiejun Chen tiejun.c...@windriver.com --- v1 - v2: To optimize performance slightly, we can reorder the two conditions to avoid the non-inline function call if cpu-stopped. cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7

Re: [Qemu-devel] [PATCH] cpus: use cpu_is_stopped efficiently

2013-08-01 Thread “tiejun.chen”
On 08/01/2013 07:38 PM, � wrote: Hi, Am 26.07.2013 10:47, schrieb Tiejun Chen: It makes more sense and simple later. Signed-off-by: Tiejun Chen tiejun.c...@windriver.com --- cpus.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index

Re: [Qemu-devel] [PATCH] monitor: fix parsing of big int

2013-08-01 Thread Luiz Capitulino
On Thu, 01 Aug 2013 07:52:17 -0600 Eric Blake ebl...@redhat.com wrote: On 08/01/2013 12:31 AM, Fam Zheng wrote: Fix it by calling strtoll instead, which will report ERANGE as expected. (HMP) block_set_io_throttle ide0-hd0 99 0 0 0 0 0 (HMP) block_set_io_throttle

Re: [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines

2013-08-01 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 11:23:49PM -0400, Jeff Cody wrote: @@ -318,6 +323,18 @@ typedef struct VHDXMetadataEntries { uint16_t present; } VHDXMetadataEntries; +typedef struct VHDXLogEntries { +uint64_t offset; +uint64_t length; +uint32_t head; +uint32_t tail; +}

[Qemu-devel] [PATCH 2/2] usb-redir: fix use-after-free

2013-08-01 Thread Gerd Hoffmann
Reinitialize dev-cs to NULL after deleting it, to make sure it isn't used afterwards. Reported-by: Martin Cerveny m.cerv...@computer.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/redirect.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/redirect.c

[Qemu-devel] [PATCH] target-ppc: Add POWER7+ CPU model

2013-08-01 Thread Alexey Kardashevskiy
This patch adds CPU PVR definition for POWER7+. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- target-ppc/cpu-models.c | 2 ++ target-ppc/cpu-models.h | 1 + 2 files changed, 3 insertions(+) diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c index 9578ed8..c97c183 100644 ---

Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability.

2013-08-01 Thread Jeff Cody
On Thu, Aug 01, 2013 at 03:44:41PM +0200, Stefan Hajnoczi wrote: On Wed, Jul 31, 2013 at 11:23:47PM -0400, Jeff Cody wrote: @@ -212,6 +242,24 @@ bool vhdx_checksum_is_valid(uint8_t *buf, size_t size, int crc_offset) /* + * This generates a UUID that is compliant with the MS

[Qemu-devel] [PATCH 4/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Storage key global access

2013-08-01 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c |5 ++--- hw/s390x/s390-virtio.c | 21

  1   2   >