Re: [Qemu-devel] [patch 0/2] force -mem-path RAM allocation

2013-10-08 Thread Markus Armbruster
Marcelo Tosatti writes: > On Tue, Oct 08, 2013 at 10:02:26AM +0200, Paolo Bonzini wrote: >> Il 08/10/2013 09:32, Markus Armbruster ha scritto: >> > We have >> > >> > -mem-path FILE provide backing storage for guest RAM >> > -mem-prealloc preallocate guest memory (use with -mem-path) >

[Qemu-devel] [PATCH v5 5/6] qemu-iotests: update test cases for commit active

2013-10-08 Thread Fam Zheng
Factor out commit test common logic into super class, and update test of committing the active image. Signed-off-by: Fam Zheng --- tests/qemu-iotests/040 | 73 +- 1 file changed, 31 insertions(+), 42 deletions(-) diff --git a/tests/qemu-iotests/04

[Qemu-devel] [PATCH v5 3/6] block: add commit_active_start()

2013-10-08 Thread Fam Zheng
commit_active_start is implemented in block/mirror.c, It will create a job with "commit" type and designated base in block-commit command. This will be used for committing active layer of device. Sync mode is removed from MirrorBlockJob because there's no proper type for commit. The used informati

[Qemu-devel] [PATCH v5 2/6] mirror: move base to MirrorBlockJob

2013-10-08 Thread Fam Zheng
This allows setting the base before entering mirror_run, commit will make use of it. Signed-off-by: Fam Zheng --- block/mirror.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 01a795a..cbdcc21 100644 --- a/block/mirror.c ++

[Qemu-devel] [PATCH v5 6/6] commit: remove unused check

2013-10-08 Thread Fam Zheng
We support top == active for commit now, remove the check and add an assertion here. Signed-off-by: Fam Zheng --- block/commit.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/block/commit.c b/block/commit.c index d4090cb..acec4ac 100644 --- a/block/commit.c +++ b/blo

[Qemu-devel] [PATCH v5 0/6] block: allow commit active as top

2013-10-08 Thread Fam Zheng
Previously live commit of active block device is not supported, this series implements it and updates corresponding qemu-iotests cases. This series is based on BlockJobType enum QAPI series. v5: Address comments from Eric and Paolo: Add mirror_start_job and front end wrapper. [Paolo] Base

[Qemu-devel] [PATCH v5 4/6] commit: support commit active layer

2013-10-08 Thread Fam Zheng
If active is top, it will be mirrored to base, (with block/mirror.c code), then the image is switched when user completes the block job. QMP documentation is updated. Signed-off-by: Fam Zheng --- block/mirror.c | 11 +++ blockdev.c | 9 +++-- qapi-schema.json | 5 +++-- 3

[Qemu-devel] [PATCH v5 1/6] mirror: don't close target

2013-10-08 Thread Fam Zheng
Let reference count manage target and don't call bdrv_close here. Signed-off-by: Fam Zheng --- block/mirror.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 7b95acf..01a795a 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -479,7 +479,6 @@ immediate_e

Re: [Qemu-devel] [PATCH v3] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Mark Wu
Thanks a lot for your all kind and helpful comments. I would fix it by myself to save the time of maintainer :) Then I have to beg your another review.BTW, I would like to ask if there's good tools or practice to perform an incremental review in qemu patch works. Thanks. Mark. On Wed 09

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-10-08 Thread liu ping fan
On Mon, Sep 30, 2013 at 11:58 PM, Michael S. Tsirkin wrote: > On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote: >> Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: >> > I was really only talking about q35 here. >> > I thought it's ugly that users can control intcap >> > directly. C

[Qemu-devel] [PATCH v4] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Mark Wu
In the original code, qmp_get_command_list is used to construct a list of all commands' name. To get the information of all qga commands, it traverses the name list and search the command info with its name. So it can cause O(n^2) in the number of commands. This patch adds an interface to travers

Re: [Qemu-devel] [PATCH v3] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Eric Blake
On 10/08/2013 08:39 PM, Mark Wu wrote: > In the original code, qmp_get_command_list is used to construct > a list of all commands' name. To get the information of all qga > commands, it traverses the name list and search the command info > with its name. So it can cause O(n^2) in the number of com

Re: [Qemu-devel] [PATCH v5] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-10-08 Thread Eric Blake
On 10/08/2013 08:37 PM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle t

Re: [Qemu-devel] [PATCH 1/2] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Mark Wu
On Wed 09 Oct 2013 10:36:21 AM CST, Mark Wu wrote: In the original code, qmp_get_command_list is used to construct a list of all commands' name. To get the information of all qga commands, it traverses the name list and search the command info with its name. So it can cause O(n^2) in the number

[Qemu-devel] [PATCH v3] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Mark Wu
In the original code, qmp_get_command_list is used to construct a list of all commands' name. To get the information of all qga commands, it traverses the name list and search the command info with its name. So it can cause O(n^2) in the number of commands. This patch adds an interface to travers

[Qemu-devel] [PATCH v5] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-10-08 Thread Mark Wu
Now we have several qemu-ga commands not returning response on success. It has been documented in qga/qapi-schema.json already. This patch exposes the 'success-response' flag by extending 'guest-info' command. With this change, the clients can handle the command response more flexibly. Signed-off-

[Qemu-devel] [PATCH 1/2] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Mark Wu
In the original code, qmp_get_command_list is used to construct a list of all commands' name. To get the information of all qga commands, it traverses the name list and search the command info with its name. So it can cause O(n^2) in the number of commands. This patch adds an interface to travers

Re: [Qemu-devel] [PATCH v2] Fix pc migration from qemu <= 1.5

2013-10-08 Thread Bandan Das
Cole Robinson writes: > The following commit introduced a migration incompatibility: > > commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe > Author: David Gibson > Date: Thu Jun 6 18:48:49 2013 +1000 > > pci: Replace pci_find_domain() with more general pci_root_bus_path() > > The issue is th

Re: [Qemu-devel] [PATCHv3 1/3] seccomp: adding blacklist support

2013-10-08 Thread Eric Blake
On 10/08/2013 06:42 PM, Eduardo Otubo wrote: > v3: The "-netdev tap" option is checked in the vl.c file during the > process of the command line argument list. It sets tap_enabled to true > or false according to the configuration found. Later at the seccomp > filter installation, this value is chec

Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

2013-10-08 Thread Brad Smith
On 25/09/13 7:24 PM, Brad Smith wrote: On 21/09/13 12:38 PM, Sebastian Herbszt wrote: Brad Smith wrote: On 19/09/13 12:53 PM, Sebastian Herbszt wrote: Brad Smith wrote: On 20/01/13 1:12 PM, David Woodhouse wrote: The PCI Firmware Specification apparently requires that the PCI Data Structure

[Qemu-devel] [Bug 1236809] Re: qemu-system-x86_64 takes 100% CPU

2013-10-08 Thread chenlidong
i find out the reason. because i used the --enable-debug option for the latest upstream. so this is not a bug. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

[Qemu-devel] [Bug 1236809] Re: qemu-system-x86_64 takes 100% CPU

2013-10-08 Thread chenlidong
i used the old version of qemu. when the vm is booting, the cpu is still 100%. but the time of guest os boot is 2min50seconds. the latest upstream is7min21seconds. so i think this is a performance problem. the old version i used: chenlidong@linux-0rsg:~> qemu-kvm --version QEMU emulator version 1

[Qemu-devel] [PATCHv3 0/3] seccomp: adding blacklist support with command line

2013-10-08 Thread Eduardo Otubo
v3: The "-netdev tap" option is checked in order to decide if the blacklist is eligible to be installed or not, since it's one the most used features that is known to use the exec() system call. It's an automatic mechanism to avoid Qemu to break when using the blacklist feature. v2: The blacklist

[Qemu-devel] [PATCHv3 3/3] seccomp: general fixes

2013-10-08 Thread Eduardo Otubo
1) On qemu-seccomp.c:255, the variable ctx was being used uninitialized; now it's initialized with NULL and it's being checked at the end of the function. 2) Changed the name of the command line option from "enable" to "sandbox" for a better understanding from user side. Signed-off-by: Eduardo

[Qemu-devel] [PATCHv3 2/3] seccomp: adding command line support for blacklist

2013-10-08 Thread Eduardo Otubo
v3: The options for blacklist in the command line also checkes the existence of "-netdev tap", leaving a warning message in a positive case. New command line options for the seccomp blacklist feature: $ qemu -sandbox on[,strict=] The strict parameter will turn on or off the new system call blac

[Qemu-devel] [PATCHv3 1/3] seccomp: adding blacklist support

2013-10-08 Thread Eduardo Otubo
v3: The "-netdev tap" option is checked in the vl.c file during the process of the command line argument list. It sets tap_enabled to true or false according to the configuration found. Later at the seccomp filter installation, this value is checked wheter to install or not this feature. Adding a

Re: [Qemu-devel] [PATCHv3 3/3] seccomp: general fixes

2013-10-08 Thread Eduardo Otubo
On 09/11/2013 01:56 PM, Corey Bryant wrote: On 09/06/2013 03:21 PM, Eduardo Otubo wrote: 1) On qemu-seccomp.c:255, the variable ctx was being used uninitialized; now it's initialized with NULL and it's being checked at the end of the function. 2) Changed the name of the command line opt

Re: [Qemu-devel] [patch 0/2] force -mem-path RAM allocation

2013-10-08 Thread Marcelo Tosatti
On Tue, Oct 08, 2013 at 10:02:26AM +0200, Paolo Bonzini wrote: > Il 08/10/2013 09:32, Markus Armbruster ha scritto: > > We have > > > > -mem-path FILE provide backing storage for guest RAM > > -mem-prealloc preallocate guest memory (use with -mem-path) > > > > PATCH 2/2 adds > > > >

Re: [Qemu-devel] [patch 1/2] qemu: mempath: prefault pages manually

2013-10-08 Thread Marcelo Tosatti
On Tue, Oct 08, 2013 at 10:03:48AM +0200, Paolo Bonzini wrote: > Il 08/10/2013 02:41, Marcelo Tosatti ha scritto: > > +/* unblock SIGBUS */ > > +pthread_sigmask(SIG_BLOCK, NULL, &oldset); > > +sigemptyset(&set); > > +sigaddset(&set, SIGBUS); > > +pthread_sigm

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Alex Bligh
On 8 Oct 2013, at 21:01, Hans de Goede wrote: >>> +/* When not non-blocking always allow io-threads to acquire the lock */ >>> +if (timeout != 0 && timeout_ns == 0) { >>> +timeout_ns = 1; >>> +} >>> + >>> ret = os_host_main_loop_wait(timeout_ns); >>> qemu_iohandler_pol

Re: [Qemu-devel] [PATCH 0/2] [RFC] qemu-ga: add support for guest command execution

2013-10-08 Thread Michael Roth
Quoting Michael Roth (2013-10-08 16:12:52) > Quoting srinath reddy (2013-10-07 09:06:04) > > Hi, > > > > Can someone help me in finding the status of this RFC here > > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg00722.html > > I picked it up again a few months back and re-worked the in

Re: [Qemu-devel] [PATCH 0/2] [RFC] qemu-ga: add support for guest command execution

2013-10-08 Thread Michael Roth
Quoting srinath reddy (2013-10-07 09:06:04) > Hi, > > Can someone help me in finding the status of this RFC here > http://lists.gnu.org/archive/html/qemu-devel/2011-12/msg00722.html I picked it up again a few months back and re-worked the interface to address some of the initial review comments by

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Hans de Goede
Hi, On 10/08/2013 09:48 PM, Alex Bligh wrote: On 8 Oct 2013, at 20:10, Hans de Goede wrote: I noticed today that current qemu master would hang as soon as Xorg starts in the guest when using qxl + a Linux guest. This message would be printed: main-loop: WARNING: I/O thread spun for 1000 itera

[Qemu-devel] [PULL 36/58] arm11mpcore: Drop unused fields

2013-10-08 Thread Andreas Färber
Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 27cd32b..8719634 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -20,8 +20,6 @@ typedef struct

Re: [Qemu-devel] [PATCH] scsi: Allocate SCSITargetReq r->buf dynamically

2013-10-08 Thread Michael Roth
Quoting Asias He (2013-10-08 03:43:37) > r->buf is hardcoded to 2056 which is (256 + 1) * 8, allowing 256 luns at > most. If more than 256 luns are specified by user, we have buffer > overflow in scsi_target_emulate_report_luns. > > To fix, we allocate the buffer dynamically. > > Signed-off-by: A

[Qemu-devel] [PULL 55/58] pcmcia: QOM'ify PCMCIACardState and MicroDriveState

2013-10-08 Thread Andreas Färber
Turn PCMCIACardState into a device. Move callbacks to new PCMCIACardClass. Derive TYPE_MICRODRIVE from TYPE_PCMCIA_CARD. Replace ide_init2_with_non_qdev_drives(). Signed-off-by: Othmar Pasteka Signed-off-by: Andreas Färber --- hw/Makefile.objs | 1 + hw/ide/microd

[Qemu-devel] [PATCH 08/13] usb: Add max_streams attribute to endpoint info

2013-10-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/core.c| 22 ++ hw/usb/desc.c| 2 ++ include/hw/usb.h | 3 +++ 3 files changed, 27 insertions(+) diff --git a/hw/usb/core.c b/hw/usb/core.c index cf59a1a..67ba7d6 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -623,6 +623,7

[Qemu-devel] [PULL 10/58] exynos4_boards: Silence lack of -smp 2 warning for qtest

2013-10-08 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/exynos4_boards.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c index 2929f9f..26cedec 100644 --- a/hw/arm/exynos4_boards.c +++ b/hw/arm/exynos4_boards.c @@ -22,6 +22,7 @@ */ #in

Re: [Qemu-devel] [PATCH v4] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-10-08 Thread Michael Roth
Quoting Mark Wu (2013-10-08 01:23:19) > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle th

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Paolo Bonzini
Il 08/10/2013 22:16, Hans de Goede ha scritto: > No, it is calling main_loop_wait with nonblocking set to 0, so > normally the lock would get released. But > timerlistgroup_deadline_ns(&main_loop_tlg) is returning 0, > causing timeout_ns to be 0, and this causes the lock to not get > released. Yes

Re: [Qemu-devel] [PATCH] qemu-ga: execute fsfreeze-freeze in reverse order of mounts

2013-10-08 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-10-01 16:09:53) > Currently, fsfreeze-freeze may cause deadlock if a guest has loopback mounts > of image files in its disk; e.g.: > > # mount | grep ^/ > /dev/vda1 / type ext4 (rw,noatime,seclabel,data=ordered) > /tmp/disk.img on /mnt type ext4 (rw,relati

[Qemu-devel] [PULL 01/58] hw/arm/boot: Make user not specifying a kernel not an error

2013-10-08 Thread Andreas Färber
From: Peter Maydell Typically ARM boards will have some kind of flash which might contain a boot ROM; it's therefore a valid use case to provide only an image for the boot ROM and not require QEMU's internal boot loader at all. Remove the fatal error if -kernel isn't specified. Signed-off-by: Pe

[Qemu-devel] [PULL 53/58] qom: Add pointer to int property helpers

2013-10-08 Thread Andreas Färber
From: "Michael S. Tsirkin" Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov Tested-by: Igor Mammedov [AF: Extended docum

[Qemu-devel] [PULL 00/58] QOM devices patch queue 2013-10-08

2013-10-08 Thread Andreas Färber
Hello Anthony, This is my current QOM devices patch queue. Please pull. Thanks, Andreas Cc: Anthony Liguori Cc: Peter Maydell Cc: Mian M. Hamayun Cc: Paolo Bonzini Cc: Michael S. Tsirkin The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking

[Qemu-devel] [PULL 08/58] palm: Don't enforce loading ROM or kernel for qtest

2013-10-08 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/palm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/palm.c b/hw/arm/palm.c index 0b72bbe..fac4f69 100644 --- a/hw/arm/palm.c +++ b/hw/arm/palm.c @@ -19,6 +19,7 @@ #include "hw/hw.h" #include "audio/audio.h" #include "syse

[Qemu-devel] [PATCH 11/13] usb-host-libusb: Fill in endpoint max_streams when available

2013-10-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..0dd60b2 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -720,6 +720,9 @@ static void usb_host_ep_updat

[Qemu-devel] [PULL 23/58] a9mpcore: Embed GICState

2013-10-08 Thread Andreas Färber
From: Andreas Färber Prepares for conversion to QOM realize. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index acbdab5..c57b1

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Alex Bligh
Hans, On 8 Oct 2013, at 21:16, Hans de Goede wrote: > No, it is calling main_loop_wait with nonblocking set to 0, so > normally the lock would get released. But > timerlistgroup_deadline_ns(&main_loop_tlg) is returning 0, > causing timeout_ns to be 0, and this causes the lock to not get > release

[Qemu-devel] [PATCH 07/13] usb-hcd-xhci: Update endpoint context dequeue pointer for streams too

2013-10-08 Thread Hans de Goede
With streams the endpoint context dequeue pointer should point to the dequeue value for the currently active stream. At least Linux guests expect it to point to value set by an set_ep_dequeue upon completion of the set_ep_dequeue (before kicking the ep). Otherwise the Linux kernel will complain (

[Qemu-devel] [PATCH 00/13] usb: Add support for bulk streams to usb-host-libusb

2013-10-08 Thread Hans de Goede
Hi Gerd et al, After quite a bit of work I'm very happy to present this patch set which adds full support for using USB-3 devices which use bulkstreams with qemu's usb host redirection. This has been tested under a Linux guest, with an uas usb-3 device, and works well and stable. There is a bunc

[Qemu-devel] [PULL 51/58] qom: Include error.h directly in object.h

2013-10-08 Thread Andreas Färber
From: Igor Mammedov qapi/error.h is simple enough to be included in qom/object.h directly and prepares qom/object.h to use Error typedef. Signed-off-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin Signed-off-by: Andreas Färber --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(

[Qemu-devel] [PULL 13/58] mcf5208: Don't enforce use of kernel for qtest

2013-10-08 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/m68k/mcf5208.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index fb96fe8..6e30c0b 100644 --- a/hw/m68k/mcf5208.c +++ b/hw/m68k/mcf5208.c @@ -10,6 +10,7 @@ #include "qemu/timer.h" #include "hw/ptimer.h" #incl

[Qemu-devel] [PULL 44/58] arm11mpcore: Split off RealView MPCore

2013-10-08 Thread Andreas Färber
Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/Makefile.objs | 1 + hw/cpu/arm11mpcore.c | 121 - hw/cpu/realview_mpcore.c | 139 +++ 3 files changed, 140 insertions(+), 121 deletio

[Qemu-devel] [PATCH 09/13] usb: Add usb_device_alloc/free_streams

2013-10-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/bus.c | 18 ++ include/hw/usb.h | 12 2 files changed, 30 insertions(+) diff --git a/hw/usb/bus.c b/hw/usb/bus.c index 72d5b92..bba554c 100644 --- a/hw/usb/bus.c +++ b/hw/usb/bus.c @@ -203,6 +203,24 @@ void usb_device_ep_st

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Hans de Goede
Hi, On 10/08/2013 10:01 PM, Alex Bligh wrote: The purpose of the 1 ns timeout is to cause os_host_main_loop_wait to unlock the iothread, as $subject says the problem I'm seeing seems to be lock starvation not cpu starvation. Note as I already indicated I'm in no way an expert in this, if you

[Qemu-devel] [PATCH 01/13] usb-host-libusb: Fix reset handling

2013-10-08 Thread Hans de Goede
The guest will issue an initial device reset when the device is attached, but since the current usb-host-libusb code only actually does the reset when udev->configuration != 0, and on attach the device is not yet configured, the reset gets ignored. This means that the device gets passed to the gues

[Qemu-devel] [PULL 18/58] leon3: Don't enforce use of -bios with qtest

2013-10-08 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/sparc/leon3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 390f3e4..c583c3d 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -26,6 +26,7 @@ #include "hw/ptimer.h" #include "sysemu/char

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Alex Bligh
On 8 Oct 2013, at 21:01, Alex Bligh wrote: > Somewhere within that patch series (7b595f35 I think) I fixed up > the spin counter bit, which made it slightly less yucky and work > with milliseconds. "with nanoseconds rather than microseconds" - oops -- Alex Bligh

Re: [Qemu-devel] [PATCH v2] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Michael Roth
Quoting Mark Wu (2013-10-08 01:23:09) > In the original code, qmp_get_command_list is used to construct > a list of all commands' name. To get the information of all qga > commands, it traverses the name list and search the command info > with its name. So it can cause O(n^2) in the number of comm

[Qemu-devel] [PATCH 13/13] usb-host-libusb: Set stream id when submitting bulk-stream transfers

2013-10-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 894875b..3376b96 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1214,10 +1214,22 @@ s

[Qemu-devel] [PATCH 12/13] usb-host-libusb: Add alloc / free streams ops

2013-10-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0dd60b2..894875b 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1280,6

[Qemu-devel] [PATCH 10/13] xhci: Call usb_device_alloc/free_streams

2013-10-08 Thread Hans de Goede
Note this code is not as KISS as I would like, the reason for this is that the Linux kernel interface wants streams on eps belonging to one interface to be allocated in one call. Things will also work if we do this one ep at a time (as long as all eps support the same amount of streams), but lets s

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Alex Bligh
On 8 Oct 2013, at 20:41, Hans de Goede wrote: >>> >>> Wasn't it 1 ms until the offending commit (note 250 us does >>> sound better to me). >> >> I believe you've made it 1 nanosecond not 1 millisecond; > > Correct, the 1 ms I referred to was before your commit which changed > things from ms to

[Qemu-devel] [PATCH 06/13] usb-hcd-xhci: Report completion of active transfer with CC_STOPPED on ep stop

2013-10-08 Thread Hans de Goede
As we should per the XHCI spec "4.6.9 Stop Endpoint". Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 7cf89ce..0131151 100644 --- a/hw/usb/hcd-xhci.c +++

[Qemu-devel] [PATCH 03/13] usb-host-libusb: Detach kernel drivers earlier

2013-10-08 Thread Hans de Goede
If we detach the kernel drivers on the first set_config, then they will be still attached when the device gets its initial reset. Causing the drivers to re-initialize the device after the reset, dirtying the device state. Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 7 +-- 1 file

[Qemu-devel] [PATCH 04/13] usb-hcd-xhci: Remove unused sstreamsm member from XHCIStreamContext

2013-10-08 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 469c24d..e078c50 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -374,7 +374,6 @@ struct XHCIStreamContext { dma_addr_t pctx;

[Qemu-devel] [PATCH 02/13] usb-host-libusb: Configuration 0 may be a valid configuration

2013-10-08 Thread Hans de Goede
Quoting from: linux/Documentation/ABI/stable/sysfs-bus-usb: Note that some devices, in violation of the USB spec, have a configuration with a value equal to 0. Writing 0 to bConfigurationValue for these devices will install that configuration, rather then unconfigur

[Qemu-devel] [PATCH 05/13] usb-hcd-xhci: Remove unused cancelled member from XHCITransfer

2013-10-08 Thread Hans de Goede
Since qemu's USB model is geared towards emulated devices cancellation is instanteneous, so no need to wait for cancellation to complete, as such there is no wait for cancellation code, and the cancelled bool as well as the bogus comment about it can be removed. Signed-off-by: Hans de Goede ---

[Qemu-devel] [PULL 14/58] an5206: Don't enforce use of kernel for qtest

2013-10-08 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/m68k/an5206.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c index a8eee44..24f2068 100644 --- a/hw/m68k/an5206.c +++ b/hw/m68k/an5206.c @@ -12,6 +12,7 @@ #include "hw/loader.h" #include "elf.h" #include "exec/ad

[Qemu-devel] [PULL 09/58] omap_sx1: Don't enforce use of kernel or flash for qtest

2013-10-08 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/omap_sx1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c index 03b3816..3ba263a 100644 --- a/hw/arm/omap_sx1.c +++ b/hw/arm/omap_sx1.c @@ -32,6 +32,7 @@ #include "hw/arm/arm.h" #include "hw/bl

[Qemu-devel] [PULL 52/58] qom: Clean up struct Error references

2013-10-08 Thread Andreas Färber
From: "Michael S. Tsirkin" Now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov Tested-by: Igor Mammed

[Qemu-devel] [PULL 15/58] milkymist: Suppress -kernel/-bios/-drive error for qtest

2013-10-08 Thread Andreas Färber
Acked-by: Michael Walle Signed-off-by: Andreas Färber --- hw/lm32/milkymist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index f1744ec..15053c4 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32/milkymist.c @@ -21,6 +21,7 @@ #incl

[Qemu-devel] [PULL 16/58] shix: Drop debug output

2013-10-08 Thread Andreas Färber
Reviewed-by: Aurelien Jarno Signed-off-by: Andreas Färber --- hw/sh4/shix.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c index 1ff37f5..f008b98 100644 --- a/hw/sh4/shix.c +++ b/hw/sh4/shix.c @@ -50,7 +50,6 @@ static void shix_init(QEMUMachineInitArgs *a

[Qemu-devel] [PULL 39/58] arm11mpcore: Convert ARM11MPCorePriveState to QOM realize

2013-10-08 Thread Andreas Färber
Embed child devices and replace SysBus initfn with realizefn. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 84 ++-- 1 file changed, 56 insertions(+), 28 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cp

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Alex Bligh
On 8 Oct 2013, at 20:10, Hans de Goede wrote: > I noticed today that current qemu master would hang as soon as Xorg starts in > the guest when using qxl + a Linux guest. This message would be printed: > main-loop: WARNING: I/O thread spun for 1000 iterations > > And from then on the guest hangs

[Qemu-devel] [PULL 57/58] ide: Drop ide_init2_with_non_qdev_drives()

2013-10-08 Thread Andreas Färber
All its users have finally been converted. Signed-off-by: Andreas Färber --- hw/ide/core.c | 49 - hw/ide/internal.h | 2 -- 2 files changed, 51 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 399b1ba..e1f4c33 100644 --- a/hw/id

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Hans de Goede
Hi, On 10/08/2013 09:33 PM, Alex Bligh wrote: On 8 Oct 2013, at 20:21, Hans de Goede wrote: Wasn't it 1 ms until the offending commit (note 250 us does sound better to me). I believe you've made it 1 nanosecond not 1 millisecond; Correct, the 1 ms I referred to was before your commit whic

[Qemu-devel] [PULL 31/58] a15mpcore: Embed GICState

2013-10-08 Thread Andreas Färber
From: Andreas Färber This covers both emulated and KVM GIC. Prepares for QOM realize. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/hw/cpu/a15mpcore

[Qemu-devel] [PULL 02/58] hw/arm: Tidy up conditional calls to arm_load_kernel()

2013-10-08 Thread Andreas Färber
From: Peter Maydell Now that arm_load_kernel() doesn't insist on a kernel filename being present, we can remove some unnecessary conditionals in board models. Signed-off-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/arm/omap_sx1.c | 10 -- hw/arm/palm.c | 10 -- h

Re: [Qemu-devel] [PATCH 4/7] usb-hcd-xhci: Remove unused sstreamsm member from XHCIStreamContext

2013-10-08 Thread Hans de Goede
Hi, On 09/24/2013 11:37 AM, Gerd Hoffmann wrote: On Mo, 2013-09-23 at 20:54 +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede Patch doesn't apply. Sorry, my bad, I had some other changes in my local tree which I was not yet ready to send and this depended on them. I'm ready to send

[Qemu-devel] [PATCH v2] Fix pc migration from qemu <= 1.5

2013-10-08 Thread Cole Robinson
The following commit introduced a migration incompatibility: commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe Author: David Gibson Date: Thu Jun 6 18:48:49 2013 +1000 pci: Replace pci_find_domain() with more general pci_root_bus_path() The issue is that i440fx savevm idstr went from :0

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Alex Bligh
On 8 Oct 2013, at 20:21, Hans de Goede wrote: > Wasn't it 1 ms until the offending commit (note 250 us does > sound better to me). I believe you've made it 1 nanosecond not 1 millisecond; can that be right? -- Alex Bligh

[Qemu-devel] [PULL 07/58] z2: Don't enforce use of -pflash for qtest

2013-10-08 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/z2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index a00fcc0..d52c501 100644 --- a/hw/arm/z2.c +++ b/hw/arm/z2.c @@ -24,6 +24,7 @@ #include "ui/console.h" #include "audio/audio.h" #include "exec/a

[Qemu-devel] [PULL 41/58] realview_gic: Prepare for QOM embedding

2013-10-08 Thread Andreas Färber
Move state struct, type constant and cast macro to a new header. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/intc/realview_gic.c | 15 +-- include/hw/intc/realview_gic.h | 28 2 files changed, 29 insertions(+), 14 deletions(-)

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Hans de Goede
Hi, On 10/08/2013 09:13 PM, Paolo Bonzini wrote: Il 08/10/2013 21:10, Hans de Goede ha scritto: @@ -480,6 +480,11 @@ int main_loop_wait(int nonblocking) timerlistgroup_deadline_ns( &main_loop_tlg)); +/* Whe

[Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Hans de Goede
I noticed today that current qemu master would hang as soon as Xorg starts in the guest when using qxl + a Linux guest. This message would be printed: main-loop: WARNING: I/O thread spun for 1000 iterations And from then on the guest hangs and qemu consumes 100% cpu, bisecting pointed out commit 7

Re: [Qemu-devel] [PATCH] main-loop: Don't lock starve io-threads when main_loop_tlg has pending events

2013-10-08 Thread Paolo Bonzini
Il 08/10/2013 21:10, Hans de Goede ha scritto: > @@ -480,6 +480,11 @@ int main_loop_wait(int nonblocking) >timerlistgroup_deadline_ns( >&main_loop_tlg)); > > +/* When not non-blocking always allow io-threads t

[Qemu-devel] [PULL 34/58] a9scu: Build only once

2013-10-08 Thread Andreas Färber
It does not have a target or ARMCPU dependency. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs index 2578e29..5636299 100644 --- a/hw/misc/Makefi

Re: [Qemu-devel] [Spice-devel] Current qemu-master hangs when used with qxl + linux guest

2013-10-08 Thread Hans de Goede
Hi, On 10/08/2013 04:30 PM, Daniel P. Berrange wrote: On Tue, Oct 08, 2013 at 04:27:38PM +0200, Hans de Goede wrote: Hi All, I'm having this weird problem with qemu master + spice/qxl using guests. As soon as the guest starts Xorg, I get the following message from qemu: main-loop: WARNING: I/

[Qemu-devel] [PULL 25/58] a9mpcore: Embed A9SCUState

2013-10-08 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 16 ++-- hw/misc/a9scu.c | 18 +- include/hw/misc/a9scu.h | 31 +++ 3 files changed, 42 inserti

Re: [Qemu-devel] [PATCHv6] block/get_block_status: avoid redundant callouts on raw devices

2013-10-08 Thread Eric Blake
On 10/08/2013 06:43 AM, Peter Lieven wrote: > if a raw device like an iscsi target or host device is used > the current implementation makes a second call out to get > the block status of bs->file. > > Signed-off-by: Peter Lieven > --- Reviewed-by: Eric Blake -- Eric Blake eblake redhat com

[Qemu-devel] [PULL 27/58] a9mpcore: Embed ARMMPTimerState

2013-10-08 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 29 ++- hw/timer/arm_mptimer.c | 35 --- include/hw/timer/arm_mptimer.h | 54 +++

[Qemu-devel] [PULL 45/58] qdev-monitor: Clean up qdev_device_add() variable naming

2013-10-08 Thread Andreas Färber
Avoid confusion between object (obj) and object class (oc). Tidy DeviceClass variable while at it (k -> dc). Signed-off-by: Andreas Färber --- qdev-monitor.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 410cdcb

[Qemu-devel] [PULL 11/58] armv7m: Don't enforce use of kernel for qtest

2013-10-08 Thread Andreas Färber
Adopt error_report(). Signed-off-by: Andreas Färber --- hw/arm/armv7m.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 89a9015..397e8df 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -11,6 +11,8 @@ #

[Qemu-devel] [PULL 56/58] microdrive: Coding Style cleanups

2013-10-08 Thread Andreas Färber
Add missing braces. Signed-off-by: Andreas Färber --- hw/ide/microdrive.c | 62 - 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/hw/ide/microdrive.c b/hw/ide/microdrive.c index cdf0eb9..21d6495 100644 --- a/hw/ide/microdrive.c

[Qemu-devel] [PULL 48/58] qdev: Drop misleading qdev_free() function

2013-10-08 Thread Andreas Färber
From: Stefan Hajnoczi The qdev_free() function name is misleading since all the function does is unlink the device from its parent. The device is not necessarily freed. The device will be freed when its QObject refcount reaches zero. It is usual for the parent (bus) to hold the final reference

[Qemu-devel] [PULL 49/58] qdev-monitor: Avoid qdev as variable name

2013-10-08 Thread Andreas Färber
Prepares for bringing error cleanup code into canonical QOM form. Includes a whitespace removal after curly brace by Stefan. Signed-off-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- qdev-monitor.c | 32 1 file changed, 16 ins

[Qemu-devel] [PULL 42/58] arm11mpcore: Convert mpcore_rirq_state to QOM realize

2013-10-08 Thread Andreas Färber
Embed ARM11MPCorePriveState and RealViewGICState and replace SysBus initfn with realizefn. Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 58 +++- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a

[Qemu-devel] [PULL 19/58] qtest: Prepare QOM machine tests

2013-10-08 Thread Andreas Färber
Instantiate all [*] machines per target, so that they get a bit of test coverage at all. This has proven helpful during QOM refactorings. [*] ppcemb target contains some non-working non-embedded machines, and ppc405 CPUs are not available there either. i386 and x86_64 do not cover pc*-x.y or xenfv

[Qemu-devel] [PULL 35/58] arm11mpcore: Fix typo in MemoryRegion name

2013-10-08 Thread Andreas Färber
"mpcode" -> "mpcore" Reviewed-by: Peter Maydell Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index a786c62..27cd32b 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcor

  1   2   3   >