Re: [Qemu-devel] QEMU ARM946 emulation, DIGIC, and MPU fault handling

2014-01-24 Thread Antony Pavlov
On Thu, 23 Jan 2014 22:25:36 + Peter Maydell peter.mayd...@linaro.org wrote: Hi Antony; have you noticed any issues with QEMU's handling of MPU faults (data or address faults) on our ARM946 model? I ask because DIGIC is the only board we have that uses the 946, and as far as I can tell

Re: [Qemu-devel] [PATCH v4 0/5] QMP full introspection

2014-01-24 Thread Amos Kong
On Thu, Jan 23, 2014 at 10:46:31PM +0800, Amos Kong wrote: This is an implement of qmp full-introspection, parse and convert the json schema to a dynamical tree, return it to management through QMP command output. Correct the URLs The whole output of query-qmp-schema command:

Re: [Qemu-devel] [PATCH target-arm v5 0/5] Reset and Halting modifications + Zynq SMP

2014-01-24 Thread Peter Crosthwaite
ping! On Wed, Jan 15, 2014 at 7:12 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi All, The clock controller module in the Zynq platform has the ability to halt and reset arbitrary devices, including the CPU. We use this feature to implement SMP Linux - the kernel halts CPU1

Re: [Qemu-devel] [PATCH v4 2/5] qapi: add qapi-introspect.py code generator

2014-01-24 Thread Fam Zheng
On Thu, 01/23 22:46, Amos Kong wrote: This is a code generator for qapi introspection. It will parse qapi-schema.json, extend schema definitions and generate a schema table with metadata, it references to the new structs which we used to describe dynamic data structs. The metadata will help C

Re: [Qemu-devel] [PATCH v4 1/4] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset()

2014-01-24 Thread Hu Tao
On Thu, Jan 23, 2014 at 03:29:04PM +0100, Kevin Wolf wrote: Am 23.01.2014 um 04:04 hat Hu Tao geschrieben: n_start can be actually calculated from offset. The number of sectors to be allocated(n_end - n_start) can be passed in in num. By removing n_start and n_end, we can save two

Re: [Qemu-devel] [PATCH v4 2/5] qapi: add qapi-introspect.py code generator

2014-01-24 Thread Amos Kong
On Fri, Jan 24, 2014 at 05:12:12PM +0800, Fam Zheng wrote: On Thu, 01/23 22:46, Amos Kong wrote: This is a code generator for qapi introspection. It will parse qapi-schema.json, extend schema definitions and generate a schema table with metadata, it references to the new structs which we

Re: [Qemu-devel] [PATCH v4 1/4] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset()

2014-01-24 Thread Hu Tao
On Thu, Jan 23, 2014 at 06:02:08PM +0100, Benoît Canet wrote: Le Thursday 23 Jan 2014 à 11:04:05 (+0800), Hu Tao a écrit : n_start can be actually calculated from offset. The number of sectors to be allocated(n_end - n_start) can be passed in in num. By removing n_start and n_end, we can

Re: [Qemu-devel] [PATCH 07/13 v7] dump: add members to DumpState and init some of them

2014-01-24 Thread Laszlo Ersek
On 01/24/14 02:52, Qiao Nuohan wrote: On 01/23/2014 01:04 AM, Laszlo Ersek wrote: @@ -864,6 +884,16 @@ static int dump_init(DumpState *s, int fd, bool paging, bool has_filter, qemu_get_guest_simple_memory_mapping(s-list,s-guest_phys_blocks); } +s-nr_cpus =

Re: [Qemu-devel] [PATCH v4 2/4] qcow2: fix offset overflow in qcow2_alloc_clusters_at()

2014-01-24 Thread Hu Tao
On Thu, Jan 23, 2014 at 06:13:48PM +0100, Benoît Canet wrote: Le Thursday 23 Jan 2014 à 11:04:06 (+0800), Hu Tao a écrit : When cluster size is big enough it can lead offset overflow Maybe it can lead to an offset overflow in in qcow2_alloc_clusters_at(). This patch fixes it. Sure.

Re: [Qemu-devel] [PATCH v11 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-24 Thread Fam Zheng
Ping? On Wed, 01/08 18:07, Fam Zheng wrote: This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup with existing device as target). We get a thin point-in-time snapshot by COW mechanism of drive-backup, and export it through built in NBD

Re: [Qemu-devel] Possible bug in monitor code

2014-01-24 Thread Stratos Psomadakis
On 01/23/2014 08:28 PM, Luiz Capitulino wrote: On Thu, 23 Jan 2014 17:33:33 +0200 Stratos Psomadakis pso...@grnet.gr wrote: On 01/23/2014 03:54 PM, Luiz Capitulino wrote: On Thu, 23 Jan 2014 08:44:02 -0500 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 23 Jan 2014 19:23:51 +0800

[Qemu-devel] [PATCH] target-i386: Fix I/O bitmap checks for in/out

2014-01-24 Thread Kevin Wolf
Commit 1b90d56e changed the implementation of in/out imm to not assign the accessed port number to cpu_T[0] as it appeared unnecessary. However, currently gen_check_io() makes use of cpu_T[0] to implement the I/O bitmap checks, so it's in fact still used and the change broke the check, leading to

Re: [Qemu-devel] [PATCH] osdep: drop unused #include trace.h

2014-01-24 Thread Michael Tokarev
24.01.2014 00:27, Stefan Hajnoczi wrote: osdep.c does not use trace_*() so we can just drop the include. Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-24 Thread Fam Zheng
On Thu, 01/23 22:46, Amos Kong wrote: This patch introduces a new monitor command to query QMP schema information, the return data is a range of schema structs, which contains the useful metadata to help management to check supported features, QMP commands detail, etc. We use

Re: [Qemu-devel] [PATCH v2] qapi: Add backing to BlockStats

2014-01-24 Thread Kevin Wolf
Am 23.01.2014 um 03:03 hat Fam Zheng geschrieben: Currently there is no way to query BlockStats of the backing chain. This adds backing field into BlockStats to make it possible. The comment of parent is reworded. Signed-off-by: Fam Zheng f...@redhat.com Thanks, applied to the block

Re: [Qemu-devel] [PATCH 12/13 v7] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-01-24 Thread Laszlo Ersek
On 01/23/14 16:17, Ekaterina Tumanova wrote: On 01/17/2014 11:46 AM, qiaonuohan wrote: Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of

Re: [Qemu-devel] [PATCH v4 1/3] block: resize backing file image during offline commit, if necessary

2014-01-24 Thread Kevin Wolf
Am 23.01.2014 um 23:45 hat Jeff Cody geschrieben: Currently, if an image file is logically larger than its backing file, committing it via 'qemu-img commit' will fail. For instance, if we have a base image with a virtual size 10G, and a snapshot image of size 20G, then committing the

Re: [Qemu-devel] [PATCH v4 5/5] update docs/qmp-full-introspection.txt

2014-01-24 Thread Paolo Bonzini
Il 23/01/2014 15:46, Amos Kong ha scritto: +The whole schema information will be returned in one go, it contains +all the schema entries. It doesn't support to be filtered by type +or name. Currently it takes about 4 seconds to return about 1.7M string. +Management only needs to execute this

Re: [Qemu-devel] [PATCH 12/13 v7] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-01-24 Thread Laszlo Ersek
Thanks for addressing my earlier comments. Some new ones below: On 01/17/14 08:46, qiaonuohan wrote: +/* check whether lzo/snappy is supported */ +#ifndef CONFIG_LZO +if (has_format format == DUMP_GUEST_MEMORY_FORMAT_KDUMP_LZO) { +error_setg(errp, kdump-lzo is not available

[Qemu-devel] Strange monitor behavior related to hotplug commands

2014-01-24 Thread Dimitris Aragiorgis
Hi, After having heavily used device_add/netdev_add lately with QEMU 1.7, we encountered the following strange behavior: 1) Get network/PCI configuration for a VM # echo info network | socat STDIO UNIX-CONNECT:/path/to/monitor/socket QEMU 1.7.0 monitor - type 'help' for more

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMUsystem emulated TLBB

2014-01-24 Thread Alex Bennée
trent.t...@gmail.com writes: Attaching data in excel which could not be sent with the patch at the same time. snip If you can attach the summary of the data as plain text that would be useful. Not all of us have access to a Windows box with Excell! -- Alex Bennée

Re: [Qemu-devel] [PATCH v11 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 11:10 hat Fam Zheng geschrieben: Ping? This doesn't apply on top of the block branch any more. Can you rebase, please? Kevin On Wed, 01/08 18:07, Fam Zheng wrote: This series adds for point-in-time snapshot NBD exporting based on blockdev-backup (variant of drive-backup

Re: [Qemu-devel] [PATCH 13/13 v7] dump: add 'query-dump-guest-memory-capability' command

2014-01-24 Thread Laszlo Ersek
two comments below On 01/17/14 08:46, qiaonuohan wrote: 'query-dump-guest-memory-capability' is used to query whether option 'format' is available for 'dump-guest-memory' and the available format. The output of the command will be like: - { execute: query-dump-guest-memory-capability } - {

[Qemu-devel] Native MinGW build crashes when partitioning hard disk in MS-DOS guest

2014-01-24 Thread Legorol
I am building the official Qemu 1.7.0 release from source natively under MinGW for myself. I execute the i386 target. Qemu starts fine, but it crashes when I try to partition a 2G hard disk in an MS-DOS 6.22 guest. Details of the build and reproducing the crash are below. The problem also

Re: [Qemu-devel] [PATCH v4 5/5] update docs/qmp-full-introspection.txt

2014-01-24 Thread Eric Blake
On 01/24/2014 04:43 AM, Paolo Bonzini wrote: Il 23/01/2014 15:46, Amos Kong ha scritto: +The whole schema information will be returned in one go, it contains +all the schema entries. It doesn't support to be filtered by type +or name. Currently it takes about 4 seconds to return about 1.7M

[Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Kevin Wolf
bdrv_commit() could return 0 or 1 on success, depending on whether or now the last sector was allocated in the overlay and whether the overlay format had a .bdrv_make_empty callback. Most callers ignored it, but qemu-img commit would print an error message while the operation actually succeeded.

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-24 Thread Kevin Wolf
Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben: Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) I'm not going to merge this one yet. It breaks qemu-iotests case 071, which would have to be adapted. However, first of

Re: [Qemu-devel] [PATCH V6 0/8] Giving names to graph's BlockDriverState

2014-01-24 Thread Kevin Wolf
Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben: The following series introduce a new file.node-name property in order to be able to give a name to each BlockDriverState of the graph. since v5: rename to bdrv_assign_node_name [Fam] add node-name to BlockdevOptionsBase [Kevin]

Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together

2014-01-24 Thread Kevin Wolf
Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben: Having both read-only=on and snapshot=on together does not make sense; currently, the read-only argument is effectively ignored for the temporary snapshot. To prevent confusion, disallow the usage of both 'snapshot=on' and 'read-only=on'.

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-24 Thread Max Reitz
On 24.01.2014 14:26, Kevin Wolf wrote: Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben: Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) I'm not going to merge this one yet. It breaks qemu-iotests case 071, which

Re: [Qemu-devel] [PATCH] block: do not allow read-only=on and snapshot=on to be used together

2014-01-24 Thread Jeff Cody
On Fri, Jan 24, 2014 at 02:33:19PM +0100, Kevin Wolf wrote: Am 14.01.2014 um 20:12 hat Jeff Cody geschrieben: Having both read-only=on and snapshot=on together does not make sense; currently, the read-only argument is effectively ignored for the temporary snapshot. To prevent confusion,

[Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-24 Thread Paolo Bonzini
From: Peter Maydell peter.mayd...@linaro.org libcurl versions 7.16.0 and later have a timer callback interface which must be implemented in order for libcurl to make forward progress (it will sometimes rely on being called back on the timeout if there are no file descriptors registered).

[Qemu-devel] [PATCH v5 3/3] block: update block commit documentation regarding image truncation

2014-01-24 Thread Jeff Cody
This updates the documentation for commiting snapshot images. Specifically, this highlights what happens when the base image is either smaller or larger than the snapshot image being committed. In the case of the base image being smaller, it is resized to the larger size of the snapshot image.

[Qemu-devel] [PATCH v5 1/3] block: resize backing file image during offline commit, if necessary

2014-01-24 Thread Jeff Cody
Currently, if an image file is logically larger than its backing file, committing it via 'qemu-img commit' will fail. For instance, if we have a base image with a virtual size 10G, and a snapshot image of size 20G, then committing the snapshot offline with 'qemu-img commit' will likely fail.

[Qemu-devel] [PATCH v5 2/3] block: resize backing image during active layer commit, if needed

2014-01-24 Thread Jeff Cody
If the top image to commit is the active layer, and also larger than the base image, then an I/O error will likely be returned during block-commit. For instance, if we have a base image with a virtual size 10G, and a active layer image of size 20G, then committing the snapshot via 'block-commit'

[Qemu-devel] [PATCH v5 0/3] block: commits of snapshots larger than backing files

2014-01-24 Thread Jeff Cody
Changes, v4-v5 Patch 1/3: Update ret in bdrv_commit() (Kevin) Patch 2/3: None Patch 3/3: None Changes, v3-v4 Patch 1/3: Commit message typo (Eric) Patch 2/3: Removed dead code (Benoît) Patch 3/3: None Changes, v2-v3: Patch 1/3: None Patch 2/3: Set errp for both bdrv_getlength() failure cases

Re: [Qemu-devel] Possible bug in monitor code

2014-01-24 Thread Luiz Capitulino
On Fri, 24 Jan 2014 12:14:12 +0200 Stratos Psomadakis pso...@grnet.gr wrote: On 01/23/2014 08:28 PM, Luiz Capitulino wrote: On Thu, 23 Jan 2014 17:33:33 +0200 Stratos Psomadakis pso...@grnet.gr wrote: On 01/23/2014 03:54 PM, Luiz Capitulino wrote: On Thu, 23 Jan 2014 08:44:02 -0500

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Wei Liu
On Thu, Jan 23, 2014 at 10:30:16PM +, Peter Maydell wrote: On 23 January 2014 22:16, Wei Liu wei.l...@citrix.com wrote: As promised I hacked a prototype based on Paolo's disable TCG series. However I coded some stubs for TCG anyway. So this series in principle should work with / without

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Paolo Bonzini
Il 23/01/2014 23:30, Peter Maydell ha scritto: As promised I hacked a prototype based on Paolo's disable TCG series. However I coded some stubs for TCG anyway. So this series in principle should work with / without Paolo's series. I'm afraid I still think this is a terrible idea. Xen isn't a

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Peter Maydell
On 24 January 2014 14:30, Paolo Bonzini pbonz...@redhat.com wrote: Il 23/01/2014 23:30, Peter Maydell ha scritto: I'm afraid I still think this is a terrible idea. Xen isn't a CPU, and the binary is smaller isn't IMHO sufficient justification for breaking QEMU's basic structure of target-*

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Paolo Bonzini
Il 24/01/2014 15:23, Wei Liu ha scritto: On Thu, Jan 23, 2014 at 10:30:16PM +, Peter Maydell wrote: On 23 January 2014 22:16, Wei Liu wei.l...@citrix.com wrote: As promised I hacked a prototype based on Paolo's disable TCG series. However I coded some stubs for TCG anyway. So this series

[Qemu-devel] [Bug 1272252] [NEW] qemu-img ftp/http convert

2014-01-24 Thread Mr J
Public bug reported: Converting images with ftp or http as source could be done a lot faster. The way it works now (qemu 1.7.50) is significantly slower than the optimal way. FTP - how it works now 1. Connect and login to ftp-server. Ask for size of file. 2. Get a chunk of data using rest+retr

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Paolo Bonzini
Il 24/01/2014 15:35, Peter Maydell ha scritto: (1) decide that the Xen ring buffers are little-endian even on big-endian CPUs (2) communicate the endianness of the Xen ring buffers via Xenstore, just like we do for sizeof(long), and let the guest use either endianness on any architecture.

Re: [Qemu-devel] Possible bug in monitor code

2014-01-24 Thread Apollon Oikonomopoulos
Hi all, On 12:14 Fri 24 Jan , Stratos Psomadakis wrote: On 01/23/2014 08:28 PM, Luiz Capitulino wrote: Not yet, I may have some time tomorrow. How reproducible is it for you? We can trigger it (by following the steps described in the first mail) consistently. Another question:

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 14:37 hat Max Reitz geschrieben: On 24.01.2014 14:26, Kevin Wolf wrote: Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben: Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) I'm not going to merge this

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Wei Liu
On Fri, Jan 24, 2014 at 03:38:01PM +0100, Paolo Bonzini wrote: Il 24/01/2014 15:23, Wei Liu ha scritto: On Thu, Jan 23, 2014 at 10:30:16PM +, Peter Maydell wrote: On 23 January 2014 22:16, Wei Liu wei.l...@citrix.com wrote: As promised I hacked a prototype based on Paolo's disable TCG

Re: [Qemu-devel] [PATCH V6 2/8] block: Allow the user to define node-name option both on command line and QMP.

2014-01-24 Thread Benoît Canet
Le Thursday 23 Jan 2014 à 21:31:33 (+0100), Benoît Canet a écrit : From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 36 qapi-schema.json | 2 ++ 2 files changed, 38 insertions(+) diff --git

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-01-24 Thread Max Reitz
On 24.01.2014 15:48, Kevin Wolf wrote: Am 24.01.2014 um 14:37 hat Max Reitz geschrieben: On 24.01.2014 14:26, Kevin Wolf wrote: Am 23.01.2014 um 21:31 hat Benoît Canet geschrieben: Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [Qemu-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Stefano Stabellini
On Fri, 24 Jan 2014, Paolo Bonzini wrote: Il 24/01/2014 15:35, Peter Maydell ha scritto: (1) decide that the Xen ring buffers are little-endian even on big-endian CPUs (2) communicate the endianness of the Xen ring buffers via Xenstore, just like we do for sizeof(long),

Re: [Qemu-devel] [PATCH] block/curl: Implement the libcurl timer callback interface

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 14:56 hat Paolo Bonzini geschrieben: From: Peter Maydell peter.mayd...@linaro.org libcurl versions 7.16.0 and later have a timer callback interface which must be implemented in order for libcurl to make forward progress (it will sometimes rely on being called back on the

Re: [Qemu-devel] [PATCH v4 4/4] qemu-iotests: add test for qcow2 preallocation with different cluster sizes

2014-01-24 Thread Max Reitz
On 23.01.2014 04:04, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- tests/qemu-iotests/079 | 63 ++ tests/qemu-iotests/079.out | 32 +++ tests/qemu-iotests/group | 1 + 3 files changed, 96 insertions(+)

Re: [Qemu-devel] [PATCH V6 2/8] block: Allow the user to define node-name option both on command line and QMP.

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 15:51 hat Benoît Canet geschrieben: Le Thursday 23 Jan 2014 à 21:31:33 (+0100), Benoît Canet a écrit : From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 36

Re: [Qemu-devel] [PATCH v5 0/3] block: commits of snapshots larger than backing files

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 15:02 hat Jeff Cody geschrieben: Changes, v4-v5 Patch 1/3: Update ret in bdrv_commit() (Kevin) Patch 2/3: None Patch 3/3: None [...] If a snapshot is larger than a backing file, then the offline bdrv_commit and the live active layer commit will fail with an i/o error

Re: [Qemu-devel] [PATCH v4 2/4] qcow2: fix offset overflow in qcow2_alloc_clusters_at()

2014-01-24 Thread Benoît Canet
Le Friday 24 Jan 2014 à 18:01:20 (+0800), Hu Tao a écrit : On Thu, Jan 23, 2014 at 06:13:48PM +0100, Benoît Canet wrote: Le Thursday 23 Jan 2014 à 11:04:06 (+0800), Hu Tao a écrit : When cluster size is big enough it can lead offset overflow Maybe it can lead to an offset overflow in

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 0/5] Xen: introduce Xen PV target

2014-01-24 Thread Ian Campbell
On Fri, 2014-01-24 at 14:56 +, Stefano Stabellini wrote: Besides I don't know how to state this more clearly but there are no big endian Xen guests. There have never been any big endian Xen guests. There are no big endian Xen guests on the roadmap. That is perhaps a bit strong, but what is

Re: [Qemu-devel] [PATCH v4 1/4] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset()

2014-01-24 Thread Benoît Canet
Le Friday 24 Jan 2014 à 17:32:40 (+0800), Hu Tao a écrit : On Thu, Jan 23, 2014 at 06:02:08PM +0100, Benoît Canet wrote: Le Thursday 23 Jan 2014 à 11:04:05 (+0800), Hu Tao a écrit : n_start can be actually calculated from offset. The number of sectors to be allocated(n_end - n_start) can

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Benoît Canet
Le Friday 24 Jan 2014 à 14:08:21 (+0100), Kevin Wolf a écrit : bdrv_commit() could return 0 or 1 on success, depending on whether or now the last sector was allocated in the overlay and whether the overlay format had a .bdrv_make_empty callback. Most callers ignored it, but qemu-img commit

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Jeff Cody
On Fri, Jan 24, 2014 at 02:08:21PM +0100, Kevin Wolf wrote: bdrv_commit() could return 0 or 1 on success, depending on whether or now the last sector was allocated in the overlay and whether the overlay format had a .bdrv_make_empty callback. Most callers ignored it, but qemu-img commit

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 16:56 hat Jeff Cody geschrieben: On Fri, Jan 24, 2014 at 02:08:21PM +0100, Kevin Wolf wrote: bdrv_commit() could return 0 or 1 on success, depending on whether or now the last sector was allocated in the overlay and whether the overlay format had a .bdrv_make_empty

Re: [Qemu-devel] [PATCH v3 21/29] block: Assert serialisation assumptions in pwritev

2014-01-24 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:15:11 (+0100), Kevin Wolf a écrit : If a request calls wait_serialising_requests() and actually has to wait in this function (i.e. a coroutine yield), other requests can run and previously read data (like the head or tail buffer) could become outdated. In this case,

[Qemu-devel] [PATCH 5/5] kvm: add support for hyper-v timers

2014-01-24 Thread Paolo Bonzini
From: Vadim Rozenfeld vroze...@redhat.com http://msdn.microsoft.com/en-us/library/windows/hardware/ff541625%28v=vs.85%29.aspx This code is generic for activating reference time counter or virtual reference time stamp counter Signed-off-by: Vadim Rozenfeld vroze...@redhat.com Reviewed-by:

[Qemu-devel] [PATCH 4/5] kvm: make hyperv vapic assist page migratable

2014-01-24 Thread Paolo Bonzini
From: Vadim Rozenfeld vroze...@redhat.com Signed-off-by: Vadim Rozenfeld vroze...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-i386/cpu.h | 1 + target-i386/kvm.c | 16 +--- target-i386/machine.c | 22 ++ 3 files changed, 36

[Qemu-devel] [PATCH 3/5] kvm: make hyperv hypercall and guest os id MSRs migratable.

2014-01-24 Thread Paolo Bonzini
From: Vadim Rozenfeld vroze...@redhat.com Signed-off-by: Vadim Rozenfeld vroze...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-i386/cpu.h | 2 ++ target-i386/kvm.c | 18 +++--- target-i386/machine.c | 23 +++ 3 files changed, 40

Re: [Qemu-devel] [PATCH v3 21/29] block: Assert serialisation assumptions in pwritev

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 17:09 hat Benoît Canet geschrieben: Le Friday 17 Jan 2014 à 15:15:11 (+0100), Kevin Wolf a écrit : If a request calls wait_serialising_requests() and actually has to wait in this function (i.e. a coroutine yield), other requests can run and previously read data (like the

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Jeff Cody
On Fri, Jan 24, 2014 at 05:00:45PM +0100, Kevin Wolf wrote: Am 24.01.2014 um 16:56 hat Jeff Cody geschrieben: On Fri, Jan 24, 2014 at 02:08:21PM +0100, Kevin Wolf wrote: bdrv_commit() could return 0 or 1 on success, depending on whether or now the last sector was allocated in the overlay

[Qemu-devel] [PATCH v2 0/4] mips32r5 with UFR

2014-01-24 Thread Petar Jovanovic
Version 2 of the patch series to add mips32r5-generic model with UFR feature. It includes extra patch to add support for Config4. Petar Jovanovic (4): target-mips: add CPU definition for MIPS32R5 target-mips: add support for CP0_Config4 target-mips: add support for CP0_Config5

[Qemu-devel] [PATCH v2 4/4] target-mips: add user-mode FR switch support for MIPS32r5

2014-01-24 Thread Petar Jovanovic
From: Petar Jovanovic petar.jovano...@imgtec.com Description of UFR feature: Required in MIPS32r5 if floating point is implemented and user-mode FR switching is supported. The UFR register allows user-mode to clear StatusFR by executing a CTC1 to UFR with GPR[0] as input, and read StatusFR by

Re: [Qemu-devel] [PATCH v3 25/29] iscsi: Set bs-request_alignment

2014-01-24 Thread Benoît Canet
Le Friday 17 Jan 2014 à 15:15:15 (+0100), Kevin Wolf a écrit : From: Paolo Bonzini pbonz...@redhat.com The iSCSI backend already gets the block size from the READ CAPACITY command it sends. Save it so that the generic block layer gets it too. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-01-24 Thread Petar Jovanovic
From: Petar Jovanovic petar.jovano...@imgtec.com Add mips32r5-generic among CPU definitions for MIPS. Define ISA_MIPS32R3 and ISA_MIPS32R5. Signed-off-by: Petar Jovanovic petar.jovano...@imgtec.com --- target-mips/mips-defs.h |8 target-mips/translate_init.c | 25

[Qemu-devel] [PATCH v2 2/4] target-mips: add support for CP0_Config4

2014-01-24 Thread Petar Jovanovic
From: Petar Jovanovic petar.jovano...@imgtec.com Add CP0_Config4, define rw_bitmask. Signed-off-by: Petar Jovanovic petar.jovano...@imgtec.com --- target-mips/cpu.h|3 +++ target-mips/helper.h |1 + target-mips/op_helper.c |6 ++ target-mips/translate.c

[Qemu-devel] [PATCH v2 3/4] target-mips: add support for CP0_Config5

2014-01-24 Thread Petar Jovanovic
From: Petar Jovanovic petar.jovano...@imgtec.com Add CP0_Config5, define rw_bitmask and enable modifications. Signed-off-by: Petar Jovanovic petar.jovano...@imgtec.com --- target-mips/cpu.h| 10 ++ target-mips/helper.h |1 + target-mips/op_helper.c |6

Re: [Qemu-devel] [PATCH] ACPI: Add IRQ resource to HPET._CRS on Mac OS X

2014-01-24 Thread Gabriel L. Somlo
On Tue, Jan 21, 2014 at 08:38:51PM +0200, Michael S. Tsirkin wrote: On Tue, Jan 21, 2014 at 01:11:01PM -0500, Gabriel L. Somlo wrote: Apple hardware invariably adds IRQNoFlags() {0, 8} to HPET._CRS, and, at least on piix+smp, an OS X guest will panic unless IRQNoFlags is present. On the

Re: [Qemu-devel] [PATCH v2] cpu: implementing victim TLB for QEMUsystem emulated TLBB

2014-01-24 Thread Richard Henderson
On 01/24/2014 04:15 AM, Alex Bennée wrote: If you can attach the summary of the data as plain text that would be useful. Not all of us have access to a Windows box with Excell! To be fair, it can be opened with openoffice. r~

[Qemu-devel] [PATCH 1/5] KVM: fix coexistence of KVM and Hyper-V leaves

2014-01-24 Thread Paolo Bonzini
kvm_arch_init_vcpu's initialization of the KVM leaves at 0x4100 is broken, because KVM_CPUID_FEATURES is left at 0x4001. Move it to 0x4101 if Hyper-V is enabled. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-i386/kvm.c | 47

[Qemu-devel] [PATCH uq/master 0/5] Hyper-V improvements and migratability

2014-01-24 Thread Paolo Bonzini
The first patch fixes the KVM leaves at 0x4100. Before, there is no leaf at 0x4101 (and the data of the highest Intel leaf is returned, e.g. 0xd on a Sandy Bridge). After this patch there is one. The second patch is extracted from Vadim's migration patches, which are patches 3-5.

[Qemu-devel] [PATCH 2/5] kvm: make availability of Hyper-V enlightenments dependent on KVM_CAP_HYPERV

2014-01-24 Thread Paolo Bonzini
The MS docs specify HV_X64_MSR_HYPERCALL as a mandatory interface, thus we must provide the MSRs even if the user only specified features that, like relaxed timing, in principle don't require them. And the MSRs are only there if the hypervisor has KVM_CAP_HYPERV. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH RFC 5/5] xen: introduce xenpv-softmmu.mak

2014-01-24 Thread Wei Liu
On Fri, Jan 24, 2014 at 08:38:19AM +0100, Paolo Bonzini wrote: Il 23/01/2014 23:16, Wei Liu ha scritto: -echo CONFIG_XEN_PCI_PASSTHROUGH=y $config_target_mak +if test $target_name != xenpv; then +echo CONFIG_XEN_I386=y $config_target_mak +if test

[Qemu-devel] [PULL v2 00/93] Block patches

2014-01-24 Thread Kevin Wolf
This supersedes my pull request from two weeks ago. The following changes since commit 732c66ce641c69702a7e7fdb73b68f0c1b583ab5: Revert error: Don't use error_report() for assertion msgs. (2014-01-17 09:50:11 +1000) are available in the git repository at: git://repo.or.cz/qemu/kevin.git

[Qemu-devel] [PULL 04/93] qemu-iotests: Clean up all extents for vmdk

2014-01-24 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com This modifies _cleanup_test_img to remove all the extent files listed by qemu-img info's format specific information. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PULL 08/93] gluster: Add support for creating zero-filled image

2014-01-24 Thread Kevin Wolf
From: Bharata B Rao bhar...@linux.vnet.ibm.com GlusterFS supports creation of zero-filled file on GlusterFS volume by means of an API called glfs_zerofill(). Use this API from QEMU to create an image that is filled with zeroes by using the preallocation option of qemu-img. qemu-img create

[Qemu-devel] [PULL 02/93] qemu-iotests: Introduce _unsupported_imgopts

2014-01-24 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Introduce _unsupported_imgopts that causes _notrun for specific image options. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/common.rc | 11 +++

[Qemu-devel] [PULL 06/93] gluster: Convert aio routines into coroutines

2014-01-24 Thread Kevin Wolf
From: Bharata B Rao bhar...@linux.vnet.ibm.com Convert the read, write, flush and discard implementations from aio-based ones to coroutine based ones. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 07/93] gluster: Implement .bdrv_co_write_zeroes for gluster

2014-01-24 Thread Kevin Wolf
From: Bharata B Rao bhar...@linux.vnet.ibm.com Support .bdrv_co_write_zeroes() from gluster driver by using GlusterFS API glfs_zerofill() that off-loads the writing of zeroes to GlusterFS server. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 03/93] qemu-iotests: Add _unsupported_imgopts for vmdk subformats

2014-01-24 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Some cases are not applicable for vmdk subformats those don't support certain features, e.g. backing file, and some others can't run on mult-file image, e.g. monolithicFlat. This adds declaration in test cases to skip them automatically, so that iotests on vmdk can

[Qemu-devel] [PULL 05/93] block/iscsi: return -ENOMEM if an async call fails immediately

2014-01-24 Thread Kevin Wolf
From: Peter Lieven p...@kamp.de if an async libiscsi call fails directly it can only be due to an out of memory condition. All other errors are returned through the callback. Signed-off-by: Peter Lieven p...@kamp.de Reviewed-by: Ronnie Sahlberg ronniesahlb...@gmail.com Signed-off-by: Stefan

[Qemu-devel] [PULL 12/93] vmdk: Fix big flat extent IO

2014-01-24 Thread Kevin Wolf
From: Fam Zheng f...@redhat.com Local variable n as int64_t avoids overflow with large sector number calculation. See test case change for failure case. Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vmdk.c | 4 +--

[Qemu-devel] [PULL 09/93] sheepdog: fix clone operation by 'qemu-img create -b'

2014-01-24 Thread Kevin Wolf
From: Liu Yuan namei.u...@gmail.com We should pass base_inode-vdi_id to base_vdi_id of SheepdogVdiReq so that sheep can create a clone instead a fresh volume. This fixes following command: qemu-create -b sheepdog:base sheepdog:clone so users can boot sheepdog:clone as a normal volume. Cc:

[Qemu-devel] [PULL 11/93] docs: qcow2 compat=1.1 is now the default

2014-01-24 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Commit 9117b47717ad208b12786ce88eacb013f9b3dd1c (qcow2: Change default for new images to compat=1.1) changed the default qcow2 image format version but forgot to update qemu-doc.texi and qemu-img.texi. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PULL 10/93] qtest: Fix the bug about disable vnc causes make check fail

2014-01-24 Thread Kevin Wolf
From: Kewei Yu kewe...@gmail.com When we disable vnc from ./configure, QEMU can't use the vnc option. So qtest can't use the vnc -none , otherwise make check fails. If QEMU uses -display none, -vnc none is excrescent, So we just need to drop it. Signed-off-by: Kewei Yu kewe...@gmail.com

[Qemu-devel] [PULL 16/93] qemu-io: use readline.c

2014-01-24 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Use readline.c for command-line history. There was support for GNU Readline and BSD Editline but it was never compiled in. Since QEMU has its own readline.c, just use that when qemu-io runs with stdin attached to a terminal. Signed-off-by: Stefan

[Qemu-devel] [PULL 13/93] readline: decouple readline from the monitor

2014-01-24 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Make the readline.c functionality reusable. Instead of calling monitor_printf() and monitor_flush() directly, invoke function pointers provided by the user. This way readline.c does not know about Monitor and other users will be able to make use of

[Qemu-devel] [PULL 15/93] osdep: add qemu_set_tty_echo()

2014-01-24 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Using stdin with readline.c requires disabling echo and line buffering. Add a portable wrapper to set the terminal attributes under Linux and Windows. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PULL 14/93] readline: move readline to a generic location

2014-01-24 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@redhat.com Now that the monitor and readline are decoupled, readline.h no longer belongs in include/monitor/. Put the header into include/qemu/. Move the source file into util/ so it can be linked as part of libqemuutil.a. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PULL 23/93] blkdebug: Always call read_config()

2014-01-24 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PULL 26/93] block: Pass reference to bdrv_file_open()

2014-01-24 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com With that now being possible, bdrv_open() should try to extract a block device reference from the options and pass it to bdrv_file_open(). Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf

[Qemu-devel] [PULL 25/93] block: Allow reference for bdrv_file_open()

2014-01-24 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Allow specifying a reference to an existing block device (by name) for bdrv_file_open() instead of a filename and/or options. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PULL 27/93] block: Allow block devices without files

2014-01-24 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com blkdebug and blkverify will, in order to retain compatibility, not support the field file implicitly through bdrv_open(). In order to be able to use those drivers without giving a filename anyway, it is necessary to be able to have block devices without files

[Qemu-devel] [PULL 31/93] blockdev: Move file to legacy_opts

2014-01-24 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Specifying the image filename through the file option is a legacy option and should not be supported by blockdev-add (in that case, giving a string for file references an existing block device). Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf

[Qemu-devel] [PULL 18/93] blkdebug: Use errp for read_config()

2014-01-24 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Use an Error variable in the read_config() function. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- block/blkdebug.c | 10 ++ 1

[Qemu-devel] [PULL 38/93] tests: Add test for qdict_array_split()

2014-01-24 Thread Kevin Wolf
From: Max Reitz mre...@redhat.com Add a test case for qdict_array_split() in tests/check-qdict.c. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/check-qdict.c | 80

  1   2   >