[Qemu-devel] [RFC PATCH 1/2] qga: Introduce guest-get-os-version command with stubs

2014-12-15 Thread zhanghailiang
Signed-off-by: zhanghailiang --- qga/commands-posix.c | 7 +++ qga/commands-win32.c | 6 ++ qga/qapi-schema.json | 26 ++ 3 files changed, 39 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index f6f3e3c..b4d5c29 100644 --- a/qga/commands-

[Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows

2014-12-15 Thread zhanghailiang
Hi, This patch series add a new guest command 'guest-get-os-version'. It is now only available for windows guest. It will return guest's OS version name and type, like bellow: '{"return":{"name":"Microsoft Windows Server 2012 R2","type":64}}' Sometimes we need to know guest's OS version info. (A

[Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows

2014-12-15 Thread zhanghailiang
We can get guest's OS version info by using 'guest-get-os-version', The return value contains version name and type (32-bit or 64-bit). For example: {"return":{"name":"Microsoft Windows Server 2012 R2","type":64}} Signed-off-by: zhanghailiang --- qga/commands-win32.c | 123 ++

Re: [Qemu-devel] paaudio race condition on close

2014-12-15 Thread Gerd Hoffmann
On Mo, 2014-12-15 at 15:37 +, Peter Maydell wrote: > On 15 December 2014 at 09:23, Gerd Hoffmann wrote: > > >> > Does anybody know how this is supposed to work? Is the fix as > >> > simple as just moving the free_resources call below the fini? > > > > I suspect the code simply wasn't written

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread Amit Shah
On (Tue) 16 Dec 2014 [16:38:15], David Gibson wrote: > On Tue, Dec 16, 2014 at 10:08:49AM +0530, Amit Shah wrote: > > On (Tue) 16 Dec 2014 [15:33:54], David Gibson wrote: > > > On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > > > > Can you split this patch so the config change and the

Re: [Qemu-devel] [PATCH v6 1/3] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2014-12-15 Thread Shannon Zhao
On 2014/12/9 18:29, Eric Auger wrote: > This new C module will be used by ARM machine files to generate > platform bus node and their dynamic sysbus device tree nodes. > > Dynamic sysbus device node addition is done in a machine init > done notifier. arm_register_platform_bus_fdt_creator does the

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread David Gibson
On Tue, Dec 16, 2014 at 10:08:49AM +0530, Amit Shah wrote: > On (Tue) 16 Dec 2014 [15:33:54], David Gibson wrote: > > On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > > > On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > > > > On a bi-endian target, with a guest in the non-default

Re: [Qemu-devel] [PATCH v7 2/7] stm32f2xx_USART: Add the stm32f2xx USART Controller

2014-12-15 Thread Peter Crosthwaite
On Wed, Dec 10, 2014 at 12:46 AM, Alistair Francis wrote: > This patch adds the stm32f2xx USART controller > (UART also uses the same controller). > > Signed-off-by: Alistair Francis > --- > V6: > - Rename to STM32F2XX > - Fix up unimplemented printing > - Add a qemu_chr_accept() > V3: > - Up

Re: [Qemu-devel] [PATCH v6 3/3] hw/arm/virt: add dynamic sysbus device support

2014-12-15 Thread Shannon Zhao
On 2014/12/9 18:29, Eric Auger wrote: > Allows sysbus devices to be instantiated from command line by > using -device option. Machvirt creates a platform bus at init. > The dynamic sysbus devices are attached to this platform bus device. > > The platform bus device registers a machine init done no

Re: [Qemu-devel] [PATCH v7 1/7] stm32f2xx_timer: Add the stm32f2xx Timer

2014-12-15 Thread Peter Crosthwaite
On Wed, Dec 10, 2014 at 12:46 AM, Alistair Francis wrote: > This patch adds the stm32f2xx timers: TIM2, TIM3, TIM4 and TIM5 > to QEMU. > > Signed-off-by: Alistair Francis > --- > V6: > - Rename to STM32F2XX > - Change the timer calculations to use ns > - Update the value to timer_mod to ensure

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread Amit Shah
On (Tue) 16 Dec 2014 [15:33:54], David Gibson wrote: > On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > > On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > > > On a bi-endian target, with a guest in the non-default endian mode, > > > attempting to migrate twice in a row with a virt

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread David Gibson
On Tue, Dec 16, 2014 at 09:43:30AM +0530, Amit Shah wrote: > On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > > On a bi-endian target, with a guest in the non-default endian mode, > > attempting to migrate twice in a row with a virtio-serial device wil > > cause a qemu SEGV on the second outg

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread Amit Shah
On (Fri) 12 Dec 2014 [16:26:35], David Gibson wrote: > On a bi-endian target, with a guest in the non-default endian mode, > attempting to migrate twice in a row with a virtio-serial device wil > cause a qemu SEGV on the second outgoing migration. > > The problem is that virtio_serial_save_device(

[Qemu-devel] [PATCH v14 3/3] sPAPR: Implement sPAPRPHBClass::eeh_handler

2014-12-15 Thread Gavin Shan
The patch implements sPAPRPHBClass::eeh_handler so that the EEH RTAS requests can be routed to VFIO for further handling. Signed-off-by: Gavin Shan --- hw/misc/vfio.c | 1 + hw/ppc/spapr_pci_vfio.c | 56 + 2 files changed, 57 insertions(+

[Qemu-devel] [PATCH v14 2/3] sPAPR: Implement EEH RTAS calls

2014-12-15 Thread Gavin Shan
The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callback sPAPRPHBClass::eeh_handler, which is going to be used this way: * RTAS calls are received in spapr_pci.c, sanity check is

[Qemu-devel] [PATCH v14 0/3] EEH Support for VFIO Devices

2014-12-15 Thread Gavin Shan
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform. It requires corresponding host kernel support, which was merged during 3.17 merge window. This patchset has been rebased to Alex Graf's QEMU repository: git://github.com/agraf/qemu.git (branch: ppc-next) The impleme

[Qemu-devel] [PATCH v14 1/3] spapr_pci: Make find_phb()/find_dev() public

2014-12-15 Thread Gavin Shan
From: Alexey Kardashevskiy This makes find_phb()/find_dev() public and changed its names to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to be used from other parts of QEMU such as VFIO DDW (dynamic DMA window) or VFIO PCI error injection or VFIO EEH handling - in all these cases t

Re: [Qemu-devel] [PATCH 1/2] QEMUSizedBuffer: only free qsb that qemu_bufopen allocated

2014-12-15 Thread Hongyang Yang
Ping! 在 12/12/2014 05:53 PM, Yang Hongyang 写道: Only free qsb that qemu_bufopen allocated, and also allow qemu_bufopen accept qsb as input for write operation. It will make the API more logical: 1.If you create the QEMUSizedBuffer yourself, you need to free it by using qsb_free() but not depen

Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file

2014-12-15 Thread David Gibson
On Tue, Dec 16, 2014 at 01:59:01AM +0100, Alexander Graf wrote: > > > On 16.12.14 01:43, David Gibson wrote: > > At the moment the RTAS (firmware/hypervisor) time of day functions are > > implemented in spapr_rtas.c along with a bunch of other things. Since > > we're going to be expanding these

Re: [Qemu-devel] [PATCH 4/5] pseries: Export /machine "rtc-time" property

2014-12-15 Thread David Gibson
On Tue, Dec 16, 2014 at 02:04:49AM +0100, Alexander Graf wrote: > > > On 16.12.14 01:43, David Gibson wrote: > > On x86, the guest's RTC can be read with QMP via the "rtc-time" property > > on the /machine object. This is due to an explicit QOM alias being set up > > by the mc146818rtc driver, a

Re: [Qemu-devel] [PATCH 2/5] pseries: Add spapr_rtc_read() helper function

2014-12-15 Thread David Gibson
On Tue, Dec 16, 2014 at 02:01:29AM +0100, Alexander Graf wrote: > > > On 16.12.14 01:43, David Gibson wrote: > > The virtual RTC time is used in two places in the pseries machine. First > > is in the RTAS get-time-of-day function which returns the RTC time to the > > guest. Second is in the spa

Re: [Qemu-devel] [PATCH v2 0/6] aio: Support epoll by introducing qemu_poll abstraction

2014-12-15 Thread Fam Zheng
On Thu, 12/04 11:43, Fam Zheng wrote: > v2: Emulate nanoseconds precison of timeout with ppoll and timerfd. > Their performance is on par with each other, but both much better than > qemu.git: > > syscall high # of fd low # of fd > -

[Qemu-devel] request for wiki account, please

2014-12-15 Thread Hongyang Yang
-- Thanks, Yang.

Re: [Qemu-devel] [RFC v2 1/2] arm: Add the cortex-a9 CPU to the a9mpcore device

2014-12-15 Thread Alistair Francis
It's been a while, but ping^3 As it's only an RFC I haven't bothered re-basing it, I can if anyone wants it rebased. Thanks, Alistair On Fri, Jun 27, 2014 at 12:58 AM, Peter Maydell wrote: > On 26 June 2014 06:09, Alistair Francis wrote: >> Ping^2 > > Hi. This is still on my must-review queue

[Qemu-devel] [PATCH] qapi: Fix document for BlockStats.node-name

2014-12-15 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 6e8db15..2d8bd25 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -423,7 +423,7 @@ # @device: #optional If the st

Re: [Qemu-devel] [PATCHv2] Fix virtio-serial migration on bi-endian targets

2014-12-15 Thread David Gibson
On Mon, Dec 15, 2014 at 03:59:56PM +0100, Alexander Graf wrote: > > > On 12.12.14 06:26, David Gibson wrote: > > On a bi-endian target, with a guest in the non-default endian mode, > > attempting to migrate twice in a row with a virtio-serial device wil > > cause a qemu SEGV on the second outgoin

Re: [Qemu-devel] [PATCH 4/5] pseries: Export /machine "rtc-time" property

2014-12-15 Thread Alexander Graf
On 16.12.14 01:43, David Gibson wrote: > On x86, the guest's RTC can be read with QMP via the "rtc-time" property > on the /machine object. This is due to an explicit QOM alias being set up > by the mc146818rtc driver, and doesn't work on other targets. > > This extends the pseries RTAS RTC to

Re: [Qemu-devel] [PATCH 2/5] pseries: Add spapr_rtc_read() helper function

2014-12-15 Thread Alexander Graf
On 16.12.14 01:43, David Gibson wrote: > The virtual RTC time is used in two places in the pseries machine. First > is in the RTAS get-time-of-day function which returns the RTC time to the > guest. Second is in the spapr events code which is used to timestamp > event messages from the hypervis

Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file

2014-12-15 Thread Alexander Graf
On 16.12.14 01:43, David Gibson wrote: > At the moment the RTAS (firmware/hypervisor) time of day functions are > implemented in spapr_rtas.c along with a bunch of other things. Since > we're going to be expanding these a bit, move the RTAS RTC related code > out into new file spapr_rtc.c. Also

Re: [Qemu-devel] [PATCH v2] block: fix spoiling all dirty bitmaps by mirror and migration

2014-12-15 Thread Fam Zheng
On Thu, 11/27 12:40, Vladimir Sementsov-Ogievskiy wrote: > Mirror and migration use dirty bitmaps for their purposes, and since > commit [block: per caller dirty bitmap] they use their own bitmaps, not > the global one. But they use old functions bdrv_set_dirty and > bdrv_reset_dirty, which change

Re: [Qemu-devel] [PATCH v13 2/3] sPAPR: Implement EEH RTAS calls

2014-12-15 Thread Alexander Graf
On 16.12.14 01:31, Gavin Shan wrote: > On Tue, Dec 16, 2014 at 01:08:52AM +0100, Alexander Graf wrote: >> >> >> On 16.12.14 00:29, Gavin Shan wrote: >>> On Tue, Dec 16, 2014 at 12:13:03AM +0100, Alexander Graf wrote: On 16.12.14 00:08, Gavin Shan wrote: > On Mon, Dec 15, 2014 at 03:52:17

[Qemu-devel] [PATCH 3/5] pseries: Add more parameter validation in RTAS time of day functions

2014-12-15 Thread David Gibson
Currently, the RTAS time of day functions only partially validate the number of parameters they receive and return. Because of how the parameters are used, this is unlikely to lead to a crash, but it's messy. This patch adds the missing checks. Signed-off-by: David Gibson --- hw/ppc/spapr_rtc.

[Qemu-devel] [PATCH 0/5] pseries: Fix and extend PAPR RTC implementation

2014-12-15 Thread David Gibson
At the moment, the PAPR RTC implementation (actually a paravirt firmware interface, rather than a normal device) works directly off host time, and so doesn't respect the options such as clock=vm which can be specified in the -rtc command line option. This patch addresses this also making some othe

[Qemu-devel] [PATCH 4/5] pseries: Export /machine "rtc-time" property

2014-12-15 Thread David Gibson
On x86, the guest's RTC can be read with QMP via the "rtc-time" property on the /machine object. This is due to an explicit QOM alias being set up by the mc146818rtc driver, and doesn't work on other targets. This extends the pseries RTAS RTC to populate that property, for improved management com

[Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file

2014-12-15 Thread David Gibson
At the moment the RTAS (firmware/hypervisor) time of day functions are implemented in spapr_rtas.c along with a bunch of other things. Since we're going to be expanding these a bit, move the RTAS RTC related code out into new file spapr_rtc.c. Also add its own initialization function, spapr_rtc_i

[Qemu-devel] [PATCH 5/5] pseries: Make RTAS time of day functions respect -rtc options

2014-12-15 Thread David Gibson
In the 'pseries' machine the real time clock is provided by a paravirtualized firmware interface rather than a device per se; the RTAS get-time-of-day and set-time-of-day calls. Out current implementations of those work directly off host time (with an offset), not respecting options such as clock=

[Qemu-devel] [PATCH 2/5] pseries: Add spapr_rtc_read() helper function

2014-12-15 Thread David Gibson
The virtual RTC time is used in two places in the pseries machine. First is in the RTAS get-time-of-day function which returns the RTC time to the guest. Second is in the spapr events code which is used to timestamp event messages from the hypervisor to the guest. Currently both call qemu_get_ti

Re: [Qemu-devel] [PATCH v13 2/3] sPAPR: Implement EEH RTAS calls

2014-12-15 Thread Gavin Shan
On Tue, Dec 16, 2014 at 01:08:52AM +0100, Alexander Graf wrote: > > >On 16.12.14 00:29, Gavin Shan wrote: >> On Tue, Dec 16, 2014 at 12:13:03AM +0100, Alexander Graf wrote: >>> On 16.12.14 00:08, Gavin Shan wrote: On Mon, Dec 15, 2014 at 03:52:17PM +0100, Alexander Graf wrote: > On 15.12.1

Re: [Qemu-devel] [PATCH v13 2/3] sPAPR: Implement EEH RTAS calls

2014-12-15 Thread Alexander Graf
On 16.12.14 00:29, Gavin Shan wrote: > On Tue, Dec 16, 2014 at 12:13:03AM +0100, Alexander Graf wrote: >> On 16.12.14 00:08, Gavin Shan wrote: >>> On Mon, Dec 15, 2014 at 03:52:17PM +0100, Alexander Graf wrote: On 15.12.14 01:15, Gavin Shan wrote: > The emulation for EEH RTAS requests fr

Re: [Qemu-devel] Bug in s390 instruction emulation

2014-12-15 Thread Torbjörn Granlund
Paolo Bonzini writes: Something like this? diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c index 5a55de8..4de3fc2 100644 --- a/target-s390x/mem_helper.c +++ b/target-s390x/mem_helper.c @@ -490,10 +490,18 @@ uint32_t HELPER(ex)(CPUS390XState *env, uint32_t cc,

Re: [Qemu-devel] [PATCH v13 2/3] sPAPR: Implement EEH RTAS calls

2014-12-15 Thread Gavin Shan
On Tue, Dec 16, 2014 at 12:13:03AM +0100, Alexander Graf wrote: >On 16.12.14 00:08, Gavin Shan wrote: >> On Mon, Dec 15, 2014 at 03:52:17PM +0100, Alexander Graf wrote: >>> On 15.12.14 01:15, Gavin Shan wrote: The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and th

[Qemu-devel] [PATCH v4 15/15] target-arm: add cpu feature EL3 to CPUs with Security Extensions

2014-12-15 Thread Greg Bellows
From: Fabian Aggeler Set ARM_FEATURE_EL3 feature for CPUs that implement Security Extensions. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- target-arm/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target-arm/cpu.c b/target-arm/cpu.c

[Qemu-devel] [PATCH v4 11/15] target-arm: Enable CPU has_el3 prop during VE init

2014-12-15 Thread Greg Bellows
Adds setting of the CPU has_el3 property based on the vexpress machine secure state property during initialization. This enables/disables EL3 state during start-up. Changes include adding an additional secure state boolean during vexpress CPU initialization. Also enables the ARM secure boot by d

[Qemu-devel] [PATCH v4 12/15] target-arm: Set CPU has_el3 prop during virt init

2014-12-15 Thread Greg Bellows
Adds setting of the CPU has_el3 property based on the virt machine secure state property during initialization. This enables/disables EL3 state during start-up. Changes include adding an additional secure state boolean during virt CPU initialization. Also disables the ARM secure boot by default.

[Qemu-devel] [PATCH v4 14/15] target-arm: Disable EL3 on unsupported machines

2014-12-15 Thread Greg Bellows
Disables the CPU ARM_FEATURE_EL3 featuere on machine models that can be configured to use Cortex-A9, Cortex-A15, and ARM1176 but don't officially support EL3. This preserves backwards compatibility. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw/arm/exynos4210.c | 11 +

Re: [Qemu-devel] [PATCH v13 2/3] sPAPR: Implement EEH RTAS calls

2014-12-15 Thread Alexander Graf
On 16.12.14 00:08, Gavin Shan wrote: > On Mon, Dec 15, 2014 at 03:52:17PM +0100, Alexander Graf wrote: >> On 15.12.14 01:15, Gavin Shan wrote: >>> The emulation for EEH RTAS requests from guest isn't covered >>> by QEMU yet and the patch implements them. >>> >>> The patch defines constants used b

[Qemu-devel] [PATCH v4 09/15] target-arm: Add ARMCPU secure property

2014-12-15 Thread Greg Bellows
Added a "has_el3" state property to the ARMCPU descriptor. This property indicates whether the ARMCPU has security extensions enabled (EL3) or not. By default it is disabled at this time. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v1 -> v2 - Added set of has_el3 to true when E

[Qemu-devel] [PATCH v4 07/15] target-arm: Add virt machine secure property

2014-12-15 Thread Greg Bellows
Add "secure" virt machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, virt machines boot into NS/SVC. When using the QEMU -bios command line argument, virt machines boot into S/SVC. The secure state

[Qemu-devel] [PATCH v4 10/15] target-arm: Add arm_boot_info secure_boot control

2014-12-15 Thread Greg Bellows
Adds the secure_boot boolean field to the arm_boot_info descriptor. This fields is used to indicate whether Linux should boot into secure or non-secure state if the ARM EL3 feature is enabled. The default is to leave the CPU in an unaltered reset state. On EL3 enabled systems, the reset state is

[Qemu-devel] [PATCH v4 13/15] target-arm: Breakout integratorcp and versatilepb cpu init

2014-12-15 Thread Greg Bellows
This commit changes the integratorcp and versatilepb CPU initialization from using the generic ARM cpu_arm_init function to doing it inline. This is necessary in order to allow CPU configuration changes to occur between CPU instance initialization and realization. Specifically, this change is in

[Qemu-devel] [PATCH v4 06/15] target-arm: Add virt class and machine types

2014-12-15 Thread Greg Bellows
Switch virt qemu machine support to use the newer object type, class, and instance model. Added virt TypeInfo with static registration along with virt specific class and machine structs. Also added virt class initialization method. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw

[Qemu-devel] [PATCH v4 08/15] target-arm: Add feature unset function

2014-12-15 Thread Greg Bellows
Add an unset_feature() function to compliment the set_feature() function. This will be used to disable functions after they have been enabled during initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- target-arm/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --gi

[Qemu-devel] [PATCH v4 04/15] target-arm: Add vexpress machine secure property

2014-12-15 Thread Greg Bellows
Add "secure" Vexpress machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, Vexpress machines boot into NS/SVC. When using the QEMU -bios command line argument, Vexpress machines boot into S/SVC. The

[Qemu-devel] [PATCH v4 02/15] target-arm: Add vexpress a9 & a15 machine objects

2014-12-15 Thread Greg Bellows
Add Vexpress machine objects for the the Cortex A9 & A15 variants. The older style QEMUMachine types were replaced with dedicated TypeInfo objects. The new objects include dedicated class init functions that currently ustilze dedicated machine init methods. The previous qemu_register_machine call

[Qemu-devel] [PATCH v4 05/15] target-arm: Change vexpress daughterboard init arg

2014-12-15 Thread Greg Bellows
Change the Vexpress daughterboard initialization method to take a vexpress machine state pointer instead of the daughterboard struct pointer. The machine state now contains the daughterboard pointer. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw/arm/vexpress.c | 10 +-

[Qemu-devel] [PATCH v4 03/15] target-arm: Switch to common vexpress machine init

2014-12-15 Thread Greg Bellows
Switched the Vexpress machine initialization to use the common function with the machine pointer to board info. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw/arm/vexpress.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/hw/arm/vex

[Qemu-devel] [PATCH v4 00/15] target-arm: Add CPU security extension enablement

2014-12-15 Thread Greg Bellows
This patchset adds functionality for enabling the ARM CPU security extensions. At this time, the only machines supported are Versatile Express and the QEMU ARM virtual machines both with Cortex A9 & A15. The patchset establishes the default security state along with adding overriding controls of t

[Qemu-devel] [PATCH v4 01/15] target-arm: Add vexpress class and machine types

2014-12-15 Thread Greg Bellows
Adds base Vexpress class and machine objects and infrastructure. This is in preparation for switching to the full QEMU object model. The base vexpress infrastructure is intended to handle common vexpress details. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v1 -> v2 - Made the

Re: [Qemu-devel] [PATCH v13 2/3] sPAPR: Implement EEH RTAS calls

2014-12-15 Thread Gavin Shan
On Mon, Dec 15, 2014 at 03:52:17PM +0100, Alexander Graf wrote: >On 15.12.14 01:15, Gavin Shan wrote: >> The emulation for EEH RTAS requests from guest isn't covered >> by QEMU yet and the patch implements them. >> >> The patch defines constants used by EEH RTAS calls and adds >> callback sPAPRPHB

[Qemu-devel] Server 2012R2 guest poor performance

2014-12-15 Thread Brian Rak
I'm trying to track down some CPU usage issues we're having with some virtual machines. Basically, when we run our application under KVM, we see about 2x the CPU usage that we would see if we were running it on bare metal. kvm_stat shows me the following: efer_reload 0

Re: [Qemu-devel] [PATCH v2 14/15] target-arm: Disable EL3 on unsupported machines

2014-12-15 Thread Peter Maydell
On 15 December 2014 at 21:45, Greg Bellows wrote: > Should the has_el3 property errors on these machines also be silent (will > break -cpu host). All the ones in this patch use the if (object_property_find(OBJECT(cpu), "has_el3", NULL)) { object_property_set_bool(OBJECT(cpu), false,

Re: [Qemu-devel] [PATCH v2 14/15] target-arm: Disable EL3 on unsupported machines

2014-12-15 Thread Greg Bellows
Should the has_el3 property errors on these machines also be silent (will break -cpu host). Greg On 15 December 2014 at 11:09, Peter Maydell wrote: > > On 11 December 2014 at 23:29, Greg Bellows > wrote: > > Disables the CPU ARM_FEATURE_EL3 featuere on machine models that can be > > configured

Re: [Qemu-devel] [PATCH v2 0/7] coroutine: optimizations

2014-12-15 Thread Paolo Bonzini
On 11/12/2014 14:55, Peter Lieven wrote: > On 02.12.2014 12:05, Paolo Bonzini wrote: >> As discussed in the other thread, this brings speedups from >> dropping the coroutine mutex (which serializes multiple iothreads, >> too) and using ELF thread-local storage. >> >> The speedup in perf/cost is a

Re: [Qemu-devel] [PATCH 16/16] ipmi: Add a thread to better simulate a BMC

2014-12-15 Thread Corey Minyard
On 12/15/2014 03:11 PM, Paolo Bonzini wrote: > > On 12/12/2014 20:15, miny...@acm.org wrote: >> +if (s->threaded_bmc) { >> +qemu_mutex_init(&s->lock); >> +qemu_cond_init(&s->waker); >> +qemu_thread_create(&s->thread, "ipmi-bmc", ipmi_thread, s, 0); >> +} >> + >> +

Re: [Qemu-devel] [PATCH 3/3] vl.c: add HMP help to machine

2014-12-15 Thread Marcel Apfelbaum
On 12/15/2014 05:20 PM, Daniel P. Berrange wrote: On Mon, Dec 15, 2014 at 04:16:02PM +0100, Alexander Graf wrote: On 10.12.14 14:19, Marcel Apfelbaum wrote: The help is based on the actual machine properties exposing only the relevant options. Signed-off-by: Marcel Apfelbaum Can libvirt ma

Re: [Qemu-devel] [PATCH 00/16] Add an IPMI device to qemu

2014-12-15 Thread Paolo Bonzini
On 12/12/2014 20:15, miny...@acm.org wrote: > This set of patches adds an IPMI device to qemu. This is good for > systems that require an IPMI device to work correctly, for simulating > scenarios that require IPMI and testing software that uses IPMI, and > of course, for the Linux IPMI driver ma

Re: [Qemu-devel] [PATCH 16/16] ipmi: Add a thread to better simulate a BMC

2014-12-15 Thread Paolo Bonzini
On 12/12/2014 20:15, miny...@acm.org wrote: > +if (s->threaded_bmc) { > +qemu_mutex_init(&s->lock); > +qemu_cond_init(&s->waker); > +qemu_thread_create(&s->thread, "ipmi-bmc", ipmi_thread, s, 0); > +} > + > +if (s->threaded_bmc) { > +qemu_mutex_init(&s-

Re: [Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2014-12-15 Thread Serge Hallyn
For the record, the workaround is deleting old snapshots in shutdown mode as per comment #14. Upstream has moved toward external snapshots as the way forward, so while I don't argue that this is a bug, it seems unlikely to receive a fix from upstream. -- You received this bug notification becaus

[Qemu-devel] [Bug 1402802] Re: target-tricore/translate.c:3812: possible bad expression ?

2014-12-15 Thread Bastian Koppelmann
EMU: Confirmed Bug description: From a run of cppcheck, a static analysis checker, over the source code of qemu trunk, dated 20141215, is the new error: [qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f) == 0x6f' is always false. Source code is

[Qemu-devel] [PATCH] target-tricore: Fix mask handling JNZ.T being 7 bit long

2014-12-15 Thread Bastian Koppelmann
The mask is actually 7 bit long, instead of 6, so the expression checking for JNZ.T is always false. Let's make the mask 1 bit wider. Signed-off-by: Bastian Koppelmann --- target-tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-tricore/translate.

[Qemu-devel] [Bug 1402802] Re: target-tricore/translate.c:3812: possible bad expression ?

2014-12-15 Thread Bastian Koppelmann
QEMU: Confirmed Bug description: From a run of cppcheck, a static analysis checker, over the source code of qemu trunk, dated 20141215, is the new error: [qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f) == 0x6f' is always false. Source cod

[Qemu-devel] [Bug 1292234] Re: qcow2 image corruption in trusty (qemu 1.7 and 2.0 candidate)

2014-12-15 Thread Chris J Arges
** Changed in: qemu (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1292234 Title: qcow2 image corruption in trusty (qemu 1.7 and 2.0 candidate) Stat

Re: [Qemu-devel] [PATCH v3 04/15] target-arm: Add vexpress machine secure property

2014-12-15 Thread Greg Bellows
On 15 December 2014 at 13:43, Peter Maydell wrote: > > On 15 December 2014 at 18:51, Greg Bellows > wrote: > > Add "secure" Vexpress machine specific property to allow override of the > > default secure state configuration. By default, when using the QEMU > > -kernel command line argument, Vexpr

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2014-12-15 Thread Mario
@michael, so you do that once, after some time the machine keeps growing, and growing and growing... and you have to redo that every so often... I have a machine that should be taking up 30 gb yet is taking 600+ GB with 4 snapshots... but yeah... I'll just plug in another 1tb hard drive so that i

Re: [Qemu-devel] [PATCH v3 12/15] target-arm: Set CPU has_el3 prop during virt init

2014-12-15 Thread Peter Maydell
On 15 December 2014 at 18:51, Greg Bellows wrote: > -object_property_set_description(obj, "secure", > - "Set on/off to enable/disable secure state", > - NULL); > +object_property_set_description(obj, "secure", SECURE_PROP_DESC, NULL); Same r

Re: [Qemu-devel] [PATCH v3 11/15] target-arm: Enable CPU has_el3 prop during VE init

2014-12-15 Thread Peter Maydell
On 15 December 2014 at 18:51, Greg Bellows wrote: > Adds setting of the CPU has_el3 property based on the vexpress machine > secure state property during initialization. This enables/disables EL3 > state during start-up. Changes include adding an additional secure state > boolean during vexpress

Re: [Qemu-devel] [PATCH v3 10/15] target-arm: Add arm_boot_info secure_boot control

2014-12-15 Thread Peter Maydell
On 15 December 2014 at 18:51, Greg Bellows wrote: > Adds the secure_boot boolean field to the arm_boot_info descriptor. This > fields is used to indicate whether Linux should boot into secure or non-secure > state if the ARM EL3 feature is enabled. The default is to leave the CPU in > an > unal

Re: [Qemu-devel] [PATCH v3 09/15] target-arm: Add ARMCPU secure property

2014-12-15 Thread Peter Maydell
On 15 December 2014 at 18:51, Greg Bellows wrote: > Added a "has_el3" state property to the ARMCPU descriptor. This property > indicates whether the ARMCPU has security extensions enabled (EL3) or not. > By default it is disabled at this time. > > Signed-off-by: Greg Bellows Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v3 07/15] target-arm: Add virt machine secure property

2014-12-15 Thread Peter Maydell
On 15 December 2014 at 18:51, Greg Bellows wrote: > Add "secure" virt machine specific property to allow override of the > default secure state configuration. By default, when using the QEMU > -kernel command line argument, virt machines boot into NS/SVC. When using > the QEMU -bios command line

Re: [Qemu-devel] [PATCH v3 04/15] target-arm: Add vexpress machine secure property

2014-12-15 Thread Peter Maydell
On 15 December 2014 at 18:51, Greg Bellows wrote: > Add "secure" Vexpress machine specific property to allow override of the > default secure state configuration. By default, when using the QEMU > -kernel command line argument, Vexpress machines boot into NS/SVC. When using > the QEMU -bios comm

[Qemu-devel] [Bug 1402802] [NEW] target-tricore/translate.c:3812: possible bad expression ?

2014-12-15 Thread dcb
Public bug reported: >From a run of cppcheck, a static analysis checker, over the source code of qemu trunk, dated 20141215, is the new error: [qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f) == 0x6f' is always false. Source code is if (unl

Re: [Qemu-devel] [PATCH v2] block: fix spoiling all dirty bitmaps by mirror and migration

2014-12-15 Thread John Snow
On 11/27/2014 04:40 AM, Vladimir Sementsov-Ogievskiy wrote: Mirror and migration use dirty bitmaps for their purposes, and since commit [block: per caller dirty bitmap] they use their own bitmaps, not the global one. But they use old functions bdrv_set_dirty and bdrv_reset_dirty, which change a

[Qemu-devel] [PATCH v3 15/15] target-arm: add cpu feature EL3 to CPUs with Security Extensions

2014-12-15 Thread Greg Bellows
From: Fabian Aggeler Set ARM_FEATURE_EL3 feature for CPUs that implement Security Extensions. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- target-arm/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target-arm/cpu.c b/target-arm/cpu.c

[Qemu-devel] [PATCH v3 06/15] target-arm: Add virt class and machine types

2014-12-15 Thread Greg Bellows
Switch virt qemu machine support to use the newer object type, class, and instance model. Added virt TypeInfo with static registration along with virt specific class and machine structs. Also added virt class initialization method. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw

[Qemu-devel] [PATCH v3 14/15] target-arm: Disable EL3 on unsupported machines

2014-12-15 Thread Greg Bellows
Disables the CPU ARM_FEATURE_EL3 featuere on machine models that can be configured to use Cortex-A9, Cortex-A15, and ARM1176 but don't officially support EL3. This preserves backwards compatibility. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw/arm/exynos4210.c | 11 +

[Qemu-devel] [PATCH v3 10/15] target-arm: Add arm_boot_info secure_boot control

2014-12-15 Thread Greg Bellows
Adds the secure_boot boolean field to the arm_boot_info descriptor. This fields is used to indicate whether Linux should boot into secure or non-secure state if the ARM EL3 feature is enabled. The default is to leave the CPU in an unaltered reset state. On EL3 enabled systems, the reset state is

[Qemu-devel] [PATCH v3 13/15] target-arm: Breakout integratorcp and versatilepb cpu init

2014-12-15 Thread Greg Bellows
This commit changes the integratorcp and versatilepb CPU initialization from using the generic ARM cpu_arm_init function to doing it inline. This is necessary in order to allow CPU configuration changes to occur between CPU instance initialization and realization. Specifically, this change is in

[Qemu-devel] [PATCH v3 04/15] target-arm: Add vexpress machine secure property

2014-12-15 Thread Greg Bellows
Add "secure" Vexpress machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, Vexpress machines boot into NS/SVC. When using the QEMU -bios command line argument, Vexpress machines boot into S/SVC. The

[Qemu-devel] [PATCH v3 12/15] target-arm: Set CPU has_el3 prop during virt init

2014-12-15 Thread Greg Bellows
Adds setting of the CPU has_el3 property based on the virt machine secure state property during initialization. This enables/disables EL3 state during start-up. Changes include adding an additional secure state boolean during virt CPU initialization. Also disables the ARM secure boot by default.

[Qemu-devel] [PATCH v3 09/15] target-arm: Add ARMCPU secure property

2014-12-15 Thread Greg Bellows
Added a "has_el3" state property to the ARMCPU descriptor. This property indicates whether the ARMCPU has security extensions enabled (EL3) or not. By default it is disabled at this time. Signed-off-by: Greg Bellows --- v1 -> v2 - Added set of has_el3 to true when EL3 is enabled v2 -> v3 - Pr

[Qemu-devel] [PATCH v3 11/15] target-arm: Enable CPU has_el3 prop during VE init

2014-12-15 Thread Greg Bellows
Adds setting of the CPU has_el3 property based on the vexpress machine secure state property during initialization. This enables/disables EL3 state during start-up. Changes include adding an additional secure state boolean during vexpress CPU initialization. Also enables the ARM secure boot by d

[Qemu-devel] [PATCH v3 03/15] target-arm: Switch to common vexpress machine init

2014-12-15 Thread Greg Bellows
Switched the Vexpress machine initialization to use the common function with the machine pointer to board info. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw/arm/vexpress.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/hw/arm/vex

[Qemu-devel] [PATCH v3 08/15] target-arm: Add feature unset function

2014-12-15 Thread Greg Bellows
Add an unset_feature() function to compliment the set_feature() function. This will be used to disable functions after they have been enabled during initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- target-arm/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --gi

[Qemu-devel] [PATCH v3 07/15] target-arm: Add virt machine secure property

2014-12-15 Thread Greg Bellows
Add "secure" virt machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, virt machines boot into NS/SVC. When using the QEMU -bios command line argument, virt machines boot into S/SVC. The secure state

[Qemu-devel] [PATCH v3 01/15] target-arm: Add vexpress class and machine types

2014-12-15 Thread Greg Bellows
Adds base Vexpress class and machine objects and infrastructure. This is in preparation for switching to the full QEMU object model. The base vexpress infrastructure is intended to handle common vexpress details. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v1 -> v2 - Made the

[Qemu-devel] [PATCH v3 02/15] target-arm: Add vexpress a9 & a15 machine objects

2014-12-15 Thread Greg Bellows
Add Vexpress machine objects for the the Cortex A9 & A15 variants. The older style QEMUMachine types were replaced with dedicated TypeInfo objects. The new objects include dedicated class init functions that currently ustilze dedicated machine init methods. The previous qemu_register_machine call

[Qemu-devel] [PATCH v3 05/15] target-arm: Change vexpress daughterboard init arg

2014-12-15 Thread Greg Bellows
Change the Vexpress daughterboard initialization method to take a vexpress machine state pointer instead of the daughterboard struct pointer. The machine state now contains the daughterboard pointer. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- hw/arm/vexpress.c | 10 +-

[Qemu-devel] [PATCH v3 00/15] target-arm: Add CPU security extension enablement

2014-12-15 Thread Greg Bellows
This patchset adds functionality for enabling the ARM CPU security extensions. At this time, the only machines supported are Versatile Express and the QEMU ARM virtual machines both with Cortex A9 & A15. The patchset establishes the default security state along with adding overriding controls of t

[Qemu-devel] [PATCH v4 5/6] tests: test-x86-cpu: Add TCG feature bit initialization test

2014-12-15 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- tests/test-x86-cpu.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/test-x86-cpu.c b/tests/test-x86-cpu.c index b6e4382..fb3de05 100644 --- a/tests/test-x86-cpu.c +++ b/tests/test-x86-cpu.c @@ -54,6 +54,30 @@ static void tes

[Qemu-devel] [PATCH v4 3/6] tests: Add unit test for X86CPU code

2014-12-15 Thread Eduardo Habkost
The unit test includes target-i386/cpu.c instead of simply linking against cpu.o because the test code will use static variables/functions from cpu.c. Reasoning for each object file included in the test binary: * qom/cpu.o - for TYPE_CPU. Dependencies: * qom/qom-qobject.o * qom/qdev.o - for T

  1   2   3   4   >