[Qemu-devel] [PATCH v3 07/14] qapi: Move camel_to_upper(), c_enum_const() to closely related code

2015-05-05 Thread Eric Blake
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/scripts/qapi.py

[Qemu-devel] [PATCH v3 08/14] qapi: Make c_type() consistently convert qapi names

2015-05-05 Thread Eric Blake
Continuing the string of cleanups for supporting downstream names containing '.', this patch focuses on ensuring c_type() can handle a downstream name. This patch alone does not fix the places where generator output should be calling this function but was open-coding things instead, but it gets

[Qemu-devel] [PATCH v3 00/14] Fix qapi mangling of downstream names

2015-05-05 Thread Eric Blake
This series makes it possible to use downstream extensions (such as __com.redhat_xyz) and temporary names (such as x-foo) in every position possible in QAPI schemes, with added tests that the generated code still compiles. There's still some things we could do to the qapi generator, such as

[Qemu-devel] [PATCH v3 01/14] qapi: Fix C identifiers generated for names containing '.'

2015-05-05 Thread Eric Blake
From: Markus Armbruster arm...@redhat.com c_fun() maps '.' to '_', c_var() doesn't. Nothing prevents '.' in QAPI names that get passed to c_var(). Which QAPI names get passed to c_fun(), to c_var(), or to both is not obvious. Names of command parameters and struct type members get passed to

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-05 Thread Juan Quintela
Eduardo Habkost ehabk...@redhat.com wrote: On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. There were even some functions using object_dynamic_cast() calls

Re: [Qemu-devel] [PATCH 2/6] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty()

2015-05-05 Thread Alberto Garcia
On Fri 01 May 2015 04:31:52 PM CEST, Stefan Hajnoczi wrote: int qcow2_cache_put(BlockDriverState *bs, Qcow2Cache *c, void **table) { -int i; +int i = (*table - c-table_array) / c-table_size; -for (i = 0; i c-size; i++) { -if (table_addr(c, i) == *table) { -

Re: [Qemu-devel] [PATCH qemu v7 13/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2015-05-05 Thread David Gibson
On Sat, Apr 25, 2015 at 10:24:43PM +1000, Alexey Kardashevskiy wrote: This adds support for Dynamic DMA Windows (DDW) option defined by the SPAPR specification which allows to have additional DMA window(s) This implements DDW for emulated and VFIO devices. As all TCE root regions are mapped

Re: [Qemu-devel] [PATCH v3 5/6] spapr_pci: fix boot-time device tree fields for pci hotplug

2015-05-05 Thread David Gibson
On Tue, May 05, 2015 at 02:23:55PM +0530, Nikunj A Dadhania wrote: From: Michael Roth mdr...@linux.vnet.ibm.com We need to set the proper drc_index values in ibm,my-drc-index fields in order to allow a PCI device that was present at boot-time to be unplugged. Previously SLOF handles this,

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-05-05 Thread Paolo Bonzini
On 05/05/2015 13:48, Kevin Wolf wrote: It depends. In its basic form, bdrv_discard() just means I don't care about the data any more. Then clearing the dirty bitmap is correct. The content is only important if the caller used discard to write zeros because can_write_zeroes_with_unmap =

Re: [Qemu-devel] [RFC PATCH 13/15] spapr_pci: provide node start offset via spapr_populate_pci_dt()

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:22PM -0500, Michael Roth wrote: PHB hotplug re-uses PHB device tree generation code and passes it to a guest via RTAS. Doing this requires knowledge of where exactly in the device tree the node describing the PHB begins. Provide this via a new optional pointer

[Qemu-devel] [PATCH 3/5] gtk: add ui_info support

2015-05-05 Thread Gerd Hoffmann
Pass new display size to the guest after window resizes. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 51ea1b9..9163b43 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1478,6 +1478,19 @@

[Qemu-devel] [PATCH v3 12/14] qapi: Support downstream flat unions

2015-05-05 Thread Eric Blake
Enhance the testsuite to cover downstream flat unions, including the base type, discriminator name and type, and branch name and type. Update the generator to mangle the union names in the appropriate places. Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi-types.py

[Qemu-devel] [PATCH v3 03/14] qapi: Rename _generate_enum_string() to camel_to_upper()

2015-05-05 Thread Eric Blake
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 2431327..d9ed73a

[Qemu-devel] [PATCH 4/4] qemu-iotests: Add test case for mirror with unmap

2015-05-05 Thread Fam Zheng
This checks that the discard on mirror source that effectively zeroes data is also reflected by the data of target. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/131 | 59 ++ tests/qemu-iotests/131.out | 5

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-05-05 Thread Kevin Wolf
Am 05.05.2015 um 13:49 hat Paolo Bonzini geschrieben: On 05/05/2015 13:48, Kevin Wolf wrote: It depends. In its basic form, bdrv_discard() just means I don't care about the data any more. Then clearing the dirty bitmap is correct. The content is only important if the caller used

Re: [Qemu-devel] [PATCH v3 3/6] spapr_pci: encode class code including Prog IF register

2015-05-05 Thread David Gibson
On Tue, May 05, 2015 at 02:23:53PM +0530, Nikunj A Dadhania wrote: Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type. For example: USB controllers use the PROG IF for denoting: USB FullSpeed, HighSpeed or

Re: [Qemu-devel] [PATCH qemu v7 08/14] spapr_pci: Do complete reset of DMA config when resetting PHB

2015-05-05 Thread David Gibson
On Sat, Apr 25, 2015 at 10:24:38PM +1000, Alexey Kardashevskiy wrote: On a system reset, DMA configuration has to reset too. At the moment it clears the table content. This is enough for the single table case but with DDW, we will also have to disable all DMA windows except the default one.

Re: [Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to return accelerator id and model name

2015-05-05 Thread Eduardo Habkost
On Mon, Apr 27, 2015 at 04:53:17PM +0200, Michael Mueller wrote: The QMP command query-cpus now additionally displays a model name and the backing accelerator. Both are omitted if the model name is not initialized. request: { execute : query-cpus } answer: { { current: true,

Re: [Qemu-devel] [PATCH qemu v7 14/14] vfio: Enable DDW ioctls to VFIO IOMMU driver

2015-05-05 Thread David Gibson
On Sat, Apr 25, 2015 at 10:24:44PM +1000, Alexey Kardashevskiy wrote: This enables DDW RTAS-related ioctls in VFIO. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru This patch belongs before the last one (since the last one won't work without it). But otherwise, Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-05 Thread Eduardo Habkost
On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: The HMP command info cpus now displays the CPU model name and the backing accelerator if part of the CPUState. (qemu) info cpus * CPU #0: (halted) model=2827-ga2 accel=kvm thread_id=1679 Signed-off-by: Michael Mueller

Re: [Qemu-devel] [ARM]: Adding support for Cortex-M4

2015-05-05 Thread Liviu Ionescu
On 05 May 2015, at 15:52, aurelio remonda aurelioremo...@gmail.com wrote: Hi, i would like to to add support for cortex-m4 on qemu. ... For your information, I'm also planning to improve support for the Cortex-M family in my GNU ARM Eclipse QEMU fork. My first priority is fully supporting

[Qemu-devel] [PATCH 5/5] gtk: update mouse position in mouse_set()

2015-05-05 Thread Gerd Hoffmann
Without that the next mouse motion event uses the old position as base for relative move calculation, giving wrong results and making your mouse pointer jump around. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/gtk.c

Re: [Qemu-devel] [RFC PATCH 14/15] spapr_pci: add ibm, my-drc-index property for PHB hotplug

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:23PM -0500, Michael Roth wrote: This is needed to denote a boot-time PHB as being hot-pluggable. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: David Gibson da...@gibson.dropbear.id.au --- hw/ppc/spapr_pci.c | 10 ++ 1 file

Re: [Qemu-devel] [RFC PATCH 08/15] spapr: create DR connectors for PHBs and register reset hooks

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:17PM -0500, Michael Roth wrote: Since we route hotplugged PHBs to their DR connector using their PHB.index value, we align the number of DR connectors with the maximum index value: SPAPR_PCI_MAX_INDEX. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com As

Re: [Qemu-devel] [RFC PATCH 15/15] spapr: add hotplug hooks for PHB hotplug

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:24PM -0500, Michael Roth wrote: Hotplugging PHBs is a machine-level operation, but PHBs reside on the main system bus, so we register spapr machine as the handler for the main system bus. The entry point for plug/unplug is shared by all such machine-level hotplug

Re: [Qemu-devel] [RFC PATCH 07/15] spapr: enable PHB hotplug for pseries-2.4

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:16PM -0500, Michael Roth wrote: Introduce an sPAPRMachineClass sub-class of MachineClass to handle sPAPR-specific machine configuration properties. The 'dr_phb_enabled' field of that class can be set as part of machine-specific init code, and is then propagated

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-05 Thread Luiz Capitulino
On Tue, 05 May 2015 14:43:19 +0200 Juan Quintela quint...@redhat.com wrote: Eduardo Habkost ehabk...@redhat.com wrote: On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: The QJSON code used casts to (QJSON*) directly, instead of

Re: [Qemu-devel] [PATCH v8 20/40] qapi: Better error messages for duplicated expressions

2015-05-05 Thread Eric Blake
On 05/05/2015 03:11 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: The previous commit demonstrated that the generator overlooked duplicate expressions: - a complex type or command reusing a built-in type name - redeclaration of a type name, whether by the same or

[Qemu-devel] [PATCH 1/5] console: delayed ui_info guest notification

2015-05-05 Thread Gerd Hoffmann
So we don't flood the guest with display change notifications while the user resizes the window. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/console.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/ui/console.c b/ui/console.c index

[Qemu-devel] [PATCH 0/5] gtk: misc bits

2015-05-05 Thread Gerd Hoffmann
Hi, A few small gtk patches. The two console patches are dependencies for patch #3. Adding ui_info is preparation for virtio-gpu merge: virtio-gpu will be able to adapt the guest display to the user's window size, simliar to how spice is doing it with the spice guest agent. ui_info basically

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-05-05 Thread Paolo Bonzini
On 05/05/2015 13:49, Paolo Bonzini wrote: On 05/05/2015 13:48, Kevin Wolf wrote: It depends. In its basic form, bdrv_discard() just means I don't care about the data any more. Then clearing the dirty bitmap is correct. The content is only important if the caller used discard to write

[Qemu-devel] [PATCH 4/5] gtk: create gtk.h

2015-05-05 Thread Gerd Hoffmann
Move various gtk bits (includes, data structures) to a header file. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/gtk.h | 76 ui/gtk.c | 73 ++--- 2 files changed, 78

[Qemu-devel] [PATCH v3 09/14] qapi: Support downstream enums

2015-05-05 Thread Eric Blake
Enhance the testsuite to cover a downstream enum type and enum string. Update the generator to mangle the enum name in the appropriate places. The code for generating list visitors must be careful how it mangles names for enum lists differently than code for builtin type lists. Signed-off-by:

[Qemu-devel] [PATCH v3 06/14] qapi: Use c_enum_const() in generate_alternate_qtypes()

2015-05-05 Thread Eric Blake
From: Markus Armbruster arm...@redhat.com Missed in commit b0b5819. Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi-types.py | 6 ++ scripts/qapi.py | 11 --- 2 files changed, 2 insertions(+), 15 deletions(-)

[Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty

2015-05-05 Thread Fam Zheng
Using this function woule always be wrong because a dirty bitmap must have a specific owner that consumes the dirty bits and calls bdrv_reset_dirty_bitmap(). Remove the unused function to avoid future misuse. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 12

[Qemu-devel] [PATCH 3/4] qemu-iotests: Make block job methods common

2015-05-05 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/041| 66 ++- tests/qemu-iotests/iotests.py | 28 ++ 2 files changed, 43 insertions(+), 51 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041

[Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-05 Thread Fam Zheng
Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure that the guest sees the same data. Calling bdrv_reset_dirty also troubles mirror job because the

Re: [Qemu-devel] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-05 Thread Alberto Garcia
On Thu 30 Apr 2015 05:08:05 PM CEST, Eric Blake ebl...@redhat.com wrote: typedef struct Qcow2CachedTable { -void* table; int64_t offset; booldirty; int cache_hits; @@ -40,39 +39,34 @@ struct Qcow2Cache { struct Qcow2Cache* depends; int

Re: [Qemu-devel] [ARM]: Adding support for Cortex-M4

2015-05-05 Thread Peter Maydell
On 5 May 2015 at 13:52, aurelio remonda aurelioremo...@gmail.com wrote: Hi, i would like to to add support for cortex-m4 on qemu. Most features of the Cortex-M3 and M4 are the same with the significant difference that Cortex-M4 has DSP extensions and optional FPU. Even so, i really need some

Re: [Qemu-devel] [RFC PATCH 09/15] spapr: populate PHB DRC entries for root DT node

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:18PM -0500, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com This add entries to the root OF node to advertise our PHBs as being DR-capable in accordance with PAPR specification. Signed-off-by: Nathan Fontenot nf...@linux.vnet.ibm.com

Re: [Qemu-devel] [RFC PATCH 10/15] spapr_events: add support for phb hotplug events

2015-05-05 Thread David Gibson
On Wed, Apr 29, 2015 at 02:20:19PM -0500, Michael Roth wrote: Extend the existing EPOW event format we use for PCI devices to emit PHB plug/unplug events. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Reviewed-by: David Gibson da...@gibson.dropbear.id.au -- David Gibson

Re: [Qemu-devel] [PATCH v4 0/4] scripts: qmp-shell: add transaction support

2015-05-05 Thread Luiz Capitulino
On Mon, 04 May 2015 15:24:02 -0400 John Snow js...@redhat.com wrote: Ping (I should've CC'd Luiz to begin with ...) Eric's given this series the once over and Kashyap has tested it, so it should in theory be good to go. I lost track of it. Is v4 a new posting? On 04/29/2015 03:14 PM,

Re: [Qemu-devel] [PATCH v5 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-05 Thread Eric Blake
On 04/30/2015 12:20 PM, Don Slutz wrote: This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz dsl...@verizon.com --- +++

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-05-05 Thread Paolo Bonzini
On 05/05/2015 15:03, Kevin Wolf wrote: Yes, the SCSI command WRITE SAME with UNMAP = 1 (not coincidentially :)) calls discard too. Who knows what the guest used it for... However, write zeroes doesn't go through bdrv_co_discard, does it? Initially I expected that it does, but when I

Re: [Qemu-devel] [PATCH qemu v7 06/14] spapr_iommu: Introduce enabled state for TCE table

2015-05-05 Thread David Gibson
On Sat, Apr 25, 2015 at 10:24:36PM +1000, Alexey Kardashevskiy wrote: Currently TCE tables are created once at start and their size never changes. We are going to change that by introducing a Dynamic DMA windows support where DMA configuration may change during the guest execution. This

[Qemu-devel] [PATCH v3 11/14] qapi: Support downstream simple unions

2015-05-05 Thread Eric Blake
Enhance the testsuite to cover downstream simple unions, including when a union branch is a downstream name. Update the generator to mangle the union names in the appropriate places. Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi-types.py | 2 +-

[Qemu-devel] [PATCH v3 04/14] qapi: Rename generate_enum_full_value() to c_enum_const()

2015-05-05 Thread Eric Blake
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi-event.py | 5 ++--- scripts/qapi-types.py | 6 +++--- scripts/qapi-visit.py | 4 ++-- scripts/qapi.py | 6 +++--- 4 files changed, 10

[Qemu-devel] [PATCH v3 14/14] qapi: Support downstream events and commands

2015-05-05 Thread Eric Blake
Enhance the testsuite to cover downstream events and commands. Events worked without more tweaks, but commands needed a few final updates in the generator to mangle names in the appropriate places. In making those tweaks, it was easier to drop type_visitor() and inline its actions instead.

Re: [Qemu-devel] [PATCH v2 3/4] qapi: Correctly handle downstream extensions in more locations

2015-05-05 Thread Eric Blake
On 04/29/2015 05:29 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: Now that c_var() handles '.' in downstream extension names, fix the generator to support such names as additional types, enums, members within an enum, branches of a union or alternate, and in arrays.

[Qemu-devel] [PATCH v3 13/14] qapi: Support downstream alternates

2015-05-05 Thread Eric Blake
Enhance the testsuite to cover downstream alternates, including whether the branch name or type is downstream. Update the generator to mangle alternate names in the appropriate places. Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi-types.py | 7 ---

[Qemu-devel] [PATCH v3 10/14] qapi: Support downstream structs

2015-05-05 Thread Eric Blake
Enhance the testsuite to cover downstream structs, including struct members and base structs. Update the generator to mangle the struct names in the appropriate places. Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi-types.py | 4 ++-- scripts/qapi-visit.py

Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-05 Thread Paolo Bonzini
On 05/05/2015 14:46, Fam Zheng wrote: Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure that the guest sees the same data. Calling

Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-05-05 Thread Eduardo Habkost
On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote: The patch defines ids per accelerator and adds the accel_id and the model_name to the CPUState. The accel_id is initialized by common code, the model name needs to be initialized by target specific code. Signed-off-by: Michael

[Qemu-devel] [PATCH v3 05/14] qapi: Simplify c_enum_const()

2015-05-05 Thread Eric Blake
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Signed-off-by: Eric Blake ebl...@redhat.com --- scripts/qapi.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index b3628fd..9209fd5 100644 ---

[Qemu-devel] [PATCH v3 02/14] qapi: Rename identical c_fun()/c_var() into c_name()

2015-05-05 Thread Eric Blake
Now that the two functions are identical, we only need one of them, and we might as well give it a more descriptive name. Basically, the function serves as the translation from a QAPI name into a (portion of a) C identifier, without regards to whether it is a variable or function name.

[Qemu-devel] [PATCH 0/4] block: Mirror discarded sectors

2015-05-05 Thread Fam Zheng
This fixes the mirror assert failure reported by wangxiaolong: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg04458.html The direct cause is that hbitmap code couldn't handle unset of bits *after* iterator's current position. We could fix that, but the bdrv_reset_dirty() call is more

[Qemu-devel] [ARM]: Adding support for Cortex-M4

2015-05-05 Thread aurelio remonda
Hi, i would like to to add support for cortex-m4 on qemu. Most features of the Cortex-M3 and M4 are the same with the significant difference that Cortex-M4 has DSP extensions and optional FPU. Even so, i really need some pointers for this (im a newbie on qemu devel). I found out that qemu can

Re: [Qemu-devel] [PATCH qemu v7 07/14] spapr_iommu: Add root memory region

2015-05-05 Thread David Gibson
On Sat, Apr 25, 2015 at 10:24:37PM +1000, Alexey Kardashevskiy wrote: We are going to have multiple DMA windows at different offsets on a PCI bus. For the sake of migration, we will have as many TCE table objects pre-created as many windows supported. So we need a way to map windows

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-05 Thread Juan Quintela
Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 05 May 2015 14:43:19 +0200 Juan Quintela quint...@redhat.com wrote: Eduardo Habkost ehabk...@redhat.com wrote: On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: Am 25.04.2015 um 17:28 schrieb Eduardo Habkost: The QJSON

Re: [Qemu-devel] Fwd: qemu drive mirror assert fault

2015-05-05 Thread Kevin Wolf
Am 05.05.2015 um 15:07 hat Paolo Bonzini geschrieben: On 05/05/2015 15:03, Kevin Wolf wrote: Yes, the SCSI command WRITE SAME with UNMAP = 1 (not coincidentially :)) calls discard too. Who knows what the guest used it for... However, write zeroes doesn't go through

Re: [Qemu-devel] [PATCH v6 1/6] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-05-05 Thread Xu, Quan
-Original Message- From: Eric Blake [mailto:ebl...@redhat.com] Sent: Tuesday, May 05, 2015 10:29 PM To: Xu, Quan; stefano.stabell...@eu.citrix.com; stef...@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org; wei.l...@citrix.com; dgde...@tycho.nsa.gov; xen-de...@lists.xen.org Subject:

Re: [Qemu-devel] [PATCH v3 1/5] qtest: allow arbitrarily long sends

2015-05-05 Thread Eric Blake
On 05/05/2015 04:22 PM, John Snow wrote: qtest currently has a static buffer of size 1024 that if we overflow, ignores the additional data silently which leads to hangs or stream failures. Use glib's string facilities to allow arbitrarily long data, but split this off into a new function,

Re: [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard

2015-05-05 Thread Fam Zheng
On Tue, 05/05 15:06, Paolo Bonzini wrote: On 05/05/2015 14:46, Fam Zheng wrote: Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure

Re: [Qemu-devel] [PATCH v3 1/5] qtest: allow arbitrarily long sends

2015-05-05 Thread John Snow
On 05/05/2015 07:22 PM, Eric Blake wrote: On 05/05/2015 04:22 PM, John Snow wrote: qtest currently has a static buffer of size 1024 that if we overflow, ignores the additional data silently which leads to hangs or stream failures. Use glib's string facilities to allow arbitrarily long

Re: [Qemu-devel] [PATCH] s390x: Fix stoc direction

2015-05-05 Thread Richard Henderson
On 04/14/2015 06:45 PM, Alexander Graf wrote: The store conditional instruction wants to store when the condition is fulfilled, so we should branch out when it's not true. The code today branches out when the condition is true, clearly reversing the logic. Fix it up by negating the

[Qemu-devel] [Bug 1452062] [NEW] qemu-img will fail to convert images in 2.3.0

2015-05-05 Thread David Hill
Public bug reported: Hello guys, There seems to be a bug in qemu-img with 2.3.0 that wasn't there in 2.2.1 qemu convert will always fail converting. See the output below: Started by upstream project Create windows image build number 73 originally caused by: Started by user

[Qemu-devel] [PULL] tcg: optimise memory layout of TCGTemp

2015-05-05 Thread Richard Henderson
From: Emilio G. Cota c...@braap.org This brings down the size of the struct from 56 to 32 bytes on 64-bit, and to 20 bytes on 32-bit. This leads to memory savings: Before: $ find . -name 'tcg.o' | xargs size textdata bss dec hex filename 41131 29800 88 71019 1156b

[Qemu-devel] [PULL] Queued tcg patch

2015-05-05 Thread Richard Henderson
Only one tcg related patch since the 2.3 freeze. r~ The following changes since commit 874e9aeeeb74c5459639a93439a502d262847e68: Merge remote-tracking branch 'remotes/kraxel/tags/pull-sdl-20150505-1' into staging (2015-05-05 14:06:12 +0100) are available in the git repository at: git

Re: [Qemu-devel] [PATCH 3/4] qemu-iotests: Make block job methods common

2015-05-05 Thread Fam Zheng
On Tue, 05/05 18:17, John Snow wrote: On 05/05/2015 08:46 AM, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/041| 66 ++- tests/qemu-iotests/iotests.py | 28 ++ 2 files changed, 43

Re: [Qemu-devel] [PATCH] translate-all: remove redundant page_find from tb_invalidate_phys_page

2015-05-05 Thread Richard Henderson
On 04/08/2015 02:37 PM, Emilio G. Cota wrote: The callers have just looked up the page descriptor, so there's no point in searching again for it. Signed-off-by: Emilio G. Cota c...@braap.org --- translate-all.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-05 Thread Fam Zheng
On Wed, 05/06 02:26, Dong, Eddie wrote: -Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Tuesday, May 05, 2015 11:24 PM To: Stefan Hajnoczi Cc: Paolo Bonzini; Wen Congyang; Fam Zheng; Kevin Wolf; Lai Jiangshan; qemu block; Jiang, Yunhong;

Re: [Qemu-devel] qemu-ga and logging domain

2015-05-05 Thread David Gibson
On Thu, Apr 30, 2015 at 10:37:21PM -0500, Michael Roth wrote: Quoting David Gibson (2015-04-30 20:29:23) Michael, I was just looking at some of the logging stuff in qemu-ga, and it seems to be doing something very odd with the domain. static void ga_log(const gchar *domain,

Re: [Qemu-devel] [RFC PATCH v3 08/24] ppc: Prepare CPU socket/core abstraction

2015-05-05 Thread Bharata B Rao
On Mon, May 04, 2015 at 05:15:04PM +0200, Thomas Huth wrote: On Fri, 24 Apr 2015 12:17:30 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de Not sure if QEMU is fully following the

Re: [Qemu-devel] [RFC PATCH v3 18/24] xics_kvm: Don't enable KVM_CAP_IRQ_XICS if already enabled

2015-05-05 Thread Bharata B Rao
On Tue, May 05, 2015 at 05:22:52PM +1000, David Gibson wrote: On Fri, Apr 24, 2015 at 12:17:40PM +0530, Bharata B Rao wrote: When supporting CPU hot removal by parking the vCPU fd and reusing it during hotplug again, there can be cases where we try to reenable KVM_CAP_IRQ_XICS CAP for the

Re: [Qemu-devel] [RFC PATCH v3 10/24] ppc: Update cpu_model in MachineState

2015-05-05 Thread Bharata B Rao
On Tue, May 05, 2015 at 04:49:08PM +1000, David Gibson wrote: On Fri, Apr 24, 2015 at 12:17:32PM +0530, Bharata B Rao wrote: Keep cpu_model field in MachineState uptodate so that it can be used from the CPU hotplug path. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com

[Qemu-devel] [PATCH v2 1/6] mirror: Discard target sectors if not allocated at source side

2015-05-05 Thread Fam Zheng
If guest discards a source cluster during mirror, we would want to discard target side as well. Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 58f391a..37a5b61

[Qemu-devel] [PATCH v2 0/6] block: Mirror discarded sectors

2015-05-05 Thread Fam Zheng
v2: Fix typo and add Eric's rev-by in patch 3. Add patch 1 to discard target in mirror job. (Paolo) Add patch 6 to improve iotests.wait_ready. (John) This fixes the mirror assert failure reported by wangxiaolong: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg04458.html The

[Qemu-devel] [PATCH v2 6/6] iotests: Use event_wait in wait_ready

2015-05-05 Thread Fam Zheng
Only poll the specific type of event we are interested in, to avoid stealing events that should be consumed by someone else. Suggested-by: John Snow js...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/iotests.py | 9 ++--- 1 file changed, 2 insertions(+), 7

[Qemu-devel] [PATCH v2 3/6] block: Remove bdrv_reset_dirty

2015-05-05 Thread Fam Zheng
Using this function would always be wrong because a dirty bitmap must have a specific owner that consumes the dirty bits and calls bdrv_reset_dirty_bitmap(). Remove the unused function to avoid future misuse. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com ---

[Qemu-devel] [PATCH v2 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-05 Thread Fam Zheng
Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure that the guest sees the same data. Calling bdrv_reset_dirty also troubles mirror job because the

[Qemu-devel] [PATCH v2 5/6] qemu-iotests: Add test case for mirror with unmap

2015-05-05 Thread Fam Zheng
This checks that the discard on mirror source that effectively zeroes data is also reflected by the data of target. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/131 | 59 ++ tests/qemu-iotests/131.out | 5

Re: [Qemu-devel] [PATCH v3 2/6] spapr_pci: encode missing 64-bit memory address space

2015-05-05 Thread Nikunj A Dadhania
Thomas Huth th...@redhat.com writes: On Tue, 5 May 2015 14:23:52 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: The properties reg/assigned-resources need to encode 64-bit memory address space as part of phys.hi dword. 00 if configuration space 01 if IO region, 10 if

Re: [Qemu-devel] [PATCH v3 5/6] spapr_pci: fix boot-time device tree fields for pci hotplug

2015-05-05 Thread Nikunj A Dadhania
David Gibson da...@gibson.dropbear.id.au writes: On Tue, May 05, 2015 at 02:23:55PM +0530, Nikunj A Dadhania wrote: From: Michael Roth mdr...@linux.vnet.ibm.com We need to set the proper drc_index values in ibm,my-drc-index fields in order to allow a PCI device that was present at

Re: [Qemu-devel] [RFC PATCH v3 07/24] cpu: Prepare Socket container type

2015-05-05 Thread Bharata B Rao
On Tue, May 05, 2015 at 11:47:30AM +1000, David Gibson wrote: On Fri, Apr 24, 2015 at 12:17:29PM +0530, Bharata B Rao wrote: From: Andreas Färber afaer...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com So, how to organize

Re: [Qemu-devel] [PATCH v3 1/6] spapr_pci: remove duplicate macros

2015-05-05 Thread Nikunj A Dadhania
Thomas Huth th...@redhat.com writes: On Tue, 5 May 2015 14:23:51 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com --- hw/ppc/spapr_pci.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/ppc/spapr_pci.c

[Qemu-devel] Bug report - Windows XP guest failure

2015-05-05 Thread Programmingkid
Just wanted to note that for the i386 target, Windows XP as a guest fails to boot. When it safe mode, loading always stops at Windows\System32\Drivers\Mup.sys. The guest boots in QEMU 2.2.0, so this seems to indicate a bug with the May 5th or earlier patch set.

Re: [Qemu-devel] [PATCH v3 4/6] spapr_pci: enumerate and add PCI device tree

2015-05-05 Thread Nikunj A Dadhania
Thomas Huth th...@redhat.com writes: On Tue, 5 May 2015 14:23:54 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple

Re: [Qemu-devel] [RFC PATCH v3 06/24] spapr: Consolidate cpu init code into a routine

2015-05-05 Thread Bharata B Rao
On Mon, May 04, 2015 at 06:10:59PM +0200, Thomas Huth wrote: On Fri, 24 Apr 2015 12:17:28 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Factor out bits of sPAPR specific CPU initialization code into a separate routine so that it can be called from CPU hotplug path too.

Re: [Qemu-devel] [RFC PATCH v3 12/24] spapr: CPU hotplug support

2015-05-05 Thread Bharata B Rao
On Mon, May 04, 2015 at 05:53:23PM +0200, Thomas Huth wrote: On Fri, 24 Apr 2015 12:17:34 +0530 Bharata B Rao bhar...@linux.vnet.ibm.com wrote: Support CPU hotplug via device-add command. Set up device tree entries for the hotplugged CPU core and use the exising EPOW event infrastructure

[Qemu-devel] [PATCH v2 4/6] qemu-iotests: Make block job methods common

2015-05-05 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/041| 66 ++- tests/qemu-iotests/iotests.py | 28 ++ 2 files changed, 43 insertions(+), 51 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041

Re: [Qemu-devel] [PATCH 7/7] disas: arm: Use target_disas impl for monitor

2015-05-05 Thread Claudio Fontana
Hello Peter, On 05.05.2015 06:45, Peter Crosthwaite wrote: As it is more fully featured. It has multi-endian, thumb and AArch64 support whereas the existing monitor disas support only has vanilla AA32 support. E.G. Running an AA64 linux kernel the follow -d in_asm disas happens

Re: [Qemu-devel] [PATCH v3 3/6] spapr_pci: encode class code including Prog IF register

2015-05-05 Thread Thomas Huth
On Tue, 5 May 2015 22:55:00 +1000 David Gibson da...@gibson.dropbear.id.au wrote: On Tue, May 05, 2015 at 02:23:53PM +0530, Nikunj A Dadhania wrote: Current code missed the Prog IF register. All Class Code, Subclass, and Prog IF registers are needed to identify the accurate device type.

[Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2015-05-05 Thread Marc-André Lureau
The spice server is polling on write, unless SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must call spice_server_char_device_wakeup() when the frontend is writable. Signed-off-by: Marc-André Lureau marcandre.lur...@gmail.com --- spice-qemu-char.c | 11 +++ 1 file

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-05 Thread Alberto Garcia
On Tue 05 May 2015 01:20:19 PM CEST, Kevin Wolf wrote: Though looking at the code again I see now that c-table_size isn't consistently used. The I/O requests still use s-cluster_size. We should either use it everywhere or not introduce it at all. c-table_size is necessary in order to

Re: [Qemu-devel] [PATCH v1 RFC 34/34] char: introduce support for TLS encrypted TCP chardev backend

2015-05-05 Thread Paolo Bonzini
On 05/05/2015 15:49, Daniel P. Berrange wrote: qemu-system-x86_64: -object qcrypto-tls-cred,id=tls0,credtype=x509,: invalid object type: qcrypto-tls-cred Typo in my commit message - it should end in '-creds' not '-cred' for the object type. FWIW, I think just tls-creds is

Re: [Qemu-devel] [PATCH v3 1/6] spapr_pci: remove duplicate macros

2015-05-05 Thread Thomas Huth
On Tue, 5 May 2015 14:23:51 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com --- hw/ppc/spapr_pci.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index

Re: [Qemu-devel] [PATCH 6/7] monitor: i: Add ARM specifics

2015-05-05 Thread Claudio Fontana
On 05.05.2015 06:45, Peter Crosthwaite wrote: Add the ARM specific disassembly flags setup, so ARM can be correctly disassembled from the monitor. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- monitor.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v1 RFC 34/34] char: introduce support for TLS encrypted TCP chardev backend

2015-05-05 Thread Kashyap Chamarthy
On Tue, May 05, 2015 at 02:49:51PM +0100, Daniel P. Berrange wrote: On Mon, May 04, 2015 at 10:07:15PM +0200, Kashyap Chamarthy wrote: On Fri, Apr 17, 2015 at 03:22:37PM +0100, Daniel P. Berrange wrote: This integrates support for QIOChannelTLS object in the TCP chardev backend. If the

[Qemu-devel] [PATCH 0/3] virtio-1 updates

2015-05-05 Thread Cornelia Huck
Hi Michael, I've taken your virtio-1.0 branch and updated it to a more currrent code base. There was some churn mostly in virtio-ccw, but it doesn't hit any obvious errors. I haven't looked at every single patch, collected r-bs etc. that might have been floating around or added my sign-off, but

[Qemu-devel] [PATCH v3 3/3] qemu-sockets: Report explicit error if unlink fails

2015-05-05 Thread Cole Robinson
Consider this case: $ ls -ld ~/root-owned/ drwx--x--x. 2 root root 4096 Apr 29 12:55 /home/crobinso/root-owned/ $ ls -l ~/root-owned/foo.sock -rwxrwxrwx. 1 crobinso crobinso 0 Apr 29 12:55 /home/crobinso/root-owned/foo.sock $ qemu-system-x86_64 -vnc unix:~/root-owned/foo.sock

  1   2   3   4   >