Re: [Qemu-devel] [PATCH v8 02/26] qapi: New QAPISchema intermediate reperesentation

2015-09-17 Thread Markus Armbruster
Eric Blake writes: > On 09/16/2015 05:06 AM, Markus Armbruster wrote: >> The QAPI code generators work with a syntax tree (nested dictionaries) >> plus a few symbol tables (also dictionaries) on the side. > >> Nothing uses the new intermediate representation just yet, thus no

Re: [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor

2015-09-17 Thread Markus Armbruster
Eric Blake writes: > On 09/16/2015 05:06 AM, Markus Armbruster wrote: >> The old code prints the result of parsing (list of expression >> dictionaries), and partial results of semantic analysis (list of enum >> dictionaries, list of struct dictionaries). >> >> The new code

Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation

2015-09-17 Thread Markus Armbruster
Eric Blake writes: > On 09/16/2015 05:06 AM, Markus Armbruster wrote: >> Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but >> that's no excuse. Move the helpers from qapi-types.py to qapi.py, and >> replace the duplicates in qapi-event.py. >> >> The

Re: [Qemu-devel] [PATCH 2/7] vhost-user: add protocol feature negotiation

2015-09-17 Thread Yuanhan Liu
On Thu, Sep 17, 2015 at 03:12:55PM +0800, Jason Wang wrote: > > > On 09/15/2015 03:10 PM, Yuanhan Liu wrote: > > From: "Michael S. Tsirkin" > > > > Support a separate bitmask for vhost-user protocol features, > > and messages to get/set protocol features. > > > > Invoke them at

Re: [Qemu-devel] help with understanding qcow2 file format

2015-09-17 Thread Vasiliy Tolstov
2015-09-16 16:46 GMT+03:00 Eric Blake : > qemu-img map file.qcow2 > > Offset Length Mapped to File qemu-img: File contains external, encrypted or compressed clusters. > is a great way to learn which physical host offsets hold the data at > which guest

Re: [Qemu-devel] [PATCH 2/7] vhost-user: add protocol feature negotiation

2015-09-17 Thread Jason Wang
On 09/15/2015 03:10 PM, Yuanhan Liu wrote: > From: "Michael S. Tsirkin" > > Support a separate bitmask for vhost-user protocol features, > and messages to get/set protocol features. > > Invoke them at init. > > No features are defined yet. > > v2: leverage vhost_user_call for

Re: [Qemu-devel] [PATCH v8 04/26] qapi: New QAPISchemaVisitor

2015-09-17 Thread Markus Armbruster
Eric Blake writes: > On 09/16/2015 05:06 AM, Markus Armbruster wrote: >> The visitor will help keeping the code generation code simple and >> reasonably separated from QAPISchema details. >> >> Signed-off-by: Markus Armbruster >> --- >> scripts/qapi.py |

Re: [Qemu-devel] Could not boot a guest vm from kvm mode based on APM X-Gene Host and latest qemu

2015-09-17 Thread Alex Bennée
liang yan writes: > On 09/16/2015 08:34 AM, Alex Bennée wrote: >> liang yan writes: >> >>> Hello, All, >>> >>> I am trying to enable kvm for a guest vm on an APM X-Gene Host with >>> latest qemu, but could not make it work. >>> >>> The host is APM X-Gene 8-core,

Re: [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation

2015-09-17 Thread Stefan Hajnoczi
On Tue, Sep 01, 2015 at 04:50:37PM -0400, John Snow wrote: > Ultimately, clean up the signature generation and as a result, tidy up > the port_reset and init_d2h functions. > > > > For convenience, this branch is

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-17 Thread Xiao Guangrong
On 09/16/2015 12:10 AM, Paolo Bonzini wrote: On 01/09/2015 11:14, Stefan Hajnoczi wrote: When I was digging into live migration code, i noticed that the same MR name may cause the name "idstr", please refer to qemu_ram_set_idstr(). Since nvdimm devices do not have parent-bus, it will

Re: [Qemu-devel] [PATCH] vmdk: Create streamOptimized as version 3

2015-09-17 Thread Kevin Wolf
Am 17.09.2015 um 07:04 hat Fam Zheng geschrieben: > VMware products accept only version 3 for streamOptimized, let's bump > the version. > > Reported-by: Radoslav Gerganov > Signed-off-by: Fam Zheng Radoslav, can I have your Reviewed-by and/or Tested-by

Re: [Qemu-devel] [PATCH v3 37/46] contrib: remove unnecessary strdup()

2015-09-17 Thread Vladimir Sementsov-Ogievskiy
On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau getopt() optarg points to argv memory, no need to dup those values, fixes small leaks detected by clang-analyzer. Signed-off-by: Marc-André Lureau ---

[Qemu-devel] [PATCH] virtio: add some migration doc

2015-09-17 Thread Cornelia Huck
Try to cover the basics of virtio migration. Signed-off-by: Cornelia Huck --- It might help if we add some documentation; at the very least, it will prevent myself getting a headache everytime I look at that code :) Feedback welcome. --- docs/virtio-migration.txt |

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-17 Thread Xiao Guangrong
On 09/17/2015 05:04 PM, Igor Mammedov wrote: On Thu, 17 Sep 2015 16:39:12 +0800 Xiao Guangrong wrote: On 09/16/2015 12:10 AM, Paolo Bonzini wrote: On 01/09/2015 11:14, Stefan Hajnoczi wrote: When I was digging into live migration code, i noticed that

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-17 Thread Paolo Bonzini
On 17/09/2015 11:14, Xiao Guangrong wrote: > > > /* get the memory region from backend memory. */ > mr = host_memory_backend_get_memory(dimm->hostmem, errp); > > /* nvdimm_nr will map to guest address space. */ > memory_region_init_alias(>nvdimm_mr, OBJECT(dev), >

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

2015-09-17 Thread Wen Congyang
On 09/10/2015 12:06 PM, Eric Blake wrote: > From: Kővágó, Zoltán > > Except qapi-schema.json, this patch was generated by: > > find . -name .git -prune -o -type f \! -name '*~' -print0 | \ > xargs -0 sed -i \ > -e 's/NetClientOptionsKind/NetClientDriver/g' \ >

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-17 Thread Marcel Apfelbaum
On 09/16/2015 08:44 PM, Flavio Leitner wrote: On Thu, Sep 10, 2015 at 10:51:19PM +0300, Marcel Apfelbaum wrote: Hi, The page describes how to setup an environment that allows testing/developing vhost-user using ovs (with dpdk) as backend. A regular pc machine can be used, no need for several

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 12:03, Daniel P. Berrange wrote: > The README file is usually the first thing consulted when a user > or developer obtains a copy of the QEMU source. The current QEMU > README is lacking immediately useful information and so not very > friendly for

Re: [Qemu-devel] [RFT PATCH v1 0/3] net: smc91c111 can_receive fixes

2015-09-17 Thread Stefan Hajnoczi
On Thu, Sep 10, 2015 at 09:23:27PM -0700, Peter Crosthwaite wrote: > Hi Richard, > > This should hopefully fix your bug, while addressing the extra concern > I raised. > > There was also inconsistent behaviour with corking packets through a > soft reset which I notice and fixed. > > Please let

[Qemu-devel] [PULL 1/4] MAINTAINERS: Stefan will not maintain net subsystem

2015-09-17 Thread Stefan Hajnoczi
From: Jason Wang Talked with Stefan, he will not maintain net subsystem. Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Signed-off-by: Jason Wang Message-id: 1442372730-11360-1-git-send-email-jasow...@redhat.com

[Qemu-devel] [PULL 3/4] net: smc91c111: gate can_receive() on rx FIFO having a slot

2015-09-17 Thread Stefan Hajnoczi
From: Peter Crosthwaite Return false from can_receive() when the FIFO doesn't have a free RX slot. This fixes a bug in the current code where the allocated buffer is freed before the fifo pop, triggering a premature flush of queued RX packets. It also will handle a

[Qemu-devel] [PULL 2/4] net: smc91c111: guard flush_queued_packets() on can_rx()

2015-09-17 Thread Stefan Hajnoczi
From: Peter Crosthwaite Check that the core can once again receive packets before asking the net layer to do a flush. This will make it more convenient to flush packets when adding new conditions to can_receive. Add missing if braces while moving the can_receive()

[Qemu-devel] [PULL 4/4] net: smc91c111: flush packets on RCR register changes

2015-09-17 Thread Stefan Hajnoczi
From: Peter Crosthwaite The SOFT_RST or RXEN in the control register can be used as a condition to unblock the net layer via can_receive(). So check for possible flushes on RCR changes. This will drop all pending packets on soft reset or disable which is the

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Paolo Bonzini
On 17/09/2015 13:03, Daniel P. Berrange wrote: > + > +Licensing > += > + > + - QEMU as a whole is released under the GNU General Public License, > version 2. > + > + - Parts of QEMU have specific licenses which are compatible with the GNU > +General Public License, version 2.

[Qemu-devel] [PULL 0/4] Net patches

2015-09-17 Thread Stefan Hajnoczi
The following changes since commit 619622424dba749feef752d76d79ef2569f7f250: Merge remote-tracking branch 'remotes/berrange/tags/vnc-crypto-v9-for-upstream' into staging (2015-09-15 15:42:58 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-17 Thread Stefano Stabellini
On Wed, 16 Sep 2015, Chen, Tiejun wrote: > On 9/15/2015 7:00 PM, Paolo Bonzini wrote: > > > > > > On 15/09/2015 11:55, Stefano Stabellini wrote: > > > On Mon, 14 Sep 2015, Paolo Bonzini wrote: > > > > > On 10/09/2015 12:29, Stefano Stabellini wrote: > > > > > > > +if (lseek(config_fd, pos,

Re: [Qemu-devel] [PATCH v4 3/3] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2015-09-17 Thread Marcel Apfelbaum
On 09/12/2015 03:36 PM, Knut Omang wrote: This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and register/unregister SR/IOV Virtual Functions. Signed-off-by: Knut Omang --- hw/pci/Makefile.objs| 2 +- hw/pci/pci.c

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Daniel P. Berrange
On Thu, Sep 17, 2015 at 12:32:56PM +0100, Peter Maydell wrote: > On 17 September 2015 at 12:03, Daniel P. Berrange wrote: > > The README file is usually the first thing consulted when a user > > or developer obtains a copy of the QEMU source. The current QEMU > > README is

Re: [Qemu-devel] [PATCH v4 1/3] pci: Make use of the devfn property when registering new devices

2015-09-17 Thread Knut Omang
On Thu, 2015-09-17 at 14:11 +0300, Marcel Apfelbaum wrote: > On 09/12/2015 03:36 PM, Knut Omang wrote: > > Without this, the devfn argument to pci_create_*() > > does not affect the assigned devfn. > > > > Needed to support (VF_STRIDE,VF_OFFSET) values other than (1,1) > > for SR/IOV. > > > >

Re: [Qemu-devel] [PULL v2 00/24] Misc patches for 2015-09-16

2015-09-17 Thread Peter Maydell
On 16 September 2015 at 16:40, Paolo Bonzini wrote: > The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-09-14 18:51:09 +0100) > > are available in the git

Re: [Qemu-devel] [PATCH] virtio: add some migration doc

2015-09-17 Thread Jason Wang
On 09/17/2015 06:39 PM, Greg Kurz wrote: > On Thu, 17 Sep 2015 11:06:01 +0200 > Cornelia Huck wrote: > >> Try to cover the basics of virtio migration. >> >> Signed-off-by: Cornelia Huck >> --- >> It might help if we add some documentation; at

[Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Daniel P. Berrange
The README file is usually the first thing consulted when a user or developer obtains a copy of the QEMU source. The current QEMU README is lacking immediately useful information and so not very friendly for first time encounters. It either redirects users to qemu-doc.html (which does not exist

Re: [Qemu-devel] [PATCH v4 1/3] pci: Make use of the devfn property when registering new devices

2015-09-17 Thread Marcel Apfelbaum
On 09/12/2015 03:36 PM, Knut Omang wrote: Without this, the devfn argument to pci_create_*() does not affect the assigned devfn. Needed to support (VF_STRIDE,VF_OFFSET) values other than (1,1) for SR/IOV. Signed-off-by: Knut Omang --- hw/pci/pci.c | 2 +- 1 file

Re: [Qemu-devel] [PATCH 2/3] monitor: throttle QAPI_EVENT_VSERPORT_CHANGE by "id"

2015-09-17 Thread Marc-André Lureau
Hi On Wed, Sep 16, 2015 at 6:40 PM, Markus Armbruster wrote: > > I got a few more questions. > > Do we expect more events in need of separate throttling by some ID-like > member of their data object? > Do we expect *different* callbacks? Callbacks that throttle by some >

Re: [Qemu-devel] [PATCH] virtio: add some migration doc

2015-09-17 Thread Greg Kurz
On Thu, 17 Sep 2015 11:06:01 +0200 Cornelia Huck wrote: > Try to cover the basics of virtio migration. > > Signed-off-by: Cornelia Huck > --- > It might help if we add some documentation; at the very least, it will > prevent myself getting a

Re: [Qemu-devel] [PATCH] virtio: add some migration doc

2015-09-17 Thread Jason Wang
On 09/17/2015 05:06 PM, Cornelia Huck wrote: > Try to cover the basics of virtio migration. > > Signed-off-by: Cornelia Huck > --- > It might help if we add some documentation; at the very least, it will > prevent myself getting a headache everytime I look at that code

Re: [Qemu-devel] [PATCH] virtio: add some migration doc

2015-09-17 Thread Cornelia Huck
On Thu, 17 Sep 2015 12:39:31 +0200 Greg Kurz wrote: > On Thu, 17 Sep 2015 11:06:01 +0200 > Cornelia Huck wrote: > > +Devices need to be careful in their state processing during load: The > > +load_device() procedure is invoked by the core

Re: [Qemu-devel] [PATCH] virtio: add some migration doc

2015-09-17 Thread Cornelia Huck
On Thu, 17 Sep 2015 18:44:00 +0800 Jason Wang wrote: > > > On 09/17/2015 05:06 PM, Cornelia Huck wrote: > > Try to cover the basics of virtio migration. > > > > Signed-off-by: Cornelia Huck > > --- > > It might help if we add some documentation;

Re: [Qemu-devel] [PATCH 2/4] ahci: fix signature generation

2015-09-17 Thread Stefan Hajnoczi
On Tue, Sep 01, 2015 at 04:50:39PM -0400, John Snow wrote: > The initial register device-to-host FIS no longer needs to specially > set certain fields, as these can be handled generically by setting those > fields explicitly with the signatures we want at port reset time. > > (1) Signatures are

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-17 Thread Xiao Guangrong
On 09/16/2015 12:07 AM, Paolo Bonzini wrote: On 26/08/2015 12:40, Xiao Guangrong wrote: + +size = get_file_size(fd); +buf = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); I guess the user will want to choose between MAP_SHARED and MAP_PRIVATE. This can be added in

Re: [Qemu-devel] [PATCH] cpu-exec: Add "nochain" debug flag

2015-09-17 Thread Peter Maydell
On 16 September 2015 at 23:34, Richard Henderson wrote: > Respect it to avoid linking TBs together. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v3 34/46] ivshmem-server: fix hugetlbfs support

2015-09-17 Thread Vladimir Sementsov-Ogievskiy
On 16.09.2015 19:14, Marc-André Lureau wrote: - Original Message - On 15.09.2015 19:07, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau As pointed out on the ML by Andrew Jones, glibc no longer permits creating POSIX shm on hugetlbfs directly.

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash

2015-09-17 Thread Andrew Jones
On Thu, Sep 17, 2015 at 09:57:21AM +0800, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > While virt machine creates two flash devices with total size 0x0800, > it wrongly uses this total size for each one. So it will overlap other > MMIO spaces. > >

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-17 Thread Xiao Guangrong
On 09/16/2015 12:06 AM, Paolo Bonzini wrote: On 25/08/2015 18:03, Stefan Hajnoczi wrote: +static uint64_t get_file_size(int fd) +{ +struct stat stat_buf; +uint64_t size; + +if (fstat(fd, _buf) < 0) { +return 0; +} + +if (S_ISREG(stat_buf.st_mode)) { +

[Qemu-devel] [PATCH v4] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-17 Thread Thomas Huth
The PAPR interface defines a hypercall to pass high-quality hardware generated random numbers to guests. Recent kernels can already provide this hypercall to the guest if the right hardware random number generator is available. But in case the user wants to use another source like EGD, or QEMU is

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-17 Thread Igor Mammedov
On Thu, 17 Sep 2015 16:39:12 +0800 Xiao Guangrong wrote: > > > On 09/16/2015 12:10 AM, Paolo Bonzini wrote: > > > > > > On 01/09/2015 11:14, Stefan Hajnoczi wrote: > > When I was digging into live migration code, i noticed that the same MR > name

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash

2015-09-17 Thread G Gregory
This is an urgent fix as it completely breaks booting with ACPI. Success is only a matter of luck with device probing order. Tested-by: Graeme Gregory Graeme On 17 September 2015 at 02:57, wrote: > From: Shannon Zhao

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 13:05, Daniel P. Berrange wrote: > On Thu, Sep 17, 2015 at 12:32:56PM +0100, Peter Maydell wrote: >> On 17 September 2015 at 12:03, Daniel P. Berrange >> wrote: > >> > +Building >> > + >> > + >> > +QEMU is multi-platform

Re: [Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support

2015-09-17 Thread Michael S. Tsirkin
On Tue, Sep 15, 2015 at 03:10:27PM +0800, Yuanhan Liu wrote: > Hi, > > Here is the updated patch set for enabling vhost-user multiple queue. > This patch set introduces 2 more vhost user messages: > VHOST_USER_GET_QUEUE_NUM, > for querying how many queues the backend supports, and >

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Daniel P. Berrange
On Thu, Sep 17, 2015 at 01:20:43PM +0100, Peter Maydell wrote: > On 17 September 2015 at 13:05, Daniel P. Berrange wrote: > > On Thu, Sep 17, 2015 at 12:32:56PM +0100, Peter Maydell wrote: > >> On 17 September 2015 at 12:03, Daniel P. Berrange > >>

Re: [Qemu-devel] [PATCH v2] target-cris: update CPU state save/load to use VMStateDescription

2015-09-17 Thread Peter Maydell
On 12 August 2015 at 15:15, Edgar E. Iglesias wrote: > On Fri, Aug 07, 2015 at 05:02:14PM +0100, Peter Maydell wrote: >> From: Juan Quintela >> >> Update the CRIS CPU state save/load to use a VMStateDescription struct >> rather than

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 13:36, Daniel P. Berrange wrote: > How about splitting "Chapter 6 Compilation" out of the qemu-doc.texi > file into a standalone file, in a format that is friendly to read > without needing generating first. Perhaps using something like > Markdown[1]

Re: [Qemu-devel] [PATCH v4 1/3] pci: Make use of the devfn property when registering new devices

2015-09-17 Thread Marcel Apfelbaum
On 09/17/2015 03:12 PM, Knut Omang wrote: On Thu, 2015-09-17 at 14:11 +0300, Marcel Apfelbaum wrote: On 09/12/2015 03:36 PM, Knut Omang wrote: Without this, the devfn argument to pci_create_*() does not affect the assigned devfn. Needed to support (VF_STRIDE,VF_OFFSET) values other than (1,1)

Re: [Qemu-devel] [wiki] New wiki page - vhost-user setup with ovs/dpdk backend

2015-09-17 Thread Flavio Leitner
On Thu, Sep 17, 2015 at 01:08:36PM +0300, Marcel Apfelbaum wrote: > On 09/16/2015 08:44 PM, Flavio Leitner wrote: > >On Thu, Sep 10, 2015 at 10:51:19PM +0300, Marcel Apfelbaum wrote: > >>Hi, > >> > >>The page describes how to setup an environment that allows > >>testing/developing > >>vhost-user

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-17 Thread Xiao Guangrong
On 09/17/2015 05:34 PM, Paolo Bonzini wrote: On 17/09/2015 11:14, Xiao Guangrong wrote: /* get the memory region from backend memory. */ mr = host_memory_backend_get_memory(dimm->hostmem, errp); /* nvdimm_nr will map to guest address space. */ memory_region_init_alias(>nvdimm_mr,

Re: [Qemu-devel] [PATCH] virtio: add some migration doc

2015-09-17 Thread Eric Blake
On 09/17/2015 03:06 AM, Cornelia Huck wrote: > Try to cover the basics of virtio migration. > > Signed-off-by: Cornelia Huck > --- > It might help if we add some documentation; at the very least, it will > prevent myself getting a headache everytime I look at that code

[Qemu-devel] [PATCH v18 09/21] replay: interrupts and exceptions

2015-09-17 Thread Pavel Dovgalyuk
This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [PATCH v18 10/21] replay: asynchronous events infrastructure

2015-09-17 Thread Pavel Dovgalyuk
This patch adds module for saving and replaying asynchronous events. These events include network packets, keyboard and mouse input, USB packets, thread pool and bottom halves callbacks. All events are stored in the queue to be processed at synchronization points such as beginning of TB execution,

[Qemu-devel] [PATCH v18 06/21] cpu-exec: allow temporary disabling icount

2015-09-17 Thread Pavel Dovgalyuk
This patch is required for deterministic replay to generate an exception by trying executing an instruction without changing icount. It adds new flag to TB for disabling icount while translating it. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [RFC PATCH 03/10] vfio: Check guest IOVA ranges against host IOMMU capabilities

2015-09-17 Thread David Gibson
The current vfio core code assumes that the host IOMMU is capable of mapping any IOVA the guest wants to use to where we need. However, real IOMMUs generally only support translating a certain range of IOVAs (the "DMA window") not a full 64-bit address space. The common x86 IOMMUs support a wide

[Qemu-devel] [RFC PATCH 09/10] spapr_iommu: Provide a function to switch a TCE table to allowing VFIO

2015-09-17 Thread David Gibson
Because of the way non-VFIO guest IOMMU operations are KVM accelerated, not all TCE tables (guest IOMMU contexts) can support VFIO devices. Currently, this is decided at creation time. To support hotplug of VFIO devices, we need to allow a TCE table which previously didn't allow VFIO devices to

[Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer

2015-09-17 Thread David Gibson
Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the Type1 fields are actually used on all IOMMU types,

[Qemu-devel] [Bug 1494350] Re: QEMU: causes vCPU steal time overflow on live migration

2015-09-17 Thread Alexandre Derumier
Hi, I confirm this bug, I have seen this a lot of time with debian jessie (kernel 3.16) and ubuntu (kernel 4.X) with qemu 2.2 and qemu 2.3 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1494350

Re: [Qemu-devel] [PATCH v11 02/12] init/cleanup of netfilter object

2015-09-17 Thread Eric Blake
On 09/16/2015 07:23 PM, Yang Hongyang wrote: >>> +{ 'enum': 'NetFilterChain', >>> + 'data': [ 'all', 'in', 'out' ] } >> >> I don't see any other QMP usage of this enum anywhere in the series. Are >> you planning on supporting QMP? If so, let's get that design discussion >> started. If not, why

[Qemu-devel] [PATCH v2 3/5] monitor: rename QDict *data->qdict

2015-09-17 Thread marcandre . lureau
From: Marc-André Lureau As suggested by Markus Armbruster, this is a bit more specific for the event qdict than 'data'. Signed-off-by: Marc-André Lureau --- monitor.c | 36 ++-- 1 file changed, 18

[Qemu-devel] [PATCH v18 18/21] replay: initialization and deinitialization

2015-09-17 Thread Pavel Dovgalyuk
This patch introduces the functions for enabling the record/replay and for freeing the resources when simulator closes. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- exec.c |2 + replay/replay-internal.h |

[Qemu-devel] [PATCH v18 14/21] replay: checkpoints

2015-09-17 Thread Pavel Dovgalyuk
This patch introduces checkpoints that synchronize cpu thread and iothread. When checkpoint is met in the code all asynchronous events from the queue are executed. Signed-off-by: Pavel Dovgalyuk --- cpus.c |5 + qemu-timer.c | 40

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-09-17 Thread Eric Blake
On 09/17/2015 10:32 AM, Paolo Bonzini wrote: Can we revert this one, please? Checkpatch now warns about constructs like typedef struct MyDevice { DeviceState parent; int reg0, reg1, reg2; } MyDevice; >>> >>> It's interesting that qom/object.h

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-17 Thread Michael Roth
Quoting Paolo Bonzini (2015-09-14 09:24:23) > > > On 14/09/2015 16:06, Alexey Kardashevskiy wrote: > > > > === * There is no way for a child to determine what its parent > > is. It is not * a bidirectional relationship. This is by > > design. === > > > > This part

[Qemu-devel] [PATCH 0/2] tcg/mips: small cleanups

2015-09-17 Thread Aurelien Jarno
I have these patches for quite some time in one of my local branch in the hope I would have time to do further changes. Given that I am going to send a pull request for the 64-bit qemu_ld issue, I think it's a good opportunity to also include them. Aurelien Jarno (2): tcg/mips: move

[Qemu-devel] [PATCH v2 0/5] monitor: throttle VSERPORT_CHANGED by "id"

2015-09-17 Thread marcandre . lureau
From: Marc-André Lureau QAPI_EVENT_VSERPORT_CHANGE reports changes of a virtio serial port state. However, the events may be for different ports, but the throttle mechanism may replace the event for a different port, since it only checks the event type. The

[Qemu-devel] [PATCH v2 1/5] monitor: split MonitorQAPIEventState

2015-09-17 Thread marcandre . lureau
From: Marc-André Lureau Create a separate structure MonitorQAPIEventPending for holding the data related to pending event. The next commits are going to reuse this structure for different throttling implementations. Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-09-17 Thread Peter Maydell
On 17 September 2015 at 17:00, Paolo Bonzini wrote: > > > On 17/09/2015 16:24, Peter Maydell wrote: >> Can we revert this one, please? Checkpatch now warns about constructs >> like >> typedef struct MyDevice { >> DeviceState parent; >> >> int reg0, reg1, reg2;

[Qemu-devel] [PATCH v18 04/21] replay: introduce mutex to protect the replay log

2015-09-17 Thread Pavel Dovgalyuk
This mutex will protect read/write operations for replay log. Using mutex is necessary because most of the events consist of several fields stored in the log. The mutex will help to avoid races. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk

[Qemu-devel] [PATCH v18 03/21] replay: internal functions for replay log

2015-09-17 Thread Pavel Dovgalyuk
This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/Makefile.objs |1 replay/replay-internal.c | 155

[Qemu-devel] [PATCH v18 20/21] replay: command line options

2015-09-17 Thread Pavel Dovgalyuk
This patch introduces command line options for enabling recording or replaying virtual machine behavior. These options are added to icount command line parameter. They include 'rr' which switches between record and replay and 'rrfile' for specifying the filename for replay log. Signed-off-by:

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-17 Thread Michael Roth
Quoting David Gibson (2015-09-15 22:16:35) > On Mon, Sep 14, 2015 at 04:24:23PM +0200, Paolo Bonzini wrote: > > > > > > On 14/09/2015 16:06, Alexey Kardashevskiy wrote: > > > > > > === * There is no way for a child to determine what its parent > > > is. It is not * a bidirectional

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-09-17 Thread Paolo Bonzini
On 17/09/2015 16:24, Peter Maydell wrote: > Can we revert this one, please? Checkpatch now warns about constructs > like > typedef struct MyDevice { > DeviceState parent; > > int reg0, reg1, reg2; > } MyDevice; It's interesting that qom/object.h documents this and start like:

[Qemu-devel] [PATCH v2 2/5] monitor: introduce MonitorQAPIEventDelay callback

2015-09-17 Thread marcandre . lureau
From: Marc-André Lureau Move the delay handling in a seperate function that can be changed for different throttling implementations, as will be done in following commits. Signed-off-by: Marc-André Lureau --- monitor.c| 85

[Qemu-devel] [PATCH v18 07/21] cpu: replay instructions sequence

2015-09-17 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. When replayed instructions counter is expired qemu_notify_event() function is

[Qemu-devel] [PATCH v18 02/21] replay: global variables and function stubs

2015-09-17 Thread Pavel Dovgalyuk
This patch adds global variables, defines, function declarations, and function stubs for deterministic VM replay used by external modules. Reviewed-by: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v18 05/21] replay: introduce icount event

2015-09-17 Thread Pavel Dovgalyuk
This patch adds icount event to the replay subsystem. This event corresponds to execution of several instructions and used to synchronize input events in the replay phase. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk ---

[Qemu-devel] [PATCH v18 21/21] replay: recording of the user input

2015-09-17 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 33 +

[Qemu-devel] [PATCH v18 17/21] typedef: add typedef for QemuOpts

2015-09-17 Thread Pavel Dovgalyuk
This patch moves typedefs for QemuOpts and related types to qemu/typedefs.h file. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- include/qemu/option.h |5 + include/qemu/typedefs.h |3 +++ 2 files changed, 4

Re: [Qemu-devel] [PATCH] README: fill out some useful quickstart information

2015-09-17 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Sep 17, 2015 at 01:20:43PM +0100, Peter Maydell wrote: >> On 17 September 2015 at 13:05, Daniel P. Berrange >> wrote: >> > On Thu, Sep 17, 2015 at 12:32:56PM +0100, Peter Maydell wrote: >> >> On 17 September 2015

[Qemu-devel] [PATCH v2] virtio: add some migration doc

2015-09-17 Thread Cornelia Huck
Try to cover the basics of virtio migration. Signed-off-by: Cornelia Huck Reviewed-by: Greg Kurz --- v1->v2: make copyright explicit --- docs/virtio-migration.txt | 106 ++ 1 file changed, 106

Re: [Qemu-devel] [RFC 21/38] target-i386: emulate atomic instructions + barriers using AIE

2015-09-17 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota > --- > aie-helper.c | 3 +- > linux-user/main.c | 4 +- > target-i386/cpu.h | 3 - > target-i386/excp_helper.c | 7 ++ > target-i386/helper.h | 6 +- >

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash

2015-09-17 Thread Wei Huang
On 09/16/2015 08:57 PM, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > While virt machine creates two flash devices with total size 0x0800, > it wrongly uses this total size for each one. So it will overlap other > MMIO spaces. > > Signed-off-by: Shannon

Re: [Qemu-devel] [PATCH v8 02/26] qapi: New QAPISchema intermediate reperesentation

2015-09-17 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 09/16/2015 05:06 AM, Markus Armbruster wrote: >>> The QAPI code generators work with a syntax tree (nested dictionaries) >>> plus a few symbol tables (also dictionaries) on the side. >> >>> Nothing uses

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-17 Thread Paolo Bonzini
On 17/09/2015 17:50, Michael Roth wrote: > We still need globals for RTAS lookups. I think QOM is our most > mature/well-tested interface for managing inter-device > relationships/lookups, but I can understand if using > root_container/link seems off. To me it seem like a nice > "freebie" we get

[Qemu-devel] [PATCH v2 5/5] monitor: remove old entries from event hash table

2015-09-17 Thread marcandre . lureau
From: Marc-André Lureau Do not let the hash table grow without limit, schedule a cleanup for outdated event. Signed-off-by: Marc-André Lureau --- monitor.c | 58 +- 1 file

[Qemu-devel] [PATCH v18 00/21] Deterministic replay core

2015-09-17 Thread Pavel Dovgalyuk
This set of patches is related to the reverse execution and deterministic replay of qemu execution. This implementation of deterministic replay can be used for deterministic debugging of guest code through gdb remote interface. Core set of patches does not include support for reverse debugging

[Qemu-devel] [PATCH v18 01/21] i386: partial revert of interrupt poll fix

2015-09-17 Thread Pavel Dovgalyuk
Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- cpu-exec.c

Re: [Qemu-devel] [PATCH 3/4] checkpatch: adapt some tests to QEMU

2015-09-17 Thread Paolo Bonzini
On 17/09/2015 18:16, Peter Maydell wrote: > On 17 September 2015 at 17:00, Paolo Bonzini wrote: >> >> >> On 17/09/2015 16:24, Peter Maydell wrote: >>> Can we revert this one, please? Checkpatch now warns about constructs >>> like >>> typedef struct MyDevice { >>>

Re: [Qemu-devel] [PATCH] tcg/mips: Fix clobbering of qemu_ld inputs

2015-09-17 Thread Aurelien Jarno
On 2015-09-14 11:34, James Hogan wrote: > The MIPS TCG backend implements qemu_ld with 64-bit targets using the v0 > register (base) as a temporary to load the upper half of the QEMU TLB > comparator (see line 5 below), however this happens before the input > address is used (line 8 to mask off

[Qemu-devel] [PATCH 1/2] tcg/mips: move tcg_out_addsub2

2015-09-17 Thread Aurelien Jarno
Somehow the tcg_out_addsub2 function ended-up in the middle of the qemu_ld/st related functions. Move it with other arithmetics related functions. Signed-off-by: Aurelien Jarno --- tcg/mips/tcg-target.c | 98 +-- 1 file

[Qemu-devel] [PATCH v18 16/21] replay: ptimer

2015-09-17 Thread Pavel Dovgalyuk
This patch adds deterministic replay for hardware periodic countdown timers. ptimer uses bottom halves layer to execute such an asynchronous callback. We put this callback into the replay queue instead of bottom halves one. When checkpoint is met by main loop thread, the replay queue is processed

[Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks

2015-09-17 Thread Pavel Dovgalyuk
Clock ticks are considered as the sources of non-deterministic data for virtual machine. This patch implements saving the clock values when they are acquired (virtual, host clock). When replaying the execution corresponding values are read from log and transfered to the module, which wants to read

[Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay

2015-09-17 Thread Pavel Dovgalyuk
icount_warp_rt function is called by qemu_clock_warp and as callback of icount_warp timer. This patch adds call to qemu_clock_warp into main_loop_wait function, because icount warp may be missed in record/replay mode, when CPU is sleeping. This patch also disables of calling this function by

[Qemu-devel] [PATCH v18 12/21] replay: shutdown event

2015-09-17 Thread Pavel Dovgalyuk
This patch records and replays simulator shutdown event. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.h |2 ++ replay/replay.c | 14 ++ replay/replay.h |5 + vl.c

  1   2   3   >