Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts

On 11/23/15 19:09, Paolo Bonzini wrote: > > > On 23/11/2015 18:59, Laszlo Ersek wrote: The only interesting thing is that parse_keyword always eats a TOKEN_KEYWORD, even if it is invalid, so it must come last in parse_value (otherwise, NULL is returned, parse_literal is invoked

Re: [Qemu-devel] [PATCH] acpi: fix buffer overrun on migration

On 11/19/2015 08:35 AM, Michael S. Tsirkin wrote: > ich calls acpi_gpe_init with length ICH9_PMIO_GPE0_LEN so > ICH9_PMIO_GPE0_LEN/2 bytes are allocated, but then the full > ICH9_PMIO_GPE0_LEN bytes are migrated. > > As a quick work-around, allocate twice the memory. > We'll probably want to

Re: [Qemu-devel] [PATCH v5 0/5] add ACPI node for fw_cfg on pc and arm

On 11/23/15 20:31, Gabriel L. Somlo wrote: > Couple of items: > > 1. Ping ? :) > > 2. Thank you markmb for your R-b ! > > 3. If anyone's had a chance to look over the corresponding guest-side >kernel sysfs driver which utilizes this, you will have noticed I'm >automatically initializing

Re: [Qemu-devel] [PATCH v5 0/5] add ACPI node for fw_cfg on pc and arm

Couple of items: 1. Ping ? :) 2. Thank you markmb for your R-b ! 3. If anyone's had a chance to look over the corresponding guest-side kernel sysfs driver which utilizes this, you will have noticed I'm automatically initializing the driver based on DeviceTree or ACPI on ARM and x86,

Re: [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default)

On Mon, Nov 23, 2015 at 05:43:14PM +0100, Borislav Petkov wrote: > On Mon, Nov 23, 2015 at 01:11:27PM -0200, Eduardo Habkost wrote: > > On Mon, Nov 23, 2015 at 11:22:37AM -0200, Eduardo Habkost wrote: > > [...] > > > In the case of this code, it looks like it's already broken > > > because the

Re: [Qemu-devel] QAPI vs QMP commands

Markus Armbruster writes: > Lluís Vilanova writes: >> When adding a new QAPI command, should I also add a corresponding entry in >> "qmp-commands.hx"? > Yes. > Towards the end of the very long QAPI patch queue are patches to get rid > of qmp-commands.hx. We'll get there,

Re: [Qemu-devel] ivshmem property size should be a size, not a string

On 11/23/2015 07:46 AM, Markus Armbruster wrote: >>> If it's not broken, please explain to me how the guest should find out >>> whether its ivshmem device sports a doorbell. >> >> If you have received ID, you should be good to use the doorbell. > > That's not a complete answer, so let me try a

Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts

On 23/11/2015 18:59, Laszlo Ersek wrote: >> > The only interesting thing is that parse_keyword always eats >> > a TOKEN_KEYWORD, even if it is invalid, so it must come last in >> > parse_value (otherwise, NULL is returned, parse_literal is invoked >> > and it tries to peek beyond end of input).

Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest

On Mon, Nov 23, 2015 at 07:01:33PM +0100, Marc-André Lureau wrote: > On Mon, Nov 23, 2015 at 6:40 PM, Paolo Bonzini wrote: > > Before: object-initial, chardev, qtest, object-late (not in the patch) > > > > After: chardev, qtest, object-initial, object-late (not in the patch)

[Qemu-devel] [RFC][PATCH v2 0/2] utils: Improve and document error reporting

Adds support for reporting non-terminating errors (dubbed warnings), and briefly documents what routines should developers generally use to keep error reporting consistent. Changes in v2 = * Split in two patches. * Explicitly add a warning error object. Signed-off-by: Lluís

[Qemu-devel] QAPI vs QMP commands

When adding a new QAPI command, should I also add a corresponding entry in "qmp-commands.hx"? Thanks, Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Markus Armbruster writes: > Marc-André Lureau writes: [...] >>> * shm appears to be the same as memdev, just less flexible. Why does it >>> exist? >> >> It was there before. > > Not only is memdev more flexible, it also provides the clean split >

Re: [Qemu-devel] Build problem with qemu Makefile change

Quoting Steve Ellcey (2015-11-23 12:06:57) > My qemu build has been failing since this checkin by Michael Roth: > > http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg03991.html > > which changed the top-level Makefile. Is anyone else seeing this? > > I am building a qemu for

[Qemu-devel] [PATCH v2 1/2] utils: Add warning messages

Adds a special error object that transforms error messages into immediately reported warnings. Signed-off-by: Lluís Vilanova --- include/qapi/error.h | 20 util/error.c | 37 +++-- 2 files changed, 47

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm/translate-a64.c: Correct unallocated checks for ldst_excl

On 23.11.2015 19:49, Peter Maydell wrote: > Ping? I forgot to mark this for-2.5, and given how long the bug's > been hanging around there's not much urgency to fixing it, but > we might as well put the fix into 2.5 if it gets reviewed. > Hi, Peter. I'm going to review this carefully in a few days

[Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 31 +++ 1 file changed, 31 insertions(+) diff --git a/HACKING b/HACKING index 12fbc8a..e59bc34 100644 --- a/HACKING +++ b/HACKING @@ -157,3

Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts

On 11/23/2015 10:59 AM, Laszlo Ersek wrote: > On 11/23/15 18:44, Paolo Bonzini wrote: >> JSON is LL(1) and our parser indeed needs only 1 token lookahead. >> Saving the parser context is mostly unnecessary; we can replace it >> with peeking at the next token, or remove it altogether when the >>

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

Daniel P Berrange writes: [...] > I don't think this "Errors in user inputs" vs "Other errors" distinction > really makes sense. Whether an error raised in a piece of code is related > to user input or not is almost impossible to determine in practice. So as > a rule to follow it is not practical.

Re: [Qemu-devel] [PATCH v5 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

Hi Gabriel, [auto build test WARNING on v4.4-rc2] [also build test WARNING on next-20151123] [cannot apply to robh/for-next] url: https://github.com/0day-ci/linux/commits/Gabriel-L-Somlo/SysFS-driver-for-QEMU-fw_cfg-device/20151124-000402 config: arm-allyesconfig (attached as .config

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > On 11/23/2015 07:46 AM, Markus Armbruster wrote: > > >>> If it's not broken, please explain to me how the guest should find out > >>> whether its ivshmem device sports a doorbell. > >> > >> If you have received ID, you should be good to use the doorbell. > > >

Re: [Qemu-devel] [PATCH v5 0/5] add ACPI node for fw_cfg on pc and arm

On Mon, Nov 23, 2015 at 08:46:33PM +0100, Laszlo Ersek wrote: > On 11/23/15 20:31, Gabriel L. Somlo wrote: > > Couple of items: > > > > 1. Ping ? :) > > > > 2. Thank you markmb for your R-b ! > > > > 3. If anyone's had a chance to look over the corresponding guest-side > >kernel sysfs

Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts

On 11/23/15 21:05, Eric Blake wrote: > On 11/23/2015 10:59 AM, Laszlo Ersek wrote: >> On 11/23/15 18:44, Paolo Bonzini wrote: >>> JSON is LL(1) and our parser indeed needs only 1 token lookahead. >>> Saving the parser context is mostly unnecessary; we can replace it >>> with peeking at the next

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

On Mon, Nov 23, 2015 at 09:05:30PM +0100, Lluís Vilanova wrote: > Daniel P Berrange writes: > [...] > > I don't think this "Errors in user inputs" vs "Other errors" distinction > > really makes sense. Whether an error raised in a piece of code is related > > to user input or not is almost

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

On Mon, Nov 23, 2015 at 03:41:11PM +0800, Jason Wang wrote: > Currently, all virtio devices bypass IOMMU completely. This is because > address_space_memory is assumed and used during DMA emulation. This > patch converts the virtio core API to use DMA API. This idea is > > - introducing a new

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

On Sat, 2015-11-21 at 14:11 +0100, Paolo Bonzini wrote: > > On 20/11/2015 01:20, Ming Lin wrote: > > One improvment could be to use google's NVMe vendor extension that > > I send in another thread, aslo here: > > https://git.kernel.org/cgit/linux/kernel/git/mlin/linux.git/log/?h=nvme-google-ext >

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

On 11/20/2015 05:59 PM, Fam Zheng wrote: > "s->bitmap" tracks done sectors, we only check bit states without using any > iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and > more memory efficient. > > Meanwhile, rename it to done_bitmap, to reflect the intention. > >

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

On Mon, 11/23 08:33, Markus Armbruster wrote: > Fam Zheng writes: > > > Otherwise, a window flashes on my desktop (built with SDL). Add this as > > other cases have it. > > > > Signed-off-by: Fam Zheng > > > > --- > > v2: Fix 119 too. [Max] > > --- > >

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

On 11/23/2015 05:19 PM, Fam Zheng wrote: > On Mon, 11/23 17:01, Wen Congyang wrote: >> On 11/20/2015 05:59 PM, Fam Zheng wrote: >>> "s->bitmap" tracks done sectors, we only check bit states without using any >>> iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and >>> more

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

On Mon, 11/23 17:24, Wen Congyang wrote: > On 11/23/2015 05:19 PM, Fam Zheng wrote: > > On Mon, 11/23 17:01, Wen Congyang wrote: > >> On 11/20/2015 05:59 PM, Fam Zheng wrote: > >>> "s->bitmap" tracks done sectors, we only check bit states without using > >>> any > >>> iterator which HBitmap is

Re: [Qemu-devel] [PATCH for 2.5 1/1] parallels: dirty BAT properly for continuous allocations

On Tue, Nov 17, 2015 at 08:02:58PM +0300, Denis V. Lunev wrote: > From: Vladimir Sementsov-Ogievskiy > > This patch marks part of the BAT dirty properly. There is a possibility that > multy-block allocation could have one block allocated on one BAT page and > next block

[Qemu-devel] [PATCH] linux-user,sh4: fix signal retcode address

To return from a signal, setup_frame() puts an instruction to be executed in the stack. This sequence calls the syscall sigreturn(). The address of the instruction must be set in the PR register to be executed. This patch fixes this: the current code sets the register to the address of the

Re: [Qemu-devel] [PATCH] linux-user, sh4: fix signal retcode address

On 11/23/2015 11:38 AM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Tested-by: John Paul Adrian Glaubitz This patch fixes crashes of qemu-sh4* on amd64 for me [1]. I also haven't seen any regressions ever since. Cheers, Adrian > [1]

[Qemu-devel] [PATCH for-2.5] vhost-user: clarify start and enable

It seems that we currently have some duplication between started and enabled states. The actual reason is that enable is not documented correctly: what it does is connecting ring to the backend. This is important for MQ, because a Linux guest expects TX packets to be completed even if it

Re: [Qemu-devel] [PATCH] vhost-user: set link down when the char device is closed

On 11/20/2015 01:42 PM, Wen wrote: > To Jason Wang: > > I think this patch should be for qemu-2.5 > > Thanks > Wen Congyang Hi: I thought it was for vhost tree. Michael: Do you want to take this patch? > > On 11/11/2015 02:53 PM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang

Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling

On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote: > qmp_query_memdev() has two error paths: > > * When object_get_objects_root() returns null. It never does, so > simply drop the useless error handling. > > * When query_memdev() fails. It leaks err then. But any failure >

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

On Mon, 11/23 17:01, Wen Congyang wrote: > On 11/20/2015 05:59 PM, Fam Zheng wrote: > > "s->bitmap" tracks done sectors, we only check bit states without using any > > iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and > > more memory efficient. > > > > Meanwhile, rename

Re: [Qemu-devel] [PATCH] block/qapi: Plug memory leak on query-block error path

Am 20.11.2015 um 13:53 hat Markus Armbruster geschrieben: > Spotted by Coverity. > > Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf

Re: [Qemu-devel] PING: [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

On 23/11/2015 11:09, Paolo Bonzini wrote: > On 23/11/2015 07:41, Pavel Fedin wrote: >> Hello! No news for a long time, we are at RC stage. Could we get this in? > > Yes, queued for -rc2. ... doh, Eduardo applied it to the NUMA tree already. I missed that backends/hostmem* is under NUMA and

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> >> Hash ivshmem been used in anger? If yes, how? >> >> Still the question to answer. > > I don't expect users to read this ML everyday (anybody > actually). Personally, I have no clue how widespread ivshmem

[Qemu-devel] [PULL for-2.5] tcg: Fix highwater check

From: John Clarke A simple typo in the variable to use when comparing vs the highwater mark. Reports are that qemu can in fact segfault occasionally due to this mistake. Signed-off-by: John Clarke Signed-off-by: Richard Henderson ---

[Qemu-devel] [PULL for-2.5] last minute tcg fix

at: git://github.com/rth7680/qemu.git tags/pull-tcg-20151123 for you to fetch changes up to 644da9b39e477caa80bab69d2847dfcb468f0d33: tcg: Fix highwater check (2015-11-23 13:16:05 +0100) Last minute fix

[Qemu-devel] [PULL 0/1] NUMA fix for -rc2

(I forgot to submit a pull request for this earlier, sorry.) The following changes since commit 541abd10a01da56c5f16582cd32d67114ec22a5c: Update version for v2.5.0-rc1 release (2015-11-20 17:43:46 +) are available in the git repository at: git://github.com/ehabkost/qemu.git

Re: [Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on every machine

Ping? Any thoughts on this approach? -rc2 is too late for this kind of change, maybe? On Thu, Nov 12, 2015 at 03:29:53PM -0200, Eduardo Habkost wrote: > This changes the qemu_hw_version() default to "2.5+" so we don't > make every machine class broken by default unless they set > hw_version. >

[Qemu-devel] [PULL 1/1] hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

From: Pavel Fedin Currently hostmem backend fails if CONFIG_NUMA is enabled in QEMU (the default) but NUMA is not supported by the kernel. This makes it impossible to use ivshmem in such configurations. This patch fixes the problem by ignoring ENOSYS error if policy is set

Re: [Qemu-devel] [PULL for-2.5] tcg: Fix highwater check

Am 23.11.2015 um 13:45 schrieb Richard Henderson: > From: John Clarke > > A simple typo in the variable to use when comparing vs the highwater mark. > Reports are that qemu can in fact segfault occasionally due to this mistake. > > Signed-off-by: John Clarke

Re: [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug

On Fri, Nov 20, 2015 at 18:24:29 +0530, Bharata B Rao wrote: > This patchset adds CPU hotplug support for sPAPR PowerPC guests using > device_add and device_del commands > > (qemu) device_add POWER8-powerpc64-cpu,id=cpu0 Is there a reason why this uses 'device_add' rather than the 'cpu_add'

Re: [Qemu-devel] [PATCH WIP 04/30] qcow2: add a 'keyid' parameter to qcow2 options

On Fri, Nov 20, 2015 at 03:15:27PM -0700, Eric Blake wrote: > On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: > > Add a 'keyid' parameter that refers to the ID of a > > QCryptoSecret instance that provides the encryption key. > > > > $QEMU \ > > -object

Re: [Qemu-devel] [PATCH 0/2] Don't require hw_version to be set on every machine

On Mon, Nov 23, 2015 at 10:53:39AM -0200, Eduardo Habkost wrote: > > Ping? Any thoughts on this approach? > > -rc2 is too late for this kind of change, maybe? > I queued this up for 2.5, will merge later this week unless anyone objects. > On Thu, Nov 12, 2015 at 03:29:53PM -0200, Eduardo

Re: [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug

On 11/23/2015 12:54 PM, Peter Krempa wrote: > On Fri, Nov 20, 2015 at 18:24:29 +0530, Bharata B Rao wrote: >> This patchset adds CPU hotplug support for sPAPR PowerPC guests using >> device_add and device_del commands >> >> (qemu) device_add POWER8-powerpc64-cpu,id=cpu0 > > Is there a reason why

Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling

"Michael S. Tsirkin" writes: > On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote: >> qmp_query_memdev() has two error paths: >> >> * When object_get_objects_root() returns null. It never does, so >> simply drop the useless error handling. >> >> * When

Re: [Qemu-devel] [PATCH for-2.5] target-arm: Don't mask out bits [47:40] in LPAE descriptors for v8

On Fri, Nov 20, 2015 at 02:32:51PM +, Peter Maydell wrote: > In an LPAE format descriptor in ARMv8 the address field extends > up to bit 47, not just bit 39. Correct the masking so we don't > give incorrect results if the output address size is greater > than 40 bits, as it can be for AArch64.

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > > >> qemu-doc documents role only with chardev. The code doesn't care. > > > > yeah, role is only really useful with a server. Another missing warning. > > I think it makes sense only when we can migrate the shared memory > contents out-of-band. Vaguely

Re: [Qemu-devel] [PATCH WIP 01/30] crypto: add QCryptoSecret object class for password/key handling

On Fri, Nov 20, 2015 at 03:09:25PM -0700, Eric Blake wrote: > On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: > > + > > +static const char *base64_valid_chars = > > +"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/="; > > + > > +static int > >

[Qemu-devel] [PATCH 1/2] tests/Makefile: Add more dependencies for test-timed-average

'make check' failed to compile the test case for mingw because of undefined references. Pull in a few more dependencies so that it builds. Signed-off-by: Kevin Wolf --- tests/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Makefile

[Qemu-devel] [PATCH for-2.5 0/2] Fix "make check" with mingw and Wine

I tried to run "make check" on my mingw build and got two failures. Both of them are bugs in the test suite rather than qemu proper. They are easy enough to fix, so here are the fixes. Kevin Wolf (2): tests/Makefile: Add more dependencies for test-timed-average test-aio: Fix event notifier

[Qemu-devel] [PATCH 2/2] test-aio: Fix event notifier cleanup

One test case closed an event notifier (event_notifier_cleanup()) without first disabling it (set_event_notifier(..., NULL)). This resulted in a leftover handle 0 that was added to each subsequent WaitForMultipleObjects() call, causing the function to fail (invalid handle). Signed-off-by: Kevin

Re: [Qemu-devel] PING: [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

On Mon, Nov 23, 2015 at 11:11:28AM +0100, Paolo Bonzini wrote: > > > On 23/11/2015 11:09, Paolo Bonzini wrote: > > On 23/11/2015 07:41, Pavel Fedin wrote: > >> Hello! No news for a long time, we are at RC stage. Could we get this in? > > > > Yes, queued for -rc2. > > ... doh, Eduardo applied

Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM

On Thu, Nov 19, 2015 at 10:39:05AM +0800, Xiao Guangrong wrote: > On 11/19/2015 04:44 AM, Michael S. Tsirkin wrote: > >On Wed, Nov 18, 2015 at 05:18:17PM -0200, Eduardo Habkost wrote: > >>On Wed, Nov 18, 2015 at 09:59:34AM +0800, Xiao Guangrong wrote: > >sorry, I'm busy with 2.5 now, and this is

[Qemu-devel] [PATCH v4 0/5] Connect the SPI devices to ZynqMP

Connect the SPI devices to Xilinx's ZynqMP. I also need to make some changes to the actual SPI device to imporove the fuctionality, but for the time being this works. V4: - Rebase - Rename the SPI busses so that they can all be accessed from the SoC - Only create one SPI flash device V3: -

[Qemu-devel] [PATCH v4 5/5] xlnx-ep108: Connect the SPI Flash

Connect the sst25wf080 SPI flash to the EP108 board. Signed-off-by: Alistair Francis --- V4: - Only add one SPI flash V3: - Don't reach into the SoC V2: - Use sst25wf080 instead of m25p80 hw/arm/xlnx-ep108.c | 16 1 file changed, 16

[Qemu-devel] [PATCH v4 1/5] m25p80.c: Add sst25wf080 SPI flash device

Add the sst25wf080 SPI flash device. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index efc43dd..7b9f97c

[Qemu-devel] [PATCH v4 2/5] ssi: Move ssi.h into a separate directory

Move the ssi.h include file into the ssi directory. While touching the code also fix the typdef lines as checkpatch complains. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V2: - Change git patch to indicate rename

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

On Mon, Nov 23, 2015 at 10:36:45AM +0100, Cornelia Huck wrote: > On Mon, 23 Nov 2015 15:41:11 +0800 > Jason Wang wrote: > > > Currently, all virtio devices bypass IOMMU completely. This is because > > address_space_memory is assumed and used during DMA emulation. This > >

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

On 11/23/2015 05:55 PM, Fam Zheng wrote: > On Mon, 11/23 17:24, Wen Congyang wrote: >> On 11/23/2015 05:19 PM, Fam Zheng wrote: >>> On Mon, 11/23 17:01, Wen Congyang wrote: On 11/20/2015 05:59 PM, Fam Zheng wrote: > "s->bitmap" tracks done sectors, we only check bit states without using

[Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling

qmp_query_memdev() has two error paths: * When object_get_objects_root() returns null. It never does, so simply drop the useless error handling. * When query_memdev() fails. It leaks err then. But any failure there is actually a programming error. Switch it to _abort, and drop the

Re: [Qemu-devel] [PATCH for 2.5 1/1] parallels: dirty BAT properly for continuous allocations

On 11/17/2015 08:02 PM, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy This patch marks part of the BAT dirty properly. There is a possibility that multy-block allocation could have one block allocated on one BAT page and next block on the next page. The

Re: [Qemu-devel] [PATCH for-2.5 v2 0/4] block: replace IOV_MAX with BlockLimits.max_iov

On Thu, Jul 09, 2015 at 10:56:43AM +0100, Stefan Hajnoczi wrote: > v2: > * Default to IOV_MAX instead of INT_MAX [Peter Lieven] > > This series depends on "[PATCH] block/mirror: limit qiov to IOV_MAX elements". > > IOV_MAX has been hardcoded in several places since preadv()/pwritev()/etc >

Re: [Qemu-devel] [PATCH for-2.5 v2 0/4] block: replace IOV_MAX with BlockLimits.max_iov

On Wed, Nov 18, 2015 at 03:51:29PM +0100, Kevin Wolf wrote: > Am 09.07.2015 um 11:56 hat Stefan Hajnoczi geschrieben: > > v2: > > * Default to IOV_MAX instead of INT_MAX [Peter Lieven] > > > > This series depends on "[PATCH] block/mirror: limit qiov to IOV_MAX > > elements". > > > > IOV_MAX

[Qemu-devel] [PATCH v4 4/5] xlnx-zynqmp: Connect the SPI devices

Connect the Xilinx SPI devices to the ZynqMP model. Signed-off-by: Alistair Francis --- V4: - Rename the SPI busses so that they can all be accessed from the SoC - Don't set the num-busses property V3: - Expose the SPI Bus as part of the SoC device V2: - Don't

[Qemu-devel] [PATCH v4 3/5] xilinx_spips: Seperate the state struct into a header

Seperate out the XilinxSPIPS struct into a seperate header file. Signed-off-by: Alistair Francis --- V4: - Don't split off R_MOD_ID and hardcode R_MAX V2: - Only split out required #defines - Prefix XLNX_SPIPS_ hw/ssi/xilinx_spips.c | 46

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

On Mon, 23 Nov 2015 15:41:11 +0800 Jason Wang wrote: > Currently, all virtio devices bypass IOMMU completely. This is because > address_space_memory is assumed and used during DMA emulation. This > patch converts the virtio core API to use DMA API. This idea is > > -

Re: [Qemu-devel] PING: [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

On 23/11/2015 07:41, Pavel Fedin wrote: > Hello! No news for a long time, we are at RC stage. Could we get this in? Yes, queued for -rc2. Paolo > Kind regards, > Pavel Fedin > Expert Engineer > Samsung Electronics Research center Russia > >> -Original Message- >> From:

Re: [Qemu-devel] [PATCH V5 8/8] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

Le 20/11/2015 13:21, Alistair Francis a écrit : On Fri, Oct 16, 2015 at 7:11 PM, wrote: From: KONRAD Frederic This adds the DP and the DPDMA to the Zynq MP platform. Signed-off-by: KONRAD Frederic

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> >> >> qemu-doc documents role only with chardev. The code doesn't care. >> > >> > yeah, role is only really useful with a server. Another missing warning. >> >> I think it makes sense only when we can

[Qemu-devel] [PATCH v2 1/1] parallels: add format spec

From: Vladimir Sementsov-Ogievskiy This specifies Parallels image format as implemented in Parallels Cloud Server 6.10 Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev CC: Eric Blake

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > > "role" was designed to only migrate the master. Ability to migrate a pool > > of > > peer would be a significant new feature. I am not aware of such request. > > I see. But how is this supposed to work? > > Before migration: one master and N peers connected

[Qemu-devel] [PATCH 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

This patch only add the interfaces, but not implementing them. Signed-off-by: Peter Xu --- dump.c | 3 ++- hmp-commands.hx | 5 +++-- hmp.c| 3 ++- qapi-schema.json | 3 ++- qmp-commands.hx | 4 ++-- 5 files changed, 11 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH REPOST 2/2] dump-guest-memory: add basic "detach" support.

This will allow the user specify "-d" (just like command "migrate") when using "dump-guest-memory" command. When specified, one background thread is created to do the dump work. One flag is added to show whether there is a background dump work in progress. Signed-off-by: Peter Xu

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> > "role" was designed to only migrate the master. Ability to migrate a pool >> > of >> > peer would be a significant new feature. I am not aware of such request. >> >> I see. But how is this supposed to

Re: [Qemu-devel] [PATCH V5 7/8] introduce xlnx-dp

Le 20/11/2015 11:06, Alistair Francis a écrit : On Fri, Oct 16, 2015 at 7:11 PM, wrote: From: KONRAD Frederic This is the implementation of the DisplayPort. It has an aux-bus to access dpcd and edid. Graphic plane is connected to the

Re: [Qemu-devel] [PATCH] target-i386: Do not set MCG_SER_P by default

On Sat, Nov 21, 2015 at 02:09:25AM +0100, Borislav Petkov wrote: > On Sat, Nov 21, 2015 at 12:11:35AM +0100, Andreas Färber wrote: > > Hi, > > > > CC'ing qemu-devel. > > Ah, thanks. > > > Am 21.11.2015 um 00:01 schrieb Borislav Petkov: > > > From: Borislav Petkov > > > > > >

[Qemu-devel] [PATCH] PCI Trivial: remove superfluous code

remove superfluous code in do_pci_register_device(). See its caller: pci_qdev_realize() Signed-off-by: Cao jin --- hw/pci/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 168b9cc..4d16da0 100644 --- a/hw/pci/pci.c +++

Re: [Qemu-devel] [PATCH WIP 01/30] crypto: add QCryptoSecret object class for password/key handling

"Daniel P. Berrange" writes: > On Fri, Nov 20, 2015 at 03:09:25PM -0700, Eric Blake wrote: >> On 11/20/2015 11:04 AM, Daniel P. Berrange wrote: >> > + >> > +static const char *base64_valid_chars = >> > +"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=";

Re: [Qemu-devel] [PULL for-2.5] tcg: Fix highwater check

On 11/23/2015 02:16 PM, Stefan Weil wrote: Am 23.11.2015 um 13:45 schrieb Richard Henderson: From: John Clarke A simple typo in the variable to use when comparing vs the highwater mark. Reports are that qemu can in fact segfault occasionally due to this mistake.

[Qemu-devel] [PATCH 0/2] Add basic "detach" support for dump-guest-memory

Currently, dump-guest-memory supports synchronous operation only. This patch sets are adding "detach" support for it (just like "migrate -d" for migration). When "-d" is provided, dump-guest-memory command will return immediately without hanging user. This should be useful when the backend storage

[Qemu-devel] [PATCH 2/2] dump-guest-memory: add basic "detach" support.

This will allow the user specify "-d" (just like command "migrate") when using "dump-guest-memory" command. When specified, one background thread is created to do the dump work. One flag is added to show whether there is a background dump work in progress. Signed-off-by: Peter Xu

[Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

Currently, dump-guest-memory supports synchronous operation only. This patch sets are adding "detach" support for it (just like "migrate -d" for migration). When "-d" is provided, dump-guest-memory command will return immediately without hanging user. This should be useful when the backend storage

[Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

This patch only add the interfaces, but not implementing them. Signed-off-by: Peter Xu --- dump.c | 3 ++- hmp-commands.hx | 5 +++-- hmp.c| 3 ++- qapi-schema.json | 3 ++- qmp-commands.hx | 4 ++-- 5 files changed, 11 insertions(+), 7 deletions(-)

[Qemu-devel] [Bug 1518969] [NEW] Instance of QEMU doesn't unplug virtio scsi disk after device_del and drive_del commands

Public bug reported: device_del and drive_del commands don't cause virtio disk detaching Steps to reproduce: 1. Run instance 2. Attach virtio scsi disk 3. Reboot instance 4. Immediately after reboot detach disk with QEMU commands: device_del drive_del Expected result: Disk should be detached

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

On 23/11/2015 09:17, Ming Lin wrote: > On Sat, 2015-11-21 at 14:11 +0100, Paolo Bonzini wrote: >> >> On 20/11/2015 01:20, Ming Lin wrote: >>> One improvment could be to use google's NVMe vendor extension that >>> I send in another thread, aslo here: >>>

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Hi - Original Message - > > > > You can't migrate the peers. > > Then explain the case N'=0 to me: how can you migrate the master so that > it's connected to a server afterwards? Dest qemu: -incoming.. -chardev socket,path=dest-server That is, start your destination qemu with a

Re: [Qemu-devel] [PATCH v5 0/6] fw_cfg: spec update, misc. cleanup, optimize read

Ping ? I can send out v6 and fix the commit blurb typo in patch 6/6 pointed out by Laszlo (unless the series is already winding its way toward eventually being applied). Please advise. Thanks, --Gabriel On Thu, Nov 05, 2015 at 09:32:46AM -0500, Gabriel L. Somlo wrote: > New since v4: > >

[Qemu-devel] [PATCH] [doc] Introduce coding style for errors

Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 52 ++ include/qapi/error.h | 12 util/error.c | 24 +-- 3

Re: [Qemu-devel] Is ivshmem's test for unix domain client socket valid?

On 20/11/2015 18:56, Markus Armbruster wrote: > Looks rather fishy: > > if (strncmp(s->server_chr->filename, "unix:", 5)) { > error_setg(errp, "chardev is not a unix client socket"); > return; > } > > Paolo, is this reliable? Yes, though by total chance

Re: [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size

On 20/11/2015 18:32, Eric Blake wrote: > > static void qlist_size_iter(QObject *obj, void *opaque) > > { > > size_t *count = opaque; > > (*count)++; > > } > > Yuck - we don't track size independently? Seems like it might make a > worthwhile addition, Would you change your mind, if I

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

On Mon, 23 Nov 2015 11:52:50 +0200 "Michael S. Tsirkin" wrote: > On Mon, Nov 23, 2015 at 10:36:45AM +0100, Cornelia Huck wrote: > > On Mon, 23 Nov 2015 15:41:11 +0800 > > Jason Wang wrote: > > > > > Currently, all virtio devices bypass IOMMU completely.

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

On 23 November 2015 at 14:34, Cornelia Huck wrote: > The mmio transport is a completely different beast; I'm afraid I don't > know enough about it to say how it interacts with iommus. Conceptually, it's just a device that does DMA, I think. You could in theory put it

Re: [Qemu-devel] [PATCH] virtio-blk: Move resetting of req->mr_next to virtio_blk_handle_rw_error

On 23/11/2015 01:41, Fam Zheng wrote: > "werror=report" would free the req in virtio_blk_handle_rw_error, we > mustn't write to it in that case. > > Reported-by: Paolo Bonzini > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 7 +++ > 1 file

Re: [Qemu-devel] [PATCH 1/2] tests/Makefile: Add more dependencies for test-timed-average

On 23/11/2015 13:39, Kevin Wolf wrote: > tests/test-timed-average$(EXESUF): tests/test-timed-average.o qemu-timer.o \ > libqemuutil.a stubs/clock-warp.o stubs/cpu-get-icount.o \ > - stubs/notify-event.o stubs/replay.o > + stubs/notify-event.o stubs/replay.o stubs/mon-is-qmp.o >

Re: [Qemu-devel] ivshmem property size should be a size, not a string

Marc-André Lureau writes: > Hi > > - Original Message - >> > >> > You can't migrate the peers. >> >> Then explain the case N'=0 to me: how can you migrate the master so that >> it's connected to a server afterwards? > > Dest qemu: -incoming.. -chardev

  1   2   3   >