Re: [Qemu-devel] [PATCH] include/hw/ptimer.h: Add documentation comments

On Mon, Jul 3, 2017 at 12:13 PM, Peter Maydell wrote: > Add documentation comments describing the public API of the > ptimer countdown timer. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > I was

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

On Tue, Jul 04, 2017 at 09:01:43AM +0530, Bharata B Rao wrote: > On Mon, Jul 03, 2017 at 02:21:31PM +0200, Greg Kurz wrote: > > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > > Let's propagate the error instead, like it is done everywhere else > > where spapr_drc_attach() is

Re: [Qemu-devel] [PATCH 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

在 2017/7/3 19:48, Cornelia Huck 写道: On Mon, 3 Jul 2017 09:38:36 +0200 QingFeng Hao wrote: Do not check kvm_eventfds_enabled() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulate ioeventfd") it

Re: [Qemu-devel] [PATCH v2 1/1] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

在 2017/7/3 18:20, Christian Borntraeger 写道: On 07/03/2017 10:51 AM, QingFeng Hao wrote: This patch is based on a similar patch from Stefan Hajnoczi - commit c324fd0a39c (" virtio-pci: use ioeventfd even when KVM is disabled) Do not check kvm_eventfds_enabled() when KVM is disabled since it

Re: [Qemu-devel] [PATCH] spapr: fix memory hotplug error path

On Mon, Jul 03, 2017 at 02:21:31PM +0200, Greg Kurz wrote: > QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails. > Let's propagate the error instead, like it is done everywhere else > where spapr_drc_attach() is called. > > Signed-off-by: Greg Kurz > --- >

Re: [Qemu-devel] [PATCH v2 0/7] KVM: MMU: fast write protect

On 07/03/2017 11:47 PM, Paolo Bonzini wrote: On 03/07/2017 16:39, Xiao Guangrong wrote: On 06/20/2017 05:15 PM, guangrong.x...@gmail.com wrote: From: Xiao Guangrong Changelog in v2: thanks to Paolo's review, this version disables write-protect-all if PML is

Re: [Qemu-devel] [PATCH v2 06/15] kvmvapic: remove tcg related code

On Mon, Jul 03, 2017 at 04:28:00PM +0200, Paolo Bonzini wrote: > > > On 03/07/2017 12:12, Yang Zhong wrote: > > Since Paolo's below patch has fixed A20 issue > > commit bbfa326fc8028e275eddf8c9965c2a1b59405b2e > > target/i386: enable A20 automatically in system management mod > > How is this

Re: [Qemu-devel] [PATCH 1/3] i386/msi: Correct mask of destination ID in MSI address

On Thu, Jun 29, 2017 at 01:49:52AM -0400, Lan Tianyu wrote: > From: Chao Gao > > According to SDM 10.11.1, only [19:12] bits of MSI address are > Destination ID, change the mask to avoid ambiguity for VT-d spec > has used the bit 4 to indicate a remappable interrupt request.

Re: [Qemu-devel] [PATCH] i386/kvm: mask MSR_IA32_BNDCFGS if MPX is not enabled in guest cpuid

On 07/03/17 17:45 +0200, Paolo Bonzini wrote: > > > On 03/07/2017 17:23, Haozhong Zhang wrote: > > Otherwise, QEMU on a host with MPX support will try to set guest > > MSR_IA32_BNDCFGS although guest MPX is not enabled, and result in > > abort. > > > > For example, > >qemu-system-x86_64

Re: [Qemu-devel] [PATCH 3/4] doc: add item for "-M enforce-config-section"

On Mon, Jul 03, 2017 at 02:07:12PM -0300, Eduardo Habkost wrote: > On Mon, Jul 03, 2017 at 10:44:07AM +0800, Peter Xu wrote: > > It's never documented, and now we have one more parameter for it (which > > means this one can be obsolete in the future). Document it properly. > > > > Although now

Re: [Qemu-devel] [PATCH 2/3] xen-pt: bind/unbind interrupt remapping format MSI

Hi Anthony: On 2017年06月30日 23:48, Anthony PERARD wrote: > On Thu, Jun 29, 2017 at 01:49:53AM -0400, Lan Tianyu wrote: >> From: Chao Gao >> >> If a vIOMMU is exposed to guest, guest will configure the msi to remapping >> format. The original code isn't suitable to the new

Re: [Qemu-devel] [PATCH v7 0/9] Convert to realize and cleanup

Hi, Michael On 07/04/2017 01:41 AM, Michael S. Tsirkin wrote: On Tue, Jun 27, 2017 at 02:16:46PM +0800, Mao Zhongyi wrote: This series mainly implements the conversions of pci-bridge devices i82801b11, io3130_upstream/downstream and so on to realize(). Naturally part of error messages need to

Re: [Qemu-devel] [PATCH 2/4] vl: move global property, migrate init earlier

On Mon, Jul 03, 2017 at 11:59:03AM -0300, Eduardo Habkost wrote: > On Mon, Jul 03, 2017 at 10:44:06AM +0800, Peter Xu wrote: > > Currently drive_init_func() may call migrate_get_current() while the > > migrate object is still not ready yet at that time. Move the migration > > object init earlier,

Re: [Qemu-devel] [PULL 01/21] virtio-net: enable configurable tx queue size

On 07/04/2017 03:44 AM, Michael S. Tsirkin wrote: From: Wei Wang This patch enables the virtio-net tx queue size to be configurable between 256 (the default queue size) and 1024 by the user when the vhost-user backend is used. Currently, the maximum tx queue size for

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

That is why I think we can consider a possibility of forgetting about ACPI hot plug in pcie-pci bridge and use only SHPC (with some correcting work). Especially since q35 is used only for 'modern' Windows guests and there're no big problems with SHPC on Linux guests. вт, 4 июля 2017 г. в 1:06,

Re: [Qemu-devel] [PATCH 4/4] target-m68k: add fscale, fgetman and fgetexp

Le 03/07/2017 à 22:31, Richard Henderson a écrit : > On 07/03/2017 12:50 PM, Laurent Vivier wrote: >> fmove.x #0x0ABCDEF12345,%fp0 >> fgetman.x %fp0,%fp6 >> fp02.1518178707571747286191852003521627e-4938(raw >> 0x0abcdef12345) >> fp6

[Qemu-devel] [PATCH v2 15/15] qemu-io: Relax 'alloc' now that block-status doesn't assert

Previously, the alloc command required that input parameters be sector-aligned and clamped to 32 bits, because the underlying bdrv_is_allocated used a 32-bit parameter and asserted aligned inputs. But now that we have fixed block status to report a 64-bit bytes value, and to properly round

[Qemu-devel] [PATCH v2 09/15] block: Switch bdrv_co_get_block_status() to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal function (no semantic change), and as with its public counterpart, rename to bdrv_co_block_status() to make the compiler enforce that we catch all uses. For now,

[Qemu-devel] [PATCH v2 13/15] block: Convert bdrv_get_block_status_above() to bytes

We are gradually moving away from sector-based interfaces, towards byte-based. In the common case, allocation is unlikely to ever use values that are not naturally sector-aligned, but it is possible that byte-based values will let us be more precise about allocation at the end of an unaligned

[Qemu-devel] [PATCH v2 07/15] qemu-img: Switch get_block_status() to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Continue by converting an internal function (no semantic change), and simplifying its caller accordingly. Signed-off-by: Eric Blake --- v2: no change --- qemu-img.c |

[Qemu-devel] [PATCH v2 08/15] block: Convert bdrv_get_block_status() to bytes

We are gradually moving away from sector-based interfaces, towards byte-based. In the common case, allocation is unlikely to ever use values that are not naturally sector-aligned, but it is possible that byte-based values will let us be more precise about allocation at the end of an unaligned

[Qemu-devel] [PATCH v2 06/15] block: Switch bdrv_make_zero() to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Change the internal loop iteration of zeroing a device to track by bytes instead of sectors (although we are still guaranteed that we iterate by steps that are sector-aligned).

Re: [Qemu-devel] [PATCH v2 3/3] block: add default implementations for bdrv_co_get_block_status()

On 07/03/2017 01:31 PM, Eric Blake wrote: >> The throttle driver I'm working on passes bdrv_co_get_block_status() to >> bs->file. If there is a problem with an unused default function (it's >> not static so will compile, but it might not be up to standard), you can >> just remove it and I will

[Qemu-devel] [RFC PATCH v2 16/15] block: Add .bdrv_co_block_status() callback

We are gradually moving away from sector-based interfaces, towards byte-based. Now that the block layer exposes byte-based allocation, it's time to tackle the drivers. Add a new callback that operates on as small as byte boundaries. Subsequent patches will then update individual drivers, then

[Qemu-devel] [PATCH v2 05/15] qcow2: Switch is_zero_sectors() to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal function (no semantic change), and rename it to is_zero() in the process. Signed-off-by: Eric Blake --- v2: rename function, rebase to

[Qemu-devel] [PATCH v2 04/15] block: Make bdrv_round_to_clusters() signature more useful

In the process of converting sector-based interfaces to bytes, I'm finding it easier to represent a byte count as a 64-bit integer at the block layer (even if we are internally capped by SIZE_MAX or even INT_MAX for individual transactions, it's still nicer to not have to worry about

[Qemu-devel] [PATCH v2 12/15] block: Switch bdrv_co_get_block_status_above() to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal type (no semantic change), and rename it to match the corresponding public function rename. Signed-off-by: Eric Blake --- v2: rebase to

[Qemu-devel] [PATCH v2 14/15] block: Align block status requests

Any device that has request_alignment greater than 512 should be unable to report status at a finer granularity; it may also be simpler for such devices to be guaranteed that the block layer has rounded things out to the granularity boundary (the way the block layer already rounds all other I/O

[Qemu-devel] [PATCH v2 02/15] block: Allow NULL file for bdrv_get_block_status()

Not all callers care about which BDS owns the mapping for a given range of the file. This patch merely simplifies the callers by consolidating the logic in the common call point, while guaranteeing a non-NULL file to all the driver callbacks, for no semantic change. The only caller that does not

[Qemu-devel] [PATCH v2 01/15] block: add default implementations for bdrv_co_get_block_status()

From: Manos Pitsidianakis bdrv_co_get_block_status_from_file() and bdrv_co_get_block_status_from_backing() set *file to bs->file and bs->backing respectively, so that bdrv_co_get_block_status() can recurse to them. Future block drivers won't have to duplicate code to

[Qemu-devel] [PATCH v2 10/15] block: Switch BdrvCoGetBlockStatusData to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal type (no semantic change), and rename it to match the corresponding public function rename. Signed-off-by: Eric Blake --- v2: rebase to

[Qemu-devel] [PATCH v2 11/15] block: Switch bdrv_common_block_status_above() to byte-based

We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert another internal function (no semantic change). Signed-off-by: Eric Blake --- v2: new patch --- block/io.c | 42 +- 1

[Qemu-devel] [PATCH v2 03/15] block: Add flag to avoid wasted work in bdrv_is_allocated()

Not all callers care about which BDS owns the mapping for a given range of the file. In particular, bdrv_is_allocated() cares more about finding the largest run of allocated data from the guest perspective, whether or not that data is consecutive from the host perspective. Therefore, doing

[Qemu-devel] [PATCH v2 00/15] make bdrv_get_block_status byte-based

There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

Tried it on Win7 Enterprise SP1 - SHPC works well, _OSC patches aren't necessary (since pci-bridge has its own controller, I suppose). On Linux guests it works when adding device from CLI with -device, but OS seems to fail detecting the device when I add it with device_add from monitor. Also

Re: [Qemu-devel] [PATCH v3 1/1] s390x: vmstatify config migration for virtio-ccw

Am Mon, 3 Jul 2017 23:34:14 +0200 schrieb Halil Pasic : > Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for > flexibility (extending using subsections) and for fun. > > To achieve this we need to hack the config_vector, which is > VirtIODevice (that

Re: [Qemu-devel] [PATCH v2 0/5] target/sh4: misc FPU fixes and optimizations

On 07/02/2017 01:28 PM, Aurelien Jarno wrote: This patchset should fix the bug#1701821 reported by Bruno Haible, which makes the gnulib testsuite to fail for single precision libm tests or for tests relying on unordered comparisons. It also fixes an inversion of cause and flag bits in the FPSCR

[Qemu-devel] [PATCH v3 1/1] s390x: vmstatify config migration for virtio-ccw

Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for flexibility (extending using subsections) and for fun. To achieve this we need to hack the config_vector, which is VirtIODevice (that is common virtio) state, in the middle of the VirtioCcwDevice state representation. This is

Re: [Qemu-devel] [PATCH 0/2] target/sh4: fix fabs and optimize fneg

On 07/02/2017 09:32 AM, Aurelien Jarno wrote: This patchset should fix the bug #1701821 reported by Bruno Haible, which makes the gnulib testsuite to fail for single precision libm tests. Aurelien Jarno (2): target/sh4: do not check for PR bit for fabs instruction target/sh4: do not use a

Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns

On 07/02/2017 06:18 AM, Aurelien Jarno wrote: +if (!s390_has_feat(s->insn->fac == S390_FEAT_EXTENDED_TRANSLATION_3 + ? S390_FEAT_ETF3_ENH : S390_FEAT_ETF2_ENH)) { +m3 = 0; +} This doesn't look correct to me. The well-formedness checking is part of ETF3_ENH

Re: [Qemu-devel] [PATCH] util/cacheinfo: Fix warning generated by clang

On 07/01/2017 03:44 PM, Peter Maydell wrote: On 1 July 2017 at 23:35, Richard Henderson wrote: Perhaps it ought to be telling me to use %x to force Xn in spite of the type? You always get Xn anyway, regardless of the type. For us, I think the right thing to do is make

Re: [Qemu-devel] [PATCH v4 3/3] tcg/aarch64: Enable indirect jump path using LDR (literal)

On 06/30/2017 07:36 AM, Pranith Kumar wrote: This patch enables the indirect jump path using an LDR (literal) instruction. It will be interesting to test and see which performs better among the two paths. CC: Alex Bennée Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 2/4] xen/mapcache: add an ability to create dummy mappings

On Mon, 3 Jul 2017, Igor Druzhinin wrote: > On 01/07/17 01:06, Stefano Stabellini wrote: > > On Fri, 30 Jun 2017, Igor Druzhinin wrote: > >> Dummys are simple anonymous mappings that are placed instead > >> of regular foreign mappings in certain situations when we need > >> to postpone the actual

Re: [Qemu-devel] [PATCH 3/4] xen/mapcache: introduce xen_remap_cache_entry()

On 01/07/17 01:08, Stefano Stabellini wrote: > On Fri, 30 Jun 2017, Igor Druzhinin wrote: >> This new call is trying to update a requested map cache entry >> according to the changes in the physmap. The call is searching >> for the entry, unmaps it, tries to translate the address and >> maps again

Re: [Qemu-devel] [PATCH 4/4] target-m68k: add fscale, fgetman and fgetexp

On 07/03/2017 12:50 PM, Laurent Vivier wrote: fmove.x #0x0ABCDEF12345,%fp0 fgetman.x %fp0,%fp6 fp02.1518178707571747286191852003521627e-4938 (raw 0x0abcdef12345) fp61.34103012886691431049257516861 (raw

Re: [Qemu-devel] [PATCH 22/22] configure: warn on untested --disable-tcg

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: --disable-tcg will almost certainly fail to compile on non-x86 platforms, so issue a warning. Signed-off-by: Paolo Bonzini --- configure | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 21/22] target/i386: add the CONFIG_TCG into Makefiles

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong Add the CONFIG_TCG for frontend and backend's files in the related Makefiles. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- target/i386/Makefile.objs

Re: [Qemu-devel] [PATCH 20/22] target/i386: add the tcg_enabled() in target/i386/

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: @@ -215,10 +215,12 @@ void breakpoint_handler(CPUState *cs) if (cs->watchpoint_hit) { if (cs->watchpoint_hit->flags & BP_CPU) { cs->watchpoint_hit = NULL; -if (check_hw_breakpoints(env, false)) { -

Re: [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: +static inline void cpu_set_mxcsr(CPUX86State *env, uint32_t mxcsr) +{ +env->mxcsr = mxcsr; +if (tcg_enabled()) { +tcg_update_mxcsr(env); I'd prefer update_mxcsr_status for this new name. +} +} + +static inline void

Re: [Qemu-devel] [PATCH 19/22] target/i386: move TLB refill function out of helper.c

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: This function calls tlb_set_page_with_attrs, which is not available when TCG is disabled. Move it to excp_helper.c. Signed-off-by: Paolo Bonzini --- target/i386/excp_helper.c | 343 +

Re: [Qemu-devel] [PATCH 17/22] target/i386: make cpu_get_fp80()/cpu_set_fp80() static

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong Move cpu_get_fp80()/cpu_set_fp80() from fpu_helper.c to machine.c because fpu_helper.c will be disabled if tcg is disabled in the build. Signed-off-by: Yang Zhong Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH 16/22] target/i386: move cpu_sync_bndcs_hflags() function

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: @@ -1302,10 +1332,12 @@ void cpu_report_tpr_access(CPUX86State *env, TPRAccess access) env->tpr_access_type = access; cpu_interrupt(cs, CPU_INTERRUPT_TPR); -} else { +} else if (tcg_enabled()) {

Re: [Qemu-devel] [PATCH 15/22] tcg: add the CONFIG_TCG into Makefiles

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong Add the CONFIG_TCG for frontend and backend's files in the related Makefiles. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- Makefile.target | 4 ++--

Re: [Qemu-devel] [PATCH 13/22] exec: elide calls to tb_lock and tb_unlock

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: Adding assertions fixes link errors. Signed-off-by: Paolo Bonzini --- exec.c | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 14/22] tcg: add CONFIG_TCG guards in headers

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: --- a/include/exec/helper-proto.h +++ b/include/exec/helper-proto.h @@ -28,7 +28,9 @@ dh_ctype(ret) HELPER(name) (dh_ctype(t1), dh_ctype(t2), dh_ctype(t3), \ #include "helper.h" #include "trace/generated-helpers.h" +#ifdef CONFIG_TCG

Re: [Qemu-devel] [PATCH 12/22] tcg: move tb_lock out of translate-all.h

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 1 - include/exec/exec-all.h | 4 tcg/tcg.h | 4 3 files changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

On Mon, Jul 03, 2017 at 03:50:52PM -0300, Eduardo Habkost wrote: > On Mon, Jul 03, 2017 at 09:38:52PM +0300, Michael S. Tsirkin wrote: > > On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > > > This compat property sole function is to prevent the device from being > > >

Re: [Qemu-devel] [PATCH 10/22] vapic: use tcg_enabled

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- hw/i386/kvmvapic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 09/22] monitor: disable "info jit" and "info opcount" if !TCG

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- accel/tcg/translate-all.c | 5 + hmp-commands-info.hx | 4 monitor.c | 2 ++ 3 files changed, 11 insertions(+) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH 11/22] tcg: add the tcg-stub.c file into accel/stubs/

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong If tcg is disabled, the functions in tcg-stub.c file will be called. This file is target-independent file, do not include any platform related stub functions into this file. Signed-off-by: Yang

[Qemu-devel] [PULL 21/21] i386/acpi: update expected acpi files

We dropped some dead code, update extected table binaries. Fixes: 4d7e7f2702912 ("hw/acpi: remove dead acpi code") Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/q35/DSDT| Bin 7824 -> 7782 bytes tests/acpi-test-data/q35/DSDT.bridge | Bin 7841 -> 7799 bytes

Re: [Qemu-devel] [PATCH 2/4] xen/mapcache: add an ability to create dummy mappings

On 01/07/17 01:06, Stefano Stabellini wrote: > On Fri, 30 Jun 2017, Igor Druzhinin wrote: >> Dummys are simple anonymous mappings that are placed instead >> of regular foreign mappings in certain situations when we need >> to postpone the actual mapping but still have to give a >> memory region to

Re: [Qemu-devel] [PATCH 06/22] tcg: move page_size_init() function

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong translate-all.c will be disabled if tcg is disabled in the build, so page_size_init() function and related variables will be moved to exec.c file. Signed-off-by: Yang Zhong Signed-off-by:

[Qemu-devel] [PULL 18/21] vhost-user: unregister slave req handler at cleanup time

From: Maxime Coquelin If the backend sends a request just before closing the socket, the aio dispatcher might schedule its reading after the vhost device has been cleaned, leading to a NULL pointer dereference in slave_read(); vhost_user_cleanup() already closes the

Re: [Qemu-devel] [PATCH 08/22] tcg: make tcg_allowed global

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong Change the tcg_enabled() and make sure user build still enable tcg even x86 softmmu disable tcg. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini ---

Re: [Qemu-devel] [PATCH 07/22] tcg: tcg_handle_interrupt() function

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong Move tcg_handle_interrupt() from translate-common.c to accel/tcg/tcg-all.c. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- accel/tcg/Makefile.objs |

Re: [Qemu-devel] [PATCH 05/22] vl: add tcg_enabled() for tcg related code

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: From: Yang Zhong Need to disable the tcg related code in the vl.c if the disable-tcg option is added into ./configure command. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 16/21] intel_iommu: fix migration breakage on mr switch

From: Peter Xu Migration is broken after the vfio integration work: qemu-kvm: AHCI: Failed to start FIS receive engine: bad FIS receive buffer address qemu-kvm: Failed to load ich9_ahci:ahci qemu-kvm: error while loading state for instance 0x0 of device

Re: [Qemu-devel] [PATCH 4/4] target-m68k: add fscale, fgetman and fgetexp

Le 03/07/2017 à 21:26, Richard Henderson a écrit : > On 07/03/2017 09:23 AM, Laurent Vivier wrote: >> +void HELPER(fgetman)(CPUM68KState *env, FPReg *res, FPReg *val) >> +{ >> +if (floatx80_is_infinity(val->d)) { >> +res->d = floatx80_default_nan(NULL); >> +/* FIXME: set the

[Qemu-devel] [PULL 13/21] fw_cfg: don't map the fw_cfg IO ports in fw_cfg_io_realize()

From: Mark Cave-Ayland As indicated by Laszlo it is a QOM bug for the realize() method to actually map the device. Set up the IO regions within fw_cfg_io_realize() and defer the mapping with sysbus_add_io() to the caller, as already done in fw_cfg_init_mem_wide().

[Qemu-devel] [PULL 20/21] virtio-net: fix tx queue size for !vhost-user

Current code segfaults when no nic peer is specified. Fix it up - fall back to default queue size. Fixes: 9b02e1618cf26a ("virtio-net: enable configurable tx queue size") Cc: Wei Wang Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 28

[Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. * test that a GUID

[Qemu-devel] [PULL 14/21] fw_cfg: move setting of FW_CFG_VERSION_DMA bit to fw_cfg_init1()

From: Mark Cave-Ayland The setting of the FW_CFG_VERSION_DMA bit is the same across both the TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in fw_cfg_init1(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Laszlo Ersek

Re: [Qemu-devel] [PATCH 1/4] block/qcow2: add compression_algorithm create option

Am 27.06.2017 um 17:04 schrieb Eric Blake: > On 06/27/2017 09:49 AM, Peter Lieven wrote: > >> Before I continue, can you please give feedback on the following spec >> change: >> >> diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt >> index 80cdfd0..f1428e9 100644 >> ---

[Qemu-devel] [PULL 17/21] vhost: ensure vhost_ops are set before calling iotlb callback

From: Maxime Coquelin This patch fixes a crash that happens when vhost-user iommu support is enabled and vhost-user socket is closed. When it happens, if an IOTLB invalidation notification is sent by the IOMMU, vhost_ops's NULL pointer is dereferenced.

[Qemu-devel] [PULL 08/21] pci: Replace pci_add_capability2() with pci_add_capability()

From: Mao Zhongyi After the patch 'Make errp the last parameter of pci_add_capability()', pci_add_capability() and pci_add_capability2() now do exactly the same. So drop the wrapper pci_add_capability() of pci_add_capability2(), then replace the pci_add_capability2()

Re: [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: -extern int tcg_tb_size; +extern unsigned long tcg_tb_size; size_t would be more natural. I don't think we support any hosts for which sizeof(size_t) != sizeof(unsigned long), but perhaps unsigned lomg tmp; if

[Qemu-devel] [PULL 12/21] i386/kvm/pci-assign: Use errp directly rather than local_err

From: Mao Zhongyi In assigned_device_pci_cap_init(), first, error messages are filled to a local_err variable, then through error_propagate() pass to the parameter of errp. It leads to cumbersome code. In order to avoid the extra local_err and error_propagate(), drop

[Qemu-devel] [PULL 15/21] hw/acpi: remove dead acpi code

From: Aleksandr Bezzubikov Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 10 --

[Qemu-devel] [PULL 11/21] i386/kvm/pci-assign: Fix return type of verify_irqchip_kernel()

From: Mao Zhongyi When the function no success value to transmit, it usually make the function return void. It has turned out not to be a success, because it means that the extra local_err variable and error_propagate() will be needed. It leads to cumbersome code,

[Qemu-devel] [PULL 07/21] pci: Make errp the last parameter of pci_add_capability()

From: Mao Zhongyi Add Error argument for pci_add_capability() to leverage the errp to pass info on errors. This way is helpful for its callers to make a better error handling when moving to 'realize'. Cc: pbonz...@redhat.com Cc: r...@twiddle.net Cc:

[Qemu-devel] [PULL 03/21] intel_iommu: relax iq tail check on VTD_GCMD_QIE enable

From: Ladi Prosek The VT-d spec (section 6.5.2) prescribes software to zero the Invalidation Queue Tail Register before enabling the VTD_GCMD_QIE Global Command Register bit. Windows Server 2012 R2 and possibly other older Windows versions violate the protocol and set a

[Qemu-devel] [PULL 05/21] pci: Add comment for pci_add_capability2()

From: Mao Zhongyi Comments for pci_add_capability2() to explain the return value. This may help to make a correct return value check for its callers. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi

[Qemu-devel] [PULL 09/21] pci: Convert to realize

From: Mao Zhongyi Convert i82801b11, io3130_upstream, io3130_downstream and pcie_root_port devices to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi Reviewed-by: Marcel Apfelbaum

[Qemu-devel] [PULL 00/21] pc, acpi, pci, virtio: fixes, cleanups, features, tests

The following changes since commit fd479c60f5766f7fb247ad146b9e3c33d03d2055: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170603' into staging (2017-07-03 09:54:32 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 10/21] pci: Convert shpc_init() to Error

From: Mao Zhongyi In order to propagate error message better, convert shpc_init() to Error also convert the pci_bridge_dev_initfn() to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi

[Qemu-devel] [PULL 06/21] pci: Fix the wrong assertion.

From: Mao Zhongyi pci_add_capability returns a strictly positive value on success, correct asserts. Cc: dmi...@daynix.com Cc: jasow...@redhat.com Cc: kra...@redhat.com Cc: alex.william...@redhat.com Cc: arm...@redhat.com Cc: mar...@redhat.com Signed-off-by: Mao

[Qemu-devel] [PULL 04/21] pci: Clean up error checking in pci_add_capability()

From: Mao Zhongyi On success, pci_add_capability2() returns a positive value. On failure, it sets an error and return a negative value. pci_add_capability() laboriously checks this behavior. No other caller does. Drop the checks from pci_add_capability(). Cc:

[Qemu-devel] [PULL 01/21] virtio-net: enable configurable tx queue size

From: Wei Wang This patch enables the virtio-net tx queue size to be configurable between 256 (the default queue size) and 1024 by the user when the vhost-user backend is used. Currently, the maximum tx queue size for other backends is 512 due to the following limitations:

[Qemu-devel] [PULL 02/21] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device

From: Thomas Huth This way the bridge shows up in the correct section of the "-device help" text. Signed-off-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH 03/22] configure: add --disable-tcg configure option

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: This lets you build without TCG (hardware accelerationor qtest only). When this flag is passed to configure, it will automatically filter out the target list to only those that support KVM or Xen or HAX. Signed-off-by: Anthony

Re: [Qemu-devel] [PATCH 02/22] configure: early test for supported targets

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: Check for unsupported targets in target_list, and print an error early in the configuration process. Signed-off-by: Paolo Bonzini --- configure | 65 ++- 1 file

Re: [Qemu-devel] [PATCH 01/22] configure: factor out list of supported Xen/KVM/HAX targets

On 07/03/2017 09:34 AM, Paolo Bonzini wrote: This will be useful when the functions are called, early in the configure process, to filter out targets that do not support hardware acceleration. Signed-off-by: Paolo Bonzini --- configure | 90

[Qemu-devel] [PATCH] virtio-net: fix tx queue size for !vhost-user

Current code segfaults when no nic peer is specified. Fix it up - fall back to default queue size. Fixes: 526e8fa8b872 ("virtio-net: enable configurable tx queue size") Cc: Wei Wang Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net.c | 28

Re: [Qemu-devel] [PATCH 4/4] target-m68k: add fscale, fgetman and fgetexp

On 07/03/2017 09:23 AM, Laurent Vivier wrote: +void HELPER(fgetman)(CPUM68KState *env, FPReg *res, FPReg *val) +{ +if (floatx80_is_infinity(val->d)) { +res->d = floatx80_default_nan(NULL); +/* FIXME: set the OPERR bit int he FPSR */ +return; +} +if

Re: [Qemu-devel] [PATCH v4] virtio-net: enable configurable tx queue size

On Wed, Jun 28, 2017 at 10:37:59AM +0800, Wei Wang wrote: > This patch enables the virtio-net tx queue size to be configurable > between 256 (the default queue size) and 1024 by the user when the > vhost-user backend is used. > > Currently, the maximum tx queue size for other backends is 512 due

Re: [Qemu-devel] [PATCH 2/4] target/m68k: add FPU trigonometric instructions

On 07/03/2017 12:11 PM, Richard Henderson wrote: if (floatx80_to_ldouble(, val))) { d = sinl(d); val = ldouble_to_floatx80(d, status); } else { status->float_exception_flags |= float_flag_invalid; val = floatx80_default_nan(status); } Blah. I didn't mean

Re: [Qemu-devel] [PATCH 3/4] target/m68k: add fmod/frem

On 07/03/2017 09:23 AM, Laurent Vivier wrote: Use libm functions fmodl() and remainderl(). The quotient byte of the FPSR is updated with the result of the operation. Signed-off-by: Laurent Vivier --- target/m68k/cpu.h| 1 + target/m68k/fpu_helper.c | 35

Re: [Qemu-devel] [PATCH 2/4] target/m68k: add FPU trigonometric instructions

On 07/03/2017 09:23 AM, Laurent Vivier wrote: +long double floatx80_to_ldouble(floatx80 val) +{ +long double mantissa; +int32_t exp; +uint8_t sign; + +if (floatx80_is_infinity(val)) { +if (floatx80_is_neg(val)) { +return -__builtin_infl(); +} +

Re: [Qemu-devel] postcopy migration hangs while loading virtio state

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Jun 30, 2017 at 05:31:39PM +0100, Dr. David Alan Gilbert wrote: > > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: > > > On 04/26/2017 01:45 PM, Christian Borntraeger wrote: > > > > > > >> Hmm, I have a theory, if the flags field

  1   2   3   4   >