[Qemu-devel] [PATCH v2 3/3] s390x/pci: add iommu replay callback

2017-08-31 Thread Yi Min Zhao
Let's introduce iommu replay callback for s390 pci iommu memory region. Currently we don't need any dma mapping replay. So let it return directly. This implementation will avoid meaningless loops calling translation callback. Reviewed-by: Pierre Morel Reviewed-by:

[Qemu-devel] [PATCH v2 2/3] s390x/pci: fixup ind_offset of msix routing entry

2017-08-31 Thread Yi Min Zhao
The guest uses the mpcifc instruction to register the aibvo of a zpci device, which is the starting offset of indicators in the indicator area and thus remains constant. Each msix vector is an offset from the aibvo. When we map a msix route to an adapter route, we should not modify the starting

[Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-08-31 Thread Yi Min Zhao
PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci device id to find its corresponding zpci device. Signed-off-by: Yi Min Zhao ---

[Qemu-devel] [PATCH v2 0/3] three zpci patches

2017-08-31 Thread Yi Min Zhao
This patch set contains three small zpci patches to fixup different issues. 1) remove zpci idx from msix message, instead we could use PCIDevice's id to find zpci device in kvm_arch_fixup_msi_route() 2) fixup ind_offset calculation for adapter interrupt routing entry 3) introduce our own

[Qemu-devel] [PATCH v6 3/4] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-31 Thread Dou Liyang
As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also be called as node0). eg: ... \ -m 128,slots=3,maxmem=1G \ -numa node -numa node,mem=128M \ But, this makes it hard for QEMU to build a known-to-work ACPI SRAT table. Only fixing it is not

[Qemu-devel] [PATCH v6 4/4] NUMA: Replace MAX_NODES with nb_numa_nodes in for loop

2017-08-31 Thread Dou Liyang
In QEMU, the number of the NUMA nodes is determined by parse_numa_opts(). Then, QEMU uses it for iteration, for example: for (i = 0; i < nb_numa_nodes; i++) However, in memory_region_allocate_system_memory(), it uses MAX_NODES not nb_numa_nodes. So, replace MAX_NODES with nb_numa_nodes to keep

[Qemu-devel] [PATCH v6 0/4]ACPI: NUMA: Fix ACPI SRAT Memory Affinity building

2017-08-31 Thread Dou Liyang
v5 --> v6: - Split the unrelated code into a separate patch [2/4] v4 --> v5: - Replace the original way with Eduardo's method. - Rewrite the testcase. - Drop the SLIT date - 2.11 develop tree is opened, So, Add the third patch for re-posting it. v3 --> v4: -add a new testcase. This

[Qemu-devel] [PATCH v6 1/4] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

2017-08-31 Thread Dou Liyang
From: Eduardo Habkost Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa

[Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment statement of next_base easy to read

2017-08-31 Thread Dou Liyang
It may be hard to read the assignment statement of "next_base", so S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; /next_base = mem_base + mem_len; ... for readability. No functionality change. Signed-off-by: Dou Liyang --- hw/i386/acpi-build.c | 2 +- 1

Re: [Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

2017-08-31 Thread Dou Liyang
Hi, Eduardo At 09/01/2017 05:36 AM, Eduardo Habkost wrote: On Thu, Aug 31, 2017 at 08:04:26PM +0800, Dou Liyang wrote: From: Eduardo Habkost Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m

Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification

2017-08-31 Thread Longpeng (Mike)
Ping... Stefan, Halil, do you have any suggestion ? -- Regards, Longpeng(Mike) On 2017/8/26 15:53, Longpeng(Mike) wrote: > Hi guys, > > I'll work on the virtio-crypto spec with Gonglei together, Because He is > so busy on the inner production project. > > --- > v19 -> v18: > - fix some

Re: [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-31 Thread John Snow
On 08/31/2017 08:27 PM, Philippe Mathieu-Daudé wrote: > On 08/31/2017 09:14 PM, John Snow wrote: >> Signed-off-by: John Snow > > Reviewed-by: Philippe Mathieu-Daudé > TY, and btw the reasoning behind what I went with: Since s->dma_cmd is itself a type

Re: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing

2017-08-31 Thread John Snow
On 08/31/2017 08:27 PM, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20170901001502.29915-1-js...@redhat.com > Subject: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing > Type:

Re: [Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-31 Thread Philippe Mathieu-Daudé
On 08/31/2017 09:14 PM, John Snow wrote: Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- hw/ide/atapi.c| 5 + hw/ide/core.c | 24 +--- hw/ide/trace-events | 3 +++

Re: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing

2017-08-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170901001502.29915-1-js...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH v3 8/9] AHCI: pretty-print FIS to buffer instead of stderr

2017-08-31 Thread John Snow
The current FIS printing routines dump the FIS to screen. adjust this such that it dumps to buffer instead, then use this ability to have FIS dump mechanisms via trace-events instead of compiled defines. Signed-off-by: John Snow --- hw/ide/ahci.c | 28

[Qemu-devel] [PATCH v3 9/9] AHCI: remove DPRINTF macro

2017-08-31 Thread John Snow
Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: John Snow --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 6c98047..14b71a3 100644 ---

[Qemu-devel] [PATCH v3 6/9] AHCI: Replace DPRINTF with trace-events

2017-08-31 Thread John Snow
There are a few hangers-on that will be dealt with individually in forthcoming patches. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: John Snow --- hw/ide/ahci.c | 157 +++- hw/ide/trace-events | 49

[Qemu-devel] [PATCH v3 7/9] AHCI: Rework IRQ constants

2017-08-31 Thread John Snow
Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as it can be multiple at any given time. As

[Qemu-devel] [PATCH v3 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

2017-08-31 Thread John Snow
As part of the ongoing effort to modernize the tracing facilities for the IDE family of devices, remove PRINTFs in the ATAPI device with actual tracing events. Signed-off-by: John Snow --- hw/ide/atapi.c| 64 +--

[Qemu-devel] [PATCH v3 2/9] IDE: Add register hints to tracing

2017-08-31 Thread John Snow
Name the registers for tracing purposes. Signed-off-by: John Snow Reviewed-by: Eric Blake --- hw/ide/core.c | 88 + hw/ide/trace-events | 8 ++--- 2 files changed, 72 insertions(+), 24 deletions(-)

[Qemu-devel] [PATCH v3 3/9] IDE: add tracing for data ports

2017-08-31 Thread John Snow
To be used sparingly, but still interesting in the case of small firmwares designed to reproduce bugs in QEMU IDE. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: John Snow --- hw/ide/core.c | 12 +++- hw/ide/trace-events | 5 + 2 files

[Qemu-devel] [PATCH v3 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-31 Thread John Snow
Remove the DEBUG_IDE preprocessor definition with something more appropriately flexible, using the trace-events subsystem. This will be less prone to bitrot and will more effectively allow us to target just the functions we care about. Signed-off-by: John Snow Reviewed-by:

[Qemu-devel] [PATCH v3 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-31 Thread John Snow
Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c | 24 +--- hw/ide/trace-events | 3 +++ include/hw/ide/internal.h | 6 -- 4 files changed, 25 insertions(+), 13 deletions(-) diff --git a/hw/ide/atapi.c

[Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing

2017-08-31 Thread John Snow
Wherever possible, replace all printfs with proper tracing. In most places I've tried to do a straight replacement, but forthcoming patches may calibrate the tracing to be a little nicer. For now, it's nice to just remove the all-or-nothing tracing. Key: [] : patches are identical [] :

Re: [Qemu-devel] [PATCH 02/14] qlit: move qlit from check-qjson to qobject/

2017-08-31 Thread Eduardo Habkost
On Thu, Aug 24, 2017 at 12:33:38PM +0200, Marc-André Lureau wrote: > Fix code style issues while at it, to please check-patch. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qlit.h | 49 + > qobject/qlit.c | 89

Re: [Qemu-devel] [Qemu devel v7 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-08-31 Thread Alistair Francis
On Thu, Aug 31, 2017 at 4:40 PM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > > On 08/31/2017 08:02 PM, Alistair Francis wrote: >> >> On Wed, Aug 30, 2017 at 7:47 AM, Philippe Mathieu-Daudé >> wrote: >>> >>> On 08/30/2017 09:26 AM, Peter Maydell wrote:

[Qemu-devel] [PATCH v2 4/5] xlnx-zcu102: Add a machine level virtualization property

2017-08-31 Thread Alistair Francis
Add a machine level virtualization property. This defaults to false and can be set to true using this machine command line argument: -machine xlnx-zcu102,virtualization=on This follows what the ARM virt machine does. This property only applies to the ZCU102 machine. The EP108 machine does

Re: [Qemu-devel] [Qemu devel v7 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-08-31 Thread Philippe Mathieu-Daudé
Hi Alistair, On 08/31/2017 08:02 PM, Alistair Francis wrote: On Wed, Aug 30, 2017 at 7:47 AM, Philippe Mathieu-Daudé wrote: On 08/30/2017 09:26 AM, Peter Maydell wrote: On 30 August 2017 at 03:45, Philippe Mathieu-Daudé wrote: I think they might be

[Qemu-devel] [PATCH v2 0/5] Expose the secure and virt properties to the

2017-08-31 Thread Alistair Francis
The EL2 and EL3 work is working well now and interanlly we now have tests that expect to start in EL3 and transition through EL2 to EL1. To make this easy to run let's expose the secure property to the machine and also add a virt property that can enable EL2. This series also does some

[Qemu-devel] [PATCH v2 5/5] xlnx-zcu102: Mark the EP108 machine as deprecated

2017-08-31 Thread Alistair Francis
The EP108 is the same as the ZCU102, mark it as deprecated as we don't need two machines. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zcu102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c index

Re: [Qemu-devel] [PATCH v7 00/11] scripts/qemu.py fixes and cleanups

2017-08-31 Thread Eduardo Habkost
I was going to queue most of this series except patch 02/11 due the "qemu received signal" message log level, but a few conflicts prevent the rest of the series from applying cleanly. Are you planning to send v8? On Fri, Aug 18, 2017 at 07:05:15PM +0200, Amador Pahim wrote: > Changes v1->v2: >

Re: [Qemu-devel] [Qemu devel v7 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-08-31 Thread Alistair Francis
On Wed, Aug 30, 2017 at 7:47 AM, Philippe Mathieu-Daudé wrote: > On 08/30/2017 09:26 AM, Peter Maydell wrote: >> >> On 30 August 2017 at 03:45, Philippe Mathieu-Daudé >> wrote: >>> >>> I think they might be issues if you start QEMU without -serial and then >>>

Re: [Qemu-devel] [Qemu devel v7 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

2017-08-31 Thread Alistair Francis
On Mon, Aug 28, 2017 at 9:38 AM, Subbaraya Sundeep wrote: > Added Sytem register block of Smartfusion2. > This block has PLL registers which are accessed by guest. > > Signed-off-by: Subbaraya Sundeep > --- > hw/misc/Makefile.objs | 1 +

[Qemu-devel] [Bug 1705118] Re: qemu user mode does not support catching SIGSEGV on some architectures

2017-08-31 Thread Bruno Haible
The behaviour in qemu-2.10 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1705118 Title: qemu user mode does not support catching SIGSEGV on some architectures Status

[Qemu-devel] [Bug 1704658] Re: O_CLOEXEC not handled in dup3 system call in user mode

2017-08-31 Thread Bruno Haible
The behaviour in qemu-2.10 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1704658 Title: O_CLOEXEC not handled in dup3 system call in user mode Status in QEMU: New

[Qemu-devel] [Bug 1701971] Re: multithreading not working right under qemu user mode for sh4

2017-08-31 Thread Bruno Haible
This works fine in qemu-2.10: $ ~/inst-qemu/2.10.0/bin/qemu-sh4 test-tls ... Worker 0xecdff4c0 doing value swapping Worker 0xecdff4c0 doing value swapping Worker 0xecdff4c0 before final verify Worker 0xecdff4c0 after final verify Worker 0xecdff4c0 dying. OK ** Changed in: qemu Status:

[Qemu-devel] [Bug 1701974] Re: pwrite does not work right under qemu-sh4

2017-08-31 Thread Bruno Haible
The behaviour in qemu-2.10 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701974 Title: pwrite does not work right under qemu-sh4 Status in QEMU: New Bug

[Qemu-devel] [Bug 1701973] Re: pread does not work right under qemu-sh4

2017-08-31 Thread Bruno Haible
The behaviour in qemu-2.10 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701973 Title: pread does not work right under qemu-sh4 Status in QEMU: New Bug

[Qemu-devel] [Bug 1704638] Re: weak symbol access makes qemu in user mode hang for mips, mips64

2017-08-31 Thread Bruno Haible
The behaviour in qemu-2.10 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1704638 Title: weak symbol access makes qemu in user mode hang for mips, mips64 Status in

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Izik Eidus
On Fri, Sep 1, 2017 at 1:02 AM, Frank Yang wrote: > + our product manager > > If I understand correctly, we will need to reconsider things if I included > any additional technology in my port. However, I didn't include any > additional references/source in my port compared to

[Qemu-devel] [Bug 1701821] Re: floating-point operation bugs in qemu-sh4

2017-08-31 Thread Bruno Haible
With qemu-2.10, all of these tests now pass. Great! ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701821 Title: floating-point operation

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-08-31 Thread Peter Maydell
Can you check whether these work if you copy the QEMU and the dynamically linked target binary into a chroot (which does not have the x86 host ld.so or /etc in it) instead of using QEMU_LD_PREFIX ? There is a problem I've seen before where: 1) QEMU when run with QEMU_LD_PREFIX or -L works by

[Qemu-devel] [Bug 1701808] Re: stack smashing in or after recvmsg system call in aarch64 user mode

2017-08-31 Thread Bruno Haible
The behaviour in qemu-2.10 is the same as in qemu-2.9. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701808 Title: stack smashing in or after recvmsg system call in aarch64 user mode Status in

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-08-31 Thread Bruno Haible
The behaviour in qemu-2.10 is nearly the same as in qemu-2.9. The only difference is a different kind of crash for m68k: $ QEMU_LD_PREFIX=/usr/m68k-linux-gnu QEMU_CPU=m68020 ~/inst-qemu/2.9.0/bin/qemu-m68k hello.m68k qemu: uncaught target signal 4 (Illegal instruction) - core dumped $

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Sergio Andrés Gómez del Real
Hello, Mr. Frank Yang was the guy at Google that introduced the HVF port to Google's Android Emulator QEMU branch. Frank, in this thread we are discussing the licensing issue with the HVF files (their being GPL v2-only). Paolo from Red Hat was asking to Veertu developer Izik Eidus if the code in

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Izik Eidus
On Fri, Sep 1, 2017 at 12:21 AM, Paolo Bonzini wrote: > Il 31 ago 2017 3:54 PM, "Izik Eidus" ha scritto: > > > Izik, Vincent (assuming you are the right person to contact at Google), > > can you reply to Daniel and Stefan? > > > > Hi, > > What I suggest is

Re: [Qemu-devel] [PATCH v5 1/3] hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM

2017-08-31 Thread Eduardo Habkost
On Thu, Aug 31, 2017 at 08:04:26PM +0800, Dou Liyang wrote: > From: Eduardo Habkost > > Currently, Using the fisrt node without memory on the machine makes > QEMU unhappy. With this example command line: > ... \ > -m 1024M,slots=4,maxmem=32G \ > -numa node,nodeid=0 \ >

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Paolo Bonzini
Il 31 ago 2017 3:54 PM, "Izik Eidus" ha scritto: > Izik, Vincent (assuming you are the right person to contact at Google), > can you reply to Daniel and Stefan? > Hi, What I suggest is that we will send our patch' again as gpl2+ and clean the entire stuff to make sure they are

[Qemu-devel] [Bug 997631] Re: Windows 2008R2 very slow cold boot when 4 CPUs

2017-08-31 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1714331] [NEW] Virtual machines not working anymore on 2.10

2017-08-31 Thread Mary Sherman
Public bug reported: Using 2.10, my virtual machine(s) don't work anymore. This happens 100% of the times. - I use QEMU compiling it from source, on Ubuntu 16.04 amd64. This is the configure command: configure --target-list=x86_64-softmmu --enable-debug --enable-gtk --enable-spice

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-08-31 Thread Peter Lieven
Am 29.08.2017 um 02:13 schrieb Michael Roth: > Hi everyone, > > The following new patches are queued for QEMU stable v2.9.1: > > https://github.com/mdroth/qemu/commits/stable-2.9-staging > > The release is planned for 2017-09-07: > > http://wiki.qemu.org/Planning/2.9 > > Please respond here or

Re: [Qemu-devel] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-08-31 Thread Michael Roth
Quoting Michael Roth (2017-08-28 19:13:35) > Hi everyone, > > The following new patches are queued for QEMU stable v2.9.1: > > https://github.com/mdroth/qemu/commits/stable-2.9-staging Thank you for the recommendations. Branch updated with the following additional patches: s390-ccw: Fix

Re: [Qemu-devel] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-08-31 Thread Michael Roth
Quoting Peter Maydell (2017-08-31 12:07:08) > On 31 August 2017 at 17:42, Michael Roth wrote: > > Quoting Thomas Huth (2017-08-28 21:18:20) > >> Not sure, but maybe the following patch should be included, too, since > >> there were some bogus files in the old version of

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-31 Thread Michael Roth
Quoting Thomas Huth (2017-08-29 04:35:22) > On 28.08.2017 09:18, Christian Borntraeger wrote: > > > > > > On 08/25/2017 10:29 AM, Cornelia Huck wrote: > >> On Fri, 25 Aug 2017 10:21:58 +0200 > >> Christian Borntraeger wrote: > >> > >>> On 08/25/2017 09:20 AM, Cornelia

Re: [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

2017-08-31 Thread Alistair Francis
On Wed, Aug 30, 2017 at 3:12 PM, Peter Maydell wrote: > On 30 August 2017 at 19:02, Alistair Francis > wrote: >> Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes >> let's use the already defined MEMTXATTRS_UNSPECIFIED

Re: [Qemu-devel] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 17:42, Michael Roth wrote: > Quoting Thomas Huth (2017-08-28 21:18:20) >> Not sure, but maybe the following patch should be included, too, since >> there were some bogus files in the old version of the U-Boot sources: >> >> 73663d71ef2bab201475d58e

Re: [Qemu-devel] [PATCH] arm_gicv3_kvm: Fix compile warning

2017-08-31 Thread Pranith Kumar
CC'ing stable for 2.10. On Tue, Aug 29, 2017 at 1:32 PM, Pranith Kumar wrote: > Fix the following warning: > > /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is > only applied to the left hand side of this bitwise operator >

Re: [Qemu-devel] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-08-31 Thread Michael Roth
Quoting Thomas Huth (2017-08-28 21:18:20) > On 29.08.2017 02:13, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v2.9.1: > > > > > >

Re: [Qemu-devel] [PATCH 0/2] hyperv: own protocol header instead of kernel's

2017-08-31 Thread Roman Kagan
On Thu, Jul 13, 2017 at 11:15:20PM +0300, Roman Kagan wrote: > Supersede kernel's header for Hyper-V protocol definitions with our own. > The reason is that, since this is a third-party protocol and not a > kernel API, the kernel folks are not happy exposing it in the kernel > uapi. > > The

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

2017-08-31 Thread Philippe Mathieu-Daudé
On 08/31/2017 01:21 PM, Eric Blake wrote: On 08/31/2017 11:18 AM, Daniel P. Berrange wrote: 'qcow' (v1) was also passing last time I checked, though it is waay slow to run compared to qcow2, so I'd understand if you were reluctant to turn that on due to speed Even './check -qcow -g

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

2017-08-31 Thread Kashyap Chamarthy
On Thu, Aug 31, 2017 at 11:06:55AM -0500, Eric Blake wrote: > On 08/31/2017 06:22 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > tests/docker/test-block | 21 + > > 1 file changed, 21 insertions(+) > > create mode 100755

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

2017-08-31 Thread Eric Blake
On 08/31/2017 11:18 AM, Daniel P. Berrange wrote: > > 'qcow' (v1) was also passing last time I checked, though it is > waay slow to run compared to qcow2, so I'd understand if you > were reluctant to turn that on due to speed Even './check -qcow -g quick' might be nicer than nothing, but

Re: [Qemu-devel] [PATCH for-2.11 v4 08/25] s390x: replace cpu_s390x_init() with cpu_generic_init()

2017-08-31 Thread David Hildenbrand
On 31.08.2017 16:04, Igor Mammedov wrote: > On Thu, 31 Aug 2017 15:44:38 +0200 > David Hildenbrand wrote: > >> On 31.08.2017 15:19, Igor Mammedov wrote: >>> cpu_s390x_init() is used only *-user targets indirectly >>> via cpu_init() macro and has a hack to assign ids to created

Re: [Qemu-devel] [PATCH 2/2] .dir-locals.el: add json schema to auto-mode

2017-08-31 Thread Eric Blake
On 08/31/2017 08:14 AM, Marc-André Lureau wrote: > The json schema is more friendly to python-mode since it doesn't > follow strictly json (comments to start with). I found that hard to read, and missing a key word of 'emacs'. Maybe reword it as: Under emacs, our QAPI files (.json suffix) are

Re: [Qemu-devel] [PATCH v2 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-31 Thread Laszlo Ersek
On 08/31/17 01:25, John Snow wrote: > CCing Laszlo Ersek literally just for laughs, as he is the most > entertaining language lawyer I know of. > > Laszlo, please feel free to ignore this if you don't care :P > > On 08/29/2017 11:14 PM, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

2017-08-31 Thread Daniel P. Berrange
On Thu, Aug 31, 2017 at 07:22:10PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/docker/test-block | 21 + > 1 file changed, 21 insertions(+) > create mode 100755 tests/docker/test-block > > diff --git a/tests/docker/test-block

Re: [Qemu-devel] [PATCH 1/2] .dir-locals.el: add makefiles to auto-mode

2017-08-31 Thread Eric Blake
On 08/31/2017 08:14 AM, Marc-André Lureau wrote: > QEMU uses non-conventional makefile filenames. Ease the life of emacs > developpers a bit by appending to the auto-mode-alist. s/emacs developpers/developers using emacs/ (typo, and avoids an ambiguity on whether you are describing people that

Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu number/address handling

2017-08-31 Thread Cornelia Huck
On Thu, 31 Aug 2017 18:03:52 +0200 Igor Mammedov wrote: > On Thu, 31 Aug 2017 16:35:13 +0200 > Cornelia Huck wrote: > > > On Wed, 30 Aug 2017 19:05:56 +0200 > > David Hildenbrand wrote: > > > > > Some time ago we discussed that

Re: [Qemu-devel] [PULL 00/29] Code cleanup patches

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 11:34, Marc-André Lureau wrote: > The following changes since commit 1201d308519f1e915866d7583d5136d03cc1d384: > > slirp: fix clearing ifq_so from pending packets (2017-08-30 23:14:34 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread Cornelia Huck
On Thu, 31 Aug 2017 17:33:13 +0200 David Hildenbrand wrote: > On 31.08.2017 17:07, Cornelia Huck wrote: > > If we know that this can't work, it makes sense to stop immediately, no? > > Hmm, like that than? > > diff --git a/hw/s390x/s390-virtio-ccw.c

Re: [Qemu-devel] [PATCH v2 3/3] docker: Add test-block

2017-08-31 Thread Eric Blake
On 08/31/2017 06:22 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/docker/test-block | 21 + > 1 file changed, 21 insertions(+) > create mode 100755 tests/docker/test-block > +cd "$BUILD_DIR" > + > +build_qemu --target-list=x86_64-softmmu >

Re: [Qemu-devel] [PATCH v2 3/5] qapi: Use OrderedDict from standard library if available

2017-08-31 Thread Eric Blake
On 08/31/2017 09:24 AM, Daniel P. Berrange wrote: > The OrderedDict class appeared in the 'collections' module > from python 2.7 onwards, so use that in preference to our > local backport if available. Since we're now using argparse.py as a third-party import (commit 47e1cb1f) also for the sake

Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu number/address handling

2017-08-31 Thread Igor Mammedov
On Thu, 31 Aug 2017 16:35:13 +0200 Cornelia Huck wrote: > On Wed, 30 Aug 2017 19:05:56 +0200 > David Hildenbrand wrote: > > > Some time ago we discussed that using "id" as property name is not the > > right thing to do, as it is a reserved property for

Re: [Qemu-devel] [PATCH v5 04/12] tests: Add vm test lib

2017-08-31 Thread Philippe Mathieu-Daudé
Hi Fam, On 08/31/2017 03:42 AM, Fam Zheng wrote: This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. Looking at this project: https://www.packer.io/docs/builders/qemu.html Maybe

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-31 Thread Jeff Cody
On Thu, Aug 31, 2017 at 04:39:49PM +0100, Stefan Hajnoczi wrote: > On Wed, Aug 30, 2017 at 06:40:29PM -0400, John Snow wrote: > > > > > > On 08/30/2017 06:35 PM, Eric Blake wrote: > > > On 08/30/2017 05:28 PM, John Snow wrote: > > > > > >> I'm a little iffy on this patch; I know that ./check

Re: [Qemu-devel] RFC: changing ROM bundling in tar dists for releases

2017-08-31 Thread Philippe Mathieu-Daudé
On 08/31/2017 09:29 AM, Daniel P. Berrange wrote: [...]> There are the following options I see 1. Keep existing dist, and add a new minimal one qemu-X.Y.Z.tar.bz2 - qemu source + bundled ROMS + libs qemu-minimal-X.Y.Z.tar.bz2 - qemu source only Least impact for

Re: [Qemu-devel] [PATCH v3 4/5] qemu-iotests: make python tests attempt to leave intermediate files

2017-08-31 Thread Stefan Hajnoczi
On Wed, Aug 30, 2017 at 06:40:29PM -0400, John Snow wrote: > > > On 08/30/2017 06:35 PM, Eric Blake wrote: > > On 08/30/2017 05:28 PM, John Snow wrote: > > > >> I'm a little iffy on this patch; I know that ./check can take care of > >> our temp files for us now, but because each python test is

Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

2017-08-31 Thread David Hildenbrand
> static void test_drive_del_device_del(void) > { > +char *args; > + > /* Start with a drive used by a device that unplugs instantaneously */ > -qtest_start("-drive if=none,id=drive0,file=null-co://,format=raw" > -" -device virtio-scsi-pci" > -"

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread David Hildenbrand
On 31.08.2017 17:07, Cornelia Huck wrote: > On Thu, 31 Aug 2017 17:03:21 +0200 > David Hildenbrand wrote: > >> On 31.08.2017 16:41, Cornelia Huck wrote: >>> On Wed, 30 Aug 2017 19:05:58 +0200 >>> David Hildenbrand wrote: >>> Specifying more than 1 CPU

Re: [Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals

2017-08-31 Thread Laszlo Ersek
On 08/31/17 10:42, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> - Original Message - >>> Marc-André Lureau writes: >>> Hi - Original Message - > Marc-André Lureau

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

2017-08-31 Thread Philippe Mathieu-Daudé
On 08/31/2017 06:43 AM, Thomas Huth wrote: On 31.08.2017 11:36, Marc-André Lureau wrote: Hi On Thu, Aug 31, 2017 at 7:20 AM Thomas Huth > wrote: On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: > Suggested-by: Peter Maydell

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

2017-08-31 Thread Thomas Huth
On 31.08.2017 17:20, Philippe Mathieu-Daudé wrote: > On 08/31/2017 02:19 AM, Thomas Huth wrote: >> On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: > [...]>> +Chardev *serial_chr_nonnull(Chardev *chr) >>> +{ >>> +    static int serial_id; >>> +    char *label; >>> + >>> +    label =

Re: [Qemu-devel] [PATCH v2 4/4] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

2017-08-31 Thread Daniel P. Berrange
On Thu, Aug 31, 2017 at 10:17:43AM -0500, Eric Blake wrote: > On 08/31/2017 06:05 AM, Daniel P. Berrange wrote: > > Instead of sector offset, take the bytes offset when encrypting > > or decrypting data. > > > > Signed-off-by: Daniel P. Berrange > > --- > > block/crypto.c

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

2017-08-31 Thread Philippe Mathieu-Daudé
On 08/31/2017 02:19 AM, Thomas Huth wrote: On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: [...]>> +Chardev *serial_chr_nonnull(Chardev *chr) +{ +static int serial_id; +char *label; + +label = g_strdup_printf("discarding-serial%d", serial_id++); +chr = qemu_chr_new(label,

Re: [Qemu-devel] [PATCH v8 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

2017-08-31 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Aug 25, 2017 at 08:34:54PM -0400, Emilio G. Cota wrote: >> On Sun, Jul 30, 2017 at 17:08:18 +0300, Lluís Vilanova wrote: >> > The hypertrace channel allows guest code to emit events in QEMU (the host) >> > using >> > its tracing infrastructure (see

Re: [Qemu-devel] [PATCH v2 4/4] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

2017-08-31 Thread Eric Blake
On 08/31/2017 06:05 AM, Daniel P. Berrange wrote: > Instead of sector offset, take the bytes offset when encrypting > or decrypting data. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 8 > block/qcow.c | 7 +-- >

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

2017-08-31 Thread Philippe Mathieu-Daudé
On 08/31/2017 07:28 AM, Peter Maydell wrote: On 31 August 2017 at 04:53, Philippe Mathieu-Daudé wrote: Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- include/hw/char/serial.h | 1 + hw/char/serial.c

Re: [Qemu-devel] [PATCH v2 3/4] block: convert crypto driver to bdrv_co_preadv|pwritev

2017-08-31 Thread Eric Blake
On 08/31/2017 06:05 AM, Daniel P. Berrange wrote: > Make the crypto driver implement the bdrv_co_preadv|pwritev > callbacks, and also use bdrv_co_preadv|pwritev for I/O > with the protocol driver beneath. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 103

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread Cornelia Huck
On Thu, 31 Aug 2017 17:03:21 +0200 David Hildenbrand wrote: > On 31.08.2017 16:41, Cornelia Huck wrote: > > On Wed, 30 Aug 2017 19:05:58 +0200 > > David Hildenbrand wrote: > > > >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the > >>

Re: [Qemu-devel] [PATCH v1 08/11] s390x: allow only 1 CPU with TCG

2017-08-31 Thread David Hildenbrand
On 31.08.2017 16:41, Cornelia Huck wrote: > On Wed, 30 Aug 2017 19:05:58 +0200 > David Hildenbrand wrote: > >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the >> guest tries to bring these CPUs up but fails), because we don't support >> multiple CPUs on s390x

Re: [Qemu-devel] [PATCH v2 2/4] block: use BDRV_SECTOR_SIZE in crypto driver

2017-08-31 Thread Eric Blake
On 08/31/2017 06:05 AM, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal

Re: [Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-31 Thread Kamil Rytarowski
On 31.08.2017 16:27, Peter Maydell wrote: > On 31 August 2017 at 15:04, Kamil Rytarowski wrote: >> Could we please add SmartOS image. It's an Illumos distribution, >> previously known as OpenSolaris. >> >> qemu is actively maintained for SmartOS in pkgsrc. >> >> The latest build

Re: [Qemu-devel] [PULL 00/11] NBD patches for 2.11

2017-08-31 Thread Peter Maydell
On 30 August 2017 at 19:07, Eric Blake wrote: > The following changes since commit 1ab5eb4efb91a3d4569b0df6e824cc08ab4bd8ec: > > Update version for v2.10.0 release (2017-08-30 17:02:54 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/ericb.git

Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches

2017-08-31 Thread Peter Maydell
On 31 August 2017 at 09:21, Stefan Hajnoczi wrote: > The following changes since commit 248b23735645f7cbb503d9be6f5bf825f2a603ab: > > Update version for v2.10.0-rc4 release (2017-08-24 17:34:26 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu number/address handling

2017-08-31 Thread Cornelia Huck
On Thu, 31 Aug 2017 16:41:47 +0200 David Hildenbrand wrote: > On 31.08.2017 16:35, Cornelia Huck wrote: > > On Wed, 30 Aug 2017 19:05:56 +0200 > > David Hildenbrand wrote: > > > >> Some time ago we discussed that using "id" as property name is not the > >>

Re: [Qemu-devel] [PATCH v5 00/12] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-31 Thread Fam Zheng
On Thu, 08/31 16:04, Kamil Rytarowski wrote: > Could we please add SmartOS image. It's an Illumos distribution, > previously known as OpenSolaris. > > qemu is actively maintained for SmartOS in pkgsrc. > > The latest build fixes were introduced less than a week ago. >

Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside machine state

2017-08-31 Thread Thomas Huth
On 31.08.2017 16:36, David Hildenbrand wrote: > On 31.08.2017 16:31, Thomas Huth wrote: >> On 31.08.2017 16:23, David Hildenbrand wrote: >>> > +struct S390CPU; You define a "struct S390CPU" here ... > typedef struct S390CcwMachineState { > /*< private >*/ >

Re: [Qemu-devel] [PATCH v1 00/11] next round of s390x cleanups

2017-08-31 Thread Cornelia Huck
On Wed, 30 Aug 2017 19:05:50 +0200 David Hildenbrand wrote: > No new functionality, only cleanups, some of the discussed during the last > round of cleanups. > > Not sure if the first two patches should be sent separatly? Anyhow, they > are most probably not worth the trouble

Re: [Qemu-devel] [PATCH v1 06/11] target/s390x: cleanup cpu number/address handling

2017-08-31 Thread David Hildenbrand
On 31.08.2017 16:35, Cornelia Huck wrote: > On Wed, 30 Aug 2017 19:05:56 +0200 > David Hildenbrand wrote: > >> Some time ago we discussed that using "id" as property name is not the >> right thing to do, as it is a reserved property for other devices. >> >> Switch to the term

  1   2   3   4   >