Re: [Qemu-devel] [PATCH 0/5] Initial write support for MTP objects

Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20170914053148.2512-1-...@redhat.com Type: series Subject: [Qemu-devel] [PATCH 0/5] Initial write support for MTP objects === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the

Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

On Wed, Sep 13, 2017 at 09:58:04AM +0200, Cornelia Huck wrote: > On Tue, 12 Sep 2017 12:17:51 +0200 > Marc-André Lureau wrote: > > > Hi Peter > > > > On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > > > On Mon, Sep 11, 2017 at 03:26:27PM +0200,

[Qemu-devel] [PATCH 1/5] usb-mtp: Add one more argument when building results

From: Bandan Das The response to a SendObjectInfo consists of the storageid, parent obejct handle anad the handle reserved for the new incoming object Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 50 +++--- 1

[Qemu-devel] [PATCH 4/5] usb-mtp: Introduce write support for MTP objects

From: Bandan Das Allow write operations on behalf of the initiator. The precursor to write is the sending of the write metadata that consists of the ObjectInfo dataset. This patch introduces a flag that is set when the responder is ready to receive write data based on a

[Qemu-devel] [PATCH 2/5] usb-mtp: print parent path in IN_IGNORED trace fn

From: Bandan Das Fix a possible null dereference when deleting a folder and its contents. An ignored event might be received for its contents after the parent folder is deleted which will return a null object. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c

[Qemu-devel] [PATCH 0/5] Initial write support for MTP objects

These patches implement write support for Qemu's MTP emulation. Simple tests such as delete/move/edit/copy work ok. Current issues/TODO: - File transfers > 4GB has not been tested and will probably not work - Some (or most) MTP clients don't advertise hidden files and folders (names that start

[Qemu-devel] [PATCH 5/5] usb-mtp: Advertise SendObjectInfo for write support

From: Bandan Das This patch implements a dummy ObjectInfo structure so that it's easy to typecast the incoming data. If the metadata is valid, write_pending is set. Also, the incoming filename is utf-16, so, instead of depending on external libraries, just implement a simple

[Qemu-devel] [PATCH 3/5] usb-mtp: Support delete of mtp objects

From: Bandan Das This is required because write of existing objects by the initiator is acheived by making a temporary buffer with the new changes, deleting the old file and then writing a new file with the same name. Note that this operation will fail as of this patch since

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Mon, Sep 11, 2017 at 10:40:10AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 06, 2017 at 01:57:48PM +0530, Nikunj A Dadhania wrote: >> >> When the user does not provide the cpu

Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/

>> --- a/accel/stubs/Makefile.objs >> +++ b/accel/stubs/Makefile.objs >> @@ -1,2 +1,3 @@ >> obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o >> obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o >> +obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o > > Reviewed-by: Stefan Weil Thanks! > >

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Sundeep, On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: Added Sytem register block of Smartfusion2. This block has PLL registers which are accessed by guest. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis ---

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1037675 Title: Guest

Re: [Qemu-devel] [PATCH v7 31/38] libqtest: Merge qtest_clock_*() with clock_*()

On 12.09.2017 15:35, Eric Blake wrote: > On 09/12/2017 05:45 AM, Thomas Huth wrote: >> On 11.09.2017 19:20, Eric Blake wrote: >>> Maintaining two layers of libqtest APIs, one that takes an explicit >>> QTestState object, and the other that uses the implicit global_qtest, >>> is annoying. In the

Re: [Qemu-devel] [PATCH v2] tests: Introduce generic device hot-plug/hot-unplug functions

On Wed, Sep 13, 2017 at 08:40:54PM +0200, Thomas Huth wrote: > A lot of tests provide code for adding and removing a device via the > device_add and device_del QMP commands. Maintaining this code in so many > places is cumbersome and error-prone (some of the code parts check the > responses for

Re: [Qemu-devel] [Qemu devel v8 PATCH 0/5] Add support for Smartfusion2 SoC

On 09/08/2017 04:24 AM, sundeep subbaraya wrote: Hi Phillipe, On Fri, Sep 8, 2017 at 3:14 AM, Philippe Mathieu-Daudé > wrote: Hi Subbaraya, very good work! On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: Hi Qemu-devel,

Re: [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration

On Wed, Sep 13, 2017 at 07:58:23PM +0200, Laurent Vivier wrote: > On 13/09/2017 19:11, Mark Cave-Ayland wrote: > > On 13/09/17 08:12, David Gibson wrote: > > > >> This is subtly incorrect. It sets the DECR on load to exactly the > >> value that was saved. That effectively means that the DECR is

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] ppc: add CPU IRQ state to PPC VMStateDescription

On Wed, Sep 13, 2017 at 07:13:09PM +0200, Greg Kurz wrote: > On Wed, 13 Sep 2017 17:44:54 +0100 > Mark Cave-Ayland wrote: > > > On 13/09/17 07:02, David Gibson wrote: > > > > >>> Alexey - do you recall from your analysis why these fields were no > > >>> longer

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] ppc: add CPU IRQ state to PPC VMStateDescription

On Wed, Sep 13, 2017 at 05:44:54PM +0100, Mark Cave-Ayland wrote: > On 13/09/17 07:02, David Gibson wrote: > > >>> Alexey - do you recall from your analysis why these fields were no > >>> longer deemed necessary, and how your TCG tests were configured? > >> > >> I most certainly did not do

Re: [Qemu-devel] [PATCH 3/4] ppc: add CPU access_type into the migration stream

On Wed, Sep 13, 2017 at 06:17:21PM +0100, Mark Cave-Ayland wrote: > On 13/09/17 08:19, David Gibson wrote: > > >> When pausing a VM, does execution stop at the end of the current TB > >> rather than immediately? If so, perhaps someone could confirm that > >> guarantee is good enough for

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

Hi Igor, awesome clean refactor! just 1 comment inlined. On 09/13/2017 01:04 PM, Igor Mammedov wrote: there are 2 use cases to deal with: 1: fixed CPU models per board/soc 2: boards with user configurable cpu_model and fallback to default cpu_model if user hasn't specified one

Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/

Am 14.09.2017 um 00:11 schrieb Philippe Mathieu-Daudé: > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > --- > Makefile.target | 1 - > hax-stub.c => accel/stubs/hax-stub.c | 0 > accel/stubs/Makefile.objs

Re: [Qemu-devel] [PATCH] target-i386: enable kvm_pv_unhalt by default

On Wed, Sep 13, 2017 at 04:39:58PM +0200, Alexander Graf wrote: > Commit f010bc643a (target-i386: add feature kvm_pv_unhalt) introduced the > kvm_pv_unhalt feature but didn't enable it by default. > > Without kvm_pv_unhalt we see a measurable degradation in scheduling > performance, so enabling

Re: [Qemu-devel] [virtio-dev] Re: [RFC 0/8] virtio-crypto: add multiplexing mode support

On 2017/9/14 2:14, Halil Pasic wrote: > > > On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: >> *NOTE* >> The code realization is based on the latest virtio crypto spec: >> [PATCH v19 0/2] virtio-crypto: virtio crypto device specification >>

Re: [Qemu-devel] [PATCH v4 1/4] hmp: fix "dump-quest-memory" segfault (ppc)

On Wed, Sep 13, 2017 at 04:20:33PM +0200, Laurent Vivier wrote: > Running QEMU with > qemu-system-ppc64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in segfault > > Fix by checking if we have CPU, and exit with > error if there is no CPU: > >

Re: [Qemu-devel] [Qemu-block] [PATCH] rbd: Detect rbd image resizes and propagate them

On 09/13/2017 05:36 PM, Adam Wolfe Gordon via Qemu-devel wrote: > On Wed, Sep 13, 2017 at 2:53 PM, John Snow wrote: >> On 09/13/2017 12:44 PM, Adam Wolfe Gordon wrote: >>> Register a watcher with rbd so that we get notified when an image is >>> resized. Propagate resizes to

Re: [Qemu-devel] [libvirt] QEMU -M nvdimm=on and hotplug

On 09/13/17 17:28 +0200, Michal Privoznik wrote: > > BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on > and guest migrated happily. So looks like guest ABI is stable (or at > least stable enough not to crash). But since ACPI table is changed I > doubt that. One example

Re: [Qemu-devel] [PATCH v7 12/20] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

On 09/12/2017 04:31 PM, Eric Blake wrote: > Thanks to recent cleanups, all callers were scaling a return value > of sectors into bytes; do the scaling internally instead. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v7 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

On 09/12/2017 04:31 PM, Eric Blake wrote: > Thanks to recent cleanups, most callers were scaling a return value > of sectors into bytes (the exception, in qcow2-bitmap, will be > converted to byte-based iteration later). Update the interface to > do the scaling internally instead. > > In

Re: [Qemu-devel] [PATCH v7 07/20] dirty-bitmap: Track bitmap size by bytes

On 09/12/2017 04:31 PM, Eric Blake wrote: > We are still using an internal hbitmap that tracks a size in sectors, > with the granularity scaled down accordingly, because it lets us > use a shortcut for our iterators which are currently sector-based. > But there's no reason we can't track the

Re: [Qemu-devel] [PATCH v7 06/20] dirty-bitmap: Change bdrv_dirty_bitmap_size() to report bytes

On 09/12/2017 04:31 PM, Eric Blake wrote: > We're already reporting bytes for bdrv_dirty_bitmap_granularity(); > mixing bytes and sectors in our return values is a recipe for > confusion. A later cleanup will convert dirty bitmap internals > to be entirely byte-based, but in the meantime, we

Re: [Qemu-devel] [PATCH 05/19] nvic: Implement AIRCR changes for v8M

On 09/12/2017 11:13 AM, Peter Maydell wrote: > The Application Interrupt and Reset Control Register has some changes > for v8M: > * new bits SYSRESETREQS, BFHFNMINS and PRIS: these all have >real state if the security extension is implemented and otherwise >are constant > * the PRIGROUP

Re: [Qemu-devel] [PATCH v7 05/20] dirty-bitmap: Check for size query failure during truncate

On 09/12/2017 04:31 PM, Eric Blake wrote: > We've previously fixed several places where we failed to account > for possible errors from bdrv_nb_sectors(). Fix another one by > making bdrv_dirty_bitmap_truncate() report the error rather then > silently resizing bitmaps to -1. Then adjust the

Re: [Qemu-devel] [PATCH 04/19] nvic: Add cached vectpending_prio state

On 09/12/2017 11:13 AM, Peter Maydell wrote: > Instead of looking up the pending priority > in nvic_pending_prio(), cache it in a new state struct > field. The calculation of the pending priority given > the interrupt number is more complicated in v8M with > the security extension, so the caching

Re: [Qemu-devel] [PATCH v4 3/3] Test for full Backup

On 09/08/2017 12:41 PM, Ishani Chugh wrote: > This patch is the test for full backup implementation in Backup tool. > The test employs two basic substests: > 1) Backing up an empty guest and comparing it with base image. > 2) Writing a pattern to the guest, creating backup and comparing >

Re: [Qemu-devel] [PATCH 02/19] nvic: Add banked exception states

On 09/12/2017 11:13 AM, Peter Maydell wrote: > For the v8M security extension, some exceptions must be banked > between security states. Add the new vecinfo array which holds > the state for the banked exceptions and migrate it if the > CPU the NVIC is attached to implements the security

Re: [Qemu-devel] [RFC PATCH] spapr_pci: make index property mandatory

On Mon, Sep 11, 2017 at 01:35:03PM +0200, Greg Kurz wrote: > Creating several PHBs without index property confuses the DRC code > and causes issues: > - only the first index-less PHB is functional, the other ones will > silently ignore hotplugging of PCI devices > - QEMU will even terminate if

Re: [Qemu-devel] [PATCH 01/19] target/arm: Implement MSR/MRS access to NS banked registers

On 09/12/2017 11:13 AM, Peter Maydell wrote: > In v8M the MSR and MRS instructions have extra register value > encodings to allow secure code to access the non-secure banked > version of various special registers. > > (We don't implement the MSPLIM_NS or PSPLIM_NS aliases, because > we don't

Re: [Qemu-devel] Trying to use ccid-card-emulated

Hi Patrick On Wed, Sep 6, 2017 at 5:04 PM Patrick Vacek wrote: > Hello, > > I'm trying to emulate a smartcard. I found section 4 of docs/ccid.txt, > which appears to do exactly what I'm interested in. However, that > document is a few years old and references

Re: [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests

On 09/13/2017 05:06 PM, Paolo Bonzini wrote: > On 13/09/2017 09:59, Fam Zheng wrote: >> On Wed, 09/13 08:47, Thomas Huth wrote: >>> Meta comment: Could we maybe also rename "tests/qemu-iotests" to >>> "tests/iotests" ? The "qemu" prefix sounds always very superfluous to me >>> here... >> >> Sounds

[Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/

Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- Makefile.target | 1 - hax-stub.c => accel/stubs/hax-stub.c | 0 accel/stubs/Makefile.objs| 1 + 3 files changed, 1 insertion(+), 1 deletion(-) rename

Re: [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests

On 13/09/2017 09:59, Fam Zheng wrote: > On Wed, 09/13 08:47, Thomas Huth wrote: >> Meta comment: Could we maybe also rename "tests/qemu-iotests" to >> "tests/iotests" ? The "qemu" prefix sounds always very superfluous to me >> here... > > Sounds good, and saves typing for when this path is

Re: [Qemu-devel] [Qemu-block] [PATCH] rbd: Detect rbd image resizes and propagate them

On Wed, Sep 13, 2017 at 3:21 PM, Jason Dillaman wrote: > On Wed, 2017-09-13 at 10:44 -0600, Adam Wolfe Gordon wrote: >> +parent = bs->inherits_from; >> +if (parent == NULL) { >> +error_report("bs %s does not have parent", >> bdrv_get_device_or_node_name(bs));

Re: [Qemu-devel] [Qemu-block] [PATCH] rbd: Detect rbd image resizes and propagate them

On Wed, Sep 13, 2017 at 2:53 PM, John Snow wrote: > On 09/13/2017 12:44 PM, Adam Wolfe Gordon wrote: >> Register a watcher with rbd so that we get notified when an image is >> resized. Propagate resizes to parent block devices so that guest devices >> get resized without user

Re: [Qemu-devel] [PATCH] osdep: Fix ROUND_UP(64-bit, 32-bit)

On 13/09/2017 23:03, Eric Blake wrote: > When using bit-wise operations that exploit the power-of-two > nature of the second argument of ROUND_UP(), we still need to > ensure that the mask is as wide as the first argument (done > by using addition of 0 to force proper arithmetic promotion). >

Re: [Qemu-devel] [Qemu-block] [PATCH] rbd: Detect rbd image resizes and propagate them

On Wed, 2017-09-13 at 10:44 -0600, Adam Wolfe Gordon wrote: > Register a watcher with rbd so that we get notified when an image is > resized. Propagate resizes to parent block devices so that guest devices > get resized without user intervention. > > Signed-off-by: Adam Wolfe Gordon

Re: [Qemu-devel] [PATCH] hw/isa/pc87312: Mark the device with user_creatable = false

Le 13/09/2017 à 11:07, Thomas Huth a écrit : QEMU currently aborts if you try to use the device at the command line: $ ppc64-softmmu/qemu-system-ppc64 -S -machine prep -device pc87312 Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-ppc64: -device pc87312: Device

Re: [Qemu-devel] [PATCH v4 00/23] make bdrv_get_block_status byte-based

On 09/13/2017 11:03 AM, Eric Blake wrote: > There are patches floating around to add NBD_CMD_BLOCK_STATUS, > but NBD wants to report status on byte granularity (even if the > reporting will probably be naturally aligned to sectors or even > much higher levels). I've therefore started the task of

[Qemu-devel] [PATCH] osdep: Fix ROUND_UP(64-bit, 32-bit)

When using bit-wise operations that exploit the power-of-two nature of the second argument of ROUND_UP(), we still need to ensure that the mask is as wide as the first argument (done by using addition of 0 to force proper arithmetic promotion). Unpatched, ROUND_UP(2ULL*1024*1024*1024*1024, 512)

Re: [Qemu-devel] [Qemu-block] [PATCH] rbd: Detect rbd image resizes and propagate them

On 09/13/2017 12:44 PM, Adam Wolfe Gordon wrote: > Register a watcher with rbd so that we get notified when an image is > resized. Propagate resizes to parent block devices so that guest devices > get resized without user intervention. > > Signed-off-by: Adam Wolfe Gordon

Re: [Qemu-devel] [PATCH 2/2] Add --firmwarepath to configure

On 13/09/2017 14:09, Gerd Hoffmann wrote: > Add a firmware path config option to configure. Multiple directories > are accepted, with the usual colon as separator. Default value is > ${prefix}/share/qemu-firmware. The path is searched in addition to the > current search path (typically

[Qemu-devel] [Bug 932490] Re: Qemu fails on -fda /dev/fd0 when no medium is present

Sorry, it has been more than five years and I don't have a system with a floppy disk to test anymore. Best, Herbert -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/932490 Title: Qemu fails on -fda

Re: [Qemu-devel] [PATCH v4 21/23] block: Align block status requests

On 09/13/2017 02:26 PM, Eric Blake wrote: > On 09/13/2017 11:03 AM, Eric Blake wrote: >> Any device that has request_alignment greater than 512 should be >> unable to report status at a finer granularity; it may also be >> simpler for such devices to be guaranteed that the block layer >> has

Re: [Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them

Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them Message-id: 20170913164424.32129-1-...@digitalocean.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them Message-id: 20170913164424.32129-1-...@digitalocean.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH] rbd: Detect rbd image resizes and propagate them

Register a watcher with rbd so that we get notified when an image is resized. Propagate resizes to parent block devices so that guest devices get resized without user intervention. Signed-off-by: Adam Wolfe Gordon --- Hello! We are using this patch in production at

Re: [Qemu-devel] [PATCH v4 2/3] backup: Adds Backup Tool

On 09/11/2017 01:02 AM, Fam Zheng wrote: > On Fri, 09/08 22:11, Ishani Chugh wrote: >> +def build_parser(): >> +backup_tool = BackupTool() >> +parser = ArgumentParser() >> +subparsers = parser.add_subparsers(title='Subcommands', >> +

Re: [Qemu-devel] [PATCH v4 21/23] block: Align block status requests

On 09/13/2017 11:03 AM, Eric Blake wrote: > Any device that has request_alignment greater than 512 should be > unable to report status at a finer granularity; it may also be > simpler for such devices to be guaranteed that the block layer > has rounded things out to the granularity boundary (the

Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390

On 09/13/2017 03:00 PM, Thomas Huth wrote: On 12.09.2017 16:26, Farhan Ali wrote: These patches wire up the virtio-gpu device for CCW bus for S390. For the S390 architecture which does not natively support any graphics device, virtio gpu in 2D mode could be used to emulate a simple graphics

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driver

On 09/13/2017 06:21 AM, Thomas Huth wrote: > Remove the unnecessary home-grown redefinition of the assert() macro here, > and remove the unusable debug code at the end of the checkpoint() function. > The code there uses assert() with side-effects (assignment to the "mapping" > variable), which

Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390

On 12.09.2017 16:26, Farhan Ali wrote: > These patches wire up the virtio-gpu device for CCW bus for > S390. > > For the S390 architecture which does not natively support any graphics > device, virtio gpu in 2D mode could be used to emulate a simple graphics > card and use VNC as the display. >

[Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

With the attached patch, qemu-sh4-static now works for file: root@debian:/# /usr/bin/qemu-sh4-static.new2 /usr/bin/file /bin/bash /bin/bash: ELF 32-bit LSB executable, Renesas SH, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2,

[Qemu-devel] [PATCH v2] tests: Introduce generic device hot-plug/hot-unplug functions

A lot of tests provide code for adding and removing a device via the device_add and device_del QMP commands. Maintaining this code in so many places is cumbersome and error-prone (some of the code parts check the responses for device deletion in an incorrect way, for example, we've got to deal

[Qemu-devel] [PATCH 13/18] block/mirror: Keep write perm for pending writes

The owner of the mirror BDS might retire its write permission; but there may still be pending mirror operations so the mirror BDS cannot necessarily retire its write permission for its child then. Signed-off-by: Max Reitz --- block/mirror.c | 6 -- 1 file changed, 4

[Qemu-devel] [PATCH 17/18] qemu-io: Add background write

Add a new parameter -B to qemu-io's write command. When used, qemu-io will not wait for the result of the operation and instead execute it in the background. Signed-off-by: Max Reitz --- qemu-io-cmds.c | 83 +- 1 file

[Qemu-devel] [PATCH 16/18] block/mirror: Add copy mode QAPI interface

This patch allows the user to specify whether to use active or only passive mode for mirror block jobs. Currently, this setting will remain constant for the duration of the entire block job. Signed-off-by: Max Reitz --- qapi/block-core.json | 11 +--

[Qemu-devel] [PATCH 18/18] iotests: Add test for active mirroring

Signed-off-by: Max Reitz --- tests/qemu-iotests/151 | 111 + tests/qemu-iotests/151.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 117 insertions(+) create mode 100755 tests/qemu-iotests/151 create mode

[Qemu-devel] [PATCH 10/18] block/mirror: Make source the file child

Regarding the source BDS, the mirror BDS is arguably a filter node. Therefore, the source BDS should be its "file" child. Signed-off-by: Max Reitz --- block/mirror.c | 127 ++--- block/qapi.c | 25 ++---

[Qemu-devel] [PATCH 14/18] block/mirror: Distinguish active from passive ops

Currently, the mirror block job only knows passive operations. But once we introduce active writes, we need to distinguish between the two; for example, mirror_wait_for_free_in_flight_slot() should wait for a passive operation because active writes will not use the same in-flight slots.

[Qemu-devel] [PATCH 15/18] block/mirror: Add active mirroring

This patch implements active synchronous mirroring. In active mode, the passive mechanism will still be in place and is used to copy all initially dirty clusters off the source disk; but every write request will write data both to the source and the target disk, so the source cannot be dirtied

[Qemu-devel] [PATCH 06/18] block/mirror: Use CoQueue to wait on in-flight ops

Attach a CoQueue to each in-flight operation so if we need to wait for any we can use it to wait instead of just blindly yielding and hoping for some operation to wake us. A later patch will use this infrastructure to allow requests accessing the same area of the virtual disk to specifically wait

[Qemu-devel] [PATCH 12/18] block/dirty-bitmap: Add bdrv_dirty_iter_next_area

This new function allows to look for a consecutively dirty area in a dirty bitmap. Signed-off-by: Max Reitz --- include/block/dirty-bitmap.h | 2 ++ block/dirty-bitmap.c | 52 2 files changed, 54 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v1 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

On 13.09.2017 14:09, David Hildenbrand wrote: > On 12.09.2017 16:26, Farhan Ali wrote: >> Wire up the virtio-gpu device for the CCW bus. The virtio-gpu >> is a virtio-1 device, so disable revision 0. >> >> Signed-off-by: Farhan Ali >> Acked-by: Christian Borntraeger

[Qemu-devel] [PATCH 11/18] hbitmap: Add @advance param to hbitmap_iter_next()

This new parameter allows the caller to just query the next dirty position without moving the iterator. Signed-off-by: Max Reitz --- include/qemu/hbitmap.h | 4 +++- block/dirty-bitmap.c | 2 +- tests/test-hbitmap.c | 26 +- util/hbitmap.c

[Qemu-devel] [PATCH 05/18] block/mirror: Convert to coroutines

In order to talk to the source BDS (and maybe in the future to the target BDS as well) directly, we need to convert our existing AIO requests into coroutine I/O requests. Signed-off-by: Max Reitz --- block/mirror.c | 134

[Qemu-devel] [PATCH 08/18] block/mirror: Use source as a BdrvChild

With this, the mirror_top_bs is no longer just a technically required node in the BDS graph but actually represents the block job operation. Signed-off-by: Max Reitz --- block/mirror.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH 09/18] block: Generalize should_update_child() rule

Currently, bdrv_replace_node() refuses to create loops from one BDS to itself if the BDS to be replaced is the backing node of the BDS to replace it: Say there is a node A and a node B. Replacing B by A means making all references to B point to A. If B is a child of A (i.e. A has a reference to

[Qemu-devel] [PATCH 07/18] block/mirror: Wait for in-flight op conflicts

This patch makes the mirror code differentiate between simply waiting for any operation to complete (mirror_wait_for_free_in_flight_slot()) and specifically waiting for all operations touching a certain range of the virtual disk to complete (mirror_wait_on_conflicts()). Signed-off-by: Max Reitz

[Qemu-devel] [PATCH 04/18] block/mirror: Pull out mirror_perform()

When converting mirror's I/O to coroutines, we are going to need a point where these coroutines are created. mirror_perform() is going to be that point. Signed-off-by: Max Reitz --- block/mirror.c | 53 ++--- 1 file changed, 30

[Qemu-devel] [PATCH 03/18] blockjob: Make drained_{begin, end} public

When a block job decides to be represented as a BDS and track its associated child nodes itself instead of having the BlockJob object track them, it needs to implement the drained_begin/drained_end child operations. In order to do that, it has to be able to control drainage of the block job (i.e.

[Qemu-devel] [PATCH 02/18] block: BDS deletion during bdrv_drain_recurse

Drainined a BDS child may lead to both the original BDS and/or its other children being deleted (e.g. if the original BDS represents a block job). We should prepare for this in both bdrv_drain_recurse() and bdrv_drained_begin() by monitoring whether the BDS we are about to drain still exists at

[Qemu-devel] [PATCH 00/18] block/mirror: Add active-sync mirroring

This series implements an active and synchronous mirroring mode. Currently, the mirror block job is passive an asynchronous: Depending on your start conditions, some part of the source disk starts as "dirty". Then, the block job will (as a background operation) continuously copy dirty parts to

[Qemu-devel] [PATCH 01/18] block: Add BdrvDeletedStatus

Sometimes an operation may delete a BDS. It may then not be trivial to determine this because the BDS object itself cannot be accessed afterwards. With this patch, one can attach a BdrvDeletedStatus object to a BDS which can be used to safely query whether the BDS still exists even after it has

Re: [Qemu-devel] [RFC 0/8] virtio-crypto: add multiplexing mode support

On 09/11/2017 03:10 AM, Longpeng(Mike) wrote: > *NOTE* > The code realization is based on the latest virtio crypto spec: > [PATCH v19 0/2] virtio-crypto: virtio crypto device specification >https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05217.html > > In session mode, the

Re: [Qemu-devel] [PATCH v2] accel: default to an actually available accelerator

On 09/13/2017 10:29 AM, Cornelia Huck wrote: > configure_accelerator() falls back to tcg if no accelerator has > been specified. Formerly, we could be sure that tcg is always > available; however, with --disable-tcg, this is not longer true, > and you are not able to start qemu without explicitly

Re: [Qemu-devel] [PATCH 7/7] trace: Add event "guest_inst_info_after"

On 09/10/2017 09:39 AM, Lluís Vilanova wrote: > if (TRACE_GUEST_INST_AFTER_ENABLED && translated_insn) { > trace_guest_inst_after_tcg(cpu, tcg_ctx.tcg_env, pc_insn); > } > +if (TRACE_GUEST_INST_INFO_AFTER_ENABLED && translated_insn) { > +

Re: [Qemu-devel] [PATCH 6/7] trace: Add event "guest_inst_after"

On 09/10/2017 09:35 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > accel/tcg/translator.c | 23 ++- > trace-events |8 > 2 files changed, 26 insertions(+), 5 deletions(-) > > diff --git a/accel/tcg/translator.c

Re: [Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after"

On 09/10/2017 09:31 AM, Lluís Vilanova wrote: > +void translator__gen_goto_tb(TCGContext *ctx) > +{ > +if (ctx->disas.in_guest_code && > +(TRACE_GUEST_BBL_AFTER_ENABLED)) { > +if (ctx->disas.inline_label == NULL) { > +ctx->disas.inline_label =

Re: [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration

On 13/09/2017 19:11, Mark Cave-Ayland wrote: > On 13/09/17 08:12, David Gibson wrote: > >> This is subtly incorrect. It sets the DECR on load to exactly the >> value that was saved. That effectively means that the DECR is frozen >> for the migration downtime, which probably isn't what we want.

Re: [Qemu-devel] [PATCH v2] accel: default to an actually available accelerator

On 13.09.2017 19:29, Cornelia Huck wrote: > configure_accelerator() falls back to tcg if no accelerator has > been specified. Formerly, we could be sure that tcg is always > available; however, with --disable-tcg, this is not longer true, > and you are not able to start qemu without explicitly

Re: [Qemu-devel] [PATCH] pixman: drop submodule

On Fri, Sep 01, 2017 at 12:50:23PM +0200, Gerd Hoffmann wrote: > Drop pixman submodule and support for the "internal" pixman build. > pixman should be reasonable well established meanwhile that we don't > need the fallback submodule any more. While being at it also drop > some #ifdefs for pixman

[Qemu-devel] [PATCH v2] accel: default to an actually available accelerator

configure_accelerator() falls back to tcg if no accelerator has been specified. Formerly, we could be sure that tcg is always available; however, with --disable-tcg, this is not longer true, and you are not able to start qemu without explicitly specifying another accelerator on those builds.

Re: [Qemu-devel] [Qemu devel v8 PATCH 4/5] msf2: Add Smartfusion2 SoC

Hi Sundeep, On 09/13/2017 06:21 AM, sundeep subbaraya wrote: All patches got Reviewed-by. Do you want me to change alias to remap and send This is just cosmetic for the "alias MSF2.eNVM.alias": (qemu) info mtree address-space: cpu-memory - (prio 0, i/o):

Re: [Qemu-devel] [PATCH 3/4] ppc: add CPU access_type into the migration stream

On 13/09/17 08:19, David Gibson wrote: >> When pausing a VM, does execution stop at the end of the current TB >> rather than immediately? If so, perhaps someone could confirm that >> guarantee is good enough for access_type? > > I'm pretty sure it has to; we'd have to come up out of an

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] ppc: add CPU IRQ state to PPC VMStateDescription

On Wed, 13 Sep 2017 17:44:54 +0100 Mark Cave-Ayland wrote: > On 13/09/17 07:02, David Gibson wrote: > > >>> Alexey - do you recall from your analysis why these fields were no > >>> longer deemed necessary, and how your TCG tests were configured? > >> > >> I most

Re: [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration

On 13/09/17 08:12, David Gibson wrote: > This is subtly incorrect. It sets the DECR on load to exactly the > value that was saved. That effectively means that the DECR is frozen > for the migration downtime, which probably isn't what we want. > > Instead we need to save the DECR as an offset

Re: [Qemu-devel] [PATCH 4/7] tcg: Add support for "inlining" regions of code

On 09/10/2017 09:27 AM, Lluís Vilanova wrote: > TCG BBLs and instructions have multiple exit points from where to raise > tracing events, but some of the necessary information in the generic > disassembly infrastructure is not available until after generating these > exit points. > > This patch

Re: [Qemu-devel] [PATCH 3/7] trace: Add event "guest_inst_info_before"

On 09/10/2017 09:23 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > accel/tcg/translator.c | 18 ++ > trace-events |9 + > 2 files changed, 27 insertions(+) > > diff --git a/accel/tcg/translator.c

Re: [Qemu-devel] [Qemu devel v8 PATCH 4/5] msf2: Add Smartfusion2 SoC

Hi Philippe, On Wed, Sep 13, 2017 at 2:51 PM, sundeep subbaraya wrote: > Hi Philippe, > > All patches got Reviewed-by. Do you want me to change alias to remap and > send > v9 or wait so that you get time to review? > > Sorry. My bad, I overlooked your comment. I will

Re: [Qemu-devel] [PATCH 2/7] trace: Add event "guest_inst_before"

On 09/10/2017 09:19 AM, Lluís Vilanova wrote: > while (true) { > +target_ulong pc_insn = db->pc_next; Why not just "pc"? > + > db->num_insns++; > ops->insn_start(db, cpu); > tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */ > @@ -96,6 +98,7

Re: [Qemu-devel] [PATCH 1/7] trace: Add event "guest_bbl_before"

On 09/10/2017 09:15 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > accel/tcg/translator.c |6 ++ > trace-events | 11 +++ > 2 files changed, 17 insertions(+) > > diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c >

  1   2   3   4   5   >