Re: [Qemu-devel] [Qemu-ppc] [PPC64] P5020DS: Booting from img possible (-drive)?

2018-05-18 Thread Thomas Huth
On 19.05.2018 06:58, Christian Zigotzky wrote: > Thomas wrote: > > > No clue, so just a blind guess: Is "CoreNet Generic" the right machine? > > What happens if you set "CONFIG_CORENET_GENERIC=n" in your kernel config? > > I think it‘s the right machine. It's likely the right selection for the r

Re: [Qemu-devel] [RFC PATCH 2/2] tests/Makefile: comment out flakey tests

2018-05-18 Thread Thomas Huth
On 18.05.2018 20:31, Peter Maydell wrote: > On 18 May 2018 at 10:14, Alex Bennée wrote: >> The following tests keep showing up in failed Travis runs: >> >> - test-aio >> - rcutorture >> - tpm-crb-test >> - tpm-tis-test >> >> I suspect it is load that causes the problems but they really nee

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-18 Thread Markus Armbruster
Eduardo Habkost writes: [...] > About being more expressive than just a single list of key,value > pairs, I don't see any evidence of that being necessary for the > problems we're trying to address. Short history of a configuration format you might have encountered: 1. A couple of (key, value)

[Qemu-devel] [Bug 1772086] Re: malformed serial data being sent from guest

2018-05-18 Thread Thomas Huth
It's even older than 6 years, see: https://lists.nongnu.org/archive/html/qemu-devel/2006-06/msg00196.html and: https://bugs.launchpad.net/qemu/+bug/1407813 https://bugs.launchpad.net/qemu/+bug/1715296 -- You received this bug notification because you are a member of qemu- devel-ml, which is subsc

[Qemu-devel] [PPC64] P5020DS: Booting from img possible (-drive)?

2018-05-18 Thread Christian Zigotzky
Thomas wrote: No clue, so just a blind guess: Is "CoreNet Generic" the right machine? What happens if you set "CONFIG_CORENET_GENERIC=n" in your kernel config? Thomas —— I think it‘s the right machine. CONFIG_CORENET_GENERIC: This option enables support for the FSL CoreNet based boards. For 3

[Qemu-devel] [Bug 1772075] [NEW] Segmentation fault on aarch64 vm at powerdown

2018-05-18 Thread M0Rf30
Public bug reported: OS Arch Linux x86_64 qemu version: 2.12 cmdline: qemu-system-aarch64 -nographic -cpu cortex-a57 -m 2048 -M virt,gic_version=3 -machine virtualization=true -bios /usr/share/ovmf/AARCH64/QEMU_EFI.fd -drive file=fat:rw:/opt/simonpiemu/kernels/rpi-3,if=none,format=raw,cache=non

[Qemu-devel] [PATCH] contrib/vhost-user-blk: enable protocol feature for vhost-user-blk

2018-05-18 Thread Changpeng Liu
This patch reports the protocol feature that is only advertised by QEMU if the device implements the config ops. Signed-off-by: Changpeng Liu --- contrib/vhost-user-blk/vhost-user-blk.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/contrib/vhost-user-blk/vhost-user-blk.c b/contrib/

[Qemu-devel] [PATCH] vhost-blk: turn on pre-defined RO feature bit

2018-05-18 Thread Changpeng Liu
Read only feature shouldn't be negotiable, because if the backend device reported Read only feature supported, QEMU host driver shouldn't change backend's RO attribute. Signed-off-by: Changpeng Liu --- hw/block/vhost-user-blk.c | 5 + include/hw/virtio/vhost-user-blk.h | 1 - 2 file

[Qemu-devel] [PULL 5/8] target/s390x: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Also do not dump both "fpu" and "vector" registers as the former overlaps the latter. Cc: Alexander Graf Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/helper.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/targe

[Qemu-devel] [PULL 8/8] target/xtensa: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Acked-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/xtensa/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index ae0feb0254..53f6f5db8f 100644 --- a/target/

[Qemu-devel] [PULL 2/8] target/mips: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Cc: Aurelien Jarno Cc: Yongbok Kim Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index f1c1fdd35c..e88f983ae7 100644 --- a/

[Qemu-devel] [PULL 7/8] target/unicore32: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Cc: Guan Xuetao Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/unicore32/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c index abe2ea8592..3cae111955 100644 --- a/targ

[Qemu-devel] [PULL 6/8] target/sparc: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/cpu.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index ff6ed91f9a..0f090ece54 1006

[Qemu-devel] [PULL 4/8] target/riscv: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Reviewed-by: Michael Clark Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/riscv/cpu.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/target/riscv/cpu.c b/target/r

[Qemu-devel] [PULL 1/8] target/alpha: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/alpha/helper.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/target/alpha/helper.c b/target/alpha/helper.c index 8a6a948572..57e2c212b3 100644 --- a/target/alpha/helper.c +++ b

[Qemu-devel] [PULL 3/8] target/ppc: Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
Cc: Alexander Graf Cc: David Gibson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/ppc/translate.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index d5e5f953da..e30d99

[Qemu-devel] [PULL 0/8] Honor CPU_DUMP_FPU

2018-05-18 Thread Richard Henderson
With Peter's new patch for "-d fpu", it makes sense to honor this setting in as many targets as currently dump the fpu. r~ The following changes since commit 5bcf917ee37a5efbef99f091a96db54a5276becb: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-201

[Qemu-devel] [Bug 1772086] Re: malformed serial data being sent from guest

2018-05-18 Thread Patto
Seems like the problems isn't really new and might be at least 6 years old if not more. https://robert.penz.name/550/mapping-a-serial-device- to-a-kvm-guest-may-lead-to-communication-problems/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1772086] Re: malformed serial data being sent from guest

2018-05-18 Thread Patto
After doing a bit of research I think line 142 in file chardev/char- serial.c is problematic. https://github.com/qemu/qemu/blob/master/chardev/char-serial.c#L142 It enables output processing, which is something unwanted here. With a simple test program I found out that by default, besides OPOST, O

Re: [Qemu-devel] [PATCH v3 2/2] Add Nios II semihosting support.

2018-05-18 Thread Sandra Loosemore
On 05/18/2018 02:19 PM, Julian Brown wrote: On Fri, 18 May 2018 21:52:04 +0200 Marek Vasut wrote: On 05/18/2018 09:23 PM, Julian Brown wrote: This patch (by Sandra Loosemore, mildly rebased) adds support for semihosting for Nios II bare-metal emulation. Signed-off-by: Julian Brown Signed-of

[Qemu-devel] [Bug 1772086] Re: malformed serial data being sent from guest

2018-05-18 Thread Patto
I am unable to provide complete QEMU command line as I'm using virt-manager to deal with configuration. I can say that two serial ports are linked with physical ones through the /dev/ttyS* files. The guests I tested it with are Windows 98 and Windows XP. For the testing I connected one port to a

Re: [Qemu-devel] [PATCH v3 2/2] Add Nios II semihosting support.

2018-05-18 Thread Marek Vasut
On 05/18/2018 10:19 PM, Julian Brown wrote: > On Fri, 18 May 2018 21:52:04 +0200 > Marek Vasut wrote: > >> On 05/18/2018 09:23 PM, Julian Brown wrote: >>> This patch (by Sandra Loosemore, mildly rebased) adds support for >>> semihosting for Nios II bare-metal emulation. >>> >>> Signed-off-by: Jul

Re: [Qemu-devel] [PATCH v3 2/2] Add Nios II semihosting support.

2018-05-18 Thread Julian Brown
On Fri, 18 May 2018 21:52:04 +0200 Marek Vasut wrote: > On 05/18/2018 09:23 PM, Julian Brown wrote: > > This patch (by Sandra Loosemore, mildly rebased) adds support for > > semihosting for Nios II bare-metal emulation. > > > > Signed-off-by: Julian Brown > > Signed-off-by: Sandra Loosemore

Re: [Qemu-devel] [PATCH v3 1/2] Add generic Nios II board.

2018-05-18 Thread Julian Brown
On Fri, 18 May 2018 21:50:55 +0200 Marek Vasut wrote: > On 05/18/2018 09:23 PM, Julian Brown wrote: > > This patch adds support for a generic MMU-less Nios II board that > > can be used e.g. for bare-metal compiler testing. Nios II booting > > is also tweaked so that bare-metal binaries start ex

Re: [Qemu-devel] [PATCH v3 2/2] Add Nios II semihosting support.

2018-05-18 Thread Marek Vasut
On 05/18/2018 09:23 PM, Julian Brown wrote: > This patch (by Sandra Loosemore, mildly rebased) adds support for > semihosting for Nios II bare-metal emulation. > > Signed-off-by: Julian Brown > Signed-off-by: Sandra Loosemore Is there some documentation for this stuff ? It looks interesting, bu

Re: [Qemu-devel] [PATCH v3 1/2] Add generic Nios II board.

2018-05-18 Thread Marek Vasut
On 05/18/2018 09:23 PM, Julian Brown wrote: > This patch adds support for a generic MMU-less Nios II board that can > be used e.g. for bare-metal compiler testing. Nios II booting is also > tweaked so that bare-metal binaries start executing in RAM starting at > 0x, rather than an alias at

Re: [Qemu-devel] [PATCH v3 0/2] Nios II generic board config and semihosting support

2018-05-18 Thread Marek Vasut
On 05/18/2018 09:23 PM, Julian Brown wrote: > This is a third attempt at sending the patch series: > > http://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04259.html > > Turns out the git format-patch "--inline" option didn't do what I thought > it did. Apologies for the noise! Success ! --

Re: [Qemu-devel] [qemu PATCH v2 3/4] nvdimm, acpi: support NFIT platform capabilities

2018-05-18 Thread Ross Zwisler
On Fri, May 18, 2018 at 04:37:10PM +, Elliott, Robert (Persistent Memory) wrote: > > > ... > > Would it help to show them in hex? > > > > As of ACPI 6.2 Errata A, the following values are valid for the bottom > > two bits: > > > > 0x2 - Memory Controller Flush to NVDIMM Durability on

[Qemu-devel] [PATCH v3 2/2] Add Nios II semihosting support.

2018-05-18 Thread Julian Brown
This patch (by Sandra Loosemore, mildly rebased) adds support for semihosting for Nios II bare-metal emulation. Signed-off-by: Julian Brown Signed-off-by: Sandra Loosemore --- qemu-options.hx| 8 +- target/nios2/Makefile.objs | 2 +- target/nios2/cpu.h | 4 +- target/n

[Qemu-devel] [PATCH v3 0/2] Nios II generic board config and semihosting support

2018-05-18 Thread Julian Brown
This is a third attempt at sending the patch series: http://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04259.html Turns out the git format-patch "--inline" option didn't do what I thought it did. Apologies for the noise! Thanks, Julian Julian Brown (2): Add generic Nios II board. Add

[Qemu-devel] [PATCH v3 1/2] Add generic Nios II board.

2018-05-18 Thread Julian Brown
This patch adds support for a generic MMU-less Nios II board that can be used e.g. for bare-metal compiler testing. Nios II booting is also tweaked so that bare-metal binaries start executing in RAM starting at 0x, rather than an alias at 0xc000, which allows features such as unwinding

Re: [Qemu-devel] [PATCH v2 0/2] Nios II generic board config and semihosting support

2018-05-18 Thread Marek Vasut
On 05/18/2018 08:57 PM, Julian Brown wrote: > > This is a second attempt at sending this patch series: > > http://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04259.html > > with some git format-patch/send-email hiccups ironed out > (hopefully). The patch contents are unchanged. > > OK, or

Re: [Qemu-devel] [PATCH v2 0/2] Nios II generic board config and semihosting support

2018-05-18 Thread Marek Vasut
On 05/18/2018 08:57 PM, Julian Brown wrote: > > This is a second attempt at sending this patch series: > > http://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04259.html > > with some git format-patch/send-email hiccups ironed out > (hopefully). The patch contents are unchanged. > > OK, or

Re: [Qemu-devel] [PATCH] usb-mtp: Assert on suspicious TYPE_DATA packet from initiator

2018-05-18 Thread Bandan Das
Peter Maydell writes: > On 18 May 2018 at 19:38, Bandan Das wrote: >> Peter Maydell writes: >> >>> On 18 May 2018 at 19:22, Bandan Das wrote: CID 1390604 If the initiator sends a packet with TYPE_DATA set without initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data

[Qemu-devel] [Bug 1772086] Re: malformed serial data being sent from guest

2018-05-18 Thread Peter Maydell
Something somewhere in the stack is converting LF to CRLF. This could be something inside your guest, or in QEMU, or in the host; to find out where we need more detail. Can you describe your setup, including: * complete QEMU command line * how you're sending data inside the guest * how you're r

[Qemu-devel] [PATCH v2 1/2] Add generic Nios II board.

2018-05-18 Thread Julian Brown
This patch adds support for a generic MMU-less Nios II board that can be used e.g. for bare-metal compiler testing. Nios II booting is also tweaked so that bare-metal binaries start executing in RAM starting at 0x, rather than an alias at 0xc000, which allows features such as unwindin

[Qemu-devel] [PATCH v2 2/2] Add Nios II semihosting support.

2018-05-18 Thread Julian Brown
This patch (by Sandra Loosemore, mildly rebased) adds support for semihosting for Nios II bare-metal emulation. Signed-off-by: Julian Brown Signed-off-by: Sandra Loosemore --- qemu-options.hx| 8 +- target/nios2/Makefile.objs | 2 +- target/nios2/cpu.h | 4 +- target/

[Qemu-devel] [PATCH v2 0/2] Nios II generic board config and semihosting support

2018-05-18 Thread Julian Brown
This is a second attempt at sending this patch series: http://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04259.html with some git format-patch/send-email hiccups ironed out (hopefully). The patch contents are unchanged. OK, or any comments? Thanks, Julian Julian Brown (2): Add generi

Re: [Qemu-devel] [PATCH] usb-mtp: Assert on suspicious TYPE_DATA packet from initiator

2018-05-18 Thread Peter Maydell
On 18 May 2018 at 19:38, Bandan Das wrote: > Peter Maydell writes: > >> On 18 May 2018 at 19:22, Bandan Das wrote: >>> >>> CID 1390604 >>> If the initiator sends a packet with TYPE_DATA set without >>> initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data >>> can trip on a null s->data_o

Re: [Qemu-devel] [PATCH] linux-user: Fix payload size logic in host_to_target_cmsg()

2018-05-18 Thread Laurent Vivier
Le 18/05/2018 à 20:47, Peter Maydell a écrit : > Coverity points out that there's a missing break in the switch in > host_to_target_cmsg() where we update tgt_len for > cmsg_level/cmsg_type combinations which require a different length > for host and target (CID 1385425). To avoid duplicating the

[Qemu-devel] [PATCH v2] usb-mtp: Return error on suspicious TYPE_DATA packet from initiator

2018-05-18 Thread Bandan Das
CID 1390604 If the initiator sends a packet with TYPE_DATA set without initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data can trip on a null s->data_out. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/

Re: [Qemu-devel] [PULL 00/32] target-arm queue

2018-05-18 Thread Peter Maydell
> > Merge remote-tracking branch > 'remotes/famz/tags/docker-and-block-pull-request' into staging (2018-05-18 > 14:11:52 +0100) > > are available in the Git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git

[Qemu-devel] [PATCH] linux-user: Fix payload size logic in host_to_target_cmsg()

2018-05-18 Thread Peter Maydell
Coverity points out that there's a missing break in the switch in host_to_target_cmsg() where we update tgt_len for cmsg_level/cmsg_type combinations which require a different length for host and target (CID 1385425). To avoid duplicating the default case (target length same as host) in both switc

Re: [Qemu-devel] [PATCH v2 13/40] job: Move coroutine and related code to Job

2018-05-18 Thread John Snow
On 05/18/2018 09:20 AM, Kevin Wolf wrote: > This commit moves some core functions for dealing with the job coroutine > from BlockJob to Job. This includes primarily entering the coroutine > (both for the first and reentering) and yielding explicitly and at pause > points. > > Signed-off-by: Kevi

Re: [Qemu-devel] [PATCH v2 00/40] Generic background jobs

2018-05-18 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Before we can make x-blockdev-create a background job, we need to > generalise the job infrastructure so that it can be used without any > associated block node. Is there any relationship between what this does, and what Marc-André's 'monitor: add asynchron

[Qemu-devel] [Bug 1772086] [NEW] malformed serial data being sent from guest

2018-05-18 Thread Patto
Public bug reported: When sending data through serial from guest each time 0x0A byte is sent 0x0D is sent before it. For example, when sending {0x29, 0x0A} on the other end I receive {0x29, 0x0D, 0x0A}. ** Affects: qemu Importance: Undecided Status: New ** Tags: com serial -- Yo

Re: [Qemu-devel] [PATCH] usb-mtp: Assert on suspicious TYPE_DATA packet from initiator

2018-05-18 Thread Bandan Das
Peter Maydell writes: > On 18 May 2018 at 19:22, Bandan Das wrote: >> >> CID 1390604 >> If the initiator sends a packet with TYPE_DATA set without >> initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data >> can trip on a null s->data_out. >> >> Signed-off-by: Bandan Das > > I think you

[Qemu-devel] [PATCH v2 1/1] tests/docker: Add a Avocado Docker test

2018-05-18 Thread Alistair Francis
Avocado is not trivial to setup on non-Fedora systems. To simplfying future testing add a docker test image that runs Avocado tests. Signed-off-by: Alistair Francis --- v2: - Add a seperate fedora-avocado Docker image - Move the avocado vt-bootstrap into the Docker file tests/docker/Makefile.

Re: [Qemu-devel] [RFC PATCH 2/2] tests/Makefile: comment out flakey tests

2018-05-18 Thread Peter Maydell
On 18 May 2018 at 10:14, Alex Bennée wrote: > The following tests keep showing up in failed Travis runs: > > - test-aio > - rcutorture > - tpm-crb-test > - tpm-tis-test > > I suspect it is load that causes the problems but they really need to > be fixed properly. > > Signed-off-by: Alex Be

Re: [Qemu-devel] [PATCH] usb-mtp: Assert on suspicious TYPE_DATA packet from initiator

2018-05-18 Thread Peter Maydell
On 18 May 2018 at 19:22, Bandan Das wrote: > > CID 1390604 > If the initiator sends a packet with TYPE_DATA set without > initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data > can trip on a null s->data_out. > > Signed-off-by: Bandan Das I think you said this can be provoked by the gue

Re: [Qemu-devel] [PULL 1/3] usb-mtp: Add some NULL checks for issues pointed out by coverity

2018-05-18 Thread Bandan Das
Bandan Das writes: >> If this is a "can't happen" situation we can mark it as a false >> positive in coverity. I posted a patch with an assert added in usb_mtp_get_data. I believe CID 1390604 can be marked as a false positive. Thanks, Bandan > The protocol ofcourse won't let this happen but t

[Qemu-devel] [PATCH] usb-mtp: Assert on suspicious TYPE_DATA packet from initiator

2018-05-18 Thread Bandan Das
CID 1390604 If the initiator sends a packet with TYPE_DATA set without initiating a CMD_GET_OBJECT_INFO first, then usb_mtp_get_data can trip on a null s->data_out. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-m

Re: [Qemu-devel] [PATCH v2 37/40] job: Add query-jobs QMP command

2018-05-18 Thread Eric Blake
On 05/18/2018 08:21 AM, Kevin Wolf wrote: This adds a minimal query-jobs implementation that shouldn't pose many design questions. It can later be extended to expose more information, and especially job-specific information. Signed-off-by: Kevin Wolf --- qapi/job.json | 45 ++

[Qemu-devel] [Bug 1771570] Re: qemu-aarch64 $program > $file doesn't pipe output to file in 2.12.0

2018-05-18 Thread Peter Maydell
No, this should work on qemu-aarch64 the same way as for x86. I just tried redirection to a file with a sample program, and it worked fine for me. Can you provide a test case binary that fails like this, please? -- You received this bug notification because you are a member of qemu- devel-ml, whi

[Qemu-devel] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc()

2018-05-18 Thread Peter Maydell
In commit 8b9ad56e9cbfd852a, we removed the code that could result in our getting to sd_prealloc()'s out_with_err_set label with a NULL blk pointer. That makes the NULL check in the error-handling path unnecessary, and Coverity gripes about it (CID 1390636). Delete the redundant check. Signed-off-

Re: [Qemu-devel] Publishing binary images for testing (was Re: [RFC PATCH 0/6] generic way to deprecate machines)

2018-05-18 Thread Alistair Francis
On Fri, May 11, 2018 at 7:27 AM, Cleber Rosa wrote: > > > On 05/11/2018 09:55 AM, Eduardo Habkost wrote: >> (CCing Cleber and avocado-devel in case they have suggestions) >> >> On Tue, May 08, 2018 at 12:47:52PM -0300, Philippe Mathieu-Daudé wrote: >> [...] >>> Ironically I have been using the Gum

Re: [Qemu-devel] [PATCH v2 37/40] job: Add query-jobs QMP command

2018-05-18 Thread Eric Blake
On 05/18/2018 08:21 AM, Kevin Wolf wrote: This adds a minimal query-jobs implementation that shouldn't pose many design questions. It can later be extended to expose more information, and especially job-specific information. Signed-off-by: Kevin Wolf --- qapi/job.json | 45 ++

Re: [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands

2018-05-18 Thread Eric Blake
On 05/18/2018 08:21 AM, Kevin Wolf wrote: This adds QMP commands that control the transition between states of the job lifecycle. Signed-off-by: Kevin Wolf --- qapi/job.json | 99 +++ job-qmp.c | 134 +++

Re: [Qemu-devel] [PULL 1/1] block/nvme: fix Coverity reports

2018-05-18 Thread Peter Maydell
On 1 March 2018 at 07:54, Fam Zheng wrote: > From: Paolo Bonzini > > 1) string not null terminated in sysfs_find_group_file > > 2) NULL pointer dereference and dead local variable in nvme_init. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Fam Zheng > > Message-Id: <20180213015240.9352-1-f.

[Qemu-devel] [Bug 1771570] Re: qemu-aarch64 $program > $file doesn't pipe output to file in 2.12.0

2018-05-18 Thread Juho Hiltunen
Running "unbuffer qemu-aarch64 $program > $file" allows to pipe the output. Is it intentional that I need to disable buffering to allow piping to other processes? If yes, this issue can be closed. further reading about unbuffer: https://unix.stackexchange.com/questions/25372/turn-off-buffering-in

Re: [Qemu-devel] [PATCH v2 20/40] job: Move single job finalisation to Job

2018-05-18 Thread Eric Blake
On 05/18/2018 08:20 AM, Kevin Wolf wrote: This moves the finalisation of a single job from BlockJob to Job. Some part of this code depends on job transactions, and job transactions call this code, we introduce some temporary calls from Job functions to BlockJob ones. This will be fixed once tran

Re: [Qemu-devel] [PATCH v2 12/40] job: Move defer_to_main_loop to Job

2018-05-18 Thread John Snow
On 05/18/2018 09:20 AM, Kevin Wolf wrote: > Move the defer_to_main_loop functionality from BlockJob to Job. > > The code can be simplified because we can use job->aio_context in > job_defer_to_main_loop_bh() now, instead of having to access the > BlockDriverState. > > Probably taking the data->

Re: [Qemu-devel] [PATCH v2 35/40] job: Add JOB_STATUS_CHANGE QMP event

2018-05-18 Thread Eric Blake
On 05/18/2018 08:21 AM, Kevin Wolf wrote: This adds a QMP event that is emitted whenever a job transitions from one status to another. Signed-off-by: Kevin Wolf --- qapi/job.json | 14 job.c | 10 +++ @@ -157,6 +158,11 @@ static int job_txn_ap

Re: [Qemu-devel] [PATCH 1/3] i386: fix regression parsing multiboot initrd modules

2018-05-18 Thread Peter Maydell
On 14 May 2018 at 18:19, Daniel P. Berrangé wrote: > The logic for parsing the multiboot initrd modules was messed up in > > commit 950c4e6c94b15cd0d8b638917a8dbf458e6a > Author: Daniel P. Berrangé > Date: Mon Apr 16 12:17:43 2018 +0100 > > opts: don't silently truncate long optio

Re: [Qemu-devel] [PATCH] kvm: rename HINTS_DEDICATED to KVM_HINTS_REALTIME

2018-05-18 Thread Eduardo Habkost
On Fri, May 18, 2018 at 07:18:57PM +0200, Paolo Bonzini wrote: > On 18/05/2018 19:13, Eduardo Habkost wrote: > >> As much as we'd like to be helpful and validate input, you need a real > >> time host too. I'm not sure how we'd find out - I suggest we do not > >> bother for now. > > I'm worried that

Re: [Qemu-devel] [PATCH v2 02/40] blockjob: Improve BlockJobInfo.offset/len documentation

2018-05-18 Thread John Snow
On 05/18/2018 09:20 AM, Kevin Wolf wrote: > Clarify that len is just an estimation of the end value of offset, and > that offset increases monotonically while len can change arbitrarily. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 9 ++--- > 1 file changed, 6 insertions(+)

Re: [Qemu-devel] storing machine data in qcow images?

2018-05-18 Thread Eduardo Habkost
On Fri, May 18, 2018 at 06:09:56PM +0100, Daniel P. Berrangé wrote: > On Fri, May 18, 2018 at 06:30:38PM +0300, Michael S. Tsirkin wrote: > > Hi! > > Right now, QEMU supports multiple machine types within > > a given architecture. This was the case for many architectures > > (like ARM) for a while,

[Qemu-devel] [PULL 27/32] target/arm: Implement SVE floating-point exponential accelerator

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-21-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 4 ++ target/arm/sve_helper.c| 90 ++ tar

[Qemu-devel] [PULL 32/32] target/arm: Implement SVE Permute - Extract Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-26-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 2 + target/arm/sve_helper.c| 81 ++ targ

[Qemu-devel] [PULL 20/32] target/arm: Implement SVE Integer Arithmetic - Unary Predicated Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-14-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 60 ++ target/arm/sve_helper.c| 127 +

[Qemu-devel] [PULL 31/32] target/arm: Implement SVE Integer Wide Immediate - Predicated Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-25-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 10 target/arm/sve_helper.c| 108 +

[Qemu-devel] [PULL 29/32] target/arm: Implement SVE Element Count Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-23-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 11 ++ target/arm/sve_helper.c| 136 ++ target/arm/translate-

[Qemu-devel] [PULL 19/32] target/arm: Implement SVE bitwise shift by wide elements (predicated)

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-13-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 21 + target/arm/sve_helper.c| 35

[Qemu-devel] [PULL 23/32] target/arm: Implement SVE Index Generation Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-17-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 5 +++ target/arm/sve_helper.c| 40 +++ target/arm/translate-

[Qemu-devel] [PULL 22/32] target/arm: Implement SVE Integer Arithmetic - Unpredicated Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-16-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 34 ++ target/arm/sve.decode | 13 +++

[Qemu-devel] [PULL 30/32] target/arm: Implement SVE Bitwise Immediate Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-24-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 49 ++ target/arm/sve.decode | 17 +++

[Qemu-devel] [PULL 24/32] target/arm: Implement SVE Stack Allocation Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-18-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 27 +++ target/arm/sve.decode | 12 2 fi

[Qemu-devel] [PULL 17/32] target/arm: Implement SVE bitwise shift by immediate (predicated)

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-11-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 25 target/arm/sve_helper.c| 264 +

[Qemu-devel] [PULL 12/32] target/arm: Implement SVE predicate test

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-6-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/Makefile.objs | 2 +- target/arm/helper-sve.h| 21 ++ target/arm/helper.h| 1

[Qemu-devel] [PULL 28/32] target/arm: Implement SVE floating-point trig select coefficient

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-22-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 4 target/arm/sve_helper.c| 43 ++ t

[Qemu-devel] [PULL 21/32] target/arm: Implement SVE Integer Multiply-Add Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-15-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 18 target/arm/sve_helper.c| 57 +

[Qemu-devel] [PULL 26/32] target/arm: Implement SVE Compute Vector Address Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-20-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 5 + target/arm/sve_helper.c| 40 ++

[Qemu-devel] [PULL 18/32] target/arm: Implement SVE bitwise shift by vector (predicated)

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-12-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 27 +++ target/arm/sve_helper.c| 25 ++

[Qemu-devel] [PULL 08/32] target/arm: Introduce translate-a64.h

2018-05-18 Thread Peter Maydell
From: Richard Henderson Move some stuff that will be common to both translate-a64.c and translate-sve.c. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-2-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- targ

[Qemu-devel] [PULL 15/32] target/arm: Implement SVE Integer Binary Arithmetic - Predicated Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-9-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 145 +++ target/arm/sve_helper.c| 194 + target

[Qemu-devel] [PULL 25/32] target/arm: Implement SVE Bitwise Shift - Unpredicated Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-19-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper-sve.h| 12 ++ target/arm/sve_helper.c| 30 ++ target/arm/translate-sv

[Qemu-devel] [PULL 04/32] xlnx-zdma: Add a model of the Xilinx ZynqMP generic DMA

2018-05-18 Thread Peter Maydell
From: Francisco Iglesias Add a model of the generic DMA found on Xilinx ZynqMP. Signed-off-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias Reviewed-by: Edgar E. Iglesias Message-id: 20180503214201.29082-2-frasse.igles...@gmail.com Signed-off-by: Peter Maydell --- hw/dma/Makefile.obj

[Qemu-devel] [PULL 09/32] target/arm: Add SVE decode skeleton

2018-05-18 Thread Peter Maydell
From: Richard Henderson Including only 4, as-yet unimplemented, instruction patterns so that the whole thing compiles. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-3-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/Makef

[Qemu-devel] [PULL 11/32] target/arm: Implement SVE load vector/predicate

2018-05-18 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-5-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sve.c | 127 + target/arm/sve.decode | 20 ++ 2 files changed, 147 insert

[Qemu-devel] [PULL 16/32] target/arm: Implement SVE Integer Reduction Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Excepting MOVPRFX, which isn't a reduction. Presumably it is placed within the group because of its encoding. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-10-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 10/32] target/arm: Implement SVE Bitwise Logical - Unpredicated Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson These were the instructions that were stubbed out when introducing the decode skeleton. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-4-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/translate-sv

[Qemu-devel] [PULL 13/32] target/arm: Implement SVE Predicate Logical Operations Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-7-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.h | 4 +- target/arm/helper-sve.h| 10 + target/arm/sve_helper.c| 39

[Qemu-devel] [PULL 14/32] target/arm: Implement SVE Predicate Misc Group

2018-05-18 Thread Peter Maydell
From: Richard Henderson Signed-off-by: Richard Henderson Message-id: 20180516223007.10256-8-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.h | 4 + target/arm/helper-sve.h| 3 + target/arm/sve_helper.c| 84 +++ target/arm/transla

[Qemu-devel] [PULL 06/32] hw/arm/smmuv3: Fix Coverity issue in smmuv3_record_event

2018-05-18 Thread Peter Maydell
From: Eric Auger Coverity complains about use of uninitialized Evt struct. The EVT_SET_TYPE and similar setters use deposit32() on fields in the struct, so they read the uninitialized existing values. In cases where we don't set all the fields in the event struct we'll end up leaking random unini

[Qemu-devel] [PULL 07/32] hw/arm/smmu-common: Fix coverity issue in get_block_pte_address

2018-05-18 Thread Peter Maydell
From: Eric Auger Coverity points out that this can overflow if n > 31, because it's only doing 32-bit arithmetic. Let's use 1ULL instead of 1. Also the formulae used to compute n can be replaced by the level_shift() macro. Reported-by: Peter Maydell Signed-off-by: Eric Auger Reviewed-by: Phili

[Qemu-devel] [PULL 01/32] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

2018-05-18 Thread Peter Maydell
From: Abdallah Bouassida This is a preparation for the coming feature of creating dynamically an XML description for the ARM sysregs. A register has ARM_CP_NO_GDB enabled will not be shown in the dynamic XML. This bit is enabled automatically when creating CP_ANY wildcard aliases. This bit could

[Qemu-devel] [PULL 05/32] xlnx-zynqmp: Connect the ZynqMP GDMA and ADMA

2018-05-18 Thread Peter Maydell
From: Francisco Iglesias The ZynqMP contains two instances of a generic DMA, the GDMA, located in the FPD (full power domain), and the ADMA, located in LPD (low power domain). This patch adds these two DMAs to the ZynqMP board. Signed-off-by: Francisco Iglesias Reviewed-by: Alistair Francis R

[Qemu-devel] [PULL 03/32] target/arm: Add the XML dynamic generation

2018-05-18 Thread Peter Maydell
From: Abdallah Bouassida Generate an XML description for the cp-regs. Register these regs with the gdb_register_coprocessor(). Add arm_gdb_get_sysreg() to use it as a callback to read those regs. Add a dummy arm_gdb_set_sysreg(). Signed-off-by: Abdallah Bouassida Tested-by: Alex Bennée Message

[Qemu-devel] [PULL 02/32] target/arm: Add "_S" suffix to the secure version of a sysreg

2018-05-18 Thread Peter Maydell
From: Abdallah Bouassida This is a preparation for the coming feature of creating dynamically an XML description for the ARM sysregs. Add "_S" suffix to the secure version of sysregs that have both S and NS views Replace (S) and (NS) by _S and _NS for the register that are manually defined, so al

[Qemu-devel] [PULL 00/32] target-arm queue

2018-05-18 Thread Peter Maydell
t' into staging (2018-05-18 14:11:52 +0100) are available in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180518 for you to fetch changes up to b94f8f60bd841c5b737185cd38263e26822f77ab: target/arm: Implement SVE Permute - Extract Group

  1   2   3   4   >