Re: [Qemu-devel] [PATCH 1/2] hw/arm/virt: Add a new 256MB ECAM region

2018-05-30 Thread Auger Eric
Hi Laszlo, On 05/30/2018 06:11 PM, Laszlo Ersek wrote: > On 05/30/18 16:26, Eric Auger wrote: >> This patch defines a new ECAM region located after the 256GB limit. >> >> The virt machine state is augmented with a new highmem_ecam field >> which guards the usage of this new ECAM region instead of

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type

2018-05-30 Thread Auger Eric
On 05/30/2018 06:18 PM, Laszlo Ersek wrote: > On 05/30/18 16:26, Eric Auger wrote: >> Add virt-3.0 machine type. >> >> This machine type supports highmem 256MB ECAM by default. >> This feature is disabled for earlier machine types and >> if highmem is off. >> >> The high 256MB ECAM region is cho

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type

2018-05-30 Thread Auger Eric
Hi Shannon, On 05/31/2018 03:42 AM, Shannon Zhao wrote: > > > On 2018/5/31 0:18, Laszlo Ersek wrote: >> +vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64); >>> + > Does it need a info log here to tell user that even though you enable > the highmem_ecam but due to some other

Re: [Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default

2018-05-30 Thread Peter Xu
On Thu, May 31, 2018 at 01:16:37PM +0800, Peter Xu wrote: > Patch 1: some more comment suggested by Markus on Out-Of-Band > handlers. > > Patch 2: touch up iotests to make sure after enabling OOB the randomly > generated SHUTDOWN event won't fail any tests. Without this change, > iotests (raw) wi

[Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event

2018-05-30 Thread Peter Xu
This event is not really necessary. After OOB series it might affect the timing of the script so this event may or may not be there comparing to the old *.out results. Let's just filter it out. Since some of the scripts are using qmp-pretty, we need some trick in the filtering script to make sur

[Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default

2018-05-30 Thread Peter Xu
Patch 1: some more comment suggested by Markus on Out-Of-Band handlers. Patch 2: touch up iotests to make sure after enabling OOB the randomly generated SHUTDOWN event won't fail any tests. Without this change, iotests (raw) will success but iotests (qcow2) may fail 2 tests out of 100+. With thi

[Qemu-devel] [RFC v2 4/4] Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

2018-05-30 Thread Peter Xu
This reverts commit ddee57e0176f6ab53b13c6c97605b62737a8fd7a. Meanwhile, revert one line from fa198ad9bdef to make sure qtest_init_without_qmp_handshake() will only pass in one parameter. Signed-off-by: Peter Xu --- tests/libqtest.h | 7 ++- tests/libqtest.c | 10 -- tests/qmp-test

[Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default

2018-05-30 Thread Peter Xu
There was a regression reported by Eric Auger before with OOB: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html The fix is 951702f39c ("monitor: bind dispatch bh to iohandler context", 2018-04-10), which is in master already. For the bug, we turned Out-Of-Band feature of moni

[Qemu-devel] [RFC v2 1/4] docs: mention shared state protect for OOB

2018-05-30 Thread Peter Xu
Out-Of-Band handlers need to protect shared state if there is any. Mention it in the document. Suggested-by: Markus Armbruster Signed-off-by: Peter Xu --- docs/devel/qapi-code-gen.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.

[Qemu-devel] [PATCH 1/2] linux-user: Implement signals for openrisc

2018-05-30 Thread Richard Henderson
All of the existing code was boilerplate from elsewhere, and would crash the guest upon the first signal. Signed-off-by: Richard Henderson --- linux-user/openrisc/target_syscall.h | 23 +-- linux-user/openrisc/signal.c | 210 +++ linux-user/signal.c

[Qemu-devel] [PATCH 0/2] linux-user openrisc fixes

2018-05-30 Thread Richard Henderson
Both of these fixes are required to fix g++ unwinding tests. r~ Richard Henderson (2): linux-user: Implement signals for openrisc linux-user: Fix struct sigaltstack for openrisc linux-user/openrisc/target_signal.h | 2 +- linux-user/openrisc/target_syscall.h | 23 +-- linux-user/openr

[Qemu-devel] [PATCH 2/2] linux-user: Fix struct sigaltstack for openrisc

2018-05-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/openrisc/target_signal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/openrisc/target_signal.h b/linux-user/openrisc/target_signal.h index 2a4e00b035..901097972a 100644 --- a/linux-user/openrisc/target_signal.h +++

Re: [Qemu-devel] [PATCH v9 5/7] monitor: remove event_clock_type

2018-05-30 Thread Peter Xu
On Wed, May 30, 2018 at 05:35:52PM +0100, Stefan Hajnoczi wrote: > On Tue, May 29, 2018 at 01:57:53PM +0800, Peter Xu wrote: > > Instead, use a dynamic function to detect which clock we'll use. The > > problem is that the old code will let monitor initialization depends on > > qtest_enabled(). Af

[Qemu-devel] [PATCH RESEND v1 1/3] linux-headers: update to v4.17-rc7

2018-05-30 Thread Dongjiu Geng
Update headers against v4.17-rc7. Signed-off-by: Dongjiu Geng --- include/standard-headers/asm-x86/hyperv.h | 1 - include/standard-headers/asm-x86/kvm_para.h | 2 +- include/standard-headers/linux/ethtool.h| 36 ++- include/standard-headers/linux/input.h | 4 +-

[Qemu-devel] [PATCH RESEND v1 2/3] kvm: sync linux headers

2018-05-30 Thread Dongjiu Geng
Import KVM_CAP_ARM_INJECT_SERROR_ESR and struct kvm_vcpu_events for arm64 Signed-off-by: Dongjiu Geng --- linux-headers/asm-arm64/kvm.h | 13 + linux-headers/linux/kvm.h | 1 + 2 files changed, 14 insertions(+) diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm6

[Qemu-devel] [PATCH RESEND v1 3/3] target: arm: Add support for VCPU event states

2018-05-30 Thread Dongjiu Geng
This patch extends the qemu-kvm state sync logic with support for KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception. And also it can support the exception state migration. Signed-off-by: Dongjiu Geng --- target/arm/cpu.h | 5 target/arm/kvm64.c | 64 +

[Qemu-devel] [PATCH RESEND v1 0/3] add support for VCPU event states

2018-05-30 Thread Dongjiu Geng
support for KVM_GET/SET_VCPU_EVENTS to get/set the SError exception state, and support the state migration. Dongjiu Geng (3): linux-headers: update to v4.17-rc7 kvm: sync linux headers target: arm: Add support for VCPU event states include/standard-headers/asm-x86/hyperv.h | 1 - i

Re: [Qemu-devel] [PATCH] qom: support orphan objects in object_get_canonical_path

2018-05-30 Thread Alexey Kardashevskiy
On 31/5/18 2:23 am, Paolo Bonzini wrote: > Mostly a rewrite, in order to keep the loop simple. > > Signed-off-by: Paolo Bonzini > --- > qom/object.c | 29 - > 1 file changed, 16 insertions(+), 13 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index 0fc97

[Qemu-devel] [PATCH v1 3/3] target: arm: Add support for VCPU event states

2018-05-30 Thread Dongjiu Geng
This patch extends the qemu-kvm state sync logic with support for KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception. And also it can support the exception state migration. Signed-off-by: Dongjiu Geng --- target/arm/cpu.h | 5 target/arm/kvm64.c | 64 +

[Qemu-devel] [PATCH v1 2/3] kvm: sync linux headers

2018-05-30 Thread Dongjiu Geng
Import KVM_CAP_ARM_INJECT_SERROR_ESR and struct kvm_vcpu_events for arm64 Signed-off-by: Dongjiu Geng --- linux-headers/asm-arm64/kvm.h | 13 + linux-headers/linux/kvm.h | 1 + 2 files changed, 14 insertions(+) diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm6

[Qemu-devel] [PATCH v1 1/3] linux-headers: update to v4.17-rc7

2018-05-30 Thread Dongjiu Geng
Update headers against v4.17-rc7. Signed-off-by: Dongjiu Geng --- include/standard-headers/asm-x86/hyperv.h | 1 - include/standard-headers/asm-x86/kvm_para.h | 2 +- include/standard-headers/linux/ethtool.h| 36 ++- include/standard-headers/linux/input.h | 4 +-

[Qemu-devel] [PATCH v1 0/3] add support for VCPU event states

2018-05-30 Thread Dongjiu Geng
support for KVM_GET/SET_VCPU_EVENTS to get/set the SError exception state, and support the state migration. Dongjiu Geng (3): linux-headers: update to v4.17-rc7 kvm: sync linux headers target: arm: Add support for VCPU event states include/standard-headers/asm-x86/hyperv.h | 1 - i

[Qemu-devel] [PATCH v4] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code regarding seccomp command line options to qemu-seccomp.c file and wraps qemu_opts_foreac

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
在 2018/5/30 下午6:54, Eduardo Otubo 写道: Can you send a v4 with a cleaned up version? Also fixing a typo on the text (elevateDprivileges). Why elevateDprivileges? The option name in the code is 'elevateprivileges'.

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
在 2018/5/30 下午6:54, Eduardo Otubo 写道: On 29/05/2018 - 18:05:25, Yi Min Zhao wrote: 在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding ca

[Qemu-devel] Recording I/O activity after KVM does a VMEXIT

2018-05-30 Thread Arnabjyoti Kalita
Hello all, I am trying to implement a 'minimal' record-replay mechanism for KVM, which is similar to the one existing for TCG via -icount. I am trying to record I/O events only (specifically disk and network events) when KVM does a VMEXIT. This has led me to the function kvm_cpu_exec where I can c

[Qemu-devel] [PATCH v5 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

2018-05-30 Thread Shannon Zhao
While we skip the GIC_INTERNAL irqs, we don't change the register offset accordingly. This will overlap the GICR registers value and leave the last GIC_INTERNAL irq's registers out of update. Fix this by skipping the registers banked by GICR. Also for migration compatibility if the migration sour

[Qemu-devel] [PATCH v5 0/2] Fix ARM KVM GICv3 get/put data shift bug

2018-05-30 Thread Shannon Zhao
These two patches fix ARM KVM GICv3 get/put data shift bug and add compatibility fro migration from old qemu to new one. Major Changes in V5: * Add detailed comment as suggested by Peter * Use memmove instead of memcpy * Delete .need callback * set gicd_no_migration_shift_bug to true after move t

[Qemu-devel] [PATCH v5 1/2] arm_gicv3_kvm: kvm_dist_get/put_priority: skip the registers banked by GICR_IPRIORITYR

2018-05-30 Thread Shannon Zhao
While for_each_dist_irq_reg loop starts from GIC_INTERNAL, it forgot to offset the date array and index. This will overlap the GICR registers value and leave the last GIC_INTERNAL irq's registers out of update. Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920 Cc: qemu-sta...@nongnu.org Reviewed-by:

[Qemu-devel] [PATCH 1/2] block: Honour BDRV_REQ_NO_SERIALISING in copy range

2018-05-30 Thread Fam Zheng
This semantics is needed by drive-backup so implement it before using this API there. Signed-off-by: Fam Zheng --- block/io.c| 6 -- include/block/block.h | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/block/io.c b/block/io.c index b7beaeeb9f..f55e0c39f

[Qemu-devel] [PATCH 0/2] backup: Use copy offloading

2018-05-30 Thread Fam Zheng
Based-on: <20180529055959.32002-1-f...@redhat.com> ([PATCH v7 00/10] qemu-img convert with copy offloading) This enhances the backup job to make use of the copy offloading API. It eliminates the necessity to use the bounce buffer as well as speeding up the copy operation when the backend supports

[Qemu-devel] [PATCH 2/2] backup: Use copy offloading

2018-05-30 Thread Fam Zheng
The implementation is similar to the 'qemu-img convert'. In the beginning of the job, offloaded copy is attempted. If it fails, further I/O will go through the existing bounce buffer code path. Signed-off-by: Fam Zheng --- block/backup.c | 93 +++--

Re: [Qemu-devel] [PATCH v7 4/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-05-30 Thread Wei Wang
On 05/30/2018 08:47 PM, Michael S. Tsirkin wrote: On Wed, May 30, 2018 at 05:12:09PM +0800, Wei Wang wrote: On 05/29/2018 11:24 PM, Michael S. Tsirkin wrote: On Tue, Apr 24, 2018 at 02:13:47PM +0800, Wei Wang wrote: +/* + * Balloon will report pages which were free at the time of this call. As

[Qemu-devel] [PATCH v3] qga: add mountpoint usage to GuestFilesystemInfo

2018-05-30 Thread Chen Hanxiao
From: Chen Hanxiao This patch adds support for getting the usage of mounted filesystem. It's very useful when we try to monitor guest's filesystem. Cc: Michael Roth Cc: Eric Blake Signed-off-by: Chen Hanxiao --- v2: add description in qapi-schema and version numbers v3: use float for u

Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board

2018-05-30 Thread Jason A. Donenfeld
Hi Peter, What ever became of this? I still really could use a second UART in the standard configuration. I'm still building with this cludge -- https://א.cc/RXI3ssWV -- in order to run the test suite on build.wireguard.com. Thanks, Jason

Re: [Qemu-devel] [PATCH] tap: fix memory leak on success to create a tap device

2018-05-30 Thread Jason Wang
On 2018年05月30日 21:52, wangyunjian wrote: From: Yunjian Wang Signed-off-by: Yunjian Wang --- Looks good, but please add some commit log and cc qemu-stable with Fixes tags. Thanks net/tap.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/net/tap

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type

2018-05-30 Thread Shannon Zhao
On 2018/5/31 0:18, Laszlo Ersek wrote: > +vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64); >> + Does it need a info log here to tell user that even though you enable the highmem_ecam but due to some other reasons it's disabled. Also, if user enables highmem_ecam but final

Re: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread Richard Henderson
On 05/30/2018 06:13 PM, Richard Henderson wrote: > +void tcg_gen_exit_tb(TranslationBlock *tb, unsigned idx) > +{ > +uintptr_t val = (uintptr_t)tb + idx; > + > +if (tb == NULL) { > +tcg_debug_assert(idx == 0); > +} else if (idx <= 1) { > +/* This is an exit following a g

Re: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180531011321.3119-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately === TEST SCRIPT BEGIN === #!/bin/bash # Testing script w

Re: [Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180531011321.3119-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH] tcg: Pass

[Qemu-devel] [PATCH] tcg: Pass tb and index to tcg_gen_exit_tb separately

2018-05-30 Thread Richard Henderson
Do the cast to uintptr_t within the helper, so that the compiler can type check the pointer argument. We can also do some more sanity checking of the index argument. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 +- tcg/tcg-op.h | 17 +

Re: [Qemu-devel] [RFC PATCH] configure: Enable out-of-tree acceptance tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 04:03 PM, Philippe Mathieu-Daudé wrote: > In order to allow out-of-tree acceptance tests with Avocado, > create a symlink in the build tree. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: 20180530184156.15634-1-cr...@redhat.com > http://lists.nongnu.org/archive/html/

[Qemu-devel] [PATCH 1/3] ahci: trim signatures on raise/lower

2018-05-30 Thread John Snow
These functions work on the AHCI device, not the individual AHCI devices, so trim the AHCIDevice argument. Signed-off-by: John Snow --- hw/ide/ahci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index e22d7be05f..b7a6f68790 100644 ---

[Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

2018-05-30 Thread John Snow
Commit d759c951f changed the main thread lock release/reacquisition, and in so doing apparently jostled loose a race condition in the AHCI code. Patch 2 should be sufficient to fix this, and patches 1 and 3 are just little trivial fixes. This might be sufficient to fix the bug as reported at http

[Qemu-devel] [PATCH 2/3] ahci: fix PxCI register race

2018-05-30 Thread John Snow
AHCI presently signals completion prior to the PxCI register being cleared to indicate completion. If a guest driver attempts to issue a new command in its IRQ handler, it might be surprised to learn there is still a command pending. In the case of Windows 10's boot driver, it will actually poll t

[Qemu-devel] [PATCH 3/3] ahci: don't schedule unnecessary BH

2018-05-30 Thread John Snow
The comment gives us a hint. *Maybe* we still have something to process. Well, why not check? Signed-off-by: John Snow --- hw/ide/ahci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index a9558e45e7..380366b038 100644 --- a/hw/ide/ahci.c +++

[Qemu-devel] [Bug 1769189] Re: Issue with qemu 2.12.0 + SATA

2018-05-30 Thread John Snow
There might be multiple issues present and I'm having difficulty reliably doing any kind of regression testing here, but I think this patch helps fix at least one of the issues I was seeing that occurs specifically during early boot. It may fix other hangs. ** Patch added: "sata.patch" https:

Re: [Qemu-devel] [RFC PATCH] configure: Enable out-of-tree acceptance tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 05:03:34PM -0300, Philippe Mathieu-Daudé wrote: > In order to allow out-of-tree acceptance tests with Avocado, > create a symlink in the build tree. > "In other to allow" seems to imply that running acceptance tests on an out-of-tree build is impossible without this patch,

Re: [Qemu-devel] [PATCH 01/20] target/openrisc: Remove DISAS_JUMP & DISAS_TB_JUMP

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:05AM -0500, Richard Henderson wrote: > These values are unused. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 06/20] target/openrisc: Exit the TB after l.mtspr

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:10AM -0500, Richard Henderson wrote: > A store to SR changes interrupt state, which should return > to the main loop to recognize that state. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 04/20] target/openrisc: Link more translation blocks

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:08AM -0500, Richard Henderson wrote: > Track direct jumps via dc->jmp_pc_imm. Use that in > preference to jmp_pc when possible. Emit goto_tb in > that case, and lookup_and_goto_tb otherwise. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 08/20] target/openrisc: Merge tlb allocation into CPUOpenRISCState

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:12AM -0500, Richard Henderson wrote: > There is no reason to allocate this separately. This was probably > copied from target/mips which makes the same mistake. > > While doing so, move tlb into the clear-on-reset range. While not > all of the TLB bits are guarantee

Re: [Qemu-devel] [PATCH 05/20] target/openrisc: Split out is_user

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:09AM -0500, Richard Henderson wrote: > This allows us to limit the amount of ifdefs and isolate > the test for usermode. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 00/20] target/openrisc improvements

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:04AM -0500, Richard Henderson wrote: > This is almost a grab-bag of little improvements to the port. > > patches 1-3: > Fix singlestepping for gdbstub. This has apparently never > worked, as the first commit has the same bug of not advancing > the pc when stepp

Re: [Qemu-devel] [PATCH 02/20] target/openrisc: Use exit_tb instead of CPU_INTERRUPT_EXITTB

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:06AM -0500, Richard Henderson wrote: > No need to use the interrupt mechanisms when we can > simply exit the tb directly. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

[Qemu-devel] [PULL 11/12] qmp: add set-numa-node command

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov Command is allowed to run only in preconfig stage and will allow to configure numa mapping for CPUs depending on possible CPUs layout (query-hotpluggable-cpus) for given machine instance. Example of configuration session: $QEMU -smp 2 --preconfig ... QMP: -> {'execute': 'que

[Qemu-devel] [PULL 12/12] tests: functional tests for QMP command set-numa-node

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov * start QEMU with 2 unmapped cpus, * while in preconfig state * add 2 numa nodes * assign cpus to them * exit preconfig and in running state check that cpus are mapped correctly. Signed-off-by: Igor Mammedov Message-Id: <1526556607-268163-1-git-send-email-imamm

Re: [Qemu-devel] [PATCH 03/20] target/openrisc: Fix singlestep_enabled

2018-05-30 Thread Stafford Horne
On Sun, May 27, 2018 at 09:13:07AM -0500, Richard Henderson wrote: > We failed to store to cpu_pc before raising the exception, > which caused us to re-execute the same insn that we stepped. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

[Qemu-devel] [PULL 10/12] qmp: permit query-hotpluggable-cpus in preconfig state

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov it will allow mgmt to query possible CPUs, which depends on used machine(version)/-smp options, without restarting QEMU and use results to configure numa mapping or adding CPUs with device_add* later. PS: *) device_add is not allowed to run at preconfig in this series but

[Qemu-devel] [PULL 09/12] tests: extend qmp test with preconfig checks

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov Add permission checks for commands at 'preconfig' stage. Signed-off-by: Igor Mammedov Message-Id: <1526556524-267991-1-git-send-email-imamm...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eduardo Habkost --- tests/qmp-test.c | 47

[Qemu-devel] [PULL 06/12] qapi: introduce new cmd option "allow-preconfig"

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov New option will be used to allow commands, which are prepared/need to run, during preconfig state. Other commands that should be able to run in preconfig state, should be amended to not expect machine in initialized state or deal with it. For compatibility reasons, commands t

[Qemu-devel] [PULL 08/12] cli: add --preconfig option

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, allowing the configuration of QEMU from QMP before the machine jumps into board initialization code of machine_run_board_init() The intent is to allow management to query machine state and additionally conf

[Qemu-devel] [PULL 07/12] tests: qapi-schema tests for allow-preconfig

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov use new allow-preconfig parameter in tests and make sure that the QAPISchema can parse allow-preconfig correctly Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Message-Id: <1526058959-41425-1-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- tes

[Qemu-devel] [PULL 04/12] qapi: introduce preconfig runstate

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov New preconfig runstate will be used in follow up patches related to introducing --preconfig CLI option and is intended to replace prelaunch runstate from QEMU start up to machine_init callback. Signed-off-by: Igor Mammedov Message-Id: <1525423069-61903-4-git-send-email-imamm

[Qemu-devel] [PULL 05/12] hmp: disable monitor in preconfig state

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov Ban it for now, if someone would need it to work early, one would have to implement checks if HMP command is valid at preconfig state. Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Message-Id: <1525423069-61903-5-git-send-email-imamm...@redhat.com> Signed-off-by: Edu

[Qemu-devel] [PULL 02/12] numa: postpone options post-processing till machine_run_board_init()

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov in preparation for numa options to being handled via QMP before machine_run_board_init(), move final numa configuration checks and processing to machine_run_board_init() so it could take into account both CLI (via parse_numa_opts()) and QMP input Signed-off-by: Igor Mammedov

[Qemu-devel] [PULL 03/12] numa: split out NumaOptions parsing into set_numa_options()

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov it will allow to reuse set_numa_options() for parsing configuration commands received via QMP interface Signed-off-by: Igor Mammedov Message-Id: <1525423069-61903-3-git-send-email-imamm...@redhat.com> Signed-off-by: Eduardo Habkost --- include/sysemu/numa.h | 1 + numa.c

[Qemu-devel] [PULL 01/12] numa: clarify error message when node index is out of range in -numa dist, ...

2018-05-30 Thread Eduardo Habkost
From: Igor Mammedov When using following CLI: -numa dist,src=128,dst=1,val=20 user gets a rather confusing error message: "Invalid node 128, max possible could be 128" Where 128 is number of nodes that QEMU supports (MAX_NODES), while src/dst is an index up to that limit, so it should be MA

[Qemu-devel] [PULL 00/12] NUMA queue, 2018-05-30

2018-05-30 Thread Eduardo Habkost
The following changes since commit e609fa71e89c81fbe2670411be62da95dfb093e0: Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2018-05-29-v1.for-upstream' into staging (2018-05-29 13:01:11 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git ta

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-05-30 Thread Richard Henderson
On 05/30/2018 03:46 PM, Richard Henderson wrote: > Thanks. Queued to tcg-next. Hmph. Unqueued, at least for now. ERROR:/home/rth/work/qemu/qemu/accel/tcg/translate-all.c:615:page_unlock__debug: assertion failed: (page_is_locked(pd)) #3 0x74b6915e in g_assertion_message_expr () at /

Re: [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3

2018-05-30 Thread Richard Henderson
On 05/21/2018 04:39 PM, Emilio G. Cota wrote: > v2: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00656.html > > Changes since v2: > > - rebase onto master, fixing conflicts > > - add R-b's > > - add a missing page_lock to page_collection_lock > > - add a couple of missing assert

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 05:31 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 05:03:56PM -0400, Cleber Rosa wrote: >> On 05/30/2018 04:00 PM, Eduardo Habkost wrote: > [...] >> [...] Now, in addition to this very personal, and thus >> insignificant botheration, it restricts API design. By sig

Re: [Qemu-devel] [PATCH 00/15] linux-user: move more definitions out of syscall_defs.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > Move fcntl.h definitions to target directories. > Introduce a generic header for the targets without > specific definitions. > Move more signal.h definitions to target directories. > > Laurent Vivier (15): > linux-user: move generic fcntl definitio

Re: [Qemu-devel] [PATCH 08/15] linux-user: move get_sp_from_cpustate() to target_cpu.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:42 PM, Laurent Vivier wrote: > Remove useless includes > Fix HPPA include guard. > > Signed-off-by: Laurent Vivier > --- Acked-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 04/15] linux-user: move arm/aarch64/m68k fcntl definitions to [arm|aarch64|m68k]/target_fcntl.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > No code change. > > Signed-off-by: Laurent Vivier > --- > linux-user/aarch64/target_fcntl.h | 5 + > linux-user/arm/target_fcntl.h | 6 ++ > linux-user/m68k/target_fcntl.h| 6 ++ > linux-user/syscall_defs.h | 7 +-- >

Re: [Qemu-devel] [PATCH 03/15] linux-user: move hppa fcntl definitions to hppa/target_fcntl.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > No code change. > > Signed-off-by: Laurent Vivier > --- > linux-user/hppa/target_fcntl.h | 31 +++ > linux-user/syscall_defs.h | 34 +- > 2 files changed, 32 insertions(+), 33 deletio

Re: [Qemu-devel] [PATCH 02/15] linux-user: move alpha fcntl definitions to alpha/target_fcntl.h

2018-05-30 Thread Richard Henderson
On 05/29/2018 12:41 PM, Laurent Vivier wrote: > No code change. > > Signed-off-by: Laurent Vivier > --- > linux-user/alpha/target_fcntl.h | 29 + > linux-user/syscall_defs.h | 32 ++-- > 2 files changed, 31 insertions(+), 30 deletions

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 05:03:56PM -0400, Cleber Rosa wrote: > On 05/30/2018 04:00 PM, Eduardo Habkost wrote: [...] > [...] Now, in addition to this very personal, and thus > insignificant botheration, it restricts API design. By signaling to > users that this is valid: > > self.vm.add_

Re: [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort()

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 05:23 PM, John Snow wrote: > On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote: >> Use error_report() + abort() instead of error_setg(&error_abort), >> as suggested by the "qapi/error.h" documentation: >> >> Please don't error_setg(&error_fatal, ...), use error_report() and >>

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 05:17 PM, John Snow wrote: > On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On 05/25/2018 08:54 PM, John Snow wrote: >>> A trace is added to let us watch unimplemented registers specifically, >>> as these are more likely to cause us trouble. Otherwise, the por

Re: [Qemu-devel] [PATCH v4 4/5] scripts/qemu.py: introduce set_console() method

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 03:41 PM, Cleber Rosa wrote: > The set_console() method is intended to ease higher level use cases > that require a console device. > > The amount of intelligence is limited on purpose, requiring either the > device type explicitly, or the existence of a machine (pattern) > definitio

Re: [Qemu-devel] [PATCH v4 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 03:41 PM, Cleber Rosa wrote: > This patch adds a few simple behavior tests for VNC. > > Signed-off-by: Cleber Rosa > Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > tests/acceptance/vnc.py | 60

Re: [Qemu-devel] [PATCH v4 2/5] scripts/qemu.py: allow adding to the list of extra arguments

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 03:41 PM, Cleber Rosa wrote: > Tests will often need to add extra arguments to QEMU command > line arguments. > > Signed-off-by: Cleber Rosa > Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > scripts/qemu.py | 6 ++

Re: [Qemu-devel] [PATCH v4 1/5] Add functional/acceptance tests infrastructure

2018-05-30 Thread Philippe Mathieu-Daudé
Hi Cleber, On 05/30/2018 03:41 PM, Cleber Rosa wrote: > This patch adds the very minimum infrastructure necessary for writing > and running functional/acceptance tests, including: > > * Documentation > * The avocado_qemu.Test base test class > * One example tests (version.py) > > Additional f

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Cleber Rosa
On 05/30/2018 04:00 PM, Eduardo Habkost wrote: > On Wed, May 30, 2018 at 02:00:48PM -0400, Cleber Rosa wrote: >> >> >> On 05/30/2018 12:29 PM, Eduardo Habkost wrote: >>> On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wr

Re: [Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot and console checking test

2018-05-30 Thread Philippe Mathieu-Daudé
Hi Cleber, On 05/30/2018 03:41 PM, Cleber Rosa wrote: > This test boots a Linux kernel, and checks that the given command > line was effective in two ways: > > * It makes the kernel use the set "console device" as a console > * The kernel records the command line as expected in the console > >

Re: [Qemu-devel] [PATCH] Fix hang with -L and symlink loop

2018-05-30 Thread Richard Henderson
On 05/29/2018 04:44 PM, Evan Green wrote: > When using -L with Linux app emulation, there is an issue in > init_paths where Qemu will get lost exploring a directory tree > with a symlink loop in it. This causes Qemu to hang, and > eventually consume all memory in the system. > > Qemu's code for pr

Re: [Qemu-devel] [Qemu-block] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job

2018-05-30 Thread John Snow
On 05/29/2018 08:30 AM, Max Reitz wrote: > On 2018-05-29 13:59, Kashyap Chamarthy wrote: >> On Fri, May 25, 2018 at 10:00:35AM +0200, Kevin Wolf wrote: >>> Am 24.05.2018 um 19:42 hat John Snow geschrieben: >> >> [...] >> >> (Randomly chiming in for a small clarification.) >> >> or some other

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2018-05-30 Thread Andreas Hasenack
Doing the same for the debian task, which doesn't have an upstream bug anyway. ** Changed in: qemu (Debian) Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/685096 Titl

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2018-05-30 Thread Andreas Hasenack
Also marking the ubuntu task as incomplete. It looks like it's sorted, but let's give it some time for people to comment if they still have an issue. ** Changed in: qemu (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-

Re: [Qemu-devel] [PATCH v4 20/21] hw/ide: Remove unused include

2018-05-30 Thread John Snow
On 05/28/2018 07:27 PM, Philippe Mathieu-Daudé wrote: > There is no need to include pci.h in this file. > (Continue f23c81073a cleanup). > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: John Snow

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: fix dirty_bitmap_load

2018-05-30 Thread John Snow
On 05/30/2018 07:24 AM, Vladimir Sementsov-Ogievskiy wrote: > dirty_bitmap_load_header return code is obtained but not handled. Fix > this. > > Bug was introduced in b35ebdf076d697bc > "migration: add postcopy migration of dirty bitmaps" with the whole > function. > > Signed-off-by: Vladimir S

Re: [Qemu-devel] [PATCH] main-loop: drop spin_counter

2018-05-30 Thread Jeff Cody
On Wed, May 30, 2018 at 08:42:38PM +0100, Stefan Hajnoczi wrote: > Commit d759c951f3287fad04210a52f2dc93f94cf58c7f ("replay: push > replay_mutex_lock up the call tree") removed the !timeout lock > optimization in the main loop. > > The idea of the optimization was to avoid ping-pongs between threa

Re: [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort()

2018-05-30 Thread John Snow
On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote: > Use error_report() + abort() instead of error_setg(&error_abort), > as suggested by the "qapi/error.h" documentation: > > Please don't error_setg(&error_fatal, ...), use error_report() and > exit(), because that's more obvious. >

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-30 Thread John Snow
On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 05/25/2018 08:54 PM, John Snow wrote: >> A trace is added to let us watch unimplemented registers specifically, >> as these are more likely to cause us trouble. Otherwise, the port read >> traces now tell us what register i

Re: [Qemu-devel] [PATCH v3 3/5] Acceptance tests: add quick VNC tests

2018-05-30 Thread Eduardo Habkost
On Wed, May 30, 2018 at 02:00:48PM -0400, Cleber Rosa wrote: > > > On 05/30/2018 12:29 PM, Eduardo Habkost wrote: > > On Wed, May 30, 2018 at 01:57:05PM +0100, Stefan Hajnoczi wrote: > >> On Tue, May 29, 2018 at 03:37:28PM -0400, Cleber Rosa wrote: > >>> This patch adds a few simple behavior test

[Qemu-devel] [RFC PATCH] configure: Enable out-of-tree acceptance tests

2018-05-30 Thread Philippe Mathieu-Daudé
In order to allow out-of-tree acceptance tests with Avocado, create a symlink in the build tree. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: 20180530184156.15634-1-cr...@redhat.com http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg06877.html Before: build_dir$ avocado run /f

[Qemu-devel] [PATCH] main-loop: drop spin_counter

2018-05-30 Thread Stefan Hajnoczi
Commit d759c951f3287fad04210a52f2dc93f94cf58c7f ("replay: push replay_mutex_lock up the call tree") removed the !timeout lock optimization in the main loop. The idea of the optimization was to avoid ping-pongs between threads by keeping the Big QEMU Lock held across non-blocking (!timeout) main lo

Re: [Qemu-devel] [PATCH v3 4/5] scripts/qemu.py: introduce set_console() method

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:29PM -0400, Cleber Rosa wrote: > The set_console() method is intended to ease higher level use cases > that require a console device. > > The amount of intelligence is limited on purpose, requiring either the > device type explicitly, or the existence of a machine (pa

Re: [Qemu-devel] [PATCH v3 5/5] Acceptance tests: add Linux kernel boot and console checking test

2018-05-30 Thread Stefan Hajnoczi
On Tue, May 29, 2018 at 03:37:30PM -0400, Cleber Rosa wrote: > This test boots a Linux kernel, and checks that the given command > line was effective in two ways: > > * It makes the kernel use the set "console device" as a console > * The kernel records the command line as expected in the consol

  1   2   3   4   >