Re: [Qemu-devel] [PATCH RFC v6 6/7] migration: fix some error handling

2018-10-31 Thread Fei Li
On 11/01/2018 12:30 AM, Dr. David Alan Gilbert wrote: * Fei Li (f...@suse.com) wrote: On 10/31/2018 03:49 AM, Dr. David Alan Gilbert wrote: * Fei Li (f...@suse.com) wrote: Add error handling for qemu_ram_foreach_migratable_block() when it fails. Always call migrate_set_error() to set the

Re: [Qemu-devel] [PULL 00/15] Python queue, 2018-10-30

2018-10-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181031003120.26771-1-ehabk...@redhat.com Subject: [Qemu-devel] [PULL 00/15] Python queue, 2018-10-30 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH v3 00/13] arm: nRF51 Devices and Microbit Support

2018-10-31 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181031002526.14262-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v3 00/13]

Re: [Qemu-devel] [PATCH v3 00/13] arm: nRF51 Devices and Microbit Support

2018-10-31 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181031002526.14262-1-cont...@steffen-goertz.de Subject: [Qemu-devel] [PATCH v3 00/13]

[Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication

2018-10-31 Thread Zhang Chen
This compilation issue will occur when user use --disable-replication to config Qemu. Reported-by: Thomas Huth Signed-off-by: Zhang Chen --- migration/colo.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/migration/colo.c b/migration/colo.c

Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-31 Thread Zhang Chen
On Wed, Oct 31, 2018 at 3:54 AM Dr. David Alan Gilbert wrote: > * Zhang Chen (zhangc...@gmail.com) wrote: > > This compilation issue will occur when user use --disable-replication > > to config Qemu. > > > > Reported-by: Thomas Huth > > Signed-off-by: Zhang Chen > > OK; do we need to add a

[Qemu-devel] one issue about usb passsthrough devices

2018-10-31 Thread linzhecheng
Hi, all A found a problem about libusb, the reproducing steps are as followed: 1. start up a vm with host-usb devices 2. kill -9 `pgrep qemu` We can not see the usb device on host any more, I think this is because qemu has no chance to release resources to kernel in this case. How can we recover

Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-31 Thread Zhang Chen
On Thu, Nov 1, 2018 at 12:47 AM Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Zhang Chen (zhangc...@gmail.com) wrote: > > > This compilation issue will occur when user use --disable-replication > > > to config Qemu. > > > > > > Reported-by: Thomas

Re: [Qemu-devel] [PATCH v3 15/16] gdbstub: add multiprocess extension support

2018-10-31 Thread Alistair
On 10/26/18 1:16 AM, Luc Michel wrote: Add multiprocess extension support by enabling multiprocess mode when the peer requests it, and by replying that we actually support it in the qSupported reply packet. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Acked-by: Alistair

Re: [Qemu-devel] [PATCH v3 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached

2018-10-31 Thread Alistair
On 10/26/18 1:16 AM, Luc Michel wrote: When gdb_set_stop_cpu() is called with a CPU associated to a process currently not attached by the GDB client, return without modifying the stop CPU. Otherwise, GDB get confused if it receives packets with a s/get/gets/g Acked-by: Alistair Francis

Re: [Qemu-devel] [PATCH v3 03/16] gdbstub: add multiprocess support to '?' packets

2018-10-31 Thread Alistair
On 10/26/18 1:16 AM, Luc Michel wrote: The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It checks if the CPU is a direct child of a CPU cluster. If it is, the returned PID is the cluster ID plus one (cluster IDs start at 0, GDB PIDs at 1). When the CPU is not a child of such

Re: [Qemu-devel] [PATCH v3 02/16] gdbstub: introduce GDB processes

2018-10-31 Thread Alistair
On 10/26/18 1:16 AM, Luc Michel wrote: Add a structure GDBProcess that represent processes from the GDB semantic point of view. CPUs can be split into different processes, by grouping them under different cpu-cluster objects. Each occurrence of a cpu-cluster object implies the existence of the

Re: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation

2018-10-31 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181029173437.32559-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/4]

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-10-31 Thread Liran Alon
> On 31 Oct 2018, at 20:59, Dr. David Alan Gilbert wrote: > > * Liran Alon (liran.a...@oracle.com) wrote: >> >> >>> On 31 Oct 2018, at 20:19, Paolo Bonzini wrote: >>> >>> On 31/10/2018 19:17, Eduardo Habkost wrote: On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote: >

Re: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation

2018-10-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181029173437.32559-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

2018-10-31 Thread Richard Henderson
On 10/31/18 9:35 PM, Max Filippov wrote: > gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b > and dc233c configurations. As a result the following message is > displayed when attaching to an xtensa linux-user process: > > "Register 105 is not available", > > and gdb is

Re: [Qemu-devel] [PATCH v3 35/35] target/riscv: Remaining rvc insn reuse 32 bit translators

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > only a translate functions of rvc need to handle special cases. For > the other rvc instruction we can remove the extra layer of indirection. > > Signed-off-by: Bastian Koppelmann > --- > target/riscv/insn16.decode | 37

Re: [Qemu-devel] [PATCH v3 34/35] target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > it splices flwsp_ldsp, fswsp_sdsp, and jal_addiw and makes each of them > reuse the code generator used for the non compressed insns. > > Signed-off-by: Bastian Koppelmann > --- > target/riscv/insn16-32.decode | 7 + >

Re: [Qemu-devel] [PATCH v3 33/35] target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > this finally removes the old decoder functions that we carried along > with it. > > Signed-off-by: Bastian Koppelmann > --- > target/riscv/Makefile.objs | 1 + > target/riscv/insn16-32.decode | 24 >

Re: [Qemu-devel] [PATCH v3 32/35] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > --- > target/riscv/insn16.decode | 20 ++-- > target/riscv/insn32.decode | 3 ++- > target/riscv/insn_trans/trans_rvc.inc.c | 24 > 3 files

Re: [Qemu-devel] [PATCH v3 31/35] target/riscv: Convert @cs_2 insns to share translation functions

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > These all expand simply to R format instructions. > > Signed-off-by: Bastian Koppelmann > --- > target/riscv/Makefile.objs | 10 +++--- > target/riscv/insn16-64.decode | 24 ++ > target/riscv/insn16.decode

Re: [Qemu-devel] [PATCH v3 27/35] target/riscv: Remove manual decoding of RV32/64M insn

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt > --- > v2 -> v3: > - trans_mulw now uses gen_mulw which properly sign extends the result > - gen_arith_w -> gen_arith_div_w > - gen_arith_div_w properly sign extends the

Re: [Qemu-devel] [PATCH v3 26/35] target/riscv: Remove shift and slt insn manual decoding

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > static bool trans_slt(DisasContext *ctx, arg_slt *a) > { > -gen_arith(ctx, OPC_RISC_SLT, a->rd, a->rs1, a->rs2); > +TCGv source1 = tcg_temp_new(); > +TCGv source2 = tcg_temp_new(); > + > +gen_get_gpr(source1, a->rs1); > +

Re: [Qemu-devel] [PATCH v3 25/35] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists

2018-10-31 Thread Richard Henderson
On 10/31/18 8:44 PM, Alistair Francis wrote: > This series causes a lot of kernel oops during boot... The only bug I can see is in trans_addw. But that's a biggie and could easily explain, since non-extended values could have caused a compare to misfire. r~

Re: [Qemu-devel] [PATCH v3 25/35] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > static bool trans_addw(DisasContext *ctx, arg_addw *a) > { > -gen_arith(ctx, OPC_RISC_ADDW, a->rd, a->rs1, a->rs2); > -return true; > +return trans_arith(ctx, a, _gen_add_tl); > } This should be using gen_addw. r~

Re: [Qemu-devel] [PATCH v3 24/35] target/riscv: Move gen_arith_imm() decoding into trans_* functions

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > + > +#ifdef TARGET_RISCV64 > +static void gen_addiw(TCGv ret, TCGv arg1, TCGv arg2) > +{ > +tcg_gen_add_tl(ret, arg1, arg2); > +tcg_gen_ext32s_tl(ret, ret); > +} > +#endif This should have been called gen_addw. It takes no immediate. r~

Re: [Qemu-devel] [PATCH v3 24/35] target/riscv: Move gen_arith_imm() decoding into trans_* functions

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > static bool trans_slli(DisasContext *ctx, arg_slli *a) > { > -gen_arith_imm(ctx, OPC_RISC_SLLI, a->rd, a->rs1, a->shamt); > +if (a->rd != 0) { > +TCGv t = tcg_temp_new(); > +gen_get_gpr(t, a->rs1); > + > +if

Re: [Qemu-devel] [PATCH v3 22/35] target/riscv: Remove manual decoding from gen_load()

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > With decodetree we don't need to convert RISC-V opcodes into to MemOps > as the old gen_load() did. > > Reviewed-by: Richard Henderson > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt Reviewed-by: Richard Henderson > +static

Re: [Qemu-devel] [PATCH v3 23/35] target/riscv: Remove manual decoding from gen_store()

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > +static bool gen_store(DisasContext *ctx, arg_sb *a, int memop) Likewise with TCGMemOp. r~

Re: [Qemu-devel] [PATCH v3] arm: exynos4: Add dma support for smdkc210

2018-10-31 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20181030193044.25954-1-phi...@redhat.com Subject: [Qemu-devel] [PATCH v3] arm: exynos4:

[Qemu-devel] [PATCH 11/12] file-posix: Switch to .bdrv_co_ioctl

2018-10-31 Thread Kevin Wolf
No real reason to keep using the callback based mechanism here when the rest of the file-posix driver is coroutine based. Changing it brings ioctls more in line with how other request types work. Signed-off-by: Kevin Wolf --- include/scsi/pr-manager.h | 8 +++- block/file-posix.c|

[Qemu-devel] [PATCH 10/12] file-posix: Remove paio_submit_co()

2018-10-31 Thread Kevin Wolf
The function is not used any more, remove it. Signed-off-by: Kevin Wolf --- block/file-posix.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index c5e83140d3..821743d2b2 100644 --- a/block/file-posix.c +++

[Qemu-devel] [PATCH 01/12] file-posix: Reorganise RawPosixAIOData

2018-10-31 Thread Kevin Wolf
RawPosixAIOData contains a lot of fields for several separate operations that are to be processed in a worker thread and that need different parameters. The struct is currently rather unorganised, with unions that cover some, but not all operations, and even one #define for field names instead of

[Qemu-devel] [PATCH 12/12] file-posix: Avoid aio_worker() for QEMU_AIO_IOCTL

2018-10-31 Thread Kevin Wolf
aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on

[Qemu-devel] [PATCH 05/12] file-posix: Avoid aio_worker() for QEMU_AIO_WRITE_ZEROES

2018-10-31 Thread Kevin Wolf
aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on

[Qemu-devel] [PATCH 08/12] file-posix: Move read/write operation logic out of aio_worker()

2018-10-31 Thread Kevin Wolf
aio_worker() for reads and writes isn't boring enough yet. It still does some postprocessing for handling short reads and turning the result into the right return value. However, there is no reason why handle_aiocb_rw() couldn't do the same, and even without duplicating code between the read and

[Qemu-devel] [PATCH 04/12] file-posix: Avoid aio_worker() for QEMU_AIO_COPY_RANGE

2018-10-31 Thread Kevin Wolf
aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on

[Qemu-devel] [PATCH 09/12] file-posix: Avoid aio_worker() for QEMU_AIO_READ/WRITE

2018-10-31 Thread Kevin Wolf
aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on

[Qemu-devel] [PATCH 07/12] file-posix: Avoid aio_worker() for QEMU_AIO_FLUSH

2018-10-31 Thread Kevin Wolf
aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on

[Qemu-devel] [PATCH 03/12] file-posix: Avoid aio_worker() for QEMU_AIO_TRUNCATE

2018-10-31 Thread Kevin Wolf
aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on

[Qemu-devel] [PATCH 06/12] file-posix: Avoid aio_worker() for QEMU_AIO_DISCARD

2018-10-31 Thread Kevin Wolf
aio_worker() doesn't add anything interesting, it's only a useless indirection. Call the handler function directly instead. As we know that this handler function is only called from coroutine context and the coroutine stays around until the worker thread finishes, we can keep RawPosixAIOData on

[Qemu-devel] [PATCH 02/12] file-posix: Factor out raw_thread_pool_submit()

2018-10-31 Thread Kevin Wolf
Getting the thread pool of the AioContext of a block node and scheduling some work in it is an operation that is already done twice, and we'll get more instances. Factor it out into a separate function. Signed-off-by: Kevin Wolf --- block/file-posix.c | 17 ++--- 1 file changed, 10

[Qemu-devel] [PATCH 00/12] file-posix: Simplify delegation to worker thread

2018-10-31 Thread Kevin Wolf
This series cleans up and simplifies the code that calls worker thread functions for the various operations in the file-posix driver. This results in less indirection and better readability as well as reduced heap allocations because we can store ACBs on the coroutine stack now. Kevin Wolf (12):

[Qemu-devel] [PATCH] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

2018-10-31 Thread Max Filippov
gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b and dc233c configurations. As a result the following message is displayed when attaching to an xtensa linux-user process: "Register 105 is not available", and gdb is unable to control the inferior. Now that

[Qemu-devel] [PATCH v4] lsi_scsi: Reselection needed to remove pending commands from queue

2018-10-31 Thread George Kennedy
Under heavy IO (e.g. fio) the queue is not checked frequently enough for pending commands. As a result some pending commands are timed out by the linux sym53c8xx driver, which sends SCSI Abort messages for the timed out commands. The SCSI Abort messages result in linux errors, which show up on the

Re: [Qemu-devel] [PATCH v3 20/35] target/riscv: Remove gen_jalr()

2018-10-31 Thread Alistair
On 10/31/18 6:20 AM, Bastian Koppelmann wrote: trans_jalr() is the only caller, so move the code into trans_jalr(). Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis Alistair ---

Re: [Qemu-devel] [PATCH v3 11/35] target/riscv: Convert RV64A insns to decodetree

2018-10-31 Thread Alistair
On 10/31/18 6:20 AM, Bastian Koppelmann wrote: Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis Alistair --- v2 -> v3: - moved 64-bit only insn to insn64.decode - dropped insn argument of trans_foo functions

Re: [Qemu-devel] [PATCH v3 08/35] target/riscv: Convert RVXI csr insns to decodetree

2018-10-31 Thread Alistair
On 10/31/18 6:20 AM, Bastian Koppelmann wrote: Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis Alistair --- v2 -> v3: - dropped insn argument of trans_foo functions target/riscv/insn32.decode | 8

Re: [Qemu-devel] [PATCH v3 25/35] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists

2018-10-31 Thread Alistair Francis
On Wed, Oct 31, 2018 at 6:29 AM Bastian Koppelmann wrote: > > manual decoding in gen_arith() is not necessary with decodetree. For now > the function is called trans_arith as the original gen_arith still > exists. The former will be renamed to gen_arith as soon as the old > gen_arith can be

Re: [Qemu-devel] [PATCH v3 09/35] target/riscv: Convert RVXM insns to decodetree

2018-10-31 Thread Alistair
On 10/31/18 6:20 AM, Bastian Koppelmann wrote: Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis Alistair --- v2 -> v3: - moved 64-bit only insn to insn64.decode - dropped insn argument of trans_foo functions

Re: [Qemu-devel] [PATCH v3 07/35] target/riscv: Convert RVXI fence insns to decodetree

2018-10-31 Thread Alistair
On 10/31/18 6:20 AM, Bastian Koppelmann wrote: Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis Alistair --- v2 -> v3: - removed %pred/%succ - dropped insn argument of trans_foo functions

Re: [Qemu-devel] [PATCH v3 06/35] target/riscv: Convert RVXI arithmetic insns to decodetree

2018-10-31 Thread Alistair
On 10/31/18 6:20 AM, Bastian Koppelmann wrote: we cannot remove the call to gen_arith() in decode_RV32_64G() since it is used to translate multiply instructions. Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis Alistair --- v2 -> v3: - moved

Re: [Qemu-devel] [PATCH v2 10/10] hostmem: use object id for memory region name with >= 3.1

2018-10-31 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 07:04:53PM +0400, Marc-André Lureau wrote: > hostmem-file and hostmem-memfd use the whole object path for the > memory region name, and hostname-ram uses only the path component (the > object id, or canonical path basename): > > qemu -m 1024 -object

Re: [Qemu-devel] [PATCH v3 05/35] target/riscv: Convert RV64I load/store insns to decodetree

2018-10-31 Thread Alistair
On 10/31/18 6:19 AM, Bastian Koppelmann wrote: this splits the 64-bit only instructions into its own decode file such that we generate the decoder for these instructions only for the RISC-V 64 bit target. Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis

Re: [Qemu-devel] [PATCH v2 07/10] qom/object: add set_globals flags

2018-10-31 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 07:04:50PM +0400, Marc-André Lureau wrote: > Guard against calling object_property_set_globals() for all objects, > check that the class flag set_globals is set before. No need to guard > in object_property_set_globals() anymore. > > Only QDev & user-creatable objects have

Re: [Qemu-devel] [PATCH v2 03/10] qdev: move qdev_prop_register_global_list() to tests

2018-10-31 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 07:04:46PM +0400, Marc-André Lureau wrote: > The function is only used by a test, move it there. > > Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost I would still like to reduce duplication between machine_register_compat_props() and

Re: [Qemu-devel] [PATCH v3 02/35] target/riscv: Activate decodetree and implemnt LUI & AUIPC

2018-10-31 Thread Alistair
On 10/31/18 6:19 AM, Bastian Koppelmann wrote: for now only LUI & AUIPC are decoded and translated. If decodetree fails, we fall back to the old decoder. Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt Acked-by: Alistair Francis Alistair ---

Re: [Qemu-devel] [PATCH v2 09/10] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

2018-10-31 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 07:04:52PM +0400, Marc-André Lureau wrote: > The following patch is going to add compatiblity parameters. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Michael S. Tsirkin Reviewed-by: Eduardo Habkost I'm really surprised we spent the whole 3.1 development cycle

Re: [Qemu-devel] [PATCH v3 01/35] target/riscv: Move CPURISCVState pointer to DisasContext

2018-10-31 Thread Alistair Francis
On Wed, Oct 31, 2018 at 6:27 AM Bastian Koppelmann wrote: > > CPURISCVState is rarely used, so there is no need to pass it to every > translate function. This paves the way for decodetree which only passes > DisasContext to translate functions. > > Reviewed-by: Palmer Dabbelt > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 05/10] qom/globals: generalize object_property_set_globals()

2018-10-31 Thread Eduardo Habkost
On Tue, Oct 30, 2018 at 07:04:48PM +0400, Marc-André Lureau wrote: > Handle calls of object_property_set_globals() with any object type, > but only apply globals to TYPE_DEVICE & TYPE_USER_CREATABLE. > > Signed-off-by: Marc-André Lureau > --- > qom/globals.c | 22 ++ > 1

Re: [Qemu-devel] [PATCH v6 0/5] Connect a PCIe host and graphics support to RISC-V

2018-10-31 Thread Alistair Francis
On Wed, Oct 31, 2018 at 7:51 AM Andrea Bolognani wrote: > > On Tue, 2018-10-30 at 22:17 +, Alistair Francis wrote: > > V6: > > - Fix the interrupt issue for the GPEX device > > I gave this a spin. > > With the pcie.0 <- pcie-root-port <- virtio-net-pci setup I get > > qemu-system-riscv64:

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread John Snow
On 10/31/2018 02:58 PM, Eduardo Habkost wrote: > On Wed, Oct 31, 2018 at 02:37:36PM -0400, John Snow wrote: >> >> >> On 10/31/2018 02:06 PM, Eduardo Habkost wrote: >>> On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote:

Re: [Qemu-devel] [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups

2018-10-31 Thread Eduardo Habkost
On Wed, Oct 31, 2018 at 11:14:48AM +0100, David Hildenbrand wrote: > On 23.10.18 17:22, David Hildenbrand wrote: > > While working on memory device code, I noticed that specifiying an uint64_t > > on command line does not work in all cases as we always parse an int64_t. > > So I fix that and also

[Qemu-devel] [Bug 1800786] Re: USB assertion `s->csw.sig == cpu_to_le32(0x53425355)' failed

2018-10-31 Thread Dr. David Alan Gilbert
Hi, 1.7.2 is a really old version of qemu; why are you using that? Does it happen with a newer version? When you say 'Qemu crashed after starting and stopping VM for many times' do you mean starting a VM and shutting it down completely, or do you mean some type of pause/resume? When

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-10-31 Thread Dr. David Alan Gilbert
* Liran Alon (liran.a...@oracle.com) wrote: > > > > On 31 Oct 2018, at 20:19, Paolo Bonzini wrote: > > > > On 31/10/2018 19:17, Eduardo Habkost wrote: > >> On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote: > >>> Ping. > >>> Patch was submitted almost two months ago and I haven’t seen

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread Eduardo Habkost
On Wed, Oct 31, 2018 at 02:37:36PM -0400, John Snow wrote: > > > On 10/31/2018 02:06 PM, Eduardo Habkost wrote: > > On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: > >> > >> > >> On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > >>> Hi Gerd, > >>> > >>> On 30/10/18 12:13, Gerd

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-10-31 Thread Liran Alon
> On 31 Oct 2018, at 20:19, Paolo Bonzini wrote: > > On 31/10/2018 19:17, Eduardo Habkost wrote: >> On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote: >>> Ping. >>> Patch was submitted almost two months ago and I haven’t seen any respond >>> for the v2 of this series. >> Sorry for

Re: [Qemu-devel] [PATCH 0/2] Deprecate the "collie" machine and Strongarm devices

2018-10-31 Thread Thomas Huth
On 2018-10-29 13:24, Peter Maydell wrote: > On 27 October 2018 at 12:04, Guenter Roeck wrote: >> On 10/26/18 3:12 AM, Peter Maydell wrote: >>> Hi Guenter; there's a proposal here to deprecate (and eventually >>> remove) the 'collie' board (strongarm) from QEMU. Is that one of >>> the ones you're

Re: [Qemu-devel] [PULL 8/8] softfloat: Specialize udiv_qrnnd for ppc64

2018-10-31 Thread Laurent Vivier
On 05/10/2018 20:02, Richard Henderson wrote: > The ISA has a 128/64-bit division instruction, though it assumes the > low 64-bits of the numerator are 0, and so requires a bit more fixup > than a full 128-bit division insn. > > Reviewed-by: David Gibson > Signed-off-by: Richard Henderson > ---

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread John Snow
On 10/31/2018 02:06 PM, Eduardo Habkost wrote: > On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: >> >> >> On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: >>> Hi Gerd, >>> >>> On 30/10/18 12:13, Gerd Hoffmann wrote: Indicates support state for somerhing (device, backend,

Re: [Qemu-devel] [PATCH v3 0/3] Deprecate QMP & HMP `cpu-add`; document vCPU hotplug

2018-10-31 Thread Eduardo Habkost
On Wed, Oct 31, 2018 at 04:17:26PM +0100, Markus Armbruster wrote: > Kashyap Chamarthy writes: > > > The first patch deprecates the QMP `cpu-add`, the second its HMP > > equivalent, and the third documents vCPU hotplug procedure using QMP > > `device_add` et al. > > > > v2:

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-10-31 Thread Paolo Bonzini
On 31/10/2018 19:17, Eduardo Habkost wrote: > On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote: >> Ping. >> Patch was submitted almost two months ago and I haven’t seen any respond for >> the v2 of this series. > Sorry for the long delay. This was on my queue of patches to be >

Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state

2018-10-31 Thread Eduardo Habkost
On Wed, Oct 31, 2018 at 03:03:34AM +0200, Liran Alon wrote: > Ping. > Patch was submitted almost two months ago and I haven’t seen any respond for > the v2 of this series. Sorry for the long delay. This was on my queue of patches to be reviewed, but I'm failing to keep up to the rate of

Re: [Qemu-devel] [PATCH 1/4] add QemuSupportState

2018-10-31 Thread Eduardo Habkost
On Wed, Oct 31, 2018 at 12:04:16PM -0400, John Snow wrote: > > > On 10/30/2018 09:32 AM, Philippe Mathieu-Daudé wrote: > > Hi Gerd, > > > > On 30/10/18 12:13, Gerd Hoffmann wrote: > >> Indicates support state for somerhing (device, backend, subsystem, ...) > > > > "something" > > > >> in

Re: [Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str

2018-10-31 Thread David Hildenbrand
On 31.10.18 18:55, Markus Armbruster wrote: > David Hildenbrand writes: > >> On 31.10.18 15:40, Markus Armbruster wrote: >>> David Hildenbrand writes: >>> The qemu api claims to be easier to use, and the resulting code seems to agree. > [...] @@ -60,9 +61,7 @@ static int

Re: [Qemu-devel] [PATCH v3 1/7] qapi: use qemu_strtoi64() in parse_str

2018-10-31 Thread Markus Armbruster
David Hildenbrand writes: > On 31.10.18 15:40, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> The qemu api claims to be easier to use, and the resulting code seems to >>> agree. [...] >>> @@ -60,9 +61,7 @@ static int parse_str(StringInputVisitor *siv, const char >>> *name, Error

Re: [Qemu-devel] [PATCH 1/2] The discard flag for block stream operation

2018-10-31 Thread Dr. David Alan Gilbert
* Andrey Shinkevich (andrey.shinkev...@virtuozzo.com) wrote: > Adding a parameter to QMP block-stream command to allow discarding > blocks in the backing chain while blocks are being copied to the > active layer. > > Signed-off-by: Andrey Shinkevich > --- > block/stream.c| 2 +- >

Re: [Qemu-devel] [PATCH v1 0/7] pci: hotplug handler reworks

2018-10-31 Thread David Hildenbrand
On 24.10.18 12:19, David Hildenbrand wrote: > This series reworks some pci hotplug handlers (except for s390, that will > require more work but is not required for now). > > 1. Route all unplug calls via the hotplug handler when called from the >unplug_request handler. This will be required

Re: [Qemu-devel] [PATCH v3 2/7] qapi: correctly parse uint64_t values from strings

2018-10-31 Thread David Hildenbrand
On 31.10.18 15:44, Markus Armbruster wrote: > Markus Armbruster writes: > >> David Hildenbrand writes: >> >>> Right now, we parse uint64_t values just like int64_t values, resulting >>> in negative values getting accepted and certain valid large numbers only >>> being representable as negative

Re: [Qemu-devel] [PATCH v2 13/29] target/riscv: Convert RV32D insns to decodetree

2018-10-31 Thread Palmer Dabbelt
On Wed, 31 Oct 2018 03:44:27 PDT (-0700), Bastian Koppelmann wrote: On 10/20/18 9:14 AM, Bastian Koppelmann wrote: [...] +static bool trans_fclass_d(DisasContext *ctx, arg_fclass_d *a, uint32_t insn) +{ +#if defined(TARGET_RISCV64) +REQUIRE_FPU; + +TCGv t0 = tcg_temp_new(); +

Re: [Qemu-devel] [PATCH v3 06/35] target/riscv: Convert RVXI arithmetic insns to decodetree

2018-10-31 Thread Richard Henderson
On 10/31/18 1:20 PM, Bastian Koppelmann wrote: > we cannot remove the call to gen_arith() in decode_RV32_64G() since it > is used to translate multiply instructions. > > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt > --- > v2 -> v3: > - moved 64-bit only insn to

Re: [Qemu-devel] [PATCH v4 00/11] block: Add auto-read-only option

2018-10-31 Thread Kevin Wolf
Am 19.10.2018 um 18:30 hat Kevin Wolf geschrieben: > See patch 2 for an explanation of the motivation. > > v4: > - Split fix for missing rbd_close() into a separate patch [Eric] > - Added qemu-iotests case > > v3: > - Clarified QAPI schema documentation that auto-read-only can only > degrade

Re: [Qemu-devel] [PATCH v4 02/11] block: Add auto-read-only option

2018-10-31 Thread Kevin Wolf
Am 19.10.2018 um 18:30 hat Kevin Wolf geschrieben: > If a management application builds the block graph node by node, the > protocol layer doesn't inherit its read-only option from the format > layer any more, so it must be set explicitly. > > Backing files should work on read-only storage, but

Re: [Qemu-devel] [PATCH v3 2/7] qapi: correctly parse uint64_t values from strings

2018-10-31 Thread David Hildenbrand
On 31.10.18 15:32, Markus Armbruster wrote: > David Hildenbrand writes: > >> Right now, we parse uint64_t values just like int64_t values, resulting >> in negative values getting accepted and certain valid large numbers only >> being representable as negative numbers. Also, reported errors

Re: [Qemu-devel] [PATCH v3 05/35] target/riscv: Convert RV64I load/store insns to decodetree

2018-10-31 Thread Richard Henderson
On 10/31/18 1:19 PM, Bastian Koppelmann wrote: > this splits the 64-bit only instructions into its own decode file such > that we generate the decoder for these instructions only for the RISC-V > 64 bit target. > > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt > --- >

Re: [Qemu-devel] [PATCH v3 03/35] target/riscv: Convert RVXI branch insns to decodetree

2018-10-31 Thread Richard Henderson
On 10/31/18 1:19 PM, Bastian Koppelmann wrote: > +static bool trans_jal(DisasContext *ctx, arg_jal *a, uint32_t insn) > +{ > +gen_jal(ctx->env, ctx, a->rd, a->imm); > +return true; > +} This patch didn't get updated properly. It looks like the removal of the insn parameter got squashed

[Qemu-devel] [PATCH 2/2] Discard blocks while copy-on-read

2018-10-31 Thread Andrey Shinkevich
Discards the block duplicated in an intermediate backing file after the block have been copied into the active layer during QMP block-stream operation. It saves the disk space while merging snapshots. Signed-off-by: Andrey Shinkevich --- block/stream.c | 400

[Qemu-devel] [PATCH 1/2] The discard flag for block stream operation

2018-10-31 Thread Andrey Shinkevich
Adding a parameter to QMP block-stream command to allow discarding blocks in the backing chain while blocks are being copied to the active layer. Signed-off-by: Andrey Shinkevich --- block/stream.c| 2 +- blockdev.c| 8 +++- hmp-commands.hx | 4 ++--

[Qemu-devel] [PATCH 0/2] Discrad blocks during block-stream operation

2018-10-31 Thread Andrey Shinkevich
Hello everyone! The given feature discards blocks with copy-on-read operation while the streaming process runs. Adding the 'discard' argument to the QMP block-stream command allows dropping a block in the backing chain after it has been copied to the active layer. That will elude the block

Re: [Qemu-devel] [PATCH v3 01/35] target/riscv: Move CPURISCVState pointer to DisasContext

2018-10-31 Thread Richard Henderson
On 10/31/18 1:19 PM, Bastian Koppelmann wrote: > CPURISCVState is rarely used, so there is no need to pass it to every > translate function. This paves the way for decodetree which only passes > DisasContext to translate functions. > > Reviewed-by: Palmer Dabbelt > Signed-off-by: Bastian

[Qemu-devel] [PULL 1/3] COLO: Fix Colo doc secondeary should be secondary

2018-10-31 Thread Dr. David Alan Gilbert (git)
From: wangguang Signed-off-by: Guang Wang Reviewed-by: Eric Blake Signed-off-by: Dr. David Alan Gilbert --- docs/COLO-FT.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt index 6302469d0e..e2686bb338 100644 --- a/docs/COLO-FT.txt +++

[Qemu-devel] [PULL 2/3] decodetree: Remove "insn" argument from trans_* expanders

2018-10-31 Thread Richard Henderson
This allows trans_* expanders to be shared between decoders for 32 and 16-bit insns, by not tying the expander to the size of the insn that produced it. This change requires adjusting the two existing users to match. Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 3/3] migration: avoid segmentfault when take a snapshot of a VM which being migrated

2018-10-31 Thread Dr. David Alan Gilbert (git)
From: Jia Lina During an active background migration, snapshot will trigger a segmentfault. As snapshot clears the "current_migration" struct and updates "to_dst_file" before it finds out that there is a migration task, Migration accesses the null pointer in "current_migration" struct and qemu

[Qemu-devel] [PULL 0/3] migration queue

2018-10-31 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +) are available in the Git repository at:

Re: [Qemu-devel] [PATCH v2] file-posix: Use error API properly

2018-10-31 Thread Eric Blake
On 10/31/18 11:05 AM, Philippe Mathieu-Daudé wrote: On 31/10/18 15:57, Eric Blake wrote: On 10/31/18 12:39 AM, Fam Zheng wrote: ... -    fprintf(stderr, "%s: stat failed: %s\n", -    fname, strerror(errno)); +    error_setg(errp, "%s: stat failed: %s", fname,

[Qemu-devel] [PULL 2/3] qapi: Fix COLOStatus and query-colo-status since version

2018-10-31 Thread Dr. David Alan Gilbert (git)
From: Zhang Chen This structure and command have missed qemu version 3.0, so fix it to since version 3.1. Signed-off-by: Zhang Chen Message-Id: <20181022164118.5502-1-zhangc...@gmail.com> Reviewed-by: Eric Blake Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan Gilbert ---

Re: [Qemu-devel] [RFC v4 24/71] s390x: convert to cpu_halted

2018-10-31 Thread Alex Bennée
Emilio G. Cota writes: > On Wed, Oct 31, 2018 at 16:13:05 +, Alex Bennée wrote: >> > @@ -353,10 +355,12 @@ void s390_cpu_unhalt(S390CPU *cpu) >> > CPUState *cs = CPU(cpu); >> > trace_cpu_unhalt(cs->cpu_index); >> > >> > -if (cs->halted) { >> > -cs->halted = 0; >> > +

[Qemu-devel] [PULL 3/3] decodetree: Allow multiple input files

2018-10-31 Thread Richard Henderson
While it would be possible to concatenate input files with make, passing the original input files to decodetree.py allows us to generate error messages which allows compilation environments (read: emacs) to next-error to the correct input file. Tested-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [Qemu-devel] [PATCH] migration/colo.c: Fix compilation issue when disable replication

2018-10-31 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Zhang Chen (zhangc...@gmail.com) wrote: > > This compilation issue will occur when user use --disable-replication > > to config Qemu. > > > > Reported-by: Thomas Huth > > Signed-off-by: Zhang Chen > > Queued. Unqueued; this still isn't

Re: [Qemu-devel] [RFC v4 57/71] accel/tcg: convert to cpu_interrupt_request

2018-10-31 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > accel/tcg/cpu-exec.c | 15 --- > accel/tcg/tcg-all.c | 12 +--- > accel/tcg/translate-all.c | 2 +- > 3 files changed, 18 insertions(+), 11 deletions(-) > > diff --git

  1   2   3   4   >