On 11/15/18 11:34 PM, Alistair Francis wrote:
> +
> +#define TCG_CT_CONST_ZERO 0x100
> +#define TCG_CT_CONST_S12 0x200
> +#define TCG_CT_CONST_N12 0x400
Logically this would go with patch 8. But,
Reviewed-by: Richard Henderson
r~
On 11/15/18 11:34 PM, Alistair Francis wrote:
> Signed-off-by: Alistair Francis
> Signed-off-by: Michael Clark
> ---
> linux-user/host/riscv64/hostdep.h | 11 +++
> 1 file changed, 11 insertions(+)
> create mode 100644 linux-user/host/riscv64/hostdep.h
Reviewed-by: Richard Henderson
On 11/15/18 11:34 PM, Alistair Francis wrote:
> +#define TCG_TARGET_HAS_add2_i32 0
> +#define TCG_TARGET_HAS_sub2_i32 0
You're not allowed to not implement this for riscv-32,
along with brcond2 and setcond2.
> +#define TCG_TARGET_HAS_movcond_i32 0
The architecture manual
On Thu, Nov 15, 2018 at 10:47:04AM +0800, Jason Wang wrote:
>
> On 2018/11/15 上午12:23, Dima Stepanov wrote:
> >On Wed, Nov 14, 2018 at 10:59:32AM +0800, Jason Wang wrote:
> >>On 2018/11/13 下午11:41, Dima Stepanov wrote:
> >>>Hi Jason,
> >>>
> >>>I know that this patch has been already merged to
On 11/15/18 11:34 PM, Alistair Francis wrote:
> Signed-off-by: Alistair Francis
> Signed-off-by: Michael Clark
> ---
> include/exec/poison.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson
r~
On 11/12/18 1:25 AM, Max Reitz wrote:
> This is what I’ve taken from two or three BoF-like get-togethers on
> blocky things. Amendments are more than welcome, of course.
>
>
>
> Permission system
> =
>
> GRAPH_MOD
> -
>
> We need some way for the commit job to prevent
On 11/15/18 11:34 PM, Alistair Francis wrote:
> Signed-off-by: Alistair Francis
> Signed-off-by: Michael Clark
> ---
> linux-user/host/riscv32/hostdep.h | 11 +++
> 1 file changed, 11 insertions(+)
> create mode 100644 linux-user/host/riscv32/hostdep.h
Reviewed-by: Richard Henderson
On 11/15/18 11:34 PM, Alistair Francis wrote:
> Signed-off-by: Alistair Francis
> Signed-off-by: Michael Clark
> ---
> linux-user/host/riscv32/hostdep.h | 11 +++
> 1 file changed, 11 insertions(+)
> create mode 100644 linux-user/host/riscv32/hostdep.h
Reviewed-by: Richard Henderson
On 11/15/18 11:34 PM, Alistair Francis wrote:
> Signed-off-by: Alistair Francis
> Signed-off-by: Michael Clark
> ---
> include/elf.h | 55 +++
> 1 file changed, 55 insertions(+)
Reviewed-by: Richard Henderson
r~
> One change I am aware of in the forked version is the possibility
to tweak the MTU and AFAIK this is the only blocker from adopting
libslirp immediately.
> Akihiro, is there anything more that could block slirp4netns from
just using libslirp once it is available?
No, the only blocker is MTU
On 2018-11-15 13:32, Gerd Hoffmann wrote:
> Gerd Hoffmann (4):
> keymaps: remove modifiers include
> keymaps: drop nl-be map
> keymaps: remove common include
> keymaps: drop support for include files
Please give some rationale in the cover letter... why do you want to
drop support for
On 2018-11-15 15:35, Peter Maydell wrote:
> Update the onenand device to use qemu_log_mask() for reporting
> guest errors and unimplemented features, rather than plain
> fprintf() and hw_error().
>
> (We leave the hw_error() in onenand_reset(), as that is
> triggered by a failure to read the
On Thu, Nov 15, 2018 at 20:13:38 -0500, Emilio G. Cota wrote:
> I'll generate now some more perf numbers that we could include in the
> commit logs.
SPEC numbers are a net perf decrease, unfortunately:
Softmmu speedup for SPEC06int (test set)
1.1
On Thu, Nov 15, 2018 at 08:24:23PM -0700, Warner Losh wrote:
> On Thu, Nov 15, 2018 at 7:54 PM Peter Xu wrote:
>
> > On Thu, Nov 15, 2018 at 11:05:33AM +0100, Philippe Mathieu-Daudé wrote:
> > > On 15/11/18 9:58, Peter Xu wrote:
> > > > Hi, the list,
> > > >
> > > > I am trying to boot a FreeBSD
>Hi,
>
>On 2018/11/16 18:50, Peng Hao wrote:
>> Add pvpanic device in arm virt machine.
[...]
>>
>> +create_pvpanic_device(vms);
>> +
>It should not create pvpanic by default. It should be configurable via
>-device pvpanic.
yeah ,it is a problem. I will resolve it.
Thanks.
>Thanks,
>Shannon
On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote:
> On Wed, 2018-11-14 at 21:38 -0200, Eduardo Habkost wrote:
> > Many of the current virtio-*-pci device types actually represent
> > 3 different types of devices:
> > * virtio 1.0 non-transitional devices
> > * virtio 1.0
From: Zhang Chen
The original code just follow the TCP state diagram,
but in this case, we can skip the TCPS_TIME_WAIT state to simplify
the implementation.
Signed-off-by: Zhang Chen
Signed-off-by: Jason Wang
---
net/filter-rewriter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
The following changes since commit d835c6192495dc5b2c3a15a0761eb57d8d310828:
Merge remote-tracking branch
'remotes/stefanberger/tags/pull-tpm-2018-11-15-1' into staging (2018-11-15
14:18:25 +)
are available in the git repository at:
https://github.com/jasowang/qemu.git
Hi,
On 2018/11/16 18:50, Peng Hao wrote:
Add pvpanic device in arm virt machine.
Signed-off-by: Peng Hao
Signed-off-by: Philippe Mathieu-Daudé
---
default-configs/arm-softmmu.mak | 1 +
hw/arm/virt.c | 21 +
include/hw/arm/virt.h | 1 +
On 11/15/18 6:48 AM, Peter Maydell wrote:
> On 17 October 2018 at 10:51, Stefan Hajnoczi wrote:
>> On Tue, Oct 16, 2018 at 04:20:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>>> Theoretically possible that we finish the skipping loop with bs = NULL
>>> and the following code will crash
On Thu, Nov 15, 2018 at 7:54 PM Peter Xu wrote:
> On Thu, Nov 15, 2018 at 11:05:33AM +0100, Philippe Mathieu-Daudé wrote:
> > On 15/11/18 9:58, Peter Xu wrote:
> > > Hi, the list,
> > >
> > > I am trying to boot a FreeBSD guest but failed. It hangs at the
> > > kernel booting phase:
> > >
> > >
Markus Armbruster 于2018年11月15日周四 下午9:29写道：
> Li Qiang writes:
>
> > When the parse_keyboard_layout() find a "include " line
> > in the keyboard layout file, it will call parse_keyboard_layout()
> > to perform a recursive parse. If the keyboard layout is malformed
> > by adding a line include
On Thu, Nov 15, 2018 at 11:05:33AM +0100, Philippe Mathieu-Daudé wrote:
> On 15/11/18 9:58, Peter Xu wrote:
> > Hi, the list,
> >
> > I am trying to boot a FreeBSD guest but failed. It hangs at the
> > kernel booting phase:
> >
> > /boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68
> >
On Thu, Nov 15, 2018 at 02:06:36PM +0300, Ilya Maximets wrote:
> > Hi, the list,
> >
> > I am trying to boot a FreeBSD guest but failed. It hangs at the
> > kernel booting phase:
> >
> > /boot/ker]el/kernel text=0x14ed860 data=0x132538+0x4baa68
> > syms=[0x8+0x159ee8+0x8
> > Booting...
> >
Add mmio support info in docs/specs/pvpanic.txt.
Signed-off-by: Peng Hao
---
docs/specs/pvpanic.txt | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
index c7bbacc..4e1f69d 100644
--- a/docs/specs/pvpanic.txt
+++
Add pvpanic device in arm virt machine.
Signed-off-by: Peng Hao
Signed-off-by: Philippe Mathieu-Daudé
---
default-configs/arm-softmmu.mak | 1 +
hw/arm/virt.c | 21 +
include/hw/arm/virt.h | 1 +
3 files changed, 23 insertions(+)
diff --git
From: Philippe Mathieu-Daudé
The 'pvpanic' ISA device can be use by any machine with an ISA bus.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
index
add pvpanic device in virt acpi table, so when kenrel command line uses
acpi=force, kernel can get info from acpi table in aarch64.
Signed-off-by: Peng Hao
---
hw/arm/virt-acpi-build.c | 16
1 file changed, 16 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c
Add pvpanic new type "TYPE_PVPANIC_MMIO"
Signed-off-by: Peng Hao
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/pvpanic.c | 81 +--
include/hw/misc/pvpanic.h | 1 +
2 files changed, 65 insertions(+), 17 deletions(-)
diff --git
The first patches are simple cleanups:
- patch 1 move the pvpanic device with the 'ocmmon objects' so we compile
it once for the x86/arm/aarch64 archs,
- patch 2 simply renames ISA fields/definitions to generic ones.
Then instead of add/use the MMIO pvpanic device in the virt machine in an
From: Philippe Mathieu-Daudé
To ease the MMIO device addition in the next patch, rename:
- ISA_PVPANIC_DEVICE -> PVPANIC (this just returns a generic Object),
- ISADevice parent_obj -> isadev,
- MemoryRegion io -> mr.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/pvpanic.c | 16
On 2018/11/15 下午6:32, Peter Maydell wrote:
On 2 November 2018 at 02:21, Jason Wang wrote:
On 2018/10/31 上午8:50, Zhang Chen wrote:
The original code just follow the TCP state diagram,
but in this case, we can skip the TCPS_TIME_WAIT state to simplify
the implementation.
Signed-off-by: Zhang
> Add mmio support info in docs/specs/pvpanic.txt.
>>
>> Signed-off-by: Peng Hao
>> ---
>> docs/specs/pvpanic.txt | 13 -
>> 1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
>> index c7bbacc..5d8e9dc 100644
>> ---
>> add pvpanic device in virt acpi table, so when kenrel command line uses
>> acpi=force, kernel can get info from acpi table in aarch64.
[...]
>>
>> +static void acpi_dsdt_add_pvpanic(Aml *scope, const MemMapEntry
>> *pvpanic_memmap)
>> +{
>> +Aml *dev = aml_device("PANC");
>
>Shouldn't
On 11/16/2018 02:50 AM, no-re...@patchew.org wrote:
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
CC net/filter.o
CC net/filter-buffer.o
On Thu, Nov 15, 2018 at 23:04:50 +0100, Richard Henderson wrote:
> On 11/15/18 7:48 PM, Emilio G. Cota wrote:
> > - Segfault in code_gen_buffer. This one I don't have a fix for,
> > but it's *much* easier to reproduce when -tb-size is very small,
> > e.g. "-tb-size 5 -smp 2" (BTW it crashes
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181115143124.19234-1-pbonz...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH for-3.2 00/10] vhost: preparation for qgraph
conversion of vhost-user-test
=== TEST SCRIPT BEGIN ===
On Fri, Nov 16, 2018 at 00:15:53 +0100, Paolo Bonzini wrote:
> On 14/11/2018 20:42, Emilio G. Cota wrote:
> > On Wed, Nov 14, 2018 at 12:44:00 +0100, Paolo Bonzini wrote:
> >> This avoids the following deadlock:
> >>
> >> 1) a thread calls run_on_cpu for CPU 2 from a timer, and
> >>
On 14/11/2018 20:42, Emilio G. Cota wrote:
> On Wed, Nov 14, 2018 at 12:44:00 +0100, Paolo Bonzini wrote:
>> This avoids the following deadlock:
>>
>> 1) a thread calls run_on_cpu for CPU 2 from a timer, and single_tcg_halt_cond
>> is signaled
>>
>> 2) CPU 1 is running and exits. It finds no work
Calling smbus_eeprom_init() with more than 8 EEPROMs would lead to a
heap overflow.
Replace the '8' magic number by a definition, and check no more than
this number are created.
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: 20181115192446.17187-1-miny...@acm.org
"RFC v2: Fix/add vmstate
Hi Corey,
On 15/11/18 20:24, miny...@acm.org wrote:
These changes allow SMBus access while doing a state transfer.
Seems like a good idea to me in general.
I have these queued for the SMBus IPMI driver work, of course.
I had submitted this before and then lost track of the work since I
On 15/11/2018 23:50, Eric Blake wrote:
> Adding a new qapi module requires some rather tedious repetition to
> wire it into Makefile and Makefile.objs. Add some indirection by
> taking advantage of GNU Make string processing to expand a list
> of module names into all the required artifacts, so
On 11/15/18 4:37 PM, Eric Blake wrote:
I'm trying to do the same thing to Makefile.objs, but when I use:
common-obj-y += $(QAPI_MODULES:%=qapi/qapi-commands-%.o)
or the longer $(patsubst %,qapi,qapi-commands-%.o,$(QAPI_MODULES))
both before and after the change, 'make print-common-obj-y |
Adding a new qapi module requires some rather tedious repetition to
wire it into Makefile and Makefile.objs. Add some indirection by
taking advantage of GNU Make string processing to expand a list
of module names into all the required artifacts, so that future
additions of a new module need only
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
configure | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 74e313a810..8a7b9fc933 100755
--- a/configure
+++ b/configure
@@ -700,6 +700,12 @@ elif check_define __s390__
On 11/15/18 3:54 PM, Eric Blake wrote:
Adding a new qapi module had some rather tedious repetition to
wire it into Makefile. Add some indirection by taking advantage
of GNU Make string processing to expand a list of module names
into all the required artifacts, so that future additions of a
new
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
accel/tcg/user-exec.c | 48 +++
1 file changed, 48 insertions(+)
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index cd75829cf2..bb693484ed 100644
--- a/accel/tcg/user-exec.c
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 240 +
1 file changed, 240 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index b449e17295..5fe6935e24 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 646a4d3ebd..bc433170c4 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 144 +
1 file changed, 144 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index bc433170c4..b449e17295 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 66 ++
1 file changed, 66 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index bf3b04f7dc..4b8f65f367 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 0e891e24c9..646a4d3ebd 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
disas.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/disas.c b/disas.c
index 5325b7e6be..82a408f272 100644
--- a/disas.c
+++ b/disas.c
@@ -522,8 +522,14 @@ void disas(FILE *out, void *code,
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 139 +
1 file changed, 139 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index a9c57493a0..e585740870 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 4b8f65f367..dfc4e8b44c 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 62 ++
1 file changed, 62 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 475feca906..0e891e24c9 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 120 +
1 file changed, 120 insertions(+)
create mode 100644 tcg/riscv/tcg-target.inc.c
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
new
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 145 +
1 file changed, 145 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 5fe6935e24..c4a013a962 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 51 ++
1 file changed, 51 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index d402e48cbf..475feca906 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 472 +
1 file changed, 472 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index c4a013a962..bf3b04f7dc 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.h | 173 +
1 file changed, 173 insertions(+)
create mode 100644 tcg/riscv/tcg-target.h
diff --git a/tcg/riscv/tcg-target.h b/tcg/riscv/tcg-target.h
new file mode
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 40 ++
1 file changed, 40 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 5319f7ade5..d402e48cbf 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
include/exec/poison.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/exec/poison.h b/include/exec/poison.h
index 32d53789f8..ecdc83c147 100644
--- a/include/exec/poison.h
+++ b/include/exec/poison.h
@@ -79,6 +79,7 @@
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 81 ++
1 file changed, 81 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index e585740870..5319f7ade5 100644
---
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
linux-user/host/riscv64/hostdep.h | 11 +++
1 file changed, 11 insertions(+)
create mode 100644 linux-user/host/riscv64/hostdep.h
diff --git a/linux-user/host/riscv64/hostdep.h
b/linux-user/host/riscv64/hostdep.h
new
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
linux-user/host/riscv32/hostdep.h | 11 +++
1 file changed, 11 insertions(+)
create mode 100644 linux-user/host/riscv32/hostdep.h
diff --git a/linux-user/host/riscv32/hostdep.h
b/linux-user/host/riscv32/hostdep.h
new
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
tcg/riscv/tcg-target.inc.c | 45 ++
1 file changed, 45 insertions(+)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index e5eca4bbbe..a9c57493a0 100644
---
This patch set adds RISC-V backend support to QEMU. This is based on
Michael Clark's original work with some patches ontop.
This has been slightly tested and can run other architecture softmmu
code for a number of instructions but eventually QEMU will either
seg fault or generate an illigal
Signed-off-by: Alistair Francis
Signed-off-by: Michael Clark
---
include/elf.h | 55 +++
1 file changed, 55 insertions(+)
diff --git a/include/elf.h b/include/elf.h
index c151164b63..0ac7911b7b 100644
--- a/include/elf.h
+++ b/include/elf.h
@@
On 15/11/18 20:24, miny...@acm.org wrote:
From: Corey Minyard
It was hard-coded to 256 in a number of places, create a constant
for that.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git
On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer wrote:
> On Wed, Nov 7, 2018 at 7:55 PM Nir Soffer wrote:
>
>> On Wed, Nov 7, 2018 at 7:27 PM Kevin Wolf wrote:
>>
>>> Am 07.11.2018 um 15:56 hat Nir Soffer geschrieben:
>>> > Wed, Nov 7, 2018 at 4:36 PM Richard W.M. Jones
>>> wrote:
>>> >
>>> > >
On 15/11/18 20:24, miny...@acm.org wrote:
From: Corey Minyard
smbus.c and smbus.h had device side code, master side code, and
smbus.h has some smbus_eeprom.c definitions. Split them into
separate files.
Lovely cleanup!
Signed-off-by: Corey Minyard
---
hw/arm/aspeed.c
On 11/15/18 7:48 PM, Emilio G. Cota wrote:
> - Segfault in code_gen_buffer. This one I don't have a fix for,
> but it's *much* easier to reproduce when -tb-size is very small,
> e.g. "-tb-size 5 -smp 2" (BTW it crashes with x86_64 guests too.)
> So at first I thought the code cache flushing
On 11/15/18 3:41 PM, Eric Blake wrote:
On 11/15/18 2:55 AM, xiezhide wrote:
this patch move ThrottleLimits to new file and rename struct
field with common format
As written, you need s/move/moves/ and s/rename/renames/ to match the
singular actor 'this patch'. Or, if you stick with my
This is a "pre-patch" to breaking up the write buffer for
MTP writes. Instead of allocating a mtp buffer equal to size
sent by the initiator, we start with a small size and reallocate
multiples (of that small size) as needed.
Signed-off-by: Bandan Das
---
hw/usb/dev-mtp.c | 26
For every MTP_WRITE_BUF_SZ copied, this patch writes it to file before
getting the next block of data. The file is kept opened for the
duration of the operation but the sanity checks on the write operation
are performed only once when the write operation starts. Additionally,
we also update the
For larger files, not only do we keep reallocating to increase the mtp buffer
size, the write also happens in one go. This does two things:
Write to file upto a certain data size we have received so far and second,
reuse the buffer again instead of reallocating to a larger buffer size.
Tested
On 15.11.18 19:02, Eric Blake wrote:
> If the conversion underflows, store ±0.0 in @result, depending on the
> sign, and return -ERANGE.
Will do! Thanks!
--
Thanks,
David / dhildenb
Adding a new qapi module had some rather tedious repetition to
wire it into Makefile. Add some indirection by taking advantage
of GNU Make string processing to expand a list of module names
into all the required artifacts, so that future additions of a
new module need only touch the list of module
On 15.11.18 17:48, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> Let's use the new function. "NaN" and "inf" are now properly rejected.
>>
>> Signed-off-by: David Hildenbrand
>
> Whether this is a bug fix or just a change is debatable. But the commit
> message's title should
On 11/15/18 2:55 AM, xiezhide wrote:
this patch move ThrottleLimits to new file and rename struct
field with common format
As written, you need s/move/moves/ and s/rename/renames/ to match the
singular actor 'this patch'. Or, if you stick with my preference for
imperative sense, s/this
On 15/11/18 22:17, Eric Blake wrote:
Prompted by my review of xiezhide's work. No semantic change, but
not technically a bug fix, so I don't care if it goes in 3.1 or
waits for 4.0.
Eric Blake (2):
typedefs: (Re-)sort entries alphabetically
numa: Match struct to typedef name
Series:
Since the last time we sorted things (2988cbeaf), we've had a
few relapses that were inserted out of order. Also, we had more
entries that were sorted case-insensitively than not, so let's
document that convention and stick to it.
Signed-off-by: Eric Blake
---
include/qemu/typedefs.h | 10
There's no reason to violate our naming conventions by having a
struct with a different name than its typedef. Messed up since
its introduction in commit 8c85901e, but made more obvious when
commit 3bfe5716 promoted it to typedefs.h.
Signed-off-by: Eric Blake
---
include/qemu/typedefs.h | 2 +-
Prompted by my review of xiezhide's work. No semantic change, but
not technically a bug fix, so I don't care if it goes in 3.1 or
waits for 4.0.
Eric Blake (2):
typedefs: (Re-)sort entries alphabetically
numa: Match struct to typedef name
include/qemu/typedefs.h | 12 ++--
Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Message-id: 20181115123218.25387-1-kra...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH 0/4] keymaps: drop
On 11/15/18 2:54 AM, xiezhide wrote:
This patch factor out throttle parameter parse code to common function
s/factor/factors/
Actually, when I write commit messages, I like to use the imperative
mood, with an implicit "Apply this patch in order to" unspoken prefix.
Starting with an explicit
Hi,
This series failed docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Message-id: 20181115123218.25387-1-kra...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH 0/4] keymaps: drop
On 11/5/18 10:37 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/232 | 147 +
tests/qemu-iotests/232.out | 59 +++
tests/qemu-iotests/group | 1 +
3 files changed, 207 insertions(+)
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote:
> On Thu, Nov 15, 2018 at 7:47 PM Dr. David Alan Gilbert (git)
> wrote:
> >
> > From: "Dr. David Alan Gilbert"
> >
> > x86 doesn't need a 3.1 machine type, because there's no incompatibility,
> > but it looks odd not having one, especially
On 11/14/18 3:05 PM, Eric Blake wrote:
file-posix.c was taking a 64-bit bytes in raw_co_copy_range_to(),
passing it through a 32-bit parameter of paio_submit_co_full(),
then widening it back to size_t when assigning into acb->aio_nbytes.
Looking at io.c, I can't quickly tell if
On Thu, Nov 15, 2018 at 7:47 PM Dr. David Alan Gilbert (git)
wrote:
>
> From: "Dr. David Alan Gilbert"
>
> x86 doesn't need a 3.1 machine type, because there's no incompatibility,
> but it looks odd not having one, especially since s390, ppc and ARM have
> it. Join the party.
>
> Signed-off-by:
From: Corey Minyard
Reset the contents to init data and reset the offset on a machine
reset.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index
From: Corey Minyard
Migration capability is being added for pm_smbus and SMBus devices.
This change will allow backwards compatibility to be kept when
migrating back to an old qemu version. Add a bool to the machine
class tho keep smbus migration from happening. Future changes
will use this.
From: Corey Minyard
Create a type name and a cast macro and use those through the
code.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index
From: Corey Minyard
Transfer the state information for the SMBus registers and
internal data so it will work on a VM transfer.
Signed-off-by: Corey Minyard
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Cc: Dr. David Alan Gilbert
---
hw/acpi/piix4.c | 3 ++-
hw/i2c/pm_smbus.c
From: Corey Minyard
It was hard-coded to 256 in a number of places, create a constant
for that.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index
From: Corey Minyard
It is never supposed to fail and cannot return an error, so just
have it return the proper type. Have it return 0xff on nothing
available, since that's what would happen on a real bus.
Signed-off-by: Corey Minyard
---
hw/arm/pxa2xx.c | 2 +-
hw/arm/tosa.c
From: Corey Minyard
There is no vmstate handling for SMBus, so no device sitting on SMBus
can have a state transfer that works reliably. So add it.
Signed-off-by: Corey Minyard
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Dr. David Alan Gilbert
---
hw/i2c/smbus_slave.c | 18
From: Corey Minyard
smbus.c and smbus.h had device side code, master side code, and
smbus.h has some smbus_eeprom.c definitions. Split them into
separate files.
Signed-off-by: Corey Minyard
---
hw/arm/aspeed.c | 2 +-
hw/i2c/Makefile.objs |
1 - 100 of 351 matches
Mail list logo
