[Qemu-devel] [Question] Hotplug rescan/remove by manual

2018-11-28 Thread Liu, Jing2
Hi guys, When I tested hotplug on pci.0 on pc platform, it seems that we have to echo 1 > /sys/bus/pci/rescan manually in guest? Is this a non-complete feature because of something like gpe interrupt issue? For hot-unplug, I uses echo 1 > /sys/bus/pci//remove but this seems only remove the

Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the ThrottleLimits member names

2018-11-28 Thread xiezhide
> Subject: Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the > ThrottleLimits member names > > On 11/28/18 3:25 AM, Markus Armbruster wrote: > > xiezhide writes: > > > >> Rename the ThrottleLimits member names and modify related code > >> > >> Signed-off-by: xiezhide > >> --- > >>

Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the ThrottleLimits member names

2018-11-28 Thread xiezhide
> Subject: Re: [Qemu-devel] [PATCH v5 2/6] fsdev-throttle-qmp: Rename the > ThrottleLimits member names > > xiezhide writes: > > > Rename the ThrottleLimits member names and modify related code > > > > Signed-off-by: xiezhide > > --- > > qapi/block-core.json | 70 +++--- > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 12/36] spapr: initialize VSMT before initializing the IRQ backend

2018-11-28 Thread Greg Kurz
On Thu, 29 Nov 2018 12:02:48 +1100 David Gibson wrote: > On Wed, Nov 28, 2018 at 10:35:51AM +0100, Greg Kurz wrote: > > On Wed, 28 Nov 2018 13:57:14 +1100 > > David Gibson wrote: > > > > > On Fri, Nov 16, 2018 at 11:57:05AM +0100, Cédric Le Goater wrote: > > > > We will need to use

Re: [Qemu-devel] [PATCH v2 01/16] virtio: split vhost vsock bits from virtio-pci

2018-11-28 Thread Thomas Huth
On 2018-11-29 07:30, Thomas Huth wrote: > On 2018-11-26 20:59, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> >> --- >> >> Updated copyright info >> Also split virtio-pci.h bits >> --- >> hw/virtio/Makefile.objs | 2 +- >> hw/virtio/vhost-vsock-pci.c | 82

Re: [Qemu-devel] [PATCH v2 01/16] virtio: split vhost vsock bits from virtio-pci

2018-11-28 Thread Thomas Huth
On 2018-11-26 20:59, Juan Quintela wrote: > Signed-off-by: Juan Quintela > > --- > > Updated copyright info > Also split virtio-pci.h bits > --- > hw/virtio/Makefile.objs | 2 +- > hw/virtio/vhost-vsock-pci.c | 82 + > hw/virtio/virtio-pci.c | 51

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-28 Thread Wei Wang
On 11/29/2018 01:10 PM, Peter Xu wrote: On Thu, Nov 29, 2018 at 11:40:57AM +0800, Wei Wang wrote: On 11/28/2018 05:32 PM, Peter Xu wrote: I'm not sure we can use start_postcopy. It's a variable being set in the QMP handler but it does not mean postcopy has started. I'm afraid there can be

Re: [Qemu-devel] [PATCH for 3.1 4/4] virtio-net-test: add large tx buffer test

2018-11-28 Thread Thomas Huth
On 2018-11-29 04:12, Jason Wang wrote: > This test tries to build a packet whose size is greater than INT_MAX > which tries to trigger integer overflow in qemu_net_queue_append_iov() > which may result OOB. > > Signed-off-by: Jason Wang > --- > tests/virtio-net-test.c | 46

Re: [Qemu-devel] [PATCH for 3.1 2/4] virtio-net-test: remove unused macro

2018-11-28 Thread Thomas Huth
On 2018-11-29 04:12, Jason Wang wrote: > Signed-off-by: Jason Wang > --- > tests/virtio-net-test.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/virtio-net-test.c b/tests/virtio-net-test.c > index dcb87a8b6e..231e7c767e 100644 > --- a/tests/virtio-net-test.c > +++

Re: [Qemu-devel] [PATCH RFC 1/5] Fix segmentation fault when qemu_signal_init fails

2018-11-28 Thread Fei Li
On 11/28/2018 08:53 PM, Markus Armbruster wrote: Fei Li writes: When qemu_signal_init() fails in qemu_init_main_loop(), we return without setting an error. Its callers crash then when they try to report the error with error_report_err(). Yes, that's a bug. Broken in 2f78e491d7b, v2.2.0.

Re: [Qemu-devel] [PATCH for 3.1 3/4] virtio-net-test: accept variable length argument in pci_test_start()

2018-11-28 Thread Thomas Huth
On 2018-11-29 04:12, Jason Wang wrote: > This allows flexibility to be reused for all kinds of command line > used by other tests. > > Signed-off-by: Jason Wang > --- > tests/virtio-net-test.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-28 Thread Peter Xu
On Thu, Nov 29, 2018 at 01:10:14PM +0800, Peter Xu wrote: > On Thu, Nov 29, 2018 at 11:40:57AM +0800, Wei Wang wrote: > > On 11/28/2018 05:32 PM, Peter Xu wrote: > > > > > > So what I am worrying here are corner cases where we might forget to > > > stop the hinting. I'm fabricating one example

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-28 Thread Peter Xu
On Thu, Nov 29, 2018 at 11:40:57AM +0800, Wei Wang wrote: > On 11/28/2018 05:32 PM, Peter Xu wrote: > > > > So what I am worrying here are corner cases where we might forget to > > stop the hinting. I'm fabricating one example sequence of events: > > > >(start migration) > >

[Qemu-devel] [Bug 1804961] Re: qemu-system-aarch64: Windows 10 ARM64 BSoD on boot while using virt-3.0

2018-11-28 Thread GH Cao
And the namespace objects tree of virt-2.12 is this. https://pastebin.com/GybigJ9r -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1804961 Title: qemu-system-aarch64: Windows 10 ARM64 BSoD on boot

Re: [Qemu-devel] [PATCH v2 2/2] hw: vmmouse: drop DEFINE_PROP_PTR()

2018-11-28 Thread Li Qiang
Markus Armbruster 于2018年11月27日周二 下午8:38写道: > Darren Kenny writes: > > > Hi Li Qiang, > > > > This is only a suggestion, I'm sure someone else might also correct > > me, but I'm not sure the subject above really describes what is > > happening in the commit as a whole. > > > > It seems to miss

[Qemu-devel] [PATCH v3 2/2] hw: vmmouse: Use link instead of pointer property

2018-11-28 Thread Li Qiang
According to qdev-properties.h, properties of pointer type should be avoided. Turn "ps2_mouse" into a link. Reviewed-by: Markus Armbruster Reviewed-by: Darren Kenny Signed-off-by: Li Qiang --- Change since v2: detailed commit message Change since v1: use error_abort in

[Qemu-devel] [PATCH v3 1/2] hw: pc: use TYPE_XXX instead of constant strings

2018-11-28 Thread Li Qiang
TYPE_VMMOUSE is defined in vmmouse.c currently, move it to pc.h in order to use it in pc.c. Reviewed-by: Darren Kenny Reviewed-by: Markus Armbruster Signed-off-by: Li Qiang --- hw/i386/pc.c | 6 +++--- hw/i386/vmmouse.c| 1 - include/hw/i386/pc.h | 3 +++ 3 files changed, 6

Re: [Qemu-devel] [PATCH v5 05/36] ppc/xive: introduce the XIVE Event Notification Descriptors

2018-11-28 Thread David Gibson
On Fri, Nov 23, 2018 at 12:01:27PM +0100, Cédric Le Goater wrote: > On 11/23/18 5:35 AM, David Gibson wrote: > > On Thu, Nov 22, 2018 at 10:47:44PM +0100, Cédric Le Goater wrote: > >> On 11/22/18 5:41 AM, David Gibson wrote: > >>> On Fri, Nov 16, 2018 at 11:56:58AM +0100, Cédric Le Goater > wrote:

[Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR

2018-11-28 Thread Li Qiang
According https://wiki.qemu.org/Contribute/BiteSizedTasks the 'DEFINE_PROP_PTR' should be replaced by QOM link property. The first patch replace constant strings with TYPE_ and move some definition to pc.h header file so that the second patch can work. Change since v2: detail commit message

Re: [Qemu-devel] [PATCH v5 27/36] sysbus: add a sysbus_mmio_unmap() helper

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:20AM +0100, Cédric Le Goater wrote: > This will be used to remove the MMIO regions of the POWER9 XIVE > interrupt controller when the sPAPR machine is reseted. > > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson Since the code looks sane. Hoever, I

Re: [Qemu-devel] [PATCH v5 23/36] spapr/xive: add migration support for KVM

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:16AM +0100, Cédric Le Goater wrote: > This extends the KVM XIVE models to handle the state synchronization > with KVM, for the monitor usage and for the migration. > > The migration priority of the XIVE interrupt controller sPAPRXive is > raised for KVM. It operates

Re: [Qemu-devel] [PATCH v5 28/36] ppc/xics: introduce a icp_kvm_init() routine

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:21AM +0100, Cédric Le Goater wrote: > This routine gathers all the KVM initialization of the XICS KVM > presenter. It will be useful when the initialization of the KVM XICS > device is moved to a global routine. > > Signed-off-by: Cédric Le Goater I dislike calling

Re: [Qemu-devel] [PATCH v5 34/36] spapr: add KVM support to the 'dual' machine

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:27AM +0100, Cédric Le Goater wrote: > The interrupt mode is chosen by the CAS negotiation process and > activated after a reset to take into account the required changes in > the machine. This brings new constraints on how the associated KVM IRQ > device is

Re: [Qemu-devel] [PATCH v5 32/36] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:25AM +0100, Cédric Le Goater wrote: > Removing RTAS handlers will become necessary when the new pseries > machine supporting multiple interrupt mode is introduced. I'd prefer this to be done as a separate spapr_rtas_unregister() helper, just to improve greppability.

Re: [Qemu-devel] [PATCH v5 31/36] spapr/xive: export the spapr_xive_kvm_init() routine

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:24AM +0100, Cédric Le Goater wrote: > We will need it to initialize the KVM XIVE device globally from the > machine when the XIVE interrupt mode is selected. > > Signed-off-by: Cédric Le Goater This is so trivial, I think it's better to fold it into the patch which

Re: [Qemu-devel] [PATCH v5 33/36] spapr: introduce routines to delete the KVM IRQ device

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:26AM +0100, Cédric Le Goater wrote: > If a new interrupt mode is chosen by CAS, the machine generates a > reset to reconfigure. At this point, the connection with the previous > KVM device needs to be closed and a new connection needs to opened > with the KVM device

Re: [Qemu-devel] [PATCH v5 22/36] spapr/xive: add models for KVM support

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 11:45:46PM +0100, Cédric Le Goater wrote: > On 11/28/18 6:52 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:15AM +0100, Cédric Le Goater wrote: > >> This introduces a set of XIVE models specific to KVM which derive from > >> the XIVE base models. The interfaces

Re: [Qemu-devel] [PATCH v5 25/36] spapr: set the interrupt presenter at reset

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:18AM +0100, Cédric Le Goater wrote: > Currently, the interrupt presenter of the VPCU is set at realize > time. Setting it at reset will become useful when the new machine > supporting both interrupt modes is introduced. In this machine, the > interrupt mode is chosen

Re: [Qemu-devel] [PATCH v5 24/36] spapr: add a 'reset' method to the sPAPR IRQ backend

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:17AM +0100, Cédric Le Goater wrote: > This method will become useful when the new machine supporting both > interrupt modes, XIVE and XICS, is introduced. In this machine, the > interrupt mode is chosen by the CAS negotiation process and activated > after a reset. >

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-11-28 Thread Eric Blake
On 6/9/18 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap

Re: [Qemu-devel] [PATCH] memory: update coalesced_range on transaction_commit

2018-11-28 Thread Atsushi Nemoto
On Wed, 28 Nov 2018 17:30:59 +0100, Paolo Bonzini wrote: >> The e1000 driver calls memory_region_add_coalescing but >> kvm_coalesce_mmio_region never been called for those regions. >> >> Update coalesced_range on memory_region_transaction_commit to fix this. >> >> It seems very old bug since

Re: [Qemu-devel] [PATCH for 3.1 1/4] net: drop too large packet early

2018-11-28 Thread Li Qiang
Jason Wang 于2018年11月29日周四 上午11:12写道: > We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 > ("net: ignore packet size greater than INT_MAX") during packet > delivering. Unfortunately, this is not sufficient as we may hit > another integer overflow when trying to queue such

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-28 Thread Benjamin Herrenschmidt
On Thu, 2018-11-29 at 11:47 +1100, David Gibson wrote: > > 1) read/write accessors which take a word number > > 2) A "get" accessor which copies the whole structure, but "write" > accessor which takes a word number. The asymmetry is a bit ugly, but > it's the non-atomic writeback of the whole

Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy

2018-11-28 Thread Wei Wang
On 11/28/2018 05:32 PM, Peter Xu wrote: So what I am worrying here are corner cases where we might forget to stop the hinting. I'm fabricating one example sequence of events: (start migration) START_MIGRATION BEFORE_SYNC AFTER_SYNC ... BEFORE_SYNC AFTER_SYNC (some

[Qemu-devel] [PATCH for 3.1 1/4] net: drop too large packet early

2018-11-28 Thread Jason Wang
We try to detect and drop too large packet (>INT_MAX) in 1592a9947036 ("net: ignore packet size greater than INT_MAX") during packet delivering. Unfortunately, this is not sufficient as we may hit another integer overflow when trying to queue such large packet in qemu_net_queue_append_iov(): -

[Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets

2018-11-28 Thread Jason Wang
Hi: This series tries to fix a possible OOB during queueing packets through qemu_net_queue_append_iov(). This could happen when it tries to queue a packet whose size is larger than INT_MAX which may lead integer overflow. We've fixed similar issue in the past during qemu_net_queue_deliver_iov()

[Qemu-devel] [PATCH for 3.1 4/4] virtio-net-test: add large tx buffer test

2018-11-28 Thread Jason Wang
This test tries to build a packet whose size is greater than INT_MAX which tries to trigger integer overflow in qemu_net_queue_append_iov() which may result OOB. Signed-off-by: Jason Wang --- tests/virtio-net-test.c | 46 + 1 file changed, 46

[Qemu-devel] [PATCH for 3.1 3/4] virtio-net-test: accept variable length argument in pci_test_start()

2018-11-28 Thread Jason Wang
This allows flexibility to be reused for all kinds of command line used by other tests. Signed-off-by: Jason Wang --- tests/virtio-net-test.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/tests/virtio-net-test.c b/tests/virtio-net-test.c index

Re: [Qemu-devel] [RFC v2 14/24] riscv: tcg-target: Add branch and jump instructions

2018-11-28 Thread Richard Henderson
On 11/28/18 5:06 PM, Alistair Francis wrote: > On Wed, Nov 28, 2018 at 12:15 PM Richard Henderson > wrote: >> >> On 11/27/18 1:08 PM, Alistair Francis wrote: >>> +static inline void tcg_out_goto_long(TCGContext *s, tcg_insn_unit *target) >>> +{ >>> +ptrdiff_t offset = tcg_pcrel_diff(s,

[Qemu-devel] [PATCH for 3.1 2/4] virtio-net-test: remove unused macro

2018-11-28 Thread Jason Wang
Signed-off-by: Jason Wang --- tests/virtio-net-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/virtio-net-test.c b/tests/virtio-net-test.c index dcb87a8b6e..231e7c767e 100644 --- a/tests/virtio-net-test.c +++ b/tests/virtio-net-test.c @@ -24,7 +24,6 @@ #define PCI_SLOT_HP

Re: [Qemu-devel] [PATCH v5 20/36] spapr: add classes for the XIVE models

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 11:38:50PM +0100, Cédric Le Goater wrote: > On 11/28/18 6:13 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:13AM +0100, Cédric Le Goater wrote: > >> The XIVE models for the QEMU and KVM accelerators will have a lot in > >> common. Introduce an abstract class for

[Qemu-devel] [ANNOUNCE] QEMU 3.1.0-rc3 is now available

2018-11-28 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 3.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-3.1.0-rc3.tar.xz

Re: [Qemu-devel] [PATCH for-3.2 v4 00/28] Generalize machine compatibility properties

2018-11-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH for-3.2 v4 00/28] Generalize machine compatibility properties Message-id: 20181127092801.21777-1-marcandre.lur...@redhat.com === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH for-3.1] hw/arm/virt-acpi-build: Fix SMMUv3 ACPI integration

2018-11-28 Thread Shannon Zhao
On 2018/11/29 1:26, Auger Eric wrote:   struct AcpiIortSmmu3 {   ACPI_IORT_NODE_HEADER_DEF   uint64_t base_address; @@ -639,6 +645,8 @@ struct AcpiIortSmmu3 {   uint32_t pri_gsiv;   uint32_t gerr_gsiv;   uint32_t sync_gsiv; +    uint32_t pxm; So if we use this field

Re: [Qemu-devel] [qemu-web PATCH] Document how to test the site with jekyll locally

2018-11-28 Thread Ning, Yu
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, November 29, 2018 0:44 > To: Daniel P. Berrangé ; qemu-devel@nongnu.org > Cc: Thomas Huth ; rai...@macports.org; > alex.ben...@linaro.org; Ning, Yu ; Eric Blake > ; Stefan Hajnoczi > Subject: Re:

Re: [Qemu-devel] (no subject)

2018-11-28 Thread berkus infinitus
I suspect the main problem is the blocking call to qemu_main from the UI thread in the app delegate didFinishLoadingWithOptions if i’m not mistaken and everything else grows from there. Going to build and run it now, since I woke up in the middle of the night anyway for reasons unexplainable) On

Re: [Qemu-devel] [PATCH v5 16/36] spapr: add hcalls support for the XIVE exploitation interrupt mode

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 11:21:37PM +0100, Cédric Le Goater wrote: > On 11/28/18 5:25 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:09AM +0100, Cédric Le Goater wrote: > >> The different XIVE virtualization structures (sources and event queues) > >> are configured with a set of

Re: [Qemu-devel] [PATCH v5 15/36] spapr: introdude a new machine IRQ backend for XIVE

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 06:16:58PM +0100, Cédric Le Goater wrote: > On 11/28/18 4:28 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:08AM +0100, Cédric Le Goater wrote: > >> The XIVE IRQ backend uses the same layout as the new XICS backend but > >> covers the full range of the IRQ number

Re: [Qemu-devel] [PATCH v5 08/36] ppc/xive: introduce a simplified XIVE presenter

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 11:59:58AM +0100, Cédric Le Goater wrote: > On 11/28/18 12:49 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:01AM +0100, Cédric Le Goater wrote: > >> The last sub-engine of the XIVE architecture is the Interrupt > >> Virtualization Presentation Engine (IVPE). On

Re: [Qemu-devel] [PATCH v5 11/36] spapr/xive: use the VCPU id as a NVT identifier

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 05:48:32PM +0100, Cédric Le Goater wrote: > On 11/28/18 3:39 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:04AM +0100, Cédric Le Goater wrote: > >> The IVPE scans the O/S CAM line of the XIVE thread interrupt contexts > >> to find a matching Notification Virtual

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 12/36] spapr: initialize VSMT before initializing the IRQ backend

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 10:35:51AM +0100, Greg Kurz wrote: > On Wed, 28 Nov 2018 13:57:14 +1100 > David Gibson wrote: > > > On Fri, Nov 16, 2018 at 11:57:05AM +0100, Cédric Le Goater wrote: > > > We will need to use xics_max_server_number() to create the sPAPRXive > > > object modeling the

Re: [Qemu-devel] [PATCH v5 10/36] spapr/xive: introduce a XIVE interrupt controller

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 05:27:29PM +0100, Cédric Le Goater wrote: > On 11/28/18 1:52 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:03AM +0100, Cédric Le Goater wrote: > >> sPAPRXive models the XIVE interrupt controller of the sPAPR machine. > >> It inherits from the XiveRouter and

Re: [Qemu-devel] [PATCH v5 09/36] ppc/xive: notify the CPU when the interrupt priority is more privileged

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 12:30:45PM +0100, Cédric Le Goater wrote: > On 11/28/18 1:13 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:02AM +0100, Cédric Le Goater wrote: > >> After the event data was pushed in the O/S Event Queue, the IVPE > >> raises the bit corresponding to the priority

Re: [Qemu-devel] [RFC v2 14/24] riscv: tcg-target: Add branch and jump instructions

2018-11-28 Thread Alistair Francis
On Wed, Nov 28, 2018 at 12:15 PM Richard Henderson wrote: > > On 11/27/18 1:08 PM, Alistair Francis wrote: > > +static inline void tcg_out_goto_long(TCGContext *s, tcg_insn_unit *target) > > +{ > > +ptrdiff_t offset = tcg_pcrel_diff(s, target); > > + > > +if (offset == sextract64(offset,

Re: [Qemu-devel] (no subject)

2018-11-28 Thread Programmingkid
> On Nov 28, 2018, at 2:39 PM, Peter Maydell wrote: > > On Wed, 28 Nov 2018 at 01:12, John Arbuckle wrote: >> >> From af4497f2b161bb4165acb8eee5cae3f2a7ea2227 Mon Sep 17 00:00:00 2001 >> From: John Arbuckle >> Date: Tue, 27 Nov 2018 20:01:20 -0500 >> Subject: [PATCH] ui/cocoa.m: fix crash

Re: [Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-11-28 Thread David Gibson
On Wed, Nov 28, 2018 at 08:27:06PM +0100, BALATON Zoltan wrote: > Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and > bitbang_i2c.h an error even if they are identical. Move it to a common > place to allow building with this clang version. > > Reported-by: Thomas Huth > Signed-off-by:

Re: [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches

2018-11-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/6] Fixes 31 20181127 patches Message-id: 20181127064932.7299-1-kra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

[Qemu-devel] [RFC/PATCH] i386: Atomically update PTEs with mttcg

2018-11-28 Thread Benjamin Herrenschmidt
Afaik, this isn't well documented (at least it wasn't when I last looked) but OSes such as Linux rely on this behaviour: The HW updates to the page tables need to be done atomically with the checking of the present bit (and other permissions). This is what allows Linux to do simple xchg of PTEs

Re: [Qemu-devel] [PATCH v5 22/36] spapr/xive: add models for KVM support

2018-11-28 Thread Cédric Le Goater
On 11/28/18 6:52 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:15AM +0100, Cédric Le Goater wrote: >> This introduces a set of XIVE models specific to KVM which derive from >> the XIVE base models. The interfaces with KVM are a new capability and >> a new KVM device for the XIVE native

Re: [Qemu-devel] [PATCH v5 20/36] spapr: add classes for the XIVE models

2018-11-28 Thread Cédric Le Goater
On 11/28/18 6:13 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:13AM +0100, Cédric Le Goater wrote: >> The XIVE models for the QEMU and KVM accelerators will have a lot in >> common. Introduce an abstract class for the source, the thread context >> and the interrupt controller object to

Re: [Qemu-devel] [PATCH v5 19/36] spapr: add a 'pseries-3.1-xive' machine type

2018-11-28 Thread Cédric Le Goater
On 11/28/18 5:42 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:12AM +0100, Cédric Le Goater wrote: >> The interrupt mode is statically defined to XIVE only for this machine. >> The guest OS is required to have support for the XIVE exploitation >> mode of the POWER9 interrupt controller.

Re: [Qemu-devel] [libvirt] [PATCH for-4.0 v3 0/2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [libvirt] [PATCH for-4.0 v3 0/2] virtio: Provide version-specific variants of virtio PCI devices Message-id: 20181127024959.7060-1-ehabk...@redhat.com === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH v5 17/36] spapr: add device tree support for the XIVE exploitation mode

2018-11-28 Thread Cédric Le Goater
On 11/28/18 5:31 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:10AM +0100, Cédric Le Goater wrote: >> The XIVE interface for the guest is described in the device tree under >> the "interrupt-controller" node. A couple of new properties are >> specific to XIVE : >> >> - "reg" >> >>

Re: [Qemu-devel] [PATCH v5 16/36] spapr: add hcalls support for the XIVE exploitation interrupt mode

2018-11-28 Thread Cédric Le Goater
On 11/28/18 5:25 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:09AM +0100, Cédric Le Goater wrote: >> The different XIVE virtualization structures (sources and event queues) >> are configured with a set of Hypervisor calls : >> >> - H_INT_GET_SOURCE_INFO >> >>used to obtain the

Re: [Qemu-devel] [PATCH 00/12] tcg: Improve register allocation for calls

2018-11-28 Thread Emilio G. Cota
On Tue, Nov 27, 2018 at 21:38:22 -0800, Richard Henderson wrote: > The intent here is to remove several move insns putting the > function arguments into the proper place. I'm hoping that > this will solve the skylake regression with spec2006, as > seen with the ool softmmu patch set. > > Emilio,

[Qemu-devel] [Bug 1805445] Re: QEMU arm virt machine was stopped by STMFD command while debug process

2018-11-28 Thread Igor
/* * Allocate RAM after the memory controller has checked the size * was valid. If not, a default value is used. */ ram_size = object_property_get_uint(OBJECT(>soc), "ram-size", _abort); memory_region_allocate_system_memory(>ram1, NULL, "ram1", ram_size);

[Qemu-devel] [PATCH 2/2] scsi: esp: Improve consistency of RSTAT, RSEQ, and RINTR

2018-11-28 Thread Guenter Roeck
The guest OS reads RSTAT, RSEQ, and RINTR, and expects those registers to reflect a consistent state. However, it is possible that the registers can change after RSTAT was read, but before RINTR is read. Guest OSqemu Read RSTAT

[Qemu-devel] [PATCH 1/2] esp-pci: Fix status register write erase control

2018-11-28 Thread Guenter Roeck
Per AM53C974 datasheet, definition of "SCSI Bus and Control (SBAC)" register: Bit 24 – STATUS – Write Erase Control This bit controls the Write Erase feature on bits 3:1 and bit 6 of the DMA Status Register ((B)+54h). When this bit is programmed to ‘1’, the state of bits 3:1 are preserved when

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2018-11-28 Thread Alexander Gretha
hi greg, thanks very much for you answer. i saw the proposed kernel patch from eric van hensbergen - even tried to build my own kernel with the patch applied, i was ready to run this on a custom kernel with a custom built qemu, but although the patch can be applied, there have been too many

Re: [Qemu-devel] [qemu-web PATCH] Document how to test the site with jekyll locally

2018-11-28 Thread Rainer Müller
On 28.11.18 17:44, Paolo Bonzini wrote: > On 28/11/18 16:35, Daniel P. Berrangé wrote: >> Add a README file that tells people this is a jekyll based static >> website, and shows people how to run jekyll for testing purposes. >> >> Signed-off-by: Daniel P. Berrangé >> --- >> >> NB, we should

Re: [Qemu-devel] [RFC v2 19/24] riscv: tcg-target: Add the target init code

2018-11-28 Thread Richard Henderson
On 11/27/18 1:09 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Signed-off-by: Michael Clark > --- > tcg/riscv/tcg-target.inc.c | 31 +++ > 1 file changed, 31 insertions(+) Reviewed-by: Richard Henderson r~

[Qemu-devel] [Bug 1805697] [NEW] egl-headless crashes

2018-11-28 Thread Anton Sharpaev
Public bug reported: egl-headless crashes when it is trying change the resolution. After XFCE login, for example. I tryed it on 2.12, 3.0 and 3.1.0-rc2 versions. # qemu-system-x86_64 -enable-kvm -enable-kvm -M q35 -smp 8 -vga virtio -spice port=59011,addr=0.0.0.0,disable-ticketing -hda

[Qemu-devel] [Bug 1805697] Re: egl-headless crashes

2018-11-28 Thread Anton Sharpaev
Is it possible to set init resolution when VM is starting? ** Tags added: egl-headless ** Tags added: virgl -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805697 Title: egl-headless crashes

Re: [Qemu-devel] [PATCH v2 16/16] virtio: virtio 9p really requires CONFIG_VIRTFS to work

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Otherwise, it has no implementation. > > Signed-off-by: Juan Quintela > --- > default-configs/virtio.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/default-configs/virtio.mak b/default-configs/virtio.mak > index

Re: [Qemu-devel] [RFC v2 18/24] riscv: tcg-target: Add the prologue generation and register the JIT

2018-11-28 Thread Richard Henderson
On 11/27/18 1:09 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Signed-off-by: Michael Clark > --- > tcg/riscv/tcg-target.inc.c | 111 + > 1 file changed, 111 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 15/16] virtio: split virtio crypto bits rom virtio-pci.h

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/virtio-crypto-pci.c | 14 ++ > hw/virtio/virtio-pci.h| 14 -- > 2 files changed, 14 insertions(+), 14 deletions(-) > Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [RFC v2 24/24] WIP: Try to patch longer branches

2018-11-28 Thread Richard Henderson
On 11/27/18 1:10 PM, Alistair Francis wrote: > +if (short_jmp) { > +reloc_sbimm12(code_ptr, (tcg_insn_unit *)value); > +} else { > +/* Invert the condition */ > +insn = insn ^ (1 << 12); > +/* Clear the offset */ > +insn

Re: [Qemu-devel] [PATCH v2 14/16] virtio: split virtio gpu bits rom virtio-pci.h

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/display/virtio-gpu-pci.c | 14 ++ > hw/display/virtio-vga.c | 1 + > hw/virtio/virtio-pci.h | 14 -- > 3 files changed, 15 insertions(+), 14 deletions(-) > Reviewed-by: Laurent

Re: [Qemu-devel] [PATCH v2 13/16] virtio: split virtio serial bits rom virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Virtio console and qga tests also depend on CONFIG_VIRTIO_SERIAL. > > Reviewed-by: Thomas Huth > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-pci.c| 75 --- >

Re: [Qemu-devel] [PATCH v2 12/16] virtio: split virtio net bits rom virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Reviewed-by: Thomas Huth > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-net-pci.c | 96 ++ > hw/virtio/virtio-pci.c | 57 -- >

Re: [Qemu-devel] [PATCH v2 11/16] virtio: split virtio blk bits rom virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Reviewed-by: Thomas Huth > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-blk-pci.c | 97 ++ > hw/virtio/virtio-pci.c | 59 --- >

Re: [Qemu-devel] [PATCH v2 07/16] virtio: split vhost user blk bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Reviewed-by: Thomas Huth > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/vhost-user-blk-pci.c | 101 + > hw/virtio/virtio-pci.c | 60 >

Re: [Qemu-devel] [PATCH v2 10/16] virtio: split virtio scsi bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Notice that we can't still run tests with it disabled. Both cdrom-test and > drive_del-test use virtio-scsi without checking if it is enabled. > > Reviewed-by: Thomas Huth > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + >

Re: [Qemu-devel] [PATCH v2 09/16] virtio: split vhost scsi bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/vhost-scsi-pci.c | 95 ++ > hw/virtio/virtio-pci.c | 59 --- > hw/virtio/virtio-pci.h | 19 > 4

Re: [Qemu-devel] [PATCH v2 08/16] virtio: split vhost user scsi bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 21:00, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/vhost-user-scsi-pci.c | 101 > hw/virtio/virtio-pci.c | 58 -- > hw/virtio/virtio-pci.h | 11

Re: [Qemu-devel] [RFC v2 23/24] WIP: Add missing instructions

2018-11-28 Thread Richard Henderson
On 11/27/18 1:10 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > tcg/riscv/tcg-target.inc.c | 77 ++ > 1 file changed, 77 insertions(+) > > diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c > index

Re: [Qemu-devel] [PATCH v2 06/16] virtio: split virtio 9p bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 20:59, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs | 1 + > hw/virtio/virtio-9p-pci.c | 86 +++ > hw/virtio/virtio-pci.c| 52 --- > hw/virtio/virtio-pci.h| 20 - > 4

Re: [Qemu-devel] [RFC v2 14/24] riscv: tcg-target: Add branch and jump instructions

2018-11-28 Thread Richard Henderson
On 11/27/18 1:08 PM, Alistair Francis wrote: > +static inline void tcg_out_goto_long(TCGContext *s, tcg_insn_unit *target) > +{ > +ptrdiff_t offset = tcg_pcrel_diff(s, target); > + > +if (offset == sextract64(offset, 0, 26)) { > +tcg_out_opc_jump(s, OPC_JAL, TCG_REG_ZERO, offset);

[Qemu-devel] [PATCH] mirror dead-lock

2018-11-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! We've faced the following mirror bug: Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. Note: I've decided to send this as a patch with reproducer, to make it easier to reproduce). No needs to commit this before mirror fix, but after, commit message may be a bit

Re: [Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-11-28 Thread Thomas Huth
On 2018-11-28 21:03, Eric Blake wrote: > On 11/28/18 1:27 PM, BALATON Zoltan wrote: >> Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and >> bitbang_i2c.h an error even if they are identical. Move it to a common >> place to allow building with this clang version. >> >> Reported-by: Thomas

Re: [Qemu-devel] [PATCH v2 05/16] virtio: split virtio balloon bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 20:59, Juan Quintela wrote: > Signed-off-by: Juan Quintela > Reviewed-by: Thomas Huth > Signed-off-by: Juan Quintela > --- > hw/virtio/Makefile.objs| 1 + > hw/virtio/virtio-balloon-pci.c | 94 ++ > hw/virtio/virtio-pci.c | 58

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add more files to sam460ex

2018-11-28 Thread Thomas Huth
On 2018-11-28 20:41, BALATON Zoltan wrote: > The sm501 model belonged to SH before but that seems to be inactive > now and latest changes were for sam460ex which is the more active user > of this device at the moment so let's adopt sm501 for sam460ex. > > Also add device tree and firmware sources

Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 20:59, Juan Quintela wrote: > Signed-off-by: Juan Quintela > > --- > > Remove the "contributions after" clause. This is based on > > commit 59ccd20a9ac719cff82180429458728f03ec612f > Author: KONRAD Frederic > Date: Wed Apr 24 10:07:56 2013 +0200 > --- >

Re: [Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-11-28 Thread Eric Blake
On 11/28/18 1:27 PM, BALATON Zoltan wrote: Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and bitbang_i2c.h an error even if they are identical. Move it to a common place to allow building with this clang version. Reported-by: Thomas Huth Signed-off-by: BALATON Zoltan ---

Re: [Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-11-28 Thread Thomas Huth
On 2018-11-28 20:27, BALATON Zoltan wrote: > Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and > bitbang_i2c.h an error even if they are identical. Move it to a common > place to allow building with this clang version. > > Reported-by: Thomas Huth > Signed-off-by: BALATON Zoltan > --- >

[Qemu-devel] [PATCH] i2c: Move typedef of bitbang_i2c_interface to i2c.h

2018-11-28 Thread BALATON Zoltan
Clang 3.4 considers duplicate typedef in ppc4xx_i2c.h and bitbang_i2c.h an error even if they are identical. Move it to a common place to allow building with this clang version. Reported-by: Thomas Huth Signed-off-by: BALATON Zoltan --- hw/i2c/bitbang_i2c.h| 2 -- include/hw/i2c/i2c.h

[Qemu-devel] [PATCH] MAINTAINERS: Add more files to sam460ex

2018-11-28 Thread BALATON Zoltan
The sm501 model belonged to SH before but that seems to be inactive now and latest changes were for sam460ex which is the more active user of this device at the moment so let's adopt sm501 for sam460ex. Also add device tree and firmware sources and binaries. Signed-off-by: BALATON Zoltan ---

Re: [Qemu-devel] [RFC v2 11/24] riscv: tcg-target: Add the mov and movi instruction

2018-11-28 Thread Richard Henderson
On 11/27/18 1:08 PM, Alistair Francis wrote: > +static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg rd, > + tcg_target_long val) > +{ > +#if TCG_TARGET_REG_BITS == 64 > +tcg_target_long lo = sextract64(val, 0, 12); > +#else > +tcg_target_long lo =

Re: [Qemu-devel] (no subject)

2018-11-28 Thread Peter Maydell
On Wed, 28 Nov 2018 at 01:12, John Arbuckle wrote: > > From af4497f2b161bb4165acb8eee5cae3f2a7ea2227 Mon Sep 17 00:00:00 2001 > From: John Arbuckle > Date: Tue, 27 Nov 2018 20:01:20 -0500 > Subject: [PATCH] ui/cocoa.m: fix crash due to cocoa_refresh() on Mac OS 10.14 Something seems to have got

Re: [Qemu-devel] [RFC v2 10/24] riscv: tcg-target: Add the relocation functions

2018-11-28 Thread Richard Henderson
On 11/27/18 1:08 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Signed-off-by: Michael Clark > --- > tcg/riscv/tcg-target.inc.c | 51 ++ > 1 file changed, 51 insertions(+) Reviewed-by: Richard Henderson r~

  1   2   3   >