Re: [Qemu-devel] [PATCH for 4.1 v3] target/riscv: Expose time CSRs when allowed by [m|s]counteren

2019-06-25 Thread Bin Meng
On Wed, Jun 26, 2019 at 4:23 AM Jonathan Behrens wrote: > > I just did some testing on a HiFive Unleashed board and can confirm what > you are saying. The low 5 bits of both mcounteren and scounteren are > writable (if you try to write 0x to them, they'll take on the value > 0x1F) but even

Re: [Qemu-devel] [PATCH for 4.1 v3] target/riscv: Expose time CSRs when allowed by [m|s]counteren

2019-06-25 Thread Bin Meng
Hi Palmer, On Tue, Jun 25, 2019 at 5:57 PM Palmer Dabbelt wrote: > > On Mon, 24 Jun 2019 16:03:20 PDT (-0700), finte...@gmail.com wrote: > > Apparently my previous message didn't make it out onto the list (sorry > > about all these email glitches!). I've included the message again below. > > Hope

Re: [Qemu-devel] [PATCH v1 0/5] RISC-V: Add firmware loading support and default

2019-06-25 Thread Palmer Dabbelt
On Tue, 25 Jun 2019 10:06:33 PDT (-0700), alistai...@gmail.com wrote: On Mon, Jun 24, 2019 at 3:14 PM Alistair Francis wrote: This series consolidates the current RISC-V kernel loading impelementation while also adding support for the -bios option and more advanced kernel image types. After c

Re: [Qemu-devel] [PATCH] RISC-V: Add support for the Zicsr extension

2019-06-25 Thread Palmer Dabbelt
On Tue, 25 Jun 2019 08:20:55 PDT (-0700), alistai...@gmail.com wrote: On Tue, Jun 25, 2019 at 3:09 AM Palmer Dabbelt wrote: The various CSR instructions have been split out of the base ISA as part of the ratification process. This patch adds a Zicsr argument, which disables all the CSR instru

Re: [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64

2019-06-25 Thread Palmer Dabbelt
On Tue, 25 Jun 2019 08:39:21 PDT (-0700), richard.hender...@linaro.org wrote: On 6/24/19 8:08 PM, Joel Sing wrote: From 8ef31a2ce8ef1cbeee92995a0b2994f480e9bb6d Mon Sep 17 00:00:00 2001 From: Joel Sing Date: Tue, 25 Jun 2019 02:44:24 +1000 Subject: [PATCH] Clear load reservations on qemu riscv

Re: [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64

2019-06-25 Thread Palmer Dabbelt
On Tue, 25 Jun 2019 08:36:28 PDT (-0700), richard.hender...@linaro.org wrote: On 6/24/19 8:08 PM, Joel Sing wrote: Regarding the alignment for reservations, the specification does require this, although I do not recall seeing any enforcement of this by qemu itself. Ah, I see it now. Enforceme

Re: [Qemu-devel] [QEMU-PPC] [PATCH v2] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

2019-06-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190626051903.26829-1-sjitindarsi...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190626051903.26829-1-sjitindarsi...@gmail.com Type: series Subject: [Qemu-devel] [QEMU-PPC] [PA

[Qemu-devel] [QEMU-PPC] [PATCH v2] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

2019-06-25 Thread Suraj Jitindar Singh
The ibm,get_system_parameter rtas call is used by the guest to retrieve data relating to certain parameters of the system. The SPLPAR characteristics option (token 20) is used to determin characteristics of the environment in which the lpar will run. It may be useful for a guest to know the number

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-25 Thread Aravinda Prasad
On Tuesday 25 June 2019 12:30 PM, Greg Kurz wrote: > On Tue, 25 Jun 2019 11:46:06 +0530 > Aravinda Prasad wrote: > >> On Monday 24 June 2019 07:59 PM, Greg Kurz wrote: >>> On Wed, 12 Jun 2019 14:51:38 +0530 >>> Aravinda Prasad wrote: >>> This patch adds support in QEMU to handle "ibm,

Re: [Qemu-devel] [PATCH v2] deprecate -mem-path fallback to anonymous RAM

2019-06-25 Thread Markus Armbruster
Igor Mammedov writes: > Fallback might affect guest or worse whole host performance > or functionality if backing file were used to share guest RAM > with another process. > > Patch deprecates fallback so that we could remove it in future > and ensure that QEMU will provide expected behavior and

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

2019-06-25 Thread Markus Armbruster
Klaus Birkelund writes: > On Mon, Jun 24, 2019 at 12:18:45PM +0200, Kevin Wolf wrote: >> Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: >> > On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: >> > > On 06/17/19 10:12, Klaus Birkelund wrote: >> > > > Hi all, >> > > > >> > > >

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

2019-06-25 Thread Markus Armbruster
Cc: QOM maintainers in case I'm talking nonsense about QOM. Klaus Birkelund writes: > On Tue, Jun 25, 2019 at 07:51:29AM +0200, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >> > On 06/24/19 12:18, Kevin Wolf wrote: >> >> Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: >> >>> On

[Qemu-devel] [PATCH] qemu-nbd: Permit TLS with Unix sockets

2019-06-25 Thread Eric Blake
Although you generally won't use encryption with a Unix socket (after all, everything is local, so why waste the CPU power), there are situations in testsuites where Unix sockets are much nicer than TCP sockets. Since nbdkit allows encryption over both types of sockets, it makes sense for qemu-nbd

[Qemu-devel] [PATCH v4 4/5] virtio: Make sure we get correct state of device on handle_aio_output()

2019-06-25 Thread elohimes
From: Xie Yongji We should set the flags: "start_on_kick" and "started" after we call the kick functions (handle_aio_output() and handle_output()). Signed-off-by: Xie Yongji --- hw/virtio/virtio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio.c b/hw

[Qemu-devel] [PATCH v4 3/5] virtio: Set "start_on_kick" on virtio_set_features()

2019-06-25 Thread elohimes
From: Xie Yongji The guest feature is not set correctly on virtio_reset() and virtio_init(). So we should not use it to set "start_on_kick" at that point. This patch set "start_on_kick" on virtio_set_features() instead. Fixes: badaf79cfdbd3 ("virtio: Introduce started flag to VirtioDevice") Sign

[Qemu-devel] [PATCH v4 5/5] virtio: Don't change "started" flag on virtio_vmstate_change()

2019-06-25 Thread elohimes
From: Xie Yongji We will call virtio_set_status() on virtio_vmstate_change(). The "started" flag should not be changed in this case. Otherwise, we may get an incorrect value when we set "started" flag but not set DRIVER_OK in source VM. Signed-off-by: Xie Yongji --- hw/virtio/virtio.c | 5

[Qemu-devel] [PATCH v4 1/5] virtio: add "use-started" property

2019-06-25 Thread elohimes
From: Xie Yongji In order to avoid migration issues, we introduce a "use-started" property to the base virtio device to indicate whether use "started" flag or not. This property will be true by default and set to false when machine type <= 4.0. Suggested-by: Greg Kurz Signed-off-by: Xie Yongji

[Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag

2019-06-25 Thread elohimes
From: Xie Yongji We introduced two flags "started" and "start_on_kick" to indicate virtio device's state before. But there still are some problems with them. So we try to fixup them in this patchset. The patch 1 introduces a "use-started" property to avoid a migration issue under Greg Kurz's sug

[Qemu-devel] [PATCH v4 2/5] virtio: Set "start_on_kick" for legacy devices

2019-06-25 Thread elohimes
From: Xie Yongji Besides virtio 1.0 transitional devices, we should also set "start_on_kick" flag for legacy devices (virtio 0.9). Signed-off-by: Xie Yongji Reviewed-by: Greg Kurz --- hw/virtio/virtio.c | 6 ++ include/hw/virtio/virtio.h | 2 +- 2 files changed, 3 insertions(+), 5

Re: [Qemu-devel] [PATCH] virtio-pci: fix missing device properties

2019-06-25 Thread Eduardo Habkost
On Wed, Jun 26, 2019 at 01:23:33AM +0200, Marc-André Lureau wrote: > Since commit a4ee4c8baa37154 ("virtio: Helper for registering virtio > device types"), virtio-gpu-pci, virtio-vga, and virtio-crypto-pci lost > some properties: "ioeventfd" and "vectors". This may cause various > issues, such as f

Re: [Qemu-devel] [PATCH] riscv: virt: Correct pci "bus-range" encoding

2019-06-25 Thread Bin Meng
Hi, On Fri, Jun 7, 2019 at 2:46 AM Alistair Francis wrote: > > On Thu, Jun 6, 2019 at 5:55 AM Bin Meng wrote: > > > > On Thu, May 30, 2019 at 11:36 AM Bin Meng wrote: > > > > > > Hi Alistair, > > > > > > On Thu, May 30, 2019 at 11:14 AM Alistair Francis > > > wrote: > > > > > > > > On Wed, Ma

Re: [Qemu-devel] [PATCH 1/2] riscv: sifive_u: Do not create hard-coded phandles in DT

2019-06-25 Thread Bin Meng
Hi, On Sat, May 18, 2019 at 5:34 AM Alistair Francis wrote: > > On Fri, 2019-05-17 at 08:51 -0700, Bin Meng wrote: > > At present the cpu, plic and ethclk nodes' phandles are hard-coded > > to 1/2/3 in DT. If we configure more than 1 cpu for the machine, > > all cpu nodes' phandles conflict with

Re: [Qemu-devel] [PATCH] riscv: sifive_test: Add reset functionality

2019-06-25 Thread Bin Meng
Hi Palmer, On Sun, Jun 23, 2019 at 10:40 PM Palmer Dabbelt wrote: > > On Thu, 20 Jun 2019 22:40:24 PDT (-0700), bmeng...@gmail.com wrote: > > Hi Palmer, > > > > On Fri, Jun 21, 2019 at 10:53 AM Palmer Dabbelt wrote: > >> > >> On Wed, 19 Jun 2019 06:42:21 PDT (-0700), bmeng...@gmail.com wrote: >

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

2019-06-25 Thread Suraj Jitindar Singh
On Mon, 2019-06-24 at 10:37 +0200, Greg Kurz wrote: > On Mon, 24 Jun 2019 11:39:21 +1000 > Suraj Jitindar Singh wrote: > > > The ibm,get_system_parameter rtas call is used by the guest to > > retrieve > > data relating to certain parameters of the system. The SPLPAR > > characteristics option (to

Re: [Qemu-devel] [PATCH] ui: Correct icon install path

2019-06-25 Thread Colin Xu
On 2019-06-25 21:40, Eric Blake wrote: On 6/25/19 5:42 AM, Daniel P. Berrangé wrote: On Tue, Jun 25, 2019 at 11:21:42AM +0800, Colin Xu wrote: The double slash in path will fail the installation on MINGW/MSYS. Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) Signed-off-by:

Re: [Qemu-devel] [PATCH v4 00/13] Add migration support for VFIO device

2019-06-25 Thread Yan Zhao
On Tue, Jun 25, 2019 at 03:00:24AM +0800, Dr. David Alan Gilbert wrote: > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > > > > > > On 6/21/2019 2:16 PM, Yan Zhao wrote: > > > On Fri, Jun 21, 2019 at 04:02:50PM +0800, Kirti Wankhede wrote: > > >> > > >> > > >> On 6/21/2019 6:54 AM, Yan Zhao wrot

Re: [Qemu-devel] [PATCH] ui: Correct icon install path

2019-06-25 Thread Colin Xu
On 2019-06-25 18:43, Philippe Mathieu-Daudé wrote: Hi Colin, On 6/25/19 5:21 AM, Colin Xu wrote: The double slash in path will fail the installation on MINGW/MSYS. Fixes: a8260d387638 (ui: install logo icons to $prefix/share/icons) Signed-off-by: Colin Xu --- Makefile | 16 --

Re: [Qemu-devel] [PATCH v4 10/13] vfio: Add function to get dirty page list

2019-06-25 Thread Yan Zhao
On Thu, Jun 20, 2019 at 10:37:38PM +0800, Kirti Wankhede wrote: > Dirty page tracking (.log_sync) is part of RAM copying state, where > vendor driver provides the bitmap of pages which are dirtied by vendor > driver through migration region and as part of RAM copy, those pages > gets copied to file

[Qemu-devel] [PATCH] migration: current_migration is never NULL

2019-06-25 Thread Wei Yang
migration_object_init() create and assign current_migration, which means it will never be null until migration_shutdown(). Signed-off-by: Wei Yang --- migration/migration.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 0fd2364961..43fd

[Qemu-devel] [PATCH] virtio-pci: fix missing device properties

2019-06-25 Thread Marc-André Lureau
Since commit a4ee4c8baa37154 ("virtio: Helper for registering virtio device types"), virtio-gpu-pci, virtio-vga, and virtio-crypto-pci lost some properties: "ioeventfd" and "vectors". This may cause various issues, such as failing migration or invalid properties. Since those VirtioPCI devices do n

Re: [Qemu-devel] [PATCH] migration: Use RunState enum to save global state pre migrate

2019-06-25 Thread Maxiwell S. Garcia
On Tue, Jun 25, 2019 at 11:18:00AM +0100, Dr. David Alan Gilbert wrote: > * Maxiwell S. Garcia (maxiw...@linux.ibm.com) wrote: > > The GlobalState struct has two confusing fields: > > - uint8_t runstate[100] > > - RunState state > > > > The first field saves the 'current_run_state' from vl.c file

[Qemu-devel] [PATCH v2 3/5] iotests: Allow skipping test cases

2019-06-25 Thread Max Reitz
case_notrun() does not actually skip the current test case. It just adds a "notrun" note and then returns to the caller, who manually has to skip the test. Generally, skipping a test case is as simple as returning from the current function, but not always: For example, this model does not allow s

[Qemu-devel] [PATCH v2 5/5] iotests: Test driver whitelisting in 136

2019-06-25 Thread Max Reitz
null-aio may not be whitelisted. Skip all test cases that require it. Signed-off-by: Max Reitz --- tests/qemu-iotests/136 | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/136 b/tests/qemu-iotests/136 index af7ffa4540..4ef95517a1 100755 ---

[Qemu-devel] [PATCH v2 4/5] iotests: Test driver whitelisting in 093

2019-06-25 Thread Max Reitz
null-aio may not be whitelisted. Skip all test cases that require it. Signed-off-by: Max Reitz --- tests/qemu-iotests/093 | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/093 b/tests/qemu-iotests/093 index bd56c94708..806bdcaa24 100755 --- a

[Qemu-devel] [PATCH v2 2/5] iotests: Prefer null-co over null-aio

2019-06-25 Thread Max Reitz
We use null-co basically everywhere in the iotests. Unless we want to test null-aio specifically, we should use it instead (for consistency). Signed-off-by: Max Reitz --- tests/qemu-iotests/093 | 7 +++ tests/qemu-iotests/245 | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [PATCH v2 1/5] iotests: Add -display none to the qemu options

2019-06-25 Thread Max Reitz
Without this argument, qemu will print an angry message about not being able to connect to a display server if $DISPLAY is not set. For me, that breaks iotests.supported_formats() because it thus only sees ["Could", "not", "connect"] as the supported formats. Signed-off-by: Max Reitz --- tests/

[Qemu-devel] [PATCH v2 0/5] iotests: Selfish patches

2019-06-25 Thread Max Reitz
Hi, These are some rather selfish iotests patches. The first patch helps me personally because I tend to run the tests over SSH and forget to set $DISPLAY. That makes test 139 skip the tests annotated with skip_if_unsupprted(), because iotests.py can no longer determine the list of whitelisted f

Re: [Qemu-devel] [PULL 8/9] virtio-gpu: split virtio-gpu-pci & virtio-vga

2019-06-25 Thread Marc-André Lureau
Hi On Mon, Jun 24, 2019 at 5:53 PM Laurent Vivier wrote: > > On 29/05/2019 06:40, Gerd Hoffmann wrote: > > From: Marc-André Lureau > > > > Add base classes that are common to vhost-user-gpu-pci and > > vhost-user-vga. > > > > Signed-off-by: Marc-André Lureau > > Message-id: 20190524130946.31736

Re: [Qemu-devel] [PATCH for 4.1 v3] target/riscv: Expose time CSRs when allowed by [m|s]counteren

2019-06-25 Thread Jonathan Behrens
I just did some testing on a HiFive Unleashed board and can confirm what you are saying. The low 5 bits of both mcounteren and scounteren are writable (if you try to write 0x to them, they'll take on the value 0x1F) but even with the TM bit set in both mcounteren and scounteren the rdtime i

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-25 Thread Eduardo Habkost
On Mon, Jun 24, 2019 at 03:37:24PM +0200, Paolo Bonzini wrote: > On 24/06/19 15:22, Paolo Bonzini wrote: > > On 24/06/19 14:38, Alex Bennée wrote: > >> Commit 2d384d7c8 broken the build when built with: > >> > >> configure --without-default-devices --disable-user > >> > >> The reason was the conv

Re: [Qemu-devel] [libvirt] [PATCH v2] deprecate -mem-path fallback to anonymous RAM

2019-06-25 Thread Daniel P . Berrangé
On Tue, Jun 25, 2019 at 01:18:01PM -0500, Eric Blake wrote: > On 6/25/19 11:16 AM, Igor Mammedov wrote: > > Fallback might affect guest or worse whole host performance > > or functionality if backing file were used to share guest RAM > > with another process. > > > > Patch deprecates fallback so t

Re: [Qemu-devel] [libvirt] [PATCH v2] deprecate -mem-path fallback to anonymous RAM

2019-06-25 Thread Eric Blake
On 6/25/19 11:16 AM, Igor Mammedov wrote: > Fallback might affect guest or worse whole host performance > or functionality if backing file were used to share guest RAM > with another process. > > Patch deprecates fallback so that we could remove it in future > and ensure that QEMU will provide exp

Re: [Qemu-devel] [PATCH 06/10] hw/mips/gt64xxx_pci: Convert debug printf()s to trace events

2019-06-25 Thread Aleksandar Markovic
On Jun 25, 2019 12:46 AM, "Philippe Mathieu-Daudé" wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Aleksandar Markovic > Makefile.objs | 1 + > hw/mips/gt64xxx_pci.c | 29 ++--- > hw/mips/trace-events | 4 > 3 files changed, 15 inser

Re: [Qemu-devel] [PATCH 05/10] hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug printf()

2019-06-25 Thread Aleksandar Markovic
On Jun 25, 2019 12:42 AM, "Philippe Mathieu-Daudé" wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Aleksandar Markovic > hw/mips/gt64xxx_pci.c | 48 +-- > 1 file changed, 37 insertions(+), 11 deletions(-) > > diff --git a/hw/mips/gt6

Re: [Qemu-devel] [PATCH 0/6] x86 CPU model versioning

2019-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2019 at 05:13:57PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 25, 2019 at 02:00:02AM -0300, Eduardo Habkost wrote: > > This series implements basic infrastructure for CPU model > > versioning, as discussed before[1][2][3]. This will finally > > allow us to update CPU models in

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

2019-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2019 at 07:08:25PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 25, 2019 at 02:00:06AM -0300, Eduardo Habkost wrote: > > Base code for versioned CPU models. This will register a "-4.1" > > version of all existing CPU models, and make the unversioned CPU > > models be an alias for

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

2019-06-25 Thread Daniel P . Berrangé
On Tue, Jun 25, 2019 at 02:00:06AM -0300, Eduardo Habkost wrote: > Base code for versioned CPU models. This will register a "-4.1" > version of all existing CPU models, and make the unversioned CPU > models be an alias for the -4.1 versions on the pc-*-4.1 machine > types. Currently we have some

Re: [Qemu-devel] [PATCH v2 1/4] add and link a statistic struct to TBs

2019-06-25 Thread Alex Bennée
Vanderson Martins do Rosario writes: > When the tb_flush removes a block and it's recreated, this shouldn't > be creating a new block but using the one that is found by: > > lookup_result = g_list_find_custom(tb_ctx.tb_statistics, new_stats, > statistics_cmp); > > So the tb_statisticics will be

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

2019-06-25 Thread Aleksandar Markovic
On Jun 25, 2019 5:42 PM, "Mark Cave-Ayland" wrote: > > The problem is that in tcg/tcg-op.h we define "DEF(dup2_vec, 1, 2, 0, IMPLVEC | > IMPL(TCG_TARGET_REG_BITS == 32))" and in the last patchset dup2_vec isn't introduced > until towards the end. Unfortunately it's not a simple as bringing the pa

Re: [Qemu-devel] [PATCH 3/6] qmp: Add "alias-of" field to query-cpu-definitions

2019-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2019 at 05:15:33PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 25, 2019 at 02:00:05AM -0300, Eduardo Habkost wrote: > > Management software will be expected to resolve CPU model name > > aliases using the new field. > > > > Signed-off-by: Eduardo Habkost > > --- > > Cc: Eric Bl

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

2019-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2019 at 05:26:03PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 25, 2019 at 02:00:06AM -0300, Eduardo Habkost wrote: > > Base code for versioned CPU models. This will register a "-4.1" > > version of all existing CPU models, and make the unversioned CPU > > models be an alias for

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

2019-06-25 Thread Mark Cave-Ayland
On 25/06/2019 16:56, Richard Henderson wrote: > On 6/25/19 5:37 PM, Mark Cave-Ayland wrote: >> The problem is that in tcg/tcg-op.h we define "DEF(dup2_vec, 1, 2, 0, >> IMPLVEC | >> IMPL(TCG_TARGET_REG_BITS == 32))" and in the last patchset dup2_vec isn't >> introduced >> until towards the end. U

Re: [Qemu-devel] [PATCH v2 1/4] add and link a statistic struct to TBs

2019-06-25 Thread Vanderson Martins do Rosario
When the tb_flush removes a block and it's recreated, this shouldn't be creating a new block but using the one that is found by: lookup_result = g_list_find_custom(tb_ctx.tb_statistics, new_stats, statistics_cmp); So the tb_statisticics will be reused and we could just add this regen counter in t

Re: [Qemu-devel] [PATCH v8 03/10] dp8393x: manage big endian bus

2019-06-25 Thread Laurent Vivier
Le 25/06/2019 à 17:57, Philippe Mathieu-Daudé a écrit : > On 6/24/19 10:07 PM, Laurent Vivier wrote: >> Hi, >> >> Jason, Can I have an Acked-by from you (as network devices maintainer)? > > Hmm something seems odd here indeed... > > What a stable model! This file has no logical modification since

Re: [Qemu-devel] [PATCH v1 0/5] RISC-V: Add firmware loading support and default

2019-06-25 Thread Alistair Francis
On Mon, Jun 24, 2019 at 3:14 PM Alistair Francis wrote: > > This series consolidates the current RISC-V kernel loading > impelementation while also adding support for the -bios option and more > advanced kernel image types. > > After consolidating the kernel loading we can extend the boot loader t

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

2019-06-25 Thread Klaus Birkelund
On Mon, Jun 24, 2019 at 12:18:45PM +0200, Kevin Wolf wrote: > Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: > > On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: > > > On 06/17/19 10:12, Klaus Birkelund wrote: > > > > Hi all, > > > > > > > > I'm thinking about how to support

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

2019-06-25 Thread Klaus Birkelund
On Tue, Jun 25, 2019 at 07:51:29AM +0200, Markus Armbruster wrote: > Laszlo Ersek writes: > > > On 06/24/19 12:18, Kevin Wolf wrote: > >> Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: > >>> On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: > On 06/17/19 10:12, Klaus Bir

Re: [Qemu-devel] [PATCH v2] deprecate -mem-path fallback to anonymous RAM

2019-06-25 Thread Daniel P . Berrangé
On Tue, Jun 25, 2019 at 12:16:29PM -0400, Igor Mammedov wrote: > Fallback might affect guest or worse whole host performance > or functionality if backing file were used to share guest RAM > with another process. > > Patch deprecates fallback so that we could remove it in future > and ensure that

Re: [Qemu-devel] [PATCH v4 04/10] block/pflash_cfi02: Implement intereleaved flash devices

2019-06-25 Thread Stephen Checkoway
> On Jun 25, 2019, at 04:32, Markus Armbruster wrote: > > Stephen Checkoway writes: > >>> On Jun 24, 2019, at 12:05, Philippe Mathieu-Daudé wrote: >>> On 6/22/19 2:25 PM, Philippe Mathieu-Daudé wrote: Hi Stephen, This series haven't fall through the cracks, however it

[Qemu-devel] [PATCH v2] deprecate -mem-path fallback to anonymous RAM

2019-06-25 Thread Igor Mammedov
Fallback might affect guest or worse whole host performance or functionality if backing file were used to share guest RAM with another process. Patch deprecates fallback so that we could remove it in future and ensure that QEMU will provide expected behavior and fail if it can't use user provided

Re: [Qemu-devel] [PATCH v5 0/2] Guest Support for DIAGNOSE 0x318

2019-06-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1561475829-19202-1-git-send-email-wall...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 0/2] Guest Support for DIAGNOSE 0x318 Type: series Message-id: 156147

Re: [Qemu-devel] [PATCH 3/6] qmp: Add "alias-of" field to query-cpu-definitions

2019-06-25 Thread Daniel P . Berrangé
On Tue, Jun 25, 2019 at 02:00:05AM -0300, Eduardo Habkost wrote: > Management software will be expected to resolve CPU model name > aliases using the new field. > > Signed-off-by: Eduardo Habkost > --- > Cc: Eric Blake > Cc: Markus Armbruster > --- > qapi/target.json | 9 - > 1 file ch

Re: [Qemu-devel] [PATCH v8 10/10] hw/m68k: define Macintosh Quadra 800

2019-06-25 Thread Thomas Huth
Am Thu, 20 Jun 2019 00:19:33 +0200 schrieb Laurent Vivier : > If you want to test the machine, it doesn't yet boot a MacROM, but > you can boot a linux kernel from the command line. I gave the patch series a quick try, and was indeed able to boot the Debian installer with the q800 machine, so: T

Re: [Qemu-devel] [PATCH 0/6] x86 CPU model versioning

2019-06-25 Thread Daniel P . Berrangé
On Tue, Jun 25, 2019 at 02:00:02AM -0300, Eduardo Habkost wrote: > This series implements basic infrastructure for CPU model > versioning, as discussed before[1][2][3]. This will finally > allow us to update CPU models in ways that introduce new software > or hardware requirements. > > My origina

Re: [Qemu-devel] [PATCH v2 1/4] add and link a statistic struct to TBs

2019-06-25 Thread Alex Bennée
Alex Bennée writes: > vandersonmr writes: > >> We want to store statistics for each TB even after flushes. >> We do not want to modify or grow the TB struct. >> So we create a new struct to contain this statistics and >> link it to each TB while they are created. >> >> Signed-off-by: Vanderson

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

2019-06-25 Thread Daniel P . Berrangé
On Tue, Jun 25, 2019 at 02:00:06AM -0300, Eduardo Habkost wrote: > Base code for versioned CPU models. This will register a "-4.1" > version of all existing CPU models, and make the unversioned CPU > models be an alias for the -4.1 versions on the pc-*-4.1 machine > types. > > On older machine ty

Re: [Qemu-devel] [PATCH v2] block/rbd: add preallocation support

2019-06-25 Thread Max Reitz
On 06.05.19 14:23, Stefano Garzarella wrote: > This patch adds the support of preallocation (off/full) for the RBD > block driver. > If available, we use rbd_writesame() to quickly fill the image when > full preallocation is required. > > Signed-off-by: Stefano Garzarella > --- > v2: > - Use 4 Ki

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

2019-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2019 at 03:56:51PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Tue, Jun 25, 2019 at 03:32:16PM +0100, Dr. David Alan Gilbert wrote: > > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > > On Tue, Jun 25, 2019 at 10:32:01AM +0100,

Re: [Qemu-devel] [Bug 1833668] Re: linux-user: Unable to run ARM binaries on Aarch64

2019-06-25 Thread Philippe Mathieu-Daudé
On 6/25/19 5:27 PM, Laurent Vivier wrote: > Le 25/06/2019 à 16:43, Richard Henderson a écrit : >> Of course. There's a separate qemu-arm executable for that. > > On some other architectures (like ppc/ppc64) the idea is the 64bit > version supports also all 32bit versions CPUs. > > I think it's w

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

2019-06-25 Thread Richard Henderson
On 6/25/19 5:37 PM, Mark Cave-Ayland wrote: > The problem is that in tcg/tcg-op.h we define "DEF(dup2_vec, 1, 2, 0, IMPLVEC > | > IMPL(TCG_TARGET_REG_BITS == 32))" and in the last patchset dup2_vec isn't > introduced > until towards the end. Unfortunately it's not a simple as bringing the patch

Re: [Qemu-devel] [PATCH v3 0/4] Clean ups in net/net.c

2019-06-25 Thread Stefano Garzarella
Ping. Thanks, Stefano On Fri, May 17, 2019 at 3:51 PM Stefano Garzarella wrote: > > This series contains some clean ups in net/net.c > > The patch 1 solves an assertion failure when ipv6-prefixlen is not a number, > > Following the Markus' advice, I modified the parsing of IPv6 prefix > (patch 2

Re: [Qemu-devel] [PATCH v8 03/10] dp8393x: manage big endian bus

2019-06-25 Thread Philippe Mathieu-Daudé
On 6/24/19 10:07 PM, Laurent Vivier wrote: > Hi, > > Jason, Can I have an Acked-by from you (as network devices maintainer)? Hmm something seems odd here indeed... What a stable model! This file has no logical modification since its introduction, a65f56eeba "Implement sonic netcard (MIPS Jazz)"

Re: [Qemu-devel] [PATCH v4 0/7] tcg/ppc: Add vector opcodes

2019-06-25 Thread Mark Cave-Ayland
On 25/06/2019 07:56, Richard Henderson wrote: >>> One more hint: if I try a build of d8dcbb57e9 along with my >>> tcg_can_emit_vec_op() >>> hack and pass --enable-debug-tcg to configure then I get an assert on >>> startup: >>> >>> qemu-system-ppc: /home/mca/src/qemu/tcg/tcg.c:2207: process_op_de

Re: [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64

2019-06-25 Thread Richard Henderson
On 6/24/19 8:08 PM, Joel Sing wrote: > From 8ef31a2ce8ef1cbeee92995a0b2994f480e9bb6d Mon Sep 17 00:00:00 2001 > From: Joel Sing > Date: Tue, 25 Jun 2019 02:44:24 +1000 > Subject: [PATCH] Clear load reservations on qemu riscv target > > This prevents a load reservation from being placed in one con

Re: [Qemu-devel] [PATCH v3] block/rbd: increase dynamically the image size

2019-06-25 Thread Max Reitz
On 25.06.19 17:28, Stefano Garzarella wrote: > On Tue, Jun 25, 2019 at 04:57:53PM +0200, Max Reitz wrote: >> On 25.06.19 16:47, Stefano Garzarella wrote: >>> On Tue, Jun 25, 2019 at 04:02:04PM +0200, Max Reitz wrote: On 09.05.19 16:59, Stefano Garzarella wrote: > RBD APIs don't allow us to

Re: [Qemu-devel] [RFC 1/1] hw/pvrdma: Add live migration support

2019-06-25 Thread Yuval Shaia
On Fri, Jun 21, 2019 at 08:15:41PM +0530, Sukrit Bhatnagar wrote: > Define and register SaveVMHandlers pvrdma_save and > pvrdma_load for saving and loading the device state, > which currently includes only the dma, command slot > and response slot addresses. > > Remap the DSR, command slot and res

Re: [Qemu-devel] [RFC 1/1] hw/pvrdma: Add live migration support

2019-06-25 Thread Yuval Shaia
On Fri, Jun 21, 2019 at 08:15:41PM +0530, Sukrit Bhatnagar wrote: > Define and register SaveVMHandlers pvrdma_save and > pvrdma_load for saving and loading the device state, > which currently includes only the dma, command slot > and response slot addresses. > > Remap the DSR, command slot and res

Re: [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64

2019-06-25 Thread Richard Henderson
On 6/24/19 8:08 PM, Joel Sing wrote: > Regarding the alignment for reservations, the > specification does require this, although I do not recall seeing any > enforcement > of this by qemu itself. Ah, I see it now. Enforcement begins here: static bool trans_lr_w(DisasContext *ctx, arg_lr_w *a) {

Re: [Qemu-devel] [PATCH v3] block/rbd: increase dynamically the image size

2019-06-25 Thread Stefano Garzarella
On Tue, Jun 25, 2019 at 04:57:53PM +0200, Max Reitz wrote: > On 25.06.19 16:47, Stefano Garzarella wrote: > > On Tue, Jun 25, 2019 at 04:02:04PM +0200, Max Reitz wrote: > >> On 09.05.19 16:59, Stefano Garzarella wrote: > >>> RBD APIs don't allow us to write more than the size set with > >>> rbd_cre

Re: [Qemu-devel] [PATCH] RISC-V: Add support for the Zicsr extension

2019-06-25 Thread Alistair Francis
On Tue, Jun 25, 2019 at 3:09 AM Palmer Dabbelt wrote: > > The various CSR instructions have been split out of the base ISA as part > of the ratification process. This patch adds a Zicsr argument, which > disables all the CSR instructions. > > Signed-off-by: Palmer Dabbelt > --- > target/riscv/c

Re: [Qemu-devel] [PATCH v4 01/13] vfio: KABI for migration interface

2019-06-25 Thread Kirti Wankhede
On 6/25/2019 12:31 AM, Alex Williamson wrote: > On Tue, 25 Jun 2019 00:22:16 +0530 > Kirti Wankhede wrote: > >> On 6/24/2019 8:55 PM, Alex Williamson wrote: >>> On Mon, 24 Jun 2019 20:30:08 +0530 >>> Kirti Wankhede wrote: >>> On 6/22/2019 3:31 AM, Alex Williamson wrote: > On Sat

Re: [Qemu-devel] [Bug 1833668] Re: linux-user: Unable to run ARM binaries on Aarch64

2019-06-25 Thread Laurent Vivier
Le 25/06/2019 à 16:43, Richard Henderson a écrit : > Of course. There's a separate qemu-arm executable for that. On some other architectures (like ppc/ppc64) the idea is the 64bit version supports also all 32bit versions CPUs. I think it's why this bug has been opened.

[Qemu-devel] [PATCH v5 1/2] s390/kvm: header sync for diag318

2019-06-25 Thread Collin Walling
Signed-off-by: Collin Walling --- linux-headers/asm-s390/kvm.h | 4 1 file changed, 4 insertions(+) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 03ab596..4a857bb 100644 --- a/linux-headers/asm-s390/kvm.h +++ b/linux-headers/asm-s390/kvm.h @@ -74,6 +74,7 @@

Re: [Qemu-devel] [PATCH v7 0/3] block/stream: get rid of the base

2019-06-25 Thread Andrey Shinkevich
On 25/06/2019 18:03, Max Reitz wrote: > On 25.06.19 16:40, Andrey Shinkevich wrote: >> >> >> On 19/06/2019 22:29, Max Reitz wrote: >>> On 29.05.19 19:56, Andrey Shinkevich wrote: This series introduces a bottom intermediate node that eliminates the dependency on the base that may change

[Qemu-devel] [PATCH v5 0/2] Guest Support for DIAGNOSE 0x318

2019-06-25 Thread Collin Walling
Changelog: v5 - split off header updates in kvm_s390x.h to a separate patch - implemented CPU model feature for this insn made available with zEC12-full and later models - s/cpc/diag318_info in order to make the relevant data more clear - reduced S39

Re: [Qemu-devel] [PATCH v7 0/3] block/stream: get rid of the base

2019-06-25 Thread Max Reitz
On 25.06.19 16:40, Andrey Shinkevich wrote: > > > On 19/06/2019 22:29, Max Reitz wrote: >> On 29.05.19 19:56, Andrey Shinkevich wrote: >>> This series introduces a bottom intermediate node that eliminates the >>> dependency on the base that may change while stream job is running. >>> It happens w

[Qemu-devel] [PATCH v5 2/2] s390: diagnose 318 info reset and migration support

2019-06-25 Thread Collin Walling
DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM. Let's introduce some functions to communicate between QEMU and KVM via ioctls. These will be used to get/set the diag318 information. The availability of this instruction is determined b

Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value

2019-06-25 Thread Richard Henderson
On 6/21/19 1:28 PM, Paolo Bonzini wrote: > While indeed we do not want to have > > return (a); > > it is less clear that this applies to > > return (a && > b); > > Some editors indent more nicely if you have parentheses, and some people's > eyes may appreciate that as well.

Re: [Qemu-devel] [PATCH v3] block/rbd: increase dynamically the image size

2019-06-25 Thread Max Reitz
On 25.06.19 16:47, Stefano Garzarella wrote: > On Tue, Jun 25, 2019 at 04:02:04PM +0200, Max Reitz wrote: >> On 09.05.19 16:59, Stefano Garzarella wrote: >>> RBD APIs don't allow us to write more than the size set with >>> rbd_create() or rbd_resize(). >>> In order to support growing images (eg. qc

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

2019-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2019 at 03:32:16PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Tue, Jun 25, 2019 at 10:32:01AM +0100, Dr. David Alan Gilbert wrote: > > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > > Base code for versioned CPU models. This

Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models

2019-06-25 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Tue, Jun 25, 2019 at 03:32:16PM +0100, Dr. David Alan Gilbert wrote: > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > On Tue, Jun 25, 2019 at 10:32:01AM +0100, Dr. David Alan Gilbert wrote: > > > > * Eduardo Habkost (ehabk...@redhat.com) w

[Qemu-devel] [Bug 1833668] Re: linux-user: Unable to run ARM binaries on Aarch64

2019-06-25 Thread Richard Henderson
Of course. There's a separate qemu-arm executable for that. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1833668 Title: linux-user: Unable to ru

Re: [Qemu-devel] [PATCH 1/2] dma/rc4030: Fix off-by-one error in specified memory region size

2019-06-25 Thread Philippe Mathieu-Daudé
On 6/25/19 4:27 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > The size is one byte less than it should be: > > address-space: rc4030-dma > -fffe (prio 0, i/o): rc4030.dma > > rc4030 is used in MIPS Jazz board context. Ah thanks :) I was planing to

Re: [Qemu-devel] [PATCH v3] block/rbd: increase dynamically the image size

2019-06-25 Thread Stefano Garzarella
On Tue, Jun 25, 2019 at 04:02:04PM +0200, Max Reitz wrote: > On 09.05.19 16:59, Stefano Garzarella wrote: > > RBD APIs don't allow us to write more than the size set with > > rbd_create() or rbd_resize(). > > In order to support growing images (eg. qcow2), we resize the > > image before write opera

Re: [Qemu-devel] [PATCH 2/2] dma/rc4030: Minor code style cleanup

2019-06-25 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Tuesday, June 25, 2019 4:27 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; Aleksandar Rikalo; hpous...@reactos.org; > f4...@amsat.org > Subject: [PATCH 2/2] dma/rc4030: Minor code style cleanup > > From: Aleksandar Markovic > > Fix some simple check

Re: [Qemu-devel] [PATCH v7 0/3] block/stream: get rid of the base

2019-06-25 Thread Andrey Shinkevich
On 19/06/2019 22:29, Max Reitz wrote: > On 29.05.19 19:56, Andrey Shinkevich wrote: >> This series introduces a bottom intermediate node that eliminates the >> dependency on the base that may change while stream job is running. >> It happens when stream/commit parallel jobs are running on the sam

Re: [Qemu-devel] [PATCH 2/2] dma/rc4030: Minor code style cleanup

2019-06-25 Thread Philippe Mathieu-Daudé
On 6/25/19 4:27 PM, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Fix some simple checkpatch.pl warnings in rc4030.c. > > Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé > --- > hw/dma/rc4030.c | 18 +++--- > 1 file changed, 11 insertions(+),

Re: [Qemu-devel] [PATCH v1 1/1] tcg/riscv: Fix RISC-VH host build failure

2019-06-25 Thread Richard Henderson
On 6/20/19 4:04 PM, Alistair Francis wrote: > Commit 269bd5d8 "cpu: Move the softmmu tlb to CPUNegativeOffsetState' > broke the RISC-V host build as there are two variables that are used but > not defined. > > This patch renames the undefined variables mask_off and table_off to the > existing (but

Re: [Qemu-devel] [PATCH v5 0/6] target/mips: Improve MSA TCG tests

2019-06-25 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Tuesday, June 25, 2019 2:59 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; Aleksandar Rikalo > Subject: [PATCH v5 0/6] target/mips: Improve MSA TCG tests > > From: Aleksandar Markovic > > This series contains various improvements and additions of MSA

Re: [Qemu-devel] [PATCH 1/2] dma/rc4030: Fix off-by-one error in specified memory region size

2019-06-25 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Tuesday, June 25, 2019 4:27 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; Aleksandar Rikalo; hpous...@reactos.org; > f4...@amsat.org > Subject: [PATCH 1/2] dma/rc4030: Fix off-by-one error in specified memory > region size > > From: Aleksandar Mark

  1   2   3   >