Re: [Qemu-devel] [PATCH v4 5/7] iotests: Test driver whitelisting in 093

2019-09-17 Thread Max Reitz
On 17.09.19 16:25, Andrey Shinkevich wrote: > > > On 17/09/2019 12:20, Max Reitz wrote: >> null-aio may not be whitelisted. Skip all test cases that require it. >> >> (And skip the whole test if null-co is not whitelisted.) > This solution has been persisting since v1. Nevertheless, I am still n

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-17 Thread Jason Wang
On 2019/9/18 上午9:44, Tian, Kevin wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Tuesday, September 17, 2019 6:36 PM On 2019/9/17 下午4:48, Tian, Kevin wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, September 16, 2019 4:33 PM On 2019/9/16 上午9:51, Tian, Kevin wro

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-17 Thread Jason Wang
On 2019/9/18 上午9:31, Tian, Kevin wrote: From: Alex Williamson [mailto:alex.william...@redhat.com] Sent: Tuesday, September 17, 2019 10:54 PM On Tue, 17 Sep 2019 08:48:36 + "Tian, Kevin" wrote: From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, September 16, 2019 4:33 PM On 20

Re: [Qemu-devel] Call for volunteers: LWN.net articles about KVM Forum talks

2019-09-17 Thread Pankaj Gupta
Hi Stefan, > > Hi, > LWN.net is a popular open source news site that covers Linux and other > open source communities (Python, GNOME, Debian, etc). It has published > a few KVM articles in the past too. > > Let's raise awareness of QEMU, KVM, and libvirt by submitting articles > covering > KV

Re: [Qemu-devel] [PATCH v3 00/18] ppc/pnv: add XIVE support for KVM guests

2019-09-17 Thread David Gibson
On Tue, Sep 17, 2019 at 01:54:24PM +0200, Cédric Le Goater wrote: > On 31/07/2019 16:12, Cédric Le Goater wrote: > > Hello, > > > > The QEMU PowerNV machine emulates a baremetal OpenPOWER system and > > acts as an hypervisor (L0). Supporting emulation of KVM to run guests > > (L1) requires a few m

[Qemu-devel] [RFC 1/3] exec: Adjust notdirty tracing

2019-09-17 Thread Richard Henderson
The memory_region_tb_read tracepoint is unreachable, since notdirty is supposed to apply only to reads. The memory_region_tb_write tracepoint is mis-named, because notdirty is not only used for TB invalidation. It is also used for e.g. VGA RAM updates. Replace memory_region_tb_write with memory_

[Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb

2019-09-17 Thread Richard Henderson
RFC because this doesn't work, and I don't quite understand why. The only failing test is {i386,x86_64} pxe-test -- the other migration tests that use notdirty all pass. Note that if you try to reproduce this on x86, you'll likely have to --disable-kvm, as otherwise the pxe-test will skip tcg. An

[Qemu-devel] [RFC 3/3] cputlb: Remove ATOMIC_MMU_DECLS

2019-09-17 Thread Richard Henderson
This macro no longer has a non-empty definition. Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 12 accel/tcg/cputlb.c | 1 - accel/tcg/user-exec.c | 1 - 3 files changed, 14 deletions(-) diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atom

[Qemu-devel] [RFC 2/3] cputlb: Move NOTDIRTY handling from I/O path to TLB path

2019-09-17 Thread Richard Henderson
Pages that we want to track for NOTDIRTY are RAM. We do not really need to go through the I/O path to handle them. Create cpu_notdirty_write() from the corpses of memory_notdirty_write_prepare and memory_notdirty_write_complete. Use this new function to implement all of the notdirty handling. Th

Re: [Qemu-devel] Call for volunteers: LWN.net articles about KVM Forum talks

2019-09-17 Thread Sergio Lopez
Stefan Hajnoczi writes: > Hi, > LWN.net is a popular open source news site that covers Linux and other > open source communities (Python, GNOME, Debian, etc). It has published > a few KVM articles in the past too. > > Let's raise awareness of QEMU, KVM, and libvirt by submitting articles > cov

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-17 Thread Libo Zhou
Alex Bennée writes: > You will need to update gdb-xml/$ARCH.xml and the appropriate arch_read/write register functions in gdbstub. For some mysterious reason my previous emails didn't go to the list successfully. Let me try sending this one without including any code or link. The MIPS targe

Re: [Qemu-devel] [PATCH v2 2/2] ppc: Add support for 'mffsce' instruction

2019-09-17 Thread David Gibson
On Tue, Sep 17, 2019 at 04:49:56PM -0500, Paul Clarke wrote: > On 9/17/19 3:46 PM, Richard Henderson wrote: > > On 9/16/19 1:02 PM, Paul A. Clarke wrote: > >> From: "Paul A. Clarke" > >> > >> ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) > >> instructions: mffsce, mffs

Re: [Qemu-devel] [PATCH 3/3] tests/acceptance/migration: test to migrate will all machine types

2019-09-17 Thread David Gibson
On Tue, Sep 17, 2019 at 10:44:25AM +0100, Dr. David Alan Gilbert wrote: > * Balamuruhan S (bal...@linux.ibm.com) wrote: > > On Mon, Sep 16, 2019 at 03:50:06PM +0100, Dr. David Alan Gilbert wrote: > > > * Balamuruhan S (bal...@linux.ibm.com) wrote: > > > > add migration test to query machine types s

Re: [Qemu-devel] [PATCH] docker: add sanitizers back to clang build

2019-09-17 Thread Fam Zheng
On Thu, 09/12 19:07, John Snow wrote: > > > On 9/11/19 9:52 PM, no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/20190912014442.5757-1-js...@redhat.com/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below for > > more in

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-17 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Wednesday, September 18, 2019 9:32 AM > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, September 17, 2019 10:54 PM > > > > On Tue, 17 Sep 2019 08:48:36 + > > "Tian, Kevin" wrote: > > > > > > From: Jason Wang [mailto:jasow...@redhat

Re: [Qemu-devel] [PATCH v1 0/2] RISC-V: Convert to do_transaction_failed hook

2019-09-17 Thread Richard Henderson
On 9/17/19 4:22 PM, Alistair Francis wrote: > Palmer Dabbelt (2): > RISC-V: Handle bus errors in the page table walker > RISC-V: Implement cpu_do_transaction_failed Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

2019-09-17 Thread Jonathan Behrens
I went through the uses of mie in the entire hypervisor patch series and it seems like it would be much simpler to just have two non-pointer fields in the CPU struct: mie and vsie. To if an interrupt is pending, you are either running with V=0 in which case the contents of vsie can be ignored, or y

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-17 Thread Tian, Kevin
> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Tuesday, September 17, 2019 6:36 PM > > On 2019/9/17 下午4:48, Tian, Kevin wrote: > >> From: Jason Wang [mailto:jasow...@redhat.com] > >> Sent: Monday, September 16, 2019 4:33 PM > >> > >> > >> On 2019/9/16 上午9:51, Tian, Kevin wrote: > >>> Hi,

Re: [Qemu-devel] [PATCH v3 2/3] virtio: add vhost-user-fs base device

2019-09-17 Thread piaojun
On 2019/9/18 0:00, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The virtio-fs virtio device provides shared file system access using > the FUSE protocol carried over virtio. > The actual file server is implemented in an external vhost-user-fs device > backend proces

Re: [Qemu-devel] vhost, iova, and dirty page tracking

2019-09-17 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, September 17, 2019 10:54 PM > > On Tue, 17 Sep 2019 08:48:36 + > "Tian, Kevin" wrote: > > > > From: Jason Wang [mailto:jasow...@redhat.com] > > > Sent: Monday, September 16, 2019 4:33 PM > > > > > > > > > On 2019/9/

Re: [Qemu-devel] [PATCH v3 3/3] virtio: add vhost-user-fs-pci device

2019-09-17 Thread piaojun
On 2019/9/18 0:00, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add the PCI version of vhost-user-fs. > > Launch QEMU like this: > > qemu -chardev socket,path=/tmp/vhost-fs.sock,id=chr0 >-device x-vhost-user-fs-pci,tag=myfs,chardev=chr0 > > Signed-off-b

[Qemu-devel] [PATCH] chardev: Add RFC2217 support for telnet client mode

2019-09-17 Thread Sylvain Munaut
This allow remote control of the baudrate and other comms parameters. Signed-off-by: Sylvain Munaut --- chardev/char-socket.c | 232 ++ chardev/char.c| 6 ++ qapi/char.json| 3 + 3 files changed, 201 insertions(+), 40 deletions(-) diff

Re: [Qemu-devel] [PATCH v6 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

2019-09-17 Thread Peter Xu
On Tue, Sep 17, 2019 at 03:42:12PM +0200, Igor Mammedov wrote: > On Tue, 17 Sep 2019 16:44:42 +0800 > Peter Xu wrote: > > > On Mon, Sep 16, 2019 at 09:23:47AM -0400, Igor Mammedov wrote: > > > PS: > > > I don't have access to a suitable system to test it. > > > > Hmm I feel like it would be go

Re: [Qemu-devel] [PATCH 04/17] ppc: Pass local error object pointer to error_append_hint()

2019-09-17 Thread David Gibson
On Tue, Sep 17, 2019 at 12:20:56PM +0200, Greg Kurz wrote: > Ensure that hints are added even if errp is &error_fatal or &error_abort. > > Signed-off-by: Greg Kurz Acked-by: David Gibson > --- > hw/ppc/mac_newworld.c |7 +-- > hw/ppc/spapr.c|7 +-- > hw/ppc/spapr_pci.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

2019-09-17 Thread David Gibson
On Tue, Sep 17, 2019 at 12:19:52PM +1000, David Gibson wrote: > On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: > > On 9/16/19 11:52 AM, Alex Bennée wrote: > > > > > > Philippe Mathieu-Daudé writes: > > > > > >> Hi David, > > >> > > >> On 9/16/19 2:42 AM, David Gibson wro

[Qemu-devel] [PATCH v5 5/5] iotests: use python logging for iotests.log()

2019-09-17 Thread John Snow
We can turn logging on/off globally instead of per-function. Remove use_log from run_job, and use python logging to turn on diffable output when we run through a script entry point. iotest 245 changes output order due to buffering reasons. Signed-off-by: John Snow --- tests/qemu-iotests/030

[Qemu-devel] [PATCH v5 2/5] iotests: add script_initialize

2019-09-17 Thread John Snow
Like script_main, but doesn't require a single point of entry. Replace all existing initialization sections with this drop-in replacement. This brings debug support to all existing script-style iotests. Any specification for supported_oses=['linux'] was dropped as explained in the previous commit

[Qemu-devel] [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms

2019-09-17 Thread John Snow
verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that always specified linux

[Qemu-devel] [PATCH v5 3/5] iotest 258: use script_main

2019-09-17 Thread John Snow
Since this one is nicely factored to use a single entry point, use script_main to run the tests. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/258 | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/258 b/tes

[Qemu-devel] [PATCH v5 4/5] iotests: specify protocol support via initialization info

2019-09-17 Thread John Snow
Any one of the iotests.main, iotests.script_main, or iotests.script_initialize functions can specify verify_protocols. Remove the last users of calling the function individually. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/207 | 4 ++-- tests/qemu-

[Qemu-devel] [PATCH v5 0/5] iotests: use python logging

2019-09-17 Thread John Snow
This series uses python logging to enable output conditionally on iotests.log(). We unify an initialization call (which also enables debugging output for those tests with -d) and then make the switch inside of iotests. It will help alleviate the need to create logged/unlogged versions of all the v

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-09-17 Thread Eduardo Habkost
On Tue, Sep 17, 2019 at 07:10:13PM -0400, John Snow wrote: > On 9/17/19 5:48 PM, Eduardo Habkost wrote: > > On Tue, Sep 17, 2019 at 03:57:26PM +0200, Kevin Wolf wrote: > >> Am 11.06.2019 um 19:12 hat Eduardo Habkost geschrieben: > >>> On Tue, Jun 11, 2019 at 05:07:55PM +0100, Peter Maydell wrote: >

Re: [Qemu-devel] [Qemu-riscv] [PATCH v1 10/28] target/riscv: Convert mie and mstatus to pointers

2019-09-17 Thread Alistair Francis
On Wed, Sep 11, 2019 at 7:55 AM Jonathan Behrens wrote: > > Version 0.4 of the hypervisor spec no longer talks about swapping registers. > Instead when running in VS-mode some of the supervisor registers are > "aliased" and actually refer to alternate versions. Implementations are of > course s

Re: [Qemu-devel] [PATCH 09/13] hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory

2019-09-17 Thread Alistair Francis
On Tue, Sep 17, 2019 at 3:28 AM Philippe Mathieu-Daudé wrote: > > Hi Alistair, > > On 9/16/19 11:44 PM, Alistair Francis wrote: > > On Mon, Sep 16, 2019 at 8:56 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Move RTC devices under the hw/rtc/ subdirectory. > >> > >> Signed-off-by: Philippe Mathie

Re: [Qemu-devel] Python 2 in tests/vm (was Re: [PULL 0/8] Python queue, 2019-06-07)

2019-09-17 Thread Eduardo Habkost
On Mon, Jul 01, 2019 at 07:25:27PM -0300, Eduardo Habkost wrote: > On Mon, Jun 10, 2019 at 01:58:50PM +0100, Peter Maydell wrote: > > On Fri, 7 Jun 2019 at 22:16, Eduardo Habkost wrote: > > > > > > The following changes since commit > > > 185b7ccc11354cbd69b6d53bf8d831dd964f6c88: > > > > > > Me

[Qemu-devel] [PATCH v1 1/2] RISC-V: Handle bus errors in the page table walker

2019-09-17 Thread Alistair Francis
From: Palmer Dabbelt We directly access physical memory while walking the page tables on RISC-V, but while doing so we were using cpu_ld*() which does not report bus errors. This patch converts the page table walker over to use address_space_ld*(), which allows bus errors to be detected. Signed

[Qemu-devel] [PATCH v1 0/2] RISC-V: Convert to do_transaction_failed hook

2019-09-17 Thread Alistair Francis
The do_unassigned_access hook has been deprecated and RISC-V is the last user of it. Let's instead update the RISC-V implementation to use do_transaction_failed instead. After this series I used the 'git grep' regexes in docs/devel/loads-stores.rst and these are the memory accesses inside target/r

[Qemu-devel] [PATCH v1 2/2] RISC-V: Implement cpu_do_transaction_failed

2019-09-17 Thread Alistair Francis
From: Palmer Dabbelt This converts our port over from cpu_do_unassigned_access to cpu_do_transaction_failed, as cpu_do_unassigned_access has been deprecated. Signed-off-by: Palmer Dabbelt Signed-off-by: Alistair Francis --- target/riscv/cpu.c| 2 +- target/riscv/cpu.h| 7 +++

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-09-17 Thread John Snow
On 9/17/19 5:48 PM, Eduardo Habkost wrote: > On Tue, Sep 17, 2019 at 03:57:26PM +0200, Kevin Wolf wrote: >> Am 11.06.2019 um 19:12 hat Eduardo Habkost geschrieben: >>> On Tue, Jun 11, 2019 at 05:07:55PM +0100, Peter Maydell wrote: On Tue, 11 Jun 2019 at 17:03, Eduardo Habkost wrote: >

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

2019-09-17 Thread John Snow
On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.09.2019 3:16, John Snow wrote: >> Like script_main, but doesn't require a single point of entry. >> Replace all existing initialization sections with this drop-in replacement. >> >> This brings debug support to all existing script-sty

Re: [Qemu-devel] [PATCH v2 2/2] ppc: Add support for 'mffsce' instruction

2019-09-17 Thread Paul Clarke
On 9/17/19 3:46 PM, Richard Henderson wrote: > On 9/16/19 1:02 PM, Paul A. Clarke wrote: >> From: "Paul A. Clarke" >> >> ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) >> instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. >> This patch adds support for

Re: [Qemu-devel] [PATCH v2 1/2] ppc: Add support for 'mffscrn', 'mffscrni' instructions

2019-09-17 Thread Paul Clarke
On 9/17/19 3:45 PM, Richard Henderson wrote: > On 9/16/19 1:02 PM, Paul A. Clarke wrote: >> +#define FP_DRN2 (1ull << FPSCR_DRN2) >> +#define FP_DRN1 (1ull << FPSCR_DRN1) >> +#define FP_DRN0 (1ull << FPSCR_DRN0) >> +#define FP_DRN (FP_DRN2 | FP_DRN1 | FP_DRN0) > >

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-09-17 Thread Eduardo Habkost
On Tue, Sep 17, 2019 at 03:57:26PM +0200, Kevin Wolf wrote: > Am 11.06.2019 um 19:12 hat Eduardo Habkost geschrieben: > > On Tue, Jun 11, 2019 at 05:07:55PM +0100, Peter Maydell wrote: > > > On Tue, 11 Jun 2019 at 17:03, Eduardo Habkost wrote: > > > > > > > > On Tue, Jun 11, 2019 at 04:50:34PM +01

Re: [Qemu-devel] [PATCH] vhost-user: save features if the char dev is closed

2019-09-17 Thread Michael S. Tsirkin
On Tue, Sep 17, 2019 at 09:19:01PM +0200, Adrian Moreno wrote: > That way the state can be correctly restored when the device is opened > again. This might happen if the backend is restarted. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1738768 > Reported-by: Pei Zhang > Fixes: 6ab79a

Re: [Qemu-devel] [PATCH v1 8/9] tests/tcg: add generic version of float_convs

2019-09-17 Thread Richard Henderson
On 9/17/19 4:57 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 9/17/19 2:41 PM, Alex Bennée wrote: >>> +for (i = 0; i < ARRAY_SIZE(round_flags); ++i) { >>> +fesetround(round_flags[i].flag); >> >> If we're going to make this a generic test, perhaps >> continue if fesetro

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-17 Thread Richard Henderson
On 9/17/19 5:00 PM, Alex Bennée wrote: >>> +add_f32_const(0x8p-152); >>> +add_f32_const(0x8p-152); >>> +add_f32_const(0x8p-152); >> >> Why are you adding 3 of the same? > > To replicate the 1841491 test case where the same number is used for > a/b/c Then we really ought to be more exp

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-17 Thread Alex Bennée
Richard Henderson writes: > On 9/17/19 2:41 PM, Alex Bennée wrote: >> +/* From https://bugs.launchpad.net/qemu/+bug/1841491 */ >> +add_f32_const(0x1.cp-1022); >> +add_f32_const(0x1.1p-1); >> +add_f32_const(0x0.1p-1022); > > These three constan

Re: [Qemu-devel] [PATCH v1 8/9] tests/tcg: add generic version of float_convs

2019-09-17 Thread Alex Bennée
Richard Henderson writes: > On 9/17/19 2:41 PM, Alex Bennée wrote: >> +for (i = 0; i < ARRAY_SIZE(round_flags); ++i) { >> +fesetround(round_flags[i].flag); > > If we're going to make this a generic test, perhaps > continue if fesetround fails? I ifdef'ed the missing symbols? Can th

Re: [Qemu-devel] [PATCH v2 2/2] ppc: Add support for 'mffsce' instruction

2019-09-17 Thread Richard Henderson
On 9/16/19 1:02 PM, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > ISA 3.0B added a set of Floating-Point Status and Control Register (FPSCR) > instructions: mffsce, mffscdrn, mffscdrni, mffscrn, mffscrni, mffsl. > This patch adds support for 'mffsce' instruction. > > 'mffsce' is identical t

Re: [Qemu-devel] [PATCH 18/19] qapi: Fix excessive QAPISchemaEntity.check() recursion

2019-09-17 Thread Eric Blake
On 9/14/19 10:35 AM, Markus Armbruster wrote: > Entity checking goes back to commit ac88219a6c "qapi: New QAPISchema > intermediate representation", v2.5.0. It's designed to work as > follows: QAPISchema.check() calls .check() for all the schema's > entities. An entity's .check() recurses into an

Re: [Qemu-devel] [PATCH 15/19] qapi: Clean up around check_known_keys()

2019-09-17 Thread Eric Blake
On 9/14/19 10:35 AM, Markus Armbruster wrote: > All callers pass a dict argument to @keys, except check_keys() passes > a dict's .keys(). Drop .keys() there, and rename parameter @keys to > @value. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/common.py | 8 > 1 file change

Re: [Qemu-devel] [PATCH 17/19] qapi: Fix to .check() empty structs just once

2019-09-17 Thread Eric Blake
On 9/14/19 10:35 AM, Markus Armbruster wrote: > QAPISchemaObjectType.check() does nothing for types that have been > checked already. Except the "has been checked" predicate is broken > for empty types: self.members is [] then, which isn't true. The bug > is harmless, but fix it anyway: use self.

Re: [Qemu-devel] [PATCH 19/19] qapi: Assert .visit() and .check_clash() run only after .check()

2019-09-17 Thread Eric Blake
On 9/14/19 10:35 AM, Markus Armbruster wrote: > Easy since the previous commit provides .checked. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/common.py | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Softwa

Re: [Qemu-devel] [PATCH v2 1/2] ppc: Add support for 'mffscrn', 'mffscrni' instructions

2019-09-17 Thread Richard Henderson
On 9/16/19 1:02 PM, Paul A. Clarke wrote: > +#define FP_DRN2 (1ull << FPSCR_DRN2) > +#define FP_DRN1 (1ull << FPSCR_DRN1) > +#define FP_DRN0 (1ull << FPSCR_DRN0) > +#define FP_DRN (FP_DRN2 | FP_DRN1 | FP_DRN0) Why not just 7ull << FPSCR_DRN? Are the individual DRN

Re: [Qemu-devel] [PATCH 14/19] qapi: Simplify check_keys()

2019-09-17 Thread Eric Blake
On 9/14/19 10:35 AM, Markus Armbruster wrote: > check_keys() parameter expr_elem expects a dictionary with keys 'expr' > and 'info'. Passing the two values separately is simpler, so do that. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/common.py | 19 --- > 1 file c

Re: [Qemu-devel] [PATCH 16/19] qapi: Delete useless check_exprs() code for simple union kind

2019-09-17 Thread Eric Blake
On 9/14/19 10:35 AM, Markus Armbruster wrote: > Commit bceae7697f "qapi script: support enum type as discriminator in > union" made check_exprs() add the implicit enum types of simple unions > to global @enum_types. I'm not sure it was needed even then. It's > certainly not needed now. Delete it

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

2019-09-17 Thread Richard Henderson
On 9/16/19 11:48 AM, Philippe Mathieu-Daudé wrote: > include/hw/rtc/mc146818rtc.h | 38 Same rebase failure as for patch 4? r~

Re: [Qemu-devel] [PATCH v3 29/29] tests/tcg: target/s390x: Test MVO

2019-09-17 Thread Richard Henderson
On 9/16/19 9:58 AM, David Hildenbrand wrote: > Let's add the simple test based on the example from the PoP. > > Signed-off-by: David Hildenbrand > --- > tests/tcg/s390x/Makefile.target | 1 + > tests/tcg/s390x/mvo.c | 25 + > 2 files changed, 26 insertions(+) >

Re: [Qemu-devel] [PATCH v3 19/29] s390x/tcg: MVC: Fault-safe handling on destructive overlaps

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > The last remaining bit for MVC is handling destructive overlaps in a > fault-safe way. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderso

Re: [Qemu-devel] [PATCH v3 18/29] s390x/tcg: MVCS/MVCP: Use access_memmove()

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > As we are moving between address spaces, we can use access_memmove_idx() > without checking for destructive overlaps (especially of real storage > locations): > "Each storage operand is processed left to right. The > storage-operand-consistency

Re: [Qemu-devel] [PATCH v3 17/29] s390x/tcg: Fault-safe memmove

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > Replace fast_memmove() variants by access_memmove() variants, that > first try to probe access to all affected pages (maximum is two pages). > > Introduce access_get_byte()/access_set_byte(). We might be able to speed > up memmove in special cases eve

Re: [Qemu-devel] [PATCH v3 16/29] s390x/tcg: Fault-safe memset

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > Replace fast_memset() by access_memset(), that first tries to probe > access to all affected pages (maximum is two). We'll use the same > mechanism for other types of accesses soon. > > Only in very rare cases (especially TLB_NOTDIRTY), we'll have to

[Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

2019-09-17 Thread Pierre Muller
Hello, I submitted September 12. a bug report about wrong handling of infinity values for m68k emulator. https://bugs.launchpad.net/qemu/+bug/1843651 The analysis I made in the bug report is wrong, because I did not know that m68k FPU really uses 80-bit representations internally. It th

Re: [Qemu-devel] [PATCH v3 12/29] s390x/tcg: MVCS/MVCP: Properly wrap the length

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > ... and don't perform any move in case the length is zero. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 11/29] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > Triggered by a review comment from Richard, also MVCOS has a 32-bit > length in 24/31-bit addressing mode. Add a new helper. > > Rename wrap_length() to wrap_length31(). > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 14 ++

Re: [Qemu-devel] [PATCH v3 09/29] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > Let's stay within single pages. > > ... and indicate cc=3 in case there is work remaining. Keep unicode > padding simple. > > While reworking, properly wrap the addresses. > > Signed-off-by: David Hildenbrand > --- > target/s390x/mem_helper.c | 54

Re: [Qemu-devel] [PATCH v3 04/29] s390x/tcg: MVCL: Process max 4k bytes at a time

2019-09-17 Thread Richard Henderson
On 9/16/19 9:57 AM, David Hildenbrand wrote: > Process max 4k bytes at a time, writing back registers between the > accesses. The instruction is interruptible. > "For operands longer than 2K bytes, access exceptions are not > recognized for locations more than 2K bytes beyond the current lo

Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option

2019-09-17 Thread John Snow
On 9/17/19 3:30 PM, Alex Bennée wrote: > > John Snow writes: > >> On 9/17/19 2:58 PM, Alex Bennée wrote: >>> >>> John Snow writes: >>> It's not used; so remove the distraction. >>> >>> It's a developer feature so you can run specific builds against the VM >>> images. I certainly have us

Re: [Qemu-devel] [PATCH v1 8/9] tests/tcg: add generic version of float_convs

2019-09-17 Thread Richard Henderson
On 9/17/19 2:41 PM, Alex Bennée wrote: > +for (i = 0; i < ARRAY_SIZE(round_flags); ++i) { > +fesetround(round_flags[i].flag); If we're going to make this a generic test, perhaps continue if fesetround fails? r~

Re: [Qemu-devel] [PATCH 2/2] audio: add -audiodev pa, in|out.latency= to documentation

2019-09-17 Thread Zoltán Kővágó
On 2019-09-11 16:58, Stefan Hajnoczi wrote: The "latency" parameter wasn't covered by the documentation. Signed-off-by: Stefan Hajnoczi Reviewed-by: Zoltán Kővágó --- How is this parameter related to buffer-length? Pulseaudio being a client-server architecture is a bit different than the

Re: [Qemu-devel] [PATCH v4 4/4] iotests: use python logging for iotests.log()

2019-09-17 Thread John Snow
On 9/17/19 7:35 AM, Vladimir Sementsov-Ogievskiy wrote: > 12.09.2019 3:16, John Snow wrote: >> We can turn logging on/off globally instead of per-function. >> >> Remove use_log from run_job, and use python logging to turn on >> diffable output when we run through a script entry point. >> >> iote

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

2019-09-17 Thread Richard Henderson
On 9/17/19 2:41 PM, Alex Bennée wrote: > +/* From https://bugs.launchpad.net/qemu/+bug/1841491 */ > +add_f32_const(0x1.cp-1022); > +add_f32_const(0x1.1p-1); > +add_f32_const(0x0.1p-1022); These three constants do not fit in float32. > +add_f

Re: [Qemu-devel] [PATCH v1 2/9] tests/docker: fix DOCKER_PARTIAL_IMAGES

2019-09-17 Thread Philippe Mathieu-Daudé
On 9/17/19 8:41 PM, Alex Bennée wrote: > Finger trouble in a previous clean-up inadvertently set > DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES. Arf :) > Fixes: 44d5a8bf5d2 > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe

2019-09-17 Thread Philippe Mathieu-Daudé
On 9/17/19 8:55 PM, John Snow wrote: > We spelled it debian-9-mxe, but the image is debian9-mxe. Oops I missed that, good catch. Fixes: 44d5a8bf5d2 Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: John Snow > --- > tests/docker/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option

2019-09-17 Thread Alex Bennée
John Snow writes: > On 9/17/19 2:58 PM, Alex Bennée wrote: >> >> John Snow writes: >> >>> It's not used; so remove the distraction. >> >> It's a developer feature so you can run specific builds against the VM >> images. I certainly have used it, unless you are saying it's broken now? >> > > Wh

Re: [Qemu-devel] [PATCH 1/2] audio: fix buffer-length typo in documentation

2019-09-17 Thread Zoltán Kővágó
On 2019-09-11 16:58, Stefan Hajnoczi wrote: Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bbfd936d29.

Re: [Qemu-devel] [PATCH v5] target-arm: Make the counter tick relative to cntfrq

2019-09-17 Thread Richard Henderson
On 9/17/19 12:14 PM, Peter Maydell wrote: >> +static Property arm_cpu_gt_cntfrq_property = >> +DEFINE_PROP_UINT64("cntfrq", ARMCPU, gt_cntfrq, >> + (1000 * 1000 * 1000) / GTIMER_SCALE); > I think it would be helpful to have a comment saynig what units > thi

[Qemu-devel] [PATCH] vhost-user: save features if the char dev is closed

2019-09-17 Thread Adrian Moreno
That way the state can be correctly restored when the device is opened again. This might happen if the backend is restarted. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1738768 Reported-by: Pei Zhang Fixes: 6ab79a20af3a (do not call vhost_net_cleanup() on running net from char user even

Re: [Qemu-devel] ELF load command alignment not page-aligned

2019-09-17 Thread Richard Henderson
On 9/17/19 7:40 AM, Peter Maydell wrote: > On Tue, 17 Sep 2019 at 11:49, Philippe Mathieu-Daudé > wrote: >> >> Cc'ing PPC folks and Laurent. >> >> On 9/16/19 11:06 PM, Niccolò Belli wrote: >>> Hi, >>> I'm trying to use qemu-user-static to chroot into a foreign amd64 >>> environment from my ppc64l

Re: [Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

2019-09-17 Thread John Snow
On 9/17/19 10:46 AM, Kevin Wolf wrote: > Am 17.09.2019 um 16:39 hat Eric Blake geschrieben: >> On 9/17/19 5:20 AM, Greg Kurz wrote: >>> Ensure that hints are added even if errp is &error_fatal or &error_abort. >>> >>> Signed-off-by: Greg Kurz >>> --- >>> block/backup.c |7 +-- >>>

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122644.15736-1-johan...@sipsolutions.net/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes

2019-09-17 Thread Alex Bennée
Pavel Dovgalyuk writes: > The set of patches include the block-related updates > of the record/replay icount feature: > - application of 'snapshot' option on the file layer instead of >the top one: command line and documentation fix > - implementation of bdrv_snapshot_goto for blkreplay d

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122644.15736-1-johan...@sipsolutions.net/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/ba

Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option

2019-09-17 Thread John Snow
On 9/17/19 2:58 PM, Alex Bennée wrote: > > John Snow writes: > >> It's not used; so remove the distraction. > > It's a developer feature so you can run specific builds against the VM > images. I certainly have used it, unless you are saying it's broken now? > What consumes it? I can't find

[Qemu-devel] [PATCH] tests/vm: remove unused --target-list option

2019-09-17 Thread John Snow
It's not used; so remove the distraction. Signed-off-by: John Snow --- tests/vm/Makefile.include | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include index fea348e845..61758101fa 100644 --- a/tests/vm/Makefile.include +++ b/tests/vm/Makefile.

[Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe

2019-09-17 Thread John Snow
We spelled it debian-9-mxe, but the image is debian9-mxe. Signed-off-by: John Snow --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 50a400b573..7eac1516f6 100644 --- a/tests/d

Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option

2019-09-17 Thread Alex Bennée
John Snow writes: > It's not used; so remove the distraction. It's a developer feature so you can run specific builds against the VM images. I certainly have used it, unless you are saying it's broken now? > > Signed-off-by: John Snow > --- > tests/vm/Makefile.include | 2 -- > 1 file chang

Re: [Qemu-devel] [PATCH v1 1/9] tests/docker: add sanitizers back to clang build

2019-09-17 Thread John Snow
On 9/17/19 2:41 PM, Alex Bennée wrote: > From: John Snow > > Fedora23 is but a distant twinkle. > The sanitizer works again, and even if not, > we have --enable-sanitizers now. > > Signed-off-by: John Snow > Message-Id: <20190912014442.5757-1-js...@redhat.com> > Signed-off-by: Alex Bennée H

Re: [Qemu-devel] [RFC] contrib: add vhost-user-sim

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190917122644.15736-1-johan...@sipsolutions.net/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC] contrib: add vhost-user-sim Message-id: 20190917122644.15736-1-johan...@sipsolut

[Qemu-devel] [PATCH v1 1/9] tests/docker: add sanitizers back to clang build

2019-09-17 Thread Alex Bennée
From: John Snow Fedora23 is but a distant twinkle. The sanitizer works again, and even if not, we have --enable-sanitizers now. Signed-off-by: John Snow Message-Id: <20190912014442.5757-1-js...@redhat.com> Signed-off-by: Alex Bennée --- tests/docker/test-clang | 6 +- 1 file changed, 1 in

[Qemu-devel] [PATCH v1 8/9] tests/tcg: add generic version of float_convs

2019-09-17 Thread Alex Bennée
This is broadly similar to the existing fcvt test for ARM but using the generic float testing framework. We should be able to pare down the ARM fcvt test case to purely half-precision with or without the Alt HP provision. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/float_convs.ref | 748 +

[Qemu-devel] [PATCH v1 6/9] tests/tcg: re-enable linux-test for ppc64abi32

2019-09-17 Thread Alex Bennée
Now we have fixed the signal delivary bug we can remove this horrible hack from the system. Cc: Richard Henderson Signed-off-by: Alex Bennée --- tests/tcg/configure.sh | 1 + tests/tcg/multiarch/Makefile.target | 11 +++ 2 files changed, 4 insertions(+), 8 deletions(-) di

[Qemu-devel] [PATCH v1 3/9] podman: fix command invocation

2019-09-17 Thread Alex Bennée
From: John Snow Oops; there's no argv here. Signed-off-by: John Snow Message-Id: <20190913193821.17756-1-js...@redhat.com> --- tests/docker/docker.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 29613afd489..bc7a470ca

[Qemu-devel] [PATCH v1 4/9] target/ppc: fix signal delivery for ppc64abi32

2019-09-17 Thread Alex Bennée
We were incorrectly using the 64-bit AIX ABI instead of the 32-bit SYSV ABI for setting NIP for the signal handler. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - change to wording --- linux-user/ppc/signal.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v1 5/9] tests/tcg: clean-up some comments after the de-tangling

2019-09-17 Thread Alex Bennée
These were missed in the recent de-tangling so have been updated to be more actuate. I've also built up ARM_TESTS in a manner similar to AARCH64_TESTS for better consistency. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell --- tests/tcg/Makefile.target | 7 +-- tests/tcg/aarc

[Qemu-devel] [PATCH v1 0/9] testing/next (docker,podman,float)

2019-09-17 Thread Alex Bennée
Hi, This is the current status of the testing/next queue. It contains a number of fixes for docker and podman as well as some additional tests for floating point under TCG I've been experimenting with. Although we have reasonable confidence in large chunks of the core softfloat code thanks to che

[Qemu-devel] [PATCH v1 2/9] tests/docker: fix DOCKER_PARTIAL_IMAGES

2019-09-17 Thread Alex Bennée
Finger trouble in a previous clean-up inadvertently set DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES. Fixes: 44d5a8bf5d2 Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/test

Re: [Qemu-devel] [PATCH 13/19] qapi: Normalize 'if' in check_exprs(), like other sugar

2019-09-17 Thread Eric Blake
On 9/14/19 10:35 AM, Markus Armbruster wrote: > We normalize shorthand to longhand forms in check_expr(): enumeration > values with normalize_enum(), feature values with > normalize_features(), struct members, union branches and alternate > branches with normalize_members(). If conditions are an e

Re: [Qemu-devel] [PATCH 12/19] qapi: Fix missing 'if' checks in struct, union, alternate 'data'

2019-09-17 Thread Eric Blake
On 9/14/19 10:34 AM, Markus Armbruster wrote: > Commit 87adbbffd4..3e270dcacc "qapi: Add 'if' to (implicit > struct|union|alternate) members" (v4.0.0) neglected test coverage, and > promptly failed to check the conditions. Review fail. > > Recent commit "tests/qapi-schema: Demonstrate insufficien

Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes

2019-09-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/156872146565.1757.3033215873677512474.stgit@pasha-Precision-3630-Tower/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally

  1   2   3   4   >