Re: [PATCH v3 4/4] qom/object: Use common get/set uint helpers

2019-11-29 Thread Marc-André Lureau
On Fri, Nov 29, 2019 at 9:46 PM Felipe Franciosi wrote: > > Several objects implemented their own uint property getters and setters, > despite them being straightforward (without any checks/validations on > the values themselves) and identical across objects. This makes use of > an enhanced API

Re: [PATCH v3 3/4] ich9: Simplify ich9_lpc_initfn

2019-11-29 Thread Marc-André Lureau
On Fri, Nov 29, 2019 at 9:46 PM Felipe Franciosi wrote: > > Currently, ich9_lpc_initfn simply serves as a caller to > ich9_lpc_add_properties. This simplifies the code a bit by eliminating > ich9_lpc_add_properties altogether and executing its logic in the parent > object initialiser function. >

Re: [PATCH v3 2/4] ich9: fix getter type for sci_int property

2019-11-29 Thread Marc-André Lureau
On Fri, Nov 29, 2019 at 9:46 PM Felipe Franciosi wrote: > > When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was > written using uint32_t. However, the object property is uint8_t. This > fixes the getter for correctness. > > Signed-off-by: Felipe Franciosi Reviewed-by:

Re: [PATCH v3 1/4] qom/object: enable setter for uint types

2019-11-29 Thread Marc-André Lureau
Hi On Fri, Nov 29, 2019 at 9:46 PM Felipe Franciosi wrote: > > Traditionally, the uint-specific property helpers only offer getters. > When adding object (or class) uint types, one must therefore use the > generic property helper if a setter is needed (and probably duplicate > some code writing

Re: [Qemu-devel] [PATCH v5 0/2] arm/acpi: simplify aml code and enable SHPC

2019-11-29 Thread Guoheyi
Hi Peter, Igor, I couldn't find these 2 patches in the latest tree. Could you help to merge them? Thanks, HG On 2019/3/13 0:09, Igor Mammedov wrote: On Sat, 9 Mar 2019 10:30:47 +0800 Heyi Guo wrote: After the introduction of generic PCIe root port and PCIe-PCI bridge, we will also have

Re: [PATCH for-5.0 0/8] docs: integrate doc comments with Sphinx build

2019-11-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191129140217.17797-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for-5.0 0/8] docs: integrate doc comments with Sphinx build Type: series Message-id:

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-11-29 Thread Aleksandar Markovic
On Friday, November 29, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Thursday, November 28, 2019, Alex Bennée > wrote: > >> >> Aleksandar Markovic writes: >> >> > On Thursday, November 28, 2019, Michael Rolnik >> wrote: >> > >> >> I don't see why you say that the

Re: libcap vs libcap-ng mess

2019-11-29 Thread Paolo Bonzini
Il ven 29 nov 2019, 19:54 Dr. David Alan Gilbert ha scritto: > > Yes, it's per thread. The state can be built from > > capng_clear/capng_get_caps_process + capng_update, and left in there > > forever. There is also capng_save_state/capng_restore_state which, as > > far as I can see from the

Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

2019-11-29 Thread Aleksandar Markovic
On Thursday, November 28, 2019, Alex Bennée wrote: > > Aleksandar Markovic writes: > > > On Thursday, November 28, 2019, Michael Rolnik > wrote: > > > >> I don't see why you say that the peripherals are inside the chip, there > is > >> CPU within target/avr directory and then there are some

[PATCH v6 19/21] fuzz: add virtio-net fuzz target

2019-11-29 Thread Oleinik, Alexander
The virtio-net fuzz target feeds inputs to all three virtio-net virtqueues, and uses forking to avoid leaking state between fuzz runs. Signed-off-by: Alexander Bulekov --- tests/fuzz/Makefile.include | 1 + tests/fuzz/virtio_net_fuzz.c | 105 +++ 2 files

[PATCH v6 21/21] fuzz: add documentation to docs/devel/

2019-11-29 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- docs/devel/fuzzing.txt | 119 + 1 file changed, 119 insertions(+) create mode 100644 docs/devel/fuzzing.txt diff --git a/docs/devel/fuzzing.txt b/docs/devel/fuzzing.txt new file mode 100644 index

[PATCH v6 20/21] fuzz: add virtio-scsi fuzz target

2019-11-29 Thread Oleinik, Alexander
The virtio-scsi fuzz target sets up and fuzzes the available virtio-scsi queues. After an element is placed on a queue, the fuzzer can select whether to perform a kick, or continue adding elements. Signed-off-by: Alexander Bulekov --- tests/fuzz/Makefile.include | 1 +

[PATCH v6 12/21] libqtest: add in-process qtest.c tx/rx handlers

2019-11-29 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- tests/libqtest.c | 54 tests/libqtest.h | 3 ++- 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index a7df92319a..e0bc5bbe0b 100644 --- a/tests/libqtest.c

[PATCH v6 17/21] fuzz: add support for qos-assisted fuzz targets

2019-11-29 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov --- tests/fuzz/qos_fuzz.c | 232 ++ tests/fuzz/qos_fuzz.h | 33 ++ 2 files changed, 265 insertions(+) create mode 100644 tests/fuzz/qos_fuzz.c create mode 100644 tests/fuzz/qos_fuzz.h diff --git

[PATCH v6 11/21] libqtest: make bufwrite rely on the TransportOps

2019-11-29 Thread Oleinik, Alexander
When using qtest "in-process" communication, qtest_sendf directly calls a function in the server (qtest.c). Previously, bufwrite used socket_send, which bypasses the TransportOps enabling the call into qtest.c. This change replaces the socket_send calls with ops->send, maintaining the benefits of

[PATCH v6 13/21] fuzz: add configure flag --enable-fuzzing

2019-11-29 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- configure | 39 +++ 1 file changed, 39 insertions(+) diff --git a/configure b/configure index 6099be1d84..5fb2494a8e 100755 --- a/configure +++ b/configure @@ -504,6 +504,7 @@ debug_mutex="no"

[PATCH v6 08/21] tests: provide test variables to other targets

2019-11-29 Thread Oleinik, Alexander
Before, when tests/Makefile.include was included, the contents would be ignored if config-host.mak was defined. Moving the ifneq responsible for this allows a target to depend on both testing-related and host-related objects. For example the virtual-device fuzzer relies on both libqtest/libqos

[PATCH v6 05/21] libqtest: Add a layer of abstraciton to send/recv

2019-11-29 Thread Oleinik, Alexander
This makes it simple to swap the transport functions for qtest commands to and from the qtest client. For example, now it is possible to directly pass qtest commands to a server handler that exists within the same process, without the standard way of writing to a file descriptor. Signed-off-by:

[PATCH v6 15/21] fuzz: add fuzzer skeleton

2019-11-29 Thread Oleinik, Alexander
tests/fuzz/fuzz.c serves as the entry point for the virtual-device fuzzer. Namely, libfuzzer invokes the LLVMFuzzerInitialize and LLVMFuzzerTestOneInput functions, both of which are defined in this file. This change adds a "FuzzTarget" struct, along with the fuzz_add_target function, which should

[PATCH v6 16/21] fuzz: add support for fork-based fuzzing.

2019-11-29 Thread Oleinik, Alexander
fork() is a simple way to ensure that state does not leak in between fuzzing runs. Unfortunately, the fuzzer mutation engine relies on bitmaps which contain coverage information for each fuzzing run, and these bitmaps should be copied from the child to the parent(where the mutation occurs). These

[PATCH v6 07/21] qtest: add in-process incoming command handler

2019-11-29 Thread Oleinik, Alexander
The handler allows a qtest client to send commands to the server by directly calling a function, rather than using a file/CharBackend Signed-off-by: Alexander Bulekov --- include/sysemu/qtest.h | 1 + qtest.c| 13 + 2 files changed, 14 insertions(+) diff --git

[PATCH v6 14/21] fuzz: Add target/fuzz makefile rules

2019-11-29 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny --- Makefile| 15 ++- Makefile.objs | 4 +++- Makefile.target | 18 +- tests/fuzz/Makefile.include | 4 4 files changed, 38 insertions(+), 3 deletions(-)

[PATCH v6 04/21] qtest: add qtest_server_send abstraction

2019-11-29 Thread Oleinik, Alexander
qtest_server_send is a function pointer specifying the handler used to transmit data to the qtest client. In the standard configuration, this calls the CharBackend handler, but now it is possible for other types of handlers, e.g direct-function calls if the qtest client and server exist within the

[PATCH v6 18/21] fuzz: add i440fx fuzz targets

2019-11-29 Thread Oleinik, Alexander
These three targets should simply fuzz reads/writes to a couple ioports, but they mostly serve as examples of different ways to write targets. They demonstrate using qtest and qos for fuzzing, as well as using rebooting and forking to reset state, or not resetting it at all. Signed-off-by:

[PATCH v6 02/21] libqos: Rename i2c_send and i2c_recv

2019-11-29 Thread Oleinik, Alexander
The names i2c_send and i2c_recv collide with functions defined in hw/i2c/core.c. This causes an error when linking against libqos and softmmu simultaneously (for example when using qtest inproc). Rename the libqos functions to avoid this. Signed-off-by: Alexander Bulekov --- tests/libqos/i2c.c

[PATCH v6 03/21] fuzz: Add FUZZ_TARGET module type

2019-11-29 Thread Oleinik, Alexander
Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- include/qemu/module.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qemu/module.h b/include/qemu/module.h index 65ba596e46..684753d808 100644 --- a/include/qemu/module.h +++

[PATCH v6 10/21] libqos: move useful qos-test funcs to qos_external

2019-11-29 Thread Oleinik, Alexander
The moved functions are not specific to qos-test and might be useful elsewhere. For example the virtual-device fuzzer makes use of them for qos-assisted fuzz-targets. Signed-off-by: Alexander Bulekov Reviewed-by: Stefan Hajnoczi --- tests/Makefile.include | 1 +

[PATCH v6 09/21] libqos: split qos-test and libqos makefile vars

2019-11-29 Thread Oleinik, Alexander
Most qos-related objects were specified in the qos-test-obj-y variable. qos-test-obj-y also included qos-test.o which defines a main(). This made it difficult to repurpose qos-test-obj-y to link anything beside tests/qos-test against libqos. This change separates objects that are libqos-specific

[PATCH v6 00/21] Add virtual device fuzzing support

2019-11-29 Thread Oleinik, Alexander
This series adds a framework for coverage-guided fuzzing of virtual-devices. Fuzzing targets are based on qtest and can make use of the libqos abstractions. In this version, I added a virtio-scsi fuzzer. The actual fuzzing code is very similar to the the virtio-net fuzzer. I experimented with

[PATCH v6 01/21] softmmu: split off vl.c:main() into main.c

2019-11-29 Thread Oleinik, Alexander
A program might rely on functions implemented in vl.c, but implement its own main(). By placing main into a separate source file, there are no complaints about duplicate main()s when linking against vl.o. For example, the virtual-device fuzzer uses a main() provided by libfuzzer, and needs to

[PATCH v6 06/21] module: check module wasn't already initialized

2019-11-29 Thread Oleinik, Alexander
The virtual-device fuzzer must initialize QOM, prior to running vl:qemu_init, so that it can use the qos_graph to identify the arguments required to initialize a guest for libqos-assisted fuzzing. This change prevents errors when vl:qemu_init tries to (re)initialize the previously initialized QOM

Re: [PATCH 2/2] Add -mem-shared option

2019-11-29 Thread Eduardo Habkost
On Fri, Nov 29, 2019 at 01:01:54PM +0100, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 29/11/19 11:07, Igor Mammedov wrote: > So user who wants something non trivial could override default > non-numa behavior with > -object

Re: [PATCH 0/2] RFC: add -mem-shared option

2019-11-29 Thread Eduardo Habkost
On Fri, Nov 29, 2019 at 10:31:36AM +0100, Paolo Bonzini wrote: > On 28/11/19 17:10, Eduardo Habkost wrote: > > On Thu, Nov 28, 2019 at 06:15:16PM +0400, Marc-André Lureau wrote: > >> Hi, > >> > >> Setting up shared memory for vhost-user is a bit complicated from > >> command line, as it requires

Re: qom device lifecycle interaction with hotplug/hotunplug ?

2019-11-29 Thread Eduardo Habkost
On Fri, Nov 29, 2019 at 12:45:09PM +, Peter Maydell wrote: > On Fri, 29 Nov 2019 at 12:26, Igor Mammedov wrote: > > But from the my very limited understanding, on real hardware, > > once device is uplugged it's gone (finalized) from machine > > perspective, so it's unclear to my why someone

Re: [PATCH v6] hw/core/loader-fit: fix freeing errp in fit_load_fdt

2019-11-29 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 29.11.2019 18:23, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 29.11.2019 17:11, Vladimir Sementsov-Ogievskiy wrote: 29.11.2019 17:03, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >>

Re: qom device lifecycle interaction with hotplug/hotunplug ?

2019-11-29 Thread Eduardo Habkost
On Fri, Nov 29, 2019 at 01:40:55PM +0100, Igor Mammedov wrote: > On Thu, 28 Nov 2019 13:33:58 -0300 > Eduardo Habkost wrote: > > > On Thu, Nov 28, 2019 at 04:00:06PM +, Peter Maydell wrote: > > > Hi; this is a question which came up in Damien's reset series > > > which I don't know the

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-29 Thread Eduardo Habkost
On Tue, Nov 26, 2019 at 03:07:32PM +0100, David Hildenbrand wrote: > On 26.11.19 13:59, Christian Borntraeger wrote: > > re-adding ccs from the cover-letter > > > On 25.11.19 18:20, David Hildenbrand wrote: > > As soon as dynamic feature groups are used, the CPU model becomes >

Re: [PATCH v5 00/13] Multi-phase reset mechanism

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Hi all, > > The purpose of this series is to split the current reset procedure > into multiple phases. This will help to solve some ordering > difficulties we have during reset. Previous version can be found here: >

Re: [PATCH v5 11/13] hw/s390x/ipl: replace deprecated qdev_reset_all registration

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Replace deprecated qdev_reset_all by resettable_cold_reset_fn for > the ipl registration in the main reset handlers. > > This does not impact the behavior for the following reasons: > + at this point resettable just call the old reset methods

Re: [PATCH v5 13/13] hw/gpio/bcm2835_gpio: Update to resettable

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Transition the bcm2835_gpio device class to Resettable. > The sdbus reparenting is delayed in hold phase to respect > resettable side-effect rules. > > Signed-off-by: Damien Hedde Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 12/13] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Split gpfsel_set() in 2 so that the sdbus reparenting is done > in a dedicated function. > > Signed-off-by: Damien Hedde > --- > Cc: Peter Maydell > Cc: Andrew Baumann > Cc: Philippe Mathieu-Daudé > Cc: qemu-...@nongnu.org > --- >

Re: [PATCH v5 09/13] docs/devel/reset.txt: add doc about Resettable interface

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Signed-off-by: Damien Hedde Subject line still says ".txt". > --- > > Should I add an entry into index.rst ? Yes, please. I have one substantive comment on this patch: in the MyDev example of implementing reset, you make the

Re: [PATCH v5 10/13] vl: replace deprecated qbus_reset_all registration

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Replace deprecated qbus_reset_all by resettable_cold_reset_fn for > the sysbus reset registration. > > Apart for the raspi machines, this does not impact the behavior > because: > + at this point resettable just call the old reset methods of

Re: libcap vs libcap-ng mess

2019-11-29 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 29/11/19 19:20, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > >> On 29/11/19 19:01, Dr. David Alan Gilbert wrote: > It's not entirely trivial because fsdev-proxy-helper wants to keep the > effective set

Re: [RFC 0/1] ATI R300 emulated grpahics card V2

2019-11-29 Thread BALATON Zoltan
On Thu, 28 Nov 2019, Gerd Hoffmann wrote: The infrastructure to branch into model-specific code is pretty rough right now, we might refine that, for example with some helper functions (ati_get_model() returning an enum, or ati_is_$model() functions returning bool, or both). Maybe we could

Re: [PATCH v5 08/13] hw/core: deprecate old reset functions and introduce new ones

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Deprecate device_legacy_reset(), qdev_reset_all() and > qbus_reset_all() to be replaced by new functions > device_cold_reset() and bus_cold_reset() which uses resettable API. > > Also introduce resettable_cold_reset_fn() which may be used as a

Re: [PATCH v5 06/13] hw/core/qdev: handle parent bus change regarding resettable

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > In qdev_set_parent_bus(), when changing the parent bus of a > realized device, if the source and destination buses are not in the > same reset state, some adaptation are required. This patch adds "adaptations" > needed call to

Re: [PATCH v5 05/13] hw/core/resettable: add support for changing parent

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > Add a function resettable_change_parent() to do the required > plumbing when changing the parent a of Resettable object. > > We need to make sure that the reset state of the object remains > coherent with the reset state of the new parent. > >

Re: [PATCH v5 04/13] hw/core: add Resettable support to BusClass and DeviceClass

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > This commit adds support of Resettable interface to buses and devices: > + ResettableState structure is added in the Bus/Device state > + Resettable methods are implemented. > + device/bus_is_in_reset function defined > > This commit allows to

Re: [PATCH v5 03/13] hw/core: create Resettable QOM interface

2019-11-29 Thread Peter Maydell
On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: > > This commit defines an interface allowing multi-phase reset. This aims > to solve a problem of the actual single-phase reset (built in > DeviceClass and BusClass): reset behavior is dependent on the order > in which reset handlers are called.

Re: libcap vs libcap-ng mess

2019-11-29 Thread Paolo Bonzini
On 29/11/19 19:20, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> On 29/11/19 19:01, Dr. David Alan Gilbert wrote: It's not entirely trivial because fsdev-proxy-helper wants to keep the effective set and clear the permitted set; in libcap-ng you can only

Re: libcap vs libcap-ng mess

2019-11-29 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 29/11/19 19:01, Dr. David Alan Gilbert wrote: > >> It's not entirely trivial because fsdev-proxy-helper wants to keep the > >> effective set and clear the permitted set; in libcap-ng you can only > ^ > > (Wrong, this is

Re: libcap vs libcap-ng mess

2019-11-29 Thread Paolo Bonzini
On 29/11/19 19:01, Dr. David Alan Gilbert wrote: >> It's not entirely trivial because fsdev-proxy-helper wants to keep the >> effective set and clear the permitted set; in libcap-ng you can only ^ (Wrong, this is "modify" the permitted set. The permitted set is already

RE: Network connection with COLO VM

2019-11-29 Thread Zhang, Chen
From: Daniel Cho Sent: Friday, November 29, 2019 10:43 AM To: Zhang, Chen Cc: Dr. David Alan Gilbert ; lukasstra...@web.de; qemu-devel@nongnu.org Subject: Re: Network connection with COLO VM Hi David, Zhang, Thanks for replying my question. We know why will occur this issue. As you said,

Re: [RFC 00/10] R300 QEMU device V2

2019-11-29 Thread BALATON Zoltan
Hello, On Thu, 28 Nov 2019, Aaron Zakhrov wrote: I tested my code with the vgabios-ati.bin rom file and it seems to get passed the earlier issue I had. Good, so then the BIOS problem seems to be sorted for now. (Maybe it needed the tables or EDID support that some drivers use from the VGA

[PATCH v3 3/4] ich9: Simplify ich9_lpc_initfn

2019-11-29 Thread Felipe Franciosi
Currently, ich9_lpc_initfn simply serves as a caller to ich9_lpc_add_properties. This simplifies the code a bit by eliminating ich9_lpc_add_properties altogether and executing its logic in the parent object initialiser function. Signed-off-by: Felipe Franciosi --- hw/isa/lpc_ich9.c | 15

Re: libcap vs libcap-ng mess

2019-11-29 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 29/11/19 10:34, Daniel P. Berrangé wrote: > >> y) Should we flip over to only using one or the other - what > >> are the advantages? > > In libvirt we use libcap-ng. We picked this originally as its API > > design allows you do write simpler

[PATCH v3 1/4] qom/object: enable setter for uint types

2019-11-29 Thread Felipe Franciosi
Traditionally, the uint-specific property helpers only offer getters. When adding object (or class) uint types, one must therefore use the generic property helper if a setter is needed (and probably duplicate some code writing their own getters/setters). This enhances the uint-specific property

[PATCH v3 0/4] Improve default object property_add uint helpers

2019-11-29 Thread Felipe Franciosi
This improves the family of object_property_add_uintXX_ptr helpers by enabling a default getter/setter only when desired. To prevent an API behavioural change (from clients that already used these helpers and did not want a setter), we add a OBJ_PROP_FLAG_READ flag that allow clients to only have

[PATCH v3 2/4] ich9: fix getter type for sci_int property

2019-11-29 Thread Felipe Franciosi
When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was written using uint32_t. However, the object property is uint8_t. This fixes the getter for correctness. Signed-off-by: Felipe Franciosi --- hw/isa/lpc_ich9.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH v3 4/4] qom/object: Use common get/set uint helpers

2019-11-29 Thread Felipe Franciosi
Several objects implemented their own uint property getters and setters, despite them being straightforward (without any checks/validations on the values themselves) and identical across objects. This makes use of an enhanced API for object_property_add_uintXX_ptr() which offers default setters.

Re: [PATCH 2/2] Add -mem-shared option

2019-11-29 Thread Paolo Bonzini
On 29/11/19 13:16, Igor Mammedov wrote: > As for "-m", I'd make it just an alias that translates > -m/mem-path/mem-prealloc I think we should just deprecate -mem-path/-mem-prealloc in 5.0. CCing Thomas as mister deprecation. :) > combination to appropriate '-object' for '-machine memdev'

[PATCH v2] configure: Use lld --image-base for --disable-pie user mode binaries

2019-11-29 Thread Fangrui Song
On 2019-11-27, Alex Bennée wrote: Fangrui Song writes: For lld, --image-base is the preferred way to set the base address. lld does not actually implement -Ttext-segment, but treats it as an alias for -Ttext. -Ttext-segment=0x6000 combined with --no-rosegment can create a 1.6GB

Re: [PATCH for 4.2?] .travis.yml: drop xcode9.4 from build matrix

2019-11-29 Thread Peter Maydell
On Fri, 29 Nov 2019 at 13:52, Thomas Huth wrote: > > On 27/11/2019 14.24, Alex Bennée wrote: > > It's broken so it's no longer helping. The latest Xcode is covered by > > Cirrus. > > > > Signed-off-by: Alex Bennée > > --- > > .travis.yml | 8 +--- > > 1 file changed, 1 insertion(+), 7

Re: [PATCH v2 1/4] qom/object: enable setter for uint types

2019-11-29 Thread Felipe Franciosi
> On Nov 29, 2019, at 3:35 PM, Marc-André Lureau > wrote: > > Hi > > On Fri, Nov 29, 2019 at 7:14 PM Felipe Franciosi wrote: >> >> Heya, >> >>> On Nov 28, 2019, at 8:35 PM, Marc-André Lureau >>> wrote: >>> >>> Hi >>> >>> On Thu, Nov 28, 2019 at 8:48 PM Felipe Franciosi wrote:

RE: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mode.

2019-11-29 Thread Wasim, Bilal
Thanks for the pointers philippe.. Is the patch okay to be merged without it or do I need to do a re-submission with the updated username ? - Bilal -Original Message- From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] Sent: Friday, November 29, 2019 8:38 PM To:

Re: [PATCH v2 1/4] qom/object: enable setter for uint types

2019-11-29 Thread Marc-André Lureau
Hi On Fri, Nov 29, 2019 at 8:25 PM Felipe Franciosi wrote: > > > > > On Nov 29, 2019, at 3:35 PM, Marc-André Lureau > > wrote: > > > > Hi > > > > On Fri, Nov 29, 2019 at 7:14 PM Felipe Franciosi wrote: > >> > >> Heya, > >> > >>> On Nov 28, 2019, at 8:35 PM, Marc-André Lureau > >>> wrote: >

Re: [PATCH v6] hw/core/loader-fit: fix freeing errp in fit_load_fdt

2019-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2019 18:23, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 29.11.2019 17:11, Vladimir Sementsov-Ogievskiy wrote: >>> 29.11.2019 17:03, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > fit_load_fdt forget to check that errp is not NULL and

[PATCH] docker: remove libcap development packages

2019-11-29 Thread Paolo Bonzini
Libcap was dropped from virtio-9p, so remove it from the dockerfiles as well. Signed-off-by: Paolo Bonzini --- tests/docker/dockerfiles/fedora.docker | 1 - tests/docker/dockerfiles/ubuntu.docker | 1 - tests/docker/dockerfiles/ubuntu1804.docker | 1 - 3 files changed, 3 deletions(-)

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

2019-11-29 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 29.11.2019 17:35, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 28.11.2019 23:29, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > 28.11.2019 17:23, Markus Armbruster wrote: >> Vladimir

Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mode.

2019-11-29 Thread Philippe Mathieu-Daudé
On Fri, Nov 29, 2019 at 4:59 PM Wasim, Bilal wrote: > > Thanks for the pointers philippe.. Is the patch okay to be merged without it > or do I need to do a re-submission with the updated username ? If there are no review comments on your patch, I think the maintainer taking your patch can fix

Re: [PATCH] virtfs-proxy-helper: switch from libcap to libcap-ng

2019-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 12:16:32PM +0100, Paolo Bonzini wrote: > virtfs-proxy-helper is the only user of libcap; everyone else is using > the simpler libcap-ng API. Switch and remove the configure code to > detect libcap. > > Signed-off-by: Paolo Bonzini > --- > configure |

Re: [PATCH] ci: Use libcap-ng

2019-11-29 Thread Philippe Mathieu-Daudé
On 11/29/19 3:21 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using It is not obvious you are referring to "virtfs-proxy-helper:

Re: [PATCH] ci: Use libcap-ng

2019-11-29 Thread Philippe Mathieu-Daudé
On 11/29/19 3:21 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using It is not obvious you are referring to "virtfs-proxy-helper:

Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops

2019-11-29 Thread Max Reitz
On 29.11.19 15:26, Vladimir Sementsov-Ogievskiy wrote: > 29.11.2019 17:17, Max Reitz wrote: >> On 29.11.19 14:55, Vladimir Sementsov-Ogievskiy wrote: >>> 29.11.2019 16:46, Max Reitz wrote: On 29.11.19 13:01, Vladimir Sementsov-Ogievskiy wrote: > 11.11.2019 19:02, Max Reitz wrote: >>

Re: [PULL 0/2] Fix for the s390-ccw bios

2019-11-29 Thread Peter Maydell
On Fri, 29 Nov 2019 at 10:08, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit 1a61a081ac33ae6cb7dd2e38d119a572f416c7f7: > > Update version for v4.2.0-rc3 release (2019-11-26 21:52:26 +) > > are available in the Git repository at: > >

Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mode.

2019-11-29 Thread Philippe Mathieu-Daudé
Hi Bilal, Cc'ing Jason, the maintainer of network devices. On 11/29/19 4:05 PM, bilalwasim...@gmail.com wrote: From: bwasim Your git setup misses your 'user.name', you could fix it running: git config user.name "Bilal Wasim" (eventually with the --global option). The patch looks good

Re: [PATCH 3/3] s390x: protvirt: Add new VCPU reset functions

2019-11-29 Thread David Hildenbrand
On 29.11.19 15:34, Janosch Frank wrote: > On 11/29/19 3:24 PM, David Hildenbrand wrote: >> On 29.11.19 15:20, Janosch Frank wrote: >>> CPU resets for protected guests need to be done via Ultravisor >>> calls. Hence we need a way to issue these calls for each reset. >>> >>> As we formerly had only

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

2019-11-29 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 28.11.2019 23:29, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 28.11.2019 17:23, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Error **errp is almost always OUT-argument: it's assumed to be NULL,

Re: [PATCH v2 1/4] qom/object: enable setter for uint types

2019-11-29 Thread Marc-André Lureau
Hi On Fri, Nov 29, 2019 at 7:14 PM Felipe Franciosi wrote: > > Heya, > > > On Nov 28, 2019, at 8:35 PM, Marc-André Lureau > > wrote: > > > > Hi > > > > On Thu, Nov 28, 2019 at 8:48 PM Felipe Franciosi wrote: > >> > >> Traditionally, the uint-specific property helpers only offer getters. > >>

Re: [PATCH 3/3] s390x: protvirt: Add new VCPU reset functions

2019-11-29 Thread Janosch Frank
On 11/29/19 3:24 PM, David Hildenbrand wrote: > On 29.11.19 15:20, Janosch Frank wrote: >> CPU resets for protected guests need to be done via Ultravisor >> calls. Hence we need a way to issue these calls for each reset. >> >> As we formerly had only one reset function and it was called for >>

Re: [PATCH v6] hw/core/loader-fit: fix freeing errp in fit_load_fdt

2019-11-29 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 29.11.2019 17:11, Vladimir Sementsov-Ogievskiy wrote: >> 29.11.2019 17:03, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> fit_load_fdt forget to check that errp is not NULL and to zero it after freeing. Fix it.

Re: [PATCH v2 1/4] qom/object: enable setter for uint types

2019-11-29 Thread Felipe Franciosi
Heya, > On Nov 28, 2019, at 8:35 PM, Marc-André Lureau > wrote: > > Hi > > On Thu, Nov 28, 2019 at 8:48 PM Felipe Franciosi wrote: >> >> Traditionally, the uint-specific property helpers only offer getters. >> When adding object (or class) uint types, one must therefore use the >> generic

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

2019-11-29 Thread Vladimir Sementsov-Ogievskiy
29.11.2019 17:35, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 28.11.2019 23:29, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> 28.11.2019 17:23, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Error **errp is

Re: [PATCH 3/3] s390x: protvirt: Add new VCPU reset functions

2019-11-29 Thread David Hildenbrand
On 29.11.19 15:20, Janosch Frank wrote: > CPU resets for protected guests need to be done via Ultravisor > calls. Hence we need a way to issue these calls for each reset. > > As we formerly had only one reset function and it was called for > initial, as well as for the clear reset, we now need a

[PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mode.

2019-11-29 Thread bilalwasim676
From: bwasim Loopback mode only works when specific conditions (as dictated by the IP guide) are met, i.e. the MII_MODE is set and the RMII_MODE is cleared. If not, we simply send the packet on the output queue (for TX to the host network). Tested by running a custom RTOS and TXing a ton of

Re: [PATCH v4 31/37] smbus-eeprom: remove PROP_PTR

2019-11-29 Thread Corey Minyard
On Fri, Nov 29, 2019 at 01:06:41PM +0400, Marc-André Lureau wrote: > Hi Corey > > On Fri, Nov 22, 2019 at 2:44 AM Corey Minyard wrote: > > > > On Wed, Nov 20, 2019 at 07:24:36PM +0400, Marc-André Lureau wrote: > > > Instead, set the initial data field directly. > > > > > > (the initial data is

[PATCH 2/3] Sync reset

2019-11-29 Thread Janosch Frank
Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 3d9b18f7f8..3dd7c407e0 100644 --- a/linux-headers/linux/kvm.h +++ b/linux-headers/linux/kvm.h @@ -1000,6 +1000,7 @@

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-11-29 Thread Viktor Mihajlovski
On 11/29/19 3:02 PM, Janosch Frank wrote: [...] As a mgmt app I think there will be a need to be able to determine whether a host + QEMU combo is actually able to support protected machines. If the mgmt app is given an image and the users says it required protected mode, then the mgmt app

Re: [PATCH for-5.0 v2 15/23] mirror: Prevent loops

2019-11-29 Thread Max Reitz
On 29.11.19 14:55, Vladimir Sementsov-Ogievskiy wrote: > 29.11.2019 16:46, Max Reitz wrote: >> On 29.11.19 13:01, Vladimir Sementsov-Ogievskiy wrote: >>> 11.11.2019 19:02, Max Reitz wrote: While bdrv_replace_node() will not follow through with it, a specific @replaces asks the mirror job

Re: qom device lifecycle interaction with hotplug/hotunplug ?

2019-11-29 Thread Igor Mammedov
On Fri, 29 Nov 2019 14:05:23 +0100 Damien Hedde wrote: > On 11/29/19 1:45 PM, Peter Maydell wrote: > > On Fri, 29 Nov 2019 at 12:26, Igor Mammedov wrote: > >> But from the my very limited understanding, on real hardware, > >> once device is uplugged it's gone (finalized) from machine > >>

Re: [PATCH] ci: Use libcap-ng

2019-11-29 Thread Daniel P . Berrangé
On Fri, Nov 29, 2019 at 02:21:26PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > We currently enable libcap-dev in build-clang to pick up the 9p proxy > helper. Paolo's patch changes that to use libcap-ng, so switch to using > it. This also means we'll be

Re: [PATCH v6] hw/core/loader-fit: fix freeing errp in fit_load_fdt

2019-11-29 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > fit_load_fdt forget to check that errp is not NULL and to zero it after > freeing. Fix it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > hw/core/loader-fit.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH] ci: Use libcap-ng

2019-11-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using it. This also means we'll be testing the scsi pr manager and the bridge helper. Signed-off-by: Dr. David Alan Gilbert

Re: [PATCH v2 01/13] s390x: protvirt: Add diag308 subcodes 8 - 10

2019-11-29 Thread Janosch Frank
On 11/29/19 1:40 PM, Thomas Huth wrote: > On 29/11/2019 10.47, Janosch Frank wrote: > [...] >> Subcodes 8-10 are not valid in protected mode, we have to do a subcode >> 3 and then the 8 and 10 combination for a protected reboot. > > So if 8-10 are not valid in protected mode... > >> @@ -59,6

[PATCH 1/8] docs: import Linux kernel-doc script and extension

2019-11-29 Thread Paolo Bonzini
Import Linux's kernel-doc script, as well as the Linux extension to call kernel-doc according to the arguments and parameters given to a reStructuredText directive. The kernel-doc extension accepts a filename, which is relative to the QEMU source tree root. The extension also notifies Sphinx

[PATCH 3/3] s390x: protvirt: Add new VCPU reset functions

2019-11-29 Thread Janosch Frank
CPU resets for protected guests need to be done via Ultravisor calls. Hence we need a way to issue these calls for each reset. As we formerly had only one reset function and it was called for initial, as well as for the clear reset, we now need a new interface. Signed-off-by: Janosch Frank ---

Re: [PATCH] ci: Use libcap-ng

2019-11-29 Thread Thomas Huth
On 29/11/2019 15.21, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > We currently enable libcap-dev in build-clang to pick up the 9p proxy > helper. Paolo's patch changes that to use libcap-ng, so switch to using > it. This also means we'll be testing the scsi pr

Re: [PATCH 00/15] s390x: Protected Virtualization support

2019-11-29 Thread Janosch Frank
On 11/29/19 1:35 PM, Daniel P. Berrangé wrote: > On Fri, Nov 29, 2019 at 01:14:27PM +0100, Janosch Frank wrote: >> On 11/29/19 12:08 PM, Daniel P. Berrangé wrote: >>> On Wed, Nov 20, 2019 at 06:43:19AM -0500, Janosch Frank wrote: Most of the QEMU changes for PV are related to the new IPL type

[PATCH 6/8] docs: Create bitops.rst as example of kernel-docs

2019-11-29 Thread Paolo Bonzini
From: Peter Maydell Create a bitops.rst which is just a container for the kernel-doc comments in qemu/bitops.h. This is mostly a test of the kernel-doc extension machinery. Signed-off-by: Peter Maydell Message-Id: <20190521122519.12573-7-peter.mayd...@linaro.org> Signed-off-by: Paolo Bonzini

  1   2   3   >