Re: [PATCH] hw/ppc/pnv: Fix typo in comment

2020-02-28 Thread David Gibson
On Fri, Feb 28, 2020 at 01:39:02PM +0100, Cédric Le Goater wrote: > On 2/28/20 1:33 PM, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > > Reviewed-by: Cédric Le Goater Applied to ppc-for-5.0, thanks. > > Thnaks, > > C. > > > > --- > > hw/ppc/pnv_lpc.c | 2 +- >

[Bug 1865252] [NEW] QEMU Windows Portable Version (with HAXM accelerator and QEMU GUI)

2020-02-28 Thread Patrick Schleizer
Public bug reported: Please consider providing a QEMU Windows portable [1] [2] [3] version on official qemu.org. Reasons: * This would improve usability, the out of the box user experience of laymen (non-technical) users. * Linux distributions could add the QEMU Windows portable to their

[Bug 1865248] [NEW] bundle QEMU installer with a QEMU GUI (graphical user interface) such as Virt Manager

2020-02-28 Thread Patrick Schleizer
Public bug reported: For a better out of the box user experience on the Windows platform it would be nice if a QEMU GUI would be by installed by the same QEMU installer. Currently it is required to first install QEMU and then install a QEMU GUI. I don't know all QEMU GUIs but looks like Virt

Re: [PATCH v3 03/21] linux-user, hppa: add syscall table generation support

2020-02-28 Thread Richard Henderson
On 2/25/20 4:15 AM, Laurent Vivier wrote: >hppa) > mttcg="yes" > +TARGET_SYSTBL_ABI=common,64 We only support hppa32. We don't even emulate a 64-bit cpu. Of course... I wasn't even aware that linux had any support for a 64-bit userland for hppa, which was one of the reasons why I

Re: [PATCH v3 02/21] linux-user, alpha: add syscall table generation support

2020-02-28 Thread Richard Henderson
On 2/25/20 4:15 AM, Laurent Vivier wrote: > Copy syscall.tbl and syscallhdr.sh from linux/arch/alpha/kernel/syscalls v5.5 > Update syscallhdr.sh to generate QEMU syscall_nr.h > > Signed-off-by: Laurent Vivier > --- > configure | 3 +- > linux-user/Makefile.objs |

Re: [PATCH v3 01/21] linux-user: introduce parameters to generate syscall_nr.h

2020-02-28 Thread Richard Henderson
On 2/25/20 4:15 AM, Laurent Vivier wrote: > This will be used when we'll import syscall.tbl from the kernel > > Add a script to remove all the dependencies to syscall_nr.h > that point to source directory and not to the build directory. > The list of arch will be update while the generated files

Re: [PATCH v3 2/2] util: add util function buffer_zero_avx512()

2020-02-28 Thread Robert Hoo
On Fri, 2020-02-28 at 18:09 -0800, Richard Henderson wrote: > On 2/27/20 6:24 PM, Robert Hoo wrote: > > if ((bv & 6) == 6 && (b & bit_AVX2)) { > > cache |= CACHE_AVX2; > > } > > +if ((bv & 6) == 6 && (b & bit_AVX512F)) { > > +

[PULL 4/8] tcg/arm: Expand epilogue inline

2020-02-28 Thread Richard Henderson
From: Richard Henderson It is, after all, just two instructions. Profiling on a cortex-a15, using -d nochain to increase the number of exit_tb that are executed, shows a minor improvement of 0.5%. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 12 ++-- 1 file

[PULL 5/8] accel/tcg: use units.h for defining code gen buffer sizes

2020-02-28 Thread Richard Henderson
From: Alex Bennée It's easier to read. Signed-off-by: Alex Bennée Reviewed-by: Niek Linnenbank Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20200228192415.19867-2-alex.ben...@linaro.org> Signed-off-by: Richard Henderson

[PULL 2/8] compiler.h: Don't use compile-time assert when __NO_INLINE__ is defined

2020-02-28 Thread Richard Henderson
From: Zenghui Yu Our robot reported the following compile-time warning while compiling Qemu with -fno-inline cflags: In function 'load_memop', inlined from 'load_helper' at /qemu/accel/tcg/cputlb.c:1578:20, inlined from 'full_ldub_mmu' at /qemu/accel/tcg/cputlb.c:1624:12:

[PULL 6/8] accel/tcg: remove link between guest ram and TCG cache size

2020-02-28 Thread Richard Henderson
From: Alex Bennée Basing the TB cache size on the ram_size was always a little heuristic and was broken by a1b18df9a4 which caused ram_size not to be fully realised at the time we initialise the TCG translation cache. The current DEFAULT_CODE_GEN_BUFFER_SIZE may still be a little small but

[PULL 7/8] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts

2020-02-28 Thread Richard Henderson
From: Alex Bennée There is no particular reason to use a static codegen buffer on 64 bit hosts as we have address space to burn. Allow the common CONFIG_USER case to use the mmap'ed buffers like SoftMMU. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe

[PULL 8/8] accel/tcg: increase default code gen buffer size for 64 bit

2020-02-28 Thread Richard Henderson
From: Alex Bennée While 32mb is certainly usable a full system boot ends up flushing the codegen buffer nearly 100 times. Increase the default on 64 bit hosts to take advantage of all that spare memory. After this change I can boot my tests system without any TB flushes. As we usually run more

[PULL 3/8] tcg/arm: Split out tcg_out_epilogue

2020-02-28 Thread Richard Henderson
From: Richard Henderson We will shortly use this function from tcg_out_op as well. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[PULL 1/8] accel/tcg: fix race in cpu_exec_step_atomic (bug 1863025)

2020-02-28 Thread Richard Henderson
From: Alex Bennée The bug describes a race whereby cpu_exec_step_atomic can acquire a TB which is invalidated by a tb_flush before we execute it. This doesn't affect the other cpu_exec modes as a tb_flush by it's nature can only occur on a quiescent system. The race was described as: B2.

[PULL 0/8] tcg patch queue

2020-02-28 Thread Richard Henderson
The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 16:39:27 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg

RE: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open()

2020-02-28 Thread Chenqun (kuhn)
>-Original Message- >From: Kevin Wolf [mailto:kw...@redhat.com] >Sent: Friday, February 28, 2020 6:55 PM >To: Chenqun (kuhn) >Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; >peter.mayd...@linaro.org; Zhanghailiang ; >Euler Robot ; Ronnie Sahlberg >; Paolo Bonzini ; Peter >Lieven ;

Re: [PATCH v3 2/2] util: add util function buffer_zero_avx512()

2020-02-28 Thread Richard Henderson
On 2/27/20 6:24 PM, Robert Hoo wrote: > if ((bv & 6) == 6 && (b & bit_AVX2)) { > cache |= CACHE_AVX2; > } > +if ((bv & 6) == 6 && (b & bit_AVX512F)) { > +cache |= CACHE_AVX512F; > +} Oh, one more thing I missed --

Re: [PATCH v3 1/2] configure: add configure option avx512f_opt

2020-02-28 Thread Richard Henderson
On 2/27/20 6:24 PM, Robert Hoo wrote: > If it is enabled, config-host.mak will have CONFIG_AVX512F_OPT defined. > > AVX512F instruction set is available since Intel Skylake, and can be enabled > in > compiling with -mavx512f. > More info: >

Re: [PATCH] linux-user: Add an argument QEMU_MMAP_BASE to set custom mmap base address in qemu user mode

2020-02-28 Thread Lirong Yuan
On Fri, Feb 21, 2020 at 5:09 PM Lirong Yuan wrote: > > This change allows us to set custom base address for guest programs. It is > needed to allow qemu to work with Thread Sanitizer (TSan), which has specific > boundary definitions for memory mappings on different platforms: >

Re: [PATCH] linux-user: Add AT_EXECFN and AT_EXECFD auxval

2020-02-28 Thread Lirong Yuan
On Fri, Feb 21, 2020 at 12:29 PM Lirong Yuan wrote: > > This change adds the support for AT_EXECFN and AT_EXECFD auxval. > > Signed-off-by: Lirong Yuan > --- > linux-user/elfload.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/linux-user/elfload.c

Re: [PATCH v2 0/4] Clean-up codegen cache size

2020-02-28 Thread Richard Henderson
On 2/28/20 11:24 AM, Alex Bennée wrote: > Hi, > > A few tweaks to the final commit so we are a little less greedy for > translation buffer, especially for the CONFIG_USER case. Otherwise > I've applied the review tags. > > Alex Bennée (4): > accel/tcg: use units.h for defining code gen buffer

[PATCH v5 11/12] target/arm: Honor the HCR_EL2.TTLB bit

2020-02-28 Thread Richard Henderson
This bit traps EL1 access to tlb maintenance insns. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.c | 85 + 1 file changed, 55 insertions(+), 30 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c

[PATCH v5 12/12] tests/tcg/aarch64: Add newline in pauth-1 printf

2020-02-28 Thread Richard Henderson
Make the output just a bit prettier when running by hand. Cc: Alex Bennée Signed-off-by: Richard Henderson --- tests/tcg/aarch64/pauth-1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/aarch64/pauth-1.c b/tests/tcg/aarch64/pauth-1.c index ea0984ea82..d3878cbeb6

[PATCH v5 08/12] target/arm: Honor the HCR_EL2.TACR bit

2020-02-28 Thread Richard Henderson
This bit traps EL1 access to the auxiliary control registers. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index

[PATCH v5 07/12] target/arm: Honor the HCR_EL2.TSW bit

2020-02-28 Thread Richard Henderson
These bits trap EL1 access to set/way cache maintenance insns. Buglink: https://bugs.launchpad.net/bugs/1863685 Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git

[PATCH v5 09/12] target/arm: Honor the HCR_EL2.TPCP bit

2020-02-28 Thread Richard Henderson
This bit traps EL1 access to cache maintenance insns that operate to the point of coherency or persistence. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v3: Fix el0 fallthru (pmm). --- target/arm/helper.c | 39 +++ 1 file changed, 31

[PATCH v5 03/12] target/arm: Disable has_el2 and has_el3 for user-only

2020-02-28 Thread Richard Henderson
In arm_cpu_reset, we configure many system registers so that user-only behaves as it should with a minimum of ifdefs. However, we do not set all of the system registers as required for a cpu with EL2 and EL3. Disabling EL2 and EL3 mean that we will not look at those registers, which means that

[PATCH v5 10/12] target/arm: Honor the HCR_EL2.TPU bit

2020-02-28 Thread Richard Henderson
This bit traps EL1 access to cache maintenance insns that operate to the point of unification. There are no longer any references to plain aa64_cacheop_access, so remove it. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v3: Fix el0 fallthru (pmm). --- target/arm/helper.c |

[PATCH v5 06/12] target/arm: Honor the HCR_EL2.{TVM,TRVM} bits

2020-02-28 Thread Richard Henderson
These bits trap EL1 access to various virtual memory controls. Buglink: https://bugs.launchpad.net/bugs/1855072 Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Include TTBCR. v3: Include not_v8_cp_reginfo, lpae_cp_reginfo, CONTEXTIDR_S; exclude not_v7_cp_reginfo (pmm).

[PATCH v5 01/12] target/arm: Improve masking of HCR/HCR2 RES0 bits

2020-02-28 Thread Richard Henderson
Don't merely start with v8.0, handle v7VE as well. Ensure that writes from aarch32 mode do not change bits in the other half of the register. Protect reads of aa64 id registers with ARM_FEATURE_AARCH64. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.c | 38

[PATCH v5 05/12] target/arm: Improve masking in arm_hcr_el2_eff

2020-02-28 Thread Richard Henderson
Update the {TGE,E2H} == '11' masking to ARMv8.6. If EL2 is configured for aarch32, disable all of the bits that are RES0 in aarch32 mode. Signed-off-by: Richard Henderson --- target/arm/helper.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git

[PATCH v5 00/12] target/arm: Honor more HCR_EL2 traps

2020-02-28 Thread Richard Henderson
Changes for v5: * Patch 1 was broken for aa32. Not just the masking vs the "other" 32-bit register that Peter noticed, but more explicitly in that "ri" was dereferenced as NULL -- hcr_write{high,low} did not pass along the structure. Oops. Break out a new helper that is passed

[PATCH v5 04/12] target/arm: Remove EL2 and EL3 setup from user-only

2020-02-28 Thread Richard Henderson
We have disabled EL2 and EL3 for user-only, which means that these registers "don't exist" and should not be set. Signed-off-by: Richard Henderson --- target/arm/cpu.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 33c28fe868..af541431e6

[PATCH v5 02/12] target/arm: Add HCR_EL2 bit definitions from ARMv8.6

2020-02-28 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 0b84742b66..0ae07a72e4 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1410,6 +1410,7 @@ static inline void xpsr_write(CPUARMState

[Bug 1759522] Re: windows qemu-img create vpc/vhdx error

2020-02-28 Thread maro
I also discovered just a few days ago the problem that sparse VHD/VHDX image files are not being accepted by Windows. It appears that qemu-img on Windows always tries to create images as sparse files. Only in some cases (e.g. when operating on a NTFS file system) will the file actually be a

Re: [PATCH] hw/smbios: add options for type 4 max_speed and current_speed

2020-02-28 Thread Heyi Guo
Hi Igor, On 2020/2/28 17:39, Igor Mammedov wrote: On Thu, 27 Feb 2020 17:12:21 +0800 Heyi Guo wrote: On 2020/2/25 17:24, Philippe Mathieu-Daudé wrote: On 2/25/20 8:50 AM, Heyi Guo wrote: Common VM users sometimes care about CPU speed, so we add two new options to allow VM vendors to

Re: [PATCH v2 0/2] hw/arm/xilinx_zynq: Fix USB port instantiation

2020-02-28 Thread Guenter Roeck
On Fri, Feb 28, 2020 at 12:44:19PM -0600, Edgar E. Iglesias wrote: > Sorry Peter, I missed the email. > > Reviewed-by: Edgar E. Iglesias > Thanks a lot everyone! Guenter > Best regards, > Edgar > > > On Fri, 28 Feb. 2020, 10:00 Peter Maydell, wrote: > > > On Thu, 20 Feb 2020 at 15:05,

Re: [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits

2020-02-28 Thread Richard Henderson
On 2/28/20 11:03 AM, Peter Maydell wrote: > It occurs to me that we should check what the required > semantics are for the opposite half of the register > if the guest writes to one half of it via hcr_writehigh() > or hcr_writelow() -- is the un-accessed half supposed > to stay exactly as it is,

RE: Emulating Solaris 10 on SPARC64 sun4u

2020-02-28 Thread BALATON Zoltan
On Wed, 19 Feb 2020, BALATON Zoltan wrote: On Wed, 19 Feb 2020, BALATON Zoltan wrote: faster or doing something differently? Does someone know what interrupts are generated on real hardware in DMA mode so we can compare that to what we see with QEMU? The document Programming Interface for

Re: [PATCH v3 3/4] target/i386: Add new property note to versioned CPU models

2020-02-28 Thread Eduardo Habkost
On Wed, Feb 12, 2020 at 04:13:27PM +0800, Tao Xu wrote: > Add additional information for -cpu help to indicate the changes in this > version of CPU model. > > Suggested-by: Eduardo Habkost > Signed-off-by: Tao Xu Queued, thanks! -- Eduardo

Re: [PATCH v3 4/4] target/i386: Add notes for versioned CPU models

2020-02-28 Thread Eduardo Habkost
On Wed, Feb 12, 2020 at 04:13:28PM +0800, Tao Xu wrote: > Add which features are added or removed in this version. Remove the > changed model-id in versioned CPU models, to keep the model name > unchanged at /proc/cpuinfo inside the VM. > > Signed-off-by: Tao Xu > --- > > Changes in v2: > -

Re: [PATCH v3 1/4] target/i386: Add Denverton-v2 (no MPX) CPU model

2020-02-28 Thread Eduardo Habkost
On Wed, Feb 12, 2020 at 04:13:25PM +0800, Tao Xu wrote: > Because MPX is being removed from the linux kernel, remove MPX feature > from Denverton. > > Signed-off-by: Tao Xu Queued, thanks! -- Eduardo

Re: [PATCH v3 2/4] target/i386: Remove monitor from some CPU models

2020-02-28 Thread Eduardo Habkost
On Wed, Feb 12, 2020 at 04:13:26PM +0800, Tao Xu wrote: > Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana > CPU model to remove MONITOR/MWAIT feature. > > After QEMU/KVM use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT > (commit id

Re: [PATCH v3 00/33] Convert qemu-doc to rST

2020-02-28 Thread Stefan Weil
Am 28.02.20 um 19:36 schrieb Peter Maydell: > Hi Stefan -- I meant to cc you on these but forgot, relating to the > "qemu.nsi needs updating to know that it should install > Sphinx documentation these days" part... > > On Fri, 28 Feb 2020 at 15:36, Peter Maydell wrote: [...] >> A couple of

[PULL 3/4] hw: Make MachineClass::is_default a boolean type

2020-02-28 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé There's no good reason for it to be type int, change it to bool. Suggested-by: Richard Henderson Reviewed-by: Michael S. Tsirkin Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200207161948.15972-3-phi...@redhat.com> Reviewed-by: Marc-André Lureau

[PULL 2/4] hw: Do not initialize MachineClass::is_default to 0

2020-02-28 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé The MachineClass is already zeroed on creation. Note: The code setting is_default=0 in hw/i386/pc_piix.c is different (related to compat options). When adding a new versioned machine, we want it to be the new default, so we have to mark the

[PULL 0/4] Machine queue, 2020-02-28

2020-02-28 Thread Eduardo Habkost
The following changes since commit e0175b71638cf4398903c0d25f93fe62e0606389: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200228' into staging (2020-02-28 16:39:27 +) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next

[PULL 1/4] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()

2020-02-28 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé There is no declaration of the 'NMI' type. INTERFACE_CHECK() returns an abstract type (see commit aa1b35b975d8). The abstract type corresponding to the TYPE_NMI interface is 'NMIState'. Fixes: 9cb805fd267 Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 4/4] vl: Abort if multiple machines are registered as default

2020-02-28 Thread Eduardo Habkost
From: Philippe Mathieu-Daudé It would be confusing to have multiple default machines. Abort if this ever occurs. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200207161948.15972-4-phi...@redhat.com> Reviewed-by: Marc-André Lureau Signed-off-by: Eduardo Habkost Reviewed-by: Laurent

RE: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state

2020-02-28 Thread Sunil Muthuswamy
> -Original Message- > From: Paolo Bonzini > Sent: Friday, February 28, 2020 2:45 AM > To: Sunil Muthuswamy ; Richard Henderson > ; Eduardo Habkost > > Cc: qemu-devel@nongnu.org; Stefan Weil > Subject: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on > VM state > >

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-02-28 Thread Peter Xu
On Fri, Feb 28, 2020 at 09:16:28PM +0100, David Hildenbrand wrote: > [...] > >> @@ -631,7 +658,7 @@ int qemu_vfio_dma_map(QEMUVFIOState *s, void *host, > >> size_t size, > >> qemu_vfio_remove_mapping(s, mapping); > >> goto out; > >> } > >> -

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-02-28 Thread David Hildenbrand
> Am 28.02.2020 um 21:49 schrieb Peter Xu : > > On Fri, Feb 28, 2020 at 03:19:45PM -0500, David Hildenbrand wrote: >> >> Am 28.02.2020 um 20:55 schrieb Peter Xu : >>> >>> On Thu, Feb 27, 2020 at 11:12:02AM +0100, David Hildenbrand wrote: +static void

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-02-28 Thread Peter Xu
On Fri, Feb 28, 2020 at 03:19:45PM -0500, David Hildenbrand wrote: > > > > Am 28.02.2020 um 20:55 schrieb Peter Xu : > > > > On Thu, Feb 27, 2020 at 11:12:02AM +0100, David Hildenbrand wrote: > >> +static void qemu_vfio_dma_map_resize(QEMUVFIOState *s, void *host, > >> +

Re: [PATCH v3 15/15] exec: Ram blocks with resizeable anonymous allocations under POSIX

2020-02-28 Thread Peter Xu
On Thu, Feb 27, 2020 at 11:12:05AM +0100, David Hildenbrand wrote: [...] > +static void ram_block_alloc_ram(RAMBlock *rb) > +{ > +const bool shared = qemu_ram_is_shared(rb); > + > +/* > + * If we can, try to allocate actually resizeable ram. Will also fail > + * if

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-02-28 Thread David Hildenbrand
> Am 28.02.2020 um 20:55 schrieb Peter Xu : > > On Thu, Feb 27, 2020 at 11:12:02AM +0100, David Hildenbrand wrote: >> +static void qemu_vfio_dma_map_resize(QEMUVFIOState *s, void *host, >> + size_t old_size, size_t new_size) >> +{ >> +IOVAMapping *m; >>

Re: [PATCH v2 4/4] accel/tcg: increase default code gen buffer size for 64 bit

2020-02-28 Thread Niek Linnenbank
On Fri, Feb 28, 2020 at 8:24 PM Alex Bennée wrote: > While 32mb is certainly usable a full system boot ends up flushing the > codegen buffer nearly 100 times. Increase the default on 64 bit hosts > to take advantage of all that spare memory. After this change I can > boot my tests system without

Re: [PATCH v2 2/4] accel/tcg: remove link between guest ram and TCG cache size

2020-02-28 Thread Niek Linnenbank
On Fri, Feb 28, 2020 at 8:24 PM Alex Bennée wrote: > Basing the TB cache size on the ram_size was always a little heuristic > and was broken by a1b18df9a4 which caused ram_size not to be fully > realised at the time we initialise the TCG translation cache. > > The current

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-02-28 Thread David Hildenbrand
> Am 28.02.2020 um 20:43 schrieb Peter Xu : > > On Thu, Feb 27, 2020 at 11:12:02AM +0100, David Hildenbrand wrote: >> Let's implement ram_block_resized(), allowing resizeable mappings. >> >> For resizeable mappings, we reserve $max_size IOVA address space, but only >> map $size of it. When

Re: [PATCH v3 14/15] numa: Introduce ram_block_notifiers_support_resize()

2020-02-28 Thread Peter Xu
On Thu, Feb 27, 2020 at 11:12:04AM +0100, David Hildenbrand wrote: > We want to actually use resizeable allocations in resizeable ram blocks > (IOW, make everything between used_length and max_length inaccessible) - > however, not all ram block notifiers can support that. > > Introduce a way to

Re: [PATCH v3 13/15] util: oslib: Resizeable anonymous allocations under POSIX

2020-02-28 Thread Peter Xu
On Thu, Feb 27, 2020 at 11:12:03AM +0100, David Hildenbrand wrote: > Introduce qemu_anon_ram_alloc_resizeable() and qemu_anon_ram_resize(). > Implement them under POSIX and make them return NULL under WIN32. > > Under POSIX, we make use of resizeable mmaps. An implementation under > WIN32 is

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-02-28 Thread Peter Xu
On Thu, Feb 27, 2020 at 11:12:02AM +0100, David Hildenbrand wrote: > +static void qemu_vfio_dma_map_resize(QEMUVFIOState *s, void *host, > + size_t old_size, size_t new_size) > +{ > +IOVAMapping *m; > +int index = 0; > + > +qemu_mutex_lock(>lock); >

Re: [PATCH v3 11/15] util/mmap-alloc: Implement resizeable mmaps

2020-02-28 Thread Peter Xu
On Thu, Feb 27, 2020 at 11:12:01AM +0100, David Hildenbrand wrote: > Implement resizeable mmaps. For now, the actual resizing is not wired up. > Introduce qemu_ram_mmap_resizeable() and qemu_ram_mmap_resize(). Make > qemu_ram_mmap() a wrapper of qemu_ram_mmap_resizeable(). > > Cc: Richard

Re: [PATCH v3 07/15] util/mmap-alloc: Factor out calculation of the pagesize for the guard page

2020-02-28 Thread Peter Xu
On Thu, Feb 27, 2020 at 11:11:57AM +0100, David Hildenbrand wrote: > Let's factor out calculating the size of the guard page and rename the > variable to make it clearer that this pagesize only applies to the > guard page. > > Cc: "Michael S. Tsirkin" > Cc: Murilo Opsfelder Araujo > Cc: Greg

Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()

2020-02-28 Thread Peter Xu
On Thu, Feb 27, 2020 at 11:12:02AM +0100, David Hildenbrand wrote: > Let's implement ram_block_resized(), allowing resizeable mappings. > > For resizeable mappings, we reserve $max_size IOVA address space, but only > map $size of it. When resizing, unmap the old part and remap the new > part.

[PATCH v2 4/4] accel/tcg: increase default code gen buffer size for 64 bit

2020-02-28 Thread Alex Bennée
While 32mb is certainly usable a full system boot ends up flushing the codegen buffer nearly 100 times. Increase the default on 64 bit hosts to take advantage of all that spare memory. After this change I can boot my tests system without any TB flushes. As we usually run more CONFIG_USER binaries

[PATCH v2 2/4] accel/tcg: remove link between guest ram and TCG cache size

2020-02-28 Thread Alex Bennée
Basing the TB cache size on the ram_size was always a little heuristic and was broken by a1b18df9a4 which caused ram_size not to be fully realised at the time we initialise the TCG translation cache. The current DEFAULT_CODE_GEN_BUFFER_SIZE may still be a little small but follow-up patches will

[PATCH v2 1/4] accel/tcg: use units.h for defining code gen buffer sizes

2020-02-28 Thread Alex Bennée
It's easier to read. Signed-off-by: Alex Bennée Reviewed-by: Niek Linnenbank Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- accel/tcg/translate-all.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff

[PATCH v2 3/4] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts

2020-02-28 Thread Alex Bennée
There is no particular reason to use a static codegen buffer on 64 bit hosts as we have address space to burn. Allow the common CONFIG_USER case to use the mmap'ed buffers like SoftMMU. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by:

[PATCH v2 0/4] Clean-up codegen cache size

2020-02-28 Thread Alex Bennée
Hi, A few tweaks to the final commit so we are a little less greedy for translation buffer, especially for the CONFIG_USER case. Otherwise I've applied the review tags. Alex Bennée (4): accel/tcg: use units.h for defining code gen buffer sizes accel/tcg: remove link between guest ram and TCG

Re: [PATCH v1 4/4] accel/tcg: increase default code gen buffer size for 64 bit

2020-02-28 Thread Alex Bennée
Igor Mammedov writes: > On Thu, 27 Feb 2020 20:07:24 +0100 > Niek Linnenbank wrote: > >> Hi Richard, >> >> On Thu, Feb 27, 2020 at 1:57 PM Richard Henderson < >> richard.hender...@linaro.org> wrote: >> >> > On 2/27/20 4:31 AM, Alex Bennée wrote: >> > >> It does not make sense for a

Re: [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits

2020-02-28 Thread Peter Maydell
On Fri, 28 Feb 2020 at 18:55, Richard Henderson wrote: > > On 2/28/20 9:34 AM, Peter Maydell wrote: > > You could refine the valid mask as the & of the bits which we > > do want to exist in aarch32, rather than &~ of the reserved bits: > > > > valid_mask &= TTLBIS | TOCU | TICAB | ... > > > > ?

Re: [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits

2020-02-28 Thread Richard Henderson
On 2/28/20 9:34 AM, Peter Maydell wrote: > One of us is miscounting, and I don't *think* it's me... > > bits 63..0: ff80ff8c9000 > bits 63..32: ff80ff8c > bits 64..48: ff80 > > bit 48 looks like it's 0 to me. Oops, yes, it's me. > You could refine the valid mask as the & of the bits which

Re: [PATCH v4 5/5] target/riscv: add vector amo operations

2020-02-28 Thread Richard Henderson
On 2/28/20 1:19 AM, LIU Zhiwei wrote: >>> +#define GEN_VEXT_AMO_NOATOMIC_OP(NAME, ETYPE, MTYPE, H, DO_OP, SUF)  \ >>> +static void vext_##NAME##_noatomic_op(void *vs3, target_ulong addr,  \ >>> +    uint32_t wd, uint32_t idx, CPURISCVState *env, uintptr_t retaddr)\ >>> +{   

Re: [PATCH v5 49/50] multi-process: add the concept description to docs/devel/qemu-multiprocess

2020-02-28 Thread Elena Ufimtseva
On Thu, Feb 27, 2020 at 05:11:40PM +, Stefan Hajnoczi wrote: > On Mon, Feb 24, 2020 at 03:55:40PM -0500, Jagannathan Raman wrote: > > From: John G Johnson > > > > Signed-off-by: John G Johnson > > Signed-off-by: Elena Ufimtseva > > Signed-off-by: Jagannathan Raman > > --- > >

Re: [PATCH v2 0/2] hw/arm/xilinx_zynq: Fix USB port instantiation

2020-02-28 Thread Edgar E. Iglesias
Sorry Peter, I missed the email. Reviewed-by: Edgar E. Iglesias Best regards, Edgar On Fri, 28 Feb. 2020, 10:00 Peter Maydell, wrote: > On Thu, 20 Feb 2020 at 15:05, Peter Maydell > wrote: > > > > On Sat, 15 Feb 2020 at 12:23, Guenter Roeck wrote: > > > > > > USB ports on Xilinx Zync must

Re: [PATCH v5 50/50] multi-process: add configure and usage information

2020-02-28 Thread Elena Ufimtseva
On Thu, Feb 27, 2020 at 04:58:04PM +, Stefan Hajnoczi wrote: > On Mon, Feb 24, 2020 at 03:55:41PM -0500, Jagannathan Raman wrote: > > From: Elena Ufimtseva > > > > Signed-off-by: Elena Ufimtseva > > Signed-off-by: Jagannathan Raman > > Signed-off-by: John G Johnson > > --- > >

Re: [PATCH v3 00/33] Convert qemu-doc to rST

2020-02-28 Thread Peter Maydell
Hi Stefan -- I meant to cc you on these but forgot, relating to the "qemu.nsi needs updating to know that it should install Sphinx documentation these days" part... On Fri, 28 Feb 2020 at 15:36, Peter Maydell wrote: > > Hi; this series does a complete conversion of qemu-doc from > Texinfo to

[Bug 1865188] Re: Switching from the monitor to the emulated machine with a French keyboard (AZERTY)

2020-02-28 Thread Laurent Vivier
In an xterm to switch to/from QEMU monitor use "Ctrl-A c" -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1865188 Title: Switching from the monitor to the emulated machine with a French keyboard

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-28 Thread David Hildenbrand
On 28.02.20 17:49, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: David Hildenbrand [mailto:da...@redhat.com] >> Sent: 13 February 2020 17:09 >> To: Shameerali Kolothum Thodi ; >> Igor Mammedov >> Cc: peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com; >>

Re: [PULL 00/33] target-arm queue

2020-02-28 Thread Peter Maydell
ntela/tags/pull-migration-pull-request' into staging > (2020-02-28 14:02:31 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20200228 > > for you to fetch changes up to 1904f9b5f1d94fe12fe021db6b5

Re: [PATCH v5 48/50] multi-process: Validate incoming commands from Proxy

2020-02-28 Thread Elena Ufimtseva
On Thu, Feb 27, 2020 at 05:18:30PM +, Stefan Hajnoczi wrote: > On Mon, Feb 24, 2020 at 03:55:39PM -0500, Jagannathan Raman wrote: > > From: Elena Ufimtseva > > > > Validate the incoming commands to confirm that they would not cause any > > errors in the remote process. > > > >

Re: [PATCH v4 00/10] vTPM for aarch64

2020-02-28 Thread Stefan Berger
On 2/28/20 9:49 AM, Auger Eric wrote: Hi Stefan, On 2/28/20 3:37 PM, Stefan Berger wrote: On 2/27/20 3:07 AM, Auger Eric wrote: Hi Stefan, On 2/26/20 11:44 PM, Stefan Berger wrote: On 2/26/20 3:59 PM, Eric Auger wrote: This series adds the capability to instantiate an MMIO TPM TIS in ARM

Re: [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits

2020-02-28 Thread Peter Maydell
On Fri, 28 Feb 2020 at 16:57, Richard Henderson wrote: > > On 2/28/20 8:22 AM, Peter Maydell wrote: > >> +if (ri->state == ARM_CP_STATE_AA32) { > >> +/* > >> + * Writes from aarch32 mode have more RES0 bits. > >> + * This includes TDZ, RW, E2H, and more. > >> +

[Bug 1865188] [NEW] Switching from the monitor to the emulated machine with a French keyboard (AZERTY)

2020-02-28 Thread Thierry Briot
Public bug reported: Hi, I run qemu in an xterm terminal, with TERM=vt100. My keyboard is french AZERTY. sudo ./qemu-system-hppa -monitor /dev/pts/2 -k fr -boot d -drive if=scsi,bus=0,index=5,file=../../hpux_11iv1.img,format=raw -serial mon:stdio -D qemu1.log -nographic -m 512 -d nochain -cdrom

Re: [PATCH v2 2/6] util: Replace fprintf(stderr, "*\n" with error_report()

2020-02-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 2/28/20 10:50 AM, Philippe Mathieu-Daudé wrote: [...] >> Thanks for your review. I'll drop the changes in util/oslib-win32.c >> for for now, and add a note in my TODO for after the 5.0 release. > > Well if I follow this line, I'v to drop the changes in

Re: [PATCH v4 1/7] target/arm: Improve masking of HCR RES0 bits

2020-02-28 Thread Richard Henderson
On 2/28/20 8:22 AM, Peter Maydell wrote: >> +if (ri->state == ARM_CP_STATE_AA32) { >> +/* >> + * Writes from aarch32 mode have more RES0 bits. >> + * This includes TDZ, RW, E2H, and more. >> + */ >> +valid_mask &= ~0xff80ff8c9000ull; >> +} > >

[RFC PATCH v2 67/67] Hexagon HVX build infrastructure

2020-02-28 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/Makefile.objs | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/hexagon/Makefile.objs b/target/hexagon/Makefile.objs index be0d08f..d18b41f 100644 --- a/target/hexagon/Makefile.objs +++

[RFC PATCH v2 52/67] Hexagon Linux user emulation

2020-02-28 Thread Taylor Simpson
Implementation of Linux user emulation for RISC-V Some common files modified in addition to new files in linux-user/hexagon Signed-off-by: Taylor Simpson --- linux-user/hexagon/sockbits.h | 18 ++ linux-user/hexagon/syscall_nr.h | 346

[RFC PATCH v2 26/67] Hexagon generator phase 2 - op_regs_generated.h

2020-02-28 Thread Taylor Simpson
Lists the register and immediate operands for each instruction Signed-off-by: Taylor Simpson --- target/hexagon/do_qemu.py | 86 +++ 1 file changed, 86 insertions(+) diff --git a/target/hexagon/do_qemu.py b/target/hexagon/do_qemu.py index

Re: [PATCH v2] qapi/machine: Place the 'Notes' tag after the 'Since' tag

2020-02-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 2/28/20 7:56 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >>> On 2/27/20 3:55 PM, Philippe Mathieu-Daudé wrote: On 2/27/20 3:52 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> This fixes when adding a

[RFC PATCH v2 54/67] Hexagon - Add Hexagon Vector eXtensions (HVX) to core definition

2020-02-28 Thread Taylor Simpson
HVX is a set of wide vector instructions. Machine state includes vector registers (VRegs) vector predicate registers (QRegs) temporary registers for packet semantics store buffer (masked stores and scatter/gather) Signed-off-by: Taylor Simpson --- target/hexagon/cpu.h |

Re: [PATCH] block: Remove trailing newline in format used by error_report API

2020-02-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > The error_report API doesn't want trailing newline characters. > Remove it, to avoid and error when moving the code around: > > ERROR: Error messages should not contain newlines Commit 312fd5f2909 has a Coccinelle script. It should be committed and re-run. >

[RFC PATCH v2 42/67] Hexagon TCG generation - step 04

2020-02-28 Thread Taylor Simpson
Override store instructions Signed-off-by: Taylor Simpson --- target/hexagon/helper_overrides.h | 241 ++ 1 file changed, 241 insertions(+) diff --git a/target/hexagon/helper_overrides.h b/target/hexagon/helper_overrides.h index 20d8584..fdcc517 100644 ---

[RFC PATCH v2 56/67] Hexagon HVX import instruction encodings

2020-02-28 Thread Taylor Simpson
Signed-off-by: Taylor Simpson --- target/hexagon/imported/allextenc.def| 20 + target/hexagon/imported/encode.def | 1 + target/hexagon/imported/mmvec/encode_ext.def | 830 +++ 3 files changed, 851 insertions(+) create mode 100644

[RFC PATCH v2 50/67] Hexagon TCG generation - step 12

2020-02-28 Thread Taylor Simpson
Override miscellaneous instructions identified during profiling Signed-off-by: Taylor Simpson --- target/hexagon/helper_overrides.h | 296 ++ 1 file changed, 296 insertions(+) diff --git a/target/hexagon/helper_overrides.h

[RFC PATCH v2 58/67] Hexagon HVX import macro definitions

2020-02-28 Thread Taylor Simpson
Imported from the Hexagon architecture library imported/allext_macros.def Top level macro include for all extensions imported/mmvec/macros.defHVX macro definitions The macro definition files specify instruction attributes that are applied to each instruction that reverences

[RFC PATCH v2 38/67] Hexagon TCG generation helpers - step 5

2020-02-28 Thread Taylor Simpson
Helpers for instructions overriden for optimization Signed-off-by: Taylor Simpson --- target/hexagon/genptr_helpers.h | 314 1 file changed, 314 insertions(+) diff --git a/target/hexagon/genptr_helpers.h b/target/hexagon/genptr_helpers.h index

[RFC PATCH v2 36/67] Hexagon TCG generation helpers - step 3

2020-02-28 Thread Taylor Simpson
Helpers for store instructions Signed-off-by: Taylor Simpson --- target/hexagon/genptr_helpers.h | 77 + 1 file changed, 77 insertions(+) diff --git a/target/hexagon/genptr_helpers.h b/target/hexagon/genptr_helpers.h index c0e4c39..0e2d7b9 100644 ---

[RFC PATCH v2 66/67] Hexagon HVX translation

2020-02-28 Thread Taylor Simpson
Changes to packet semantics to support HVX Signed-off-by: Taylor Simpson --- target/hexagon/translate.h | 30 target/hexagon/translate.c | 188 + 2 files changed, 218 insertions(+) diff --git a/target/hexagon/translate.h

  1   2   3   4   >