Mark Cave-Ayland writes:
> On 28/05/2020 12:04, Markus Armbruster wrote:
>
>> These devices go with the "via-pmu" device, which is controlled by
>> property "has-pmu". macio_newworld_init() creates it unconditionally,
>> because the property has not been set then. macio_newworld_realize()
>>
Philippe Mathieu-Daudé writes:
> On 5/28/20 1:04 PM, Markus Armbruster wrote:
>> xlnx_dp_init() creates these two devices, but they're never realized.
>> Affects machine xlnx-zcu102.
>>
>> In theory, a device becomes real only on realize. In practice, the
>> transition from unreal to real is a
On 5/28/20 1:04 PM, Markus Armbruster wrote:
> leon3_generic_hw_init() creates a "grlib,ahbpnp" and a "grlib,apbpnp"
> sysbus device in a way that leaves them unplugged.
>
> Create them the common way that puts them into the main system bus.
> Affects machine leon3_generic. Visible in "info
On 3/31/20 12:50 PM, Philippe Mathieu-Daudé wrote:
> The Leon3Machine.test_leon3_helenos_uimage has been running
> erratically since some time now. Time to disable it (at least
> until we make it reliable).
> Few other patches added while tracking the issue.
>
> Philippe Mathieu-Daudé (7):
>
On 6/8/20 7:21 PM, Philippe Mathieu-Daudé wrote:
> Few more SPARC patches.
>
> Mark/Artyom/Frederic if you Ack them I'll simply add them
> to the current trivial SPARC patch queue I prepared.
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (3):
> hw/sparc/leon3: Map the UART device
On 5/10/20 5:28 PM, Philippe Mathieu-Daudé wrote:
> New Spring, new opportunity to clean this device :)
> (v1 was in 2018, v2 in 2019).
>
> - lower device priority
> - follow qdev model and use properties
> - convert to trace events
> - describe with slot name
> - move under hw/misc/ and cover in
On 6/9/20 2:47 AM, Yi Wang wrote:
> From: Liao Pingfang
>
> We need install qemu-[qmp/ga]-ref.* files into the subdirectory of qemu docs:
> interop.
>
> If we visit the following address and click the link to qemu-qmp-ref.html:
>
On Mon, Jun 08, 2020 at 09:06:17 +0100, Alex Bennée wrote:
> Emilio G. Cota writes:
> > I'd rather use asprintf(3) and strdup(3) here, so that plugins don't
> > have to worry about glib, and on the QEMU side we don't have to worry
> > about plugins calling free() instead of g_free().
>
> AFAIK
在 2020/6/9 10:47, Jiaxun Yang 写道:
Our current code assumed the target page size is always 4k
when handling PageMask and VPN2, however, variable page size
was just added to mips target and that's nolonger true.
So we refined this piece of code to handle any target page size.
Also added Big
On Tue, Jun 9, 2020 at 4:14 AM Eric Blake wrote:
>
> On 5/29/20 9:06 AM, Cindy Lu wrote:
> > From: Tiwei Bie
>
> The original author is Tiwei Bie...
>
> >
> > Currently we have 2 types of vhost backends in QEMU: vhost kernel and
> > vhost-user. The above patch provides a generic device for vDPA
On 2020/6/9 3:34, Richard Henderson wrote:
On 6/8/20 5:53 AM, LIU Zhiwei wrote:
Hi Richard,
I am doing bfloat16 support on QEMU.
Once I tried to reuse float32 interface, but I couldn't properly process
rounding in some insns like fadd.
What's your opinion about it? Should I expand the
On 2020/6/8 23:50, Alex Bennée wrote:
LIU Zhiwei writes:
Hi Richard,
I am doing bfloat16 support on QEMU.
Once I tried to reuse float32 interface, but I couldn't properly process
rounding in some insns like fadd.
What do you mean by re-use the float32 interface?
Once I think bfloat16
Our current code assumed the target page size is always 4k
when handling PageMask and VPN2, however, variable page size
was just added to mips target and that's nolonger true.
So we refined this piece of code to handle any target page size.
Also added Big Page support defined by MIPS64 Release2.
On Thu, 21 May 2020 at 20:39, Havard Skinnemoen wrote:
>
> The Nuvoton NPCM7xx SoC family are used to implement Baseboard
> Management Controllers in servers. While the family includes four SoCs,
> this patch implements limited support for two of them: NPCM730 (targeted
> for Data Center
On Mon, 8 Jun 2020 at 22:15, Havard Skinnemoen wrote:
>
> On Thu, May 21, 2020 at 12:21 PM Havard Skinnemoen
> wrote:
>>
>> This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to
>> boot
>> a minimal Linux kernel. This includes device models for:
>
>
> Does anyone have
On Thu, 21 May 2020 at 20:40, Havard Skinnemoen wrote:
>
> Implement a device model for the System Global Control Registers in the
> NPCM730 and NPCM750 BMC SoCs.
>
> This is primarily used to enable SMP boot (the boot ROM spins reading
> the SCRPAD register); other registers are best effort for
On Thu, 21 May 2020 at 20:39, Havard Skinnemoen wrote:
>
> This adds two new machines:
>
> - npcm750-evb: Nuvoton NPCM750 Evaluation Board.
> - quanta-gsj: A board with a NPCM730 chip.
You could note that these are the two boards supported by OpenBMC.
> They rely on the NPCM7xx SoC device
On Thu, 21 May 2020 at 20:39, Havard Skinnemoen wrote:
>
> Enough functionality to boot the Linux kernel has been implemented. This
> includes:
>
> - Correct power-on reset values so the various clock rates can be
> accurately calculated.
> - Clock enables stick around when written.
>
>
On Thu, 21 May 2020 at 20:38, Havard Skinnemoen wrote:
>
> The NPCM730 and NPCM750 SoCs have three timer modules each holding five
> timers and some shared registers (e.g. interrupt status).
>
> Each timer runs at 25 MHz divided by a prescaler, and counts down from a
> configurable initial value
On Thu, 21 May 2020 at 20:39, Havard Skinnemoen wrote:
>
> Add a config symbol for the NPCM7xx BMC SoC family that subsequent
> patches can use in Makefiles.
>
> Reviewed-by: Tyrone Ting
> Signed-off-by: Havard Skinnemoen
Acked-by: Joel Stanley
> ---
> default-configs/arm-softmmu.mak | 1 +
Thanks a lot for the reply.
But from the cmdline of qemu, we can see as following, libvirt passed "-device"
option with "ide-hd, bus=ide.0" to qemu. I am wondering why qemu received this
option, but it is still dealing it as scsi bus device instead of ide bus
device, since with "lssci" cmd,
From: Liao Pingfang
We need install qemu-[qmp/ga]-ref.* files into the subdirectory of qemu docs:
interop.
If we visit the following address and click the link to qemu-qmp-ref.html:
https://www.qemu.org/docs/master/interop/bitmaps.html#basic-qmp-usage
It will report following error:
"
Not
On Thu, May 21, 2020 at 12:21 PM Havard Skinnemoen
wrote:
> This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to
> boot
> a minimal Linux kernel. This includes device models for:
>
Does anyone have comments on this series? I'm currently finishing up a
second patch series
On 6/6/20 3:18 AM, Vladimir Sementsov-Ogievskiy wrote:
Add class for bitmap extension and dump its fields. Further work is to
dump bitmap directory.
Test new functionality inside 291 iotest.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Andrey Shinkevich
---
@@ -88,6 +90,8 @@
Patchew URL:
https://patchew.org/QEMU/20200608164357.25065-1-filip.boz...@syrmia.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200608164357.25065-1-filip.boz...@syrmia.com
Subject: [PATCH v2 0/6] Add strace support for
On 6/6/20 3:18 AM, Vladimir Sementsov-Ogievskiy wrote:
We are going to introduce more Qcow2 structure types, defined like
QcowHeader. Move generic functionality into base class to be reused for
further structure classes.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Andrey
On Mon, 8 Jun 2020 at 10:44, Alex Bennée wrote:
> > +static void tcg_region_tree_reset_all(tb_destroy_func tb_destroy)
> > {
> > size_t i;
> >
> > @@ -510,6 +519,10 @@ static void tcg_region_tree_reset_all(void)
> > for (i = 0; i < region.n; i++) {
> > struct tcg_region_tree
On 6/6/20 3:17 AM, Vladimir Sementsov-Ogievskiy wrote:
We are going to enhance qcow2 format parsing by adding more structure
classes. Let's split format parsing from utility code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/qcow2.py| 160
Joseph Myers writes:
> On Mon, 8 Jun 2020, Alex Bennée wrote:
>
>> > +uint8_t old_flags = save_exception_flags(env);
>>
>> Hmm where did this come from:
>
> This series assumes all my other recent x87 fixes (11 such patches in
> three series that aren't yet on master, there's also a
On 6/6/20 3:17 AM, Vladimir Sementsov-Ogievskiy wrote:
Add classic heading, which is missing here. Keep copyright place empty,
for anyone who have added (or will add) some intellectual property
here.
It's not so much intellectual property (since that term is at odds with
open source), but
On 6/6/20 3:17 AM, Vladimir Sementsov-Ogievskiy wrote:
Fix flake8 complaints. Leave the only chunk of lines over 79 characters:
Stale sentence since you fixed that; on my Fedora 32 machine, with
flake8 3.7.7, this patch silences all warnings.
initialization of cmds variable. Leave it for
This series fixes couple of issues with recent topology related code.
1. Fix uninitialized memory with -device and CPU hotplug
2. Simplify CPUID_8000_001E to generalize the support for higher
number of cores and nodes
Here are the threads discussing the issue.
Noticed the following command failure while testing CPU hotplug.
$ qemu-system-x86_64 -machine q35,accel=kvm -smp 1,maxcpus=2,
cores=1, threads=1,sockets=2 -cpu EPYC -device EPYC-x86_64-
cpu,core-id=0,socket-id=1,thread-id=0
qemu-system-x86_64: -device
apic_id contains all the information required to build
CPUID_8000_001E. core_id and node_id is already part of
apic_id generated by x86_topo_ids_from_apicid_epyc.
Also remove the restriction on number bits on core_id and
node_id.
Remove all the hardcoded values and replace with generalized
On 5/29/20 9:06 AM, Cindy Lu wrote:
From: Tiwei Bie
The original author is Tiwei Bie...
Currently we have 2 types of vhost backends in QEMU: vhost kernel and
vhost-user. The above patch provides a generic device for vDPA purpose,
this vDPA device exposes to user space a non-vendor-specific
On Mon, 8 Jun 2020 at 09:39, Alex Bennée wrote:
> > -static void finish_switch_fiber(void *fake_stack_save)
> > +/* QEMU_ALWAYS_INLINE only does so if __OPTIMIZE__, so we cannot use it. */
> > +static inline __attribute__((always_inline))
> > +void on_new_fiber(CoroutineUContext *co)
> > +{
>
>
Depending on the granularity of holes and amount of metadata consumed
by a file, the 'disk size:' number of 'qemu-img info' is not reliable.
Adjust our test to use a different set of filters to avoid spurious
failures.
Reported-by: Kevin Wolf
Fixes: cf2d1203dc
Signed-off-by: Eric Blake
---
Am Mon, 8 Jun 2020 18:00:31 +0200
schrieb Philippe Mathieu-Daudé :
> This code hasn't been QOM'ified yet. Warn the user.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/m68k/mcf5206.c | 5 +
> hw/m68k/mcf5208.c | 3 +++
> 2 files changed, 8 insertions(+)
>
> diff --git
On 6/8/20 1:08 AM, Klaus Jensen wrote:
> On Jun 5 11:10, Andrzej Jakowski wrote:
>> So far it was not possible to have CMB and PMR emulated on the same
>> device, because BAR2 was used exclusively either of PMR or CMB. This
>> patch places CMB at BAR4 offset so it not conflicts with MSI-X
On 6/8/20 9:06 AM, Philippe Mathieu-Daudé wrote:
> When compiling with GCC 10 (Fedora 32) using CFLAGS=-O2 we get:
>
> CC or1k-softmmu/hw/openrisc/openrisc_sim.o
> hw/openrisc/openrisc_sim.c: In function ‘openrisc_sim_init’:
> hw/openrisc/openrisc_sim.c:87:42: error: ‘cpu_irqs[0]’
On 6/8/20 5:53 AM, LIU Zhiwei wrote:
> Hi Richard,
>
> I am doing bfloat16 support on QEMU.
>
> Once I tried to reuse float32 interface, but I couldn't properly process
> rounding in some insns like fadd.
>
> What's your opinion about it? Should I expand the fpu/softfloat?
Yes, we need to
On 6/8/20 2:17 PM, Kevin Wolf wrote:
Am 21.05.2020 um 21:21 hat Eric Blake geschrieben:
Add a new test covering the 'qemu-img bitmap' subcommand, as well as
'qemu-img convert --bitmaps', both added in recent patches.
Signed-off-by: Eric Blake
Reviewed-by: Max Reitz
Reviewed-by: Vladimir
On Mon, Jun 8, 2020 at 7:28 PM Fred Konrad wrote:
>
>
>
> Le 6/8/20 à 7:21 PM, Philippe Mathieu-Daudé a écrit :
> > The UART is present on the chipset regardless there is a
> > character device connected to it. Map it unconditionally.
> >
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> >
On Mon, Jun 8, 2020 at 7:21 PM Philippe Mathieu-Daudé wrote:
>
> NIAGARA_UART_BASE is already defined few lines earlier.
>
> Signed-off-by: Philippe Mathieu-Daudé
Thanks!
Reviewed-by: Artyom Tarasenko
> ---
> hw/sparc64/niagara.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
On Mon, Jun 8, 2020 at 7:21 PM Philippe Mathieu-Daudé wrote:
>
> The UART is present on the machine regardless there is a
> character device connected to it. Map it unconditionally.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Artyom Tarasenko
> ---
> hw/sparc64/niagara.c | 6
Am 08.06.2020 um 21:08 hat Eric Blake geschrieben:
> For now, we don't have persistent bitmaps in any other formats, but
> that might not be true in the future. Make it obvious that our
> incoming parameter is not necessarily a qcow2 image, and therefore is
> limited to just the
Am 08.06.2020 um 19:33 hat Eric Blake geschrieben:
> Rather than listing block/monitor from the top-level Makefile.objs, we
> should instead list monitor from block/Makefile.objs.
>
> Suggested-by: Kevin Wolf
> Fixes: bb4e58c613
> Signed-off-by: Eric Blake
Thanks, applied to the block branch.
Am 21.05.2020 um 21:21 hat Eric Blake geschrieben:
> Add a new test covering the 'qemu-img bitmap' subcommand, as well as
> 'qemu-img convert --bitmaps', both added in recent patches.
>
> Signed-off-by: Eric Blake
> Reviewed-by: Max Reitz
> Reviewed-by: Vladimir Sementsov-Ogievskiy
This one
For now, we don't have persistent bitmaps in any other formats, but
that might not be true in the future. Make it obvious that our
incoming parameter is not necessarily a qcow2 image, and therefore is
limited to just the bdrv_dirty_bitmap_* API calls (rather than probing
into qcow2 internals).
Patchew URL:
https://patchew.org/QEMU/20200608164357.25065-1-filip.boz...@syrmia.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200608164357.25065-1-filip.boz...@syrmia.com
Subject: [PATCH v2 0/6] Add strace support for
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
tests/decode/err_pattern_group_nest1.decode | 14 ++
tests/decode/err_pattern_group_nest2.decode | 6 ++
tests/decode/err_pattern_group_nest3.decode | 14 ++
The miscellaneous control instructions are mutually exclusive
within the t32 decode sub-group.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
target/arm/t32.decode | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/t32.decode
Intended to be nested within overlapping groups.
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Suggested-by: Peter Maydell
Signed-off-by: Richard Henderson
---
scripts/decodetree.py | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git
While it makes little sense for the end product to have a group
containing only a single pattern, avoiding this case within an
incremental patch set is troublesome.
Because this is expected to be a transient condition, do not
bother "optimizing" this case, e.g. by folding away the group.
Name the current node for "inclusive" multi-pattern, in
preparation for adding a node for "exclusive" multi-pattern.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
scripts/decodetree.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
This is an edge case for sure, but the logic that disallowed
this case was faulty. Further, a few fixes scattered about
can allow this to work.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
...est1.decode => succ_pattern_group_nest2.decode} | 2 +-
scripts/decodetree.py
Create ExcMultiPattern to hold an set of non-overlapping patterns.
The body of build_tree, prop_format become member functions on this
class. Add minimal member functions to Pattern and MultiPattern
to allow recusion through the tree.
Move the bulk of build_incmulti_pattern to prop_masks and
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
scripts/decodetree.py | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 7af6b3056d..ea313bcdea 100755
---
Use proper varargs to print the arguments.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
scripts/decodetree.py | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index
This is a feature that Peter requested for completing the
neon decodetree conversion.
Changes for v3:
- Remove check for less than 2 patterns in a group.
Changes for v2:
- Rebase on master, which includes some generic python cleanups.
- Indentation error message restored.
- 4 new
Commit 93676c88 relaxed our NBD client code to request export names up
to the NBD protocol maximum of 4096 bytes without NUL terminator, even
though the block layer can't store anything longer than 4096 bytes
including NUL terminator for display to the user. Since this means
there are some export
Ever since commit 36683283 (v2.8), the server code asserts that error
strings sent to the client are well-formed per the protocol by not
exceeding the maximum string length of 4096. At the time the server
first started sending error messages, the assertion could not be
triggered, because messages
In qemu 4.2, I accidentally introduced the ability for an NBD client
obeying the specification to kill qemu as NBD server with an assertion
failure when the client requests an unusually long export name, as a
regression from the intended graceful server error message back to the
client. Given
On 200605 1956, Philippe Mathieu-Daudé wrote:
> On 6/5/20 7:40 PM, Alexander Bulekov wrote:
-cut-
> "make install-datadir"?
I think this just sets up the datadir for subsequent copies:
install-datadir:
$(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)"
The actual copy happens in install:
install:
Hi Alistair,
On 6/5/20 12:22 PM, Philippe Mathieu-Daudé wrote:
> Patches 2 & 3 fix CVE-2020-13253.
> The rest are (accumulated) cleanups.
>
> Supersedes: <20200604182502.24228-1-f4...@amsat.org>
>
> Philippe Mathieu-Daudé (11):
> MAINTAINERS: Cc qemu-block mailing list
> hw/sd/sdcard:
On 6/8/20 5:33 PM, Kevin Wolf wrote:
> Am 08.06.2020 um 17:19 hat John Snow geschrieben:
>>
>>
>> On 6/5/20 5:26 AM, Kevin Wolf wrote:
>>> Am 04.06.2020 um 22:22 hat John Snow geschrieben:
Based-on: 20200604195252.20739-1-js...@redhat.com
This series is extracted from my larger
On 6/8/20 6:54 PM, Paul Durrant wrote:
>> -Original Message-
>> From: Philippe Mathieu-Daudé
>>
>> This code hasn't been QOM'ified yet. Warn the user.
>
> "Based on today's IRC chat, this is a trivial RFC series
> to anotate pre-qdev/QOM devices so developers using them
> without knowing
Rather than listing block/monitor from the top-level Makefile.objs, we
should instead list monitor from block/Makefile.objs.
Suggested-by: Kevin Wolf
Fixes: bb4e58c613
Signed-off-by: Eric Blake
---
Makefile.objs | 2 +-
block/Makefile.objs | 1 +
2 files changed, 2 insertions(+), 1
Hello Giuseppe,
On 4/10/20 11:14 PM, LemonBoy wrote:
> From 11d0cfe58d12e0f191b435ade88622cfceb2098a Mon Sep 17 00:00:00 2001
> From: LemonBoy
> Date: Fri, 10 Apr 2020 22:55:26 +0200
> Subject: [PATCH] linux-user/sparc64: Translate flushw opcode
>
> The ifdef logic should unconditionally
Le 6/8/20 à 7:21 PM, Philippe Mathieu-Daudé a écrit :
The UART is present on the chipset regardless there is a
character device connected to it. Map it unconditionally.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/leon3.c | 18 --
1 file changed, 8 insertions(+), 10
The UART is present on the chipset regardless there is a
character device connected to it. Map it unconditionally.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc/leon3.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/hw/sparc/leon3.c
NIAGARA_UART_BASE is already defined few lines earlier.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc64/niagara.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c
index ab5ef8c5b3..201fb05d50 100644
--- a/hw/sparc64/niagara.c
+++
Few more SPARC patches.
Mark/Artyom/Frederic if you Ack them I'll simply add them
to the current trivial SPARC patch queue I prepared.
Regards,
Phil.
Philippe Mathieu-Daudé (3):
hw/sparc/leon3: Map the UART device unconditionally
hw/sparc64/niagara: Remove duplicated NIAGARA_UART_BASE
The UART is present on the machine regardless there is a
character device connected to it. Map it unconditionally.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc64/niagara.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/sparc64/niagara.c b/hw/sparc64/niagara.c
The x87 fprem and fprem1 emulation is currently based around
conversion to double, which is inherently unsuitable for a good
emulation of any floatx80 operation. Reimplement using the soft-float
floatx80 remainder operations.
Signed-off-by: Joseph Myers
Reviewed-by: Richard Henderson
---
[..]
> > Let me list some pros and cons (compared to the previous patch):
> >
> > PRO:
> > * Thanks to on/off/auto we don't override what the user specified. From
> > user interface perspective preferable. I usually hate software that
> > thinks its than me and can do the opposite I tell it.
>
Both x87 and m68k need the low parts of the quotient for their
remainder operations. Arrange for floatx80_modrem to track those bits
and return them via a pointer.
The architectures using float32_rem and float64_rem do not appear to
need this information, so the *_rem interface is left unchanged
The floatx80 remainder implementation sometimes returns the numerator
unchanged when the denominator is sufficiently larger than the
numerator. But if the value to be returned unchanged is a
pseudo-denormal, that is incorrect. Fix it to normalize the numerator
in that case.
Signed-off-by:
From: Filip Bozuta
This series covers strace support for printing arguments of following syscalls:
*acct() *lgetxattr() *removexattr() *lchown()
*fsync() *fgetxattr() *lremovexattr() *fallocate()
*fdatasync() *listxattr()
The floatx80 remainder implementation unnecessarily sets the high bit
of bSig explicitly. By that point in the function, arguments that are
invalid, zero, infinity or NaN have already been handled and
subnormals have been through normalizeFloatx80Subnormal, so the high
bit will already be set.
The m68k-specific softfloat code includes a function floatx80_mod that
is extremely similar to floatx80_rem, but computing the remainder
based on truncating the quotient toward zero rather than rounding it
to nearest integer. This is also useful for emulating the x87 fprem
and fprem1
The floatx80 remainder implementation ignores the high bit of the
significand when checking whether an operand (numerator) with zero
exponent is zero. This means it mishandles a pseudo-denormal
representation of 0x1p-16382L by treating it as zero. Fix this by
checking the whole significand
The x87 floating-point emulation of the fprem and fprem1 instructions
works via conversion to and from double. This is inherently
unsuitable for a good emulation of any floatx80 operation. This patch
series adapts the softfloat floatx80_rem implementation to be suitable
for these instructions
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: 08 June 2020 17:00
> To: qemu-devel@nongnu.org
> Cc: qemu-...@nongnu.org; Markus Armbruster ; Max Filippov
> ;
> Marcel Apfelbaum ; Peter Maydell
> ; Michael Walle
> ; Edgar E. Iglesias ; Aurelien
> Jarno
> ; Gerd Hoffmann ;
On Mon, 8 Jun 2020, Alex Bennée wrote:
> > +uint8_t old_flags = save_exception_flags(env);
>
> Hmm where did this come from:
This series assumes all my other recent x87 fixes (11 such patches in
three series that aren't yet on master, there's also a single patch for
pcmpxstrx which is
On Sat, Jun 06, 2020 at 01:32:17AM +0200, Halil Pasic wrote:
> On Wed, 20 May 2020 12:23:24 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Fri, May 15, 2020 at 12:11:55AM +0200, Halil Pasic wrote:
> > > The virtio specification tells that the device is to present
> > > VIRTIO_F_ACCESS_PLATFORM
Joseph Myers writes:
> The x87 fprem1 emulation is currently based around conversion to
> double, which is inherently unsuitable for a good emulation of any
> floatx80 operation. Reimplement using the soft-float floatx80
> remainder operations.
>
> Signed-off-by: Joseph Myers
> ---
>
From: Filip Bozuta
This patch implements strace argument printing functionality for following
syscall:
*fallocate - manipulate file space
int fallocate(int fd, int mode, off_t offset, off_t len)
man page: https://www.man7.org/linux/man-pages/man2/fallocate.2.html
From: Filip Bozuta
This patch implements strace argument printing functionality for syscall:
*lseek - reposition read/write file offset
off_t lseek(int fd, off_t offset, int whence)
man page: https://www.man7.org/linux/man-pages/man2/lseek.2.html
Implementation notes:
From: Filip Bozuta
This patch implements strace argument printing functionality for syscalls:
*chown, lchown - change ownership of a file
int chown(const char *pathname, uid_t owner, gid_t group)
int lchown(const char *pathname, uid_t owner, gid_t group)
man page:
From: Filip Bozuta
This patch implements strace argument printing functionality for following
syscalls:
*getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value
ssize_t getxattr(const char *path, const char *name, void *value,
size_t size)
ssize_t
Allow use of target-specific Kconfig file.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index aef466b0b9..6bc4fed7bd 100644
--- a/Makefile
From: Filip Bozuta
This patch implements strace argument printing functionality for following
syscalls:
*acct - switch process accounting on or off
int acct(const char *filename)
man page: https://www.man7.org/linux/man-pages/man2/acct.2.html
*fsync, fdatasync -
On 6/8/20 6:38 PM, Philippe Mathieu-Daudé wrote:
> One might get caught trying to understand unexpected Makefile
> behavior. Trailing backslash can help to split very long lines,
> but are rather dangerous when nothing follow. Preserve other
> developers debugging time by removing this one.
>
>
One might get caught trying to understand unexpected Makefile
behavior. Trailing backslash can help to split very long lines,
but are rather dangerous when nothing follow. Preserve other
developers debugging time by removing this one.
Reviewed-by: Thomas Huth
Reviewed-by: Alistair Francis
Having one entry per line helps reviews/refactors. As we are
going to modify the MINIKCONF variables, split them now to
ease further review.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile | 9 ++---
1 file changed, 6
From: Filip Bozuta
Structure "struct syscallname" in file "strace.c" is used for "-strace"
to print arguments and return values of syscalls. The last field of
this structure "result" represents the calling function that prints the
return values. This field was extended in this
Expose the CONFIG_TCG selector to let minikconf.py uses it.
When building with --disable-tcg build, this helps to deselect
devices that are TCG-dependent.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile | 1 +
accel/Kconfig | 3
Move the accel selectors from the global Kconfig.host to their
own Kconfig file.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile | 1 +
Kconfig.host | 7 ---
accel/Kconfig | 6 ++
3 files changed, 7 insertions(+), 7
From: Philippe Mathieu-Daudé
The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
probe_write() was added in there in 3b4afc9e75a to be moved out
to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
as probe_access() in c25c283df0f.
Since it is a TCG specific helper, add a
1 - 100 of 324 matches
Mail list logo
