Re: [PATCH] util: qemu_get_thread_id for OpenBSD

2020-07-14 Thread Thomas Huth
On 14/07/2020 23.26, David CARLIER wrote: > From 9c7f54c67d40fae0174ba795fbaad829cd59c264 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Tue, 14 Jul 2020 23:23:55 +0100 > Subject: [PATCH] util: qemu_get_thread_id implementation for OpenBSD. > > ussage of getthrid syscall. > >

[Bug 1886811] Re: systemd complains Failed to enqueue loopback interface start request: Operation not supported

2020-07-14 Thread Ryutaroh Matsumoto
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1887606 ** No longer affects: qemu (Ubuntu) ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Bug 1887604] [NEW] Forward host UNIX socket to guest TCP port

2020-07-14 Thread Ralph G
Public bug reported: Hello. I've been racking my brain trying to work out if this is possible. I would like to be able to forward to a guest TCP port, via a host UNIX socket to avoid opening a TCP port on the host. For example: qemu-system-i386 [...] -nic user,hostfwd=unix:/path/to/socket-:22

[PATCH] docs/nvdimm: add 'pmem=on' for the device dax backend file

2020-07-14 Thread Jingqi Liu
At the end of live migration, QEMU uses msync() to flush the data to the backend storage. When the backend file is a character device dax, the pages explicitly avoid the page cache. It will return failure from msync(). The following warning is output. "warning: qemu_ram_msync: failed to sync

Re: [RFC 05/65] target/riscv: remove vsll.vi, vsrl.vi, vsra.vi insns from using gvec

2020-07-14 Thread LIU Zhiwei
On 2020/7/14 21:59, Frank Chang wrote: On Tue, Jul 14, 2020 at 9:21 PM Richard Henderson mailto:richard.hender...@linaro.org>> wrote: On 7/13/20 7:59 PM, Frank Chang wrote: > The latest spec specified: > > Only the low *lg2(SEW) bits* are read to obtain the shift amount

Re: [PATCH-for-5.1 3/4] qemu-common: Document qemu_find_file()

2020-07-14 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年7月15日周三 上午12:48写道: > > Document qemu_find_file(), in particular the returned > value which must be freed. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang > --- > include/qemu-common.h | 14 ++ > 1 file changed, 14 insertions(+) > >

Re: [PATCH v5 04/11] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-14 Thread Havard Skinnemoen
On Tue, Jul 14, 2020 at 10:11 AM Philippe Mathieu-Daudé wrote: > > On 7/14/20 6:01 PM, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > >> +Markus > >> > >> On 7/14/20 2:44 AM, Havard Skinnemoen wrote: > >>> On Mon, Jul 13, 2020 at 8:02 AM Cédric Le Goater wrote: > >

[PATCH] ppc/spapr: Fix 32 bit logical memory block size assumptions

2020-07-14 Thread Anton Blanchard
When testing large LMB sizes (eg 4GB), I found a couple of places that assume they are 32bit in size. Signed-off-by: Anton Blanchard --- hw/ppc/spapr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index a1b06defe6..0ba2526215 100644

[PULL 18/19] python/qmp.py: add casts to JSON deserialization

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow mypy and python type hints are not powerful enough to properly describe JSON messages in Python 3.6. The best we can do, generally, is describe them as Dict[str, Any]. Add casts to coerce this type for static analysis; but do NOT enforce this type at runtime in any way. Note:

[PULL 19/19] python/qmp.py: add QMPProtocolError

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow In the case that we receive a reply but are unable to understand it, use this exception name to indicate that case. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf Message-Id: <20200710052220.3306-7-js...@redhat.com> Signed-off-by:

[PULL 15/19] iotests.py: use qemu.qmp type aliases

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow iotests.py should use the type definitions from qmp.py instead of its own. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-Id: <20200710052220.3306-3-js...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/iotests.py | 9 +++-- 1 file

[PULL 12/19] python/machine.py: re-add sigkill warning suppression

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow If the user kills QEMU on purpose, we don't need to warn them about that having happened: they know already. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Message-Id: <20200710050649.32434-12-js...@redhat.com> Signed-off-by: Philippe

[PULL 16/19] python/qmp.py: re-absorb MonitorResponseError

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow When I initially split this out, I considered this more of a machine error than a QMP protocol error, but I think that's misguided. Move this back to qmp.py and name it QMPResponseError. Convert qmp.command() to use this exception type. Signed-off-by: John Snow Reviewed-by:

[PULL 17/19] python/qmp.py: Do not return None from cmd_obj

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow This makes typing the qmp library difficult, as it necessitates wrapping Optional[] around the type for every return type up the stack. At some point, it becomes difficult to discern or remember why it's None instead of the expected object. Use the python exception system to

[PULL 13/19] python/machine.py: change default wait timeout to 3 seconds

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow Machine.wait() does not appear to be used except in the acceptance tests, and an infinite timeout by default in a test suite is not the most helpful. Change it to 3 seconds, like the default shutdown timeout. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé

[PULL 03/19] python/machine.py: Close QMP socket in cleanup

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow It's not important to do this before waiting for the process to exit, so it can be done during generic post-shutdown cleanup. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Message-Id:

[PULL 09/19] tests/acceptance: wait() instead of shutdown() where appropriate

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow When issuing 'reboot' to a VM with the no-reboot option, that VM will exit. When then issuing a shutdown command, the cleanup may race. Add calls to vm.wait() which will gracefully mark the VM as having exited. Subsequent vm.shutdown() calls in generic tearDown code will not

[PULL 14/19] python/qmp.py: Define common types

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow Define some common types that we'll need to annotate a lot of other functions going forward. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-Id: <20200710052220.3306-2-js...@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- python/qemu/qmp.py | 18

[PULL 10/19] tests/acceptance: Don't test reboot on cubieboard

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow cubieboard does not have a functioning reboot, it halts and QEMU does not exit. vm.shutdown() is modified in a forthcoming patch that makes it less tolerant of race conditions on shutdown; tests should consciously decide to WAIT or to SHUTDOWN qemu. So long as this test is

[PULL 02/19] python/machine.py: consolidate _post_shutdown()

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow Move more cleanup actions into _post_shutdown. As a change, if QEMU should so happen to be terminated during a call to wait(), that event will now be logged. This is not likely to occur during normative use. Signed-off-by: John Snow Reviewed-by: Cleber Rosa Tested-by: Cleber

[PULL 06/19] python/machine.py: Prohibit multiple shutdown() calls

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow If the VM is not launched, don't try to shut it down. As a change, _post_shutdown now unconditionally also calls _early_cleanup in order to offer comprehensive object cleanup in failure cases. As a courtesy, treat it as a NOP instead of rejecting it as an error. This is slightly

[PULL 11/19] python/machine.py: split shutdown into hard and soft flavors

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow This is done primarily to avoid the 'bare except' pattern, which suppresses all exceptions during shutdown and can obscure errors. Replace this with a pattern that isolates the different kind of shutdown paradigms (_hard_shutdown and _soft_shutdown), and a new fallback shutdown

[PULL 01/19] scripts/performance: Add dissect.py script

2020-07-14 Thread Philippe Mathieu-Daudé
From: Ahmed Karaman Python script that dissects QEMU execution into three main phases: code generation, JIT execution and helpers execution. Syntax: dissect.py [-h] -- [] \ [] [-h] - Print the script arguments help message. Example of usage: dissect.py -- qemu-arm

[PULL 07/19] python/machine.py: Add a configurable timeout to shutdown()

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow Three seconds is hardcoded. Use it as a default parameter instead, and use that value for both waits that may occur in the function. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Message-Id: <20200710050649.32434-7-js...@redhat.com>

[PULL 00/19] Python patches for 5.1

2020-07-14 Thread Philippe Mathieu-Daudé
The following changes since commit 1a53dfee92284d3016a579ef31d53367e84d9dd8: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-07-13' into staging (2020-07-14 13:52:10 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/python-next-20200714

[PULL 08/19] python/machine.py: Make wait() call shutdown()

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow At this point, shutdown(has_quit=True) and wait() do essentially the same thing; they perform cleanup without actually instructing QEMU to quit. Define one in terms of the other. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Tested-by:

[PULL 05/19] python/machine.py: Perform early cleanup for wait() calls, too

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow This is primarily for consistency, and is a step towards wait() and shutdown() sharing the same implementation so that the two cleanup paths cannot diverge. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa

[PULL 04/19] python/machine.py: Add _early_cleanup hook

2020-07-14 Thread Philippe Mathieu-Daudé
From: John Snow Some parts of cleanup need to occur prior to shutdown, otherwise shutdown might break. Move this into a suitably named method/callback. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Message-Id:

[PATCH] virtio-rng: return available data with O_NONBLOCK

2020-07-14 Thread mwilck
From: Martin Wilck If a program opens /dev/hwrng with O_NONBLOCK and uses poll() and non-blocking read() to retrieve random data, it ends up in a tight loop with poll() always returning POLLIN and read() returning EAGAIN. This repeats forever until some process makes a blocking read() call. The

[PATCH] util: qemu_get_thread_id for OpenBSD

2020-07-14 Thread David CARLIER
>From 9c7f54c67d40fae0174ba795fbaad829cd59c264 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 14 Jul 2020 23:23:55 +0100 Subject: [PATCH] util: qemu_get_thread_id implementation for OpenBSD. ussage of getthrid syscall. Signed-off-by: David Carlier --- util/oslib-posix.c | 2 ++ 1

Re: device compatibility interface for live migration with assigned devices

2020-07-14 Thread Sean Mooney
resending with full cc list since i had this typed up i would blame my email provier but my email client does not seam to like long cc lists. we probably want to continue on alex's thread to not split the disscusion. but i have responed inline with some example of how openstack schdules and

Re: device compatibility interface for live migration with assigned devices

2020-07-14 Thread Alex Williamson
On Tue, 14 Jul 2020 18:19:46 +0100 "Dr. David Alan Gilbert" wrote: > * Alex Williamson (alex.william...@redhat.com) wrote: > > On Tue, 14 Jul 2020 11:21:29 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Jul 14, 2020 at 07:29:57AM +0800, Yan Zhao wrote: > > > > hi folks, > > > > we

Re: [PATCH] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines

2020-07-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200714200439.11328-1-filip.boz...@syrmia.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200714200439.11328-1-filip.boz...@syrmia.com Subject: [PATCH] linux-user: Add

Re: [PATCH v1] util: OpenBSD build fix

2020-07-14 Thread Peter Maydell
On Tue, 14 Jul 2020 at 20:45, David CARLIER wrote: > > From e2103b86b031ab74ff4c8dd0a3944cb488c9333e Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Tue, 14 Jul 2020 21:34:59 +0100 > Subject: [PATCH] util: OpenBSD build fix. > > thread id implementation, using getthrid syscall. >

Re: device compatibility interface for live migration with assigned devices

2020-07-14 Thread Alex Williamson
On Tue, 14 Jul 2020 17:47:22 +0100 Daniel P. Berrangé wrote: > On Tue, Jul 14, 2020 at 10:16:16AM -0600, Alex Williamson wrote: > > On Tue, 14 Jul 2020 11:21:29 +0100 > > Daniel P. Berrangé wrote: > > > > > On Tue, Jul 14, 2020 at 07:29:57AM +0800, Yan Zhao wrote: > > > > > > > > The

[PATCH] hw/arm/aspeed: Add board model for Supermicro X11 BMC

2020-07-14 Thread erik-smit
Signed-off-by: erik-smit -- checkpatch was complaining about the length of aspeed_machine_supermicrox11_bmc_class_init(ObjectClass *oc, void *data) so I renamed it to aspeed_machine_smx11_bmc_class_init. Not sure if that's the right way to go, since then it's out of sync with the machine name

Re: [PATCH v4 06/11] Update PowerPC AT_HWCAP2 definition

2020-07-14 Thread Lijun Pan
> On Jul 13, 2020, at 6:47 PM, David Gibson wrote: > > On Mon, Jul 13, 2020 at 02:20:20PM -0500, Lijun Pan wrote: >> >> >>> On Jul 13, 2020, at 12:14 AM, David Gibson >>> wrote: >>> >>> On Wed, Jul 01, 2020 at 06:43:41PM -0500, Lijun Pan wrote: Add PPC2_FEATURE2_ARCH_3_10 to the

Re: [PULL 0/7] Linux user for 5.1 patches

2020-07-14 Thread Peter Maydell
is negative > (2020-07-14 09:29:14 +0200) > > ---- > linux-user branch 20200714 > > Fix strace errno management > Fix Coverity erros in ioctl straces > Fix some netlinks errors > Fix semtimedop > Applied, thanks. Please update t

[PULL 2/3] target/mips: Fix ADD.S FPU instruction

2020-07-14 Thread Philippe Mathieu-Daudé
From: Alex Richardson After merging latest QEMU upstream into our CHERI fork, I noticed that some of the FPU tests in our MIPS baremetal testsuite [*] started failing. It turns out commit 1ace099f2a accidentally changed add.s into a subtract. [*] https://github.com/CTSRD-CHERI/cheritest Fixes:

[PULL 1/3] target/mips: Remove identical if/else branches

2020-07-14 Thread Philippe Mathieu-Daudé
From: Aleksandar Markovic Remove the segment: if (other_tc == other->current_tc) { tccause = other->CP0_Cause; } else { tccause = other->CP0_Cause; } Original contributor can't remember what was his intention. Fixes: 5a25ce9487 ("mips: Hook in more reg

[PULL 0/3] MIPS patches for 5.1

2020-07-14 Thread Philippe Mathieu-Daudé
The following changes since commit 1a53dfee92284d3016a579ef31d53367e84d9dd8: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-07-13' into staging (2020-07-14 13:52:10 +0100) are available in the Git repository at: https://gitlab.com/philmd/qemu.git tags/mips-next-20200714

[PULL 3/3] MAINTAINERS: Adjust MIPS maintainership (add Huacai Chen & Jiaxun Yang)

2020-07-14 Thread Philippe Mathieu-Daudé
From: Aleksandar Markovic Huacai Chen and Jiaxun Yang step in as new energy [1]. Aurelien Jarno comment [2]: It happens that I known Huacai Chen from the time he was upstreaming the Loongson 3 support to the kernel, I have been testing and reviewing his patches. I also know Jiaxun Yang

[PATCH] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines

2020-07-14 Thread Filip Bozuta
Functions "print_ioctl()" and "print_syscall_ret_ioctl()" are used to print arguments of "ioctl()" with "-strace". These functions use "thunk_print()", which is defined in "thunk.c", to print the contents of ioctl's third arguments that are not basic types. However, this function doesn't handle

Re: [PATCH v6] scripts/simplebench: compare write request performance

2020-07-14 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 22:36, Eduardo Habkost wrote: On Tue, Jul 14, 2020 at 07:05:05PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi Eduardo! Could you please stage this in your branch, to be pulled for 5.2 later? Queued, thanks! Thank you! -- Best regards, Vladimir

[PATCH v1] util: OpenBSD build fix

2020-07-14 Thread David CARLIER
>From e2103b86b031ab74ff4c8dd0a3944cb488c9333e Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 14 Jul 2020 21:34:59 +0100 Subject: [PATCH] util: OpenBSD build fix. thread id implementation, using getthrid syscall. qemu_exec_dir implementation as beast as we can as path is not always

Re: [PATCH v6] scripts/simplebench: compare write request performance

2020-07-14 Thread Eduardo Habkost
On Tue, Jul 14, 2020 at 07:05:05PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi Eduardo! > > Could you please stage this in your branch, to be pulled for 5.2 later? Queued, thanks! > > 14.07.2020 18:50, Andrey Shinkevich wrote: > > The script 'bench_write_req.py' allows comparing

Re: [PATCH v3 4/9] host trust limitation: Rework the "memory-encryption" property

2020-07-14 Thread Richard Henderson
On 6/18/20 7:05 PM, David Gibson wrote: > Currently the "memory-encryption" property is only looked at once we get to > kvm_init(). Although protection of guest memory from the hypervisor isn't > something that could really ever work with TCG, it's not conceptually tied > to the KVM accelerator.

Re: [PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 8:13 PM, John Snow wrote: > > > On 7/14/20 12:13 AM, Cleber Rosa wrote: >> On Fri, Jul 10, 2020 at 01:06:47AM -0400, John Snow wrote: >>> This is done primarily to avoid the 'bare except' pattern, which >>> suppresses all exceptions during shutdown and can obscure errors. >>> >>>

Re: [PULL v3 00/32] AVR port

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/12/20 4:31 PM, Peter Maydell wrote: > On Sat, 11 Jul 2020 at 10:07, Philippe Mathieu-Daudé wrote: >> >> 8bit AVR port from Michael Rolnik. >> >> Michael started to work on the AVR port few years ago [*] and kept >> improving

Re: [PATCH] .travis.yml: skip ppc64abi32-linux-user with plugins

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 7:55 PM, Alex Bennée wrote: > We actually see failures on threadcount running without plugins: > > retry.py -n 1000 -c -- \ > ./ppc64abi32-linux-user/qemu-ppc64abi32 \ > ./tests/tcg/ppc64abi32-linux-user/threadcount > > which reports: > > 0: 978 times (97.80%), avg time

Re: [PATCH v5 00/16] python: add mypy support to python/qemu

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/10/20 7:22 AM, John Snow wrote: > Based-on: 20200710050649.32434-1-js...@redhat.com > > This series modifies the python/qemu library to comply with mypy --strict, > pylint, and flake8. > This requires my "refactor shutdown" patch as a pre-requisite. > [...] > > These should all 100% pass.

Re: [PATCH v3 1/9] host trust limitation: Introduce new host trust limitation interface

2020-07-14 Thread Richard Henderson
On 6/18/20 7:05 PM, David Gibson wrote: > Several architectures have mechanisms which are designed to protect guest > memory from interference or eavesdropping by a compromised hypervisor. AMD > SEV does this with in-chip memory encryption and Intel has a similar > mechanism. POWER's Protected

Re: [PULL v3] Block layer patches

2020-07-14 Thread Peter Maydell
On Mon, 13 Jul 2020 at 15:33, Kevin Wolf wrote: > > The following changes since commit 6c87d9f311dba0641bdc2df556056938a8bf2a12: > > Merge remote-tracking branch 'remotes/elmarco/tags/chardev-pull-request' > into staging (2020-07-13 09:34:24 +0100) > > are available in the Git repository at: >

Re: [PATCH v5 00/12] python/machine.py: refactor shutdown

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/10/20 7:06 AM, John Snow wrote: > v5: More or less rewritten. > > This series is motivated by a desire to move python/qemu onto a strict > mypy/pylint regime to help prevent regressions in the python codebase. > > 1. Remove the "bare except" pattern in the existing shutdown code, which >

Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza

2020-07-14 Thread John Snow
On 7/13/20 9:35 AM, Alex Bennée wrote: > > John Snow writes: > >> I'm proposing that I split the actual Python library off from the other >> miscellaneous python scripts we have and declare it maintained. Add >> myself as a maintainer of this folder, along with Cleber. >> >> Signed-off-by:

Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

2020-07-14 Thread John Snow
On 7/13/20 10:48 PM, Cleber Rosa wrote: > On Fri, Jul 10, 2020 at 01:06:42AM -0400, John Snow wrote: >> If the VM is not launched, don't try to shut it down. As a change, >> _post_shutdown now unconditionally also calls _early_cleanup in order to >> offer comprehensive object cleanup in failure

Re: [PATCH-for-5.1 3/4] qemu-common: Document qemu_find_file()

2020-07-14 Thread Peter Maydell
On Tue, 14 Jul 2020 at 17:43, Philippe Mathieu-Daudé wrote: > > Document qemu_find_file(), in particular the returned > value which must be freed. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu-common.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git

Re: [PULL 00/15] riscv-to-apply queue

2020-07-14 Thread Peter Maydell
On Tue, 14 Jul 2020 at 01:44, Alistair Francis wrote: > > The following changes since commit 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20200713-pull-request' into staging (2020-07-13 > 16:58:44 +0100) > > are available in the Git

Re: [PATCH v7 20/47] block: Iterate over children in refresh_limits

2020-07-14 Thread Andrey Shinkevich
On 25.06.2020 18:21, Max Reitz wrote: Instead of looking at just bs->file and bs->backing, we should look at all children that could end up receiving forwarded requests. Signed-off-by: Max Reitz --- block/io.c | 32 1 file changed, 16 insertions(+), 16

Re: [PATCH 1/1] python: add check-python target

2020-07-14 Thread John Snow
On 7/14/20 12:30 AM, Cleber Rosa wrote: > On Mon, Jul 13, 2020 at 09:30:26PM -0400, John Snow wrote: >> Move pylintrc and flake8 up to the root of the python folder where >> they're the most useful. Add a requirements.cqa.txt file to house >> the requirements necessary to build a venv

Re: [PATCH for-5.1] i386: hvf: Explicitly set CR4 guest/host mask

2020-07-14 Thread Paolo Bonzini
Hi Roman, please ask Peter to apply it directly because I won't be able to send a pull request in the next couple of weeks. Paolo Il mar 14 lug 2020, 12:39 Roman Bolshakov ha scritto: > On Tue, Jul 14, 2020 at 12:07:27PM +0300, Roman Bolshakov wrote: > > Removal of register reset omitted

Re: [RFC 0/3] x86: fix cpu hotplug with secure boot

2020-07-14 Thread Laszlo Ersek
On 07/10/20 18:17, Igor Mammedov wrote: > CPU hotplug with Secure Boot was not really supported and firmware wasn't > aware > of hotplugged CPUs (which might lead to guest crashes). During 4.2 we > introduced > locked SMI handler RAM arrea to make sure that guest OS wasn't able to inject > its

Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-14 Thread Igor Mammedov
On Tue, 14 Jul 2020 12:26:56 -0500 Babu Moger wrote: > > -Original Message- > > From: Igor Mammedov > > Sent: Tuesday, July 14, 2020 11:42 AM > > To: Moger, Babu > > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; ehabk...@redhat.com; > > r...@twiddle.net > > Subject: Re: [PATCH v2

Re: [PATCH v5 12/12] python/machine.py: change default wait timeout to 3 seconds

2020-07-14 Thread John Snow
On 7/14/20 12:20 AM, Cleber Rosa wrote: > On Fri, Jul 10, 2020 at 01:06:49AM -0400, John Snow wrote: >> Machine.wait() does not appear to be used except in the acceptance tests, >> and an infinite timeout by default in a test suite is not the most helpful. >> >> Change it to 3 seconds, like the

Re: [PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors

2020-07-14 Thread John Snow
On 7/14/20 12:13 AM, Cleber Rosa wrote: > On Fri, Jul 10, 2020 at 01:06:47AM -0400, John Snow wrote: >> This is done primarily to avoid the 'bare except' pattern, which >> suppresses all exceptions during shutdown and can obscure errors. >> >> Replace this with a pattern that isolates the

RE: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dependent on VM state

2020-07-14 Thread Sunil Muthuswamy
> > > > Thanks. Ok, I am setup with GPG. Where should I be sending the pull > > requests to? Who is "Peter"? Do I have to send it to you? > > Peter is Peter Maydell, but for now you can send them to me. I'll get > round to documenting the remaining steps. > > Unfortunately all the scripts I

Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls

2020-07-14 Thread John Snow
On 7/13/20 10:48 PM, Cleber Rosa wrote: > On Fri, Jul 10, 2020 at 01:06:42AM -0400, John Snow wrote: >> If the VM is not launched, don't try to shut it down. As a change, >> _post_shutdown now unconditionally also calls _early_cleanup in order to >> offer comprehensive object cleanup in failure

[PATCH] fuzz: Expect the cmdline in a freeable GString

2020-07-14 Thread Alexander Bulekov
In the initial FuzzTarget, get_init_cmdline returned a char *. With this API, we had no guarantee about where the string came from. For example, i440fx-qtest-reboot-fuzz simply returned a pointer to a string literal, while the QOS-based targets build the arguments out in a GString an return the

Re: [PATCH] tests: qmp-cmd-test: fix memory leak

2020-07-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200714171531.83723-1-liq...@163.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] fuzz: Expect the cmdline in a freeable GString

2020-07-14 Thread Darren Kenny
On Tuesday, 2020-07-14 at 13:46:16 -04, Alexander Bulekov wrote: > In the initial FuzzTarget, get_init_cmdline returned a char *. With this > API, we had no guarantee about where the string came from. For example, > i440fx-qtest-reboot-fuzz simply returned a pointer to a string literal, > while

[PATCH] .travis.yml: skip ppc64abi32-linux-user with plugins

2020-07-14 Thread Alex Bennée
We actually see failures on threadcount running without plugins: retry.py -n 1000 -c -- \ ./ppc64abi32-linux-user/qemu-ppc64abi32 \ ./tests/tcg/ppc64abi32-linux-user/threadcount which reports: 0: 978 times (97.80%), avg time 0.270 (0.01 varience/0.08 deviation) -6: 21 times

Re: [PATCH v3 1/2] tpm: tpm_spapr: Exit on TPM backend failures

2020-07-14 Thread Marc-André Lureau
Hi On Wed, Jul 8, 2020 at 12:17 AM Stefan Berger wrote: > Exit on TPM backend failures in the same way as the TPM CRB and TIS device > models do. With this change we now get an error report when the backend > did not start up properly: > > error: internal error: qemu unexpectedly closed the

Re: [PATCH for 5.1] crypto: use a stronger private key for tests

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 7:37 PM, Daniel P. Berrangé wrote: > The unit tests using the x509 crypto functionality have started > failing in Fedora 33 rawhide with a message like > > The certificate uses an insecure algorithm > > This is result of Fedora changes to support strong crypto [1]. RSA > with

RE: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-14 Thread Babu Moger
> -Original Message- > From: Igor Mammedov > Sent: Tuesday, July 14, 2020 11:42 AM > To: Moger, Babu > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; ehabk...@redhat.com; > r...@twiddle.net > Subject: Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from > CpuInstanceProperties > >

[PATCH for 5.1] crypto: use a stronger private key for tests

2020-07-14 Thread Daniel P . Berrangé
The unit tests using the x509 crypto functionality have started failing in Fedora 33 rawhide with a message like The certificate uses an insecure algorithm This is result of Fedora changes to support strong crypto [1]. RSA with 1024 bit key is viewed as legacy and thus insecure. Generate a

Re: [PATCH 0/2] Add list_fn_callees.py and list_helpers.py scripts

2020-07-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200714164156.9353-1-ahmedkhaledkara...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200714164156.9353-1-ahmedkhaledkara...@gmail.com Subject: [PATCH 0/2] Add

Re: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak

2020-07-14 Thread Philippe Mathieu-Daudé
Cc'ing Marc-André On 7/14/20 6:49 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200714162234.13113-1-vsement...@virtuozzo.com/ ... > > TESTiotest-qcow2: 022 > TESTcheck-unit: tests/test-char > ** >

Re: device compatibility interface for live migration with assigned devices

2020-07-14 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 14 Jul 2020 11:21:29 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Jul 14, 2020 at 07:29:57AM +0800, Yan Zhao wrote: > > > hi folks, > > > we are defining a device migration compatibility interface that helps > > > upper > > >

Re: [PATCH] hmp: fix memory leak in qom_composition_compare()

2020-07-14 Thread Li Qiang
Philippe Mathieu-Daudé 于2020年7月15日周三 上午12:47写道: > > On 7/14/20 5:11 PM, Li Qiang wrote: > > While 'make chekc', I got following error: > > > > root@ubuntu:~/qemu# ./tests/qtest/device-introspect-test > > /x86_64/device/introspect/list: OK > > /x86_64/device/introspect/list-fields: OK > >

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 6:21 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> + qemu-block experts. >> >> On 7/14/20 11:16 AM, Markus Armbruster wrote: >>> Havard Skinnemoen writes: >>> On Mon, Jul 13, 2020 at 7:57 AM Cédric Le Goater wrote: > > On 7/9/20 2:36 AM, Havard

[PATCH] tests: qmp-cmd-test: fix memory leak

2020-07-14 Thread Li Qiang
Fixes: 5b88849e7b9("tests/qmp-cmd-test: Add qmp/object-add-failure-modes" Signed-off-by: Li Qiang --- tests/qtest/qmp-cmd-test.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c index c68f99f659..f7b1aa7fdc 100644 ---

Re: [PATCH v5 04/11] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 6:01 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> +Markus >> >> On 7/14/20 2:44 AM, Havard Skinnemoen wrote: >>> On Mon, Jul 13, 2020 at 8:02 AM Cédric Le Goater wrote: On 7/9/20 2:36 AM, Havard Skinnemoen wrote: > The Nuvoton NPCM7xx SoC family

Re: [PATCH for 5.1] docs: fix trace docs build with sphinx 3.1.1

2020-07-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200714162659.1017432-1-berra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: sysbus_create_simple Vs qdev_create

2020-07-14 Thread Philippe Mathieu-Daudé
Hi Pratik, On 7/14/20 6:17 PM, Pratik Parvati wrote: > Here is a brief context that might help you. > I am referring hw/arm/versatilepb.c > > The ARM PrimeCell UART (PL011) device created as follows > > |dev = qdev_create(NULL, "pl011"); s = SYS_BUS_DEVICE(dev); > qdev_prop_set_chr(dev,

Re: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak

2020-07-14 Thread Vladimir Sementsov-Ogievskiy
14.07.2020 19:49, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200714162234.13113-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can

Re: [PULL 0/3] Migration patches

2020-07-14 Thread Peter Maydell
On Mon, 13 Jul 2020 at 18:55, Juan Quintela wrote: > > The following changes since commit 9f526fce49c6ac48114ed04914b5a76e4db75785: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-misc-110720-2' into staging > (2020-07-12 15:32:05 +0100) > > are available in the Git

Re: [PATCH for 5.1] docs: fix trace docs build with sphinx 3.1.1

2020-07-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200714162659.1017432-1-berra...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak

2020-07-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200714162234.13113-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH] hmp: fix memory leak in qom_composition_compare()

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 5:11 PM, Li Qiang wrote: > While 'make chekc', I got following error: > > root@ubuntu:~/qemu# ./tests/qtest/device-introspect-test > /x86_64/device/introspect/list: OK > /x86_64/device/introspect/list-fields: OK > /x86_64/device/introspect/none: >

Re: device compatibility interface for live migration with assigned devices

2020-07-14 Thread Daniel P . Berrangé
On Tue, Jul 14, 2020 at 10:16:16AM -0600, Alex Williamson wrote: > On Tue, 14 Jul 2020 11:21:29 +0100 > Daniel P. Berrangé wrote: > > > On Tue, Jul 14, 2020 at 07:29:57AM +0800, Yan Zhao wrote: > > > > > > The string read from migration_version attribute is defined by device > > > vendor > > >

[PATCH-for-5.1 3/4] qemu-common: Document qemu_find_file()

2020-07-14 Thread Philippe Mathieu-Daudé
Document qemu_find_file(), in particular the returned value which must be freed. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu-common.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index d0142f29ac..d6a08259d3 100644

Re: [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree"

2020-07-14 Thread Philippe Mathieu-Daudé
On 7/14/20 6:01 PM, Markus Armbruster wrote: > Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted" > created a memory leak, because I didn't realize > object_get_canonical_path_component()'s value needs to be freed. > > Reproducer: > > $ qemu-system-x86_64 -nodefaults -display

[PATCH 2/2] scripts/performance: Add list_helpers.py script

2020-07-14 Thread Ahmed Karaman
Python script that prints executed helpers of a QEMU invocation. Syntax: list_helpers.py [-h] -- \ [] \ [] [-h] - Print the script arguments help message. Example of usage: list_helpers.py -- qemu-mips coulomb_double-mips -n10 Example output: Total number of

[PATCH-for-5.1 1/4] qemu/osdep: Document os_find_datadir() return value

2020-07-14 Thread Philippe Mathieu-Daudé
Document os_find_datadir() returned data must be freed. Signed-off-by: Philippe Mathieu-Daudé --- os-posix.c | 3 +++ os-win32.c | 7 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/os-posix.c b/os-posix.c index b674b20b1b..3572db3f44 100644 --- a/os-posix.c +++

[PATCH-for-5.1 4/4] hw/avr/boot: Fix memory leak in avr_load_firmware()

2020-07-14 Thread Philippe Mathieu-Daudé
The value returned by qemu_find_file() must be freed. This fixes Coverity issue CID 1430449, which points out that the memory returned by qemu_find_file() is leaked. Fixes: Coverity CID 1430449 (RESOURCE_LEAK) Fixes: 7dd8f6fde4 ('hw/avr: Add support for loading ELF/raw binaries') Signed-off-by:

[PATCH 1/2] scripts/performance: Add list_fn_callees.py script

2020-07-14 Thread Ahmed Karaman
Python script that prints the callees of a given list of QEMU functions. Syntax: list_fn_callees.py [-h] -f FUNCTION [FUNCTION ...] -- \ [] \ [] [-h] - Print the script arguments help message. -f FUNCTION [FUNCTION ...] - List of function names Example of usage:

[PATCH-for-5.1 0/4] misc: Document qemu_find_file and fix memory leak in avr_load_firmware

2020-07-14 Thread Philippe Mathieu-Daudé
Fix the memory leak reported by Coverity (CID 1430449). Philippe Mathieu-Daudé (4): qemu/osdep: Document os_find_datadir() return value qemu/osdep: Reword qemu_get_exec_dir() documentation qemu-common: Document qemu_find_file() hw/avr/boot: Fix memory leak in avr_load_firmware()

Re: [PATCH v2 1/3] hw/i386: Initialize topo_ids from CpuInstanceProperties

2020-07-14 Thread Igor Mammedov
On Mon, 13 Jul 2020 14:30:29 -0500 Babu Moger wrote: > > -Original Message- > > From: Igor Mammedov > > Sent: Monday, July 13, 2020 12:32 PM > > To: Moger, Babu > > Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; qemu- > > de...@nongnu.org > > Subject: Re: [PATCH v2

[PATCH 0/2] Add list_fn_callees.py and list_helpers.py scripts

2020-07-14 Thread Ahmed Karaman
Hi, This series adds the two new scripts introduced in report 4 of the "TCG Continuous Benchmarking" GSoC project. "list_fn_callees.py" is used for printing the callees of a given list of QEMU functions. "list_helpers.py" is used for printing the executed helpers of a QEMU invocation. To learn

[PATCH-for-5.1 2/4] qemu/osdep: Reword qemu_get_exec_dir() documentation

2020-07-14 Thread Philippe Mathieu-Daudé
This comment is confuse, reword it a bit. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/osdep.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 979a403984..a96849dd90 100644 --- a/include/qemu/osdep.h +++

  1   2   3   >