On 2020/8/19 上午11:30, Yan Zhao wrote:
hi All,
could we decide that sysfs is the interface that every VFIO vendor driver
needs to provide in order to support vfio live migration, otherwise the
userspace management tool would not list the device into the compatible
list?
if that's true, let's mo
> From: Jason Wang
> Sent: Wednesday, August 19, 2020 12:19 PM
>
>
> On 2020/8/19 下午1:26, Parav Pandit wrote:
> >
> >> From: Jason Wang
> >> Sent: Wednesday, August 19, 2020 8:16 AM
> >
> >> On 2020/8/18 下午5:32, Parav Pandit wrote:
> >>> Hi Jason,
> >>>
> >>> From: Jason Wang
> >>> Sent: Tue
The mcf5206 system integration module should be a proper device.
Let's finally QOMify it.
Signed-off-by: Thomas Huth
---
hw/m68k/an5206.c | 14 --
hw/m68k/mcf5206.c | 44 ++-
include/hw/m68k/mcf.h | 3 +--
3 files changed, 48 insertio
On 2020/8/19 下午1:26, Parav Pandit wrote:
From: Jason Wang
Sent: Wednesday, August 19, 2020 8:16 AM
On 2020/8/18 下午5:32, Parav Pandit wrote:
Hi Jason,
From: Jason Wang
Sent: Tuesday, August 18, 2020 2:32 PM
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at 11:24:3
Due to 1.14 release being delayed it missed qemu 5.1.
The last snapshot has all code changes though, so this
changes only the version string in the binaries.
shortlog
Kevin O'Connor (1):
docs: Note v1.14.0 release
Signed-off-by: Gerd Hoffmann
---
pc-bios/bios-256k.bin
The following changes since commit 672b2f2695891b6d818bddc3ce0df964c7627969:
Open 5.2 development tree (2020-08-18 13:44:04 +0100)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/seabios-20200819-pull-request
for you to fetch changes up to c180ff4c7946cab99dcfdf3d2579
Patchew URL: https://patchew.org/QEMU/20200819061110.1320568-1-alx...@bu.edu/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200819061110.1320568-1-alx...@bu.edu
Subject: [PATCH v2 00/15] Add a General Virtual Device
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 29 --
v5:
* removed hanging dlfcn include from v3
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
--
2.20.1
v4:
Use a bottom handler for shutdown as suggested by Gerd Hoffman
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 30 +-
configure | 4 +++-
2 files changed, 24 insertions(+), 10 deletions(-)
--
2.20.1
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 30 +-
v2:
- Remove QOS dependency.
- Add a custom crossover function
- Fix broken minimization scripts
- Fixes to the IO region and DMA handling code
This is a general virtual-device fuzzer, designed to fuzz devices over Port IO,
MMIO, and DMA.
To get started with this:
SRU need the bug 1890881 fix to be really helpful, but the dependency chain of
that is not SRUable.
See: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1890881/comments/17
Users (of this valid but rare use case) can either use Groovy which will
fix this or wait until Openstack Victoria will
Build general-fuzzer wrappers for each configuration defined in
general_fuzzer_configs.yml and move the actual general-fuzzer to a
subdirectory, so oss-fuzz doesn't treat it as a standalone fuzzer.
Signed-off-by: Alexander Bulekov
---
scripts/oss-fuzz/build.sh | 8 +++-
scr
This parses a yaml file containing general-fuzzer configs and builds a
separate oss-fuzz wrapper binary for each one, changing some
preprocessor macros for each configuration. To avoid dealing with
escaping and stringifying, convert each string into a byte-array
representation
Signed-off-by: Alexa
Once we find a crash, we can convert it into a QTest trace. Usually this
trace will contain many operations that are unneeded to reproduce the
crash. This script tries to minimize the crashing trace, by removing
operations and trimming QTest bufwrite(write addr len data...) commands.
Signed-off-by
The general-fuzzer uses hooks to fulfill DMA requests just-in-time.
This means that if we try to use QTEST_LOG=1 to build a reproducer, the
DMA writes will be logged _after_ the in/out/read/write that triggered
the DMA read. To work work around this, the general-fuzzer annotates
these just-in time
libfuzzer supports a "custom crossover function". Libfuzzer often tries
to blend two inputs to create a new interesting input. Sometimes, we
have a better idea about how to blend inputs together. This change
allows fuzzers to specify a custom function for blending two inputs
together.
Signed-off-b
On oss-fuzz we need some sort of wrapper to specify command-line
arguments or environment variables. When we had a similar problem with
other targets that I fixed with
05509c8e6d ("fuzz: select fuzz target using executable name")
by selecting the fuzz target based on the executable's name. In the
f
We should be careful to not call any functions besides fuzz_dma_read_cb.
Without --enable-fuzzing, fuzz_dma_read_cb is an empty inlined function.
Signed-off-by: Alexander Bulekov
---
exec.c| 2 ++
include/exec/memory.h | 1 +
include/exec/memory_ld
Each of these entries is built into a wrapper binary that sets the
needed environment variables and executes the general virtual-device
fuzzer. In the future, we will need additional fields, such as arch=arm,
timeout_per_testcase=0, reset=reboot, etc...
Signed-off-by: Alexander Bulekov
---
scrip
This patch compares TYPE_PCI_DEVICE objects against the user-provided
matching pattern. If there is a match, we use some hacks and leverage
QOS to map each possible BAR for that device. Now fuzzed inputs might be
converted to pci_read/write commands which target specific. This means
that we can fuz
Signed-off-by: Alexander Bulekov
---
tests/qtest/fuzz/general_fuzz.c | 81 -
1 file changed, 80 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/fuzz/general_fuzz.c b/tests/qtest/fuzz/general_fuzz.c
index 26fcd69e45..2c3716f8cc 100644
--- a/tests/qtest/fuzz/g
This patch declares the fuzz_dma_read_cb function and uses the
preprocessor and linker(weak symbols) to handle these cases:
When we build softmmu/all with --enable-fuzzing, there should be no
strong symbol defined for fuzz_dma_read_cb, and we link against a weak
stub function.
When we build softm
This new operation is used in the next commit, which concatenates two
fuzzer-generated inputs. With this operation, we can prevent the second
input from clobbering the PCI configuration performed by the first.
Signed-off-by: Alexander Bulekov
---
tests/qtest/fuzz/general_fuzz.c | 13 +++-
Telling QTest to log to /dev/fd/2, essentially results in dup(2). This
is fine, if other code isn't logging to stderr. Otherwise, the order of
the logs is mixed due to buffering issues, since two file-descriptors
are used to write to the same file. We can avoid this, since just
specifying "-qtest"
This is a generic fuzzer designed to fuzz a virtual device's
MemoryRegions, as long as they exist within the Memory or Port IO (if it
exists) AddressSpaces. The fuzzer's input is interpreted into a sequence
of qtest commands (outb, readw, etc). The interpreted commands are
separated by a magic seap
When a virtual-device tries to access some buffer in memory over DMA, we
add call-backs into the fuzzer(next commit). The fuzzer checks verifies
that the DMA request maps to a physical RAM address and fills the memory
with fuzzer-provided data. The patterns that we use to fill this memory
are speci
Hi,
> > > schedule a bottom half calling qjack_client_fini()
> >
> > Does QEMU have such a mechanism for doing this?
>
> There could also be a possible race here if `jack_client_connect` is called
> before the scheduled shutdown takes place.
You can cancel a scheduled bottom half, and checkin
Hi,
> > > Have another small question. Do you know how force show cursor working
> > > in this case?
> >
> > Which display and which vga do you use?
>
> -vga std \
So stdvga (has no hardware cursor support).
display not specified, so it is the default.
i.e. gtk or sdl depending on what config
> From: Yan Zhao
> Sent: Wednesday, August 19, 2020 9:01 AM
> On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote:
> > Please refer to my previous email which has more example and details.
> hi Parav,
> the example is based on a new vdpa tool running over netlink, not based on
> devli
From: César Belley
This patch adds the U2F key base class implementation.
The U2F key base mainly takes care of the HID interfacing with guest.
On the one hand, it retrieves the guest U2FHID packets and transmits
them to the variant associated according to the mode: pass-through
or emulated.
On
From: César Belley
Add USB U2F key device documentation:
- USB U2F key device
- Building
- Using u2f-emulated
- Using u2f-passthru
- Libu2f-emu
Signed-off-by: César Belley
Message-id: 20200812094135.20550-3-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
docs/u2f.txt | 101
From: César Belley
This patch adds the U2F key emulated mode.
The emulated mode consists of completely emulating the behavior of a
U2F device through software part. Libu2f-emu is used for that.
The emulated mode is associated with a device inheriting from
u2f-key base.
To work, an emulated U2F
To fully work this also needs the fix for bug 1890881 as identified
there.
** Changed in: qemu (Ubuntu Focal)
Status: New => Triaged
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1886811
Titl
From: César Belley
This patch adds the specification for the U2F key base class.
Used to group the common characteristics, this device class will be
inherited by its two variants, corresponding to the two modes:
passthrough and emulated
This prepares the U2F devices hierarchy which is as follow:
From: César Belley
This patch adds the U2F key pass-through mode.
The pass-through mode consists of passing all requests made from the
guest to the physical security key connected to the host machine and
vice versa.
In addition, the dedicated pass-through allows to have a U2F security key
share
The following changes since commit d0ed6a69d399ae193959225cdeaa9382746c91cc:
Update version for v5.1.0 release (2020-08-11 17:07:03 +0100)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/usb-20200819-pull-request
for you to fetch changes up to d7e5b2e1a4035fb81517a203
From: César Belley
This patchs adds a check to verify that the device passed through the
hidraw property is a U2F device.
The check is done by ensuring that the first values of the report
descriptor (USAGE PAGE and USAGE) correspond to those of a U2F device.
Signed-off-by: César Belley
Message
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-8-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
hw/usb/Kconfig | 5 +
hw/usb/Makefile.objs | 7 +++
2 files changed, 12 insertions(+)
diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index 5
From: César Belley
This patch adds an autoscan to let u2f-passthru choose the first U2F
device it finds.
The autoscan is performed using libudev with an enumeration of all the
hidraw devices present on the host.
The first device which happens to be a U2F device is taken to do the
pass-through.
From: César Belley
Group some HID values that are used pretty much everywhere when
dealing with HID devices.
Signed-off-by: César Belley
Message-id: 20200812094135.20550-2-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
include/hw/usb/hid.h | 17 +
hw/usb/dev-hid.c
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-9-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
configure | 27 +++
1 file changed, 27 insertions(+)
diff --git a/configure b/configure
index 2acc4d1465f8..3ea5e561ff43 100755
We have a tracepoint at the same place which can be enabled if needed.
Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236
Signed-off-by: Gerd Hoffmann
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20200722072613.10390-1-kra...@redhat.com>
---
hw/usb/hcd-ehci.c | 1 -
1 file change
From: Li Qiang
If 'usb_packet_map' fails, we should stop to process the usb
request.
Signed-off-by: Li Qiang
Message-Id: <20200812161727.29412-1-liq...@163.com>
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ehci.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-11-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
docs/qdev-device-use.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt
index f8d0d2fe297a..988
From: César Belley
This patch adds the script used to generate setup directories, needed
for the device u2f-emulated configuration in directory mode:
python u2f-setup-gen.py $DIR
qemu -usb -device u2f-emulated,dir=$DIR
Signed-off-by: César Belley
Message-id: 20200812094135.20550-12-ces
On Wed, Aug 12, 2020 at 11:41:22AM +0200, César Belley wrote:
> This patch series adds the U2F dedicated support to Qemu through a USB
> U2F key device that can operate in two modes: pass-through and emulated.
>
> This work is also part of the GSoC program of this year and follows the
> proposal
From: Li Qiang
Currently we don't check the return value of 'usb_packet_map',
this will cause an UAF issue. This is LP#1891341.
Following is the reproducer provided in:
-->https://bugs.launchpad.net/qemu/+bug/1891341
cat << EOF | ./i386-softmmu/qemu-system-i386 -device nec-usb-xhci \
-trace usb\
From: Li Qiang
This may cause resource leak.
Signed-off-by: Li Qiang
Message-Id: <20200812161712.29361-1-liq...@163.com>
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-ehci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 1495e8f7fab1..58cceacbf83
From: César Belley
Signed-off-by: César Belley
Message-id: 20200812094135.20550-10-cesar.bel...@lse.epita.fr
Signed-off-by: Gerd Hoffmann
---
docs/system/usb.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/system/usb.rst b/docs/system/usb.rst
index ddfa828d74ae..9a2f1927c451 10
Hi,
> > schedule a bottom half calling qjack_client_fini()
>
> Does QEMU have such a mechanism for doing this?
Yes, look for QEMUBH in include/qemu/main-loop.h
HTH,
Gerd
On 2020-08-19 15:28, Geoffrey McRae wrote:
On 2020-08-19 15:04, Gerd Hoffmann wrote:
Hi,
As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup"
routine
that JACK1 does not have, we need to determine which version is in
use
at runtime. Unfortunatly there is no way to determine which i
On 2020-08-19 15:04, Gerd Hoffmann wrote:
Hi,
As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine
that JACK1 does not have, we need to determine which version is in use
at runtime. Unfortunatly there is no way to determine which is in use
other then to look for symbols that a
> From: Jason Wang
> Sent: Wednesday, August 19, 2020 8:16 AM
> On 2020/8/18 下午5:32, Parav Pandit wrote:
> > Hi Jason,
> >
> > From: Jason Wang
> > Sent: Tuesday, August 18, 2020 2:32 PM
> >
> >
> > On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
> > On Tue, Aug 18, 2020 at 11:24:30AM +0800, J
On 2020-08-19 14:46, Philippe Mathieu-Daudé wrote:
On 8/19/20 5:36 AM, Geoffrey McRae wrote:
On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
The client may have been freed already by a secondary audio device
recovering its session
Hi,
> As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine
> that JACK1 does not have, we need to determine which version is in use
> at runtime. Unfortunatly there is no way to determine which is in use
> other then to look for symbols that are missing in JACK1, which in this
On 8/19/20 5:36 AM, Geoffrey McRae wrote:
>
>
> On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
>> Hi Geoffrey,
>>
>> On 8/19/20 3:18 AM, Geoffrey McRae wrote:
>>> The client may have been freed already by a secondary audio device
>>> recovering its session as JACK2 has some cleanup code to wo
On Tue, Aug 18, 2020 at 09:39:24AM +, Parav Pandit wrote:
> Hi Cornelia,
>
> > From: Cornelia Huck
> > Sent: Tuesday, August 18, 2020 3:07 PM
> > To: Daniel P. Berrangé
> > Cc: Jason Wang ; Yan Zhao
> > ; k...@vger.kernel.org; libvir-l...@redhat.com;
> > qemu-devel@nongnu.org; Kirti Wankhede
On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
The client may have been freed already by a secondary audio device
recovering its session as JACK2 has some cleanup code to work around
broken clients, which doesn't account for well beh
On 8/18/20 11:20 PM, Sunil Muthuswamy wrote:
It's still shameful that MS is forcing developers to waste time
rewriting API headers, just because the MS legal departments are not
able to understand the needs of Open Source development.
>>> There has be a big switch from Microsoft towa
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
> The client may have been freed already by a secondary audio device
> recovering its session as JACK2 has some cleanup code to work around
> broken clients, which doesn't account for well behaved clients.
>
> https://github.com/jackaudio/jac
Hi Julia,
On 8/18/20 11:52 PM, Julia Suvorova wrote:
> Implement notifications and gpe to support q35 ACPI PCI hot-plug.
> Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports.
>
> Signed-off-by: Julia Suvorova
> ---
> include/hw/acpi/pcihp.h | 3 ++-
> hw/acpi/pcihp.c | 10 ++--
On 8/18/20 11:52 PM, Julia Suvorova wrote:
> Add trace events similar to piix4_gpe_readb() to check gpe status.
>
> Signed-off-by: Julia Suvorova
> Reviewed-by: Igor Mammedov
> ---
> hw/acpi/ich9.c | 7 ++-
> hw/acpi/trace-events | 4
> 2 files changed, 10 insertions(+), 1 deleti
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the
> start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> Note that this changes behavior by setting cs->halted to 1 on reset, which
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
> start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> This makes secondary_cpu_reset() unnecessary, so remove it.
>
> Also r
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset()
> is pointless.
>
> Suggested-by: Philippe Mathieu-Daudé
> Reviewed-by: David Gibson
> Signed-off-by: Thiago Jung Bauermann
Reviewed-by: Philippe Mathieu-Daudé
> ---
>
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
> start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> Also change creation of CPU object from cpu_create() to object_new() and
> q
On 8/19/20 4:42 AM, Thiago Jung Bauermann wrote:
> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
> the start-powered-off property which makes cpu_common_reset() initialize it
> to 1 in common code.
>
> Also change creation of CPU object from cpu_create() to object_new()
On 2020/8/18 下午5:36, Cornelia Huck wrote:
On Tue, 18 Aug 2020 10:16:28 +0100
Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote:
On 2020/8/1
On 2020/8/18 下午5:32, Parav Pandit wrote:
Hi Jason,
From: Jason Wang
Sent: Tuesday, August 18, 2020 2:32 PM
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug 18, 2020 at 11:24:30AM +0800, Jason Wang wrote:
On 2020/8/14 下午1:16, Yan Zhao wrote:
On Thu, Aug 13, 2020 at 12:24:50PM +0800
Le mar. 18 août 2020 23:30, Eduardo Habkost a écrit :
> CCing maintainer (pmaydell).
>
> On Fri, Aug 14, 2020 at 07:45:40PM +0200, Philippe Mathieu-Daudé wrote:
> > On 8/14/20 12:25 AM, Eduardo Habkost wrote:
> > > The PL1110 enum value name will conflict with the PL1110 type
> > > cast checker,
Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
Also change creation of CPU object from cpu_create() to object_new() and
qdev_realize_and_unref() because cpu_create() realizes the CPU
Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
This makes secondary_cpu_reset() unnecessary, so remove it.
Also remove setting of cs->halted from cpu_devinit(), which seems out
We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset()
is pointless.
Suggested-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
Signed-off-by: Thiago Jung Bauermann
---
hw/sparc/sun4m.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/hw/
Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
the start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
Also change creation of CPU object from cpu_create() to object_new() and
qdev_realize_and_unref() because cpu_create() realizes
This version, like the previous one, tries to fix an issue found by
David Gibson when running the Travis CI:
Unexpected error in qdev_prop_set_after_realize() at
/home/travis/build/dgibson/qemu/hw/core/qdev-properties.c:30:
qemu-system-mips64el: Attempt to set property 'start-powered-off' on anon
There are other platforms which also have CPUs that start powered off, so
generalize the start-powered-off property so that it can be used by them.
Note that ARMv7MState also has a property of the same name but this patch
doesn't change it because that class isn't a subclass of CPUState so it
woul
Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.
Note that this changes behavior by setting cs->halted to 1 on reset, which
didn't happen before.
Acked-by: Cornelia Huck
Signed-off-
This change is in a separate patch because it's not so obvious that it
won't cause a regression.
Suggested-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
Reviewed-by: Greg Kurz
Signed-off-by: Thiago Jung Bauermann
---
hw/core/cpu.c| 2 +-
target/arm/cpu
PowerPC sPAPR CPUs start in the halted state, and spapr_reset_vcpu()
attempts to implement this by setting CPUState::halted to 1. But that's too
late for the case of hotplugged CPUs in a machine configure with 2 or more
threads per core.
By then, other parts of QEMU have already caused the vCPU to
On 2020/8/18 下午5:16, Daniel P. Berrangé wrote:
Your mail came through as HTML-only so all the quoting and attribution
is mangled / lost now :-(
My bad, sorry.
On Tue, Aug 18, 2020 at 05:01:51PM +0800, Jason Wang wrote:
On 2020/8/18 下午4:55, Daniel P. Berrangé wrote:
On Tue, Aug 18
This is where the error occurred:
(gdb) x/30i 0x40007ff2c0
0x40007ff2c0:xor%al,%dh
0x40007ff2c2:(bad)
0x40007ff2c3:add%al,(%rax)
0x40007ff2c5:add%al,(%rax)
0x40007ff2c7:add%ch,0x0(%rbp)
0x40007ff2cd:add%al,(%rax
On 8/18/2020 10:10 AM, Paolo Bonzini wrote:
From: Marc-André Lureau
Meson warns if xgettext is not found. In the future we may want to add
a required argument to i18n.gettext(); in the meanwhile, I am adding a
--enable-gettext/--disable-gettext option and feature detection in
configure. This
Signed-off-by: Yi Li
---
qemu-img.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 5308773811..aa2e31c8ae 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1200,10 +1200,10 @@ static int is_allocated_sectors(const uint8_t *buf, int
n, int
On Tue, Aug 18, 2020 at 9:55 PM Anup Patel wrote:
>
> On Tue, Aug 18, 2020 at 6:39 PM wrote:
> >
> > On 8/18/20 7:17 AM, Anup Patel wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > > the content is safe
> > >
> > > On Tue, Aug 18, 2020 at 1:23 AM wrote:
>
Now, I found something new when I use gdb:
=> 0x400523c858:ud2
0x400523c85a:pushq $0xd
0x400523c85c:mov-0x230(%rbp),%rax
0x400523c863:mov-0x240(%rbp),%rdi
0x400523c86a:mov$0x1,%esi
0x400523c86f:movq $0x0,-0x230(%rbp)
Fixed accidental eof newline strip from `configure`
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 37 -
configure | 4 +++-
2 files changed, 39 insertions(+), 2 deletions(-)
--
2.20.1
The client may have been freed already by a secondary audio device
recovering its session as JACK2 has some cleanup code to work around
broken clients, which doesn't account for well behaved clients.
https://github.com/jackaudio/jack2/issues/627
As JACK1 and JACK2 are interchangeable and JACK2 ha
The client may have been freed already by a secondary audio device
recovering its session as JACK2 has some cleanup code to work around
broken clients, which doesn't account for well behaved clients.
https://github.com/jackaudio/jack2/issues/627
As JACK1 and JACK2 are interchangeable and JACK2 ha
Philippe Mathieu-Daudé writes:
> On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote:
>> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
>> start-powered-off property which makes cpu_common_reset() initialize it
>> to 1 in common code.
>>
>> Also change creation of CPU object
Thiago Jung Bauermann writes:
> Hello Philippe,
>
> Thanks for your review.
>
> Philippe Mathieu-Daudé writes:
>
>> On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote:
@@ -897,6 +895,19 @@ void ppce500_init(MachineState *machine)
} else {
/* Secondary CPUs */
Hello Philippe,
Thanks for your review.
Philippe Mathieu-Daudé writes:
> On 8/18/20 9:22 AM, Philippe Mathieu-Daudé wrote:
>> On 8/18/20 5:33 AM, Thiago Jung Bauermann wrote:
>>> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
>>> the start-powered-off property which
Hi Igor,
Thank you for reviewing these patches, and the tips you provided here
and on other messages on how to fix the refcount issues.
Igor Mammedov writes:
> On Tue, 18 Aug 2020 00:33:19 -0300
> Thiago Jung Bauermann wrote:
>
> [...]
>
>> Also change creation of CPU object from cpu_create(
Patchew URL: https://patchew.org/QEMU/20200818215227.181654-1-jus...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On 2020-08-19 04:11, Christian Schoenebeck wrote:
On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote:
Due to a ridiculous commit in the Jack library, the client may have
been
freed already by a secondary audio device recovering its session.
https://github.com/jackaudio/jack2/is
Ok, we may store these functions in syscall.c.
вт, 18 авг. 2020 г. в 18:56, Laurent Vivier :
> Le 18/08/2020 à 01:57, Andrew Aladjev a écrit :
> > Signed-off-by: Andrew Aladjev
> > ---
> > linux-user/Makefile.objs | 5 +++--
> > linux-user/syscall.c | 33 +
Add acpi_pcihp to ich9_pm and use ACPI PCI hot-plug by default.
Signed-off-by: Julia Suvorova
---
Note: New pc_compats are usually added shortly after release.
I will switch to pc_compat_5_1 when it becomes available.
hw/i386/acpi-build.h | 1 +
include/hw/acpi/ich9.h | 3 +++
hw/acpi
Other methods may be used if the system is capable of this and the _OSC bit
is set. Disable them explicitly to force ACPI PCI hot-plug use. The older
versions will still use PCIe native.
Signed-off-by: Julia Suvorova
---
hw/i386/acpi-build.h | 11 +++
hw/i386/acpi-build.c | 21 ++
Add trace events similar to piix4_gpe_readb() to check gpe status.
Signed-off-by: Julia Suvorova
Reviewed-by: Igor Mammedov
---
hw/acpi/ich9.c | 7 ++-
hw/acpi/trace-events | 4
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 6
1 - 100 of 478 matches
Mail list logo
