Re: [PATCH v2] hw/riscv: microchip_pfsoc: add QSPI NOR flash

2020-11-11 Thread Bin Meng
On Thu, Nov 12, 2020 at 3:50 PM Vitaly Wool wrote: > > Add QSPI NOR flash definition for Microchip PolarFire SoC. > > Signed-off-by: Vitaly Wool > --- > hw/riscv/microchip_pfsoc.c | 21 + > include/hw/riscv/microchip_pfsoc.h | 3 +++ > 2 files changed, 24

[PATCH v2] hw/riscv: microchip_pfsoc: add QSPI NOR flash

2020-11-11 Thread Vitaly Wool
Add QSPI NOR flash definition for Microchip PolarFire SoC. Signed-off-by: Vitaly Wool --- hw/riscv/microchip_pfsoc.c | 21 + include/hw/riscv/microchip_pfsoc.h | 3 +++ 2 files changed, 24 insertions(+) diff --git a/hw/riscv/microchip_pfsoc.c

答复: [PATCH] ide:do nothing for identify cmd if no any device attached

2020-11-11 Thread RockCui-oc
Hi all, Any suggestions for this patch? Rock 发件人: John Snow 发送时间: 2020年10月3日 3:37 收件人: Max Reitz; RockCui-oc; qemu-devel@nongnu.org 抄送: Peter Maydell; Cobe Chen(BJ-RD) 主题: Re: [PATCH] ide:do nothing for identify cmd if no any device attached On 9/3/20 6:40

Re: [PATCH v2 3/4] nand: put it into the 'storage' category

2020-11-11 Thread Thomas Huth
On 11/11/2020 17.47, Gan Qixin wrote: > The category of the nand device is not set, put it into the 'storage' > category. > > Signed-off-by: Gan Qixin > --- > hw/block/nand.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/block/nand.c b/hw/block/nand.c > index

Re: [PATCH v2 2/4] ads7846: put it into the 'display' category

2020-11-11 Thread Thomas Huth
On 11/11/2020 17.47, Gan Qixin wrote: > The category of the ads7846 device is not set, put it into the 'display' > category. > > Signed-off-by: Gan Qixin > --- > hw/display/ads7846.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c > index

Re: [PATCH v2 1/4] ssd0323: put it into the 'display' category

2020-11-11 Thread Thomas Huth
On 11/11/2020 17.47, Gan Qixin wrote: > The category of the ssd0323 device is not set, put it into the 'display' > category. > > Signed-off-by: Gan Qixin > --- > hw/display/ssd0323.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/ssd0323.c b/hw/display/ssd0323.c > index

[Bug 1794950] Re: qemu hangs when guest is using linux kernel 4.16+

2020-11-11 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1795369] Re: Record/replay (icount rr) causes emulation hang or exit with error about missing events in log

2020-11-11 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1798057] Re: Not able to start instances larger than 1 TB

2020-11-11 Thread Thomas Huth
I'm assuming that the right physbits setting fixed the bug? ... so I'm marking this ticket as "Invalid". If the problem still persists, then please open again. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml,

[Bug 1795799] Re: Cirrus video, graphical corruption, bad fonts

2020-11-11 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1798451] Re: MMX emulation is missing on HVF Acceleration

2020-11-11 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[PATCH v2 3/4] nand: put it into the 'storage' category

2020-11-11 Thread Gan Qixin
The category of the nand device is not set, put it into the 'storage' category. Signed-off-by: Gan Qixin --- hw/block/nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/nand.c b/hw/block/nand.c index bcceb64ebb..1d7a48a2ec 100644 --- a/hw/block/nand.c +++ b/hw/block/nand.c @@

[PATCH v2 2/4] ads7846: put it into the 'display' category

2020-11-11 Thread Gan Qixin
The category of the ads7846 device is not set, put it into the 'display' category. Signed-off-by: Gan Qixin --- hw/display/ads7846.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c index 023165b2a3..b455cb5acd 100644 --- a/hw/display/ads7846.c

[Bug 1796816] Re: Wrong keyboard in QEMU Windows for OpenSUSE PowerPC

2020-11-11 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[PATCH v2 4/4] max111x: put it into the 'misc' category

2020-11-11 Thread Gan Qixin
The category of the max111x device is not set, put it into the 'misc' category. Signed-off-by: Gan Qixin --- hw/misc/max111x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/max111x.c b/hw/misc/max111x.c index 7e6723f343..eae0f9b598 100644 --- a/hw/misc/max111x.c +++

[PATCH v2 0/4] Categorize some uncategorized devices

2020-11-11 Thread Gan Qixin
Hi all, I found some uncategorized devices and categorize them in these patches. Thanks, Gan Qixin v1->v2: Correct some spelling errors and limit commit message line length to around 70. Gan Qixin (4): ssd0323: put it into the 'display' category ads7846: put it into the 'display' category

[PATCH v2 1/4] ssd0323: put it into the 'display' category

2020-11-11 Thread Gan Qixin
The category of the ssd0323 device is not set, put it into the 'display' category. Signed-off-by: Gan Qixin --- hw/display/ssd0323.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/ssd0323.c b/hw/display/ssd0323.c index 17d4b32ae3..cbfd21dfd5 100644 --- a/hw/display/ssd0323.c +++

Re: [PATCH] vl, qemu-config: remove -set

2020-11-11 Thread Paolo Bonzini
Il gio 12 nov 2020, 07:55 Markus Armbruster ha scritto: > Immediate removal of -set / rejection of -set for some option groups > needs more justification than just "I think we can get away with it": > there has to be a tangible benefit. The benefit is being able to switch parsers (for

Re: [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job

2020-11-11 Thread Thomas Huth
On 10/11/2020 21.42, Wainer dos Santos Moschetta wrote: > Once Cleber said "acceptance" wasn't  a good name for those tests. Indeed > "integration" is widely used, so okay for this renaming. Should we maybe also rename the folder and "make check-acceptance" into "make check-integration" ?

Re: [PATCH] vl, qemu-config: remove -set

2020-11-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/11/20 16:03, Daniel P. Berrangé wrote: >> On Wed, Nov 11, 2020 at 08:57:16AM -0500, Paolo Bonzini wrote: >>> -set as far as I can see has basically no use. It was intended as an >>> override >>> mechanism for configuration files, but even configuration files

Re: [PATCH 1/2] ppc/translate: Implement lxvwsx opcode

2020-11-11 Thread Greg Kurz
On Tue, 10 Nov 2020 10:14:23 +0100 LemonBoy wrote: > Is there any chance for this patch series to be merged for 5.2? > Not a chance. We're in hard freeze now. > On 09/11/20 18:39, Richard Henderson wrote: > > On 11/9/20 1:17 AM, LemonBoy wrote: > >> Implement the "Load VSX Vector Word & Splat

Re: [PATCH] json: Fix a memleak in parse_pair()

2020-11-11 Thread Markus Armbruster
Alex Chen writes: > In qobject_type(), NULL is returned when the 'QObject' returned from > parse_value() is not of QString type, > and this 'QObject' memory will leaked. > So we need to first check whether the 'QObject' returned from parse_value() > is of QString type, > and if not, we free

[Bug 1794086] Re: readlink(2) returns incorrect size for /proc/self/exe

2020-11-11 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

[Bug 1794285] Re: 100% Host CPU usage while guest idling

2020-11-11 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch

Re: [PATCH] target/i386: seg_helper: Correct segement selector nullification in the RET/IRET helper

2020-11-11 Thread Bin Meng
On Mon, Nov 2, 2020 at 4:20 PM Bin Meng wrote: > > On Thu, Oct 22, 2020 at 6:16 PM Bin Meng wrote: > > > > From: Bin Meng > > > > Per the SDM, when returning to outer privilege level, for segment > > registers (ES, FS, GS, and DS) if the check fails, the segment > > selector becomes null, but

Re: [PATCH] Microchip: add QSPI NOR flash

2020-11-11 Thread Bin Meng
Hi Vitaly, On Tue, Nov 10, 2020 at 10:48 PM Vitaly Wool wrote: > nits: please use the tag "hw/riscv: microchip_pfsoc" > Add QSPI NOR flash definition for Microchip PolarFire SoC. > > Signed-off-by: Vitaly Wool > --- > hw/riscv/microchip_pfsoc.c | 21 + >

Re: [PATCH] net: do not exit on "netdev_add help" monitor command

2020-11-11 Thread Jason Wang
On 2020/11/11 下午6:52, Paolo Bonzini wrote: "netdev_add help" is causing QEMU to exit because the code that invokes show_netdevs is shared between CLI and HMP processing. Move the check to the callers so that exit(0) remains only in the CLI flow. "netdev_add help" is not fixed by this patch;

Re: [PATCH] hw/net/e1000e: advance desc_offset in case of null descriptor

2020-11-11 Thread Jason Wang
On 2020/11/11 下午9:06, P J P wrote: From: Prasad J Pandit While receiving packets via e1000e_write_packet_to_guest() routine, 'desc_offset' is advanced only when RX descriptor is processed. And RX descriptor is not processed if it has NULL buffer address. This may lead to an infinite loop

Re: [PATCH-for-5.2 v2] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off

2020-11-11 Thread Ani Sinha
On Sun, Nov 8, 2020 at 22:40 Philippe Mathieu-Daudé wrote: > On 11/8/20 4:58 AM, Ani Sinha wrote: > > On Sun, Nov 8, 2020 at 1:10 AM Philippe Mathieu-Daudé > wrote: > >> > >> GCC 9.3.0 thinks that 'method' can be left uninitialized. This code > >> is already in the "if (bsel ||

[PATCH v2] ACPI: Avoid infinite recursion when dump-vmstate

2020-11-11 Thread Peng Liang
There is a field with vmstate_ghes_state as vmsd in vmstate_ghes_state, which will lead to infinite recursion in dump_vmstate_vmsd. Fixes: a08a64627b ("ACPI: Record the Generic Error Status Block address") Reported-by: Euler Robot Signed-off-by: Peng Liang Acked-by: Igor Mammedov ---

Re: [PATCH] ACPI: Avoid infinite recursion when dump-vmstate

2020-11-11 Thread Peng Liang
On 11/12/2020 1:26 AM, Dr. David Alan Gilbert wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: >> On Wed, 11 Nov 2020 14:01:12 + >> "Dr. David Alan Gilbert" wrote: >> >>> Is someone taking a fix for this in 5.2 - it's breaking vmstate >>> comparison. >> can you merge it via migration

[PATCH] ast2600: SRAM is 89KB

2020-11-11 Thread Joel Stanley
On the AST2600A1, the SRAM size was increased to 89KB. Fixes: 7582591ae745 ("aspeed: Support AST2600A1 silicon revision") Signed-off-by: Joel Stanley --- hw/arm/aspeed_ast2600.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c

[PATCH v1 1/2] intc/ibex_plic: Fix some typos in the comments

2020-11-11 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/intc/ibex_plic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/ibex_plic.c b/hw/intc/ibex_plic.c index 235e6b88ff..db9e0aa25f 100644 --- a/hw/intc/ibex_plic.c +++ b/hw/intc/ibex_plic.c @@ -45,7 +45,7 @@ static void

[PATCH v1 2/2] intc/ibex_plic: Ensure we don't loose interrupts

2020-11-11 Thread Alistair Francis
If an interrupt occurs between when we claim and complete an interrupt we currently drop the interrupt in ibex_plic_irqs_set_pending(). This somewhat matches hardware that also ignore the interrupt between the claim and complete process. In the case of hardware though the physical interrupt line

[Bug 1685526] Re: UEFI firmware can't write to "fake" FAT hard disk

2020-11-11 Thread Laszlo Ersek (Red Hat)
Out of scope; please see my (independent, more recent) replies here: [edk2-devel] OVMF/QEMU shell based unit tests and writing to a virtual disk https://edk2.groups.io/g/devel/message/66655 https://edk2.groups.io/g/devel/message/66656 (alternative links:

Re: [PATCH v2 08/12] can_host: Use class properties

2020-11-11 Thread Pavel Pisa
Hello Eduardo, thanks for contribution. On Wednesday 11 of November 2020 19:38:19 Eduardo Habkost wrote: > Instance properties make introspection hard and are not shown by > "-object ...,help". Convert them to class properties. > > Signed-off-by: Eduardo Habkost > --- > This was originally

Re: [PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState *

2020-11-11 Thread Keith Packard
Alistair Francis writes: > I'm not sure common is the right name here, as it is really just ARM > and RISC-V, but I don't have a better name to use. We've already seen some interest for other architectures; Benjamin Herrenschmidt was looking at using this for PPC, for instance. He got stuck at

Re: [PATCH 4/4] riscv: Add semihosting support [v11]

2020-11-11 Thread Keith Packard
Alistair Francis writes: >> +return (nr == TARGET_SYS_EXIT_EXTENDED || sizeof(target_ulong) == 0); > > How would sizeof(target_ulong) == 0 ? Oops. This is supposed to be 8, not 0. And those look very similar on the screen. I caught this myself a couple of weeks ago but forgot to send out a

Re: [PATCH 3/4] semihosting: Change internal common-semi interfaces to use CPUState *

2020-11-11 Thread Alistair Francis
On Wed, Oct 28, 2020 at 12:00 PM Keith Packard via wrote: > > This makes all of the internal interfaces architecture-independent and > renames the internal functions to use the 'common_semi' prefix instead > of 'arm' or 'arm_semi'. > > To do this, some new architecture-specific internal helper

Re: [PATCH 4/4] riscv: Add semihosting support [v11]

2020-11-11 Thread Alistair Francis
On Wed, Oct 28, 2020 at 12:04 PM Keith Packard via wrote: > > Adapt the arm semihosting support code for RISCV. This implementation > is based on the standard for RISC-V semihosting version 0.2 as > documented in > >https://github.com/riscv/riscv-semihosting-spec/releases/tag/0.2 > >

Re: [PATCH 2/4] semihosting: Change common-semi API to be architecture-independent

2020-11-11 Thread Alistair Francis
On Wed, Oct 28, 2020 at 12:01 PM Keith Packard via wrote: > > The public API is now defined in > hw/semihosting/common-semi.h. do_common_semihosting takes CPUState * > instead of CPUARMState *. All internal functions have been renamed > common_semi_ instead of arm_semi_ or arm_. Aside from the

Re: [PATCH] Microchip: add QSPI NOR flash

2020-11-11 Thread Alistair Francis
On Tue, Nov 10, 2020 at 6:50 AM Vitaly Wool wrote: > > Add QSPI NOR flash definition for Microchip PolarFire SoC. > > Signed-off-by: Vitaly Wool Acked-by: Alistair Francis Alistair > --- > hw/riscv/microchip_pfsoc.c | 21 + > include/hw/riscv/microchip_pfsoc.h |

Re: [PATCH] hw/riscv: sifive_u: Add UART1 DT node in the generated DTB

2020-11-11 Thread Alistair Francis
On Wed, Nov 11, 2020 at 1:48 AM Anup Patel wrote: > > The sifive_u machine emulates two UARTs but we have only UART0 DT > node in the generated DTB so this patch adds UART1 DT node in the > generated DTB. > > Signed-off-by: Anup Patel Thanks! Applied to riscv-to-apply.next Alistair > --- >

Re: [PULL for-5.2 0/2] Tracing patches

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 15:57, Stefan Hajnoczi wrote: > > The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c: > > Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +) > > are available in the Git repository at: > > https://gitlab.com/stefanha/qemu.git

Re: [PATCH v2 12/12] input: Use class properties

2020-11-11 Thread Eduardo Habkost
On Wed, Nov 11, 2020 at 01:38:23PM -0500, Eduardo Habkost wrote: > Instance properties make introspection hard and are not shown by > "-object ...,help". Convert them to class properties. > > Signed-off-by: Eduardo Habkost > --- > This was originally submitted as part of the series: > Subject:

[PULL 1/2] linux-user: Correct definition of stack_t

2020-11-11 Thread Laurent Vivier
From: LemonBoy Some platforms used the wrong definition of stack_t where the flags and size fields were swapped or where the flags field had type ulong instead of int. Due to the presence of padding space in the structure and the prevalence of little-endian machines this problem went unnoticed

[PULL 2/2] linux-user: Prevent crash in epoll_ctl

2020-11-11 Thread Laurent Vivier
From: LemonBoy >From 894bb5172705e46a3a04c93b4962c0f0cafee814 Mon Sep 17 00:00:00 2001 From: Giuseppe Musacchio Date: Fri, 17 Apr 2020 17:25:07 +0200 Subject: [PATCH] linux-user: Prevent crash in epoll_ctl The `event` parameter is ignored by the kernel if `op` is EPOLL_CTL_DEL, do the same and

[PULL 0/2] Linux user for 5.2 patches

2020-11-11 Thread Laurent Vivier
The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c: Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-5.2-pull-request for you to fetch changes up to

Re: [PATCH v2] linux-user: Correct definition of stack_t

2020-11-11 Thread Laurent Vivier
Le 05/11/2020 à 16:52, LemonBoy a écrit : > Some platforms used the wrong definition of stack_t where the flags and > size fields were swapped or where the flags field had type ulong instead > of int. > > Due to the presence of padding space in the structure and the prevalence > of little-endian

Re: [PATCH] linux-user: Prevent crash in epoll_ctl

2020-11-11 Thread Laurent Vivier
Le 17/04/2020 à 17:34, LemonBoy a écrit : > From 894bb5172705e46a3a04c93b4962c0f0cafee814 Mon Sep 17 00:00:00 2001 > From: Giuseppe Musacchio > Date: Fri, 17 Apr 2020 17:25:07 +0200 > Subject: [PATCH] linux-user: Prevent crash in epoll_ctl > > The `event` parameter is ignored by the kernel if

Re: [PATCH v2 02/12] vexpress-a15: Register "virtualization" as class property

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 18:38, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- >

Re: [PATCH 11/29] vl: extract various command line desugaring snippets to a new function

2020-11-11 Thread Paolo Bonzini
Il mer 11 nov 2020, 20:57 Igor Mammedov ha scritto: > On Tue, 27 Oct 2020 14:21:26 -0400 > Paolo Bonzini wrote: > > > Signed-off-by: Paolo Bonzini > > --- > > softmmu/vl.c | 40 ++-- > > 1 file changed, 22 insertions(+), 18 deletions(-) > > > > diff --git

Re: [PATCH v2 07/12] arm/cpu64: Register "aarch64" as class property

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 18:38, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- >

Re: [PATCH v2 05/12] arm/virt: Register most properties as class properties

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 18:39, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- >

Re: [PATCH v2 01/12] vexpress: Register "secure" as class property

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 18:38, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > ---

Re: [PATCH v2 06/12] virt: Register "its" as class property

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 18:38, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Note: "its" is currently registered conditionally, but this makes > the feature be registered unconditionally. The only

Re: [Virtio-fs] [PATCH 1/3] tools/virtiofsd/buffer.c: check whether buf is NULL in fuse_bufvec_advance func

2020-11-11 Thread Dr. David Alan Gilbert
* Haotian Li (lihaoti...@huawei.com) wrote: > In fuse_bufvec_advance func, calling fuse_bufvec_current func > may return NULL, so we should check whether buf is NULL before > using it. > > Signed-off-by: Haotian Li > Signed-off-by: Zhiqiang Liu > --- > tools/virtiofsd/buffer.c | 4 > 1

Re: [PATCH v2 03/12] tmp421: Register properties as class properties

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 18:43, Eduardo Habkost wrote: > > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 10/29] vl: preconfig and loadvm are mutually exclusive

2020-11-11 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:25 -0400 Paolo Bonzini wrote: > Just like -incoming. > > Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov > --- > softmmu/vl.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index

Re: [PATCH 11/29] vl: extract various command line desugaring snippets to a new function

2020-11-11 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:26 -0400 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > softmmu/vl.c | 40 ++-- > 1 file changed, 22 insertions(+), 18 deletions(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index c2a5ee61f9..6749109b29 100644 >

Re: [Virtio-fs] [PATCH 3/3] virtiofsd: check whether strdup lo.source return NULL in main func

2020-11-11 Thread Dr. David Alan Gilbert
* Haotian Li (lihaoti...@huawei.com) wrote: > In main func, strdup lo.source may fail. So check whether strdup > lo.source return NULL before using it. > > Signed-off-by: Haotian Li > Signed-off-by: Zhiqiang Liu > --- > tools/virtiofsd/passthrough_ll.c | 4 > 1 file changed, 4

Re: [PULL v2 0/6] Misc fixes for QEMU 5.2-rc2

2020-11-11 Thread Peter Maydell
On Wed, 11 Nov 2020 at 14:51, Paolo Bonzini wrote: > > The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into > staging (2020-11-06 13:43:28 +) > > are available in the Git repository at: > >

Re: [Virtio-fs] [PATCH 2/3] virtiofsd: check whether lo_map_reserve returns NULL in, main func

2020-11-11 Thread Dr. David Alan Gilbert
* Haotian Li (lihaoti...@huawei.com) wrote: > In main func, func lo_map_reserve is called without NULL check. > If reallocing new_elems fails in func lo_map_grow, the func > lo_map_reserve may return NULL. We should check whether > lo_map_reserve returns NULL before using it. > > Signed-off-by:

Re: [PATCH 09/29] vl: extract various command line validation snippets to a new function

2020-11-11 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:24 -0400 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov > --- > hw/core/machine.c | 1 + > softmmu/vl.c | 78 +++ > 2 files changed, 40 insertions(+), 39 deletions(-) > > diff --git

Re: [PATCH 08/29] vl: move prelaunch part of qemu_init to new functions

2020-11-11 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:23 -0400 Paolo Bonzini wrote: > The final part of qemu_init, starting with the completion of > board init, is already relatively clean. Split it out of > qemu_init so that qemu_init keeps only the messy parts. > > Signed-off-by: Paolo Bonzini Reviewed-by: Igor

[PATCH v2 10/12] netfilter: Reorder functions

2020-11-11 Thread Eduardo Habkost
Trivial code reordering in some filter backends, to make the next changes easier to review. Signed-off-by: Eduardo Habkost --- This was originally submitted as part of the series: Subject: [PATCH 00/12] qom: Make all -object types use only class properties Message-Id:

[PATCH v2 01/12] vexpress: Register "secure" as class property

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/vexpress.c | 11 ++- 1 file changed, 6 insertions(+), 5

[PATCH v2 05/12] arm/virt: Register most properties as class properties

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/virt.c | 76 +++ 1

[PATCH v2 09/12] colo: Use class properties

2020-11-11 Thread Eduardo Habkost
Instance properties make introspection hard and are not shown by "-object ...,help". Convert them to class properties. Signed-off-by: Eduardo Habkost --- This was originally submitted as part of the series: Subject: [PATCH 00/12] qom: Make all -object types use only class properties Message-Id:

[PATCH v2 11/12] netfilter: Use class properties

2020-11-11 Thread Eduardo Habkost
Instance properties make introspection hard and are not shown by "-object ...,help". Convert them to class properties. Signed-off-by: Eduardo Habkost --- This was originally submitted as part of the series: Subject: [PATCH 00/12] qom: Make all -object types use only class properties Message-Id:

Re: [PATCH v2 00/44] Make qdev static property API usable by any QOM type

2020-11-11 Thread Eduardo Habkost
On Tue, Nov 10, 2020 at 11:38:04AM +0100, Kevin Wolf wrote: > Am 09.11.2020 um 21:28 hat Eduardo Habkost geschrieben: [...] > > Anyway, If we are the only ones discussing this, I will just > > defer to your suggestions as QOM maintainer. I hope we hear from > > others. > > Well, I expressed my

[PATCH v2 08/12] can_host: Use class properties

2020-11-11 Thread Eduardo Habkost
Instance properties make introspection hard and are not shown by "-object ...,help". Convert them to class properties. Signed-off-by: Eduardo Habkost --- This was originally submitted as part of the series: Subject: [PATCH 00/12] qom: Make all -object types use only class properties Message-Id:

[PATCH v2 02/12] vexpress-a15: Register "virtualization" as class property

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/vexpress.c | 14 -- 1 file changed, 8 insertions(+), 6

[PATCH v2 12/12] input: Use class properties

2020-11-11 Thread Eduardo Habkost
Instance properties make introspection hard and are not shown by "-object ...,help". Convert them to class properties. Signed-off-by: Eduardo Habkost --- This was originally submitted as part of the series: Subject: [PATCH 00/12] qom: Make all -object types use only class properties Message-Id:

[PATCH v2 06/12] virt: Register "its" as class property

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Note: "its" is currently registered conditionally, but this makes the feature be registered unconditionally. The only side effect is that it will be now possible to set its=on on

[PATCH v2 03/12] tmp421: Register properties as class properties

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: qemu-devel@nongnu.org --- hw/misc/tmp421.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git

[PATCH v2 04/12] i386: Register feature bit properties as class properties

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Remove x86_cpu_release_bit_prop() function, as we will allocate BitProperty only once and never free the class property list

[PATCH v2 07/12] arm/cpu64: Register "aarch64" as class property

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as they don't require an object to be instantiated. Signed-off-by: Eduardo Habkost --- Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- target/arm/cpu64.c | 16 ++-- 1 file changed, 6 insertions(+),

[PATCH v2 00/12] qom: Convert some properties to class properties

2020-11-11 Thread Eduardo Habkost
Class properties make QOM introspection simpler and easier, as it doesn't require an object to be instantiated. This series converts a few existing object_property_add*() calls to register class properties instead. Changes v1 -> v2: * Bug fix at "i386: Register feature bit properties as class

Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC

2020-11-11 Thread Miroslav Rezanina
- Original Message - > From: "Andrew Jones" > To: "Peter Maydell" > Cc: "Miroslav Rezanina" , "QEMU Developers" > , "qemu-arm" > , "Philippe Mathieu-Daudé" > Sent: Wednesday, November 11, 2020 6:39:32 PM > Subject: Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC > > On Wed,

Re: [PATCH v3 00/81] target/arm: Implement SVE2

2020-11-11 Thread Stephen Long
Hi Richard, Apologies for forgetting to cc you in the previous reply. What's the plan to get this patch series into master? Thanks, Stephen

Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC

2020-11-11 Thread Andrew Jones
On Wed, Nov 11, 2020 at 04:00:25PM +, Peter Maydell wrote: > On Wed, 11 Nov 2020 at 15:05, Miroslav Rezanina wrote: > > > > - Original Message - > > > From: "Andrew Jones" > > > To: qemu-devel@nongnu.org, qemu-...@nongnu.org > > > Cc: "peter maydell" , phi...@redhat.com, > > >

Re: [PATCH] ACPI: Avoid infinite recursion when dump-vmstate

2020-11-11 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 11 Nov 2020 14:01:12 + > "Dr. David Alan Gilbert" wrote: > > > Is someone taking a fix for this in 5.2 - it's breaking vmstate > > comparison. > can you merge it via migration tree? I could; Peng: Could you give a sign-off for this

Re: [PATCH v2 4/5] plugins/loader: fix uninitialized variable warning in plugin_reset_uninstall()

2020-11-11 Thread Alex Bennée
Chen Qun writes: > After the WITH_QEMU_LOCK_GUARD macro is added, the compiler cannot identify > that the statements in the macro must be executed. As a result, some > variables > assignment statements in the macro may be considered as unexecuted by the > compiler. > > When the

nec-usb-xhci migration breakage

2020-11-11 Thread Dr. David Alan Gilbert
Hi, Somewhere between 5.1.0 and 5.2.0-rc1 there's a migration breakage on the nec-usb-xhci device: [dgilbert@dgilbert-t580 try]$ ./x86_64-softmmu/qemu-system-x86_64 -M pc-q35-5.1 -device nec-usb-xhci -nographic -incoming tcp:: qemu-system-x86_64: get_pci_config_device: Bad config data:

Re: [PATCH] ACPI: Avoid infinite recursion when dump-vmstate

2020-11-11 Thread Igor Mammedov
On Wed, 11 Nov 2020 14:01:12 + "Dr. David Alan Gilbert" wrote: > Is someone taking a fix for this in 5.2 - it's breaking vmstate > comparison. can you merge it via migration tree? [...] for fixed up version below Acked-by: Igor Mammedov > > > > Do you mean that we need another

Re: [PATCH] hw/riscv: sifive_u: Add UART1 DT node in the generated DTB

2020-11-11 Thread Alistair Francis
On Wed, Nov 11, 2020 at 1:48 AM Anup Patel wrote: > > The sifive_u machine emulates two UARTs but we have only UART0 DT > node in the generated DTB so this patch adds UART1 DT node in the > generated DTB. > > Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Alistair > --- >

[PATCH v3 0/2] quorum: Implement bdrv_co_block_status()

2020-11-11 Thread Alberto Garcia
Hi, I realized that if one of the children returns an error during co_block_status() then we should not pass the error immediately to the caller, because that's a situation that Quorum should be able to handle. The new version of the patch takes the simpler approach of falling back to returning

[PATCH v3 1/2] quorum: Implement bdrv_co_block_status()

2020-11-11 Thread Alberto Garcia
The quorum driver does not implement bdrv_co_block_status() and because of that it always reports to contain data even if all its children are known to be empty. One consequence of this is that if we for example create a quorum with a size of 10GB and we mirror it to a new image the operation

[PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-11 Thread Alberto Garcia
This simply calls bdrv_co_pwrite_zeroes() in all children Signed-off-by: Alberto Garcia --- block/quorum.c | 18 -- tests/qemu-iotests/312 | 7 +++ tests/qemu-iotests/312.out | 4 3 files changed, 27 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 00/15] *** ARC port for review ***

2020-11-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2020161758.9636-1-cupertinomira...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 2020161758.9636-1-cupertinomira...@gmail.com Subject: [PATCH 00/15] *** ARC port for review

Re: [PATCH-for-5.2 v2 2/4] meson: Only build vhost-user when system or tools is enabled

2020-11-11 Thread Philippe Mathieu-Daudé
On 11/11/20 4:48 PM, Stefan Hajnoczi wrote: > On Wed, Nov 11, 2020 at 01:09:10PM +0100, Philippe Mathieu-Daudé wrote: >> It does not make sense to select vhost-user features >> without system-mode or tools. Return an error when >> this configuration is selected. Example: >> >> $ ../configure

Re: Command line QAPIfication and -readconfig

2020-11-11 Thread Paolo Bonzini
On 11/11/20 16:29, Kevin Wolf wrote: Yes, no question this is doable, it just requires some extra code for each option instead of reusing something existing. But it's not too bad as QDicts are at least slightly more natural for a QAPI based interface than QemuOpts. Yeah, see the series I

[PATCH for-5.2?] nbd: Silence Coverity false positive

2020-11-11 Thread Eric Blake
Coverity noticed (CID 1436125) that we check the return value of nbd_extent_array_add in most places, but not at the end of bitmap_to_extents(). The return value exists to break loops before a future iteration, so there is nothing to check if we are already done iterating. That said, a minor

RE: [RFC v3] VFIO Migration

2020-11-11 Thread Thanos Makatos
> VFIO Migration > == > This document describes how to ensure migration compatibility for VFIO > devices, > including mdev and vfio-user devices. Is this something all VFIO/user devices will have to support? If it's not mandatory, how can a device advertise support? > Multiple

[PATCH 11/15] arc: Add gdbstub and XML for debugging support

2020-11-11 Thread cupertinomiranda
From: Shahab Vahedi Register layout for the target and the mechanisms to read and set them. Signed-off-by: Shahab Vahedi --- gdb-xml/arc-v2-aux.xml | 32 +++ gdb-xml/arc-v2-core.xml | 45 + gdb-xml/arc-v2-other.xml | 235 ++ target/arc/gdbstub.c | 420

Re: [PATCH] hw/arm/virt: ARM_VIRT must select ARM_GIC

2020-11-11 Thread Philippe Mathieu-Daudé
On 11/11/20 3:34 PM, Andrew Jones wrote: > The removal of the selection of A15MPCORE from ARM_VIRT also > removed what A15MPCORE selects, ARM_GIC. We still need ARM_GIC. > > Fixes: bec3c97e0cf9 ("hw/arm/virt: Remove dependency on Cortex-A15 MPCore > peripherals") > Reported-by: Miroslav Rezanina

[PATCH 12/15] arc: Add Synopsys ARC emulation boards

2020-11-11 Thread cupertinomiranda
From: Claudiu Zissulescu Add the Synopsys ARC boards, arc_sim for testing, sim-hs main emulation board using standard UART and nsim which includes a Synopsys ARC specific UART implementation. Signed-off-by: Claudiu Zissulescu --- hw/arc/Makefile.objs | 21 +++ hw/arc/arc_sim.c

[PATCH 10/15] arc: Add memory protection unit (MPU) support

2020-11-11 Thread cupertinomiranda
From: Shahab Vahedi Add memory implementation for Synopsys MPU unit version 3. Synopsys MPU allows to create memory regions against unauthorized execution/read/writes accesses. Signed-off-by: Shahab Vahedi --- target/arc/mpu.c | 656 +++

[PATCH 15/15] tests/acceptance: ARC: Add linux boot testing.

2020-11-11 Thread cupertinomiranda
From: Cupertino Miranda Just an acceptance test with ARC Linux booting. Signed-off-by: Cupertino Miranda --- tests/acceptance/boot_linux_console.py | 55 ++ 1 file changed, 55 insertions(+) diff --git a/tests/acceptance/boot_linux_console.py

  1   2   3   >