[PATCH V2] target/riscv: Align the data type of reset vector address

2021-03-24 Thread Dylan Jhong
Signed-off-by: Dylan Jhong Signed-off-by: Ruinland ChuanTzu Tsai --- target/riscv/cpu.c | 2 +- target/riscv/cpu.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 7d6ed80f6b..4ac901245a 100644 --- a/target/riscv/cpu.c +++

Re: [PATCH v3 04/16] qapi/expr.py: Add assertion for union type 'check_dict'

2021-03-24 Thread Markus Armbruster
John Snow writes: > On 2/24/21 5:35 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> mypy isn't fond of allowing you to check for bool membership in a >>> collection of str elements. Guard this lookup for precisely when we were >>> given a name. >>> >>> Signed-off-by: John Snow >>>

Re: gitlab-ci: Only build /staging branch?

2021-03-24 Thread Thomas Huth
On 24/03/2021 22.58, Philippe Mathieu-Daudé wrote: On 3/24/21 7:33 PM, Philippe Mathieu-Daudé wrote: On 3/24/21 7:01 PM, Philippe Mathieu-Daudé wrote: Hi, Peter's current workflow is push to /staging and if his testing succeeds, he pushes the same commit as /master. IMO there is no point in

Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver

2021-03-24 Thread Viresh Kumar
On 25-03-21, 13:09, Jie Deng wrote: > > On 2021/3/24 15:33, Viresh Kumar wrote: > > + > > +/* Definitions from virtio-i2c specifications */ > > +#define VHOST_USER_I2C_MAX_QUEUES 1 > > + > > +/* Status */ > > +#define VIRTIO_I2C_MSG_OK 0 > > +#define VIRTIO_I2C_MSG_ERR

Re: [PATCH v3 15/16] qapi/expr.py: move related checks inside check_xxx functions

2021-03-24 Thread John Snow
On 2/25/21 10:28 AM, Markus Armbruster wrote: John Snow writes: There's not a big obvious difference between the types of checks that happen in the main function versus the kind that happen in the functions. Now they're in one place for each of the main types. As part of the move, spell out

Re: [PATCH 3/5] tools/vhost-user-i2c: Add backend driver

2021-03-24 Thread Jie Deng
On 2021/3/24 15:33, Viresh Kumar wrote: + +/* Definitions from virtio-i2c specifications */ +#define VHOST_USER_I2C_MAX_QUEUES 1 + +/* Status */ +#define VIRTIO_I2C_MSG_OK 0 +#define VIRTIO_I2C_MSG_ERR 1 + +/* The bit 0 of the @virtio_i2c_out_hdr.@flags, used

[PATCH qemu v17] spapr: Implement Open Firmware client interface

2021-03-24 Thread Alexey Kardashevskiy
The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor. Since the beginning, the runtime component of the firmware (RTAS) has been implemented as a

Re: [PATCH] target/riscv: Align the data type of reset vector address

2021-03-24 Thread Bin Meng
On Thu, Mar 25, 2021 at 11:40 AM Bin Meng wrote: > > On Thu, Mar 25, 2021 at 11:32 AM Dylan Jhong wrote: > > > > On Wed, Mar 24, 2021 at 10:59:55PM +0800, Alistair Francis wrote: > > > On Tue, Mar 23, 2021 at 5:15 AM Dylan Jhong wrote: > > > > > > > > Although the AE350 has not been upstream

Re: [PATCH 2/3] aspeed: Add Scater-Gather support for HACE Hash

2021-03-24 Thread Joel Stanley
On Wed, 24 Mar 2021 at 22:39, Klaus Heinrich Kiwi wrote: > > Complement the Aspeed HACE support with Scatter-Gather hash support for > sha256 and sha512. Scatter-Gather is only supported on AST2600-series. Please update the documentation at docs/system/arm/aspeed.rst too. > > Signed-off-by:

Re: [PATCH] target/riscv: Align the data type of reset vector address

2021-03-24 Thread Bin Meng
On Thu, Mar 25, 2021 at 11:32 AM Dylan Jhong wrote: > > On Wed, Mar 24, 2021 at 10:59:55PM +0800, Alistair Francis wrote: > > On Tue, Mar 23, 2021 at 5:15 AM Dylan Jhong wrote: > > > > > > Although the AE350 has not been upstream (preparing for v2), > > > the reset vector of the AE350 is known

Re: [PATCH] target/riscv: Align the data type of reset vector address

2021-03-24 Thread Dylan Jhong
On Wed, Mar 24, 2021 at 10:59:55PM +0800, Alistair Francis wrote: > On Tue, Mar 23, 2021 at 5:15 AM Dylan Jhong wrote: > > > > Although the AE350 has not been upstream (preparing for v2), > > the reset vector of the AE350 is known to be at the 2G position, > > so this patch is corrected in

Re: [PATCH qemu v16] spapr: Implement Open Firmware client interface

2021-03-24 Thread Alexey Kardashevskiy
On 25/03/2021 13:52, David Gibson wrote: On Tue, Mar 23, 2021 at 01:58:30PM +1100, Alexey Kardashevskiy wrote: The PAPR platform which describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-24 Thread Robert Hoo
On Wed, 2021-03-24 at 07:44 -0600, Richard Henderson wrote: > On 3/24/21 2:00 AM, Robert Hoo wrote: > > +if ((env->xcr0 & XFEATURE_AVX512) == XFEATURE_AVX512) { > > +/* XSAVE enabled AVX512 */ > > +nb = (env->hflags & HF_CS64_MASK) ? 32 : 8; > > +for (i

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-24 Thread David Gibson
On Tue, Mar 23, 2021 at 02:21:33PM -0300, Daniel Henrique Barboza wrote: > > > On 3/22/21 10:03 PM, David Gibson wrote: > > On Fri, Mar 19, 2021 at 03:34:52PM -0300, Daniel Henrique Barboza wrote: > > > Kernel commit 4bce545903fa ("powerpc/topology: Update > > > topology_core_cpumask") cause a

[PATCH 10/15] Hexagon (target/hexagon) instructions with multiple definitions

2021-03-24 Thread Taylor Simpson
Instructions with multiple definitions require special handling because the generator wants to create a helper, but helpers can only return a single result. Therefore, we must override the generated code. The following instructions are added A4_addp_cRdd32 = add(Rss32, Rtt32,

[PATCH 01/15] Hexagon (target/hexagon) TCG generation cleanup

2021-03-24 Thread Taylor Simpson
Simplify TCG generation of hex_reg_written Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/genptr.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index

[PATCH 02/15] Hexagon (target/hexagon) remove unnecessary inline directives

2021-03-24 Thread Taylor Simpson
Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- linux-user/hexagon/cpu_loop.c | 2 +- target/hexagon/cpu.c | 9 - target/hexagon/cpu.h | 6 ++ target/hexagon/decode.c | 6 +++--- target/hexagon/fma_emu.c | 39

[PATCH 07/15] Hexagon (target/hexagon) use softfloat default NaN and tininess

2021-03-24 Thread Taylor Simpson
Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- fpu/softfloat-specialize.c.inc | 5 + target/hexagon/cpu.c | 5 + target/hexagon/op_helper.c | 47 -- 3 files changed, 10 insertions(+), 47 deletions(-)

[PATCH 13/15] Hexagon (target/hexagon) load and unpack bytes instructions

2021-03-24 Thread Taylor Simpson
The following instructions are added L2_loadbzw2_io Rd32 = memubh(Rs32+#s11:1) L2_loadbzw4_io Rdd32 = memubh(Rs32+#s11:1) L2_loadbsw2_io Rd32 = membh(Rs32+#s11:1) L2_loadbsw4_io Rdd32 = membh(Rs32+#s11:1) L4_loadbzw2_ur Rd32 =

[PATCH 06/15] Hexagon (target/hexagon) utility function changes

2021-03-24 Thread Taylor Simpson
Remove unused carry_from_add64 function Change type of softfloat_roundingmodes Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 15 +-- target/hexagon/arch.h | 1 - target/hexagon/macros.h | 2 -- 3 files changed, 1

[PATCH 14/15] Hexagon (target/hexagon) load into shifted register instructions

2021-03-24 Thread Taylor Simpson
The following instructions are added L2_loadalignb_io Ryy32 = memb_fifo(Rs32+#s11:1) L2_loadalignh_io Ryy32 = memh_fifo(Rs32+#s11:1) L4_loadalignb_ur Ryy32 = memb_fifo(Rt32<<#u2+#U6) L4_loadalignh_ur Ryy32 = memh_fifo(Rt32<<#u2+#U6)

[PATCH 15/15] Hexagon (target/hexagon) CABAC decode bin

2021-03-24 Thread Taylor Simpson
The following instruction is added S2_cabacdecbinRdd32=decbin(Rss32,Rtt32) Test cases added to tests/tcg/hexagon/misc.c Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 91 +++ target/hexagon/arch.h | 4

[PATCH 04/15] Hexagon (target/hexagon) decide if pred has been written at TCG gen time

2021-03-24 Thread Taylor Simpson
Multiple writes to the same preg are and'ed together. Rather than generating a runtime check, we can determine at TCG generation time if the predicate has previously been written in the packet. Test added to tests/tcg/hexagon/misc.c Address feedback from Richard Henderson Signed-off-by:

[PATCH 12/15] Hexagon (target/hexagon) bit reverse (brev) addressing

2021-03-24 Thread Taylor Simpson
The following instructions are added L2_loadrub_pbr Rd32 = memub(Rx32++Mu2:brev) L2_loadrb_pbr Rd32 = memb(Rx32++Mu2:brev) L2_loadruh_pbr Rd32 = memuh(Rx32++Mu2:brev) L2_loadrh_pbr Rd32 = memh(Rx32++Mu2:brev) L2_loadri_pbr Rd32 =

[PATCH 00/15] Hexagon (target/hexagon) update

2021-03-24 Thread Taylor Simpson
This patch series is a significant update for the Hexagon target The first 9 patches address feedback from Richard Henderson The next 6 patches add the remaining instructions for the Hexagon scalar core The patches are logically independent but are organized as a series to avoid

[PATCH 11/15] Hexagon (target/hexagon) circular addressing

2021-03-24 Thread Taylor Simpson
The following instructions are added L2_loadrub_pci Rd32 = memub(Rx32++#s4:0:circ(Mu2)) L2_loadrb_pci Rd32 = memb(Rx32++#s4:0:circ(Mu2)) L2_loadruh_pci Rd32 = memuh(Rx32++#s4:1:circ(Mu2)) L2_loadrh_pci Rd32 = memh(Rx32++#s4:1:circ(Mu2))

[PATCH 03/15] Hexagon (target/hexagon) properly generate TB end for DISAS_NORETURN

2021-03-24 Thread Taylor Simpson
When exiting a TB, generate all the code before returning from hexagon_tr_translate_packet so that nothing needs to be done in hexagon_tr_tb_stop. Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/translate.c | 62

[PATCH 08/15] Hexagon (target/hexagon) replace float32_mul_pow2 with float32_scalbn

2021-03-24 Thread Taylor Simpson
Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/target/hexagon/arch.c b/target/hexagon/arch.c index bb51f19..40b6e3d 100644 ---

[PATCH 05/15] Hexagon (target/hexagon) change variables from int to bool when appropriate

2021-03-24 Thread Taylor Simpson
Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/cpu_bits.h | 2 +- target/hexagon/decode.c| 80 +++--- target/hexagon/insn.h | 21 ++-- target/hexagon/op_helper.c | 8 ++---

[PATCH v4 09/10] Add the function of colo_bitmap_clear_diry.

2021-03-24 Thread leirao
From: "Rao, Lei" When we use continuous dirty memory copy for flushing ram cache on secondary VM, we can also clean up the bitmap of contiguous dirty page memory. This also can reduce the VM stop time during checkpoint. Signed-off-by: Lei Rao --- migration/ram.c | 29

[PATCH v4 05/10] Add a function named packet_new_nocopy for COLO.

2021-03-24 Thread leirao
From: "Rao, Lei" Use the packet_new_nocopy instead of packet_new in the filter-rewriter module. There will be one less memory copy in the processing of each network packet. Signed-off-by: Lei Rao --- net/colo.c| 23 +++ net/colo.h| 1 +

[PATCH 09/15] Hexagon (target/hexagon) use softfloat for float-to-int conversions

2021-03-24 Thread Taylor Simpson
Use the proper return for helpers that convert to unsigned Remove target/hexagon/conv_emu.[ch] Address feedback from Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/conv_emu.c | 177 target/hexagon/conv_emu.h | 31

Re: [PATCH qemu v16] spapr: Implement Open Firmware client interface

2021-03-24 Thread David Gibson
On Tue, Mar 23, 2021 at 01:58:30PM +1100, Alexey Kardashevskiy wrote: > The PAPR platform which describes an OS environment that's presented by > a combination of a hypervisor and firmware. The features it specifies > require collaboration between the firmware and the hypervisor. > > Since the

[PATCH v4 04/10] Remove migrate_set_block_enabled in checkpoint

2021-03-24 Thread leirao
From: "Rao, Lei" We can detect disk migration in migrate_prepare, if disk migration is enabled in COLO mode, we can directly report an error.and there is no need to disable block migration at every checkpoint. Signed-off-by: Lei Rao Signed-off-by: Zhang Chen Reviewed-by: Li Zhijian ---

[PATCH v4 06/10] Add the function of colo_compare_cleanup

2021-03-24 Thread leirao
From: "Rao, Lei" This patch fixes the following: #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 #1 0x7f6ae4559859 in __GI_abort () at abort.c:79 #2 0x559aaa386720 in error_exit (err=16, msg=0x559aaa5973d0 <__func__.16227> "qemu_mutex_destroy") at

[PATCH v4 08/10] Reduce the PVM stop time during Checkpoint

2021-03-24 Thread leirao
From: "Rao, Lei" When flushing memory from ram cache to ram during every checkpoint on secondary VM, we can copy continuous chunks of memory instead of 4096 bytes per time to reduce the time of VM stop during checkpoint. Signed-off-by: Lei Rao --- migration/ram.c | 45

[PATCH v4 02/10] Fix the qemu crash when guest shutdown during checkpoint

2021-03-24 Thread leirao
From: "Rao, Lei" This patch fixes the following: qemu-system-x86_64: invalid runstate transition: 'colo' ->'shutdown' Aborted (core dumped) Signed-off-by: Lei Rao Reviewed-by: Li Zhijian --- softmmu/runstate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/softmmu/runstate.c

[PATCH v4 03/10] Optimize the function of filter_send

2021-03-24 Thread leirao
From: "Rao, Lei" The iov_size has been calculated in filter_send(). we can directly return the size.In this way, this is no need to repeat calculations in filter_redirector_receive_iov(); Signed-off-by: Lei Rao Reviewed-by: Li Zhijian --- net/filter-mirror.c | 8 1 file changed, 4

[PATCH v4 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info()

2021-03-24 Thread leirao
From: "Rao, Lei" The data pointer has skipped vnet_hdr_len in the function of parse_packet_early().So, we can not subtract vnet_hdr_len again when calculating pkt->header_size in fill_pkt_tcp_info(). Otherwise, it will cause network packet comparsion errors and greatly increase the frequency of

[PATCH v4 07/10] Reset the auto-converge counter at every checkpoint.

2021-03-24 Thread leirao
From: "Rao, Lei" if we don't reset the auto-converge counter, it will continue to run with COLO running, and eventually the system will hang due to the CPU throttle reaching DEFAULT_MIGRATE_MAX_CPU_THROTTLE. Signed-off-by: Lei Rao Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 4

[PATCH v4 01/10] Remove some duplicate trace code.

2021-03-24 Thread leirao
From: "Rao, Lei" There is the same trace code in the colo_compare_packet_payload. Signed-off-by: Lei Rao Reviewed-by: Li Zhijian --- net/colo-compare.c | 13 - 1 file changed, 13 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 9d1ad99..c142c08 100644 ---

[PATCH v4 00/10] Fixed some bugs and optimized some codes for COLO

2021-03-24 Thread leirao
From: Rao, Lei Changes since v3: --Remove cpu_throttle_stop from mig_throttle_counter_reset. Changes since v2: --Add a function named packet_new_nocopy. --Continue to optimize the function of colo_flush_ram_cache. Changes since v1: --Reset the state of the

Questions about qtest on interrupt controller

2021-03-24 Thread LIU Zhiwei
Hi folks, When I am writing  qtest  cases for an interrupt controller,  I encounter some problems. *1) Can't intercept both the irq in and irq out for the same device.* It's a necessary feature for an interrupt controller qtest. However, as you can see  from qtest.c,  when a device has

Re: [PULL V2 16/20] qapi: net: Add query-netdev command

2021-03-24 Thread Jason Wang
在 2021/3/17 上午11:34, Jason Wang 写道: 在 2021/3/17 上午5:37, Peter Maydell 写道: On Mon, 15 Mar 2021 at 09:15, Jason Wang wrote: From: Alexey Kirillov The query-netdev command is used to get the configuration of the current network device backends (netdevs). This is the QMP analog of the HMP

RE: [PATCH v3 07/10] Reset the auto-converge counter at every checkpoint.

2021-03-24 Thread Rao, Lei
After testing, I think you are right. Will remove the cpu_throttle_stop() in V4. Thanks, Lei. -Original Message- From: Dr. David Alan Gilbert Sent: Thursday, March 25, 2021 12:40 AM To: Rao, Lei Cc: Zhang, Chen ; lizhij...@cn.fujitsu.com; jasow...@redhat.com; quint...@redhat.com;

Re: [PATCH 3/3] tests: Aspeed HACE Scatter-Gather tests

2021-03-24 Thread Joel Stanley
On Wed, 24 Mar 2021 at 22:39, Klaus Heinrich Kiwi wrote: > > Expand current Aspeed HACE testsuite to also include Scatter-Gather of > sha256 and sha512 operations. > > Signed-off-by: Klaus Heinrich Kiwi > --- > tests/qtest/aspeed_hace-test.c | 164 ++--- > 1 file

Re: [PATCH v10 0/7] Pegasos2 emulation

2021-03-24 Thread David Gibson
On Tue, Mar 23, 2021 at 01:57:25PM +0100, BALATON Zoltan wrote: > On Tue, 23 Mar 2021, David Gibson wrote: > > On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: > > > Hello, > > > > > > This is adding a new PPC board called pegasos2. More info on it can be > > > found at: > > > > >

Re: [PATCH v10 7/7] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-03-24 Thread David Gibson
On Wed, Mar 24, 2021 at 12:21:02PM +0100, BALATON Zoltan wrote: > On Wed, 24 Mar 2021, David Gibson wrote: > > On Tue, Mar 23, 2021 at 02:01:27PM +0100, BALATON Zoltan wrote: > > > On Tue, 23 Mar 2021, David Gibson wrote: > > > > On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: > >

Re: [PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-03-24 Thread David Gibson
On Wed, Mar 24, 2021 at 12:11:50PM +0100, BALATON Zoltan wrote: > On Wed, 24 Mar 2021, David Gibson wrote: > > On Tue, Mar 23, 2021 at 02:31:07PM +0100, BALATON Zoltan wrote: > > > On Tue, 23 Mar 2021, David Gibson wrote: > > > > On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: > >

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-24 Thread David Gibson
On Wed, Mar 24, 2021 at 04:09:59PM -0300, Daniel Henrique Barboza wrote: > > > On 3/23/21 10:40 PM, David Gibson wrote: > > On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 3/22/21 10:12 PM, David Gibson wrote: > > > > On Fri, Mar 12, 2021 at

Re: [PATCH v3 2/3] spapr: nvdimm: Implement H_SCM_FLUSH hcall

2021-03-24 Thread David Gibson
On Wed, Mar 24, 2021 at 09:34:06AM +0530, Aneesh Kumar K.V wrote: > On 3/24/21 8:37 AM, David Gibson wrote: > > On Tue, Mar 23, 2021 at 09:47:38AM -0400, Shivaprasad G Bhat wrote: > > > The patch adds support for the SCM flush hcall for the nvdimm devices. > > > To be available for exploitation by

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-24 Thread Keqian Zhu
Peter, On 2021/3/24 23:09, Peter Xu wrote: > On Wed, Mar 24, 2021 at 10:56:22AM +0800, Keqian Zhu wrote: >> Hi Peter, >> >> On 2021/3/23 22:34, Peter Xu wrote: >>> Keqian, >>> >>> On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote: >> The second question is that you observed longer

Re: [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation

2021-03-24 Thread Klaus Heinrich Kiwi
Hi Cedric, On 3/24/2021 7:57 PM, Cédric Le Goater wrote: On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote: Basically using camelCase for some variables... I don't think CamelCase applies to variables, only types. Thanks, I think I mis-interpreted your comment on this. Will re-factor the

[ANNOUNCE] QEMU 6.0.0-rc0 is now available

2021-03-24 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 6.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-6.0.0-rc0.tar.xz

Re: [PATCH v2 03/10] Python: add utility function for retrieving port redirection

2021-03-24 Thread Cleber Rosa
On Wed, Mar 24, 2021 at 05:35:07PM -0300, Willian Rampazzo wrote: > On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote: > > > > Slightly different versions for the same utility code are currently > > present on different locations. This unifies them all, giving > > preference to the version from

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-24 Thread Cleber Rosa
On Wed, Mar 24, 2021 at 11:36:53AM +0100, Auger Eric wrote: > Hi Cleber, > On 3/23/21 11:15 PM, Cleber Rosa wrote: > > For users of the LinuxTest class, let's set up the VM with the port > > redirection for SSH, instead of requiring each test to set the same > > arguments. > > > > Signed-off-by:

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-24 Thread Cleber Rosa
On Wed, Mar 24, 2021 at 10:10:50AM +0100, Auger Eric wrote: > Hi Cleber, > > On 3/23/21 11:15 PM, Cleber Rosa wrote: > > For users of the LinuxTest class, let's set up the VM with the port > > redirection for SSH, instead of requiring each test to set the same > also sets the network device to

Re: gitlab-ci: Only build /staging branch?

2021-03-24 Thread Cleber Rosa
On Wed, Mar 24, 2021 at 07:01:12PM +0100, Philippe Mathieu-Daudé wrote: > Hi, > > Peter's current workflow is push to /staging and if his > testing succeeds, he pushes the same commit as /master. > > IMO there is no point in building /master branch, as it > has already been built earlier as

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-24 Thread Cleber Rosa
On Wed, Mar 24, 2021 at 12:30:18PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Mar 24, 2021 at 2:23 AM Cleber Rosa wrote: > > > For users of the LinuxTest class, let's set up the VM with the port > > redirection for SSH, instead of requiring each test to set the same > > arguments. > > > >

Re: [PATCH v2 04/10] Acceptance Tests: move useful ssh methods to base class

2021-03-24 Thread Cleber Rosa
On Wed, Mar 24, 2021 at 10:07:31AM +0100, Auger Eric wrote: > Hi Cleber, > > On 3/23/21 11:15 PM, Cleber Rosa wrote: > > Both the virtiofs submounts and the linux ssh mips malta tests > > contains useful methods related to ssh that deserve to be made > > available to other tests. Let's move them

Re: [PATCH v2 07/10] Acceptance Tests: set up SSH connection by default after boot for LinuxTest

2021-03-24 Thread Cleber Rosa
On Wed, Mar 24, 2021 at 10:22:47AM +0100, Auger Eric wrote: > Hi Cleber, > > On 3/23/21 11:15 PM, Cleber Rosa wrote: > > The LinuxTest specifically targets users that need to interact with Linux > > guests. So, it makes sense to give a connection by default, and avoid > > requiring it as

Re: [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation

2021-03-24 Thread Cédric Le Goater
On 3/24/21 11:38 PM, Klaus Heinrich Kiwi wrote: > Basically using camelCase for some variables... I don't think CamelCase applies to variables, only types. https://qemu.readthedocs.io/en/latest/devel/style.html#variable-naming-conventions C. > > Signed-off-by: Klaus Heinrich Kiwi > ---

Re: [PATCH 0/6] hw/southbridge: QOM'ify vt82c686 as VT82C686B_SOUTHBRIDGE

2021-03-24 Thread BALATON Zoltan
On Wed, 24 Mar 2021, Philippe Mathieu-Daudé wrote: The motivation behind this series is to remove the isa_get_irq(NULL) call to simplify the ISA generic model. Could you please wait with this until after my pegasos2 series is merged? Otherwise I'll have to rewrite that again for which I don't

[PATCH 3/3] tests: Aspeed HACE Scatter-Gather tests

2021-03-24 Thread Klaus Heinrich Kiwi
Expand current Aspeed HACE testsuite to also include Scatter-Gather of sha256 and sha512 operations. Signed-off-by: Klaus Heinrich Kiwi --- tests/qtest/aspeed_hace-test.c | 164 ++--- 1 file changed, 153 insertions(+), 11 deletions(-) diff --git

[PATCH 2/3] aspeed: Add Scater-Gather support for HACE Hash

2021-03-24 Thread Klaus Heinrich Kiwi
Complement the Aspeed HACE support with Scatter-Gather hash support for sha256 and sha512. Scatter-Gather is only supported on AST2600-series. Signed-off-by: Klaus Heinrich Kiwi --- hw/misc/aspeed_hace.c | 127 -- include/hw/misc/aspeed_hace.h | 6 ++ 2

[PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation

2021-03-24 Thread Klaus Heinrich Kiwi
Basically using camelCase for some variables... Signed-off-by: Klaus Heinrich Kiwi --- hw/misc/aspeed_hace.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 6e5b447a48..93313d2b80 100644 ---

[PATCH 0/3] aspeed: HACE hash Scatter-Gather support

2021-03-24 Thread Klaus Heinrich Kiwi
This series adds support for scatter-gather sha256 and sha512 operations on Aspeed's HACE (Hash And Crypto Engine) to the Aspeed model. These operations are supported on AST2600 series of machines. -Klaus

Re: [RFC v11 34/55] target/arm: remove broad "else" statements when checking accels

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: @@ -296,7 +297,8 @@ void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp) */ bitmap_andnot(tmp, kvm_supported, cpu->sve_vq_init, max_vq); bitmap_or(cpu->sve_vq_map, cpu->sve_vq_map, tmp, max_vq); -} else

Re: [RFC v11 32/55] target/arm: move kvm-const.h, kvm.c, kvm64.c, kvm_arm.h to kvm/

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: target/arm/kvm-stub.c | 24 Can you really get rid of this? If so, I think this should be a separate step. --- a/target/arm/kvm/meson.build +++ b/target/arm/kvm/meson.build @@ -1,3 +1,8 @@ arm_ss.add(when:

Re: [RFC v11 31/55] target/arm: remove kvm include file for PSCI and arm-powerctl

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: The QEMU PSCI implementation is not used for KVM, we do not need the kvm constants header. Signed-off-by: Claudio Fontana --- target/arm/arm-powerctl.h | 2 -- target/arm/psci.c | 1 - 2 files changed, 3 deletions(-) Reviewed-by: Richard

Re: [RFC v11 30/55] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: After this patch it is possible to build only kvm: ./configure --disable-tcg --enable-kvm Signed-off-by: Claudio Fontana --- target/arm/cpu-sysemu.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson

Re: [RFC v11 29/55] target/arm: cpu: fix style

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: Signed-off-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daudé --- target/arm/cpu-sysemu.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) Obviously, this should be done before the code moves. r~

Re: [RFC v11 28/55] target/arm: refactor exception and cpu code

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: move exception code out of tcg/ as we need part of it for KVM too. put the exception code into separate cpu modules as appropriate, including: cpu-sysemu.c tcg/tcg-cpu.c tcg/sysemu/tcg-cpu.c to avoid naming confusion with the existing cpu_tcg.c,

Re: [RFC v11 27/55] target/arm: move sve_exception_el out of TCG helpers

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: we need this for KVM too. Signed-off-by: Claudio Fontana --- target/arm/cpu-sysemu.c | 60 target/arm/cpu-user.c | 5 target/arm/tcg/helper.c | 61 - 3 files

Re: [RFC v11 26/55] target/arm: split a15 cpu model and 32bit class functions to cpu32.c

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: -static void arm_cpu_dump_state(CPUState *cs, FILE *f, int flags) -{ -ARMCPU *cpu = ARM_CPU(cs); -CPUARMState *env = >env; -int i; - -if (is_a64(env)) { -aarch64_cpu_dump_state(cs, f, flags); -return; -} You've lost

Re: [RFC v11 25/55] target/arm: move aarch64_sync_32_to_64 (and vv) to cpu code

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: + + + Watch the excessive whitespace. Otherwise, Reviewed-by: Richard Henderson r~

Re: [RFC v11 23/55] target/arm: move arm_sctlr away from tcg helpers

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: this function is used for kvm too, add it to the cpu-common module. Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson /* #endif TARGET_AARCH64 , see matching comment above */ + +uint64_t arm_sctlr(CPUARMState *env, int el) +{ +

Re: [RFC v11 22/55] target/arm: move sve_zcr_len_for_el to common_cpu

2021-03-24 Thread Richard Henderson
On 3/23/21 9:46 AM, Claudio Fontana wrote: it is required by arch-dump.c and cpu.c, so apparently we need this for KVM too Signed-off-by: Claudio Fontana Reviewed-by: Richard Henderson +/* + * these are AARCH64-only, but due to the chain of dependencies, + * between HELPER prototypes,

Re: gitlab-ci: Only build /staging branch?

2021-03-24 Thread Philippe Mathieu-Daudé
On 3/24/21 7:33 PM, Philippe Mathieu-Daudé wrote: > On 3/24/21 7:01 PM, Philippe Mathieu-Daudé wrote: >> Hi, >> >> Peter's current workflow is push to /staging and if his >> testing succeeds, he pushes the same commit as /master. >> >> IMO there is no point in building /master branch, as it >> has

[Bug 1921092] Re: gdbstub debug of multi-cluster machines is undocumented and confusing

2021-03-24 Thread Martin Schönstedt
Thanks for the answer, indeed the second cluster of the board has been halted when I was starting gdb the "normal" way - not adding the second inferior. In my own research I did not find out about these inferiors, so I was wondering why "info threads" did only show one cpu. Maybe gdb could inform

[Bug 1918084] Re: Build fails on macOS 11.2.2

2021-03-24 Thread Eddy Hahn
I pulled the latest it got a bit further :-) In file included from ../disas/arm-a64.cc:21: In file included from /opt/build/build/stage/qemu/include/qemu/osdep.h:126: In file included from /opt/build/build/stage/qemu/include/glib-compat.h:32: In file included from

Re: [PATCH v4 00/11] 64bit block-layer: part II

2021-03-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210324205132.464899-1-vsement...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210324205132.464899-1-vsement...@virtuozzo.com Subject: [PATCH v4 00/11] 64bit

[Bug 1921280] [NEW] OpenIndiana stuck in boot loop when using hvf

2021-03-24 Thread Mohamed
Public bug reported: I'm using QEMU version 5.2.0 on macOS, and running the "OpenIndiana Hipster 2020.10 Text Install DVD (64-bit x86)" ISO: qemu-system-x86_64 -cdrom ~/Downloads/OI-hipster-text-20201031.iso -m 2048 -accel hvf -cpu host It gets to "Booting...", stays there for a bit, and then

Re: [PATCH v3 04/16] qapi/expr.py: Add assertion for union type 'check_dict'

2021-03-24 Thread John Snow
On 2/24/21 5:35 AM, Markus Armbruster wrote: John Snow writes: mypy isn't fond of allowing you to check for bool membership in a collection of str elements. Guard this lookup for precisely when we were given a name. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber

[PATCH v4 11/11] block/io: allow 64bit discard requests

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
Now, when all drivers are updated by previous commit, we can drop the last limiter on pdiscard path: INT_MAX in bdrv_co_pdiscard(). Now everything is prepared for implementing incredibly cool and fast big-discard requests in NBD and qcow2. And any other driver which wants it of course.

[PATCH v4 10/11] block: use int64_t instead of int in driver discard handlers

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with

[PATCH v4 06/11] block: make BlockLimits::max_pwrite_zeroes 64bit

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We are going to support 64 bit write-zeroes requests. Now update the limit variable. It's absolutely safe. The variable is set in some drivers, and used in bdrv_co_do_pwrite_zeroes(). Update also max_write_zeroes variable in bdrv_co_do_pwrite_zeroes(), so that bdrv_co_do_pwrite_zeroes() is now

[PATCH v4 03/11] block: use int64_t instead of uint64_t in driver read handlers

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We are going to convert .bdrv_co_preadv_part and .bdrv_co_pwritev_part to int64_t type for offset and bytes parameters (as it's already done for generic block/io.c layer). In qcow2 .bdrv_co_preadv_part is used in some places, so let's add corresponding checks and assertions. Signed-off-by:

[PATCH v4 08/11] block/io: allow 64bit write-zeroes requests

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
Now, when all drivers are updated by previous commit, we can drop two last limiters on write-zeroes path: INT_MAX in bdrv_co_do_pwrite_zeroes() and bdrv_check_request32() in bdrv_co_pwritev_part(). Now everything is prepared for implementing incredibly cool and fast big-write-zeroes in NBD and

[PATCH v4 09/11] block: make BlockLimits::max_pdiscard 64bit

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We are going to support 64 bit discard requests. Now update the limit variable. It's absolutely safe. The variable is set in some drivers, and used in bdrv_co_pdiscard(). Update also max_pdiscard variable in bdrv_co_pdiscard(), so that bdrv_co_pdiscard() is now prepared to 64bit requests. The

[PATCH v4 01/11] block/io: bring request check to bdrv_co_{read, write}v_vmstate

2021-03-24 Thread Vladimir Sementsov-Ogievskiy via
There are only two drivers supporting vmstate: qcow2 and sheepdog. Sheepdog is deprecated. In qcow2 these requests go through .bdrv_co_p{read,write}v_part handlers. So, let's do our basic check for the request on vmstate generic handlers. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[PATCH v4 04/11] block: use int64_t instead of uint64_t in driver write handlers

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with

[PATCH v4 07/11] block: use int64_t instead of int in driver write_zeroes handlers

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with

[PATCH v4 05/11] block: use int64_t instead of uint64_t in copy_range driver handlers

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with

[PATCH v4 02/11] qcow2: check request on vmstate save/load path

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
We modify the request by adding an offset to vmstate. Let's check the modified request. It will help us to safely move .bdrv_co_preadv_part and .bdrv_co_pwritev_part to int64_t type of offset and bytes. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 3 +++

[PATCH v4 00/11] 64bit block-layer: part II

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is part II of 64bit block-layer, when part I already landed ([PATCH v4 00/16] 64bit block-layer: part I <20201211183934.169161-1-vsement...@virtuozzo.com>) This is called v4 too, because it follows old ([PATCH v3 00/17] 64bit block-layer

Re: [PATCH v2 08/10] tests/acceptance/virtiofs_submounts.py: remove launch_vm()

2021-03-24 Thread Willian Rampazzo
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote: > > The LinuxTest class' launch_and_wait() method now behaves the same way > as this test's custom launch_vm(), so let's just use the upper layer > (common) method. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/virtiofs_submounts.py |

Re: [PATCH] device-crash-test: Ignore errors about a bus not being available

2021-03-24 Thread John Snow
On 3/23/21 12:47 PM, Thomas Huth wrote: Recent QEMU versions now sometimes exit cleanly with an error message that a bus is not available for a specified device. Don't flag those as an error in the device-crash-test script. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 1 + 1

Re: [PATCH v2 07/10] Acceptance Tests: set up SSH connection by default after boot for LinuxTest

2021-03-24 Thread Willian Rampazzo
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote: > > The LinuxTest specifically targets users that need to interact with Linux > guests. So, it makes sense to give a connection by default, and avoid > requiring it as boiler-plate code. > > Signed-off-by: Cleber Rosa > --- >

Re: [PATCH v2 06/10] Acceptance Tests: make username/password configurable

2021-03-24 Thread Willian Rampazzo
On Tue, Mar 23, 2021 at 7:16 PM Cleber Rosa wrote: > > This makes the username/password used for authentication configurable, > because some guest operating systems may have restrictions on accounts > to be used for logins, and it just makes it better documented. > > Signed-off-by: Cleber Rosa >

  1   2   3   4   >