Re: [RFC 00/10] hw/mos6522: VIA timer emulation fixes and improvements

2021-08-27 Thread Finn Thain
On Wed, 25 Aug 2021, Mark Cave-Ayland wrote: > On 24/08/2021 11:09, Finn Thain wrote: > > > This is a patch series that I started last year. The aim was to try to > > get a monotonic clocksource for Linux/m68k guests. That aim hasn't been > > achieved yet (for q800 machines) but I'm submitting

Re: [PATCH v2 8/8] tests/tcg: Add arm and aarch64 pc alignment tests

2021-08-27 Thread Richard Henderson
On 8/26/21 6:54 AM, Peter Maydell wrote: On Sat, 21 Aug 2021 at 21:09, Richard Henderson wrote: +/* + * From v8, it is CONSTRAINED UNPREDICTABLE whether BXWritePC aligns + * the address or not. If so, we can legitimately fall through. + */ +return EXIT_SUCCESS; +} Can

Re: [RFC 00/10] hw/mos6522: VIA timer emulation fixes and improvements

2021-08-27 Thread Finn Thain
On Tue, 24 Aug 2021, Philippe Mathieu-Daudé wrote: > On 8/24/21 12:09 PM, Finn Thain wrote: > > > On a real Quadra, accesses to the SY6522 chips are slow because they are > > synchronous with the 783360 Hz "phase 2" clock. In QEMU, they are slow > > only because of the division operation in

Re: [RFC 01/10] hw/mos6522: Remove get_load_time() methods and functions

2021-08-27 Thread Finn Thain
On Wed, 25 Aug 2021, Mark Cave-Ayland wrote: > On 24/08/2021 11:09, Finn Thain wrote: > > > This code appears to be unnecessary. > > > > Signed-off-by: Finn Thain > > --- > > hw/misc/mos6522.c | 22 +- > > 1 file changed, 1 insertion(+), 21 deletions(-) > > > > diff

Re: [RFC 07/10] hw/mos6522: Fix initial timer counter reload

2021-08-27 Thread Finn Thain
On Wed, 25 Aug 2021, Mark Cave-Ayland wrote: > On 24/08/2021 11:09, Finn Thain wrote: > > > The first reload of timer 1 is early by half of a clock cycle as it gets > > measured from a falling edge. By contrast, the succeeding reloads are > > measured from rising edge to rising edge. > > > >

Re: [PATCH 1/5] hw/arm/aspeed: Add get_irq to AspeedSoCClass

2021-08-27 Thread Peter Delevoryas
Just noticed, I forgot to initialize get_irq for the AST2500. I didn’t notice it because I hadn’t tested booting an image for -machine ast2500-evb. I’ll make sure to test with images for all 3 chip revisions, then I’ll resubmit with PATCH v2. I’ll wait a little while though, for comments on the

[PATCH 2/5] hw/arm/aspeed: Select console UART from machine

2021-08-27 Thread pdel
From: Peter Delevoryas This change replaces the UART serial device initialization code with machine configuration data, making it so that we have a single code path for console UART initialization, but allowing different machines to use different UART's. This is relevant because the Aspeed chips

[PATCH 1/5] hw/arm/aspeed: Add get_irq to AspeedSoCClass

2021-08-27 Thread pdel
From: Peter Delevoryas The AST2500 uses different logic than the AST2600 for getting IRQ's. This adds a virtual `get_irq` function to the Aspeed SOC class, so that the shared initialization code in `hw/arm/aspeed.c` can retrieve IRQ's. Signed-off-by: Peter Delevoryas ---

[PATCH 3/5] hw/arm/aspeed: Add fuji machine type

2021-08-27 Thread pdel
From: Peter Delevoryas Fuji uses the AST2600, so it's very similar to `ast2600-evb`, but it has a few slight differences, such as using UART1 for the serial console. Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH 4/5] hw/arm/aspeed: Fix AST2600_CLK_SEL3 address

2021-08-27 Thread pdel
From: Peter Delevoryas This register address is not actually used anywhere, and the datasheet specifies that it's zero-initialized by default anyways, but the address is incorrect. This just corrects the address. Fixes: e09cf36321f6 ("hw: aspeed_scu: Add AST2600 support") Signed-off-by: Peter

[PATCH 5/5] hw/arm/aspeed: Initialize AST2600 clock selection registers

2021-08-27 Thread pdel
From: Peter Delevoryas UART5 is typically used as the default debug UART on the AST2600, but UART1 is also designed to be a debug UART. All the AST2600 UART's have semi-configurable clock rates through registers in the System Control Unit (SCU), but only UART5 works out of the box with

[PATCH 0/5] hw/arm/aspeed: Add fuji machine type

2021-08-27 Thread pdel
From: Peter Delevoryas Hello! This patch series creates an Aspeed machine type for Facebook's OpenBMC platform "fuji". The first 2 commits do some refactoring, to allow Aspeed machines to configure the first serial device. Most board configurations use UART5 for the console, but fuji uses

[PATCH] block/export/fuse.c: fix fuse-lseek on uclibc or musl

2021-08-27 Thread Fabrice Fontaine
Include linux/fs.h to avoid the following build failure on uclibc or musl raised since version 6.0.0: ../block/export/fuse.c: In function 'fuse_lseek': ../block/export/fuse.c:641:19: error: 'SEEK_HOLE' undeclared (first use in this function) 641 | if (whence != SEEK_HOLE && whence !=

Re: [PATCH v6 10/10] ACPI ERST: step 6 of bios-tables-test

2021-08-27 Thread Eric DeVolder
Igor, I'm not sure if I should post v7 with the correction to the tables, or await your guidance/feedback on v6. Thanks, eric On 8/6/21 12:16 PM, Eric DeVolder wrote: Well, I discovered today that running "make check" again resulted in bios table mismatches. In looking into this further, I

Re: [PATCH v2 38/43] bsd-user: Refactor load_elf_sections and is_target_elf_binary

2021-08-27 Thread Warner Losh
> On Aug 26, 2021, at 3:11 PM, i...@bsdimp.com wrote: > > From: Warner Losh > > Factor out load_elf_sections and is_target_elf_binary out of > load_elf_interp. > > Signed-off-by: Mikaël Urankar > Signed-off-by: Stacey Son > Signed-off-by: Warner Losh > --- > bsd-user/elfload.c | 350

Re: [PATCH] Report any problems with loading the VGA driver for PPC Macintosh targets

2021-08-27 Thread BALATON Zoltan
On Fri, 27 Aug 2021, John Arbuckle wrote: I was having a problem with missing video resolutions in my Mac OS 9 VM. When I ran QEMU it gave no indication as to why these resolutions were missing. I found out that the OpenFirmware VGA driver was not being loaded. To prevent anyone from going thru

Re: [PATCH] qapi: Set boolean value correctly in examples

2021-08-27 Thread Eric Blake
On Fri, Aug 27, 2021 at 05:06:27PM +0800, Guoyi Tu wrote: > > Signed-off-by: Guoyi Tu > --- > qapi/trace.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/qapi/trace.json b/qapi/trace.json > index 47c68f04da..eedfded512 100644 > ---

Re: [PATCH 2/2] Prevent vhost-user-blk-test hang

2021-08-27 Thread ebl...@redhat.com
On Fri, Aug 27, 2021 at 04:50:47PM +, Raphael Norwitz wrote: > In the vhost-user-blk-test, as of now there is nothing stoping stopping > vhost-user-blk in QEMU writing to the socket right after forking off the > storage daemon before it has a chance to come up properly, leaving the > test

Re: [PATCH 1/2] storage-daemon: add opt to print when initialized

2021-08-27 Thread ebl...@redhat.com
On Fri, Aug 27, 2021 at 04:50:35PM +, Raphael Norwitz wrote: > This change adds a command line option to print a line to standard out > when the storage daemon has completed initialization and is ready to > serve client connections. > > This option will be used to resolve a hang in the

Re: [FSL P50x0] lscpu reports wrong values since the RC1 of kernel 5.13

2021-08-27 Thread Christian Zigotzky
> On 26. Aug 2021, at 05:43, Srikar Dronamraju > wrote: > > * Christian Zigotzky [2021-08-16 14:29:21]: > > > Hi Christian, > >> I tested the RC6 of kernel 5.14 today and unfortunately the issue still >> exists. We have figured out that only P5040 SoCs are affected. [1] >> P5020 SoCs

[PATCH v2 18/19] qapi: backup: add immutable-source parameter

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
We are on the way to implement internal-backup with fleecing scheme, which includes backup job copying from fleecing block driver node (which is target of copy-before-write filter) to final target of backup. This job doesn't need own filter, as fleecing block driver node is a kind of snapshot,

Re: [PATCH] nbd/server: Advertise MULTI_CONN for shared writable exports

2021-08-27 Thread Eric Blake
On Fri, Aug 27, 2021 at 07:58:10PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 27.08.2021 18:09, Eric Blake wrote: > > According to the NBD spec, a server advertising > > NBD_FLAG_CAN_MULTI_CONN promises that multiple client connections will > > not see any cache inconsistencies: when properly

[PATCH v2 17/19] block: blk_root(): return non-const pointer

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
In the following patch we'll want to pass blk children to block-copy. Const pointers are not enough. So, return non const pointer from blk_root(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/block-backend.h | 2 +- block/block-backend.c | 2 +- 2 files changed, 2

Re: [PATCH v2 0/2] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/27/21 8:01 PM, Willian Rampazzo wrote: > Hi, Phil, > > On Thu, Aug 26, 2021 at 1:49 PM Philippe Mathieu-Daudé > wrote: >> >> Hi Peter, >> >> On 7/9/21 6:00 PM, Peter Maydell wrote: >>> On Fri, 9 Jul 2021 at 16:33, Peter Maydell wrote: On Thu, 8 Jul 2021 at 15:55, Philippe

[PATCH v2 15/19] iotests.py: add qemu_io_pipe_and_status()

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Add helper that returns both status and output, to be used in the following commit Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index

[PATCH v2 10/19] block: introduce fleecing block driver

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Introduce a new driver, that works in pair with copy-before-write to improve fleecing. Without fleecing driver, old fleecing scheme looks as follows: [guest] | |root v [copy-before-write] -> [temp.qcow2] <--- [nbd export] | target | |file

[PATCH v2 08/19] block/reqlist: add reqlist_wait_all()

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Add function to wait for all intersecting requests. To be used in the further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/reqlist.h | 8 block/reqlist.c | 8 2 files changed, 16 insertions(+) diff --git a/include/block/reqlist.h

[PATCH v2 11/19] block/copy-before-write: support fleecing block driver

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
The last step to make new fleecing scheme work (see block/fleecing.h for descritption) is to update copy-before-write filter: If we detect that unfiltered target child is fleecing block driver, we do: - initialize shared FleecingState - activate fleecing block driver with it - do guest write

[PATCH v2 09/19] block: introduce FleecingState class

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
FleecingState represents state shared between copy-before-write filter and upcoming fleecing block driver. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/fleecing.h | 135 ++ block/fleecing.c | 182 ++

[PATCH v2 19/19] iotests/image-fleecing: test push backup with fleecing

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Add test for push backup with fleecing: - start fleecing with copy-before-write filter - start a backup job from temporary fleecing node to actual backup target Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/image-fleecing | 121 ++--

[PATCH v2 13/19] block/copy-before-write: use write-unchanged in fleecing mode

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
As announced in previous commit, we need use write-unchanged operations for fleecing, so that fleecing client may unshare writes if needed. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-before-write.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[PATCH v2 00/19] Make image fleecing more usable

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Hi all! That continues "[PATCH RFC DRAFT 00/11] Make image fleecing more usable" and supersedes "[PATCH v2 for-6.2 0/6] push backup with fleecing" Supersedes: <20210804131750.127574-1-vsement...@virtuozzo.com> Supersedes: <20210721140424.163701-1-vsement...@virtuozzo.com> There several

[PATCH v2 01/19] block/block-copy: move copy_bitmap initialization to block_copy_state_new()

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
We are going to complicate bitmap initialization in the further commit. And in future, backup job will be able to work without filter (when source is immutable), so we'll need same bitmap initialization in copy-before-write filter and in backup job. So, it's reasonable to do it in block-copy.

[PATCH v2 03/19] block/block-copy: block_copy_state_new(): add bitmap parameter

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
This will be used in the following commit to bring "incremental" mode to copy-before-write filter. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 2 +- block/block-copy.c | 14 -- block/copy-before-write.c | 2 +- 3 files changed, 14

[PATCH v2 04/19] block/copy-before-write: add bitmap open parameter

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
This brings "incremental" mode to copy-before-write filter: user can specify bitmap so that filter will copy only "dirty" areas. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 10 +- block/copy-before-write.c | 30 +- 2 files

[PATCH v2 06/19] block: intoduce reqlist

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Split intersecting-requests functionality out of block-copy to be reused in copy-before-write filter. Note: while being here, fix tiny typo in MAINTAINERS. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/reqlist.h | 67 +++ block/block-copy.c | 116

[PATCH v2 16/19] iotests/image-fleecing: add test case with bitmap

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Note that reads zero areas (not dirty in the bitmap) fails, that's correct. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/image-fleecing | 32 ++-- tests/qemu-iotests/tests/image-fleecing.out | 84 + 2 files changed, 108 insertions(+), 8

[PATCH v2 14/19] iotests/image-fleecing: add test-case for fleecing format node

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/image-fleecing | 67 +-- tests/qemu-iotests/tests/image-fleecing.out | 74 - 2 files changed, 121 insertions(+), 20 deletions(-) diff --git a/tests/qemu-iotests/tests/image-fleecing

[PATCH v2 02/19] block/dirty-bitmap: bdrv_merge_dirty_bitmap(): add return value

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
That simplifies handling failure in existing code and in further new usage of bdrv_merge_dirty_bitmap(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h| 2 +- block/dirty-bitmap.c| 9 +++-- block/monitor/bitmap-qmp-cmds.c | 5 + 3 files

[PATCH v2 12/19] block/block-copy: add write-unchanged mode

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
We are going to implement push backup with fleecing scheme. This means that backup job will be a fleecing user and therefore will not need separate copy-before-write filter. Instead it will consider source as constant unchanged drive. Of course backup will want to unshare writes on source for this

[PATCH v2 07/19] block/dirty-bitmap: introduce bdrv_dirty_bitmap_status()

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Add a convenient function similar with bdrv_block_status() to get status of dirty bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 11 +++ block/dirty-bitmap.c | 6 ++ util/hbitmap.c |

[PATCH v2 05/19] block/block-copy: add block_copy_reset()

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
Split block_copy_reset() out of block_copy_reset_unallocated() to be used separately later. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 1 + block/block-copy.c | 21 + 2 files changed, 14 insertions(+), 8 deletions(-) diff --git

Re: [PATCH RFC server v2 01/11] vfio-user: build library

2021-08-27 Thread Jag Raman
> On Aug 27, 2021, at 1:53 PM, Jag Raman wrote: > > add the libvfio-user library as a submodule. build it as a cmake > subproject. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > configure| 11 +++ >

[PATCH RFC server v2 09/11] vfio-user: handle device interrupts

2021-08-27 Thread Jagannathan Raman
Forward remote device's interrupts to the guest Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/hw/remote/iohub.h | 2 ++ hw/remote/iohub.c | 5 + hw/remote/vfio-user-obj.c | 30 ++

[PATCH] Report any problems with loading the VGA driver for PPC Macintosh targets

2021-08-27 Thread John Arbuckle
I was having a problem with missing video resolutions in my Mac OS 9 VM. When I ran QEMU it gave no indication as to why these resolutions were missing. I found out that the OpenFirmware VGA driver was not being loaded. To prevent anyone from going thru the same trouble I went thru I added

Re: [PATCH v2 0/2] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

2021-08-27 Thread Willian Rampazzo
Hi, Phil, On Thu, Aug 26, 2021 at 1:49 PM Philippe Mathieu-Daudé wrote: > > Hi Peter, > > On 7/9/21 6:00 PM, Peter Maydell wrote: > > On Fri, 9 Jul 2021 at 16:33, Peter Maydell wrote: > >> > >> On Thu, 8 Jul 2021 at 15:55, Philippe Mathieu-Daudé > >> wrote: > >>> > >>> Since v1: > >>> -

[PATCH RFC server v2 08/11] vfio-user: handle PCI BAR accesses

2021-08-27 Thread Jagannathan Raman
Determine the BARs used by the PCI device and register handlers to manage the access to the same. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 95 +++

[PATCH RFC server v2 06/11] vfio-user: handle PCI config space accesses

2021-08-27 Thread Jagannathan Raman
Define and register handlers for PCI config space accesses Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 44 hw/remote/trace-events| 2 ++ 2 files changed, 46

Re: [PATCH] nbd/server: Advertise MULTI_CONN for shared writable exports

2021-08-27 Thread Eric Blake
On Fri, Aug 27, 2021 at 05:48:10PM +0100, Richard W.M. Jones wrote: > On Fri, Aug 27, 2021 at 10:09:16AM -0500, Eric Blake wrote: > > +# Parallel client connections are easier with libnbd than qemu-io: > > +if ! (nbdsh --version) >/dev/null 2>&1; then > > I'm curious why the parentheses are

[PATCH RFC server v2 10/11] vfio-user: register handlers to facilitate migration

2021-08-27 Thread Jagannathan Raman
Store and load the device's state during migration. use libvfio-user's handlers for this purpose Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- migration/savevm.h| 2 + hw/remote/vfio-user-obj.c | 313

[PATCH RFC server v2 05/11] vfio-user: run vfio-user context

2021-08-27 Thread Jagannathan Raman
Setup a handler to run vfio-user context. The context is driven by messages to the file descriptor associated with it - get the fd for the context and hook up the handler with it Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman ---

[PATCH RFC server v2 07/11] vfio-user: handle DMA mappings

2021-08-27 Thread Jagannathan Raman
Define and register callbacks to manage the RAM regions used for device DMA Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 50 +++ hw/remote/trace-events| 2 ++ 2

[PATCH RFC server v2 04/11] vfio-user: find and init PCI device

2021-08-27 Thread Jagannathan Raman
Find the PCI device with specified id. Initialize the device context with the QEMU PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 28 1 file changed, 28 insertions(+) diff

[PATCH RFC server v2 03/11] vfio-user: instantiate vfio-user context

2021-08-27 Thread Jagannathan Raman
create a context with the vfio-user library to run a PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 29 + 1 file changed, 29 insertions(+) diff --git

[PATCH RFC server v2 11/11] vfio-user: acceptance test

2021-08-27 Thread Jagannathan Raman
Acceptance test for libvfio-user in QEMU Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- MAINTAINERS | 1 + tests/acceptance/vfio-user.py | 94 +++ 2 files changed, 95 insertions(+)

[PATCH RFC server v2 00/11] vfio-user server in QEMU

2021-08-27 Thread Jagannathan Raman
Hi, This series depends on the following series from Elena Ufimtseva : [PATCH RFC v2 00/16] vfio-user implementation Thank you for your feedback for the v1 patches! https://www.mail-archive.com/qemu-devel@nongnu.org/msg825021.html We have incorporated the following feedback from v1 of the

[PATCH RFC server v2 01/11] vfio-user: build library

2021-08-27 Thread Jagannathan Raman
add the libvfio-user library as a submodule. build it as a cmake subproject. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- configure| 11 +++ meson.build | 28 .gitmodules

[PATCH RFC server v2 02/11] vfio-user: define vfio-user object

2021-08-27 Thread Jagannathan Raman
Define vfio-user object which is remote process server for QEMU. Setup object initialization functions and properties necessary to instantiate the object Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- qapi/qom.json | 20 ++-

[Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2021-08-27 Thread Philippe Mathieu-Daudé
Per Brad on IRC, this issue persists. Re-opening to move to GitLab. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1819289 Title: Windows 95 and Windows 98 will not install or run Status in QEMU:

RE: [EXTERNAL] [PULL 08/15] whpx nvmm: Drop useless migrate_del_blocker()

2021-08-27 Thread Sunil Muthuswamy
> -Original Message- > From: Markus Armbruster > Sent: Thursday, August 26, 2021 9:51 PM > To: qemu-devel@nongnu.org > Cc: peter.mayd...@linaro.org; Sunil Muthuswamy ; > Kamil Rytarowski ; Reinoud Zandijk > ; Reinoud Zandijk ; Michael S . > Tsirkin > Subject: [EXTERNAL] [PULL 08/15]

Re: [PATCH] nbd/server: Advertise MULTI_CONN for shared writable exports

2021-08-27 Thread Vladimir Sementsov-Ogievskiy
27.08.2021 18:09, Eric Blake wrote: According to the NBD spec, a server advertising NBD_FLAG_CAN_MULTI_CONN promises that multiple client connections will not see any cache inconsistencies: when properly separated by a single flush, actions performed by one client will be visible to another

Re: intermittent failure, s390 host, x86-64 guest, vhost-user-blk test

2021-08-27 Thread Raphael Norwitz
On Wed, Aug 04, 2021 at 09:43:25AM -0400, Michael S. Tsirkin wrote: > On Wed, Aug 04, 2021 at 01:40:37PM +0100, Peter Maydell wrote: > > Saw this intermittent as part of my ad-hoc CI test setup. > > The backtrace says that the QEMU process has somehow hung > > during 'realize' of the vhost-user

[PATCH 2/2] Prevent vhost-user-blk-test hang

2021-08-27 Thread Raphael Norwitz
In the vhost-user-blk-test, as of now there is nothing stoping vhost-user-blk in QEMU writing to the socket right after forking off the storage daemon before it has a chance to come up properly, leaving the test hanging forever. This intermittently hanging test has caused QEMU automation failures

[PATCH 1/2] storage-daemon: add opt to print when initialized

2021-08-27 Thread Raphael Norwitz
This change adds a command line option to print a line to standard out when the storage daemon has completed initialization and is ready to serve client connections. This option will be used to resolve a hang in the vhost-user-blk-test. Signed-off-by: Raphael Norwitz ---

Re: [PATCH] nbd/server: Advertise MULTI_CONN for shared writable exports

2021-08-27 Thread Richard W.M. Jones
On Fri, Aug 27, 2021 at 10:09:16AM -0500, Eric Blake wrote: > +# Parallel client connections are easier with libnbd than qemu-io: > +if ! (nbdsh --version) >/dev/null 2>&1; then I'm curious why the parentheses are needed here? > +export nbd_unix_socket > +nbdsh -c ' > +import os > +sock =

Re: [PATCH v2 41/43] bsd-user: Implement cpu_copy() helper routine

2021-08-27 Thread Warner Losh
> On Aug 27, 2021, at 10:00 AM, Philippe Mathieu-Daudé wrote: > > On 8/27/21 4:56 PM, Warner Losh wrote: >>> On Aug 26, 2021, at 10:47 PM, Philippe Mathieu-Daudé >>> wrote: >>> >>> On 8/26/21 11:11 PM, i...@bsdimp.com wrote: From: Warner Losh cpu_copy shouldbe called when

Re: [PATCH v2 30/43] bsd-user: Remove dead #ifdefs from elfload.c

2021-08-27 Thread Warner Losh
> On Aug 27, 2021, at 9:58 AM, Philippe Mathieu-Daudé wrote: > > On 8/27/21 5:02 PM, Warner Losh wrote: >>> On Aug 26, 2021, at 10:42 PM, Philippe Mathieu-Daudé >>> wrote: >>> >>> On 8/26/21 11:11 PM, i...@bsdimp.com wrote: From: Warner Losh LOW_ELF_STACK doesn't exist on

Re: [PATCH v2 41/43] bsd-user: Implement cpu_copy() helper routine

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/27/21 4:56 PM, Warner Losh wrote: >> On Aug 26, 2021, at 10:47 PM, Philippe Mathieu-Daudé wrote: >> >> On 8/26/21 11:11 PM, i...@bsdimp.com wrote: >>> From: Warner Losh >>> >>> cpu_copy shouldbe called when processes are creating new threads. It >> >> Typo "should be" >> >>> copies the

Re: [PATCH v2 30/43] bsd-user: Remove dead #ifdefs from elfload.c

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/27/21 5:02 PM, Warner Losh wrote: >> On Aug 26, 2021, at 10:42 PM, Philippe Mathieu-Daudé wrote: >> >> On 8/26/21 11:11 PM, i...@bsdimp.com wrote: >>> From: Warner Losh >>> >>> LOW_ELF_STACK doesn't exist on FreeBSD and likely never will. Remove it. >>> Likewise, remove an #if 0 block

Re: [PATCH v2 07/43] bsd-user: move arch specific defines out of elfload.c

2021-08-27 Thread Warner Losh
> On Aug 26, 2021, at 10:19 PM, Philippe Mathieu-Daudé wrote: > > On 8/26/21 11:11 PM, i...@bsdimp.com wrote: >> From: Warner Losh >> >> Move the arcitecture specific defines to target_arch_elf.h and delete > > Typo "architecture" Thanks >> them from elfload.c. unifdef as appropriate for

Re: [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/27/21 5:17 PM, Thomas Huth wrote: > libfdt in Debian is too old to be usable for QEMU. So far we were > silently falling back to the internal dtc submodule, but since > this is wrong, let's remove the --enable-fdt=system switch here now. > > Signed-off-by: Thomas Huth > --- > Sorry, I just

Re: [PATCH v2 08/43] bsd-user: pass the bsd_param into loader_exec

2021-08-27 Thread Warner Losh
> On Aug 26, 2021, at 10:22 PM, Philippe Mathieu-Daudé wrote: > > On 8/26/21 11:11 PM, i...@bsdimp.com wrote: >> From: Warner Losh >> >> Pass the bsd_param into loader_exec, and adjust. > > Missing the "why" justification. So I am. I’ve added it and it will be in v3 of the patches. It’s

Re: [PATCH v2 19/43] bsd-user: start to move target CPU functions to target_arch*

2021-08-27 Thread Warner Losh
> On Aug 26, 2021, at 10:39 PM, Philippe Mathieu-Daudé wrote: > > On 8/26/21 11:11 PM, i...@bsdimp.com wrote: >> From: Warner Losh >> >> Move the CPU functons into target_arch_cpu.c that are unique to each > > Typo "functions" doh! Thanks! >> CPU. These are defined in target_arch.h. >>

[PATCH v4] hw/intc/sifive_clint: Fix muldiv64 overflow in sifive_clint_write_timecmp()

2021-08-27 Thread David Hoppenbrouwers
`muldiv64` would overflow in cases where the final 96-bit value does not fit in a `uint64_t`. This would result in small values that cause an interrupt to be triggered much sooner than intended. The overflow can be detected in most cases by checking if the new value is smaller than the previous

Re: [PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job

2021-08-27 Thread Daniel P . Berrangé
On Fri, Aug 27, 2021 at 05:17:18PM +0200, Thomas Huth wrote: > libfdt in Debian is too old to be usable for QEMU. So far we were > silently falling back to the internal dtc submodule, but since > this is wrong, let's remove the --enable-fdt=system switch here now. > > Signed-off-by: Thomas Huth

[PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job

2021-08-27 Thread Thomas Huth
libfdt in Debian is too old to be usable for QEMU. So far we were silently falling back to the internal dtc submodule, but since this is wrong, let's remove the --enable-fdt=system switch here now. Signed-off-by: Thomas Huth --- Sorry, I just noticed this after sending out the first three

[PATCH 4/3] gitlab-ci: Don't try to use the system libfdt in the debian job

2021-08-27 Thread Thomas Huth
libfdt in Debian is too old to be usable for QEMU. So far we were silently falling back to the internal dtc submodule, but since this is wrong, let's remove the --enable-fdt=system switch here now. Signed-off-by: Thomas Huth --- Sorry, I just noticed this after sending out the first three

[PATCH] nbd/server: Advertise MULTI_CONN for shared writable exports

2021-08-27 Thread Eric Blake
According to the NBD spec, a server advertising NBD_FLAG_CAN_MULTI_CONN promises that multiple client connections will not see any cache inconsistencies: when properly separated by a single flush, actions performed by one client will be visible to another client, regardless of which client did the

Re: [PATCH v3 01/19] target/loongarch: Add README

2021-08-27 Thread Peter Xu
On Fri, Aug 27, 2021 at 03:14:36PM +0800, Song Gao wrote: > +The following versions of the LoongArch core are supported > +core: 3A5000 > + > https://github.com/loongson/LoongArch-Documentation/releases/download/LoongArch-Vol1-v3/LoongArch-Vol1-v1.00-EN.pdf This link seems invalid now.

Re: [PATCH v2 30/43] bsd-user: Remove dead #ifdefs from elfload.c

2021-08-27 Thread Warner Losh
> On Aug 26, 2021, at 10:42 PM, Philippe Mathieu-Daudé wrote: > > On 8/26/21 11:11 PM, i...@bsdimp.com wrote: >> From: Warner Losh >> >> LOW_ELF_STACK doesn't exist on FreeBSD and likely never will. Remove it. >> Likewise, remove an #if 0 block that's not useful >> >> Signed-off-by: Warner

Re: [PATCH v2 41/43] bsd-user: Implement cpu_copy() helper routine

2021-08-27 Thread Warner Losh
> On Aug 26, 2021, at 10:47 PM, Philippe Mathieu-Daudé wrote: > > On 8/26/21 11:11 PM, i...@bsdimp.com wrote: >> From: Warner Losh >> >> cpu_copy shouldbe called when processes are creating new threads. It > > Typo "should be" > >> copies the current state of the CPU to a new cpu state

Re: [PATCH v2 42/43] bsd-user: Add '-0 argv0' option to bsd-user/main.c

2021-08-27 Thread Warner Losh
> On Aug 26, 2021, at 10:48 PM, Philippe Mathieu-Daudé wrote: > > On 8/26/21 11:12 PM, i...@bsdimp.com wrote: >> From: Colin Percival >> >> Previously it was impossible to emulate a program with a file name >> different from its argv[0]. With this change, you can run >>qemu -0 fakename

[PATCH] qapi: Set boolean value correctly in examples

2021-08-27 Thread Guoyi Tu
Signed-off-by: Guoyi Tu --- qapi/trace.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/trace.json b/qapi/trace.json index 47c68f04da..eedfded512 100644 --- a/qapi/trace.json +++ b/qapi/trace.json @@ -99,7 +99,7 @@ # Example: # # -> { "execute":

Re: [PATCH v2 3/3] dump-guest-memory: Block live migration

2021-08-27 Thread Peter Xu
On Fri, Aug 27, 2021 at 11:51:04AM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Aug 27, 2021 at 11:44 AM Marc-André Lureau < > marcandre.lur...@redhat.com> wrote: > > > Hi > > > > On Thu, Aug 26, 2021 at 10:58 PM Peter Xu wrote: > > > >> Both dump-guest-memory and live migration caches vm

Re: [PATCH 0/3] gdbstub: add support for switchable endianness

2021-08-27 Thread Changbin Du
On Tue, Aug 24, 2021 at 10:11:14AM +0100, Peter Maydell wrote: > On Tue, 24 Aug 2021 at 00:05, Changbin Du wrote: > > > > On Mon, Aug 23, 2021 at 04:30:05PM +0100, Peter Maydell wrote: > > > changes to be more capable of handling dynamic target changes > > > (this would also help with eg

RE: [PATCH 02/19] host-utils: move abs64() to host-utils

2021-08-27 Thread Luis Fernando Fujita Pires
> >> Oh, I wasn't referring to any specific users. What I meant is that, > >> if we make abs64() generically available from host-utils, callers > >> could expect it to behave the same way as abs() in stdlib, for > >> example. > > > > That would be surprising, but do you think there are cases where

Re: [PATCH v3 09/18] ui/vdagent: disconnect handlers and reset state on finalize

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/5/21 3:57 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Avoid handlers being called with dangling pointers when the object is > freed. > > Signed-off-by: Marc-André Lureau > --- > ui/vdagent.c | 25 +++-- > 1 file changed, 15 insertions(+), 10

Re: [PATCH v3 1/2] tests: Remove uses of deprecated raspi2/raspi3 machine names

2021-08-27 Thread Willian Rampazzo
On Fri, Aug 27, 2021 at 3:14 AM Philippe Mathieu-Daudé wrote: > > Commit 155e1c82ed0 deprecated the raspi2/raspi3 machine names. > Use the recommended new names: raspi2b and raspi3b. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/devel/qgraph.rst | 38

Re: [PATCH v3 01/18] ui/vdagent: fix leak on error path

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/5/21 3:56 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > "info" was leaked when more than 10 entries. > > Signed-off-by: Marc-André Lureau > --- > include/ui/clipboard.h | 2 ++ > ui/vdagent.c | 4 +--- > 2 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH 0/6] virtio-iommu: Add ACPI support

2021-08-27 Thread Jean-Philippe Brucker
Hi Eric, On Tue, Aug 17, 2021 at 04:58:01PM +0200, Eric Auger wrote: > Hi Jean, > > On 8/10/21 10:45 AM, Jean-Philippe Brucker wrote: > > Allow instantiating a virtio-iommu device on ACPI systems by adding a > > Virtual I/O Translation table (VIOT). Enable x86 support for VIOT. > > Don't you

Re: [PATCH 2/6] hw/acpi: Add VIOT table

2021-08-27 Thread Jean-Philippe Brucker
On Tue, Aug 10, 2021 at 11:22:27AM +0200, Igor Mammedov wrote: > On Tue, 10 Aug 2021 10:45:02 +0200 > Jean-Philippe Brucker wrote: > > > Add a function that generates a Virtual I/O Translation table (VIOT), > > describing the topology of paravirtual IOMMUs. The table is created when > >

Re: [PATCH 4/6] hw/arm/virt: Remove device tree restriction for virtio-iommu

2021-08-27 Thread Jean-Philippe Brucker
On Tue, Aug 17, 2021 at 03:42:22PM +0200, Eric Auger wrote: > > diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c > > index 770c286be7..f30eb16cbf 100644 > > --- a/hw/virtio/virtio-iommu-pci.c > > +++ b/hw/virtio/virtio-iommu-pci.c > > @@ -48,16 +48,9 @@ static void

Re: [PATCH 6/6] pc: Allow instantiating a virtio-iommu device

2021-08-27 Thread Jean-Philippe Brucker
On Tue, Aug 17, 2021 at 04:11:49PM +0200, Eric Auger wrote: > Hi Jean, > > On 8/10/21 10:45 AM, Jean-Philippe Brucker wrote: > > From: Eric Auger > > > > Add a hotplug handler for virtio-iommu on x86 and set the necessary > > reserved region property. On x86, the [0xfee0, 0xfeef] DMA > >

Re: [PATCH v3 00/18] Clipboard fixes (for 6.1?)

2021-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 5, 2021 at 5:59 PM wrote: > From: Marc-André Lureau > > Hi, > > Here is a few fixes I have collected while working on clipboard-related > code. > > There are some obvious code improvements/fixes, and better handling of > release & > unregister to avoid dangling pointers and

Re: [PATCH 2/3] meson.build: Don't use internal libfdt if the user requested the system libfdt

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/27/21 2:09 PM, Thomas Huth wrote: > If the users ran configure with --enable-libfdt=system, they likely did > that on purpose. We should not silently fall back to the internal libfdt > if the system libfdt is not usable, but report the problem with a proper > message instead. > >

Re: [PATCH 0/3] dtc: Fixes for the fdt check and update submodule to 1.6.1

2021-08-27 Thread Marc-André Lureau
On Fri, Aug 27, 2021 at 4:13 PM Thomas Huth wrote: > There are some issues in the checks for libfdt in meson.build which > get fixed with the first two patches. > > And while we're at it, also update the dtc submodule to a proper release > version (in the third patch). > > Thomas Huth (3): >

Ping: [PATCH 2/2] ui/cocoa.m: Add ability to swap command/meta and options keys

2021-08-27 Thread Programmingkid
Ping: From: John Arbuckle Date: Fri, 30 Jul 2021 10:18:56 -0400 Subject: [PATCH 2/2] ui/cocoa.m: Add ability to swap command/meta and options keys For users who are use to using a Macintosh keyboard having to use a PC keyboard can be a pain because the Command/meta and Option/Alt keys are

Ping: [PATCH 1/2] ui/cocoa.m: Add full keyboard grab support

2021-08-27 Thread Programmingkid
ping From: John Arbuckle Date: Thu, 29 Jul 2021 14:41:57 -0400 Subject: [PATCH 1/2] ui/cocoa.m: Add full keyboard grab support There are keyboard shortcuts that are vital for use in a guest that runs Mac OS. These shortcuts are reserved for Mac OS use only which makes having the guest see them

Re: [PATCH v3 3/3] hw/usb/xhci: Always expect 'dma' link property to be set

2021-08-27 Thread Philippe Mathieu-Daudé
On 8/27/21 1:03 PM, Mark Cave-Ayland wrote: > On 27/08/2021 11:14, Peter Maydell wrote: > >> On Fri, 27 Aug 2021 at 10:14, Mark Cave-Ayland >> wrote: >>> Ah so the plan moving forward is to always have an explicit MR passed >>> in for DMA use. >>> Sorry if I missed that in earlier versions of

[PATCH 3/3] dtc: Update to version 1.6.1

2021-08-27 Thread Thomas Huth
The dtc submodule is currently pointing to non-release commit. It's nicer if submodules point to release versions instead and since dtc 1.6.1 is available now, let's update to that version. Signed-off-by: Thomas Huth --- dtc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

  1   2   >