Re: [PATCH v2] failover: fix unplug pending detection

2021-09-30 Thread Ani Sinha
On Thu, 30 Sep 2021, Laurent Vivier wrote: > Failover needs to detect the end of the PCI unplug to start migration > after the VFIO card has been unplugged. > > To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in > pcie_unplug_device(). > > But since > 17858a169508

Re: [PATCH] failover: fix unplug pending detection

2021-09-30 Thread Ani Sinha
On Thu, 30 Sep 2021, Laurent Vivier wrote: > On 30/09/2021 11:24, Ani Sinha wrote: > > > > > > On Thu, 30 Sep 2021, Laurent Vivier wrote: > > > > > Failover needs to detect the end of the PCI unplug to start migration > > > after the VFIO card has been unplugged. > > > > > > To do that, a flag

Re: [PATCH 1/7] docs: name included files ".rst.inc"

2021-09-30 Thread Markus Armbruster
Emacs recognizes .rst, but doesn't recognize .rst.inc. Sure we want file names that defeat common tooling?

Re: OHCI/usb pass through

2021-09-30 Thread Gerd Hoffmann
Hi, > [...] > /* Active packets. */ > uint32_t old_ctl; > USBPacket usb_packet; > uint8_t usb_buf[8192]; > uint32_t async_td; > bool async_complete; > > void (*ohci_die)(struct OHCIState *ohci); > } OHCIState; > > Then everything in hcd-ohci seems to reuse

Re: TCG Floating Point Support (Work in Progress)

2021-09-30 Thread Matt
Thank you Alex, for your quick and thoughtful response. > I've not reviewed the code as it is a rather large diff. For your proper > submission could you please ensure that your patch series is broken up > into discreet commits to aid review. Of course. > The phrase "if the user discovers some

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-09-30 Thread David Gibson
On Thu, Sep 30, 2021 at 09:10:12AM +0200, Thomas Huth wrote: > On 27/08/2021 14.09, Thomas Huth wrote: > > The dtc submodule is currently pointing to non-release commit. It's nicer > > if submodules point to release versions instead and since dtc 1.6.1 is > > available now, let's update to that

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-09-30 Thread David Gibson
On Thu, Sep 30, 2021 at 01:56:33PM +0200, Greg Kurz wrote: > On Thu, 30 Sep 2021 09:10:12 +0200 > Thomas Huth wrote: > > > On 27/08/2021 14.09, Thomas Huth wrote: > > > The dtc submodule is currently pointing to non-release commit. It's nicer > > > if submodules point to release versions instead

OHCI/usb pass through

2021-09-30 Thread BALATON Zoltan
Hello, We're trying to find out why passing through an usb sound card fails with MacOS/OS X on mac99 and came across some things in OHCI that I don't understand so some help from those who know more about USB handling in QEMU or OHCI would be needed. From traces Howard collected we see that

Re: [PATCH 1/3] hw/intc/arm_gicv3: Move checking of redist-region-count to arm_gicv3_common_realize

2021-09-30 Thread Philippe Mathieu-Daudé
On 9/30/21 17:08, Peter Maydell wrote: > The GICv3 devices have an array property redist-region-count. > Currently we check this for errors (bad values) in > gicv3_init_irqs_and_mmio(), just before we use it. Move this error > checking to the arm_gicv3_common_realize() function, where we >

Re: [PATCH v2] Hexagon (target/hexagon) probe the stores in a packet at start of commit

2021-09-30 Thread Philippe Mathieu-Daudé
Hi Taylor, On 9/30/21 23:16, Taylor Simpson wrote: > When a packet has 2 stores, either both commit or neither commit. > At the beginning of gen_commit_packet, we check for multiple stores. > If there are multiple stores, call a helper that will probe each of > them before proceeding with the

Running 297 from GitLab CI

2021-09-30 Thread John Snow
Hiya, I was talking this over with Hanna in review to '[PATCH v3 00/16] python/iotests: Run iotest linters during Python CI' [1] and I have some doubt about what you'd personally like to see happen, here. In a nutshell, I split out 'linters.py' from 297 and keep all of the iotest-bits in 297 and

[PATCH v2] Hexagon (target/hexagon) probe the stores in a packet at start of commit

2021-09-30 Thread Taylor Simpson
When a packet has 2 stores, either both commit or neither commit. At the beginning of gen_commit_packet, we check for multiple stores. If there are multiple stores, call a helper that will probe each of them before proceeding with the commit. Note that we don't call the probe helper for packets

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Eric Blake
On Thu, Sep 30, 2021 at 11:54:58AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 9/30/21 11:47, Richard W.M. Jones wrote: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label stored in memory

[PATCH v4 13/13] qapi/parser: enable pylint checks

2021-09-30 Thread John Snow
Signed-off-by: John Snow --- This can be merged with the previous commit, if desired. Signed-off-by: John Snow --- scripts/qapi/pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index 5b7dbc58ad8..b259531a726 100644

[PATCH v4 12/13] qapi/parser: Silence too-few-public-methods warning

2021-09-30 Thread John Snow
Eh. Not worth the fuss today. There are bigger fish to fry. Signed-off-by: John Snow --- scripts/qapi/parser.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py index 0265b47b955..1b006cdc133 100644 --- a/scripts/qapi/parser.py +++

[PATCH v4 11/13] qapi/parser: enable mypy checks

2021-09-30 Thread John Snow
Signed-off-by: John Snow --- As always, this can be merged with the previous commit. Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini index 54ca4483d6d..66253564297 100644 ---

[PATCH v4 07/13] qapi/parser: Introduce NullSection

2021-09-30 Thread John Snow
Here's the weird bit. QAPIDoc generally expects -- virtually everywhere -- that it will always have a current section. The sole exception to this is in the case that end_comment() is called, which leaves us with *no* section. However, in this case, we also don't expect to actually ever mutate the

[PATCH v4 09/13] qapi/parser: add type hint annotations (QAPIDoc)

2021-09-30 Thread John Snow
Annotations do not change runtime behavior. This commit consists of only annotations. Signed-off-by: John Snow --- scripts/qapi/parser.py | 67 -- 1 file changed, 39 insertions(+), 28 deletions(-) diff --git a/scripts/qapi/parser.py

[PATCH v4 04/13] qapi: Add spaces after symbol declaration for consistency

2021-09-30 Thread John Snow
Several QGA definitions omit a blank line after the symbol declaration. This works OK currently, but it's the only place where we do this. Adjust it for consistency. Future commits may wind up enforcing this formatting. Signed-off-by: John Snow --- This isn't strictly necessary and I don't

[PATCH v4 10/13] qapi/parser: Add FIXME for consolidating JSON-related types

2021-09-30 Thread John Snow
The fix for this comment is forthcoming in a future commit, but this will keep me honest. The linting configuration in ./python/setup.cfg prohibits 'FIXME' comments. A goal of this long-running series is to move ./scripts/qapi to ./python/qemu/qapi so that the QAPI generator is regularly

[PATCH v4 06/13] qapi/parser: clarify _end_section() logic

2021-09-30 Thread John Snow
The "if self._section" clause in end_section is mysterious: In which circumstances might we end a section when we don't have one? QAPIDoc always expects there to be a "current section", only except after a call to end_comment(). This actually *shouldn't* ever be 'None', so let's remove that logic

[PATCH v4 08/13] qapi/parser: add import cycle workaround

2021-09-30 Thread John Snow
Adding static types causes a cycle in the QAPI generator: [schema -> expr -> parser -> schema]. It exists because the QAPIDoc class needs the names of types defined by the schema module, but the schema module needs to import both expr.py/parser.py to do its actual parsing. Ultimately, the

[PATCH v4 00/13] qapi: static typing conversion, pt5b

2021-09-30 Thread John Snow
Hello darkness my old friend; This is part five (b), and focuses on QAPIDoc in parser.py. GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b CI: https://gitlab.com/jsnow/qemu/-/pipelines/380464863 Note: intentional trailing whitespace in a QAPI schema test causes a

[PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments

2021-09-30 Thread John Snow
Pylint informs us we're not using these arguments. Oops, it's right. Correct the error message and remove the remaining unused parameter. Fix test output now that the error message is improved. Fixes: e151941d1b Signed-off-by: John Snow --- scripts/qapi/parser.py| 16

[PATCH v4 01/13] qapi/pylintrc: ignore 'consider-using-f-string' warning

2021-09-30 Thread John Snow
Pylint 2.11.x adds this warning. We're not yet ready to pursue that conversion, so silence it for now. Signed-off-by: John Snow --- scripts/qapi/pylintrc | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index c5275d5f59b..5b7dbc58ad8 100644 ---

[PATCH v4 05/13] qapi/parser: remove FIXME comment from _append_body_line

2021-09-30 Thread John Snow
True, we do not check the validity of this symbol -- but we don't check the validity of definition names during parse, either -- that happens later, during the expr check. I don't want to introduce a dependency on expr.py:check_name_str here and introduce a cycle. Instead, rest assured that a

[PATCH v4 02/13] qapi/gen: use dict.items() to iterate over _modules

2021-09-30 Thread John Snow
New pylint warning. I could silence it, but this is the only occurrence in the entire tree, including everything in iotests/ and python/. Easier to just change this one instance. (The warning is emitted in cases where you are fetching the values anyway, so you may as well just take advantage of

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Eric Blake
On Wed, Sep 29, 2021 at 01:30:50AM -0400, ~farzon wrote: > From: Farzon Lotfi Food for thought: your git/mail configuration used one address for the envelope (name '~farzon' as user 'farzon@') and another as the patch author (name 'Farzon Lotfi' as user 'hi@'). Since you own your domain (with

Re: [PATCH qemu v2] QEMU coding style mandates spaces for indentation. This change replaces TABs in block files.

2021-09-30 Thread Eric Blake
On Thu, Sep 30, 2021 at 02:55:16PM +0200, Kevin Wolf wrote: > > > When we're changing these lines anyway, let's make sure to have > > > consistent alignment with the surrounding code. So I would prefer > > > something like: > > > > > > +.bdrv_close = parallels_close, > > >

Re: [PATCH] failover: allow to pause the VM during the migration

2021-09-30 Thread Laine Stump
On 9/30/21 1:09 PM, Laurent Vivier wrote: If we want to save a snapshot of a VM to a file, we used to follow the following steps: 1- stop the VM: (qemu) stop 2- migrate the VM to a file: (qemu) migrate "exec:cat > snapshot" 3- resume the VM: (qemu) cont After that we can restore

Re: [PULL v2 00/33] x86 and misc changes for 2021-09-28

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 16:00, Paolo Bonzini wrote: > > The following changes since commit ba0fa56bc06e563de68d2a2bf3ddb0cfea1be4f9: > > Merge remote-tracking branch > 'remotes/vivier/tags/q800-for-6.2-pull-request' into staging (2021-09-29 > 21:20:49 +0100) > > are available in the Git

Re: [PATCH 14/16] tests/acceptance/ppc_prep_40p.py: NetBSD 7.1.2 location update

2021-09-30 Thread Philippe Mathieu-Daudé
On 9/30/21 21:19, Reinoud Zandijk wrote: > On Mon, Sep 27, 2021 at 05:26:43PM +0200, Philippe Mathieu-Daudé wrote: >> On 9/24/21 20:55, Cleber Rosa wrote: >>> The NetBSD-7.1.2-prep.iso is no longer available on the CDN, but it's >>> still available in the archive. >>> >>> Let's update its location

Re: [PATCH 14/16] tests/acceptance/ppc_prep_40p.py: NetBSD 7.1.2 location update

2021-09-30 Thread Reinoud Zandijk
On Mon, Sep 27, 2021 at 05:26:43PM +0200, Philippe Mathieu-Daudé wrote: > On 9/24/21 20:55, Cleber Rosa wrote: > > The NetBSD-7.1.2-prep.iso is no longer available on the CDN, but it's > > still available in the archive. > > > > Let's update its location so that users without the file on cache

Re: [PATCH v1] Use CLOCK_MONOTONIC_RAW if available for get_clock().

2021-09-30 Thread Joe Tanen
Peter, Thanks for the quick response. I've informally socialized the issue and will update this thread when I get more information. That aside, I'd find using CLOCK_MONOTONIC_RAW valuable if, e.g., I wanted test an NTP daemon inside of a guest and didn't want the host providing an

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Vladimir Sementsov-Ogievskiy
9/30/21 21:37, Richard W.M. Jones wrote: On Thu, Sep 30, 2021 at 02:00:11PM -0300, Willian Rampazzo wrote: On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy wrote: 9/30/21 11:47, Richard W.M. Jones wrote: Under SELinux, Unix domain sockets have two labels. One is on the disk and

[PATCH 2/3] virtio-iommu: Default to bypass during boot

2021-09-30 Thread Jean-Philippe Brucker
Currently the virtio-iommu device must be programmed before it allows DMA from any PCI device. This can make the VM entirely unusable when a virtio-iommu driver isn't present, for example in a bootloader that loads the OS from storage. Similarly to the other vIOMMU implementations, default to DMA

[PATCH 0/3] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG

2021-09-30 Thread Jean-Philippe Brucker
Replace the VIRTIO_IOMMU_F_BYPASS feature with VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch global bypass on and off. Add a boot-bypass option, which defaults to 'on' to be in line with other vIOMMUs and to allow running firmware/bootloader that are unaware of the

[PATCH 3/3] virtio-iommu: Support bypass domain

2021-09-30 Thread Jean-Philippe Brucker
The driver can create a bypass domain by passing the VIRTIO_IOMMU_ATTACH_F_BYPASS flag on the ATTACH request. Bypass domains perform slightly better than domains with identity mappings since they skip translation. Signed-off-by: Jean-Philippe Brucker --- hw/virtio/virtio-iommu.c | 32

[PATCH 1/3] NOMERGE: virtio-iommu: Add definitions for VIRTIO_IOMMU_F_BYPASS_CONFIG

2021-09-30 Thread Jean-Philippe Brucker
Pull VIRTIO_IOMMU_F_BYPASS_CONFIG changes from Linux (not upstream yet). Signed-off-by: Jean-Philippe Brucker --- include/standard-headers/linux/virtio_iommu.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/include/standard-headers/linux/virtio_iommu.h

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Richard W.M. Jones
On Thu, Sep 30, 2021 at 02:00:11PM -0300, Willian Rampazzo wrote: > On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy > wrote: > > > > 9/30/21 11:47, Richard W.M. Jones wrote: > > > Under SELinux, Unix domain sockets have two labels. One is on the > > > disk and can be set with

Re: [PATCH v3 05/13] qapi/parser: improve detection of '@symbol:' preface

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 4:42 AM Markus Armbruster wrote: > John Snow writes: > > > Leading and trailing whitespace are now discarded, addressing the FIXME > > comment. A new error is raised to detect this accidental case. > > > > Parsing for args sections is left alone here; the 'name' variable

Re: [PATCH v3 06/13] qapi/parser: remove FIXME comment from _append_body_line

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 4:47 AM Markus Armbruster wrote: > John Snow writes: > > > True, we do not check the validity of this symbol -- but we don't check > > the validity of definition names during parse, either -- that happens > > later, during the expr check. I don't want to introduce a

Re: [PATCH v3 09/13] qapi/parser: add import cycle workaround

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 5:45 AM Markus Armbruster wrote: > John Snow writes: > > > There is a cycle that exists in the QAPI generator: [schema -> expr -> > > "There is" or "there will be once we add strong type hints"? > > "There exists in my mind-palace a cycle where, ..." (Will adjust the

[PATCH] failover: allow to pause the VM during the migration

2021-09-30 Thread Laurent Vivier
If we want to save a snapshot of a VM to a file, we used to follow the following steps: 1- stop the VM: (qemu) stop 2- migrate the VM to a file: (qemu) migrate "exec:cat > snapshot" 3- resume the VM: (qemu) cont After that we can restore the snapshot with: qemu-system-x86_64 ...

Re: [PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 12:36:36PM -0400, Richard Henderson wrote: > By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, > we were still including the 64-bit packages. Install > pcre-devel.i686 to fill a missing glib2 dependency. > > By using --extra-cflags instead of --cpu, we incorrectly >

Re: [PATCH v3] nbd/server: Add --selinux-label option

2021-09-30 Thread Willian Rampazzo
On Thu, Sep 30, 2021 at 5:55 AM Vladimir Sementsov-Ogievskiy wrote: > > 9/30/21 11:47, Richard W.M. Jones wrote: > > Under SELinux, Unix domain sockets have two labels. One is on the > > disk and can be set with commands such as chcon(1). There is a > > different label stored in memory (called

Re: [PATCH 1/2] tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES

2021-09-30 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 12:36:35PM -0400, Richard Henderson wrote: > The image was upgraded to a full image in ee381b7fe146. > This makes it possible to use docker-test@image syntax > with this container. > > Cc: Thomas Huth > Cc: Alex Bennée > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v3 08/13] qapi/parser: Introduce NullSection

2021-09-30 Thread John Snow
On Thu, Sep 30, 2021 at 5:35 AM Markus Armbruster wrote: > John Snow writes: > > > Here's the weird bit. QAPIDoc generally expects -- virtually everywhere > > -- that it will always have a current section. The sole exception to > > this is in the case that end_comment() is called, which leaves

Re: [PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Richard W.M. Jones
On Thu, Sep 30, 2021 at 12:36:36PM -0400, Richard Henderson wrote: > By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, > we were still including the 64-bit packages. Install > pcre-devel.i686 to fill a missing glib2 dependency. > > By using --extra-cflags instead of --cpu, we incorrectly >

Re: [PULL 00/44] ppc-for-6.2 queue 20210930

2021-09-30 Thread Peter Maydell
are available in the Git repository at: > > https://gitlab.com/dgibson/qemu.git tags/ppc-for-6.2-20210930 > > for you to fetch changes up to 85d887be82905aa81b5d3d6c483ff0fa9958382b: > > MAINTAINERS: Demote sPAPR from "Supported

[PATCH 1/2] tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES

2021-09-30 Thread Richard Henderson
The image was upgraded to a full image in ee381b7fe146. This makes it possible to use docker-test@image syntax with this container. Cc: Thomas Huth Cc: Alex Bennée Signed-off-by: Richard Henderson --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Richard Henderson
By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, we were still including the 64-bit packages. Install pcre-devel.i686 to fill a missing glib2 dependency. By using --extra-cflags instead of --cpu, we incorrectly use the wrong probing during meson. Cc: Alex Bennée Cc: Paolo Bonzini Cc:

[PATCH 0/2] tests/docker: Fix fedora-i386-cross

2021-09-30 Thread Richard Henderson
The meson + pkg-config probing issues came up wrt a recent NBD pull request at the same time as I am trying to reproduce a gitlab-ci failure with fedora-i386-cross, and ran into something apparently related. r~ Richard Henderson (2): tests/docker: Remove fedora-i386-cross from

Re: [RFC PATCH 1/1] hw: aspeed_adc: Add initial Aspeed ADC support

2021-09-30 Thread Cédric Le Goater
FYI, these series was sent by Andrew in 2017 and I have been keeping it alive since in the aspeed-x.y branches : * memory: Support unaligned accesses on aligned-only models https://github.com/legoater/qemu/commit/1960ba6bde27b91edb5336985a9210260a4c8938 That was requested by Phil I

Re: Moving QEMU downloads to GitLab Releases?

2021-09-30 Thread Eldon Stegall
Hello! I'd be happy to help with this. I'm mostly a consumer of QEMU, but greatly appreciate all the work this community has done, and was able to contribute a little by helping with QEMU advent this past year. I would be happy to help streamline some of this activities if that would be welcome,

[PATCH 07/13] virtiofsd: Release file locks using F_UNLCK

2021-09-30 Thread Vivek Goyal
We are emulating posix locks for guest using open file description locks in virtiofsd. When any of the fd is closed in guest, we find associated OFD lock fd (if there is one) and close it to release all the locks. Assumption here is that there is no other thread using lo_inode_plock structure or

Re: [PATCH v1] Use CLOCK_MONOTONIC_RAW if available for get_clock().

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 17:04, Joe Tanen wrote: > > CLOCK_MONOTONIC_RAW provides an unadjusted system clock on some platforms, > which is closer in spirit to providing a guest with a raw hardware clock than > CLOCK_MONOTONIC. > > Using CLOCK_MONOTONIC_RAW also works around a current issue in OSX

[PATCH 08/13] virtiofsd: Create a notification queue

2021-09-30 Thread Vivek Goyal
Add a notification queue which will be used to send async notifications for file lock availability. Signed-off-by: Vivek Goyal Signed-off-by: Ioannis Angelakopoulos --- hw/virtio/vhost-user-fs-pci.c | 4 +- hw/virtio/vhost-user-fs.c | 62 +--

[PATCH 05/13] virtiofsd: Add a helper to stop all queues

2021-09-30 Thread Vivek Goyal
Use a helper to stop all the queues. Later in the patch series I am planning to use this helper at one more place later in the patch series. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git

[PATCH 04/13] virtiofsd: Add a helper to send element on virtqueue

2021-09-30 Thread Vivek Goyal
We have open coded logic to take locks and push element on virtqueue at three places. Add a helper and use it everywhere. Code is easier to read and less number of lines of code. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 45 ++- 1 file

Re: [RFC PATCH 1/1] hw: aspeed_adc: Add initial Aspeed ADC support

2021-09-30 Thread Peter Delevoryas
> On Sep 29, 2021, at 11:22 PM, Cédric Le Goater wrote: > > Hello Peter, > > If you run ./scripts/get_maintainer.pl on the patch, it will build > the list of persons and mailing list to send to. Oh, sorry about that, I’ll cc everyone properly when I resubmit this. > > On 9/30/21 02:42,

[PATCH 02/13] virtiofsd: fuse.h header file changes for lock notification

2021-09-30 Thread Vivek Goyal
This change comes from fuse.h kernel header file udpate. Hence keeping it in a separate patch. Signed-off-by: Vivek Goyal --- include/standard-headers/linux/fuse.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/linux/fuse.h

[PATCH v1] Use CLOCK_MONOTONIC_RAW if available for get_clock().

2021-09-30 Thread Joe Tanen
CLOCK_MONOTONIC_RAW provides an unadjusted system clock on some platforms, which is closer in spirit to providing a guest with a raw hardware clock than CLOCK_MONOTONIC. Using CLOCK_MONOTONIC_RAW also works around a current issue in OSX where CLOCK_MONOTONIC has been observed to go backwards.

[PATCH 10/13] virtiofsd: Custom threadpool for remote blocking posix locks requests

2021-09-30 Thread Vivek Goyal
Add a new custom threadpool using posix threads that specifically service locking requests. In the case of a fcntl(SETLKW) request, if the guest is waiting for a lock or locks and issues a hard-reboot through SYSRQ then virtiofsd unblocks the blocked threads by sending a signal to them and waking

Re: [PATCH 6/7] docs: move gcov section at the end of testing.rst

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > gcov testing applies to all tests, not just make check. Move it > out of the make check section. > > Signed-off-by: Paolo Bonzini > --- > docs/devel/testing.rst | 38 +++--- > 1 file changed, 19

[PATCH 11/13] virtiofsd: Shutdown notification queue in the end

2021-09-30 Thread Vivek Goyal
So far we did not have the notion of cross queue traffic. That is, we get request on a queue and send back response on same queue. So if a request be being processed and at the same time a stop queue request comes in, we wait for all pending requests to finish and then queue is stopped and

[PATCH 13/13] virtiofsd, seccomp: Add clock_nanosleep() to allow list

2021-09-30 Thread Vivek Goyal
g_usleep() calls nanosleep() and that now seems to call clock_nanosleep() syscall. Now these patches are making use of g_usleep(). So add clock_nanosleep() to list of allowed syscalls. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_seccomp.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH 3/7] docs: put "make" information together in build-system.rst

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > --- > docs/devel/build-system.rst | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst > index

Re: [PULL v2 00/19] NBD patches through 2021-09-27

2021-09-30 Thread Peter Maydell
On Wed, 29 Sept 2021 at 22:13, Eric Blake wrote: > > The following changes since commit 6b54a31bf7b403672a798b6443b1930ae6c74dea: > > Merge remote-tracking branch > 'remotes/jsnow-gitlab/tags/python-pull-request' into staging (2021-09-28 > 13:07:32 +0100) > > are available in the Git

[PATCH 12/13] virtiofsd: Implement blocking posix locks

2021-09-30 Thread Vivek Goyal
As of now we don't support fcntl(F_SETLKW) and if we see one, we return -EOPNOTSUPP. Change that by accepting these requests and returning a reply immediately asking caller to wait. Once lock is available, send a notification to the waiter indicating lock is available. In response to lock

Re: [PATCH 2/7] docs: move notes inside the body of the document

2021-09-30 Thread Peter Maydell
On Thu, 30 Sept 2021 at 14:33, Paolo Bonzini wrote: > > Make all documents start with a heading. > > Signed-off-by: Paolo Bonzini > --- > docs/devel/multi-process.rst | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/docs/devel/multi-process.rst

[PULL 15/22] target/arm: Don't put FPEXC and FPSID in org.gnu.gdb.arm.vfp XML

2021-09-30 Thread Peter Maydell
Currently we send VFP XML which includes D0..D15 or D0..D31, plus FPSID, FPSCR and FPEXC. The upstream GDB tolerates this, but its definition of this XML feature does not include FPSID or FPEXC. In particular, for M-profile cores there are no FPSID or FPEXC registers, so advertising those is

[PATCH 09/13] virtiofsd: Specify size of notification buffer using config space

2021-09-30 Thread Vivek Goyal
Daemon specifies size of notification buffer needed and that should be done using config space. Only ->notify_buf_size value of config space comes from daemon. Rest of it is filled by qemu device emulation code. Signed-off-by: Vivek Goyal Signed-off-by: Ioannis Angelakopoulos ---

[PATCH 00/13] virtiofsd: Support notification queue and

2021-09-30 Thread Vivek Goyal
Hi, Here are the patches to support notification queue and blocking posix locks. One of the biggest change since las time has been creation of custom thread pool for handling locking requests. Thanks to Ioannis for doing most of the work on custom thread pool. I have posted corresponding kernel

[PULL 20/22] qbus: Rename qbus_create() to qbus_new()

2021-09-30 Thread Peter Maydell
Rename the "allocate and return" qbus creation function to qbus_new(), to bring it into line with our _init vs _new convention. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Corey Minyard Message-id:

[PULL 22/22] hw/arm: sabrelite: Connect SPI flash CS line to GPIO3_19

2021-09-30 Thread Peter Maydell
From: Xuzhou Cheng The Linux spi-imx driver does not work on QEMU. The reason is that the state of m25p80 loops in STATE_READING_DATA state after receiving RDSR command, the new command is ignored. Before sending a new command, CS line should be pulled high to make the state of m25p80 back to

[PATCH 01/13] virtio_fs.h: Add notification queue feature bit

2021-09-30 Thread Vivek Goyal
This change will ultimately come from kernel as kernel header file update when kernel patches get merged. Signed-off-by: Vivek Goyal --- include/standard-headers/linux/virtio_fs.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/standard-headers/linux/virtio_fs.h

[PATCH 06/13] vhost-user-fs: Use helpers to create/cleanup virtqueue

2021-09-30 Thread Vivek Goyal
Add helpers to create/cleanup virtuqueues and use those helpers. I will need to reconfigure queues in later patches and using helpers will allow reusing the code. Signed-off-by: Vivek Goyal --- hw/virtio/vhost-user-fs.c | 87 +++ 1 file changed, 52

[PULL 19/22] qbus: Rename qbus_create_inplace() to qbus_init()

2021-09-30 Thread Peter Maydell
Rename qbus_create_inplace() to qbus_init(); this is more in line with our usual naming convention for functions that in-place initialize objects. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-id:

[PULL 18/22] pci: Rename pci_root_bus_new_inplace() to pci_root_bus_init()

2021-09-30 Thread Peter Maydell
Rename the pci_root_bus_new_inplace() function to pci_root_bus_init(); this brings the bus type in to line with a "_init for in-place init, _new for allocate-and-return" convention. To do this we need to rename the implementation-internal function that was using the pci_root_bus_init() name to

[PULL 16/22] scsi: Replace scsi_bus_new() with scsi_bus_init(), scsi_bus_init_named()

2021-09-30 Thread Peter Maydell
The function scsi_bus_new() creates a new SCSI bus; callers can either pass in a name argument to specify the name of the new bus, or they can pass in NULL to allow the bus to be given an automatically generated unique name. Almost all callers want to use the autogenerated name; the only

[PULL 17/22] ipack: Rename ipack_bus_new_inplace() to ipack_bus_init()

2021-09-30 Thread Peter Maydell
Rename ipack_bus_new_inplace() to ipack_bus_init(), to bring it in to line with a "_init for in-place init, _new for allocate-and-return" convention. Drop the 'name' argument, because the only caller does not pass in a name. If a future caller does need to specify the bus name, we should create

[PATCH 03/13] virtiofsd: Remove unused virtio_fs_config definition

2021-09-30 Thread Vivek Goyal
"struct virtio_fs_config" definition seems to be unused in fuse_virtio.c. Remove it. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 8f4fd165b9..da7b6a76bf

[PULL 14/22] target/arm: Move gdbstub related code out of helper.c

2021-09-30 Thread Peter Maydell
Currently helper.c includes some code which is part of the arm target's gdbstub support. This code has a better home: in gdbstub.c and gdbstub64.c. Move it there. Because aarch64_fpu_gdb_get_reg() and aarch64_fpu_gdb_set_reg() move into gdbstub64.c, this means that they're now compiled only for

Re: Strange qemu6 regression cauing disabled usb controller.

2021-09-30 Thread Remy Noel
On Thu, Sep 30, 2021 at 04:05:52PM +0100, Daniel P. Berrangé wrote: On Thu, Sep 30, 2021 at 03:48:44PM +0200, Remy Noel wrote: Co-incidentally we've just had another bug report filed today that suggests 7bed89958bfbf40df9ca681cefbdca63abdde39d as a buggy commit causing deadlock in QEMU

[PULL 12/22] configs: Don't include 32-bit-only GDB XML in aarch64 linux configs

2021-09-30 Thread Peter Maydell
The aarch64-linux QEMU usermode binaries can never run 32-bit code, so they do not need to include the GDB XML for it. (arm_cpu_register_gdb_regs_for_features() will not use these XML files if the CPU has ARM_FEATURE_AARCH64, so we will not advertise to gdb that we have them.) Signed-off-by:

[PULL 13/22] target/arm: Fix coding style issues in gdbstub code in helper.c

2021-09-30 Thread Peter Maydell
We're going to move this code to a different file; fix the coding style first so checkpatch doesn't complain. This includes deleting the spurious 'break' statements after returns in the vfp_gdb_get_reg() function. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by:

[PULL 06/22] hw/nvram: Introduce Xilinx battery-backed ram

2021-09-30 Thread Peter Maydell
From: Tong Ho This device is present in Versal and ZynqMP product families to store a 256-bit encryption key. Co-authored-by: Edgar E. Iglesias Co-authored-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Signed-off-by: Sai Pavan Boddu Signed-off-by: Tong Ho Message-id:

[PULL 08/22] hw/arm: xlnx-versal-virt: Add Xilinx eFUSE device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for Versal eFUSE one-time field-programmable bit array. The command argument: -drive if=pflash,index=1,... Can be used to optionally connect the bit array to a backend storage, such that field-programmed values in one invocation can be made available to next

[PULL 09/22] hw/arm: xlnx-zcu102: Add Xilinx BBRAM device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for Xilinx ZynqMP Battery-Backed RAM (BBRAM) The command argument: -drive if=pflash,index=2,... Can be used to optionally connect the bbram to a backend storage, such that field-programmed values in one invocation can be made available to next invocation.

[PULL 07/22] hw/arm: xlnx-versal-virt: Add Xilinx BBRAM device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for Versal Battery-Backed RAM (BBRAM) The command argument: -drive if=pflash,index=0,... Can be used to optionally connect the bbram to a backend storage, such that field-programmed values in one invocation can be made available to next invocation. The

[PULL 03/22] hw/nvram: Introduce Xilinx eFuse QOM

2021-09-30 Thread Peter Maydell
From: Tong Ho This introduces the QOM for Xilinx eFuse, an one-time field-programmable storage bit array. The actual mmio interface to the array varies by device families and will be provided in different change-sets. Co-authored-by: Edgar E. Iglesias Co-authored-by: Sai Pavan Boddu

[PULL 11/22] docs/system/arm: xlnx-versal-virt: BBRAM and eFUSE Usage

2021-09-30 Thread Peter Maydell
From: Tong Ho Add BBRAM and eFUSE usage to the Xilinx Versal Virt board document. Signed-off-by: Tong Ho Message-id: 20210917052400.1249094-10-tong...@xilinx.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/arm/xlnx-versal-virt.rst | 49

[PULL 02/22] arm: tcg: Adhere to SMCCC 1.3 section 5.2

2021-09-30 Thread Peter Maydell
From: Alexander Graf The SMCCC 1.3 spec section 5.2 says The Unknown SMC Function Identifier is a sign-extended value of (-1) that is returned in the R0, W0 or X0 registers. An implementation must return this error code when it receives: * An SMC or HVC call with an unknown Function

[PULL 21/22] ide: Rename ide_bus_new() to ide_bus_init()

2021-09-30 Thread Peter Maydell
The function ide_bus_new() does an in-place initialization. Rename it to ide_bus_init() to follow our _init vs _new convention. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Corey Minyard Reviewed-by: John Snow Acked-by: John

[PULL 01/22] allwinner-h3: Switch to SMC as PSCI conduit

2021-09-30 Thread Peter Maydell
From: Alexander Graf The Allwinner H3 SoC uses Cortex-A7 cores which support virtualization. However, today we are configuring QEMU to use HVC as PSCI conduit. That means HVC calls get trapped into QEMU instead of the guest's own emulated CPU and thus break the guest's ability to execute

[PULL 10/22] hw/arm: xlnx-zcu102: Add Xilinx eFUSE device

2021-09-30 Thread Peter Maydell
From: Tong Ho Connect the support for ZynqMP eFUSE one-time field-programmable bit array. The command argument: -drive if=pflash,index=3,... Can be used to optionally connect the bit array to a backend storage, such that field-programmed values in one invocation can be made available to next

[PATCH 2/3] hw/intc/arm_gicv3: Set GICR_TYPER.Last correctly when nb_redist_regions > 1

2021-09-30 Thread Peter Maydell
The 'Last' bit in the GICR_TYPER GICv3 redistributor register is supposed to be set to 1 if this is the last redistributor in a series of contiguous redistributor pages. Currently we set Last only for the redistributor for CPU (num_cpu - 1). This only works if there is a single redistributor

[PULL 05/22] hw/nvram: Introduce Xilinx ZynqMP eFuse device

2021-09-30 Thread Peter Maydell
From: Tong Ho This implements the Xilinx ZynqMP eFuse, an one-time field-programmable non-volatile storage device. There is only one such device in the Xilinx ZynqMP product family. Co-authored-by: Edgar E. Iglesias Co-authored-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias

[PULL 04/22] hw/nvram: Introduce Xilinx Versal eFuse device

2021-09-30 Thread Peter Maydell
From: Tong Ho This implements the Xilinx Versal eFuse, an one-time field-programmable non-volatile storage device. There is only one such device in the Xilinx Versal product family. This device has two separate mmio interfaces, a controller and a flatten readback. The controller provides

  1   2   3   >