Re: [PATCH v3 0/3] qapi & doc: deprecate drive-backup

Vladimir Sementsov-Ogievskiy writes: > Hi all! > > See 03 commit message for details. 01-02 are preparation docs update. > > v3: wording fix-ups and improvements suggested by Kashyap > v2: add a lot of documentation changes > v1 was "[PATCH] qapi: deprecate drive-backup" > > > Note, that this

Re: [PATCH v4 5/5] block: Deprecate transaction type drive-backup

Vladimir Sementsov-Ogievskiy writes: > 25.10.2021 07:24, Markus Armbruster wrote: >> Several moons ago, Vladimir posted >> >> Subject: [PATCH v2 3/3] qapi: deprecate drive-backup >> Date: Wed, 5 May 2021 16:58:03 +0300 >>

Re: [PATCH v3 03/19] docs/devel: document expectations for QAPI data modelling for QMP

Daniel P. Berrangé writes: > On Thu, Oct 28, 2021 at 04:24:31PM +0100, Daniel P. Berrangé wrote: >> On Thu, Oct 28, 2021 at 04:31:40PM +0200, Markus Armbruster wrote: >> > This clashes with my "[PATCH v2 0/9] Configurable policy for handling >> > unstable interfaces", which replaces "you must

RE: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

> > > > > > > > > > > > I wonder if we need to introduce new parameter, e.g force_vnet_hdr > > > > here, then we can always send vnet_hdr when it is enabled. > > > > > > > > Otherwise the "vnet_hdr_support" seems meaningless. > > > > > > Yes, Current "vnet_hdr_support" default enabled, and

Re: [PATCH v4 14/22] target/riscv: Implement AIA xiselect and xireg CSRs

On Tue, Oct 26, 2021 at 6:08 PM Anup Patel wrote: > > The AIA specification defines [m|s|vs]iselect and [m|s|vs]ireg CSRs > which allow indirect access to interrupt priority arrays and per-HART > IMSIC registers. This patch implements AIA xiselect and xireg CSRs. > > Signed-off-by: Anup Patel >

Re: [PATCH v4 08/22] target/riscv: Allow AIA device emulation to set ireg rmw callback

On Tue, Oct 26, 2021 at 6:00 PM Anup Patel wrote: > > The AIA device emulation (such as AIA IMSIC) should be able to set > (or provide) AIA ireg read-modify-write callback for each privilege > level of a RISC-V HART. > > Signed-off-by: Anup Patel > --- > target/riscv/cpu.h| 19

Re: [PATCH v4 12/22] target/riscv: Implement AIA interrupt filtering CSRs

On Tue, Oct 26, 2021 at 5:44 PM Anup Patel wrote: > > The AIA specificaiton adds interrupt filtering support for M-mode > and HS-mode. Using AIA interrupt filtering M-mode and H-mode can > take local interrupt 13 or above and selectively inject same local > interrupt to lower privilege modes. > >

Re: [PATCH v4 11/22] target/riscv: Implement AIA hvictl and hviprioX CSRs

On Tue, Oct 26, 2021 at 5:39 PM Anup Patel wrote: > > The AIA hvictl and hviprioX CSRs allow hypervisor to control > interrupts visible at VS-level. This patch implements AIA hvictl > and hviprioX CSRs. > > Signed-off-by: Anup Patel > --- > target/riscv/cpu.h | 1 + > target/riscv/csr.c

Re: [PULL for 6.2 00/21] testing, plugin and gdbstub updates

On 11/3/21 3:32 PM, Taylor Simpson wrote: We'll investigate the toolchain issue. This is compiling tests/tcg/multiarch/signals.c, right? Technically, yes. But the error I identified is within the packaged musl libc.a. r~

Re: [PATCH v4 10/22] target/riscv: Implement AIA CSRs for 64 local interrupts on RV32

On Tue, Oct 26, 2021 at 5:10 PM Anup Patel wrote: > > The AIA specification adds new CSRs for RV32 so that RISC-V hart can > support 64 local interrupts on both RV32 and RV64. > > Signed-off-by: Anup Patel > --- > target/riscv/cpu.h| 14 +- > target/riscv/cpu_helper.c | 10 +- >

Re: [PULL 00/27] Misc patches for QEMU 6.2 soft freeze

On 11/3/21 11:04 AM, Paolo Bonzini wrote: The following changes since commit f79bb385c0fb9756393bde2a13ebbc70ae6c8043: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20211101' into staging (2021-11-02 08:46:23 -0400) are available in the Git repository at:

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

On Wed, Nov 3, 2021 at 8:24 PM Juan Quintela wrote: > > Leonardo Bras Soares Passos wrote: > > Hello Juan, > > hi > > > Current multifd's sendmsg() will block until all data is sent, is that > > correct? > > > > If that's the case, and supposing the network driver supports > > multiqueue, maybe

Re: [PATCH v2] Fix virtio-net-pci* "vectors" compat

On Wed, Nov 3, 2021 at 7:39 PM Jean-Louis Dupond wrote: > > From: Eduardo Habkost > > hw_compat_5_2 has an issue: it affects only "virtio-net-pci" > but not "virtio-net-pci-transitional" and > "virtio-net-pci-non-transitional". The solution is to use the > "virtio-net-pci-base" type in

Re: [PATCH v3 2/2] vhost: Fix last vq queue index of devices with no cvq

On Wed, Nov 3, 2021 at 6:01 PM Eugenio Pérez wrote: > > The -1 assumes that last index counts all vhost device models as having > two queues, but they count only the ones that models the data queues. > > Because of that, the right change in last_index is to actually add the > cvq, not to remove

Re: [PATCH v3 1/2] vhost: Rename last_index to last_vq_index

On Wed, Nov 3, 2021 at 6:01 PM Eugenio Pérez wrote: > > The doc of this field points out that last_index is the last vq index. > Since last_index can cause confusion if seen out of context, renaming > to last_vq_index, aligning with vq_index. > > Signed-off-by: Eugenio Pérez Acked-by: Jason

Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq

On Wed, Nov 3, 2021 at 3:44 PM Eugenio Perez Martin wrote: > > On Wed, Nov 3, 2021 at 4:18 AM Jason Wang wrote: > > > > On Tue, Nov 2, 2021 at 4:10 PM Eugenio Perez Martin > > wrote: > > > > > > On Tue, Nov 2, 2021 at 6:26 AM Jason Wang wrote: > > > > > > > > On Sat, Oct 30, 2021 at 2:44 AM

Re: [RFC PATCH v5 11/26] vhost: Handle host notifiers in SVQ

On Wed, Nov 3, 2021 at 3:40 PM Eugenio Perez Martin wrote: > > On Wed, Nov 3, 2021 at 3:56 AM Jason Wang wrote: > > > > On Tue, Nov 2, 2021 at 4:47 PM Eugenio Perez Martin > > wrote: > > > > > > On Tue, Nov 2, 2021 at 8:55 AM Jason Wang wrote: > > > > > > > > > > > > 在 2021/10/30 上午2:35,

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

Leonardo Bras Soares Passos wrote: > Hello Juan, hi > Current multifd's sendmsg() will block until all data is sent, is that > correct? > > If that's the case, and supposing the network driver supports > multiqueue, maybe there is a small chance for this to happen. > I will add the flush at

Re: [PATCH 0/1] tests/acceptance: rename tests acceptance to tests avocado

Hi Willian, For the Orange Pi PC documentation: Reviewed-by: Niek Linnenbank Op wo 3 nov. 2021 22:14 schreef Willian Rampazzo : > In the discussion about renaming the `tests/acceptance` [1], the > conclusion was that the folders inside `tests` are related to the > framework running the tests

[PATCH v4 5/7] blockdev: Add a new IF type IF_OTHER

This type is used to represent block devs that are not suitable to be represented by other existing types. Signed-of-by: Hao Wu --- blockdev.c| 3 ++- include/sysemu/blockdev.h | 1 + meson | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v4 4/7] hw/adc: Make adci[*] R/W in NPCM7XX ADC

Our sensor test requires both reading and writing from a sensor's QOM property. So we need to make the input of ADC module R/W instead of write only for that to work. Signed-off-by: Hao Wu Reviewed-by: Titus Rwantare Reviewed-by: Peter Maydell --- hw/adc/npcm7xx_adc.c | 2 +- 1 file changed,

[PATCH v4 7/7] hw/arm: quanta-gbs-bmc add i2c devices

From: Patrick Venture Adds supported i2c devices to the quanta-gbc-bmc board. Signed-off-by: Patrick Venture Reviewed-by: Hao Wu --- hw/arm/npcm7xx_boards.c | 82 - 1 file changed, 49 insertions(+), 33 deletions(-) diff --git a/hw/arm/npcm7xx_boards.c

[PATCH v4 6/7] hw/nvram: Update at24c EEPROM init function in NPCM7xx boards

We made 3 changes to the at24c_eeprom_init function in npcm7xx_boards.c: 1. We allow the function to take a I2CBus* as parameter. This allows us to attach an EEPROM device behind an I2C mux which is not possible with the old method. 2. We make at24c EEPROMs are backed by drives so that we

[PATCH v4 1/7] hw/i2c: Clear ACK bit in NPCM7xx SMBus module

The ACK bit in NPCM7XX SMBus module should be cleared each time it sends out a NACK signal. This patch fixes the bug that it fails to do so. Signed-off-by: Hao Wu Reviewed-by: Titus Rwantare Reviewed-by: Peter Maydell --- hw/i2c/npcm7xx_smbus.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v4 3/7] hw/adc: Fix CONV bit in NPCM7XX ADC CON register

The correct bit for the CONV bit in NPCM7XX ADC is bit 13. This patch fixes that in the module, and also lower the IRQ when the guest is done handling an interrupt event from the ADC module. Signed-off-by: Hao Wu Reviewed-by: Patrick Venture Reviewed-by: Peter Maydell --- hw/adc/npcm7xx_adc.c

[PATCH v4 2/7] hw/i2c: Read FIFO during RXF_CTL change in NPCM7XX SMBus

Originally we read in from SMBus when RXF_STS is cleared. However, the driver clears RXF_STS before setting RXF_CTL, causing the SM bus module to read incorrect amount of bytes in FIFO mode when the number of bytes read changed. This patch fixes this issue. Signed-off-by: Hao Wu Reviewed-by:

[PATCH v4 0/7] Misc NPCM7XX patches

This patch set contains a few bug fixes and I2C devices for some NPCM7XX boards. Patch 1~2 fix a problem that causes the SMBus module to behave incorrectly when it's in FIFO mode and trying to receive more than 16 bytes at a time. Patch 3 fixes a error in a register for ADC module. Patch 4

Re: [PATCH] target/riscv: machine: Sort the .subsections

On Sat, Oct 30, 2021 at 1:07 PM Bin Meng wrote: > > From: Bin Meng > > Move the codes around so that the order of .subsections matches > the one they are referenced in vmstate_riscv_cpu. > > Signed-off-by: Bin Meng Thanks! Applied to riscv-to-apply.next Alistair > --- > >

Re: [PATCH v2 5/7] hw/nvram: Update at24c EEPROM init function in NPCM7xx boards

Thanks for the comment. I'll upload a new version using IF_OTHER as discussed in that thread. I don't know if adding the assertion for type != IF_NONE is a good idea now so I didn't add that. If you think that's good I can add it as well. On Wed, Nov 3, 2021 at 2:13 AM Thomas Huth wrote: > On

Re: [RFC PATCH 00/12] QOM/QAPI integration part 1

On 11/3/21 18:29, Kevin Wolf wrote: This series adds QOM class definitions to the QAPI schema, introduces a new TypeInfo.instance_config() callback that configures the object at creation time (instead of setting properties individually) and is separate from runtime property setters (which often

[PULL v2 25/30] Hexagon HVX (target/hexagon) instruction decoding

Add new file to target/hexagon/meson.build Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/mmvec/decode_ext_mmvec.h | 24 target/hexagon/decode.c | 24 +++- target/hexagon/mmvec/decode_ext_mmvec.c | 236

[PULL v2 26/30] Hexagon HVX (target/hexagon) import instruction encodings

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/decode.c | 4 + target/hexagon/imported/allextenc.def| 20 + target/hexagon/imported/encode.def | 1 + target/hexagon/imported/mmvec/encode_ext.def | 794

[PULL v2 29/30] Hexagon HVX (tests/tcg/hexagon) scatter_gather test

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- tests/tcg/hexagon/scatter_gather.c | 1011 1 file changed, 1011 insertions(+) create mode 100644 tests/tcg/hexagon/scatter_gather.c diff --git a/tests/tcg/hexagon/scatter_gather.c

[PULL v2 23/30] Hexagon HVX (target/hexagon) helper overrides - vector stores

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 218 +++ 1 file changed, 218 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index 2d1d778..cdcc938 100644 ---

Re: [PATCH v4 3/3] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

Hello Juan, On Tue, Nov 2, 2021 at 9:32 AM Juan Quintela wrote: > > Leonardo Bras wrote: > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > zerocopy interface. > > > > Change multifd_send_sync_main() so it can distinguish the last sync from > > the setup and

[PULL v2 14/30] Hexagon HVX (target/hexagon) helper overrides for histogram instructions

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 106 +++ 1 file changed, 106 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index b5c6cad..a560504 100644 ---

[PULL v2 08/30] Hexagon HVX (target/hexagon) semantics generator - part 2

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_helper_funcs.py | 112 ++-- target/hexagon/gen_helper_protos.py | 16 ++- target/hexagon/gen_tcg_funcs.py | 254 ++-- 3 files changed, 360 insertions(+), 22

[PULL v2 13/30] Hexagon HVX (target/hexagon) helper overrides infrastructure

Build the infrastructure to create overrides for HVX instructions. We create a new empty file (gen_tcg_hvx.h) that will be populated in subsequent patches. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h

[PULL v2 18/30] Hexagon HVX (target/hexagon) helper overrides - vector max/min

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index e865410..f548404 100644 ---

[PULL v2 06/30] Hexagon HVX (target/hexagon) import macro definitions

Imported from the Hexagon architecture library imported/allext_macros.def Top level macro include for all extensions imported/macros.def Scalar core macros (some HVX here) imported/mmvec/macros.defHVX macro definitions The macro definition files specify

[PULL v2 30/30] Hexagon HVX (tests/tcg/hexagon) histogram test

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- tests/tcg/hexagon/hvx_histogram_input.h | 717 tests/tcg/hexagon/hvx_histogram_row.h | 24 ++ tests/tcg/hexagon/hvx_histogram.c | 88 tests/tcg/hexagon/hvx_histogram_row.S | 294

[PULL v2 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test

Tests for packet semantics vector loads (aligned and unaligned) vector stores (aligned and unaligned) vector masked stores vector new value store maximum HVX temps in a packet vector operations Acked-by: Richard Henderson Signed-off-by: Taylor Simpson ---

[PULL v2 27/30] Hexagon HVX (tests/tcg/hexagon) vector_add_int test

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- tests/tcg/hexagon/vector_add_int.c | 61 ++ 1 file changed, 61 insertions(+) create mode 100644 tests/tcg/hexagon/vector_add_int.c diff --git a/tests/tcg/hexagon/vector_add_int.c

[PULL v2 22/30] Hexagon HVX (target/hexagon) helper overrides - vector loads

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 150 +++ 1 file changed, 150 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index 435c7b5..2d1d778 100644 ---

[PULL v2 10/30] Hexagon HVX (target/hexagon) instruction utility functions

Functions to support scatter/gather Add new file to target/hexagon/meson.build Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/mmvec/system_ext_mmvec.h | 25 ++ target/hexagon/mmvec/system_ext_mmvec.c | 47 +

[PULL v2 17/30] Hexagon HVX (target/hexagon) helper overrides - vector shifts

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 122 +++ 1 file changed, 122 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index ac2143e..e865410 100644 ---

[PULL v2 12/30] Hexagon HVX (target/hexagon) TCG generation

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/translate.h | 61 target/hexagon/genptr.c| 15 +++ target/hexagon/translate.c | 239 - 3 files changed, 311 insertions(+), 4 deletions(-) diff --git

[PULL v2 07/30] Hexagon HVX (target/hexagon) semantics generator

Add HVX support to the semantics generator Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_semantics.c | 33 + target/hexagon/hex_common.py | 13 + 2 files changed, 46 insertions(+) diff --git

[PULL v2 11/30] Hexagon HVX (target/hexagon) helper functions

Probe and commit vector stores (masked and scatter/gather) Log vector register writes Add the execution counters to the debug log Histogram instructions Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/helper.h| 16 +++ target/hexagon/op_helper.c | 282

[PULL v2 04/30] Hexagon HVX (target/hexagon) instruction attributes

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/attribs_def.h.inc | 22 ++ 1 file changed, 22 insertions(+) diff --git a/target/hexagon/attribs_def.h.inc b/target/hexagon/attribs_def.h.inc index e44a7ea..dc890a5 100644 ---

[PULL v2 21/30] Hexagon HVX (target/hexagon) helper overrides - vector splat and abs

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index 32f8e20..435c7b5 100644 ---

[PULL v2 05/30] Hexagon HVX (target/hexagon) macros

macros to interface with the generator macros referenced in instruction semantics Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/macros.h | 22 +++ target/hexagon/mmvec/macros.h | 354 ++ 2 files changed, 376

[PULL v2 15/30] Hexagon HVX (target/hexagon) helper overrides - vector assign & cmov

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index a560504..916230e 100644 ---

[PULL v2 19/30] Hexagon HVX (target/hexagon) helper overrides - vector logical ops

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 42 ++ 1 file changed, 42 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index f548404..f53a7f2 100644 ---

[PULL v2 20/30] Hexagon HVX (target/hexagon) helper overrides - vector compares

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 103 +++ 1 file changed, 103 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index f53a7f2..32f8e20 100644 ---

[PULL v2 09/30] Hexagon HVX (target/hexagon) C preprocessor for decode tree

Acked-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_dectree_import.c | 13 + 1 file changed, 13 insertions(+) diff --git a/target/hexagon/gen_dectree_import.c b/target/hexagon/gen_dectree_import.c index 5b7ecfc..ee35467 100644 ---

[PULL v2 00/30] Hexagon HVX (target/hexagon) patch series

-20211103 for you to fetch changes up to 49278c1b0d7ef5864d0d8ad9a950296deb8b05ae: Hexagon HVX (tests/tcg/hexagon) histogram test (2021-11-03 16:01:38 -0500) This series adds support for the Hexagon Vector eXtensions (HVX

[PULL v2 01/30] Hexagon HVX (target/hexagon) README

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/README | 81 ++- 1 file changed, 80 insertions(+), 1 deletion(-) diff --git a/target/hexagon/README b/target/hexagon/README index b0b2435..372e247 100644 ---

[PULL v2 03/30] Hexagon HVX (target/hexagon) register names

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/hex_regs.h | 1 + target/hexagon/cpu.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/hexagon/hex_regs.h b/target/hexagon/hex_regs.h index f291911..e1b3149 100644 ---

[PULL v2 16/30] Hexagon HVX (target/hexagon) helper overrides - vector add & sub

Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg_hvx.h | 50 1 file changed, 50 insertions(+) diff --git a/target/hexagon/gen_tcg_hvx.h b/target/hexagon/gen_tcg_hvx.h index 916230e..ac2143e 100644 ---

[PULL v2 02/30] Hexagon HVX (target/hexagon) add Hexagon Vector eXtensions (HVX) to core

HVX is a set of wide vector instructions. Machine state includes vector registers (VRegs) vector predicate registers (QRegs) temporary registers for intermediate values store buffer (masked stores and scatter/gather) Acked-by: Richard Henderson Signed-off-by: Taylor Simpson ---

[PATCH 1/1] tests/acceptance: rename tests acceptance to tests avocado

In the discussion about renaming the `tests/acceptance` [1], the conclusion was that the folders inside `tests` are related to the framework running the tests and not directly related to the type of the tests. This changes the folder to `tests/avocado` and adjusts the MAKEFILE, the CI related

[PATCH 0/1] tests/acceptance: rename tests acceptance to tests avocado

In the discussion about renaming the `tests/acceptance` [1], the conclusion was that the folders inside `tests` are related to the framework running the tests and not directly related to the type of the tests. This changes the folder to `tests/avocado` and adjusts the MAKEFILE, the CI related

Re: [PATCH v4 2/3] QIOChannelSocket: Implement io_writev_zerocopy & io_flush_zerocopy for CONFIG_LINUX

On Tue, Nov 2, 2021 at 10:13 AM Juan Quintela wrote: > > Leonardo Bras wrote: > > For CONFIG_LINUX, implement the new optional callbacks io_write_zerocopy and > > io_flush_zerocopy on QIOChannelSocket, but enables it only when MSG_ZEROCOPY > > feature is available in the host kernel, which is

Re: [PATCH v5 0/6] optimize the downtime for vfio migration

On Wed, 3 Nov 2021 16:16:51 +0800 "Longpeng(Mike)" wrote: > Hi guys, > > In vfio migration resume phase, the cost would increase if the > vfio device has more unmasked vectors. We try to optimize it in > this series. > > You can see the commit message in PATCH 6 for details. > > Patch 1-3

Re: [PATCH] linux-user: Add GPL-2.0+ SPDX license identifier

Beh I meant "GPL-2.0-or-later" in the patch subject line. On 11/3/21 21:31, Philippe Mathieu-Daudé wrote: > Use Qualcomm License Identifier tool [*] to classify linux-user/ > files per license type, filtering those matching at least 60% the > "GPLv2 or later" type, and manually add the

Re: [PATCH v3 17/23] linux-user/openrisc: Use force_sig_fault

On Wed, Nov 03, 2021 at 10:08:41AM -0400, Richard Henderson wrote: > Use the new function instead of setting up a target_siginfo_t > and calling queue_signal. Fill in the missing PC for SIGTRAP. > > Signed-off-by: Richard Henderson > --- > linux-user/openrisc/cpu_loop.c | 18 +++---

[PATCH] linux-user: Add GPL-2.0+ SPDX license identifier

Use Qualcomm License Identifier tool [*] to classify linux-user/ files per license type, filtering those matching at least 60% the "GPLv2 or later" type, and manually add the GPL-2.0-or-later SPDX comment. $ license-identifier --output_format easy_read \ --threshold 0.6 --input_path

Re: [PATCH v6 1/2] vhost-user: remove VirtQ notifier restore

On Wed, Nov 03, 2021 at 02:48:41PM +, Xueming(Steven) Li wrote: > On Tue, 2021-11-02 at 02:49 -0400, Michael S. Tsirkin wrote: > > On Tue, Nov 02, 2021 at 06:08:39AM +, Xueming(Steven) Li wrote: > > > On Mon, 2021-11-01 at 17:06 -0400, Michael S. Tsirkin wrote: > > > > On Mon, Nov 01, 2021

Re: [PATCH] postocpy: Check that postocpy fd's are not NULL

"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> If postcopy has finished, it frees the array. >> But vhost-user unregister it at cleanup time. > > I must admit to being confused as the double migrate case vs migrate > once and shutdown. It might just be an

Re: [PATCH] postocpy: Check that postocpy fd's are not NULL

* Juan Quintela (quint...@redhat.com) wrote: > If postcopy has finished, it frees the array. > But vhost-user unregister it at cleanup time. I must admit to being confused as the double migrate case vs migrate once and shutdown. It might just be an ordering thing? I notice that

RE: [PULL for 6.2 00/21] testing, plugin and gdbstub updates

We'll investigate the toolchain issue. This is compiling tests/tcg/multiarch/signals.c, right? Also, I'll do as Richard suggests in his email and respin the pull with the HVX tests disabled in the makefile. Thanks, Taylor > -Original Message- > From: Alex Bennée > Sent: Wednesday,

[PATCH] postocpy: Check that postocpy fd's are not NULL

If postcopy has finished, it frees the array. But vhost-user unregister it at cleanup time. Signed-off-by: Juan Quintela --- migration/postcopy-ram.c | 4 1 file changed, 4 insertions(+) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index e721f69d0f..d18b5d05b2 100644

Re: [PATCH v2 26/30] bsd-user: add arm target build

On Tue, Nov 2, 2021 at 9:47 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/2/21 6:52 PM, Warner Losh wrote: > > CC: Paolo Bonzini > > Signed-off-by: Warner Losh > > Acked-by: Kyle Evans > > Reviewed-by: Richard Henderson > > --- > > configs/targets/arm-bsd-user.mak | 2

Re: [PATCH v2 24/30] bsd-user/arm/target_arch_signal.h: arm set_mcontext

On Tue, Nov 2, 2021 at 9:40 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/2/21 6:52 PM, Warner Losh wrote: > > +env->regs[15] = tswap32(gr[TARGET_REG_PC]); > > This will be able to crash qemu with an odd pc in thumb mode. > You'd have to artificially create this mcontext

Re: [PATCH v2 22/30] bsd-user/arm/target_arch_signal.h: arm set_sigtramp_args

On Tue, Nov 2, 2021 at 9:37 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/2/21 6:52 PM, Warner Losh wrote: > > +/* > > + * Low bit indicates whether or not we're entering thumb mode. > > + */ > > +cpsr = cpsr_read(env); > > +if (ka->_sa_handler & 1) { > >

Re: [PATCH 6/6] docker: Add Fedora 35 container

On 11/3/21 18:51, John Snow wrote:> On Wed, Nov 3, 2021 at 1:01 PM Daniel P. Berrangé > wrote: > > On Wed, Nov 03, 2021 at 10:48:44AM -0400, John Snow wrote: > > Or, more accurately, update our current Fedora container to Fedora 35, > > and then add a new

Re: [PATCH] hw/m68k: Fix typo in SPDX tag

Le 03/11/2021 à 11:53, Philippe Mathieu-Daudé a écrit : Fix 'Identifer' -> 'Identifier' typo. Cc: Laurent Vivier Fixes: 8c6df16ff60 ("hw/char: add goldfish-tty") Fixes: 87855593903 ("hw/intc: add goldfish-pic") Fixes: 2fde99ee312 ("m68k: add an interrupt controller") Fixes: 0791bc02b8f ("m68k:

Re: [RFC PATCH] tests/docker: force NOUSER=1 for base images

On 11/3/21 18:13, Alex Bennée wrote: > As base images are often used to build further images like toolchains > ensure we don't add the local user by accident. The local user should > only exist on local images and not anything that gets pushed up to the > public registry. > > Reported-by: Richard

Re: [PATCH v2 14/30] bsd-user/arm/target_arch_thread.h: Routines to create and switch to a thread

[[ Adding Olivier Houchard to confirm my reading of the ARM init twisty maze of code ]] On Tue, Nov 2, 2021 at 9:31 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 11/2/21 6:52 PM, Warner Losh wrote: > > +/* > > + * Thumb mode is encoded by the low bit in the entry point

Re: [PATCH 6/6] docker: Add Fedora 35 container

On Wed, Nov 3, 2021 at 1:01 PM Daniel P. Berrangé wrote: > On Wed, Nov 03, 2021 at 10:48:44AM -0400, John Snow wrote: > > Or, more accurately, update our current Fedora container to Fedora 35, > > and then add a new fedora34 container and build test. > > > > Signed-off-by: John Snow > > --- > >

Re: [PATCH v5 00/26] fdt: Make OF_BOARD a boolean option

> From: Simon Glass > Date: Wed, 3 Nov 2021 10:45:42 -0600 > > Hi Tom, > > On Wed, 3 Nov 2021 at 10:02, Tom Rini wrote: > > > > On Wed, Nov 03, 2021 at 09:22:58AM +0100, Mark Kettenis wrote: > > > > From: Simon Glass > > > > Date: Tue, 2 Nov 2021 19:20:51 -0600 > > > > > > > > Hi Mark, > > >

[RFC PATCH 12/12] qapi/qom: Add class definition for rng-egd

Switch object creation to .instance_config and remove the property setter that would only return an error after creation anyway. Signed-off-by: Kevin Wolf --- qapi/qom.json | 12 ++-- backends/rng-egd.c | 18 +++--- 2 files changed, 13 insertions(+), 17 deletions(-)

[RFC PATCH 08/12] qapi: Create qom-config:... type for classes

For every class that has a 'config' definition, a corresponding 'qom-config:$QOM_TYPE' type is automatically created that contains the configuration for the class and all of its parent classes. Signed-off-by: Kevin Wolf --- scripts/qapi/schema.py | 60 +++---

[RFC PATCH 07/12] qapi: Allow defining QOM classes

Signed-off-by: Kevin Wolf --- scripts/qapi/expr.py | 28 +- scripts/qapi/schema.py | 66 ++ 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 3cb389e875..77550629f3 100644 ---

[RFC PATCH 06/12] rng-backend: Implement .instance_config

This commit really only serves as an illustration because the only property in rng-backend is 'opened', which is useless and deprecated. Implement .instance_config in order to show that .instance_config is working both when parent class and subclass implement it (rng-random) and when only the

[RFC PATCH 04/12] qom: Add instance_config() to TypeInfo

Instead of providing the whole configuration through property setters, object_config() can now use the instance_config() callback. Options that are not consumed by the callback (e.g. because they belong to a parent class that hasn't been converted to the new callback yet) are still set as

[RFC PATCH 11/12] qapi/qom: Add class definition for rng-builtin

This doesn't add any configuration options compared to its parent class, so this just makes the schema a little more descriptive with no other code changes. Signed-off-by: Kevin Wolf --- qapi/qom.json | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/qapi/qom.json

[RFC PATCH 10/12] qapi: Generate QOM config marshalling code

Signed-off-by: Kevin Wolf --- backends/rng-random.c | 17 ++-- backends/rng.c| 17 ++-- scripts/qapi/main.py | 2 + scripts/qapi/qom.py | 91 +++ qapi/meson.build | 3 ++ 5 files changed, 104 insertions(+), 26 deletions(-) create

[RFC PATCH 02/12] qom: Create object_configure()

This renames object_set_properties_from_qdict() to object_configure() and removes the QDict parameter from it: With visit_next_struct_member() it can set all properties without looking at the keys of the QDict. Signed-off-by: Kevin Wolf --- qom/object_interfaces.c | 13 ++--- 1 file

[RFC PATCH 03/12] qom: Make object_configure() public

This makes object_configure() public and moves it to qom/object.c because it will need to access TypeImpl in the future. Signed-off-by: Kevin Wolf --- include/qom/object.h| 3 +++ qom/object.c| 17 + qom/object_interfaces.c | 17 - 3 files

[RFC PATCH 05/12] rng-random: Implement .instance_config

This adds an implementation for .instance_config to the rng-random object. It is split into a function doing the actual configuration and providing a native C interface and a marshalling function with a visitor interface that we want to generate from the QAPI schema later. rng-random objects are

[RFC PATCH 09/12] qapi/qom: Convert rng-backend/random to class

Signed-off-by: Kevin Wolf --- qapi/qom.json | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/qapi/qom.json b/qapi/qom.json index ccd1167808..a167e91f67 100644 --- a/qapi/qom.json +++ b/qapi/qom.json @@ -721,6 +721,16 @@ { 'struct': 'RngProperties',

[RFC PATCH 00/12] QOM/QAPI integration part 1

This series adds QOM class definitions to the QAPI schema, introduces a new TypeInfo.instance_config() callback that configures the object at creation time (instead of setting properties individually) and is separate from runtime property setters (which often used to be not really tested for

[RFC PATCH 01/12] qapi: Add visit_next_struct_member()

This adds a way to generically deal with an unknown set of members in input visitors by just getting the name of the next unvisited member. QOM object creation code will use it to have generic code that calls property setters which then in turn have the more specific knowledge how to visit the

Re: [PULL for 6.2 00/21] testing, plugin and gdbstub updates

Alex Bennée writes: > The following changes since commit e86e00a2493254d072581960b48461eb96481e45: > > Merge remote-tracking branch > 'remotes/berrange/tags/hmp-x-qmp-620-pull-request' into staging (2021-11-03 > 08:04:32 -0400) > > tests/docker: Update debian-hexagon-cross to a

Re: [PATCH v5 00/26] fdt: Make OF_BOARD a boolean option

Hi Simon I don't know if this is correct etiquette but at this moment it feels just right to do this: The problem is not confusion it is that the patch set goes in a direction that makes no sense. On Tue, 26 Oct 2021 at 02:24, Simon Glass wrote: > With Ilias' efforts we have dropped

Re: [PATCH v5 00/26] fdt: Make OF_BOARD a boolean option

On Wed, Nov 03, 2021 at 10:45:11AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 27 Oct 2021 at 13:25, Tom Rini wrote: > > > > On Wed, Oct 27, 2021 at 12:23:21PM -0600, Simon Glass wrote: > > > Hi François, > > > > > > On Wed, 27 Oct 2021 at 09:14, François Ozog > > > wrote: > > > > > > > >

[PULL 20/21] tests/tcg: remove debug polluting make output

Fixes: 5343a837cd ("tests/tcg: move some multiarch files and make conditional") Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20211026173914.79377-1-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/Makefile.target

[PULL 15/21] chardev: don't exit() straight away on C-a x

While there are a number of uses in the code-base of the exit(0) pattern it gets in the way of clean exit which can do all of it's house-keeping. In particular it was reported that you can crash plugins this way because TCG can still be running on other threads when the atexit callback is called.

  1   2   3   4   >