Re: [PATCH v13 1/7] net/vmnet: add vmnet dependency and customizable option

2022-01-19 Thread Roman Bolshakov
On Thu, Jan 13, 2022 at 08:22:13PM +0300, Vladislav Yaroshchuk wrote: > vmnet.framework dependency is added with 'vmnet' option > to enable or disable it. Default value is 'auto'. > > vmnet features to be used are available since macOS 11.0, Hi Vladislav, I'm not sure if the comment belongs

Re: [PATCH v7 21/22] target/riscv: Enable uxl field write

2022-01-19 Thread LIU Zhiwei
Hi Alistair, Do you mind share you test method? I follow the xvisor document on https://github.com/xvisor/xvisor/blob/v0.3.1/docs/riscv/riscv64-qemu.txt. But it can't run even on QEMU master branch. It blocks on OpenSBI. liuzw@b12e0231:/mnt/ssd/liuzw/git/xvisor$  qemu-system-riscv64 -cpu

Re: [PATCH 0/2] virtio: Add vhost-user-gpio device's support

2022-01-19 Thread Viresh Kumar
On 17-01-22, 10:11, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Wed, Jan 12, 2022 at 05:04:57PM +0530, Viresh Kumar wrote: > >> Hello, > >> > >> This patchset adds vhost-user-gpio device's support in Qemu. The support > >> for the > >> same has already been added to virtio

Re: [PATCH v7 21/22] target/riscv: Enable uxl field write

2022-01-19 Thread Alistair Francis
On Thu, Jan 20, 2022 at 12:12 PM LIU Zhiwei wrote: > > > On 2022/1/20 上午8:35, Alistair Francis wrote: > > On Wed, Jan 19, 2022 at 3:34 PM LIU Zhiwei wrote: > >> Signed-off-by: LIU Zhiwei > >> Reviewed-by: Richard Henderson > >> Reviewed-by: Alistair Francis > >> --- > >> target/riscv/csr.c

Re: [PATCH v3 5/6] docs/system/devices/usb: Add CanoKey to USB devices examples

2022-01-19 Thread Hongren (Zenithal) Zheng
On Tue, Jan 18, 2022 at 10:28:49AM +0100, Thomas Huth wrote: > On 13/01/2022 19.11, Hongren (Zenithal) Zheng wrote: > > Signed-off-by: Hongren (Zenithal) Zheng > > --- > > docs/system/devices/usb.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/docs/system/devices/usb.rst

Re: [PATCH v7 21/22] target/riscv: Enable uxl field write

2022-01-19 Thread LIU Zhiwei
On 2022/1/20 上午8:35, Alistair Francis wrote: On Wed, Jan 19, 2022 at 3:34 PM LIU Zhiwei wrote: Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/csr.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff

Re: [PATCH RFC 05/15] migration: Simplify unqueue_page()

2022-01-19 Thread Peter Xu
On Wed, Jan 19, 2022 at 04:36:50PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > This patch simplifies unqueue_page() on both sides of it (itself, and > > caller). > > > > Firstly, due to the fact that right after unqueue_page() returned true, > > we'll > >

Re: [PATCH v7 21/22] target/riscv: Enable uxl field write

2022-01-19 Thread LIU Zhiwei
On 2022/1/20 上午8:35, Alistair Francis wrote: On Wed, Jan 19, 2022 at 3:34 PM LIU Zhiwei wrote: Signed-off-by: LIU Zhiwei Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/csr.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff

Re: [PATCH RFC 02/15] migration: Allow pss->page jump over clean pages

2022-01-19 Thread Peter Xu
On Wed, Jan 19, 2022 at 01:42:47PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Commit ba1b7c812c ("migration/ram: Optimize ram_save_host_page()") managed > > to > > optimize host huge page use case by scanning the dirty bitmap when looking > > for > > the

Re: [PATCH v7 4/5] migration: Add migrate_use_tls() helper

2022-01-19 Thread Peter Xu
On Wed, Jan 19, 2022 at 03:06:55PM -0300, Leonardo Bras Soares Passos wrote: > Hello Peter, > > On Thu, Jan 13, 2022 at 4:02 AM Peter Xu wrote: > > > > On Thu, Jan 06, 2022 at 07:13:41PM -0300, Leonardo Bras wrote: > > > void migration_channel_process_incoming(QIOChannel *ioc) > > > { > > > -

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-19 Thread Peter Xu
On Wed, Jan 19, 2022 at 02:22:56PM -0300, Leonardo Bras Soares Passos wrote: > Hello Daniel, > > On Thu, Jan 13, 2022 at 7:42 AM Daniel P. Berrangé > wrote: > > > > On Thu, Jan 13, 2022 at 06:34:12PM +0800, Peter Xu wrote: > > > On Thu, Jan 13, 2022 at 10:06:14AM +, Daniel P. Berrangé

Re: [PATCH v7 21/22] target/riscv: Enable uxl field write

2022-01-19 Thread Alistair Francis
On Wed, Jan 19, 2022 at 3:34 PM LIU Zhiwei wrote: > > Signed-off-by: LIU Zhiwei > Reviewed-by: Richard Henderson > Reviewed-by: Alistair Francis > --- > target/riscv/csr.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/target/riscv/csr.c

Re: [PATCH v2] qapi: Cleanup SGX related comments and restore @section-size

2022-01-19 Thread Philippe Mathieu-Daudé via
+Markus for QAPI deprecation On 1/20/22 00:57, Yang Zhong wrote: > The SGX NUMA patches were merged into Qemu 7.0 release, we need > clarify detailed version history information and also change > some related comments, which make SGX related comments clearer. > > The QMP command schema promises

[PATCH v3 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-19 Thread Philippe Mathieu-Daudé via
From: Eric Auger Representing the CRB cmd/response buffer as a standard RAM region causes some trouble when the device is used with VFIO. Indeed VFIO attempts to DMA_MAP this region as usual RAM but this latter does not have a valid page size alignment causing such an error report:

[PATCH v3 2/2] hw/vfio/common: Silence ram device offset alignment error traces

2022-01-19 Thread Philippe Mathieu-Daudé via
From: Eric Auger Failing to DMA MAP a ram_device should not cause an error message. This is currently happening with the TPM CRB command region and this is causing confusion. We may want to keep the trace for debug purpose though. Signed-off-by: Eric Auger Tested-by: Stefan Berger Acked-by:

[PATCH v3 0/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-19 Thread Philippe Mathieu-Daudé via
This is a respin of Eric's work, but not making tpm_crb.c target specific. Based-on: <2022012836.229419-1-f4...@amsat.org> "exec/cpu: Make host pages variables / macros 'target agnostic'" https://lore.kernel.org/qemu-devel/2022012836.229419-1-f4...@amsat.org/ -- Eric's v2 cover: This

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-01-19 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 04:41:52PM -0500, Jagannathan Raman wrote: > Allow PCI buses to be part of isolated CPU address spaces. This has a > niche usage. > > TYPE_REMOTE_MACHINE allows multiple VMs to house their PCI devices in > the same machine/server. This would cause address space collision

[PATCH] exec/cpu: Make host pages variables / macros 'target agnostic'

2022-01-19 Thread Philippe Mathieu-Daudé via
"host" pages are related to the *host* not the *target*, thus the qemu_host_page_size / qemu_host_page_mask variables and the HOST_PAGE_ALIGN() / REAL_HOST_PAGE_ALIGN() macros can be moved to "exec/cpu-common.h" which is target agnostic. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v2 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-19 Thread Alex Williamson
On Wed, 19 Jan 2022 23:46:19 +0100 Philippe Mathieu-Daudé wrote: > On 18/1/22 16:33, Eric Auger wrote: > > Representing the CRB cmd/response buffer as a standard > > RAM region causes some trouble when the device is used > > with VFIO. Indeed VFIO attempts to DMA_MAP this region > > as usual RAM

Re: Cross Architecture Kernel Modules?

2022-01-19 Thread Kenneth Adam Miller
Would it be possible somehow to save the TCG cache, as with user binaries, but for a kernel module, before then loading that kernel module into memory the target architecture whether in or outside of QEMU? On Wed, Jan 19, 2022 at 2:42 PM Kenneth Adam Miller < kennethadammil...@gmail.com> wrote:

Re: [PATCH] hw/nvram: use at24 macro

2022-01-19 Thread Philippe Mathieu-Daudé via
On 19/1/22 22:43, Patrick Venture wrote: Use the macro for going from I2CSlave to EEPROMState. Signed-off-by: Patrick Venture --- hw/nvram/eeprom_at24c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-01-19 Thread Philippe Mathieu-Daudé via
On 18/1/22 16:33, Eric Auger wrote: Representing the CRB cmd/response buffer as a standard RAM region causes some trouble when the device is used with VFIO. Indeed VFIO attempts to DMA_MAP this region as usual RAM but this latter does not have a valid page size alignment causing such an error

[PATCH v5 18/18] vfio-user: avocado tests for vfio-user

2022-01-19 Thread Jagannathan Raman
Avocado tests for libvfio-user in QEMU - tests startup, hotplug and migration of the server object Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- MAINTAINERS| 1 + tests/avocado/vfio-user.py | 225

[PATCH] hw/nvram: use at24 macro

2022-01-19 Thread Patrick Venture
Use the macro for going from I2CSlave to EEPROMState. Signed-off-by: Patrick Venture --- hw/nvram/eeprom_at24c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index af6f5dbb99..da435500ba 100644 ---

[PATCH v5 16/18] vfio-user: handle device interrupts

2022-01-19 Thread Jagannathan Raman
Forward remote device's interrupts to the guest Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/hw/pci/pci.h | 6 +++ hw/pci/msi.c | 13 +- hw/pci/msix.c | 12 +- hw/remote/vfio-user-obj.c | 89

[PATCH v5 15/18] vfio-user: handle PCI BAR accesses

2022-01-19 Thread Jagannathan Raman
Determine the BARs used by the PCI device and register handlers to manage the access to the same. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/vfio-user-obj.c | 92

[PATCH v5 14/18] vfio-user: handle DMA mappings

2022-01-19 Thread Jagannathan Raman
Define and register callbacks to manage the RAM regions used for device DMA Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Stefan Hajnoczi --- hw/remote/vfio-user-obj.c | 50 +++

[PATCH v5 06/18] vfio-user: add HotplugHandler for remote machine

2022-01-19 Thread Jagannathan Raman
Allow hotplugging of PCI(e) devices to remote machine Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/machine.c | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/remote/machine.c

[PATCH v5 17/18] vfio-user: register handlers to facilitate migration

2022-01-19 Thread Jagannathan Raman
Store and load the device's state during migration. use libvfio-user's handlers for this purpose Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/migration/vmstate.h | 2 + migration/savevm.h | 2 +

[PATCH v5 04/18] pci: create and free isolated PCI buses

2022-01-19 Thread Jagannathan Raman
Adds pci_isol_bus_new() and pci_isol_bus_free() functions to manage creation and destruction of isolated PCI buses. Also adds qdev_get_bus and qdev_put_bus callbacks to allow the choice of parent bus. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman

[PATCH v5 12/18] vfio-user: run vfio-user context

2022-01-19 Thread Jagannathan Raman
Setup a handler to run vfio-user context. The context is driven by messages to the file descriptor associated with it - get the fd for the context and hook up the handler with it Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- qapi/misc.json

[PATCH v5 11/18] vfio-user: find and init PCI device

2022-01-19 Thread Jagannathan Raman
Find the PCI device with specified id. Initialize the device context with the QEMU PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 60 +++ 1 file changed, 60

[PATCH v5 10/18] vfio-user: instantiate vfio-user context

2022-01-19 Thread Jagannathan Raman
create a context with the vfio-user library to run a PCI device Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 78 +++ 1 file changed, 78 insertions(+) diff --git

[PATCH v5 01/18] configure, meson: override C compiler for cmake

2022-01-19 Thread Jagannathan Raman
The compiler path that cmake gets from meson is corrupted. It results in the following error: | -- The C compiler identification is unknown | CMake Error at CMakeLists.txt:35 (project): | The CMAKE_C_COMPILER: | /opt/rh/devtoolset-9/root/bin/cc;-m64;-mcx16 | is not a full path to an existing

[PATCH v5 13/18] vfio-user: handle PCI config space accesses

2022-01-19 Thread Jagannathan Raman
Define and register handlers for PCI config space accesses Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/vfio-user-obj.c | 45 +++ hw/remote/trace-events| 2 ++ 2 files changed, 47

[PATCH v5 09/18] vfio-user: define vfio-user-server object

2022-01-19 Thread Jagannathan Raman
Define vfio-user object which is remote process server for QEMU. Setup object initialization functions and properties necessary to instantiate the object Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- qapi/qom.json | 20 +++-

[PATCH v5 07/18] vfio-user: set qdev bus callbacks for remote machine

2022-01-19 Thread Jagannathan Raman
Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/remote/machine.c | 57 + 1 file changed, 57 insertions(+) diff --git a/hw/remote/machine.c b/hw/remote/machine.c index 220ff01aa9..221a8430c1 100644

[PATCH v5 08/18] vfio-user: build library

2022-01-19 Thread Jagannathan Raman
add the libvfio-user library as a submodule. build it as a cmake subproject. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- configure | 19 +- meson.build| 44

[PATCH v5 03/18] pci: isolated address space for PCI bus

2022-01-19 Thread Jagannathan Raman
Allow PCI buses to be part of isolated CPU address spaces. This has a niche usage. TYPE_REMOTE_MACHINE allows multiple VMs to house their PCI devices in the same machine/server. This would cause address space collision as well as be a security vulnerability. Having separate address spaces for

[PATCH v5 05/18] qdev: unplug blocker for devices

2022-01-19 Thread Jagannathan Raman
Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- include/hw/qdev-core.h | 5 + softmmu/qdev-monitor.c | 35 +++ 2 files changed, 40 insertions(+) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h

[PATCH v5 02/18] tests/avocado: Specify target VM argument to helper routines

2022-01-19 Thread Jagannathan Raman
Specify target VM for exec_command and exec_command_and_wait_for_pattern routines Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Beraldo Leal --- tests/avocado/avocado_qemu/__init__.py | 14

[PATCH v5 00/18] vfio-user server in QEMU

2022-01-19 Thread Jagannathan Raman
Hi, Thank you for taking the time to provide a comprehensive feedback of the last series of patches. We have addressed all the comments. We are posting this v5 of the series, which incorporates all the feedback. Kindly share your feedback for this latest series We added the following patches to

Re: [PATCH v2 00/13] arm gicv3 ITS: Various bug fixes and refactorings

2022-01-19 Thread Andre Przywara
On Wed, 19 Jan 2022 10:15:52 + Peter Maydell wrote: Hi Peter, > On Tue, 18 Jan 2022 at 23:30, Andre Przywara wrote: > > Looking at k-u-t's arm/gic.c and QEMU's hw/intc/arm_gic.c I see two > > problems here: QEMU implements word accesses as four successive calls to > > gic_dist_readb() -

Re: [PATCH v2 0/2] TPM-CRB: Remove spurious error report when used with VFIO

2022-01-19 Thread Stefan Berger
On 1/18/22 10:33, Eric Auger wrote: This series aims at removing a spurious error message we get when launching a guest with a TPM-CRB device and VFIO-PCI devices. The CRB command buffer currently is a RAM MemoryRegion and given its base address alignment, it causes an error report on

Re: [PATCH v2 2/2] hw/vfio/common: Silence ram device offset alignment error traces

2022-01-19 Thread Stefan Berger
On 1/19/22 15:13, Alex Williamson wrote: On Tue, 18 Jan 2022 16:33:06 +0100 Eric Auger wrote: Failing to DMA MAP a ram_device should not cause an error message. This is currently happening with the TPM CRB command region and this is causing confusion. We may want to keep the trace for

Re: [PATCH v2 2/2] hw/vfio/common: Silence ram device offset alignment error traces

2022-01-19 Thread Alex Williamson
On Tue, 18 Jan 2022 16:33:06 +0100 Eric Auger wrote: > Failing to DMA MAP a ram_device should not cause an error message. > This is currently happening with the TPM CRB command region and > this is causing confusion. > > We may want to keep the trace for debug purpose though. > >

Re: [RESEND] target/riscv: fix RV128 lq encoding

2022-01-19 Thread Philipp Tomsich
The cbo.* mnemonics share their opcode space with lq for those cases where rd == 0 ("brownfield" encodings). "Major opcode" refers to inst[6:0] according to chapter 26. In overlapping multi-group syntax, this would look like: > { > > # *** RV32 Zicbom Standard Extension *** > > cbo_clean

Re: iotest 040, 041, intermittent failure in netbsd VM

2022-01-19 Thread John Snow
On Tue, Jan 18, 2022 at 1:34 PM John Snow wrote: > > On Tue, Jan 18, 2022 at 7:13 AM Peter Maydell > wrote: > > > > On Mon, 17 Jan 2022 at 20:35, John Snow wrote: > > > I do expect this to print more information on failure than it > > > currently is, though (bug somewhere in machine.py, I

Re: [RESEND] target/riscv: fix RV128 lq encoding

2022-01-19 Thread Frédéric Pétrot
Le 18/01/2022 à 17:32, Christoph Muellner a écrit : If LQ has func3==010 and is located in the MISC-MEM opcodes, then it conflicts with the CBO opcode space. However, since LQ is specified as: "LQ is added to the MISC-MEM major opcode", we have an implementation bug, because 'major opcode'

Re: Cross Architecture Kernel Modules?

2022-01-19 Thread Kenneth Adam Miller
The source for it isn't available in order that it be compiled to the desired architecture. What 3rd party forks take this approach? On Wed, Jan 19, 2022 at 2:06 PM Alex Bennée wrote: > > Kenneth Adam Miller writes: > > > Hello all, > > > > I just want to pose the following problem: > > > >

Re: [PATCH 2/3] migration/migration.c: Avoid COLO boot in postcopy migration

2022-01-19 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > COLO dose not support postcopy migration and remove the Fixme. 'does' not 'dose' > Signed-off-by: Zhang Chen > --- > migration/migration.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/migration/migration.c

[PATCH v2 5/5] python/aqmp: add socket bind step to legacy.py

2022-01-19 Thread John Snow
The old QMP library would actually bind to the server address during __init__(). The new library delays this to the accept() call, because binding occurs inside of the call to start_[unix_]server(), which is an async method -- so it cannot happen during __init__ anymore. Python 3.7+ adds the

[PATCH v2 3/5] python/machine: raise VMLaunchFailure exception from launch()

2022-01-19 Thread John Snow
This allows us to pack in some extra information about the failure, which guarantees that if the caller did not *intentionally* cause a failure (by capturing this Exception), some pretty good clues will be printed at the bottom of the traceback information. This will help make failures in the

[PATCH v2 4/5] python: upgrade mypy to 0.780

2022-01-19 Thread John Snow
We need a slightly newer version of mypy in order to use some features of the asyncio server functions in a forthcoming patch. (Note: pipenv is not really suited to upgrading individual packages; I need to replace this tool with something better for the task. For now, the miscellaneous updates

[PATCH v2 1/5] python/aqmp: Fix negotiation with pre-"oob" QEMU

2022-01-19 Thread John Snow
QEMU versions prior to the "oob" capability *also* can't accept the "enable" keyword argument at all. Fix the handshake process with older QEMU versions. Signed-off-by: John Snow --- python/qemu/aqmp/qmp_client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 2/5] python: use avocado's "new" runner

2022-01-19 Thread John Snow
The old legacy runner no longer seems to work with output logging, so we can't see failure logs when a test case fails. The new runner doesn't (seem to) support Coverage.py yet, but seeing error output is a more important feature. Signed-off-by: John Snow --- python/avocado.cfg | 2 +- 1 file

[PATCH v2 0/5] Python: minor fixes

2022-01-19 Thread John Snow
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-aqmp-fixes CI: https://gitlab.com/jsnow/qemu/-/pipelines/451899886 Fix a couple AQMP bugs and improve some minor irritants. V2: - Hack-fix a race condition inherent between machine.py and aqmp/legacy.py - Improve error reporting from

Re: Cross Architecture Kernel Modules?

2022-01-19 Thread Alex Bennée
Kenneth Adam Miller writes: > Hello all, > > I just want to pose the following problem: > > There is a kernel module for a non-native architecture, say, arch 1. For > performance reasons, the rest of all of the software needs to run > natively on a different arch, arch 2. Is there any way to

Re: [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux

2022-01-19 Thread Leonardo Bras Soares Passos
On Wed, Jan 19, 2022 at 3:16 PM Daniel P. Berrangé wrote: > > On Wed, Jan 19, 2022 at 03:03:29PM -0300, Leonardo Bras Soares Passos wrote: > > Hello Daniel, > > > > On Thu, Jan 13, 2022 at 10:10 AM Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jan 06, 2022 at 07:13:40PM -0300, Leonardo Bras

Re: [PULL 00/10] s390x patches (shift instructions, MAINTAINERS, ...)

2022-01-19 Thread Peter Maydell
On Wed, 19 Jan 2022 at 08:32, Thomas Huth wrote: > > Hi! > > The following changes since commit 69353c332c558cead5f8081d0bb69f989fe33fa3: > > Merge remote-tracking branch > 'remotes/konstantin/tags/qga-win32-pull-2022-01-10' into staging (2022-01-16 > 16:32:34 +) > > are available in the

Re: [PATCH v5 28/31] block.c: assert BQL lock held in bdrv_co_invalidate_cache

2022-01-19 Thread Kevin Wolf
Am 20.12.2021 um 13:20 hat Emanuele Giuseppe Esposito geschrieben: > > > On 17/12/2021 17:38, Emanuele Giuseppe Esposito wrote: > > > > > > On 17/12/2021 12:04, Hanna Reitz wrote: > > > On 24.11.21 07:44, Emanuele Giuseppe Esposito wrote: > > > > bdrv_co_invalidate_cache is special: it is an

Re: [PATCH v7 1/5] QIOChannel: Add flags on io_writev and introduce io_flush callback

2022-01-19 Thread Leonardo Bras Soares Passos
On Tue, Jan 18, 2022 at 10:58 PM Peter Xu wrote: > > On Tue, Jan 18, 2022 at 05:45:09PM -0300, Leonardo Bras Soares Passos wrote: > > Hello Peter, > > > > On Thu, Jan 13, 2022 at 3:28 AM Peter Xu wrote: > > > > > > On Thu, Jan 06, 2022 at 07:13:38PM -0300, Leonardo Bras wrote: > > > > diff --git

Re: [PATCH v7 5/5] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-01-19 Thread Leonardo Bras Soares Passos
Hello Peter, On Thu, Jan 13, 2022 at 4:15 AM Peter Xu wrote: > > On Thu, Jan 06, 2022 at 07:13:42PM -0300, Leonardo Bras wrote: > > Implement zero copy on nocomp_send_write(), by making use of QIOChannel > > writev + flags & flush interface. > > > > Change multifd_send_sync_main() so it can

Re: [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux

2022-01-19 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 03:03:29PM -0300, Leonardo Bras Soares Passos wrote: > Hello Daniel, > > On Thu, Jan 13, 2022 at 10:10 AM Daniel P. Berrangé > wrote: > > > > On Thu, Jan 06, 2022 at 07:13:40PM -0300, Leonardo Bras wrote: > > > Add property that allows zero-copy migration of memory

Re: [PATCH v7 4/5] migration: Add migrate_use_tls() helper

2022-01-19 Thread Leonardo Bras Soares Passos
Hello Daniel, On Thu, Jan 13, 2022 at 10:11 AM Daniel P. Berrangé wrote: > > On Thu, Jan 06, 2022 at 07:13:41PM -0300, Leonardo Bras wrote: > > A lot of places check parameters.tls_creds in order to evaluate if TLS is > > in use, and sometimes call migrate_get_current() just for that test. > > >

Re: [PATCH v7 4/5] migration: Add migrate_use_tls() helper

2022-01-19 Thread Leonardo Bras Soares Passos
Hello Peter, On Thu, Jan 13, 2022 at 4:02 AM Peter Xu wrote: > > On Thu, Jan 06, 2022 at 07:13:41PM -0300, Leonardo Bras wrote: > > void migration_channel_process_incoming(QIOChannel *ioc) > > { > > -MigrationState *s = migrate_get_current(); > > Error *local_err = NULL; > > > >

Re: [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux

2022-01-19 Thread Leonardo Bras Soares Passos
Hello Daniel, On Thu, Jan 13, 2022 at 10:10 AM Daniel P. Berrangé wrote: > > On Thu, Jan 06, 2022 at 07:13:40PM -0300, Leonardo Bras wrote: > > Add property that allows zero-copy migration of memory pages, > > and also includes a helper function migrate_use_zero_copy() to check > > if it's

Re: [PATCH v7 3/5] migration: Add zero-copy parameter for QMP/HMP for Linux

2022-01-19 Thread Leonardo Bras Soares Passos
Hello Peter, On Thu, Jan 13, 2022 at 4:00 AM Peter Xu wrote: > > On Thu, Jan 06, 2022 at 07:13:40PM -0300, Leonardo Bras wrote: > > Add property that allows zero-copy migration of memory pages, > > and also includes a helper function migrate_use_zero_copy() to check > > if it's enabled. > > > >

Re: [PATCH 0/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Daniel P . Berrangé
On Wed, Jan 19, 2022 at 06:17:57PM +0100, Andrea Bolognani wrote: > See [1] for recent discussion about libgcrypt specifically, which the > first patch is about. > > After writing that one, I realized that there is no point in > explicitly passing 'method' to dependency() because Meson will do

Re: [PATCH 0/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
On Wed, Jan 19, 2022 at 05:38:38PM +, Daniel P. Berrangé wrote: > On Wed, Jan 19, 2022 at 06:17:57PM +0100, Andrea Bolognani wrote: > > See [1] for recent discussion about libgcrypt specifically, which the > > first patch is about. > > > > After writing that one, I realized that there is no

Re: [PATCH 1/3] migration/migration.c: Add missed default error handler for migration state

2022-01-19 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > In the migration_completion() no other status is expected, for > example MIGRATION_STATUS_CANCELLING, MIGRATION_STATUS_CANCELLED, etc. > > Signed-off-by: Zhang Chen I think you're right; Reviewed-by: Dr. David Alan Gilbert however, did you

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-19 Thread Leonardo Bras Soares Passos
On Thu, Jan 13, 2022 at 10:06 AM Daniel P. Berrangé wrote: > > On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote: > > For CONFIG_LINUX, implement the new zero copy flag and the optional callback > > io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY > > feature is

Re: [PATCH v5 28/31] block.c: assert BQL lock held in bdrv_co_invalidate_cache

2022-01-19 Thread Hanna Reitz
On 19.01.22 16:57, Hanna Reitz wrote: On 23.12.21 18:11, Hanna Reitz wrote: On 20.12.21 13:20, Emanuele Giuseppe Esposito wrote: On 17/12/2021 17:38, Emanuele Giuseppe Esposito wrote: On 17/12/2021 12:04, Hanna Reitz wrote: On 24.11.21 07:44, Emanuele Giuseppe Esposito wrote:

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-19 Thread Leonardo Bras Soares Passos
Hello Daniel, On Thu, Jan 13, 2022 at 7:42 AM Daniel P. Berrangé wrote: > > On Thu, Jan 13, 2022 at 06:34:12PM +0800, Peter Xu wrote: > > On Thu, Jan 13, 2022 at 10:06:14AM +, Daniel P. Berrangé wrote: > > > On Thu, Jan 13, 2022 at 02:48:15PM +0800, Peter Xu wrote: > > > > On Thu, Jan 06,

Re: [PATCH 2/2] tests: Refresh lcitool submodule

2022-01-19 Thread Daniel P . Berrangé
On Mon, Jan 10, 2022 at 01:46:38PM +0100, Philippe Mathieu-Daudé wrote: > Refresh lcitool submodule and the generated files by running: > > $ make lcitool-refresh > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/alpine.docker| 3 ++- >

Re: [PATCH 0/2] tests: Refresh lcitool submodule

2022-01-19 Thread Philippe Mathieu-Daudé via
ping? (the testing/next queue this patch was depending on is now merged). On 1/10/22 13:46, Philippe Mathieu-Daudé wrote: > Refresh lcitool to latest. > > Based on Alex's testing/next > Based-on: <20220105135009.1584676-1-alex.ben...@linaro.org> > > Philippe Mathieu-Daudé (2): > MAINTAINERS:

Re: [PATCH 1/2] MAINTAINERS: Cover lcitool submodule with build test / automation

2022-01-19 Thread Daniel P . Berrangé
On Mon, Jan 10, 2022 at 01:46:37PM +0100, Philippe Mathieu-Daudé wrote: > lcitool is used by build test / automation, we want maintainers > to get notified if the submodule is updated. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 2/2] tests: Refresh lcitool submodule

2022-01-19 Thread Philippe Mathieu-Daudé via
On 1/19/22 18:33, Daniel P. Berrangé wrote: > On Mon, Jan 10, 2022 at 01:46:38PM +0100, Philippe Mathieu-Daudé wrote: >> Refresh lcitool submodule and the generated files by running: >> >> $ make lcitool-refresh >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>

[PATCH 1/3] meson: Don't force use of libgcrypt-config

2022-01-19 Thread Andrea Bolognani
libgcrypt 1.9.0 (released in 2021-01) ships with a proper pkg-config file, which Meson's libgcrypt detection code can use if available. Passing 'config-tool' as 'method' when calling dependency(), however, forces Meson to ignore the pkg-config file and always use libgcrypt-config instead.

Re: [RFC PATCH v3 1/3] hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR

2022-01-19 Thread Philippe Mathieu-Daudé via
Hi Peter, Can you take this single patch via your arm tree? Thanks, Phil. On 12/15/21 19:24, Philippe Mathieu-Daudé wrote: > Quoting Peter Maydell: > > "These MEMTX_* aren't from the memory transaction > API functions; they're just being used by gicd_readl() and > friends as a way to

[PATCH 3/3] docs: Don't recommend passing 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
Meson will do the right thing by default. Signed-off-by: Andrea Bolognani --- docs/devel/build-system.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst index 431caba7aa..fcdc0cd187 100644 --- a/docs/devel/build-system.rst +++

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-19 Thread Leonardo Bras Soares Passos
On Thu, Jan 13, 2022 at 9:12 AM Peter Xu wrote: > > On Thu, Jan 13, 2022 at 10:42:39AM +, Daniel P. Berrangé wrote: > > On Thu, Jan 13, 2022 at 06:34:12PM +0800, Peter Xu wrote: > > > On Thu, Jan 13, 2022 at 10:06:14AM +, Daniel P. Berrangé wrote: > > > > On Thu, Jan 13, 2022 at

Re: [PATCH] configure: Use -mlittle-endian instead of -mlittle for ppc64

2022-01-19 Thread Philippe Mathieu-Daudé via
On 1/19/22 12:13, Paolo Bonzini wrote: > On 1/19/22 10:56, mreza...@redhat.com wrote: >> From: Miroslav Rezanina >> >> GCC options -mlittle and -mlittle-endian are equivalent on ppc64 >> architecture. However, clang supports only -mlittle-endian option. >> >> Use longer form in configure to

Re: [PATCH] drop libxml2 checks since libxml is not actually used (for parallels)

2022-01-19 Thread Stefan Hajnoczi
On Wed, Jan 19, 2022 at 12:04:23PM +0300, Michael Tokarev wrote: > [This is a trivial patch, but due to the number of files it touches > I'm not using qemu-trivial@ route.] > > For a long time, we assumed that libxml2 is neecessary for parallels > block format support (block/parallels*). However,

Re: [PATCH 1/3] qsd: Add pre-init argument parsing pass

2022-01-19 Thread Kevin Wolf
Am 19.01.2022 um 14:44 hat Hanna Reitz geschrieben: > On 19.01.22 13:58, Markus Armbruster wrote: > > Hanna Reitz writes: > > > > > We want to add a --daemonize argument to QSD's command line. > > Why? > > OK, s/we/I/.  I find it useful, because without such an option, I need to > have whoever

[PATCH 0/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
See [1] for recent discussion about libgcrypt specifically, which the first patch is about. After writing that one, I realized that there is no point in explicitly passing 'method' to dependency() because Meson will do the right thing by default - hence the next two patches. [1]

[PATCH RESEND v2] qapi/block: Cosmetic change in BlockExportType schema

2022-01-19 Thread Philippe Mathieu-Daudé via
From: Philippe Mathieu-Daudé Fix long line introduced in commit bb01ea73110 ("qapi/block: Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER"). Suggested-by: Markus Armbruster Acked-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- Trying another git option to see even if

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-19 Thread Leonardo Bras Soares Passos
Hello Peter, On Thu, Jan 13, 2022 at 3:48 AM Peter Xu wrote: > > On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote: > > @@ -558,15 +575,26 @@ static ssize_t qio_channel_socket_writev(QIOChannel > > *ioc, > > memcpy(CMSG_DATA(cmsg), fds, fdsize); > > } > > > > +if

[PATCH 2/3] meson: Don't pass 'method' to dependency()

2022-01-19 Thread Andrea Bolognani
Meson will do the right thing by default. Signed-off-by: Andrea Bolognani --- meson.build | 74 - tcg/meson.build | 2 +- 2 files changed, 31 insertions(+), 45 deletions(-) diff --git a/meson.build b/meson.build index bc17ba67fd..b807ad9fbb

Re: [PATCH v7 2/5] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-01-19 Thread Leonardo Bras Soares Passos
On Thu, Jan 13, 2022 at 7:34 AM Peter Xu wrote: > > On Thu, Jan 13, 2022 at 10:06:14AM +, Daniel P. Berrangé wrote: > > On Thu, Jan 13, 2022 at 02:48:15PM +0800, Peter Xu wrote: > > > On Thu, Jan 06, 2022 at 07:13:39PM -0300, Leonardo Bras wrote: > > > > @@ -558,15 +575,26 @@ static ssize_t

[PATCH RESEND] qapi/block: Cosmetic change in BlockExportType schema

2022-01-19 Thread Philippe Mathieu-Daudé via
Fix long line introduced in commit bb01ea73110 ("qapi/block: Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER"). Suggested-by: Markus Armbruster Acked-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- Trying another git option to see even if my email From: is "Philippe

Re: [RFC 05/10] vdpa-dev: implement the realize interface

2022-01-19 Thread Stefan Hajnoczi
On Mon, Jan 17, 2022 at 12:34:50PM +, Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Thursday, January 6, 2022 7:34 PM > > To: Longpeng (Mike, Cloud Infrastructure Service

Re: [PATCH RFC 06/15] migration: Move temp page setup and cleanup into separate functions

2022-01-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Temp pages will need to grow if we want to have multiple channels for > postcopy, > because each channel will need its own temp page to cache huge page data. > > Before doing that, cleanup the related code. No functional change intended. > > Since at it,

Re: [PATCH RFC 05/15] migration: Simplify unqueue_page()

2022-01-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This patch simplifies unqueue_page() on both sides of it (itself, and caller). > > Firstly, due to the fact that right after unqueue_page() returned true, we'll > definitely send a huge page (see ram_save_huge_page() call - it will _never_ > exit before

Re: [PATCH v8 18/23] hw/intc: Add RISC-V AIA APLIC device emulation

2022-01-19 Thread Frank Chang
On Wed, Jan 19, 2022 at 11:27 PM Anup Patel wrote: > From: Anup Patel > > The RISC-V AIA (Advanced Interrupt Architecture) defines a new > interrupt controller for wired interrupts called APLIC (Advanced > Platform Level Interrupt Controller). The APLIC is capabable of > forwarding wired

[PATCH v8 23/23] hw/riscv: virt: Increase maximum number of allowed CPUs

2022-01-19 Thread Anup Patel
From: Anup Patel To facilitate software development of RISC-V systems with large number of HARTs, we increase the maximum number of allowed CPUs to 512 (2^9). We also add a detailed source level comments about limit defines which impact the physical address space utilization. Signed-off-by:

[PATCH v8 22/23] docs/system: riscv: Document AIA options for virt machine

2022-01-19 Thread Anup Patel
From: Anup Patel We have two new machine options "aia" and "aia-guests" available for the RISC-V virt machine so let's document these options. Signed-off-by: Anup Patel Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Reviewed-by: Frank Chang --- docs/system/riscv/virt.rst | 16

[PATCH v8 17/23] target/riscv: Allow users to force enable AIA CSRs in HART

2022-01-19 Thread Anup Patel
From: Anup Patel We add "x-aia" command-line option for RISC-V HART using which allows users to force enable CPU AIA CSRs without changing the interrupt controller available in RISC-V machine. Signed-off-by: Anup Patel Signed-off-by: Anup Patel Reviewed-by: Alistair Francis Reviewed-by:

[PATCH v8 19/23] hw/riscv: virt: Add optional AIA APLIC support to virt machine

2022-01-19 Thread Anup Patel
From: Anup Patel We extend virt machine to emulate AIA APLIC devices only when "aia=aplic" parameter is passed along with machine name in QEMU command-line. When "aia=none" or not specified then we fallback to original PLIC device emulation. Signed-off-by: Anup Patel Signed-off-by: Anup Patel

Re: [PULL v2 00/31] testing/next and other misc fixes

2022-01-19 Thread Peter Maydell
On Tue, 18 Jan 2022 at 19:00, Alex Bennée wrote: > > The following changes since commit 6621441db50d5bae7e34dbd04bf3c57a27a71b32: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-20220115' > into staging (2022-01-16 20:12:23 +) > > are available in the Git repository

  1   2   3   >