Re: [PATCH v2 0/9] ppc: nested KVM HV for spapr virtual hypervisor

2022-02-17 Thread Cédric Le Goater
On 2/16/22 11:25, Nicholas Piggin wrote: This should account for AFAIKS all comments, except maybe some about naming. Changes since v1: - Per-CPU spapr nested state moved to SpaprCpuState from PowerPCCPU. - address_space_map ops are used, small rearrangement to make any given access region

Re: [PATCH v7 0/3] spapr: nvdimm: Introduce spapr-nvdimm device

2022-02-17 Thread Cédric Le Goater
On 2/4/22 09:15, Shivaprasad G Bhat wrote: If the device backend is not persistent memory for the nvdimm, there is need for explicit IO flushes to ensure persistence. On SPAPR, the issue is addressed by adding a new hcall to request for an explicit flush from the guest when the backend is not

Re: [PATCH v2 00/27] target/ppc: SPR registration cleanups

2022-02-17 Thread Cédric Le Goater
On 2/16/22 17:23, Fabiano Rosas wrote: The goal of this series is to do some untangling of SPR registration code in cpu_init.c and prepare for moving the CPU initialization into separate files for each CPU family. After this series we'll have only cpu-specific SPR code in cpu_init.c, i.e. code

Re: [PATCH v5 05/15] hw/nvme: Add support for SR-IOV

2022-02-17 Thread Klaus Jensen
On Feb 17 18:44, Lukasz Maniak wrote: > This patch implements initial support for Single Root I/O Virtualization > on an NVMe device. > > Essentially, it allows to define the maximum number of virtual functions > supported by the NVMe controller via sriov_max_vfs parameter. > > Passing a

Re: [PATCH v5 15/15] hw/nvme: Update the initalization place for the AER queue

2022-02-17 Thread Klaus Jensen
On Feb 17 18:45, Lukasz Maniak wrote: > From: Łukasz Gieryk > > This patch updates the initialization place for the AER queue, so it’s > initialized once, at controller initialization, and not every time > controller is enabled. > > While the original version works for a non-SR-IOV device, as

[PATCH v3] migration/rdma: set the REUSEADDR option for destination

2022-02-17 Thread Jack Wang
We hit following error during testing RDMA transport: in case of migration error, mgmt daemon pick one migration port, incoming rdma:[::]:8089: RDMA ERROR: Error: could not rdma_bind_addr Then try another -incoming rdma:[::]:8103, sometime it worked, sometimes need another try with other ports

[PATCH v2] hw: riscv: opentitan: fixup SPI addresses

2022-02-17 Thread Alistair Francis
From: Wilfred Mallawa This patch updates the SPI_DEVICE, SPI_HOST0, SPI_HOST1 base addresses. Also adds these as unimplemented devices. The address references can be found [1]. [1]

Re: [PATCH v2 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-17 Thread Ani Sinha
On Mon, Feb 14, 2022 at 6:21 PM Igor Mammedov wrote: > > On Mon, 7 Feb 2022 17:01:28 +0530 > Ani Sinha wrote: > > > With the current smbios table assignment code, we can have only 512 DIMM > > slots > it's a bit confusing, since it's not DIMM slots in QEMU sense (we do not > expose > DIMM

Re: [PATCH v2 00/15] target/arm: Implement LVA, LPA, LPA2 features

2022-02-17 Thread Richard Henderson
On 2/18/22 04:37, Alex Bennée wrote: Peter Maydell writes: On Thu, 10 Feb 2022 at 04:04, Richard Henderson wrote: Changes for v2: * Introduce FIELD_SEX64, instead of open-coding w/ sextract64. * Set TCR_EL1 more completely for user-only. * Continue to bound tsz within

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-17 Thread Jag Raman
> On Feb 17, 2022, at 7:09 AM, Peter Maydell wrote: > > On Thu, 17 Feb 2022 at 07:56, Jagannathan Raman wrote: >> >> The compiler path that cmake gets from meson is corrupted. It results in >> the following error: >> | -- The C compiler identification is unknown >> | CMake Error at

Re: [PATCH] migration: NULL transport_data after freeing

2022-02-17 Thread Peter Xu
On Thu, Feb 17, 2022 at 06:04:07PM +0100, Hanna Reitz wrote: > migration_incoming_state_destroy() NULLs all objects it frees after they > are freed, presumably so that a subsequent call to the same function > will not free them again, unless new objects have been created in the > meantime. > >

Re: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-17 Thread Richard Henderson
On 2/17/22 04:18, Philippe Mathieu-Daudé wrote: On 16/2/22 17:42, Akihiko Odaki wrote: On 2022/02/17 0:08, Philippe Mathieu-Daudé wrote: On 16/2/22 11:19, Richard Henderson wrote: These should have been supplied by libgcc.a, which we're supposed to be linking against. Something is wrong with

Re: [PATCH] configure: Support empty prefixes

2022-02-17 Thread Paolo Bonzini
On 2/17/22 19:42, Joshua Seaton wrote: At least as of v5 (before the meson build), empty `--prefix` values were supported; this seems to have fallen out along the way. This change reintroduces support. What is the usecase exactly? QEMU supports relocatable installation so if you want you can

[PATCH v6 4/4] tests/tcg/s390x: changed to using .insn for tests requiring z15

2022-02-17 Thread David Miller
Signed-off-by: David Miller --- tests/tcg/s390x/mie3-compl.c | 21 +++-- tests/tcg/s390x/mie3-mvcrl.c | 2 +- tests/tcg/s390x/mie3-sel.c | 6 +++--- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/tests/tcg/s390x/mie3-compl.c b/tests/tcg/s390x/mie3-compl.c

[PATCH v6 3/4] tests/tcg/s390x: Tests for Miscellaneous-Instruction-Extensions Facility 3

2022-02-17 Thread David Miller
tests/tcg/s390x/mie3-compl.c: [N]*K instructions tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction tests/tcg/s390x/mie3-sel.c: SELECT instruction Signed-off-by: David Miller --- tests/tcg/s390x/Makefile.target | 5 ++- tests/tcg/s390x/mie3-compl.c| 55 +

[PATCH v6 1/4] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-17 Thread David Miller
resolves: https://gitlab.com/qemu-project/qemu/-/issues/737 implements: AND WITH COMPLEMENT (NCRK, NCGRK) NAND (NNRK, NNGRK) NOT EXCLUSIVE OR (NXRK, NXGRK) NOR (NORK, NOGRK) OR WITH COMPLEMENT(OCRK, OCGRK) SELECT(SELR, SELGR) SELECT

[PATCH v6 2/4] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z15 GA1

2022-02-17 Thread David Miller
TCG implements everything we need to run basic z15 OS+software Signed-off-by: David Miller --- hw/s390x/s390-virtio-ccw.c | 3 +++ target/s390x/cpu_models.c | 6 +++--- target/s390x/gen-features.c | 7 +-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git

[PATCH v6 0/4] s390x: Add partial z15 support and tests

2022-02-17 Thread David Miller
Add partial support for s390x z15 ga1 and specific tests for mie3 v5 -> v6: * Swap operands for sel* instructions * Use .insn in tests for z15 arch instructions v4 -> v5: * Readd missing tests/tcg/s390x/mie3-*.c to patch v3 -> v4: * Change popcnt encoding RRE -> RRF_c * Remove redundant code

[PATCH] virtio/virtio-balloon: Prefer Object* over void* parameter

2022-02-17 Thread Bernhard Beschow
*opaque is an alias to *obj. Using the ladder makes the code consistent with with other devices, e.g. accel/kvm/kvm-all and accel/tcg/tcg-all. It also makes the cast more typesafe. Signed-off-by: Bernhard Beschow --- hw/virtio/virtio-balloon.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 1/2] hw/vfio/pci-quirks: Resolve redundant property getters

2022-02-17 Thread Bernhard Beschow
The QOM API already provides getters for uint64 and uint32 values, so reuse them. Signed-off-by: Bernhard Beschow --- hw/vfio/pci-quirks.c | 34 +- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index

[PATCH 0/2] Resolve some redundant property accessors

2022-02-17 Thread Bernhard Beschow
The QOM API already provides appropriate accessors, so reuse them. Testing done: :$ make check Ok: 569 Expected Fail: 0 Fail: 0 Unexpected Pass:0 Skipped:178 Timeout:0 Bernhard Beschow (2): hw/vfio/pci-quirks:

[PATCH 2/2] hw/riscv/sifive_u: Resolve redundant property accessors

2022-02-17 Thread Bernhard Beschow
The QOM API already provides accessors for uint32 values, so reuse them. Signed-off-by: Bernhard Beschow --- hw/riscv/sifive_u.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 7fbc7dea42..747eb4ee89

Re: [PATCH v12 2/5] target/ppc: make power8-pmu.c CONFIG_TCG only

2022-02-17 Thread Richard Henderson
On 2/16/22 21:10, Daniel Henrique Barboza wrote: static void init_tcg_pmu_power8(CPUPPCState *env) { -#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) +#if defined(CONFIG_TCG) /* Init PMU overflow timers */ if (!kvm_enabled()) { cpu_ppc_pmu_init(env); @@ -7872,10

Re: [PATCH v4 1/7] hw/mips/gt64xxx_pci: Fix PCI IRQ levels to be preserved during migration

2022-02-17 Thread Bernhard Beschow
Am 17. Februar 2022 10:19:18 UTC schrieb Bernhard Beschow : >Based on commit e735b55a8c11dd455e31ccd4420e6c9485191d0c: > > piix_pci: eliminate PIIX3State::pci_irq_levels > > PIIX3State::pci_irq_levels are redundant which is already tracked by > PCIBus layer. So eliminate them. > >The IRQ levels

Re: [PATCH 3/4] hw/openrisc/openrisc_sim; Add support for loading a decice tree

2022-02-17 Thread Stafford Horne
On Thu, Feb 17, 2022 at 06:18:58PM +, Peter Maydell wrote: > On Thu, 10 Feb 2022 at 06:46, Stafford Horne wrote: > > > > Using the device tree means that qemu can now directly tell > > the kernel what hardware is configured rather than use having > > to maintain and update a separate device

Re: [PATCH v2 1/2] Mark remaining global TypeInfo instances as const

2022-02-17 Thread Bernhard Beschow
Am 17. Januar 2022 14:58:04 UTC schrieb Bernhard Beschow : >More than 1k of TypeInfo instances are already marked as const. Mark the >remaining ones, too. > >This commit was created with: > git grep -z -l 'static TypeInfo' -- '*.c' | \ > xargs -0 sed -i 's/static TypeInfo/static const TypeInfo/'

[PATCH] configure: Support empty prefixes

2022-02-17 Thread Joshua Seaton
At least as of v5 (before the meson build), empty `--prefix` values were supported; this seems to have fallen out along the way. This change reintroduces support. Tested locally with empty and non-empty values of `--prefix`. Signed-off-by: Joshua Seaton --- configure | 33

I have a Question? Can you build a version with German and English and Spain and France and Russia and Chinese Language Pack and Handbook Installation Guide in PDF and Paper book with all Function in

2022-02-17 Thread Anon Anonymous
I have a Question? Can you build a version with German and English and Spain and France and Russia and Chinese Language Pack and Handbook Installation Guide in PDF and Paper book with all Function in Linux, Unix and Windows? A Book with configure Raspberry PI Emulation, Android Emulation,

A Virtual Bios in Qemu with GUI by Boot QEMU with SHORTCUT

2022-02-17 Thread Anon Anonymous
Hello can you build a Virtual Bios with Hardware Simulation Emulation and change Hardware? CPU Option = CPU x86/x64/SPARC/ARM/ARM64/ANDROID/IOS/MAC CPU Standard Config Name = Original CPU in HArdware or Simulation Emulation All INTEL CELERON, CENTRINO, ATOM, PENTIUM (MMX) 1234, i3,i5,i7,i9 ,

Re: [PATCH v2 4/4] hw/openrisc/openrisc_sim: Add support for initrd loading

2022-02-17 Thread Stafford Horne
On Thu, Feb 17, 2022 at 06:04:32PM +, Peter Maydell wrote: > On Thu, 10 Feb 2022 at 13:13, Stafford Horne wrote: > > > > The initrd passed via the command line is loaded into memory. It's > > location and size is then added to the device tree so the kernel knows > > where to find it. > > > >

Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-17 Thread John Snow
On Mon, Feb 14, 2022 at 1:48 PM Liav Albani wrote: > > Hello BALATON, > > Thank you for helping keeping this patch noticeable to everyone :) > > I tried to reach out to John via a private email last Saturday (two days > ago) so I don't "spam" the mailing list for no good reason. > It might be

Re: [PATCH] ppc/spapr: Advertise StoreEOI for POWER10 compat guests

2022-02-17 Thread Daniel Henrique Barboza
On 2/17/22 10:23, Cédric Le Goater wrote: On 2/17/22 12:28, Daniel Henrique Barboza wrote: On 2/14/22 11:11, Cédric Le Goater wrote: When an interrupt has been handled, the OS notifies the interrupt controller with a EOI sequence. On a POWER9 and POWER10 systems using the XIVE interrupt

Re: [PATCH v2] ide: Increment BB in-flight counter for TRIM BH

2022-02-17 Thread John Snow
On Tue, Feb 15, 2022 at 12:14 PM Hanna Reitz wrote: > > Ping > > (I can take it too, if you’d like, John, but you’re listed as the only > maintainer for hw/ide, so... Just say the word, though!) > Sorry, I sent you a mail off-list at the time where I said you were free to take it whenever you

Re: [PATCH v4 01/12] mm/shmem: Introduce F_SEAL_INACCESSIBLE

2022-02-17 Thread Andy Lutomirski
On Thu, Feb 17, 2022, at 5:06 AM, Chao Peng wrote: > On Fri, Feb 11, 2022 at 03:33:35PM -0800, Andy Lutomirski wrote: >> On 1/18/22 05:21, Chao Peng wrote: >> > From: "Kirill A. Shutemov" >> > >> > Introduce a new seal F_SEAL_INACCESSIBLE indicating the content of >> > the file is inaccessible

Re: [PATCH v5 03/16] tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directives

2022-02-17 Thread Peter Maydell
On Mon, 14 Feb 2022 at 18:56, Philippe Mathieu-Daudé wrote: > > Since we already use -Wno-unknown-pragmas, we can also use > -Wno-ignored-pragmas. This silences hundred of warnings using > clang 13 on macOS Monterey: > > [409/771] Compiling C object >

Re: qemu crash 100% CPU with Ubuntu10.04 guest (solved)

2022-02-17 Thread Andrea Bolognani
On Thu, Feb 17, 2022 at 12:07:15PM +1100, Ben Smith wrote: > Hi All, > > I'm cross-posting this from Reddit qemu_kvm, in case it helps in some > way. I know my setup is ancient and unique; let me know if you would > like more info. > > Symptoms: > 1. Ubuntu10.04 32-bit guest locks up randomly

Re: [PATCH v5 02/16] configure: Allow passing extra Objective C compiler flags

2022-02-17 Thread Peter Maydell
On Mon, 14 Feb 2022 at 18:56, Philippe Mathieu-Daudé wrote: > > We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment > variables, or via configure --extra-cflags / --extra-cxxflags / > --extra-ldflags options. Provide similar behavior for Objective C: > use existing flags from

Re: [PATCH v5 01/16] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-17 Thread Peter Maydell
On Mon, 14 Feb 2022 at 18:56, Philippe Mathieu-Daudé wrote: > > From: Akihiko Odaki > > Signed-off-by: Akihiko Odaki > Reviewed-by: Christian Schoenebeck > Reviewed-by: Philippe Mathieu-Daudé > Message-Id: <20220213021215.1974-1-akihiko.od...@gmail.com> > Signed-off-by: Philippe Mathieu-Daudé

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-17 Thread Thomas Huth
On 28/01/2022 16.47, Stefan Hajnoczi wrote: Dear QEMU, KVM, and rust-vmm communities, QEMU will apply for Google Summer of Code 2022 (https://summerofcode.withgoogle.com/) and has been accepted into Outreachy May-August 2022 (https://www.outreachy.org/). You can now submit internship project

Re: [PATCH 3/4] hw/openrisc/openrisc_sim; Add support for loading a decice tree

2022-02-17 Thread Peter Maydell
On Thu, 10 Feb 2022 at 06:46, Stafford Horne wrote: > > Using the device tree means that qemu can now directly tell > the kernel what hardware is configured rather than use having > to maintain and update a separate device tree file. > > This patch adds device tree support for the OpenRISC

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-17 Thread Paolo Bonzini
On 2/14/22 15:01, Stefan Hajnoczi wrote: Thanks for this idea. As a stretch goal we could add implementing the packed virtqueue layout in Linux vhost, QEMU's libvhost-user, and/or QEMU's virtio qtest code. Why not have a separate project for packed virtqueue layout? Paolo

Re: [PATCH v2 4/4] hw/openrisc/openrisc_sim: Add support for initrd loading

2022-02-17 Thread Peter Maydell
On Thu, 10 Feb 2022 at 13:13, Stafford Horne wrote: > > The initrd passed via the command line is loaded into memory. It's > location and size is then added to the device tree so the kernel knows > where to find it. > > Signed-off-by: Stafford Horne > --- > hw/openrisc/openrisc_sim.c | 32

[PATCH v5 14/15] docs: Add documentation for SR-IOV and Virtualization Enhancements

2022-02-17 Thread Lukasz Maniak
Signed-off-by: Lukasz Maniak --- docs/system/devices/nvme.rst | 82 1 file changed, 82 insertions(+) diff --git a/docs/system/devices/nvme.rst b/docs/system/devices/nvme.rst index b5acb2a9c19..aba253304e4 100644 --- a/docs/system/devices/nvme.rst +++

[RFC PATCH] virtio-net: Unlimit tx queue size if peer is vdpa

2022-02-17 Thread Eugenio Pérez
The code used to limit the maximum size of tx queue for others backends than vhost_user since the introduction of configurable tx queue size in 9b02e1618cf2 ("virtio-net: enable configurable tx queue size"). As vhost_user, vhost_vdpa devices should deal with memory region crosses already, so

[PATCH v5 09/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk The NVMe device defines two properties: max_ioqpairs, msix_qsize. Having them as constants is problematic for SR-IOV support. SR-IOV introduces virtual resources (queues, interrupts) that can be assigned to PF and its dependent VFs. Each device, following a reset, should

[PATCH v5 13/15] hw/nvme: Add support for the Virtualization Management command

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk With the new command one can: - assign flexible resources (queues, interrupts) to primary and secondary controllers, - toggle the online/offline state of given controller. Signed-off-by: Łukasz Gieryk --- hw/nvme/ctrl.c | 257

[PATCH v5 04/15] pcie: Add 1.2 version token for the Power Management Capability

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk Signed-off-by: Łukasz Gieryk --- include/hw/pci/pci_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/pci/pci_regs.h b/include/hw/pci/pci_regs.h index 77ba64b9314..a5901409622 100644 --- a/include/hw/pci/pci_regs.h +++ b/include/hw/pci/pci_regs.h @@ -4,5

[PATCH v5 15/15] hw/nvme: Update the initalization place for the AER queue

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk This patch updates the initialization place for the AER queue, so it’s initialized once, at controller initialization, and not every time controller is enabled. While the original version works for a non-SR-IOV device, as it’s hard to interact with the controller if it’s not

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-17 Thread Paolo Bonzini
On 1/28/22 16:47, Stefan Hajnoczi wrote: Dear QEMU, KVM, and rust-vmm communities, QEMU will apply for Google Summer of Code 2022 (https://summerofcode.withgoogle.com/) and has been accepted into Outreachy May-August 2022 (https://www.outreachy.org/). You can now submit internship project ideas

[PATCH v5 07/15] hw/nvme: Add support for Secondary Controller List

2022-02-17 Thread Lukasz Maniak
Introduce handling for Secondary Controller List (Identify command with CNS value of 15h). Secondary controller ids are unique in the subsystem, hence they are reserved by it upon initialization of the primary controller to the number of sriov_max_vfs. ID reservation requires the addition of an

[PATCH v5 11/15] hw/nvme: Calculate BAR attributes in a function

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk An NVMe device with SR-IOV capability calculates the BAR size differently for PF and VF, so it makes sense to extract the common code to a separate function. Signed-off-by: Łukasz Gieryk Reviewed-by: Klaus Jensen --- hw/nvme/ctrl.c | 45

[PATCH v5 02/15] pcie: Add some SR/IOV API documentation in docs/pcie_sriov.txt

2022-02-17 Thread Lukasz Maniak
From: Knut Omang Add a small intro + minimal documentation for how to implement SR/IOV support for an emulated device. Signed-off-by: Knut Omang --- docs/pcie_sriov.txt | 115 1 file changed, 115 insertions(+) create mode 100644

[PATCH v5 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk With four new properties: - sriov_v{i,q}_flexible, - sriov_max_v{i,q}_per_vf, one can configure the number of available flexible resources, as well as the limits. The primary and secondary controller capability structures are initialized accordingly. Since the number of

[PATCH v5 03/15] pcie: Add a helper to the SR/IOV API

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk Convenience function for retrieving the PCIDevice object of the N-th VF. Signed-off-by: Łukasz Gieryk Reviewed-by: Knut Omang --- hw/pci/pcie_sriov.c | 10 +- include/hw/pci/pcie_sriov.h | 6 ++ 2 files changed, 15 insertions(+), 1 deletion(-) diff

[PATCH v5 08/15] hw/nvme: Implement the Function Level Reset

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk This patch implements the Function Level Reset, a feature currently not implemented for the Nvme device, while listed as a mandatory ("shall") in the 1.4 spec. The implementation reuses FLR-related building blocks defined for the pci-bridge module, and follows the same

[PATCH v5 10/15] hw/nvme: Remove reg_size variable and update BAR0 size calculation

2022-02-17 Thread Lukasz Maniak
From: Łukasz Gieryk The n->reg_size parameter unnecessarily splits the BAR0 size calculation in two phases; removed to simplify the code. With all the calculations done in one place, it seems the pow2ceil, applied originally to reg_size, is unnecessary. The rounding should happen as the last

[PATCH v5 05/15] hw/nvme: Add support for SR-IOV

2022-02-17 Thread Lukasz Maniak
This patch implements initial support for Single Root I/O Virtualization on an NVMe device. Essentially, it allows to define the maximum number of virtual functions supported by the NVMe controller via sriov_max_vfs parameter. Passing a non-zero value to sriov_max_vfs triggers reporting of

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 2:36 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 9:25 PM Akihiko Odaki wrote: >> >> On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki >> > wrote: >> >> >> >> On Fri, Feb

[PATCH v5 01/15] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2022-02-17 Thread Lukasz Maniak
From: Knut Omang This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and register/unregister SR/IOV Virtual Functions. Signed-off-by: Knut Omang --- hw/pci/meson.build | 1 + hw/pci/pci.c| 100 +--- hw/pci/pcie.c

[PATCH v5 06/15] hw/nvme: Add support for Primary Controller Capabilities

2022-02-17 Thread Lukasz Maniak
Implementation of Primary Controller Capabilities data structure (Identify command with CNS value of 14h). Currently, the command returns only ID of a primary controller. Handling of remaining fields are added in subsequent patches implementing virtualization enhancements. Signed-off-by: Lukasz

Re: [PATCH] ppc/spapr: Advertise StoreEOI for POWER10 compat guests

2022-02-17 Thread Cédric Le Goater
Unfortunately, this patch breaks migration under TCG because the XIVE source flag is not updated on the target side. KVM is not impacted because the emulated sources are not used. This needs to be addressed in a v2. That said, even without this patch, TCG migration is broken. some CPUs on the

[PATCH v5 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

2022-02-17 Thread Lukasz Maniak
Changes since v4: - Added hello world example for SR-IOV to the docs - Moved AER initialization from nvme_init_ctrl to nvme_init_state - Fixed division by zero issue in calculation of vqfrt and vifrt capabilities Knut Omang (2): pcie: Add support for Single Root I/O Virtualization (SR/IOV)

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Marc-André Lureau
Hi On Thu, Feb 17, 2022 at 9:25 PM Akihiko Odaki wrote: > On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau > wrote: > > > > Hi > > > > On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki > wrote: > >> > >> On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau > >> wrote: > >> > > >> > Hi > >> > > >>

Re: [PATCH v2 00/15] target/arm: Implement LVA, LPA, LPA2 features

2022-02-17 Thread Alex Bennée
Peter Maydell writes: > On Thu, 10 Feb 2022 at 04:04, Richard Henderson > wrote: >> >> Changes for v2: >> * Introduce FIELD_SEX64, instead of open-coding w/ sextract64. >> * Set TCR_EL1 more completely for user-only. >> * Continue to bound tsz within aa64_va_parameters; >> provide

[PULL 10/12] virtiofsd: Create new file using O_TMPFILE and set security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal If guest and host policies can't work with each other, then guest security context (selinux label) needs to be set into an xattr. Say remap guest security.selinux xattr to trusted.virtiofs.security.selinux. That means setting "fscreate" is not going to help as that's ony

[PULL 12/12] virtiofsd: Add basic support for FUSE_SYNCFS request

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Greg Kurz Honor the expected behavior of syncfs() to synchronously flush all data and metadata to disk on linux systems. If virtiofsd is started with '-o announce_submounts', the client is expected to send a FUSE_SYNCFS request for each individual submount. In this case, we just create a

[PULL 09/12] virtiofsd: Create new file with security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal This patch adds support for creating new file with security context as sent by client. It basically takes three paths. - If no security context enabled, then it continues to create files without security context. - If security context is enabled and but security.selinux has

[PULL 11/12] virtiofsd: Add an option to enable/disable security label

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Provide an option "-o security_label/no_security_label" to enable/disable security label functionality. By default these are turned off. If enabled, server will indicate to client that it is capable of handling one security label during file creation. Typically this is

[PULL 08/12] virtiofsd: Add helpers to work with /proc/self/task/tid/attr/fscreate

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Soon we will be able to create and also set security context on the file atomically using /proc/self/task/tid/attr/fscreate knob. If this knob is available on the system, first set the knob with the desired context and then create the file. It will be created with the context

[PULL 04/12] virtiofsd: Parse extended "struct fuse_init_in"

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Add some code to parse extended "struct fuse_init_in". And use a local variable "flag" to represent 64 bit flags. This will make it easier to add more features without having to worry about two 32bit flags (->flags and ->flags2) in "fuse_struct_in". Signed-off-by: Vivek Goyal

Re: [PATCH] migration: NULL transport_data after freeing

2022-02-17 Thread Dr. David Alan Gilbert
* Hanna Reitz (hre...@redhat.com) wrote: > migration_incoming_state_destroy() NULLs all objects it frees after they > are freed, presumably so that a subsequent call to the same function > will not free them again, unless new objects have been created in the > meantime. > > transport_data is the

[PULL 07/12] virtiofsd: Move core file creation code in separate function

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Move core file creation bits in a separate function. Soon this is going to get more complex as file creation need to set security context also. And there will be multiple modes of file creation in next patch. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal

[PULL 06/12] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Add capability to enable and parse security context as sent by client and put into fuse_req. Filesystems now can get security context from request and set it on files during creation. Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-6-vgo...@redhat.com>

[PULL 05/12] virtiofsd: Extend size of fuse_conn_info->capable and ->want fields

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal ->capable keeps track of what capabilities kernel supports and ->wants keep track of what capabilities filesytem wants. Right now these fields are 32bit in size. But now fuse has run out of bits and capabilities can now have bit number which are higher than 31. That means 32

Re: [Virtio-fs] [PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert
to staging (2022-02-16 > 09:57:11 +) > > are available in the Git repository at: > > https://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20220217 > > for you to fetch changes up to e138ec4ac86ea71d10ecd032edc433290776a5f2: > > virtiofsd: Add basic suppor

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 2:07 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki wrote: >> >> On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau >> wrote: >> > >> > Hi >> > >> > On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki >> > wrote: >> >> >> >> On Thu, Feb

[PULL 03/12] linux-headers: Update headers to v5.17-rc1

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Update headers to 5.17-rc1. I need latest fuse changes. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Vivek Goyal Message-Id: <20220208204813.682906-3-vgo...@redhat.com> Signed-off-by: Dr. David Alan Gilbert --- include/standard-headers/asm-x86/kvm_para.h | 1 +

[PULL 02/12] virtiofsd: Fix breakage due to fuse_init_in size change

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Vivek Goyal Kernel version 5.17 has increased the size of "struct fuse_init_in" struct. Previously this struct was 16 bytes and now it has been extended to 64 bytes in size. Once qemu headers are updated to latest, it will expect to receive 64 byte size struct (for protocol version major

[PULL 01/12] virtiofsd: Do not support blocking flock

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: Sebastian Hasler With the current implementation, blocking flock can lead to deadlock. Thus, it's better to return EOPNOTSUPP if a user attempts to perform a blocking flock request. Signed-off-by: Sebastian Hasler Message-Id:

[PULL 00/12] virtiofs queue

2022-02-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit c13b8e9973635f34f3ce4356af27a311c993729c: Merge remote-tracking branch 'remotes/alistair/tags/pull-riscv-to-apply-20220216' into staging (2022-02-16 09:57:11 +) are available in the Git repository at:

[PULL v2 0/5] 9p queue (previous 2022-02-10)

2022-02-17 Thread Christian Schoenebeck
/pull-9p-20220217 for you to fetch changes up to e64e27d5cb103b7764f1a05b6eda7e7fedd517c5: 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread (2022-02-17 16:57:58 +0100) 9pfs: fixes and cleanup * Fifth patch

[PULL v2 1/5] tests/9pfs: use g_autofree where possible

2022-02-17 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck Reviewed-by: Greg Kurz Message-Id: --- tests/qtest/virtio-9p-test.c | 90 +++- 1 file changed, 27 insertions(+), 63 deletions(-) diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c index

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

2022-02-17 Thread Eugenio Perez Martin
On Tue, Feb 8, 2022 at 4:58 AM Jason Wang wrote: > > > 在 2022/2/1 上午2:58, Eugenio Perez Martin 写道: > > On Sun, Jan 30, 2022 at 5:03 AM Jason Wang wrote: > >> > >> 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > >>> First half of the buffers forwarding part, preparing vhost-vdpa > >>> callbacks to SVQ to

[PULL v2 3/5] tests/9pfs: Fix leak of local_test_path

2022-02-17 Thread Christian Schoenebeck
From: Greg Kurz local_test_path is allocated in virtio_9p_create_local_test_dir() to hold the path of the temporary directory. It should be freed in virtio_9p_remove_local_test_dir() when the temporary directory is removed. Clarify the lifecycle of local_test_path while here. Based-on:

Re: [PATCH v2 9/9] spapr: implement nested-hv capability for the virtual hypervisor

2022-02-17 Thread Cédric Le Goater
On 2/16/22 13:30, Nicholas Piggin wrote: Excerpts from Nicholas Piggin's message of February 16, 2022 9:38 pm: Excerpts from Cédric Le Goater's message of February 16, 2022 8:52 pm: On 2/16/22 11:25, Nicholas Piggin wrote: This implements the Nested KVM HV hcall API for spapr under TCG. The

[PULL v2 4/5] tests/9pfs: Use g_autofree and g_autoptr where possible

2022-02-17 Thread Christian Schoenebeck
From: Greg Kurz It is recommended to use g_autofree or g_autoptr as it reduces the odds of introducing memory leaks in future changes. Signed-off-by: Greg Kurz Message-Id: <20220201151508.190035-3-gr...@kaod.org> Reviewed-by: Christian Schoenebeck Signed-off-by: Christian Schoenebeck ---

Re: [PATCH] tcg: Remove dh_alias indirection for dh_typecode

2022-02-17 Thread Keith Packard via
Richard Henderson writes: > Reported-by: Keith Packard > Signed-off-by: Richard Henderson Looks good to me, and it passes my very simple test when run on s390. Tested-by: Keith Packard -- -keith signature.asc Description: PGP signature

[PULL v2 2/5] tests/9pfs: fix mkdir() being called twice

2022-02-17 Thread Christian Schoenebeck
The 9p test cases use mkdtemp() to create a temporary directory for running the 'local' 9p tests with real files/dirs. Unlike mktemp() which only generates a unique file name, mkdtemp() also creates the directory, therefore the subsequent mkdir() was wrong and caused errors on some systems.

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Marc-André Lureau
Hi On Thu, Feb 17, 2022 at 8:39 PM Akihiko Odaki wrote: > On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau > wrote: > > > > Hi > > > > On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki > wrote: > >> > >> On Thu, Feb 17, 2022 at 8:58 PM wrote: > >> > > >> > From: Marc-André Lureau > >> > > >> >

[PATCH] migration: NULL transport_data after freeing

2022-02-17 Thread Hanna Reitz
migration_incoming_state_destroy() NULLs all objects it frees after they are freed, presumably so that a subsequent call to the same function will not free them again, unless new objects have been created in the meantime. transport_data is the exception, and it shows exactly this problem: When an

Re: [PATCH v5 11/20] block/mirror.c: use of job helpers in drivers to avoid TOC/TOU

2022-02-17 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 09:35:04AM -0500, Emanuele Giuseppe Esposito wrote: > Once job lock is used and aiocontext is removed, mirror has > to perform job operations under the same critical section, > using the helpers prepared in previous commit. > > Note: at this stage, job_{lock/unlock} and

[PATCH v1] aio-posix: fix build failure io_uring 2.2

2022-02-17 Thread Haiyue Wang
The io_uring fixed "Don't truncate addr fields to 32-bit on 32-bit": https://git.kernel.dk/cgit/liburing/commit/?id=d84c29b19ed0b13619cff40141bb1fc3615b This leads to build failure: ../util/fdmon-io_uring.c: In function ‘add_poll_remove_sqe’: ../util/fdmon-io_uring.c:182:36: error: passing

[PULL v2 5/5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-17 Thread Christian Schoenebeck
From: Vitaly Chikunov `struct dirent' returned from readdir(3) could be shorter (or longer) than `sizeof(struct dirent)', thus memcpy of sizeof length will overread into unallocated page causing SIGSEGV. Example stack trace: #0 0x559ebeed v9fs_co_readdir_many

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Akihiko Odaki
On Fri, Feb 18, 2022 at 1:12 AM Marc-André Lureau wrote: > > Hi > > On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki wrote: >> >> On Thu, Feb 17, 2022 at 8:58 PM wrote: >> > >> > From: Marc-André Lureau >> > >> > Hi, >> > >> > In the thread "[PATCH 0/6] ui/dbus: Share one listener for a console",

Re: [PATCH v5 1/3] s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

2022-02-17 Thread David Miller
Will submit patch later today, thanks

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-17 Thread Stefan Hajnoczi
On Thu, 17 Feb 2022 at 14:12, Stefano Garzarella wrote: > > On Mon, Feb 14, 2022 at 02:01:52PM +, Stefan Hajnoczi wrote: > >On Mon, 14 Feb 2022 at 07:11, Jason Wang wrote: > >> > >> On Fri, Jan 28, 2022 at 11:47 PM Stefan Hajnoczi > >> wrote: > >> > > >> > Dear QEMU, KVM, and rust-vmm

Re: [PATCH v5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-17 Thread Christian Schoenebeck
On Mittwoch, 16. Februar 2022 19:18:21 CET Vitaly Chikunov wrote: > `struct dirent' returned from readdir(3) could be shorter (or longer) > than `sizeof(struct dirent)', thus memcpy of sizeof length will overread > into unallocated page causing SIGSEGV. Example stack trace: > > #0

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-17 Thread Stefan Hajnoczi
On Thu, 17 Feb 2022 at 07:08, Alice Frosi wrote: > > On Fri, Jan 28, 2022 at 6:04 PM Stefan Hajnoczi wrote: > > > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy

Re: qemu crash 100% CPU with Ubuntu10.04 guest (solved)

2022-02-17 Thread Kashyap Chamarthy
On Thu, Feb 17, 2022 at 12:07:15PM +1100, Ben Smith wrote: > Hi All, Hi, > I'm cross-posting this from Reddit qemu_kvm, in case it helps in some > way. I know my setup is ancient and unique; let me know if you would > like more info. > > Symptoms: > 1. Ubuntu10.04 32-bit guest locks up randomly

Re: [PATCH v2 00/12] GL & D-Bus display related fixes

2022-02-17 Thread Marc-André Lureau
Hi On Thu, Feb 17, 2022 at 5:09 PM Akihiko Odaki wrote: > On Thu, Feb 17, 2022 at 8:58 PM wrote: > > > > From: Marc-André Lureau > > > > Hi, > > > > In the thread "[PATCH 0/6] ui/dbus: Share one listener for a console", > Akihiko > > Odaki reported a number of issues with the GL and D-Bus

  1   2   3   >