Re: [PATCH v1 1/1] aspeed/hace: Support AST1030 HACE

2022-05-02 Thread Cédric Le Goater
On 5/3/22 04:27, Steven Lee wrote: Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE engine. Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater Thanks C. --- hw/misc/aspeed_hace.c | 20 include/hw/misc/aspeed_hace.h | 2 ++ 2

Re: [PATCH v2 1/2] hw/core: Sync uboot_image.h from U-Boot v2022.01

2022-05-02 Thread Bin Meng
On Thu, Apr 28, 2022 at 4:43 PM Bin Meng wrote: > > On Fri, Apr 22, 2022 at 11:00 AM Bin Meng wrote: > > > > +Richard > > > > On Wed, Apr 20, 2022 at 4:16 PM Bin Meng wrote: > > > > > > On Tue, Apr 12, 2022 at 9:11 AM Bin Meng wrote: > > > > > > > > On Thu, Mar 24, 2022 at 9:48 PM Bin Meng

Re: [PATCH 0/9] 9pfs: Add 9pfs support for Windows host

2022-05-02 Thread Bin Meng
On Tue, Apr 26, 2022 at 9:41 AM Bin Meng wrote: > > +Mark > > > On Mon, Apr 25, 2022 at 10:27 PM Bin Meng wrote: > > > > At present there is no Windows support for 9p file system. > > This series adds initial Windows support for 9p file system. > > > > 'local' file system backend driver is

[PATCH v1 0/1] aspeed/hace: Support AST1030 HACE

2022-05-02 Thread Steven Lee
Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE engine. Please help to review. Thanks, Steven Based-on: 20220426021120.28255-3-steven_...@aspeedtech.com ([v6,2/3] aspeed/hace: Support AST2600 HACE) Steven Lee (1): aspeed/hace: Support AST1030 HACE

[PATCH v1 1/1] aspeed/hace: Support AST1030 HACE

2022-05-02 Thread Steven Lee
Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE engine. Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 20 include/hw/misc/aspeed_hace.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/hw/misc/aspeed_hace.c

Re: [PULL 06/11] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-05-02 Thread Peter Xu
On Mon, May 02, 2022 at 09:12:53PM -0300, Leonardo Bras Soares Passos wrote: > Hello Peter, > > On Mon, May 2, 2022 at 8:52 PM Peter Xu wrote: > > > > Leo, > > > > On Fri, Apr 29, 2022 at 11:40:44PM -0300, Leonardo Bras Soares Passos wrote: > > > Does anyone else have any further suggestions, or

Re: [PATCH] hw/dma: Add Xilinx AXI CDMA

2022-05-02 Thread Frank Chang
On Mon, May 2, 2022 at 6:29 PM Edgar E. Iglesias wrote: > On Thu, Apr 28, 2022 at 5:43 PM wrote: > >> From: Frank Chang >> >> Add Xilinx AXI CDMA model, which follows >> AXI Central Direct Memory Access v4.1 spec: >> https://docs.xilinx.com/v/u/en-US/pg034-axi-cdma >> >> Supports both Simple

Re: [PULL 06/11] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-05-02 Thread Leonardo Bras Soares Passos
Hello Peter, On Mon, May 2, 2022 at 8:52 PM Peter Xu wrote: > > Leo, > > On Fri, Apr 29, 2022 at 11:40:44PM -0300, Leonardo Bras Soares Passos wrote: > > Does anyone else have any further suggestions, or know how this kind of > > issue > > is generally solved in qemu? > > I've no solid idea why

Re: [PATCH] hw/openrisc: use right OMPIC size variable

2022-05-02 Thread Richard Henderson
On 5/2/22 16:28, Jason A. Donenfeld wrote: This appears to be a copy and paste error. The UART size was used instead of the much smaller OMPIC size. Signed-off-by: Jason A. Donenfeld --- hw/openrisc/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard

Re: [PATCH] target/openrisc: implement shutdown and reset helpers

2022-05-02 Thread Richard Henderson
On 5/2/22 15:52, Jason A. Donenfeld wrote: OpenRISC defines various nop instructions in or1k as meaning shutdown or reset. Implement these in TCG. This has been tested with Linux and confirmed to work. No, OpenRISC does not define various nop instructions, etc. OpenRISC defines a Power

Re: [PULL 06/11] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-05-02 Thread Peter Xu
Leo, On Fri, Apr 29, 2022 at 11:40:44PM -0300, Leonardo Bras Soares Passos wrote: > Does anyone else have any further suggestions, or know how this kind of issue > is generally solved in qemu? I've no solid idea why it can't see MSG_ZEROCOPY defined in the specific environment, but when I was

[PATCH] hw/openrisc: use right OMPIC size variable

2022-05-02 Thread Jason A. Donenfeld
This appears to be a copy and paste error. The UART size was used instead of the much smaller OMPIC size. Signed-off-by: Jason A. Donenfeld --- hw/openrisc/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c

[PATCH] hw/openrisc: support 4 serial ports in or1ksim

2022-05-02 Thread Jason A. Donenfeld
The 8250 serial controller supports 4 serial ports, so wire them all up, so that we can have more than one basic I/O channel. Cc: Stafford Horne Signed-off-by: Jason A. Donenfeld --- hw/openrisc/openrisc_sim.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff

[PATCH] target/openrisc: implement shutdown and reset helpers

2022-05-02 Thread Jason A. Donenfeld
OpenRISC defines various nop instructions in or1k as meaning shutdown or reset. Implement these in TCG. This has been tested with Linux and confirmed to work. Cc: Stafford Horne Signed-off-by: Jason A. Donenfeld --- target/openrisc/helper.h | 1 + target/openrisc/sys_helper.c | 18

Re: [PATCH v2 20/21] target/ppc: Add unused msr bits FIELDs

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: Add FIELDs macros for msr bits that had an unused msr_* before. Signed-off-by: Víctor Colombo Acked-by: Richard Henderson r~

Re: [PATCH v2 17/21] target/ppc: Remove msr_fe0 and msr_fe1 macros

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_fe0 and msr_fe1 macros hide the usage of env->msr, which is a bad behavior. Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard

Re: [PATCH v2 18/21] target/ppc: Remove msr_ts macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_ts macro hides the usage of env->msr, which is a bad behavior. Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 12/21] target/ppc: Remove msr_fp macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_fp macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 13/21] target/ppc: Remove msr_me macro

2022-05-02 Thread Richard Henderson
On 5/2/22 14:38, Richard Henderson wrote: On 5/2/22 07:39, Víctor Colombo wrote: msr_me macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo

Re: [PATCH v2 10/21] target/ppc: Remove msr_me macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_me macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 09/21] target/ppc: Remove msr_pow macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_pow macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 06/21] target/ppc: Remove msr_ile macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_ile macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 04/21] target/ppc: Remove msr_le macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_le macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 07/21] target/ppc: Remove msr_ee macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_ee macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 08/21] target/ppc: Remove msr_ce macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_ce macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 05/21] target/ppc: Remove msr_ds macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_ds macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo Reviewed-by: Richard Henderson r~

Re: [PATCH v2 03/21] target/ppc: Remove msr_pr macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_pr macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_PR and use FIELD_EX64

Re: [PATCH v2 19/21] target/ppc: Remove msr_hv macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_hv macro hides the usage of env->msr, which is a bad behavior. Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_HV and use FIELD_EX64

Re: [PATCH v2 16/21] target/ppc: Remove msr_ep macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: -if (unlikely((value >> MSR_EP) & 1) != msr_ep) { -env->excp_prefix = ((value >> MSR_EP) & 1) * 0xFFF0; +if (unlikely(!(value & env->msr & R_MSR_EP_MASK))) { Needs xor. +env->excp_prefix = FIELD_EX64(env->msr, MSR, EP) *

Re: [PATCH v2 15/21] target/ppc: Remove msr_dr macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: if (!(value & env->msr & R_MSR_IR_MASK) || -((value >> MSR_DR) & 1) != msr_dr) { +!(value & env->msr & R_MSR_DR_MASK)) { Xor, but then this becomes (value ^ env->msr) & (R_MSR_IR_MASK | R_MSR_DR_MASK) r~

Re: [PATCH v2 14/21] target/ppc: Remove msr_ir macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: -if (((value >> MSR_IR) & 1) != msr_ir || +if (!(value & env->msr & R_MSR_IR_MASK) || Likewise needs xor. r~

Re: [PATCH v2 11/21] target/ppc: Remove msr_gs macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: -((value >> MSR_GS) & 1) != msr_gs) { +!(value & env->msr & R_MSR_GS_MASK)) { This isn't right. I think you wanted (value ^ env->msr) & R_MSR_GS_MASK r~

Re: [PATCH v2 13/21] target/ppc: Remove msr_me macro

2022-05-02 Thread Richard Henderson
On 5/2/22 07:39, Víctor Colombo wrote: msr_me macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_CM and use FIELD_EX64

Re: [PATCH v3 3/3] nbd/server: Allow MULTI_CONN for shared writable exports

2022-05-02 Thread Eric Blake
On Fri, Apr 29, 2022 at 02:49:35PM +0200, Kevin Wolf wrote: ... > > Or a multi-pathed connection to network storage, where one QEMU > > process accesses the network device, but those accesses may > > round-robin which server they reach, and where any caching at an > > individual server may be

Re: [PATCH v5 7/9] s390x/pci: enable adapter event notification for interpreted devices

2022-05-02 Thread Matthew Rosato
On 5/2/22 7:30 AM, Pierre Morel wrote: On 5/2/22 11:19, Niklas Schnelle wrote: On Mon, 2022-05-02 at 09:48 +0200, Pierre Morel wrote: On 4/22/22 14:10, Matthew Rosato wrote: On 4/22/22 5:39 AM, Pierre Morel wrote: On 4/4/22 20:17, Matthew Rosato wrote: Use the associated kvm ioctl

Re: [PATCH 0/7] qapi: Primarily whitespace tweaks

2022-05-02 Thread Markus Armbruster
Andrea Bolognani writes: > On Mon, May 02, 2022 at 02:43:52PM +0200, Markus Armbruster wrote: >> PATCH 1-5 queued, because no-brainers :) > > Thanks! > > How do you want me to handle respinning 6/7 and 7/7? Send out the > entire series again with those two patches tweaked, wait for your > pull

Re: [PATCH 6/7] qapi: Drop unnecessary horizontal spacing in comments

2022-05-02 Thread Markus Armbruster
Andrea Bolognani writes: > On Mon, May 02, 2022 at 10:50:07AM +0200, Markus Armbruster wrote: >> Andrea Bolognani writes: >> > -# @writeback: true if writeback mode is enabled >> > -# @direct: true if the host page cache is bypassed (O_DIRECT) >> > -# @no-flush:true if flush requests

[PATCH] tests/tcg/s390x: Use a different PCRel32 notation in branch-relative-long.c

2022-05-02 Thread Ilya Leoshkevich
Binutils >=2.37 and Clang do not accept (. - 0x1) PCRel32 constants. While this looks like a bug that needs fixing, use a different notation (-0x1) as a workaround. Reported-by: Thomas Huth Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/branch-relative-long.c | 4 ++-- 1

Re: [PATCH v6 00/13] s390x/tcg: Implement Vector-Enhancements Facility 2

2022-05-02 Thread David Miller
There was also the patch that had them as .insn in the other series of emails. On Mon, May 2, 2022 at 11:52 AM David Hildenbrand wrote: > > On 02.05.22 09:20, Thomas Huth wrote: > > On 28/04/2022 11.46, David Hildenbrand wrote: > >> Implement Vector-Enhancements Facility 2 for s390x > >> > >>

Re: [PATCH] hw/gpio/aspeed_gpio: Fix QOM pin property

2022-05-02 Thread Peter Delevoryas
> On May 2, 2022, at 8:09 AM, Cédric Le Goater wrote: > > On 5/2/22 10:08, Peter Delevoryas wrote: >> I was setting gpioV4-7 to "1110" using the QOM pin property handler and >> noticed that lowering gpioV7 was inadvertently lowering gpioV4-6 too. >> (qemu) qom-set /machine/soc/gpio gpioV4 true

Re: [PATCH v6 00/13] s390x/tcg: Implement Vector-Enhancements Facility 2

2022-05-02 Thread David Hildenbrand
On 02.05.22 09:20, Thomas Huth wrote: > On 28/04/2022 11.46, David Hildenbrand wrote: >> Implement Vector-Enhancements Facility 2 for s390x >> >> resolves: https://gitlab.com/qemu-project/qemu/-/issues/738 >> >> implements: >> VECTOR LOAD ELEMENTS REVERSED (VLER) >> VECTOR

Re: [PATCH] hw/gpio/aspeed_gpio: Fix QOM pin property

2022-05-02 Thread Cédric Le Goater
On 5/2/22 10:08, Peter Delevoryas wrote: I was setting gpioV4-7 to "1110" using the QOM pin property handler and noticed that lowering gpioV7 was inadvertently lowering gpioV4-6 too. (qemu) qom-set /machine/soc/gpio gpioV4 true (qemu) qom-set /machine/soc/gpio gpioV5 true (qemu)

[PATCH v2 21/21] target/ppc: Change MSR_* to follow POWER ISA numbering convention

2022-05-02 Thread Víctor Colombo
Today we have the issue where MSR_* values are the 'inverted order' bit numbers from what the ISA specifies. e.g. MSR_LE is bit 63 but is defined as 0 in QEMU. Add a macro to be used to convert from QEMU order to ISA order. This solution requires less changes than to use the already defined

[PATCH v2 19/21] target/ppc: Remove msr_hv macro

2022-05-02 Thread Víctor Colombo
msr_hv macro hides the usage of env->msr, which is a bad behavior. Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_HV and use FIELD_EX64 instead. In this patch I'm having some

[PATCH v2 18/21] target/ppc: Remove msr_ts macro

2022-05-02 Thread Víctor Colombo
msr_ts macro hides the usage of env->msr, which is a bad behavior. Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_TS* and use FIELD_EX64 instead. Signed-off-by: Víctor Colombo

[PATCH v2 17/21] target/ppc: Remove msr_fe0 and msr_fe1 macros

2022-05-02 Thread Víctor Colombo
msr_fe0 and msr_fe1 macros hide the usage of env->msr, which is a bad behavior. Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_FE* and use FIELD_EX64 instead. As the bit

[PATCH v2 16/21] target/ppc: Remove msr_ep macro

2022-05-02 Thread Víctor Colombo
msr_ep macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Also, this macro was called in a specific place where it was being used 'kinda' like a mask: (value >> MSR_EP) & 1) != msr_ep. The setup to use

[PATCH v2 14/21] target/ppc: Remove msr_ir macro

2022-05-02 Thread Víctor Colombo
msr_ir macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_IR and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 15/21] target/ppc: Remove msr_dr macro

2022-05-02 Thread Víctor Colombo
msr_dr macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_DR and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

Re: [PATCH v2 00/21] target/ppc: Remove hidden usages of *env

2022-05-02 Thread Cédric Le Goater
On 5/2/22 16:39, Víctor Colombo wrote: By running the grep command `git grep -nr 'define \(fpscr\|msr\)_[a-z0-9]\+\>'` we can find multiple macros that use `env->fpscr` and `env->msr` but doesn't take *env as a parameter. Richard Henderson said [1] that these macros hiding the usage of *env

[PATCH v2 11/21] target/ppc: Remove msr_gs macro

2022-05-02 Thread Víctor Colombo
msr_gs macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_GS and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 13/21] target/ppc: Remove msr_me macro

2022-05-02 Thread Víctor Colombo
msr_me macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_CM and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 10/21] target/ppc: Remove msr_me macro

2022-05-02 Thread Víctor Colombo
msr_me macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_ME and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 12/21] target/ppc: Remove msr_fp macro

2022-05-02 Thread Víctor Colombo
msr_fp macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_FP and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 06/21] target/ppc: Remove msr_ile macro

2022-05-02 Thread Víctor Colombo
msr_ile macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_ILE and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 09/21] target/ppc: Remove msr_pow macro

2022-05-02 Thread Víctor Colombo
msr_pow macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_POW and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

Re: [Patch 1/3] hw/vfio/pci: fix vfio_pci_hot_reset_result trace point

2022-05-02 Thread Eric Auger
Hi Alex, On 5/2/22 16:35, Alex Williamson wrote: > On Mon, 2 May 2022 02:42:21 -0700 > Yi Liu wrote: > >> From: Eric Auger >> >> Properly output the errno string. > More explanation please, why is it broken and how does this fix it? > Thanks, "%m" format specifier is not interpreted by the

[PATCH v2 04/21] target/ppc: Remove msr_le macro

2022-05-02 Thread Víctor Colombo
msr_le macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_LE and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 07/21] target/ppc: Remove msr_ee macro

2022-05-02 Thread Víctor Colombo
msr_ee macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_EE and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 08/21] target/ppc: Remove msr_ce macro

2022-05-02 Thread Víctor Colombo
msr_ce macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_CE and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 20/21] target/ppc: Add unused msr bits FIELDs

2022-05-02 Thread Víctor Colombo
Add FIELDs macros for msr bits that had an unused msr_* before. Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_* and use FIELD macro now. Signed-off-by: Víctor Colombo --- target/ppc/cpu.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/target/ppc/cpu.h

[PATCH v2 03/21] target/ppc: Remove msr_pr macro

2022-05-02 Thread Víctor Colombo
msr_pr macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_PR and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 05/21] target/ppc: Remove msr_ds macro

2022-05-02 Thread Víctor Colombo
msr_ds macro hides the usage of env->msr, which is a bad behavior Substitute it with FIELD_EX64 calls that explicitly use env->msr as a parameter. Suggested-by: Richard Henderson Signed-off-by: Víctor Colombo --- v2: Remove M_MSR_DS and use FIELD_EX64 instead Signed-off-by: Víctor Colombo

[PATCH v2 02/21] target/ppc: Remove unused msr_* macros

2022-05-02 Thread Víctor Colombo
Some msr_* macros are not used anywhere. Remove them as part of the work to remove all hidden usage of *env. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Víctor Colombo --- target/ppc/cpu.h | 21 - 1 file changed, 21 deletions(-) diff

Re: [PATCH 0/7] qapi: Primarily whitespace tweaks

2022-05-02 Thread Andrea Bolognani
On Mon, May 02, 2022 at 02:43:52PM +0200, Markus Armbruster wrote: > PATCH 1-5 queued, because no-brainers :) Thanks! How do you want me to handle respinning 6/7 and 7/7? Send out the entire series again with those two patches tweaked, wait for your pull request to make it into the tree,

[PATCH v2 01/21] target/ppc: Remove fpscr_* macros from cpu.h

2022-05-02 Thread Víctor Colombo
fpscr_* defined macros are hiding the usage of *env behind them. Substitute the usage of these macros with `env->fpscr & FP_*` to make the code cleaner. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Víctor Colombo --- target/ppc/cpu.c| 2 +-

[PATCH v2 00/21] target/ppc: Remove hidden usages of *env

2022-05-02 Thread Víctor Colombo
By running the grep command `git grep -nr 'define \(fpscr\|msr\)_[a-z0-9]\+\>'` we can find multiple macros that use `env->fpscr` and `env->msr` but doesn't take *env as a parameter. Richard Henderson said [1] that these macros hiding the usage of *env "are evil". This patch series remove them

Re: [PATCH RFC 09/10] migration/dirtyrate: Expand dirty_bitmap to be tracked separately for devices

2022-05-02 Thread Joao Martins
On 5/2/22 13:54, Markus Armbruster wrote: > Joao Martins writes: > >> Expand dirtyrate measurer that is accessible via HMP calc_dirty_rate >> or QMP 'calc-dirty-rate' to receive a @scope argument. The scope >> then restricts the dirty tracking to be done at devices only, >> while neither

Re: [PATCH v3 0/3] Misc AC97 clean ups

2022-05-02 Thread BALATON Zoltan
On Sat, 23 Apr 2022, BALATON Zoltan wrote: During trying to implement via-ac97 I did some small clean ups to ac97 which is in this series. The via-ac97 is not working yet so that's not included but these unrelated clean ups could be merged now. v3: Fixed misalignments and drop spaces before

Re: [Patch 1/3] hw/vfio/pci: fix vfio_pci_hot_reset_result trace point

2022-05-02 Thread Alex Williamson
On Mon, 2 May 2022 02:42:21 -0700 Yi Liu wrote: > From: Eric Auger > > Properly output the errno string. More explanation please, why is it broken and how does this fix it? Thanks, Alex > Signed-off-by: Eric Auger > Signed-off-by: Yi Liu > --- > hw/vfio/pci.c | 2 +- > 1 file changed,

Re: [PATCH 6/7] qapi: Drop unnecessary horizontal spacing in comments

2022-05-02 Thread Andrea Bolognani
On Mon, May 02, 2022 at 10:50:07AM +0200, Markus Armbruster wrote: > Andrea Bolognani writes: > > -# @writeback: true if writeback mode is enabled > > -# @direct: true if the host page cache is bypassed (O_DIRECT) > > -# @no-flush:true if flush requests are ignored for the device > >

Re: [PATCH] Meson: Make mremap() detecting works correctly

2022-05-02 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-05-02 Thread Andrea Bolognani
On Mon, May 02, 2022 at 01:46:23PM +0200, Markus Armbruster wrote: > Andrea Bolognani writes: > >> > The wire protocol would still retain the unappealing name, but at > >> > least client libraries could hide the uglyness from users. > >> > >> At the price of mild inconsistency between the library

Re: [RFC PATCH] target/s390x: Check storage keys in the TPROT instruction

2022-05-02 Thread Janis Schoetterl-Glausch
On 5/2/22 12:17, Janis Schoetterl-Glausch wrote: > On 5/2/22 10:25, Thomas Huth wrote: >> TPROT allows to specify an access key that should be used for checking >> with the storage key of the destination page, to see whether an access >> is allowed or not. Honor this storage key checking now in

Re: [RFC PATCH] target/s390x: Check storage keys in the TPROT instruction

2022-05-02 Thread Janis Schoetterl-Glausch
On 5/2/22 10:25, Thomas Huth wrote: > TPROT allows to specify an access key that should be used for checking > with the storage key of the destination page, to see whether an access > is allowed or not. Honor this storage key checking now in the emulated > TPROT instruction, too. > > Since we

Re: [PATCH] net/slirp: Use newer slirp_*_hostxfwd API

2022-05-02 Thread Breno Leitao
On 9/25/21 22:48, Nicholas Ngai wrote: libslirp provides a newer slirp_*_hostxfwd API meant for address-agnostic forwarding instead of the is_udp parameter which is limited to just TCP/UDP. Signed-off-by: Nicholas Ngai Reviewed-by: Samuel Thibault Tested-by: Breno Leitao

Re: [PULL 4/8] tests/tcg/s390x: Test BRASL and BRCL with large negative offsets

2022-05-02 Thread Thomas Huth
On 15/03/2022 12.20, Thomas Huth wrote: From: Ilya Leoshkevich Add a small test in order to prevent regressions. Signed-off-by: Ilya Leoshkevich Message-Id: <20220314104232.675863-4-...@linux.ibm.com> Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth

Re: [PATCH] mos6522: fix linking error when CONFIG_MOS6522 is not set

2022-05-02 Thread Murilo Opsfelder Araújo
Hi, Mark. Thanks for reviewing. Comments below. On 5/2/22 06:43, Mark Cave-Ayland wrote: On 30/04/2022 00:31, Murilo Opsfelder Araujo wrote: When CONFIG_MOS6522 is not set, building ppc64-softmmu target fails: /usr/bin/ld: libqemu-ppc64-softmmu.fa.p/monitor_misc.c.o:(.data+0x1158):

Re: [RFC PATCH v2 0/8] Removal of AioContext lock, bs->parents and ->children: new rwlock

2022-05-02 Thread Paolo Bonzini
On 5/2/22 10:02, Emanuele Giuseppe Esposito wrote: Are you saying rdlock isn't necessary in the main loop because nothing can take the wrlock while our code is executing in the main loop? Yes, that's the idea. If I am not mistaken (and I hope I am not), only the main loop currently modifies/is

[PATCH] Meson: Make mremap() detecting works correctly

2022-05-02 Thread Juan Quintela
Without this (at least in Fedora 35) it don't detect mremap() correctly. Signed-off-by: Juan Quintela --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1fe7d257ff..f96da78741 100644 --- a/meson.build +++ b/meson.build @@

Re: [PATCH RFC 09/10] migration/dirtyrate: Expand dirty_bitmap to be tracked separately for devices

2022-05-02 Thread Markus Armbruster
Joao Martins writes: > Expand dirtyrate measurer that is accessible via HMP calc_dirty_rate > or QMP 'calc-dirty-rate' to receive a @scope argument. The scope > then restricts the dirty tracking to be done at devices only, > while neither enabling or using the KVM (CPU) dirty tracker. > The

Re: [PATCH 0/7] qapi: Primarily whitespace tweaks

2022-05-02 Thread Markus Armbruster
PATCH 1-5 queued, because no-brainers :)

Re: [PATCH] qapi: Fix malformed "Since:" section tags

2022-05-02 Thread Markus Armbruster
Markus Armbruster writes: > "Since X.Y" is not recognized as a tagged section, and therefore not > formatted as such in generated documentation. Fix by adding the > required colon. > > Signed-off-by: Markus Armbruster Queued.

Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-05-02 Thread Markus Armbruster
Andrea Bolognani writes: > On Mon, May 02, 2022 at 09:21:36AM +0200, Markus Armbruster wrote: >> Andrea Bolognani writes: >> > The wire protocol would still retain the unappealing name, but at >> > least client libraries could hide the uglyness from users. >> >> At the price of mild

Re: [PATCH v5 7/9] s390x/pci: enable adapter event notification for interpreted devices

2022-05-02 Thread Pierre Morel
On 5/2/22 11:19, Niklas Schnelle wrote: On Mon, 2022-05-02 at 09:48 +0200, Pierre Morel wrote: On 4/22/22 14:10, Matthew Rosato wrote: On 4/22/22 5:39 AM, Pierre Morel wrote: On 4/4/22 20:17, Matthew Rosato wrote: Use the associated kvm ioctl operation to enable adapter event

[PATCH qemu v13 12/15] target/riscv: rvv: Add tail agnostic for vector reduction instructions

2022-05-02 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 20 1 file changed, 20 insertions(+) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index f67ec1f249..a319cda969 100644 ---

[PATCH qemu v13 14/15] target/riscv: rvv: Add tail agnostic for vector permutation instructions

2022-05-02 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 22 ++ target/riscv/vector_helper.c| 40 + 2 files changed, 62 insertions(+) diff --git

[PATCH qemu v13 11/15] target/riscv: rvv: Add tail agnostic for vector floating-point instructions

2022-05-02 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 15 + target/riscv/vector_helper.c| 440 +---

[PATCH qemu v13 06/15] target/riscv: rvv: Add tail agnostic for vx, vvm, vxm instructions

2022-05-02 Thread ~eopxd
From: eopXD `vmadc` and `vmsbc` produces a mask value, they always operate with a tail agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 29 +++ target/riscv/internals.h| 5 +-

[PATCH qemu v13 08/15] target/riscv: rvv: Add tail agnostic for vector integer comparison instructions

2022-05-02 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PATCH qemu v13 09/15] target/riscv: rvv: Add tail agnostic for vector integer merge and move instructions

2022-05-02 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 44 + target/riscv/vector_helper.c| 20 +++ 2 files changed, 64 insertions(+) diff --git

[PATCH qemu v13 15/15] target/riscv: rvv: Add option 'rvv_ta_all_1s' to enable optional tail agnostic behavior

2022-05-02 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple

[PATCH qemu v13 04/15] target/riscv: rvv: Add tail agnostic for vv instructions

2022-05-02 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple

[PATCH qemu v13 01/15] target/riscv: rvv: Prune redundant ESZ, DSZ parameter passed

2022-05-02 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 1132 +- 1 file changed, 565 insertions(+), 567 deletions(-)

[PATCH qemu v13 03/15] target/riscv: rvv: Early exit when vstart >= vl

2022-05-02 Thread ~eopxd
From: eopXD According to v-spec (section 5.4): When vstart ≥ vl, there are no body elements, and no elements are updated in any destination vector register group, including that no tail elements are updated with agnostic values. vmsbf.m, vmsif.m, vmsof.m, viota.m, vcompress instructions

[PATCH qemu v13 13/15] target/riscv: rvv: Add tail agnostic for vector mask instructions

2022-05-02 Thread ~eopxd
From: eopXD The tail elements in the destination mask register are updated under a tail-agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 6 + target/riscv/vector_helper.c| 30

[PATCH qemu v13 10/15] target/riscv: rvv: Add tail agnostic for vector fix-point arithmetic instructions

2022-05-02 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 220 ++- 1 file changed, 114 insertions(+), 106 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index

[PATCH qemu v13 02/15] target/riscv: rvv: Rename ambiguous esz

2022-05-02 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 76 ++-- 1 file changed, 38 insertions(+), 38 deletions(-)

[PATCH qemu v13 05/15] target/riscv: rvv: Add tail agnostic for vector load / store instructions

2022-05-02 Thread ~eopxd
From: eopXD Destination register of unit-stride mask load and store instructions are always written with a tail-agnostic policy. A vector segment load / store instruction may contain fractional lmul with nf * lmul > 1. The rest of the elements in the last register should be treated as tail

[PATCH qemu v13 07/15] target/riscv: rvv: Add tail agnostic for vector integer shift instructions

2022-05-02 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 11 +++ target/riscv/vector_helper.c| 11 +++ 2 files changed, 22 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

  1   2   >