Re: [RFC] hw/nvme: Use irqfd to send interrupts

2022-08-01 Thread Klaus Jensen
On Aug 2 12:03, Jinhao Fan wrote: > at 6:21 PM, Stefan Hajnoczi wrote: > > > What happens when the MSI-X vector is masked? > > > > I remember the VIRTIO code having masking support. I'm on my phone and > > can't check now, but I think it registers a temporary eventfd and buffers > > irqs

[PATCH 1/2] hw/arm/virt: Improve address assignment for highmem IO regions

2022-08-01 Thread Gavin Shan
There are 3 highmem IO regions as below. They can be disabled in two situations: (a) The specific region is disabled by user. (b) The specific region doesn't fit in the PA space. However, the base address and highest_gpa are still updated no matter if the region is enabled or disabled. It's

[PATCH 2/2] hw/arm/virt: Warn when high memory region is disabled

2022-08-01 Thread Gavin Shan
When one specific high memory region is disabled due to the PA limit, it'd better to warn user about that. The warning messages help to identify the cause in some cases. For example, PCIe device that has large MMIO bar, to be covered by PCIE_MMIO high memory region, won't work properly if

[PATCH 0/2] hw/arm/virt: Improve address assignment for highmem IO regions

2022-08-01 Thread Gavin Shan
There are 3 highmem IO regions on arm/virt machine. Their base addresses are determined dynamically. However, there are several issues I can see in current implementation: (1) The memory region's base address and highest_gpa are always updated no matter even if the memory region has been

Re: [RFC] hw/nvme: Use irqfd to send interrupts

2022-08-01 Thread Jinhao Fan
at 6:21 PM, Stefan Hajnoczi wrote: > What happens when the MSI-X vector is masked? > > I remember the VIRTIO code having masking support. I'm on my phone and can't > check now, but I think it registers a temporary eventfd and buffers irqs > while the vector is masked. Hi Stefan, While

Re: [PATCH] hw/nvme: Add helper functions for qid-db conversion

2022-08-01 Thread Jinhao Fan
at 4:07 PM, Jinhao Fan wrote: > With the introduction of shadow doorbell and ioeventfd, we need to do > frequent conversion between qid and its doorbell offset. The original > hard-coded calculation is confusing and error-prone. Add several helper > functions to do this task. > > Signed-off-by:

Re: [PULL 9/9] hw/i386: pass RNG seed via setup_data entry

2022-08-01 Thread Xiaoyao Li
On 7/22/2022 12:36 AM, Paolo Bonzini wrote: From: "Jason A. Donenfeld" Tiny machines optimized for fast boot time generally don't use EFI, which means a random seed has to be supplied some other way. For this purpose, Linux (≥5.20) supports passing a seed in the setup_data table with

[PATCH v5 2/3] job: introduce dump guest memory job

2022-08-01 Thread Hogan Wang via
There's no way to cancel the current executing dump process, lead to the virtual machine manager daemon((e.g. libvirtd) cannot restore the dump job after daemon restart. Introduce dump guest memory job type, and add an optional 'job-id' argument for dump-guest-memory QMP to make use of jobs

[PATCH v5 1/3] dump: support cancel dump process

2022-08-01 Thread Hogan Wang via
Break saving pages or dump iterate when dump job in cancel state, make sure dump process exits as soon as possible. Signed-off-by: Hogan Wang --- dump/dump.c | 23 +++ include/sysemu/dump.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/dump/dump.c

[PATCH v5 3/3] dump: use jobs framework for dump guest memory

2022-08-01 Thread Hogan Wang via
There's no way to cancel the current executing dump process, lead to the virtual machine manager daemon((e.g. libvirtd) cannot restore the dump job after daemon restart. When caller pass the 'job-id' argument, create a job for dump process. And then caller can use job-cancel QMP command to cancel

Re: [PATCH v3 08/11] target/openrisc: Enable MTTCG

2022-08-01 Thread Stafford Horne
On Fri, Jul 29, 2022 at 04:42:54PM -0700, Richard Henderson wrote: > On 7/29/22 16:01, Stafford Horne wrote: > > This patch enables multithread TCG for OpenRISC. Since the or1k shared > > syncrhonized timer can be updated from each vCPU via helpers we use a > > mutex to synchronize updates. > >

Re: [PULL 0/2] aspeed queue

2022-08-01 Thread Richard Henderson
/legoater/qemu/ tags/pull-aspeed-20220801 for you to fetch changes up to 398c01da9c8c8af5db0b2b4b4888c2bd27218230: aspeed/fby35: Fix owner of the BMC RAM memory region (2022-08-01 15:24:15 +0200) aspeed queue: * Fix ownership of RAM

Re: [PATCH v4 2/3] job: introduce dump guest memory job

2022-08-01 Thread Wangjing(Hogan)
> Hogan Wang writes: > > > There's no way to cancel the current executing dump process, lead to > > the virtual machine manager daemon((e.g. libvirtd) cannot restore the > > dump job after daemon restart. > > > > Introduce dump guest memory job type, and add an optional 'job-id' > > argument

[PATCH 1/1] vfio-user: update submodule to latest

2022-08-01 Thread Jagannathan Raman
Update libvfio-user submodule to the latest Signed-off-by: Jagannathan Raman --- subprojects/libvfio-user | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvfio-user b/subprojects/libvfio-user index 0b28d20557..1305f161b7 16 --- a/subprojects/libvfio-user

[PATCH 0/1] Update vfio-user module to the latest

2022-08-01 Thread Jagannathan Raman
Hi, This patch updates the libvfio-user submodule to the latest. Passed 'make check' & GitLab CI. Thank you! -- Jag Jagannathan Raman (1): vfio-user: update submodule to latest subprojects/libvfio-user | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1

[PATCH v3 0/1] monitor: Support specified vCPU registers

2022-08-01 Thread zhenwei pi
v2 -> v3: - Add more document in help info. - Use 'qemu_get_cpu()' to simplify code. v1 -> v2: - Typo fix in commit message. - Suggested by Darren, use '[-a|vcpu]' instead of '[-a] [vcpu]', becase only one of these may be specified at a time. v1: - Support specified vCPU registers for monitor

[PATCH v3 1/1] monitor: Support specified vCPU registers

2022-08-01 Thread zhenwei pi
Originally we have to get all the vCPU registers and parse the specified one. To improve the performance of this usage, allow user specified vCPU id to query registers. Run a VM with 16 vCPU, use bcc tool to track the latency of 'hmp_info_registers': 'info registers -a' uses about 3ms; 'info

Re: [PATCH v7 11/14] KVM: Register/unregister the guest private memory regions

2022-08-01 Thread Sean Christopherson
On Fri, Jul 29, 2022, Sean Christopherson wrote: > On Mon, Jul 25, 2022, Chao Peng wrote: > > On Thu, Jul 21, 2022 at 05:58:50PM +, Sean Christopherson wrote: > > > On Thu, Jul 21, 2022, Chao Peng wrote: > > > > On Thu, Jul 21, 2022 at 03:34:59PM +0800, Wei Wang wrote: > > > > > > > > > > >

[PULL 1/1] linux-user/riscv: Align signal frame to 16 bytes

2022-08-01 Thread Alistair Francis
From: Richard Henderson Follow the kernel's alignment, as we already noted. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1093 Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Message-Id: <20220729201942.30738-1-richard.hender...@linaro.org> Signed-off-by: Alistair

[PULL 0/1] riscv-to-apply queue

2022-08-01 Thread Alistair Francis
From: Alistair Francis The following changes since commit 0e0c2cf6de0bc6538840837c63b25817cd417347: Merge tag 'pull-target-arm-20220801' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-08-01 12:00:08 -0700) are available in the Git repository at: g

Re: [PATCH for-7.1?] linux-user/riscv: Align signal frame to 16 bytes

2022-08-01 Thread Alistair Francis
On Sat, Jul 30, 2022 at 6:19 AM Richard Henderson wrote: > > Follow the kernel's alignment, as we already noted. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1093 > Signed-off-by: Richard Henderson Thanks! Applied to riscv-to-apply.next Alistair > --- >

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-01 Thread Peter Delevoryas
On Mon, Aug 01, 2022 at 11:49:09AM +0930, Andrew Jeffery wrote: > > > On Sun, 31 Jul 2022, at 06:48, Cédric Le Goater wrote: > > On 7/29/22 19:30, Peter Delevoryas wrote: > >> Certainly we'd like to use IRQ's instead, but she ran into correctness > >> problems. Maybe we can investigate that

Re: [PULL 0/3] target-arm queue

2022-08-01 Thread Richard Henderson
-0700) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220801 for you to fetch changes up to 5265d24c981dfdda8d29b44f7e84a514da75eedc: target/arm: Move sve probe inside kvm >= 4.15 branch (2022-08-01 16:21:18 +0

[PATCH 1/2] linux-user: Introduce stubs for ELF AT_BASE_PLATFORM

2022-08-01 Thread Jiaxun Yang
AT_BASE_PLATFORM is a elf auxiliary vector pointing to a string to pass some architecture information. Signed-off-by: Jiaxun Yang --- linux-user/elfload.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/linux-user/elfload.c

[PATCH 2/2] linux-user: Set ELF_BASE_PLATFORM for MIPS

2022-08-01 Thread Jiaxun Yang
Match most appropriate base platform string based on insn_flags. Logic is aligned with arch/mips/kernel/cpu-probe.c in Linux kernel. Signed-off-by: Jiaxun Yang --- linux-user/elfload.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/linux-user/elfload.c

[PATCH 0/2] linux-user: AT_BASE_PLATFORM for MIPS

2022-08-01 Thread Jiaxun Yang
Hi all, This series properly filled AT_BASE_PLATFORM of MIPS. There is a checkpatch error about braces after if statement, I intentionally left it for style consistency. Thanks. - Jiaxun Jiaxun Yang (2): linux-user: Introduce stubs for ELF AT_BASE_PLATFORM linux-user: Set ELF_BASE_PLATFORM

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Michael S. Tsirkin
On Mon, Aug 01, 2022 at 08:48:41PM +0200, Eugenio Perez Martin wrote: > On Mon, Aug 1, 2022 at 8:34 PM Peter Maydell wrote: > > > > On Mon, 1 Aug 2022 at 19:31, Laurent Vivier wrote: > > > > > > On 01/08/2022 16:47, Eugenio Pérez wrote: > > > > File descriptor vdpa_device_fd is not free in the

Re: [PULL 0/7] Testing and wording fixes

2022-08-01 Thread Richard Henderson
On 8/1/22 08:54, Thomas Huth wrote: Hi! The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at:

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Eugenio Perez Martin
On Mon, Aug 1, 2022 at 8:34 PM Peter Maydell wrote: > > On Mon, 1 Aug 2022 at 19:31, Laurent Vivier wrote: > > > > On 01/08/2022 16:47, Eugenio Pérez wrote: > > > File descriptor vdpa_device_fd is not free in the case of returning > > > error from vhost_vdpa_get_features. Fixing it by making all

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Peter Maydell
On Mon, 1 Aug 2022 at 19:31, Laurent Vivier wrote: > > On 01/08/2022 16:47, Eugenio Pérez wrote: > > File descriptor vdpa_device_fd is not free in the case of returning > > error from vhost_vdpa_get_features. Fixing it by making all errors go to > > the same error path. > > > > Resolves: Coverity

Re: [PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Laurent Vivier
On 01/08/2022 16:47, Eugenio Pérez wrote: File descriptor vdpa_device_fd is not free in the case of returning error from vhost_vdpa_get_features. Fixing it by making all errors go to the same error path. Resolves: Coverity CID 1490785 Fixes: 8170ab3f43 ("vdpa: Extract get features part from

Re: [PATCH for-7.1] icount: Take iothread lock when running QEMU timers

2022-08-01 Thread Richard Henderson
On 8/1/22 09:45, Peter Maydell wrote: The function icount_prepare_for_run() is called with the iothread unlocked, but it can call icount_notify_aio_contexts() which will run qemu timer handlers. Those are supposed to be run only with the iothread lock held, so take the lock while we do that.

[PATCH v7 1/4] target/riscv: Add smstateen support

2022-08-01 Thread Mayuresh Chitale
Smstateen extension specifies a mechanism to close the potential covert channels that could cause security issues. This patch adds the CSRs defined in the specification and the corresponding predicates and read/write functions. Signed-off-by: Mayuresh Chitale --- target/riscv/cpu.h | 4

Re: [PULL] IPMI bug fixes

2022-08-01 Thread Richard Henderson
On 8/1/22 07:02, Corey Minyard wrote: Not a huge deal, but probably makes mainainers lives a little easier. Add a change to make Coverity happy. Corey Minyard (1): ipmi:smbus: Add a check around a memcpy

[PATCH v7 3/4] target/riscv: smstateen check for fcsr

2022-08-01 Thread Mayuresh Chitale
If smstateen is implemented and sstateen0.fcsr is clear then the floating point operations must return illegal instruction exception. Signed-off-by: Mayuresh Chitale --- target/riscv/csr.c| 23 + target/riscv/insn_trans/trans_rvf.c.inc | 40

[PATCH v7 0/4] RISC-V Smstateen support

2022-08-01 Thread Mayuresh Chitale
This series adds support for the Smstateen specification which provides a mechanism plug potential covert channels which are opened by extensions that add to processor state that may not get context-switched. Currently access to *envcfg registers and floating point(fcsr) is controlled via

[PATCH v7 4/4] target/riscv: smstateen knobs

2022-08-01 Thread Mayuresh Chitale
Add knobs to allow users to enable smstateen and also export it via the ISA extension string. Signed-off-by: Mayuresh Chitale --- target/riscv/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d4635c7df4..d8a0f4e700 100644 ---

[PATCH v7 2/4] target/riscv: smstateen check for h/senvcfg

2022-08-01 Thread Mayuresh Chitale
Accesses to henvcfg, henvcfgh and senvcfg are allowed only if corresponding bit in mstateen0/hstateen0 is enabled. Otherwise an illegal instruction trap is generated. Signed-off-by: Mayuresh Chitale --- roms/opensbi | 2 +- target/riscv/csr.c | 83

RE: Support for Gaisler multicore LEONx SoCs

2022-08-01 Thread Gregg Allison
Fabien, Fred, and Peter, Thank you all for the helpful information. Might AdaCore’s SMP Leon3/Leon4 fork be merged with the main branch of QEMU in the somewhat near term? Fabien, can I obtain the SMP Leon3/Leon4 fork from AdaCore directly? Gregg Allison From: Fabien Chouteau Sent:

[PULL 2/2] aspeed/fby35: Fix owner of the BMC RAM memory region

2022-08-01 Thread Cédric Le Goater
A MachineState object is used as a owner of the RAM region and this asserts in memory_region_init_ram() when QEMU is built with CONFIG_QOM_CAST_DEBUG : /* This will assert if owner is neither NULL nor a DeviceState. * We only want the owner here for the purposes of defining a *

[PATCH for-7.1] icount: Take iothread lock when running QEMU timers

2022-08-01 Thread Peter Maydell
The function icount_prepare_for_run() is called with the iothread unlocked, but it can call icount_notify_aio_contexts() which will run qemu timer handlers. Those are supposed to be run only with the iothread lock held, so take the lock while we do that. Since icount mode runs everything on a

Re: [RFC v5 00/11] Add support for zoned device

2022-08-01 Thread Stefan Hajnoczi
Hi Hannes, Damien, and Dmitry, This patch series introduces zoned_host_device for passing through host zoned storage devices. How can one host zoned storage device be split up for multiple VMs? For NVMe it may be possible to allocate multiple Namespaces on the device using management tools. Then

[PULL 0/2] aspeed queue

2022-08-01 Thread Cédric Le Goater
The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-aspeed-20220801 for you

[PULL 1/2] aspeed: Remove unused fields from AspeedMachineState

2022-08-01 Thread Cédric Le Goater
Fixes: 346160cbf2af ("aspeed: Set the dram container at the SoC level") Message-Id: <20220727102714.803041-2-...@kaod.org> Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 4193a3d23d1d..b3bbe06f8fa4

[PULL 7/7] tests/qtest/migration-test: Run the dirty ring tests only with the x86 target

2022-08-01 Thread Thomas Huth
kvm_dirty_ring_supported() only checks whether the dirty ring support is available on the x86 host, but it ignores whether the target QEMU architecture is x86 or not. Thus the test_vcpu_dirty_limit() test currently fails with the assert((strcmp(arch, "x86_64") == 0)) statement in

Re: [RFC v5 11/11] docs/zoned-storage: add zoned device documentation

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:42, Sam Li wrote: > > Add the documentation about the zoned device support to virtio-blk > emulation. > > Signed-off-by: Sam Li > --- > docs/devel/zoned-storage.rst | 68 ++ > docs/system/qemu-block-drivers.rst.inc | 6 +++ > 2 files

[PULL 5/7] misc: fix commonly doubled up words

2022-08-01 Thread Thomas Huth
From: Daniel P. Berrangé Signed-off-by: Daniel P. Berrangé Message-Id: <20220707163720.1421716-5-berra...@redhat.com> Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth --- docs/devel/qom.rst | 4 ++-- docs/interop/live-block-operations.rst | 4 ++--

[PULL 0/7] Testing and wording fixes

2022-08-01 Thread Thomas Huth
Hi! The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-08-01

[PULL 6/7] trivial: Fix duplicated words

2022-08-01 Thread Thomas Huth
Some files wrongly contain the same word twice in a row. One of them should be removed or replaced. Message-Id: <20220722145859.1952732-1-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/arm/omap2.c| 2 +- hw/misc/mac_via.c | 2 +-

[PULL 3/7] migration-test: Allow test to run without uffd

2022-08-01 Thread Thomas Huth
From: Peter Xu We used to stop running all tests if uffd is not detected. However logically that's only needed for postcopy not the rest of tests. Keep running the rest when still possible. Signed-off-by: Peter Xu Tested-by: Thomas Huth Message-Id: <20220728133516.92061-3-pet...@redhat.com>

[PULL 4/7] tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test

2022-08-01 Thread Thomas Huth
Let's use better, more inclusive wording here. Message-Id: <20220727092135.302915-4-th...@redhat.com> Reviewed-by: Konstantin Kostiuk Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/unit/test-qga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [RFC v5 10/11] qemu-iotests: test new zone operations

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:39, Sam Li wrote: > > We have added new block layer APIs of zoned block devices. Test it with: > Create a null_blk device, run each zone operation on it and see > whether reporting right zone information. > > Signed-off-by: Sam Li > --- >

[PULL 1/7] tests/tcg/linux-test: Fix random hangs in test_socket

2022-08-01 Thread Thomas Huth
From: Ilya Leoshkevich test_socket hangs randomly in connect(), especially when run without qemu. Apparently the reason is that linux started treating backlog value of 0 literally instead of rounding it up since v4.4 (commit ef547f2ac16b). So set it to 1 instead. Signed-off-by: Ilya

[PULL 2/7] migration-test: Use migrate_ensure_converge() for auto-converge

2022-08-01 Thread Thomas Huth
From: Peter Xu Thomas reported that auto-converge test will timeout on MacOS CI gatings. Use the migrate_ensure_converge() helper too in the auto-converge as when Daniel reworked the other test cases. Since both max_bandwidth / downtime_limit will not be used for converge calculations, make it

Re: [PULL for-7.1 0/3] hw/nvme fixes

2022-08-01 Thread Richard Henderson
On 8/1/22 03:05, Klaus Jensen wrote: From: Klaus Jensen Hi, The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at:

Re: [RFC v5 09/11] qemu-io: add zoned block device operations.

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:42, Sam Li wrote: > > Add zoned storage commands of the device: zone_report(zrp), zone_open(zo), > zone_close(zc), zone_reset(zrs), zone_finish(zf). > > For example, to test zone_report, use following command: > $ ./build/qemu-io --image-opts driver=zoned_host_device,

Re: [RFC v5 08/11] virtio-blk: add zoned storage APIs for zoned devices

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:43, Sam Li wrote: > > This patch extends virtio-blk emulation to handle zoned device commands > by calling the new block layer APIs to perform zoned device I/O on > behalf of the guest. It supports Report Zone, and four zone oparations (open, > close, finish, reset). The

[PULL 1/3] target/arm: Use kvm_arm_sve_supported in kvm_arm_get_host_cpu_features

2022-08-01 Thread Peter Maydell
From: Richard Henderson Indication for support for SVE will not depend on whether we perform the query on the main kvm_state or the temp vcpu. Signed-off-by: Richard Henderson Message-id: 20220726045828.53697-2-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter

[PULL 2/3] target/arm: Set KVM_ARM_VCPU_SVE while probing the host

2022-08-01 Thread Peter Maydell
From: Richard Henderson Because we weren't setting this flag, our probe of ID_AA64ZFR0 was always returning zero. This also obviates the adjustment of ID_AA64PFR0, which had sanitized the SVE field. The effects of the bug are not visible, because the only thing that ID_AA64ZFR0 is used for

[PULL 3/3] target/arm: Move sve probe inside kvm >= 4.15 branch

2022-08-01 Thread Peter Maydell
From: Richard Henderson The test for the IF block indicates no ID registers are exposed, much less host support for SVE. Move the SVE probe into the ELSE block. Signed-off-by: Richard Henderson Message-id: 20220726045828.53697-4-richard.hender...@linaro.org Reviewed-by: Peter Maydell

[PULL 0/3] target-arm queue

2022-08-01 Thread Peter Maydell
at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220801 for you to fetch changes up to 5265d24c981dfdda8d29b44f7e84a514da75eedc: target/arm: Move sve probe inside kvm >= 4.15 branch (2022-08-01 16:21:18 +0

Re: [RFC v5 07/11] config: add check to block layer

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:39, Sam Li wrote: > > Putting zoned/non-zoned BlockDrivers on top of each other is not > allowed. > > Signed-off-by: Sam Li > --- > block.c | 13 + > block/file-posix.c | 2 ++ > block/raw-format.c | 1

Re: [RFC v5 06/11] raw-format: add zone operations to pass through requests

2022-08-01 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi

Re: [RFC v5 05/11] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:34, Sam Li wrote: > > By adding zone management operations in BlockDriver, storage controller > emulation can use the new block layer APIs including Report Zone and > four zone management operations (open, close, finish, reset). > > BlockDriver can get zone information

[PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Eugenio Pérez
File descriptor vdpa_device_fd is not free in the case of returning error from vhost_vdpa_get_features. Fixing it by making all errors go to the same error path. Resolves: Coverity CID 1490785 Fixes: 8170ab3f43 ("vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs")

Re: [RFC v5 04/11] file-posix: introduce get_sysfs_str_val for device zoned model

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:34, Sam Li wrote: > > Use sysfs attribute files to get the string value of device > zoned model. Then get_sysfs_zoned_model can convert it to > BlockZoneModel type in QEMU. > > Signed-off-by: Sam Li > --- > block/file-posix.c | 86

Re: [PATCH v7 14/14] memfd_create.2: Describe MFD_INACCESSIBLE flag

2022-08-01 Thread Dave Hansen
This patch does not belong in this series. It's not a patch to the kernel. This is a kernel series. It would be much more appropriate to put a link to a separately posted manpage patch in the cover letter.

Re: [PATCH] tpm_emulator: Avoid double initialization during migration

2022-08-01 Thread Marc-André Lureau
Hi On Mon, Aug 1, 2022 at 6:28 PM Ross Lagerwall via wrote: > When resuming after a migration, the backend sends CMD_INIT to the > emulator from the startup callback, then it sends the migration state > from the vmstate to the emulator, then it sends CMD_INIT again. Skip the > first CMD_INIT

Re: [PATCH] tests/qtest/migration-test: Run the dirty ring tests only with the x86 target

2022-08-01 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > kvm_dirty_ring_supported() only checks whether the dirty ring support > is available on the x86 host, but it ignores whether the target QEMU > architecture is x86 or not. Thus the test_vcpu_dirty_limit() test > currently fails with the assert((strcmp(arch,

Re: [RFC v5 03/11] file-posix: introduce get_sysfs_long_val for the long sysfs attribute

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:39, Sam Li wrote: > > Use sysfs attribute files to get the long value of zoned device > information. > > Signed-off-by: Sam Li > --- > block/file-posix.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git

[PATCH] tpm_emulator: Avoid double initialization during migration

2022-08-01 Thread Ross Lagerwall via
When resuming after a migration, the backend sends CMD_INIT to the emulator from the startup callback, then it sends the migration state from the vmstate to the emulator, then it sends CMD_INIT again. Skip the first CMD_INIT during a migration to avoid initializing the TPM twice. Signed-off-by:

Re: [PATCH v4 11/17] dump/dump: Add section string table support

2022-08-01 Thread Janosch Frank
On 7/29/22 21:35, Janis Schoetterl-Glausch wrote: On 7/26/22 11:22, Janosch Frank wrote: As sections don't have a type like the notes do we need another way to Having a string table seems like a good idea to me, as we don't know the requirements any architecture might have, but sections do

Re: [RFC v5 02/11] include: import virtio_blk headers from linux with zoned storage support

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:33, Sam Li wrote: > > Add file from Dmitry's "virtio-blk:add support for zoned block devices" > linux patch using scripts/update-linux-headers.sh. There is a link for > more information: https://github.com/dmitry-fomichev/virtblk-zbd > > Signed-off-by: Sam Li > --- >

Re: [RFC v5 01/11] include: add zoned device structs

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:32, Sam Li wrote: > > Signed-off-by: Sam Li > --- > include/block/block-common.h | 43 > 1 file changed, 43 insertions(+) > > diff --git a/include/block/block-common.h b/include/block/block-common.h > index fdb7306e78..c9d28b1c51

Re: [PATCH v3 1/2] qapi: Add exit-failure PanicAction

2022-08-01 Thread Markus Armbruster
Ilya Leoshkevich writes: > Currently QEMU exits with code 0 on both panic an shutdown. For tests > it is useful to return 1 on panic, so that it counts as a test > failure. > > Introduce a new exit-failure PanicAction that makes main() return > EXIT_FAILURE. Tests can use -action

[RFC PATCH] util: add a qemu_backtrace utility function

2022-08-01 Thread Alex Bennée
When debugging failures in CI which can't be replicated locally it can be useful to dump a backtrace. However ad-hoc debug code is likely to fail to compile on numerous hosts so lets package up a utility function with proper compiler detection. Signed-off-by: Alex Bennée --- configure

[PULL] IPMI bug fixes

2022-08-01 Thread Corey Minyard
Not a huge deal, but probably makes mainainers lives a little easier. Add a change to make Coverity happy. Corey Minyard (1): ipmi:smbus: Add a check around a memcpy hw/ipmi/smbus_ipmi.c | 4 +++- 1 file changed, 3

Re: [RFC v5 05/11] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-01 Thread Eric Blake
On Mon, Aug 01, 2022 at 09:33:05AM +0800, Sam Li wrote: > By adding zone management operations in BlockDriver, storage controller > emulation can use the new block layer APIs including Report Zone and > four zone management operations (open, close, finish, reset). > > BlockDriver can get zone

Re: [PULL 0/3] Hexagon bug fixes and test improvements

2022-08-01 Thread Richard Henderson
On 7/31/22 16:32, Taylor Simpson wrote: The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at:

Re: [PATCH v2 1/1] monitor: Support specified vCPU registers

2022-08-01 Thread Markus Armbruster
zhenwei pi writes: > Originally we have to get all the vCPU registers and parse the > specified one. To improve the performance of this usage, allow user > specified vCPU id to query registers. > > Run a VM with 16 vCPU, use bcc tool to track the latency of > 'hmp_info_registers': > 'info

race condition in display device caused by run_on_cpu() dropping the iothread lock

2022-08-01 Thread Peter Maydell
I've been debugging a segfault in the raspi3b display device, and I've tracked it down to a race condition, but I'm not sure what the right way to fix it is... The race is that a vCPU thread is handling a guest register write that says "resize the framebuffer", which it implements by calling

Re: [PATCH 18/19] ppc/ppc405: QOM'ify UIC

2022-08-01 Thread Cédric Le Goater
Daniel, On 8/1/22 15:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 3 ++- hw/ppc/ppc405_uc.c | 27 ++- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index

Re: [PULL V2 19/25] vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs

2022-08-01 Thread Eugenio Perez Martin
On Mon, Aug 1, 2022 at 5:29 AM Jason Wang wrote: > > > 在 2022/7/29 22:08, Peter Maydell 写道: > > On Wed, 20 Jul 2022 at 10:04, Jason Wang wrote: > >> From: Eugenio Pérez > >> > >> To know the device features is needed for CVQ SVQ, so SVQ knows if it > >> can handle all commands or not. Extract

[PATCH 17/19] ppc/ppc405: QOM'ify FPGA

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 55 +- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c index 82b51cc457fa..2900c267b7ac 100644 --- a/hw/ppc/ppc405_boards.c +++

[PATCH 18/19] ppc/ppc405: QOM'ify UIC

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 3 ++- hw/ppc/ppc405_uc.c | 27 ++- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index 0cbfd977aecf..c2cfccb9d106 100644 --- a/hw/ppc/ppc405.h +++

[PATCH 16/19] ppc/ppc405: QOM'ify MAL

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h | 1 + include/hw/ppc/ppc4xx.h | 28 ++ hw/ppc/ppc405_uc.c | 20 +-- hw/ppc/ppc4xx_devs.c| 120 +--- 4 files changed, 118 insertions(+), 51 deletions(-) diff --git

[PATCH 11/19] ppc/ppc405: QOM'ify DMA

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 23 + hw/ppc/ppc405_uc.c | 80 +- 2 files changed, 73 insertions(+), 30 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index 46366c3b8a19..bd662b2444ff 100644 ---

[PATCH 12/19] ppc/ppc405: QOM'ify EBC

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 16 +++ hw/ppc/ppc405_uc.c | 71 +++--- 2 files changed, 64 insertions(+), 23 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index bd662b2444ff..f1acb37185f5 100644 ---

[PATCH 19/19] ppc/ppc405: QOM'ify I2C

2022-08-01 Thread Cédric Le Goater
Having an explicit I2C model object will help if one day we want to add I2C devices on the bus. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 2 ++ hw/ppc/ppc405_uc.c | 10 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h

[PATCH 13/19] ppc/ppc405: QOM'ify OPBA

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 12 hw/ppc/ppc405_uc.c | 47 +++--- 2 files changed, 40 insertions(+), 19 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index f1acb37185f5..ebff00bdad80 100644 ---

[PATCH 06/19] ppc/ppc405: QOM'ify CPU

2022-08-01 Thread Cédric Le Goater
Drop the use of ppc4xx_init() and duplicate a bit of code related to clocks in the SoC realize routine. We will clean that up in the following patches. ppc_dcr_init simply allocates default DCR handlers for the CPU. Maybe this could be done in model initializer of the CPU families needing it.

[PATCH 07/19] ppc/ppc405: QOM'ify CPC

2022-08-01 Thread Cédric Le Goater
Since all clock settings are now handled at the CPC level, this changes the SoC "sys-clk" property to be an alias on the same property in the CPC model. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 39 +++- hw/ppc/ppc405_uc.c | 109

[PATCH 05/19] ppc/ppc405: Start QOMification of the SoC

2022-08-01 Thread Cédric Le Goater
This moves all the code previously done in the ppc405ep_init() routine under ppc405_soc_realize(). Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 12 ++-- hw/ppc/ppc405_boards.c | 12 ++-- hw/ppc/ppc405_uc.c | 151 - 3 files changed,

[PATCH 15/19] ppc/ppc405: QOM'ify PLB

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 14 ++ hw/ppc/ppc405_uc.c | 67 +- 2 files changed, 62 insertions(+), 19 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index d39d65cc86e4..4ff5cdcf5c65 100644 ---

[PATCH 10/19] ppc/ppc405: QOM'ify GPIO

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 21 +++ hw/ppc/ppc405_uc.c | 50 +- 2 files changed, 44 insertions(+), 27 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index e56363366cad..46366c3b8a19 100644 ---

[PATCH 08/19] ppc/ppc405: QOM'ify GPT

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 22 hw/ppc/ppc405_uc.c | 90 +++--- 2 files changed, 67 insertions(+), 45 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index d51fb5094e95..f7c0eb1d0008 100644 ---

[PATCH 14/19] ppc/ppc405: QOM'ify POB

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 14 +++ hw/ppc/ppc405_uc.c | 58 +++--- 2 files changed, 53 insertions(+), 19 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index ebff00bdad80..d39d65cc86e4 100644 ---

[PATCH 04/19] ppc/ppc405: Introduce a PPC405 SoC

2022-08-01 Thread Cédric Le Goater
It is an initial model to start QOMification of the PPC405 board. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 17 ++ hw/ppc/ppc405_boards.c | 29 ++- hw/ppc/ppc405_uc.c | 53 ++ 3 files changed, 82

[PATCH 03/19] ppc/ppc405: Move devices under the ref405ep machine

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c index 4c269b6526a5..24ec948d22a4 100644 --- a/hw/ppc/ppc405_boards.c +++

[PATCH 02/19] ppc/ppc405: Introduce a PPC405 generic machine

2022-08-01 Thread Cédric Le Goater
We will use this machine as a base to define the ref405ep and possibly the PPC405 hotfoot board as found in the Linux kernel. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git

  1   2   >