Re: [Qemu-devel] [PATCH] block: Fix compiler warning (-Werror=uninitialized)

Am 17.09.2013 18:43, schrieb Stefan Weil: The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3: block/stream.c:141:22: error: ‘copy’ may be used uninitialized in this function [-Werror=uninitialized] This is not a real bug - a better compiler would not complain. Now 'copy'

Re: [Qemu-devel] block/stream.c -Werror build failure

Am 19.09.2013 18:59, schrieb Stefan Weil: Am 19.09.2013 18:52, schrieb Andreas Färber: Hello, As reported yesterday on IRC, since the last round of pulls I am getting the following warning-treated-as-error: CCblock/stream.o /home/andreas/QEMU/qemu/block/stream.c: In function

[Qemu-devel] [PATCH v3 14/18] milkymist: Suppress -kernel/-bios/-drive error for qtest

Acked-by: Michael Walle mich...@walle.cc Signed-off-by: Andreas Färber afaer...@suse.de --- hw/lm32/milkymist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index f1744ec..15053c4 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32

[Qemu-devel] [PATCH v3 00/18] qtest: Test all targets

() for armv7m, too. Cc: Anthony Liguori anth...@codemonkey.ws Cc: Aurélien Jarno aurel...@aurel32.net Cc: Paolo Bonzini pbonz...@redhat.com Cc: Peter Maydell peter.mayd...@linaro.org Andreas Färber (18): mips_mipssim: Silence BIOS loading warning for qtest arm/boot: Turn arm_load_kernel

[Qemu-devel] [PATCH v3 16/18] shix: Don't require firmware presence for qtest

Adopt error_report() while at it. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/tc58128.c | 10 ++ hw/sh4/shix.c | 9 + 2 files changed, 11 insertions(+), 8

[Qemu-devel] [PATCH v3 02/18] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/boot.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 1e313af..0c3dc5f 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -15,6 +15,7 @@ #include hw/loader.h #include elf.h #include sysemu

[Qemu-devel] [PATCH v3 07/18] palm: Don't enforce loading ROM or kernel for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/palm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/palm.c b/hw/arm/palm.c index 3e39044..ff6bfab 100644 --- a/hw/arm/palm.c +++ b/hw/arm/palm.c @@ -19,6 +19,7 @@ #include hw/hw.h #include audio/audio.h

[Qemu-devel] [PATCH v3 10/18] armv7m: Don't enforce use of kernel for qtest

Adopt error_report(). Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/armv7m.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 89a9015..397e8df 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c

[Qemu-devel] [PATCH v3 03/18] puv3: Turn puv3_load_kernel() into a no-op for qtest without -kernel

Replacing the assert() with more user-friendly error handling is left for a follow-up. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/unicore32/puv3.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c index a900061..e05cbc1 100644 --- a/hw

[Qemu-devel] [PATCH v3 04/18] mainstone: Don't enforce use of -pflash for qtest

Simply skip flash setup for now. Also drop useless debug output. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/mainstone.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c index b244f7e..9402c84 100644 --- a/hw/arm

[Qemu-devel] [PATCH v3 09/18] exynos4_boards: Silence lack of -smp 2 warning for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/exynos4_boards.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c index 2929f9f..26cedec 100644 --- a/hw/arm/exynos4_boards.c +++ b/hw/arm/exynos4_boards.c @@ -22,6

[Qemu-devel] [PATCH v3 11/18] axis_dev88: Don't enforce use of kernel for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cris/axis_dev88.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index 03058d3..5524088 100644 --- a/hw/cris/axis_dev88.c +++ b/hw/cris/axis_dev88.c @@ -32,6 +32,7

[Qemu-devel] [PATCH v3 18/18] qtest: Prepare QOM machine tests

or xenfv. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/Makefile | 26 ++ tests/qom-test.c | 253 +++ 2 files changed, 279 insertions(+) create mode 100644 tests/qom-test.c diff --git a/tests/Makefile b/tests/Makefile index 994fef1

[Qemu-devel] [PATCH v3 12/18] mcf5208: Don't enforce use of kernel for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/m68k/mcf5208.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index fb96fe8..6e30c0b 100644 --- a/hw/m68k/mcf5208.c +++ b/hw/m68k/mcf5208.c @@ -10,6 +10,7 @@ #include qemu/timer.h #include hw

[Qemu-devel] [PATCH v3 01/18] mips_mipssim: Silence BIOS loading warning for qtest

Reviewed-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Andreas Färber afaer...@suse.de --- hw/mips/mips_mipssim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c index 242bab9..239aa6a 100644 --- a/hw/mips

[Qemu-devel] [PATCH v3 13/18] an5206: Don't enforce use of kernel for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/m68k/an5206.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c index a8eee44..24f2068 100644 --- a/hw/m68k/an5206.c +++ b/hw/m68k/an5206.c @@ -12,6 +12,7 @@ #include hw/loader.h #include elf.h

[Qemu-devel] [PATCH v3 05/18] gumstix: Don't enforce use of -pflash for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/gumstix.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c index e97fbbd..aeea172 100644 --- a/hw/arm/gumstix.c +++ b/hw/arm/gumstix.c @@ -42,6 +42,7 @@ #include hw

Re: [Qemu-devel] [PATCH v4 06/12] xics: convert init() to realize()

Am 30.08.2013 07:28, schrieb Alexey Kardashevskiy: This fixes XICS according new QOM rules. This converts ICS's init() callbacks to realize(). This converts legacy qdev_init_nofail() to property_set(realized). Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: Andreas

Re: [Qemu-devel] [PATCH v4 07/12] xics: add missing const specifiers to TypeInfo

Am 30.08.2013 07:28, schrieb Alexey Kardashevskiy: This adds missing const specifiers to ICS and ICP TypeInfo's. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF

[Qemu-devel] [PATCH v3 15/18] shix: Drop debug output

Reviewed-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Andreas Färber afaer...@suse.de --- hw/sh4/shix.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c index 1ff37f5..f008b98 100644 --- a/hw/sh4/shix.c +++ b/hw/sh4/shix.c @@ -50,7 +50,6 @@ static

Re: [Qemu-devel] [PATCH v3 02/18] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel

Am 23.09.2013 15:35, schrieb Andreas Färber: Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/boot.c | 4 1 file changed, 4 insertions(+) Sorry, I forgot that Grant Likely had an alternative patch [1] not restricted to qtest. Last thing I read was that PMM had similar/further

Re: [Qemu-devel] [PATCH v4 04/12] xics: replace fprintf with error_report

Am 30.08.2013 07:28, schrieb Alexey Kardashevskiy: This replaces old-style fprintf with new style error_report. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: Andreas Färber afaer...@suse.de Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

[Qemu-devel] [PATCH v3 08/18] omap_sx1: Don't enforce use of kernel or flash for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/omap_sx1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c index b0f8664..235fed8 100644 --- a/hw/arm/omap_sx1.c +++ b/hw/arm/omap_sx1.c @@ -32,6 +32,7 @@ #include hw/arm/arm.h

[Qemu-devel] [PATCH v3 06/18] z2: Don't enforce use of -pflash for qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/arm/z2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index 2e0d5d4..61c9ca7 100644 --- a/hw/arm/z2.c +++ b/hw/arm/z2.c @@ -24,6 +24,7 @@ #include ui/console.h #include audio/audio.h

[Qemu-devel] [PATCH v3 17/18] leon3: Don't enforce use of -bios with qtest

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/sparc/leon3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 390f3e4..c583c3d 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -26,6 +26,7 @@ #include hw/ptimer.h

Re: [Qemu-devel] [PATCH 1/3] Fix coding style

Am 24.09.2013 18:45, schrieb Fabien Chouteau: Signed-off-by: Fabien Chouteau chout...@adacore.com --- disas.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [Qemu-devel] [PATCH v2 0/2] tests: Fixes for in-tree build

Am 25.09.2013 02:38, schrieb Michael Roth: Quoting Laszlo Ersek (2013-08-28 05:49:05) On 08/20/13 13:43, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com v2: Nominate for qemu-stable (Andreas) Markus Armbruster (2): tests: Fix schema parser test for in-tree build

Re: [Qemu-devel] [PATCH v3 02/11] AARCH64: add a57core

Hi, Am 27.09.2013 12:10, schrieb Mian M. Hamayun: From: John Rigby john.ri...@linaro.org Just an copy of a15 with a57 substituting a15 for now. Signed-off-by: John Rigby john.ri...@linaro.org Signed-off-by: Mian M. Hamayun m.hama...@virtualopensystems.com --- hw/cpu/Makefile.objs | 1

Re: [Qemu-devel] [PATCH v2 03/30] net/pcnet-pci: QOM Upcast Sweep

Am 30.06.2013 09:34, schrieb Andreas Färber: Am 24.06.2013 08:52, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct - style upcasting. Signed-off-by: Peter Crosthwaite

Re: [Qemu-devel] [PATCH qom-cpu] HACKING: Document vaddr type usage

Am 22.07.2013 19:27, schrieb Peter Maydell: On 22 July 2013 17:36, Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- HACKING | 1 + 1 file changed, 1 insertion(+) diff --git a/HACKING b/HACKING index e73ac79..d9dbb46 100644 --- a/HACKING +++ b

Re: [Qemu-devel] [PATCH RFC qom-next 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

Am 22.07.2013 22:29, schrieb Anthony Liguori: Michael S. Tsirkin m...@redhat.com writes: On Sun, Jul 21, 2013 at 04:09:04PM +0200, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 23 ++- hw/pci-bridge

Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp

Am 22.07.2013 23:03, schrieb Seiji Aguchi: Convert stderr messages calling error_get_pretty() to error_report(). Timestamp is prepended by -msg timstamp option with it. This is suggested by Luiz Capitulino. http://marc.info/?l=qemu-develm=137331442628866w=2 Signed-off-by: Seiji

Re: [Qemu-devel] [PATCH 00/28] Memory API for 1.6: fix I/O port endianness mess

Am 22.07.2013 22:16, schrieb Hervé Poussineau: BTW, I've a patch to really cleanup i82378 implementation (47 insertions, 175 deletions). Should I send it now, during 1.6 soft freeze? Yes please, since it's a PReP-only device and relevant to the general discussion. Andreas -- SUSE LINUX

Re: [Qemu-devel] [PATCH RFC qom-next 0/4] QOM'ification of pci-bridge types

Am 22.07.2013 19:22, schrieb Andreas Färber: Am 21.07.2013 22:26, schrieb Michael S. Tsirkin: On Sun, Jul 21, 2013 at 04:09:00PM +0200, Andreas Färber wrote: Hello Michael et al., This series turns PCIBridge, PCIEPort and PCIESlot into abstract QOM types, so that we can use QOM casts

[Qemu-devel] [PATCH qom-next v2 2/4] pci-bridge-dev: QOM parent field cleanup

Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/pci_bridge_dev.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge

[Qemu-devel] [PATCH qom-next v2 1/4] pci-bridge: Turn PCIBridge into abstract QOM type

Introduce TYPE_PCI_BRIDGE as base type and use PCI_BRIDGE() casts. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/dec.c| 4 ++-- hw/pci-bridge/i82801b11.c | 6 +++--- hw/pci-bridge/ioh3420.c| 18 - hw/pci-bridge

[Qemu-devel] [PATCH qom-next v2 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

Move PCIEPort's port property to the new type, same for aer_log_max. Move PCIESlot's chassis and slot properties to the new type. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/ioh3420.c| 31 ++- hw/pci-bridge/xio3130_downstream.c | 31

[Qemu-devel] [PATCH qom-next v2 3/4] pci-bridge/i82801b11: Rename parent field

Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-bridge/i82801b11.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index 88f489a..90fc91d 100644 --- a/hw/pci-bridge/i82801b11.c +++ b/hw/pci-bridge/i82801b11.c

[Qemu-devel] [PATCH qom-next v2 0/4] QOM'ification of pci-bridge types

...@cn.fujitsu.com Andreas Färber (4): pci-bridge: Turn PCIBridge into abstract QOM type pci-bridge-dev: QOM parent field cleanup pci-bridge/i82801b11: Rename parent field pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types hw/pci-bridge/dec.c| 4 +-- hw/pci-bridge

Re: [Qemu-devel] [PATCH 0/9] Add platform bus

Am 23.07.2013 00:34, schrieb Peter Maydell: On 22 July 2013 23:05, Anthony Liguori anth...@codemonkey.ws wrote: Peter Maydell peter.mayd...@linaro.org writes: We don't currently have any PCI host controller which is: (a) for ARM In QEMU? You can make one super easily by just extending

Re: [Qemu-devel] [PATCH] linux-user: Use X86CPU property to retrieve CPUID family

Am 11.07.2013 07:35, schrieb Igor Mammedov: On Wed, 10 Jul 2013 18:26:17 +0200 Andreas Färber afaer...@suse.de wrote: Avoids duplicating the calculation. Signed-off-by: Andreas Färber afaer...@suse.de --- Have this lying around for a while already, apparently not sent out yet. linux

[Qemu-devel] [PULL 09/55] scsi/lsi53c895a: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/lsi53c895a.c | 26

[Qemu-devel] [PULL 01/55] hw: Avoid use of QOM type name macros in VMStateDescriptions

of code refactoring and cleanup. For the handful of devices that were doing this by mistake, replace the QOM typenames with the corresponding literal strings. Signed-off-by: Peter Maydell peter.mayd...@linaro.org [AF: Use TYPE_PVSCSI for TypeInfo instead] Signed-off-by: Andreas Färber afaer

[Qemu-devel] [PULL 07/55] usb/hcd-xhci: QOM Upcast Sweep

-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-xhci.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index d7a54fd..0566886 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -482,6 +482,11 @@ struct

[Qemu-devel] [PULL 11/55] scsi/megasas: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/megasas.c | 15

[Qemu-devel] [PULL 13/55] scsi/esp-pci: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/esp-pci.c | 14

[Qemu-devel] [PULL 02/55] net/e1000: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/net/e1000.c | 18

[Qemu-devel] [PULL 03/55] net/e1000: QOM parent field cleanup

Replace direct uses of E1000State::dev field with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/net/e1000.c | 35 ++- 1 file changed, 22 insertions(+), 13

[Qemu-devel] [PULL 26/55] xen/xen_platform: QOM parent field cleanup

Replace direct uses of PCIXenPlatformState::pci_dev field with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/xen/xen_platform.c | 21 + 1 file changed, 13 insertions(+), 8

[Qemu-devel] [PULL 12/55] scsi/megasas: QOM parent field cleanup

Replace direct uses of MegasasState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/megasas.c | 46 ++ 1 file changed, 26 insertions

[Qemu-devel] [PULL 21/55] display/vmware_vga: QOM casting sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style casting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Renamed to TYPE_VMWARE_VGA and VMWARE_VGA()] Signed-off-by: Andreas Färber

[Qemu-devel] [PULL 30/55] i440fx: Use type-safe cast instead of direct access of parent dev

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Converted remaining accesses and renamed to parent_obj] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-host/piix.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff

[Qemu-devel] [PULL 19/55] misc/pci-testdev: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Replaced another DO_UPCAST()] Signed-off-by: Andreas Färber afaer...@suse.de

[Qemu-devel] [PULL 18/55] acpi/piix4: QOM parent field cleanup

Replace direct uses of PIIX4PMState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/acpi/piix4.c | 32 1 file changed, 20 insertions(+), 12 deletions

[Qemu-devel] [PULL 23/55] misc/ivshmem: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Simplified casts and converted two more DO_UPCAST()s] Signed-off-by: Andreas

[Qemu-devel] [PULL 25/55] xen/xen_platform: QOM casting sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Dropped opaque casts] Signed-off-by: Andreas Färber afaer...@suse.de --- hw

[Qemu-devel] [PULL 17/55] acpi/piix4: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/acpi/piix4.c | 31

[Qemu-devel] [PULL 36/55] pflash-cfi02: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and replace FROM_SYSBUS(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/pflash_cfi02.c | 21 - 1 file changed, 12 insertions(+), 9

[Qemu-devel] [PULL 22/55] display/vmware_vga: QOM parent field cleanup

Replace direct uses of pci_vmsvga_state_s::card with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/display/vmware_vga.c | 23 +-- 1 file changed, 13 insertions(+), 10

[Qemu-devel] [PULL 47/55] fw_cfg: Use QOM realize for fw_cfg

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Moved sysbus_init_mmio() to instance_init, renamed variable] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/nvram/fw_cfg.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions

[Qemu-devel] [PULL 27/55] sysbus: Document SysBusDeviceClass::init and realize semantics

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Syntax and wording changes] Signed-off-by: Andreas Färber afaer...@suse.de --- include/hw/sysbus.h | 12 1 file changed, 12 insertions(+) diff --git a/include/hw/sysbus.h b/include/hw/sysbus.h index

[Qemu-devel] [PULL 37/55] ahci: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and avoid DO_UPCAST(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ide/ahci.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PULL 41/55] kvm/clock: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and avoid FROM_SYSBUS(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/clock.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions

[Qemu-devel] [PULL 15/55] ide/ich: QOM Upcast Sweep

-by: Andreas Färber afaer...@suse.de --- hw/ide/ahci.h | 5 + hw/ide/ich.c | 10 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h index 341a571..f997c67 100644 --- a/hw/ide/ahci.h +++ b/hw/ide/ahci.h @@ -305,6 +305,11 @@ typedef struct

[Qemu-devel] [PULL 24/55] misc/ivshmem: QOM parent field cleanup

Replace direct uses of IVShmemState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/misc/ivshmem.c | 37 ++--- 1 file changed, 22 insertions(+), 15

[Qemu-devel] [PULL 39/55] scsi/esp: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and avoid DO_UPCAST(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/esp.c | 21 + 1 file changed, 13 insertions(+), 8 deletions

[Qemu-devel] [PULL 28/55] ohci: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and avoid DO_UPCAST(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Avoid remaining OHCIPCIState::pci_dev uses, rename parent fields] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-ohci.c | 39

[Qemu-devel] [PULL 44/55] pflash_cfi01: Use QOM realize for pflash_cfi01

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed argument] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/pflash_cfi01.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block

[Qemu-devel] [PULL 43/55] fdc: Improve error propagation for QOM realize

Rename fdctrl_init_common() to fdctrl_realize_common() and let fdctrl_connect_drives() propagate an Error through it. Reviewed-by: Hu Tao hu...@cn.fujitsu.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/fdc.c | 40

[Qemu-devel] [PULL 55/55] isa-bus: Drop isabus_bridge_init() since it does nothing

From: Hu Tao hu...@cn.fujitsu.com This works since commit 4ce5dae88ecf2bafa0cd663de7e923728b1b3672. Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Edited] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/isa/isa-bus.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/isa/isa

[Qemu-devel] [PULL 42/55] fdc: Use QOM realize for fdc

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed SysBusDevice variable] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/fdc.c | 63 ++ 1 file changed, 41 insertions(+), 22 deletions

[Qemu-devel] [PULL 48/55] scsi/esp: Use QOM realize for scsi esp

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Drop sysbus_esp_init()] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/esp.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index

[Qemu-devel] [PULL 33/55] q35: Use QOM realize for q35 host bridge

From: Hu Tao hu...@cn.fujitsu.com And split off MemoryRegion initialization into instance_init. Signed-off-by: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-host/q35.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions

[Qemu-devel] [PULL 46/55] ahci: Use QOM realize for ahci

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Avoided repeated SYS_BUS_DEVICE() casts] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ide/ahci.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide

[Qemu-devel] [PULL 35/55] pflash-cfi01: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and replace FROM_SYSBUS(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/pflash_cfi01.c | 21 - 1 file changed, 12 insertions(+), 9

[Qemu-devel] [PULL 49/55] megasas: Legacy command line handling fix

Only apply legacy command line handling when the device has not been hot-plugged. Propagate failure of legacy command line handling. Cc: qemu-sta...@nongnu.org Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/megasas.c | 5 - 1 file

[Qemu-devel] [PULL 38/55] fwcfg: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Use type constant if possible and avoid DO_UPCAST(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/nvram/fw_cfg.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions

[Qemu-devel] [PULL 51/55] hpet: Use QOM realize for hpet

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Avoided SYS_BUS_DEVICE() in loop] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/timer/hpet.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/timer

[Qemu-devel] [PULL 53/55] kvmvapic: Use QOM realize

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed variable] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvmvapic.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index

[Qemu-devel] [PULL 40/55] hpet: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant, avoid FROM_SYSBUS(). Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field and renamed variable] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/timer/hpet.c | 19 +-- 1 file changed, 13 insertions

[Qemu-devel] [PULL 50/55] scsi: Improve error propagation for scsi_bus_legacy_handle_cmdline()

Let scsi_bus_legacy_add_drive() and scsi_bus_legacy_handle_cmdline() return an Error**. Prepare qdev initfns for QOM realize error model. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci/pci-hotplug-old.c | 2 +- hw/scsi/esp-pci.c| 7 ++- hw/scsi/esp.c| 6

[Qemu-devel] [PULL 08/55] usb/hcd-xhci: QOM parent field cleanup

Replace direct uses of XHCIState::pci_dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-xhci.c | 83 --- 1 file changed, 48

[Qemu-devel] [PULL 10/55] scsi/lsi53c895a: QOM parent field cleanup

Replace direct uses of LSIState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/lsi53c895a.c | 46 +++--- 1 file changed, 27 insertions

[Qemu-devel] [PULL 45/55] pflash_cfi02: Use QOM realize for pflash_cfi02

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/pflash_cfi02.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index

[Qemu-devel] [PULL 31/55] i440fx-pcihost: Use QOM realize for i440fx-pcihost

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-host/piix.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index

[Qemu-devel] [PULL 52/55] kvm/clock: Use QOM realize for kvmclock

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/clock.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 6265458..e89e2f7 100644

[Qemu-devel] [PULL 04/55] net/rtl8139: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/net/rtl8139.c | 26

[Qemu-devel] [PULL 20/55] misc/pci-testdev: QOM parent field cleanup

Replace direct uses of PCITestDevState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/misc/pci-testdev.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL 34/55] fdc: QOM'ify some more

From: Hu Tao hu...@cn.fujitsu.com Introduce type constant and avoid DO_UPCAST(), container_of(), and use DEVICE() to avoid accessing parent qdev directly. Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Renamed parent field and avoided repeated SYS_BUS_DEVICE() casts] Signed-off-by: Andreas

Re: [Qemu-devel] [PATCH qom-cpu] HACKING: Document vaddr type usage

Am 22.07.2013 19:36, schrieb Peter Maydell: On 22 July 2013 18:32, Andreas Färber afaer...@suse.de wrote: Am 22.07.2013 19:27, schrieb Peter Maydell: Here's my suggestion for this paragraph (ie to replace both the Use target_ulong... and Use vaddr sentences above): ===begin=== For CPU

[Qemu-devel] [PULL 16/55] ide/ich: QOM parent field cleanup

Replace direct uses of AHCIPCIState::card with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ide/ahci.c | 11 ++- hw/ide/ahci.h | 5 - hw/ide/ich.c | 22 +++--- 3

[Qemu-devel] [PULL 54/55] ioapic: Use QOM realize for ioapic

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Tweaked error message] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/intc/ioapic_common.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/intc/ioapic_common.c b/hw/intc

[Qemu-devel] [PULL 00/55] QOM devices patch queue 2013-07-22

with DeviceClass::realize Andreas Färber (15): net/e1000: QOM parent field cleanup net/rtl8139: QOM parent field cleanup usb/hcd-xhci: QOM parent field cleanup scsi/lsi53c895a: QOM parent field cleanup scsi

[Qemu-devel] [PULL 29/55] ohci: Use QOM realize for OHCI

From: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-ohci.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index 7da2564..2bab8ff 100644

[Qemu-devel] [PULL 06/55] net/pcnet-pci: QOM Upcast Sweep

From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST() and direct - style upcasting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com [AF: Renamed parent field, renamed from PC_NET to PCNET] Signed-off-by: Andreas

[Qemu-devel] [PULL 32/55] q35: Use type-safe cast instead of direct access of parent dev

From: Hu Tao hu...@cn.fujitsu.com And remove variables if possible. Signed-off-by: Hu Tao hu...@cn.fujitsu.com [AF: Converted remaining access and renamed to parent_obj] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc_q35.c | 4 +++- hw/pci-host/q35.c | 43

[Qemu-devel] [PULL 14/55] scsi/esp-pci: QOM parent field cleanup

Replace direct uses of PCIESPState::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/scsi/esp-pci.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw

[Qemu-devel] [PULL 05/55] net/rtl8139: QOM parent field cleanup

Replace direct uses of RTL8139State::dev with QOM casts and rename it to parent_obj. Acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/net/rtl8139.c | 88 +++- 1 file changed, 49

[Qemu-devel] [PATCH qom-next] pcie_host: Turn pcie_host_init() into an instance_init

This assures the trivial field initialization is applied for any derived type - currently only Q35PCIHost. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pci-host/q35.c | 4 hw/pci/pcie_host.c | 7 --- include/hw/pci/pcie_host.h | 1 - 3 files changed, 4

[Qemu-devel] [PATCH v2 08/16] timer/arm_mptimer: Convert to QOM realize

From: Andreas Färber andreas.faer...@web.de Split the SysBusDevice initfn into instance_init and realizefn. Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/timer/arm_mptimer.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/timer

<    1   2   3   4   5   6   7   8   9   10   >