Re: [PATCH v6 1/3] acpi: Some build_tpm2() code reshape

2020-06-19 Thread Auger Eric
Hi Stefan, On 6/19/20 6:09 PM, Stefan Berger wrote: > On 6/19/20 10:18 AM, Eric Auger wrote: >> Remove any reference to Acpi20TPM2 and adopt an implementation >> similar to build_ghes_v2(). >> >> Signed-off-by: Eric Auger >> Suggested-by: Igor Mammedov > > Reviewed-by: Stefan Berger > > Teste

Re: [question] qemu abort when object-add is called with an already used id

2020-06-19 Thread Auger Eric
Hi Daniel, On 6/18/20 7:12 PM, Daniel P. Berrangé wrote: > On Thu, Jun 18, 2020 at 06:15:57PM +0200, Auger Eric wrote: >> Hi, >> >> While testing PCDIMM hotplug/coldplug I noted qemu aborts if we attempt >> to add from the QMP monitor an object whose id is already

Re: [PATCH v6 1/3] acpi: Some build_tpm2() code reshape

2020-06-19 Thread Auger Eric
Hi Stefan, On 6/19/20 5:07 PM, Stefan Berger wrote: > On 6/19/20 10:18 AM, Eric Auger wrote: >> Remove any reference to Acpi20TPM2 and adopt an implementation >> similar to build_ghes_v2(). >> >> Signed-off-by: Eric Auger >> Suggested-by: Igor Mammedov >> >> --- >> >> v5 -> v6: >> - add referenc

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

2020-06-19 Thread Auger Eric
Hi Laszlo, On 6/19/20 11:38 AM, Laszlo Ersek wrote: > On 06/18/20 09:50, Auger Eric wrote: >> Hi Stefan, Igor, >> >> On 6/16/20 4:11 PM, Stefan Berger wrote: >>> On 6/16/20 8:33 AM, Igor Mammedov wrote: >>>> >>>> nevertheless looks l

[question] qemu abort when object-add is called with an already used id

2020-06-18 Thread Auger Eric
Hi, While testing PCDIMM hotplug/coldplug I noted qemu aborts if we attempt to add from the QMP monitor an object whose id is already in use. for instance object-add qom-type=memory-backend-ram id=mem1 props.size=4294967296 while mem1 is already used. We get: Unexpected error in object_property_

Re: [PATCH v3] arm/virt: Add memory hot remove support

2020-06-18 Thread Auger Eric
Hi Shameer, On 6/18/20 2:21 PM, Shameer Kolothum wrote: > This adds support for memory(pc-dimm) hot remove on arm/virt that > uses acpi ged device. > > NVDIMM hot removal is not yet supported. > > Signed-off-by: Shameer Kolothum > --- > V2 --> v3 > -Addressed Eric's review comment and added c

Re: [PATCH v2] arm/virt: Add memory hot remove support

2020-06-18 Thread Auger Eric
Hi Shameer, On 6/17/20 6:40 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message----- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: 17 June 2020 14:54 >> To: Shameerali Kolothum Thodi ; >> qemu-devel@nongnu.org; qemu-...@n

Re: [PATCH v3 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-18 Thread Auger Eric
Hi Jean-Philippe, On 6/17/20 11:16 AM, Jean-Philippe Brucker wrote: > On Thu, Jun 11, 2020 at 05:12:06PM +0200, Eric Auger wrote: >> This patch implements the PROBE request. At the moment, >> only THE RESV_MEM property is handled. The first goal is >> to report iommu wide reserved regions such as

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

2020-06-18 Thread Auger Eric
Hi Stefan, Igor, On 6/16/20 4:11 PM, Stefan Berger wrote: > On 6/16/20 8:33 AM, Igor Mammedov wrote: >> >> nevertheless looks like faithfull conversion, >> btw why you didn't drop Acpi20TPM2 structure definition? >> > If we get rid of the table we should keep a reference to this document, > table

Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts

2020-06-18 Thread Auger Eric
Hi Stefan, On 6/17/20 4:22 PM, Stefan Berger wrote: > This series of patches enables the usage of the TPM TIS with interrupts. > We use the unused IRQ 13, which is the only one accepted by Windows. > > Stefan > > v3->v4: > - Changed TPM_IRQ_DISABLED from -1 to ~0 > > v2->v3: > - Extended

Re: [PATCH v4 7/8] tpm: Guard irq related ops in case interrupts are disabled

2020-06-18 Thread Auger Eric
: Stefan Berger > Message-id: 20200616205721.1191408-8-stef...@linux.vnet.ibm.com Reviewed-by: Eric Auger Eric > --- > hw/tpm/tpm_tis_common.c | 12 +++- > hw/tpm/tpm_tis_isa.c| 6 -- > 2 files changed, 15 insertions(+), 3 deletions(-) > > diff --gi

Re: [PATCH v4 8/8] tpm: Disable interrupt support for TIS on sysbus

2020-06-18 Thread Auger Eric
Hi, On 6/17/20 4:23 PM, Stefan Berger wrote: > Disable interrupt support for the TIS on sysbus. > > Signed-off-by: Stefan Berger > Reviewed-by: Marc-André Lureau > Message-id: 20200616205721.1191408-9-stef...@linux.vnet.ibm.com Reviewed-by: Eric Auger Eric > --- > incl

Re: [PATCH v4 6/8] tests: Add updated DSDT

2020-06-18 Thread Auger Eric
A) > Field (TPP2, AnyAcc, NoLock, Preserve) > ** > > Signed-off-by: Stefan Berger > Reviewed-by: Marc-André Lureau > Message-id: 20200616205721.1191408-7-stef...@linux.vnet.ibm.com Reviewed-by: Eric Auger Eric > CC: Michael S. Tsirkin > --- > test

Re: [PATCH v4 5/8] acpi: Enable TPM IRQ

2020-06-18 Thread Auger Eric
Stefan Berger > Reviewed-by: Marc-André Lureau > Message-id: 20200616205721.1191408-6-stef...@linux.vnet.ibm.com > CC: Michael S. Tsirkin Reviewed-by: Eric Auger Eric > --- > hw/i386/acpi-build.c | 11 +-- > include/hw/acpi/tpm.h | 2 +- > 2 files changed, 6 ins

Re: [PATCH v4 4/8] tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ

2020-06-18 Thread Auger Eric
Hi Stefan, On 6/17/20 4:23 PM, Stefan Berger wrote: > Before the enablement of interrupts on PCs, split the TPM_TIS_IRQ > into TPM_TIS_ISA_IRQ for PCs and TPM_TIS_SYSBUS_IRQ for ARM. > > Signed-off-by: Stefan Berger > Reviewed-by: Marc-André Lureau > Message-id: 20200616205721.1191408-5-stef...

Re: [PATCH v4 2/8] tpm: Extend TPMIfClass with get_irqnum() function

2020-06-18 Thread Auger Eric
Hi Stefan, On 6/17/20 4:22 PM, Stefan Berger wrote: > From: Stefan Berger > > Implement get_irqnum() as part of the TPMIfClass to get the assigned IRQ > number or TPM_IRQ_DISABLED (~0) in case IRQs cannot be used. > > Signed-off-by: Stefan Berger > Reviewed-by: Marc-André Lureau > Message-id:

Re: [PATCH v2] arm/virt: Add memory hot remove support

2020-06-17 Thread Auger Eric
Hi Shameer, On 5/20/20 1:03 PM, Shameer Kolothum wrote: > This adds support for memory hot remove on arm/virt that > uses acpi ged device. > > Signed-off-by: Shameer Kolothum > --- > RFC v1 --> v2 > -Rebased on top of latest Qemu master. > -Dropped "RFC" and tested with kernel 5.7-rc6 > ---

Re: [PATCH v3 4/8] tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ

2020-06-17 Thread Auger Eric
Hi Stefan, On 6/17/20 2:06 PM, Stefan Berger wrote: > On 6/17/20 4:12 AM, Auger Eric wrote: >> Hi Stefan, >> >> On 6/16/20 10:57 PM, Stefan Berger wrote: >>> Before the enablement of interrupts on PCs, split the TPM_TIS_IRQ >>> into TPM_TIS_ISA_IRQ

Re: [PATCH v3 5/8] acpi: Enable TPM IRQ

2020-06-17 Thread Auger Eric
Hi Stefan, On 6/16/20 10:57 PM, Stefan Berger wrote: > From: Stefan Berger > > Move the TPM TIS IRQ to unused IRQ 13, which is the only one accepted by > Windows. Query for the TPM's irq number and enable the TPM IRQ unless > TPM_IRQ_DISABLED is returned. > > Signed-off-by: Stefan Berger > CC:

Re: [PATCH v3 4/8] tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ

2020-06-17 Thread Auger Eric
Hi Stefan, On 6/16/20 10:57 PM, Stefan Berger wrote: > Before the enablement of interrupts on PCs, split the TPM_TIS_IRQ > into TPM_TIS_ISA_IRQ for PCs and TPM_TIS_SYSBUS_IRQ for ARM. > > Signed-off-by: Stefan Berger > --- > hw/tpm/tpm_tis_isa.c| 2 +- > hw/tpm/tpm_tis_sysbus.c | 3 ++- > i

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

2020-06-16 Thread Auger Eric
Hi Stefan, On 6/16/20 4:05 PM, Stefan Berger wrote: > On 6/16/20 9:01 AM, Auger Eric wrote: >> Hi Stefan, >> >> On 6/15/20 7:11 PM, Stefan Berger wrote: >>> On 6/15/20 11:13 AM, Marc-André Lureau wrote: >>>>> diff --git a/include/hw/acpi/tpm.h b

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

2020-06-16 Thread Auger Eric
Hi Igor, On 6/16/20 2:33 PM, Igor Mammedov wrote: > On Thu, 11 Jun 2020 15:59:13 +0200 > Eric Auger wrote: > >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settin

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

2020-06-16 Thread Auger Eric
Hi Stefan, On 6/15/20 7:11 PM, Stefan Berger wrote: > On 6/15/20 11:13 AM, Marc-André Lureau wrote: >> >>> diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h >>> index 1a2a57a21f..063a9eb42a 100644 >>> --- a/include/hw/acpi/tpm.h >>> +++ b/include/hw/acpi/tpm.h >>> @@ -24,7 +24,7 @@ >>>  

Re: [PATCH v2 3/5] tests: Temporarily ignore DSDT table differences

2020-06-16 Thread Auger Eric
On 6/15/20 4:23 PM, Stefan Berger wrote: > Ignore DSDT table differences before enabling IRQ support for TPM. > > Signed-off-by: Stefan Berger > CC: Michael S. Tsirkin Reviewed-by: Eric Auger Thanks Eric > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file changed, 1 insert

Re: [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function

2020-06-16 Thread Auger Eric
Hi Stefan, On 6/15/20 5:44 PM, Stefan Berger wrote: > On 6/15/20 11:11 AM, Marc-André Lureau wrote: >> Hi >> >> On Mon, Jun 15, 2020 at 6:23 PM Stefan Berger >> wrote: >>> From: Stefan Berger >>> >>> Implement get_irqnum() as part of the TPMIfClass to be get the assigned >> ^^ to get >> >>> IRQ

Re: [PATCH v2 1/5] tpm_tis: Allow lowering of IRQ also when locality is not active

2020-06-16 Thread Auger Eric
Hi Stefan, On 6/15/20 4:23 PM, Stefan Berger wrote: > From: Stefan Berger > > This patch fixes a bug that occurs when using interrupts. It > allows to lower the IRQ also when a locality is not active. > > Signed-off-by: Stefan Berger Reviewed-by: Eric Auger Thanks Eric > --- > hw/tpm/tpm_

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

2020-06-16 Thread Auger Eric
Hi Stefan, On 6/15/20 7:11 PM, Stefan Berger wrote: > On 6/15/20 11:13 AM, Marc-André Lureau wrote: >> >>> diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h >>> index 1a2a57a21f..063a9eb42a 100644 >>> --- a/include/hw/acpi/tpm.h >>> +++ b/include/hw/acpi/tpm.h >>> @@ -24,7 +24,7 @@ >>>  

Re: [PULL v2 00/58] virtio, acpi, pci: features, fixes, cleanups, tests

2020-06-16 Thread Auger Eric
Hi, On 6/16/20 9:26 AM, Auger Eric wrote: > Hi Michael, > > + Stefan > > On 6/12/20 4:51 PM, Michael S. Tsirkin wrote: >> changes from v1: >> - printf format fixed for 32 bit hosts >> - a couple of bugfixes added >> >> The following changes since co

Re: [PULL v2 00/58] virtio, acpi, pci: features, fixes, cleanups, tests

2020-06-16 Thread Auger Eric
Hi Michael, + Stefan On 6/12/20 4:51 PM, Michael S. Tsirkin wrote: > changes from v1: > - printf format fixed for 32 bit hosts > - a couple of bugfixes added > > The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: > > Merge remote-tracking branch > 'remotes/vivier2/t

Re: [PATCH] tests/qtest/bios-tables: Only run the TPM test with CONFIG_TPM enabled

2020-06-15 Thread Auger Eric
Hi Thomas, On 6/15/20 2:54 PM, Thomas Huth wrote: > "make check-qtest" currently fails if configure has been run with > "--disable-tpm" - the TPM-related tests can only work if the TPM is > enabled in the build. So let's use the CONFIG_TPM switch to disable > the test if TPM is not available. Plea

Re: [PULL v2 20/58] bios-tables-test: Add Q35/TPM-TIS test

2020-06-15 Thread Auger Eric
Hi Philippe, Thomas, On 6/15/20 12:22 PM, Thomas Huth wrote: > On 15/06/2020 12.02, Philippe Mathieu-Daudé wrote: >> On Fri, Jun 12, 2020 at 5:00 PM Michael S. Tsirkin wrote: >>> >>> From: Eric Auger >>> >>> Test tables specific to the TPM-TIS instantiation. >>> The TPM2 is added in the framewor

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

2020-06-11 Thread Auger Eric
Hi Stefan, On 6/11/20 5:19 PM, Stefan Berger wrote: > On 6/11/20 9:59 AM, Eric Auger wrote: >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settings with manual end

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

2020-06-11 Thread Auger Eric
Hi Stefan, On 6/11/20 4:25 PM, Stefan Berger wrote: > On 6/11/20 9:59 AM, Eric Auger wrote: >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settings with manual end

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

2020-06-11 Thread Auger Eric
Hi Stefan, On 6/11/20 4:25 PM, Stefan Berger wrote: > On 6/11/20 9:59 AM, Eric Auger wrote: >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settings with manual end

Re: [PATCH v3 4/4] arm/acpi: Add the TPM2.0 device under the DSDT

2020-06-11 Thread Auger Eric
Hi Igor, On 6/5/20 4:45 PM, Igor Mammedov wrote: > On Mon, 1 Jun 2020 11:57:37 +0200 > Eric Auger wrote: > >> In case it is dynamically instantiated, add the TPM 2.0 device object >> under the DSDT table in the ACPI namespace. Its HID is MSFT0101 >> while its current resource settings (CRS) pro

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-10 Thread Auger Eric
Hi Igor, On 6/5/20 4:23 PM, Igor Mammedov wrote: > On Mon, 1 Jun 2020 11:57:34 +0200 > Eric Auger wrote: > >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settin

Re: [PATCH v2 0/5] TPM-TIS bios-tables-test

2020-06-09 Thread Auger Eric
Hi, On 6/9/20 4:00 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200609125409.24179-1-eric.au...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker i

Re: [RFC 5/6] bios-tables-test: Add Q35/TPM-TIS test

2020-06-09 Thread Auger Eric
Hi Igor, On 6/5/20 5:17 PM, Igor Mammedov wrote: > On Mon, 1 Jun 2020 12:21:12 +0200 > Eric Auger wrote: > >> Test tables specific to the TPM-TIS instantiation. >> The TPM2 is added in the framework. Also the DSDT >> is updated with the TPM. The new function should be >> be usable for CRB as we

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-08 Thread Auger Eric
Hi Igor, On 6/8/20 10:34 AM, Igor Mammedov wrote: > On Fri, 5 Jun 2020 17:47:08 +0200 > Auger Eric wrote: > >> Hi Stefan, >> >> On 6/5/20 5:25 PM, Stefan Berger wrote: >>> On 6/5/20 5:35 AM, Auger Eric wrote: >>>> Hi Stefan, >>>> &g

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-05 Thread Auger Eric
Hi Stefan, On 6/5/20 5:25 PM, Stefan Berger wrote: > On 6/5/20 5:35 AM, Auger Eric wrote: >> Hi Stefan, >> >> On 6/2/20 6:17 PM, Stefan Berger wrote: >>> On 6/2/20 12:13 PM, Auger Eric wrote: >>>> Hi Stefan, >>>> >>>> On 6/2/20

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-05 Thread Auger Eric
Hi Stefan, On 6/2/20 6:17 PM, Stefan Berger wrote: > On 6/2/20 12:13 PM, Auger Eric wrote: >> Hi Stefan, >> >> On 6/2/20 3:39 PM, Stefan Berger wrote: >>> On 6/1/20 6:21 AM, Eric Auger wrote: >>>> While writing tests for checking the content of TPM2 and

Re: [Question] Regarding PMU initialization within the QEMU for ARM VCPUs

2020-06-03 Thread Auger Eric
Hi Drew, On 6/3/20 12:21 PM, Andrew Jones wrote: > On Wed, Jun 03, 2020 at 11:59:23AM +0200, Auger Eric wrote: >> Hi Drew, >> >> On 6/3/20 11:37 AM, Andrew Jones wrote: >>> On Mon, Jun 01, 2020 at 03:04:33PM +, Salil Mehta wrote: >>>> Hel

Re: [Question] Regarding PMU initialization within the QEMU for ARM VCPUs

2020-06-03 Thread Auger Eric
Hi Drew, On 6/3/20 11:37 AM, Andrew Jones wrote: > On Mon, Jun 01, 2020 at 03:04:33PM +, Salil Mehta wrote: >> Hello, >> I could see below within function fdt_add_pmu_nodes() part of >> hw/arm/virt.c during virt machine initialization time: >> >> Observation: >> In below function, support of P

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Auger Eric
Stefan, On 6/2/20 6:17 PM, Stefan Berger wrote: > On 6/2/20 12:13 PM, Auger Eric wrote: >> Hi Stefan, >> >> On 6/2/20 3:39 PM, Stefan Berger wrote: >>> On 6/1/20 6:21 AM, Eric Auger wrote: >>>> While writing tests for checking the content of TPM2 and DS

Re: [RFC 4/6] tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 3:39 PM, Stefan Berger wrote: > On 6/1/20 6:21 AM, Eric Auger wrote: >> While writing tests for checking the content of TPM2 and DSDT >> along with TPM-TIS instantiation I attempted to reuse the >> framework used for TPM-TIS tests. However While dumping the >> ACPI tables I ge

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 4:24 PM, Stefan Berger wrote: > On 6/2/20 9:55 AM, Auger Eric wrote: >> Hi Stefan, >> On 6/2/20 3:30 PM, Stefan Berger wrote: >>> On 6/1/20 5:57 AM, Eric Auger wrote: >>>> In preparation of its move to the generic acpi code, >>>>

Re: [PATCH v3 1/4] acpi: Convert build_tpm2() to build_append* API

2020-06-02 Thread Auger Eric
Hi Stefan, On 6/2/20 3:30 PM, Stefan Berger wrote: > On 6/1/20 5:57 AM, Eric Auger wrote: >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >> settings with manual endian

Re: [RFC 0/6] TPM-TIS bios-tables-test

2020-06-02 Thread Auger Eric
Hi, On 6/1/20 12:21 PM, Eric Auger wrote: > This series adds the test of the TPM2 and DSDT tables when the > TPM-TIS device gets instantiated. > > The series also allows to validate changes in the TPM2 table > generation done in "[PATCH v3 0/4] vTPM/aarch64 ACPI support", > sent separately. > >

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-02 Thread Auger Eric
Hi, On 6/2/20 7:36 AM, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin Fixes issues reported in "[RFC 0/6] TPM-TIS bi

Re: [PATCH] acpi: tpm: Do not build TCPA table for TPM 2

2020-05-29 Thread Auger Eric
Hi Stefan On 5/30/20 12:23 AM, Stefan Berger wrote: > On 5/29/20 3:28 PM, Stefan Berger wrote: >> From: Stefan Berger >> >> Do not build a TCPA table for TPM 2 anymore but create the log area when >> building the TPM2 table. The TCPA table is only needed for TPM 1.2. Now I understand the purpose

Re: [PATCH v2] hw/vfio/common: Trace in which mode an IOMMU is opened

2020-05-29 Thread Auger Eric
Hi Philippe, On 5/27/20 5:55 PM, Philippe Mathieu-Daudé wrote: > One might want to check which IOMMU version the host kernel > provide. Add a trace event to see in which mode we opened > our container. > > Reviewed-by: Cornelia Huck > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auge

Re: [PATCH] hw/vfio/common: Trace in which mode a IOMMU is opened

2020-05-27 Thread Auger Eric
Hi Philippe, On 5/26/20 7:35 PM, Philippe Mathieu-Daudé wrote: > One might want to check which IOMMU version the host kernel > provide. Add a trace event to see in which mode we opened > our container. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/vfio/common.c | 19 ++---

Re: [PATCH v2 2/3] arm/acpi: TPM2 ACPI table support

2020-05-12 Thread Auger Eric
Hi Igor, On 5/12/20 4:27 PM, Igor Mammedov wrote: > On Tue, 5 May 2020 16:44:18 +0200 > Eric Auger wrote: > >> Add a TPM2 ACPI table if a TPM2.0 sysbus device has been >> dynamically instantiated. >> >> Signed-off-by: Eric Auger > > on x86 we also do: > > fw_cfg_add_file(x86ms->fw_cfg, ACP

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-12 Thread Auger Eric
Hi Igor, On 5/12/20 4:14 PM, Igor Mammedov wrote: > On Wed, 6 May 2020 05:58:25 -0400 > "Michael S. Tsirkin" wrote: > >> On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: >>> I realize this function is just getting moved, but maybe it should get >>> converted to the build_append* API

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-12 Thread Auger Eric
Hi Igor, On 5/12/20 4:10 PM, Igor Mammedov wrote: > On Wed, 6 May 2020 11:50:09 +0200 > Auger Eric wrote: > >> Hi, >> >> On 5/6/20 8:33 AM, Andrew Jones wrote: >>> On Tue, May 05, 2020 at 04:44:17PM +0200, Eric Auger wrote: >>>> We plan to build

Re: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-11 Thread Auger Eric
Hi Bharat, On 5/12/20 5:03 AM, Bharat Bhushan wrote: > Hi Eric, > >> -Original Message----- >> From: Auger Eric >> Sent: Monday, May 11, 2020 2:19 PM >> To: Bharat Bhushan ; eric.auger@gmail.com; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; peter.ma

Re: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-11 Thread Auger Eric
Hi Bharat, On 5/11/20 10:42 AM, Bharat Bhushan wrote: > Hi Eric, > >> -Original Message----- >> From: Auger Eric >> Sent: Monday, May 11, 2020 12:26 PM >> To: Bharat Bhushan ; eric.auger@gmail.com; >> qemu-devel@nongnu.org; qemu-...@nongnu

Re: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-10 Thread Auger Eric
Hi Bharat, On 5/11/20 8:38 AM, Bharat Bhushan wrote: > Hi Eric, > >> -Original Message- >> From: Eric Auger >> Sent: Friday, May 8, 2020 11:01 PM >> To: eric.auger@gmail.com; eric.au...@redhat.com; qemu-devel@nongnu.org; >> qemu-...@nongnu.org; peter.mayd...@linaro.org; m...@redhat.co

Re: [PATCH 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-08 Thread Auger Eric
Hi Jean, On 5/8/20 11:26 AM, Jean-Philippe Brucker wrote: > On Thu, May 07, 2020 at 04:31:58PM +0200, Eric Auger wrote: >> +static ssize_t virtio_iommu_fill_resv_mem_prop(VirtIOIOMMU *s, uint32_t ep, >> + uint8_t *buf, size_t free) >> +{ >> +struct

Re: [PATCH 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

2020-05-08 Thread Auger Eric
Hi Jean-Philippe, On 5/8/20 10:21 AM, Jean-Philippe Brucker wrote: > On Thu, May 07, 2020 at 04:32:01PM +0200, Eric Auger wrote: >> At the moment the virtio-iommu translates MSI transactions. >> This behavior is inherited from ARM SMMU. The virt machine >> code knows where the guest MSI doorbells

Re: [PATCH 3/5] virtio-iommu: Handle reserved regions in the translation process

2020-05-07 Thread Auger Eric
Hi Peter, On 5/7/20 9:47 PM, Peter Xu wrote: > Hi, Eric, > > On Thu, May 07, 2020 at 04:31:59PM +0200, Eric Auger wrote: >> @@ -640,6 +641,24 @@ static IOMMUTLBEntry >> virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, >> goto unlock; >> } >> >> +for (i = 0; i < s->n

Re: [PATCH 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-07 Thread Auger Eric
Hi Peter, On 5/7/20 9:40 PM, Peter Xu wrote: > Hi, Eric, > > On Thu, May 07, 2020 at 04:31:58PM +0200, Eric Auger wrote: > > [...] > >> @@ -452,17 +520,33 @@ static void virtio_iommu_handle_command(VirtIODevice >> *vdev, VirtQueue *vq) >> case VIRTIO_IOMMU_T_UNMAP: >> tail

Re: [PATCH v9 8/9] virtio-iommu: Implement probe request

2020-05-07 Thread Auger Eric
Hi Bharat, On 5/5/20 11:06 AM, Bharat Bhushan wrote: > On Fri, Apr 24, 2020 at 7:22 PM Auger Eric wrote: >> >> Hi Bharat, >> On 4/23/20 6:09 PM, Jean-Philippe Brucker wrote: >>> Hi Bharat, >>> >>> A few more things found while rebasing >>

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-07 Thread Auger Eric
Hi Bharat, On 5/5/20 12:18 PM, Bharat Bhushan wrote: > Hi Eric, > > On Tue, May 5, 2020 at 3:16 PM Bharat Bhushan wrote: >> >> hi Eric, >> >> On Tue, May 5, 2020 at 3:00 PM Auger Eric wrote: >>> >>> Hi Bharat, >>> >>> On

Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part

2020-05-06 Thread Auger Eric
Hi, On 5/6/20 8:33 AM, Andrew Jones wrote: > On Tue, May 05, 2020 at 04:44:17PM +0200, Eric Auger wrote: >> We plan to build the tpm2 table on ARM too. In order to reuse the >> generation code, let's move build_tpm2() to aml-build.c. >> >> No change in the implementation. >> >> Signed-off-by: Eric

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Auger Eric
Hi Bharat, On 5/5/20 12:18 PM, Bharat Bhushan wrote: > Hi Eric, > > On Tue, May 5, 2020 at 3:16 PM Bharat Bhushan wrote: >> >> hi Eric, >> >> On Tue, May 5, 2020 at 3:00 PM Auger Eric wrote: >>> >>> Hi Bharat, >>> >>> On

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Auger Eric
Hi Bharat, On 5/5/20 11:25 AM, Bharat Bhushan wrote: > Hi Eric, > > On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: >> >> Hi Bharat, >> >> On 4/2/20 11:01 AM, Bharat Bhushan wrote: >>> Hi Eric/Alex, >>> >>>> -Original Message

Re: [PATCH v4 0/7] ARM virt: Add NVDIMM support

2020-05-04 Thread Auger Eric
Hi, On 5/4/20 11:29 AM, Peter Maydell wrote: > On Mon, 4 May 2020 at 06:13, Michael S. Tsirkin wrote: >> >> On Tue, Apr 21, 2020 at 01:59:27PM +0100, Shameer Kolothum wrote: >>> This series adds NVDIMM support to arm/virt platform. >>> The series reuses some of the patches posted by Eric >>> in h

Re: [PATCH 0/2] virt: Set tpm-tis-device ppi property to off by default

2020-04-28 Thread Auger Eric
Hi Stefan, On 4/27/20 10:21 PM, Stefan Berger wrote: > On 4/27/20 10:31 AM, Eric Auger wrote: >> Instead of using a compat in the mach-virt machine to force >> PPI off for all virt machines (PPI not supported by the >> tpm-tis-device device), let's simply change the default value >> in the sysbus

Re: [PATCH] hw: add compat machines for 5.1

2020-04-27 Thread Auger Eric
Hi Connie, On 4/27/20 11:06 AM, Cornelia Huck wrote: > On Mon, 27 Apr 2020 09:43:33 +0200 > Auger Eric wrote: > >> Hi Connie, >> >> On 4/24/20 11:03 AM, Cornelia Huck wrote: >>> Add 5.1 machine types for arm/i440fx/q35/s390x/spapr. >>> >>&g

Re: [PATCH] hw: add compat machines for 5.1

2020-04-27 Thread Auger Eric
Hi Connie, On 4/24/20 11:03 AM, Cornelia Huck wrote: > Add 5.1 machine types for arm/i440fx/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > > Still keeping the default cpu model version on x86 at v1. > > I'll queue this to my s390-next branch, as I'm planning to send a pull > req as

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-04-24 Thread Auger Eric
Hi Bharat, On 4/2/20 11:01 AM, Bharat Bhushan wrote: > Hi Eric/Alex, > >> -Original Message- >> From: Alex Williamson >> Sent: Thursday, March 26, 2020 11:23 PM >> To: Auger Eric >> Cc: Bharat Bhushan ; peter.mayd...@linaro.org; >> pet...@red

Re: [PATCH v9 8/9] virtio-iommu: Implement probe request

2020-04-24 Thread Auger Eric
Hi Bharat, On 4/23/20 6:09 PM, Jean-Philippe Brucker wrote: > Hi Bharat, > > A few more things found while rebasing > > On Mon, Mar 23, 2020 at 02:16:16PM +0530, Bharat Bhushan wrote: >> This patch implements the PROBE request. Currently supported >> page size mask per endpoint is returned. Also

Re: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext

2020-04-06 Thread Auger Eric
Hi Yi, On 4/6/20 10:04 AM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric < eric.au...@redhat.com> >> Sent: Tuesday, March 31, 2020 1:23 AM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> Subject: Re: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext >

Re: [PATCH v2 09/22] vfio/common: init HostIOMMUContext per-container

2020-04-06 Thread Auger Eric
Hi Yi, On 4/6/20 9:12 AM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Wednesday, April 1, 2020 3:51 PM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> Subject: Re: [PATCH v2 09/22] vfio/common: init HostIOMMUContext >> per-container >> &g

Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2020-04-06 Thread Auger Eric
Yi, On 4/6/20 8:27 AM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Thursday, April 2, 2020 9:49 PM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> Subject: Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set >> PCIIOMMUOps >> &g

Re: [RFC v6 00/24] vSMMUv3/pSMMUv3 2 stage VFIO integration

2020-04-03 Thread Auger Eric
Hi Shameer, On 3/25/20 12:35 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Eric Auger [mailto:eric.au...@redhat.com] >> Sent: 20 March 2020 16:58 >> To: eric.auger@gmail.com; eric.au...@redhat.com; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; peter

Re: [PATCH kvm-unit-tests] fixup! arm/arm64: ITS: pending table migration test

2020-04-03 Thread Auger Eric
Hi Drew, On 4/3/20 9:37 AM, Andrew Jones wrote: > On Fri, Apr 03, 2020 at 07:07:10AM +0200, Auger Eric wrote: >> Hi Drew, >> >> On 4/2/20 8:01 PM, Andrew Jones wrote: >>> [ Without the fix this test would hang, as timeouts don't work with >>> the

Re: [PATCH kvm-unit-tests] fixup! arm/arm64: ITS: pending table migration test

2020-04-02 Thread Auger Eric
Hi Drew, On 4/2/20 8:01 PM, Andrew Jones wrote: > [ Without the fix this test would hang, as timeouts don't work with > the migration scripts (yet). Use errata to skip instead of hang. ] > Signed-off-by: Andrew Jones > --- > arm/gic.c | 18 -- > errata.txt | 1 + > 2 files ch

Re: [RFC v6 00/24] vSMMUv3/pSMMUv3 2 stage VFIO integration

2020-04-02 Thread Auger Eric
Hi Zhangfei, On 3/31/20 10:24 AM, Zhangfei Gao wrote: > Hi, Eric > > On 2020/3/31 下午4:12, Auger Eric wrote: >> Hi Zhangfei, >> >> On 3/31/20 8:42 AM, Zhangfei Gao wrote: >>> Hi, Eric >>> >>> On 2020/3/21 上午12:58, Eric Auger wrote: >>

Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2020-04-02 Thread Auger Eric
Hi Yi, On 4/2/20 3:37 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric < eric.au...@redhat.com > >> Sent: Thursday, April 2, 2020 8:41 PM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> Subject: Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set &g

Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2020-04-02 Thread Auger Eric
Hi Yi, On 4/2/20 10:52 AM, Liu, Yi L wrote: >> From: Auger Eric < eric.au...@redhat.com> >> Sent: Monday, March 30, 2020 7:02 PM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> Subject: Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set >> PCIIOMMUOps &g

Re: [kvm-unit-tests PATCH v7 10/13] arm/arm64: ITS: INT functional tests

2020-04-02 Thread Auger Eric
Hi Zenghui, On 3/30/20 12:43 PM, Zenghui Yu wrote: > Hi Eric, > > On 2020/3/20 17:24, Eric Auger wrote: >> Triggers LPIs through the INT command. >> >> the test checks the LPI hits the right CPU and triggers >> the right LPI intid, ie. the translation is correct. >> >> Updates to the config table

Re: [PATCH v2 09/22] vfio/common: init HostIOMMUContext per-container

2020-04-01 Thread Auger Eric
Hi Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > In this patch, QEMU firstly gets iommu info from kernel to check the > supported capabilities by a VFIO_IOMMU_TYPE1_NESTING iommu. And inits > HostIOMMUContet instance. > > Cc: Kevin Tian > Cc: Jacob Pan > Cc: Peter Xu > Cc: Eric Auger > Cc: Yi Sun

Re: [PATCH v2 10/22] vfio/pci: set host iommu context to vIOMMU

2020-03-31 Thread Auger Eric
Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > For vfio-pci devices, it could use pci_device_set/unset_iommu() to > expose host iommu context to vIOMMU emulators. vIOMMU emulators > could make use the methods provided by host iommu context. e.g. > propagate requests to host iommu. I think I would squas

Re: [PATCH v2 07/22] intel_iommu: add set/unset_iommu_context callback

2020-03-31 Thread Auger Eric
Hi Yi, On 3/31/20 2:25 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric < eric.au...@redhat.com> >> Sent: Tuesday, March 31, 2020 4:24 AM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> Subject: Re: [PATCH v2 07/22] intel_iommu: add set/unset_iommu_context

Re: [PATCH v2 08/22] vfio/common: provide PASID alloc/free hooks

2020-03-31 Thread Auger Eric
Hi Yi, On 3/31/20 12:59 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Tuesday, March 31, 2020 6:48 PM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> alex.william...@redhat.com; pet...@redhat.com >> Cc: pbonz...@redhat.com; m...@redhat.co

Re: [PATCH v2 08/22] vfio/common: provide PASID alloc/free hooks

2020-03-31 Thread Auger Eric
Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > This patch defines vfio_host_iommu_context_info, implements the PASID > alloc/free hooks defined in HostIOMMUContextClass. > > Cc: Kevin Tian > Cc: Jacob Pan > Cc: Peter Xu > Cc: Eric Auger > Cc: Yi Sun > Cc: David Gibson > Cc: Alex Williamson > Si

Re: [RFC v6 00/24] vSMMUv3/pSMMUv3 2 stage VFIO integration

2020-03-31 Thread Auger Eric
Hi Zhangfei, On 3/31/20 8:42 AM, Zhangfei Gao wrote: > Hi, Eric > > On 2020/3/21 上午12:58, Eric Auger wrote: >> Up to now vSMMUv3 has not been integrated with VFIO. VFIO >> integration requires to program the physical IOMMU consistently >> with the guest mappings. However, as opposed to VTD, SMMUv

Re: [RFC v6 09/24] vfio: Force nested if iommu requires it

2020-03-31 Thread Auger Eric
Yi, On 3/31/20 8:34 AM, Liu, Yi L wrote: > Hi Eric, > >> From: Eric Auger >> Sent: Saturday, March 21, 2020 12:58 AM >> To: eric.auger@gmail.com; eric.au...@redhat.com; qemu-devel@nongnu.org; >> Subject: [RFC v6 09/24] vfio: Force nested if iommu requires it >> >> In case we detect the addre

Re: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext

2020-03-31 Thread Auger Eric
Yi, On 3/31/20 6:10 AM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric < eric.au...@redhat.com > >> Sent: Tuesday, March 31, 2020 1:23 AM >> To: Liu, Yi L ; qemu-devel@nongnu.org; >> Subject: Re: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext >&g

Re: [PATCH v2 07/22] intel_iommu: add set/unset_iommu_context callback

2020-03-30 Thread Auger Eric
Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > This patch adds set/unset_iommu_context() impelementation in Intel This patch implements the set/unset_iommu_context() ops for Intel vIOMMU. > vIOMMU. For Intel platform, pass-through modules (e.g. VFIO) could > set HostIOMMUContext to Intel vIOMMU emulato

Re: [PATCH v2 06/22] hw/pci: introduce pci_device_set/unset_iommu_context()

2020-03-30 Thread Auger Eric
Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > This patch adds pci_device_set/unset_iommu_context() to set/unset > host_iommu_context for a given device. New callback is added in > PCIIOMMUOps. As such, vIOMMU could make use of host IOMMU capability. > e.g setup nested translation. I think you need to

Re: [PATCH v2 04/22] hw/iommu: introduce HostIOMMUContext

2020-03-30 Thread Auger Eric
Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > Currently, many platform vendors provide the capability of dual stage > DMA address translation in hardware. For example, nested translation > on Intel VT-d scalable mode, nested stage translation on ARM SMMUv3, > and etc. In dual stage DMA address transla

Re: [kvm-unit-tests PATCH v7 13/13] arm/arm64: ITS: pending table migration test

2020-03-30 Thread Auger Eric
Hi Zenghui, On 3/30/20 2:06 PM, Zenghui Yu wrote: > Hi Eric, > > On 2020/3/20 17:24, Eric Auger wrote: >> Add two new migration tests. One testing the migration of >> a topology where collection were unmapped. The second test >> checks the migration of the pending table. >> >> Signed-off-by: Eric

Re: [PATCH v2 05/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2020-03-30 Thread Auger Eric
On 3/30/20 6:24 AM, Liu Yi L wrote: > This patch modifies pci_setup_iommu() to set PCIIOMMUOps > instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to > get an address space for a PCI device in vendor specific > way. The PCIIOMMUOps still offers this functionality. But > using PCIIOMMUOps lea

Re: [PATCH v2 00/22] intel_iommu: expose Shared Virtual Addressing to VMs

2020-03-30 Thread Auger Eric
Hi Yi, On 3/30/20 6:24 AM, Liu Yi L wrote: > Shared Virtual Addressing (SVA), a.k.a, Shared Virtual Memory (SVM) on > Intel platforms allows address space sharing between device DMA and > applications. SVA can reduce programming complexity and enhance security. > > This QEMU series is intended to

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Auger Eric
Hi Drew, On 3/30/20 12:19 PM, Andrew Jones wrote: > On Mon, Mar 30, 2020 at 11:56:00AM +0200, Auger Eric wrote: >> Hi, >> >> On 3/30/20 11:11 AM, Andrew Jones wrote: >>> On Mon, Mar 30, 2020 at 10:46:57AM +0200, Auger Eric wrote: >>>> Hi Zenghui, >&

Re: [kvm-unit-tests PATCH v7 09/13] arm/arm64: ITS: Commands

2020-03-30 Thread Auger Eric
Hi Zenghui, On 3/30/20 11:22 AM, Zenghui Yu wrote: > Hi Eric, > > On 2020/3/20 17:24, Eric Auger wrote: >> Implement main ITS commands. The code is largely inherited from >> the ITS driver. >> >> Signed-off-by: Eric Auger > > [...] > >> +/* ITS COMMANDS */ >> + >> +static void its_encode_cmd(s

Re: [kvm-unit-tests PATCH v7 06/13] arm/arm64: ITS: Introspection tests

2020-03-30 Thread Auger Eric
Hi, On 3/30/20 11:11 AM, Andrew Jones wrote: > On Mon, Mar 30, 2020 at 10:46:57AM +0200, Auger Eric wrote: >> Hi Zenghui, >> >> On 3/30/20 10:30 AM, Zenghui Yu wrote: >>> Hi Eric, >>> >>> On 2020/3/20 17:24, Eric Auger wrote: >>>> +sta

<    1   2   3   4   5   6   7   8   9   10   >