Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header

On Fri, May 04, 2018 at 05:52:39PM +0300, Michael S. Tsirkin wrote: > On Fri, May 04, 2018 at 10:29:24AM +0100, Daniel P. Berrangé wrote: > > On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote: > > > This way it is easier to find using standard rules. >

[Qemu-devel] [PATCH 2/3] glib: bump min required glib library version to 2.42

that a minimum glib of 2.42 is a reasonable target Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- configure | 6 +- include/glib-compat.h | 319 tests/test-qmp-event.c | 2 +- tests/tpm-emu.h | 4 +- tests

[Qemu-devel] [PATCH 1/3] qemu-doc: provide details of supported build platforms

environments to match the intended supported build platforms. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- qemu-doc.texi | 68 +++ 1 file changed, 68 insertions(+) diff --git a/qemu-doc.texi b/qemu-doc.texi index 5813

[Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version and warn about old APIs

to temporarily turn off the -Wdeprecated-declarations compiler warning, while a static inline compat function is implemented. Nothing needs that at this time, so just illustrate it in a comment for benefit of future changes. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- includ

[Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42

sion. This would do a much better job of catching mistakes than our min-glib docker job, making that obsolete. Daniel P. Berrangé (3): qemu-doc: provide details of supported build platforms glib: bump min required glib library version to 2.42 glib: enforce the minimum required version and warn about

Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42

On Fri, May 04, 2018 at 09:40:06PM +0200, Olaf Hering wrote: > Am Fri, 4 May 2018 17:00:23 +0100 > schrieb Daniel P. Berrangé <berra...@redhat.com>: > > > - I suggested following libvirt's lead in writing a policy for how > > we pick supported OS targets to

Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42

CC'ing xen-devel in case Xen maintainers have a need for something that will that conflict with this proposal wrt supported build platforms. On Fri, May 04, 2018 at 05:00:23PM +0100, Daniel P. Berrangé wrote: > This short series is a followup the discussions around min glib version > whe

Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header

On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote: > This way it is easier to find using standard rules. > > Signed-off-by: Michael S. Tsirkin > --- > include/replication.h | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 include/replication.h > >

Re: [Qemu-devel] [PATCH 01/67] block: use local path for local headers

On Thu, May 03, 2018 at 10:50:20PM +0300, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. This commit

Re: [Qemu-devel] Requiring Python 2.7+ (was Re: [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42)

On Fri, May 11, 2018 at 07:48:23PM -0300, Eduardo Habkost wrote: > On Fri, May 04, 2018 at 05:00:23PM +0100, Daniel P. Berrangé wrote: > [...] > > Based on that doc and https://repology.org/metapackage/glib/versions, > > I identified that we could feasibly set min

Re: [Qemu-devel] [PULL 15/30] opts: don't silently truncate long option values

On Mon, May 14, 2018 at 05:19:04PM +0100, Peter Maydell wrote: > On 8 May 2018 at 23:14, Paolo Bonzini <pbonz...@redhat.com> wrote: > > From: Daniel P. Berrangé <berra...@redhat.com> > > > > The existing QemuOpts parsing code uses a fixed size 1024 byte buffer

[Qemu-devel] [PATCH 1/3] i386: fix regression parsing multiboot initrd modules

The logic for parsing the multiboot initrd modules was messed up in commit 950c4e6c94b15cd0d8b638917a8dbf458e6a Author: Daniel P. Berrangé <berra...@redhat.com> Date: Mon Apr 16 12:17:43 2018 +0100 opts: don't silently truncate long option values Causing the

[Qemu-devel] [PATCH 2/3] i386: only parse the initrd_filename once for multiboot modules

() method which means it can safely assume a non-NULL param. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- hw/i386/multiboot.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c

[Qemu-devel] [PATCH 0/3] i386: fix handling of multiboot modules

This short series fixes a flaw identified by coverity which broke the handling of multiboot modules. Daniel P. Berrangé (3): i386: fix regression parsing multiboot initrd modules i386: only parse the initrd_filename once for multiboot modules opts: remove redundant check for NULL parameter

[Qemu-devel] [PATCH 3/3] opts: remove redundant check for NULL parameter

No callers of get_opt_value() pass in a NULL for the "value" parameter, so the check is redundant. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- util/qemu-option.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/util/qemu-opti

Re: [Qemu-devel] [PATCH v2 3/5] migration: remove unnecessary variables len in QIOChannelRDMA

On Thu, Apr 26, 2018 at 05:40:11PM +0100, Dr. David Alan Gilbert wrote: > * Lidong Chen (jemmy858...@gmail.com) wrote: > > Because qio_channel_rdma_writev and qio_channel_rdma_readv maybe invoked > > by different threads concurrently, this patch removes unnecessary variables > > len in

Re: [Qemu-devel] Who is running QEMU automated tests, and when?

On Fri, Apr 27, 2018 at 05:58:44AM +0200, Thomas Huth wrote: > On 26.04.2018 16:24, Daniel P. Berrangé wrote: > > On Thu, Apr 26, 2018 at 11:22:36AM -0300, Eduardo Habkost wrote: > >> On Thu, Apr 26, 2018 at 03:14:00PM +0100, Daniel P. Berrangé wrote: > >>> On Thu, Ap

Re: [Qemu-devel] [PATCH v2 3/5] migration: remove unnecessary variables len in QIOChannelRDMA

-off-by: Lidong Chen <lidongc...@tencent.com> > --- > migration/rdma.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.fli

Re: [Qemu-devel] [PATCH v2 4/5] migration: implement bi-directional RDMA QIOChannel

On Fri, Apr 27, 2018 at 03:56:38PM +0800, 858585 jemmy wrote: > On Fri, Apr 27, 2018 at 1:36 AM, Dr. David Alan Gilbert > wrote: > > * Lidong Chen (jemmy858...@gmail.com) wrote: > >> This patch implements bi-directional RDMA QIOChannel. Because different > >> threads may

Re: [Qemu-devel] POD document had syntax errors at /usr/bin/pod2man line 68.

On Fri, Apr 27, 2018 at 08:52:53AM -0500, Eric Blake wrote: > On 04/27/2018 03:47 AM, Rahul Gusai wrote: > > I am getting the following error while trying to compile the binaries for > > QEMU emulator. > > > > Your mailer corrupted line spacing, making it difficult to read. > > > *GEN

Re: [Qemu-devel] [PATCH 04/13] qapi: Formalize qcow2 encryption probing

On Wed, May 09, 2018 at 06:55:21PM +0200, Max Reitz wrote: > Currently, you can give no encryption format for a qcow2 file while > still passing a key-secret. That does not conform to the schema, so > this patch changes the schema to allow it. > > Signed-off-by: Max Reitz >

Re: [Qemu-devel] [PATCH 05/13] qapi: Formalize qcow encryption probing

On Thu, May 10, 2018 at 09:24:24AM -0500, Eric Blake wrote: > On 05/09/2018 11:55 AM, Max Reitz wrote: > > Currently, you can give no encryption format for a qcow file while still > > passing a key-secret. That does not conform to the schema, so this > > patch changes the schema to allow it. > >

Re: [Qemu-devel] [PULL 00/30] Misc patches for 2018-05-09

On Fri, May 11, 2018 at 01:19:51PM +0100, Peter Maydell wrote: > On 8 May 2018 at 23:14, Paolo Bonzini wrote: > > The following changes since commit cc8f8ba754bba17eea9791d67b572eb26e30b4ce: > > > > Merge remote-tracking branch > >

Re: [Qemu-devel] [PULL 00/30] Misc patches for 2018-05-09

On Fri, May 11, 2018 at 01:50:28PM +0100, Peter Maydell wrote: > On 11 May 2018 at 13:42, Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Fri, May 11, 2018 at 01:19:51PM +0100, Peter Maydell wrote: > >> Some of my build setups barf on the new glib version requ

Re: [Qemu-devel] Outreachy intro: micro:bit project

On Fri, May 11, 2018 at 05:13:31PM +0100, Stefan Hajnoczi wrote: > On Thu, May 10, 2018 at 11:19 PM, Julia Suvorova wrote: > > My name is Julia. I am a bachelor of mathematics from Moscow who is > > interested in system programming. I've been selected for Outreachy this > > year

Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers

On Fri, May 11, 2018 at 08:23:22PM +0300, Michael S. Tsirkin wrote: > On Tue, May 08, 2018 at 02:25:07PM +0200, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > This way they are easier to find using standard rules. > > > > > > Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 1/1] sandbox: avoid to compile options if CONFIG_SECCOMP undefined

On Mon, May 07, 2018 at 01:04:17PM -0500, Eric Blake wrote: > On 05/06/2018 10:32 PM, Yi Min Zhao wrote: > > In the subject line: s/avoid to compile/avoid compiling/ > > > If CONFIG_SECCOMP is undefined, the option 'elevatorprivileges' remains > > s/elevator/elevate/ > > > complied. This would

Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42

On Sat, May 05, 2018 at 12:05:10AM +0200, Paolo Bonzini wrote: > On 04/05/2018 18:00, Daniel P. Berrangé wrote: > > Based on that doc and https://repology.org/metapackage/glib/versions, > > I identified that we could feasibly set min glib to 2.42. Note that > > this wou

Re: [Qemu-devel] tpm_emu_test_wait_cond: code should not be reached

On Tue, May 08, 2018 at 09:41:05AM -0300, Philippe Mathieu-Daudé wrote: > Hi, > > Travis CI hit this error testing commit 853f8ca13cd6d256: > > $ clang --version > Apple LLVM version 8.1.0 (clang-802.0.42) > Target: x86_64-apple-darwin16.7.0 > > $ ./configure > C compilerclang > host

Re: [Qemu-devel] [Xen-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42

On Tue, May 08, 2018 at 03:50:49PM +0100, George Dunlap wrote: > On Fri, May 4, 2018 at 10:00 PM, Daniel P. Berrangé <berra...@redhat.com> > wrote: > > CC'ing xen-devel in case Xen maintainers have a need for something that > > will that conflict with this proposal wrt s

Re: [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version and warn about old APIs

On Tue, May 08, 2018 at 05:17:40PM +0200, Paolo Bonzini wrote: > On 04/05/2018 18:00, Daniel P. Berrangé wrote: > > There are two useful macros that can be defined before including > > glib.h that are related to the min required glib version > > > > - GLIB_VERSION_MI

Re: [Qemu-devel] [PATCH] tests: fix tpm-crb tpm-tis tests race

n the TPM data thread. > > Reported-by: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Signed-off-by: Stefan Berger <stef...@linux.vnet.ibm.com> > --- > tests/tpm-emu.c | 2 +- > 1 file changed, 1 inserti

Re: [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version and warn about old APIs

On Tue, May 08, 2018 at 06:02:55PM +0200, Paolo Bonzini wrote: > On 08/05/2018 17:19, Daniel P. Berrangé wrote: > > Ok, that change looks fine with me assuming it passes your build tests. > > In fact that is what I had done in an earlier version. > > > > Regard

Re: [Qemu-devel] tpm_emu_test_wait_cond: code should not be reached

On Tue, May 08, 2018 at 02:54:39PM +0100, Peter Maydell wrote: > On 8 May 2018 at 14:48, Daniel P. Berrangé <berra...@redhat.com> wrote: > > This test has a couple of threads running, and passes _abort to > > the qio_channel_socket_readv() function. So I expect that one

Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

On Thu, May 17, 2018 at 02:39:42PM +0200, Paolo Bonzini wrote: > x_keymap.o is common to the SDL and GTK+ modules, and it causes the > QEMU binary to link to the X11 libraries. Add it separately to the > modules to keep the main QEMU binary smaller. > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

On Thu, May 17, 2018 at 02:50:04PM +0200, Paolo Bonzini wrote: > On 17/05/2018 14:44, Daniel P. Berrangé wrote: > >> +ifeq ($(CONFIG_X11),y) > >> +sdl.mo-objs += x_keymap.o > >> +gtk.mo-objs += x_keymap.o > > Would this cause symbol clash if both sdl & gtk

Re: [Qemu-devel] [PATCH] ui: add x_keymap.o to modules

On Thu, May 17, 2018 at 02:51:10PM +0200, Gerd Hoffmann wrote: > Hi, > > > > +ifeq ($(CONFIG_X11),y) > > > +sdl.mo-objs += x_keymap.o > > > +gtk.mo-objs += x_keymap.o > > > > Would this cause symbol clash if both sdl & gtk modules are loaded > > at the same time, or have we used linker scripts

Re: [Qemu-devel] [PATCH] Delete AF_UNIX socket after close

On Mon, May 21, 2018 at 02:10:18PM +0300, Pavel Balaev wrote: > Hello, > > Since version 2.12.0 AF_UNIX socket created for QMP exchange is not > deleted on instance shutdown. > > This is due to the fact that function qio_channel_socket_finalize() is > called after qio_channel_socket_close().

Re: [Qemu-devel] storing machine data in qcow images?

On Mon, May 21, 2018 at 03:29:28PM -0300, Eduardo Habkost wrote: > On Sat, May 19, 2018 at 08:05:06AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > [...] > > > About being more expressive than just a single list of key,value > > > pairs, I don't see any

Re: [Qemu-devel] storing machine data in qcow images?

On Fri, May 18, 2018 at 02:41:33PM -0300, Eduardo Habkost wrote: > On Fri, May 18, 2018 at 06:09:56PM +0100, Daniel P. Berrangé wrote: > > On Fri, May 18, 2018 at 06:30:38PM +0300, Michael S. Tsirkin wrote: > > > Hi! > > > Right now, QEMU supports multiple machine

[Qemu-devel] [PATCH 3/3] i386: Define the Virt SSBD MSR and handling of it (CVE-2018-3639)

x86/speculation: Add virtualized speculative store bypass disable support in Linux). Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- target/i386/cp

[Qemu-devel] [PATCH 2/3] i386: define the AMD 'virt-ssbd' CPUID feature bit (CVE-2018-3639)

k Wilk <konrad.w...@oracle.com> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index a1185

[Qemu-devel] [PATCH 0/3] i386: speculative store buffer bypass mitigation (CVE-2018-3639)

=3b78ce4a34b761c7fe13520de822984019ff1a8f [1] https://bugs.chromium.org/p/project-zero/issues/detail?id=1528 https://access.redhat.com/security/vulnerabilities/ssbd Daniel P. Berrangé (1): i386: define the 'ssbd' CPUID feature bit (CVE-2018-3639) Konrad Rzeszutek Wilk (2): i386: define the AMD 'virt-ssbd' CPUID feature bit

[Qemu-devel] [PATCH 1/3] i386: define the 'ssbd' CPUID feature bit (CVE-2018-3639)

New microcode introduces the "Speculative Store Bypass Disable" CPUID feature bit. This needs to be exposed to guest OS to allow them to protect against CVE-2018-3639. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@ora

Re: [Qemu-devel] storing machine data in qcow images?

On Fri, May 18, 2018 at 06:30:38PM +0300, Michael S. Tsirkin wrote: > Hi! > Right now, QEMU supports multiple machine types within > a given architecture. This was the case for many architectures > (like ARM) for a while, somewhat more recently this is the case > for x86 with I440FX and Q35

Re: [Qemu-devel] [PATCH 2/2] gtk: disable the F10 menubar key

On Tue, May 15, 2018 at 10:30:09AM +0200, Gerd Hoffmann wrote: > On Fri, May 11, 2018 at 01:07:39AM +0200, Peter Wu wrote: > > The F10 key is used in various applications, disable it unconditionally > > (do not limit it to grab mode). Note that this property is deprecated > > and might be removed

Re: [Qemu-devel] [PATCH 1/3] i386: fix regression parsing multiboot initrd modules

On Fri, May 18, 2018 at 06:54:48PM +0100, Peter Maydell wrote: > On 14 May 2018 at 18:19, Daniel P. Berrangé <berra...@redhat.com> wrote: > > The logic for parsing the multiboot initrd modules was messed up in > > > > commit 950c4e6c94b15cd0d8b638917a8dbf45

Re: [Qemu-devel] [RFC] monitor: turn on Out-Of-Band by default again

On Mon, May 21, 2018 at 04:42:49PM +0800, Peter Xu wrote: > We turned Out-Of-Band feature of monitors off for 2.12 release. Now we > try to turn that on again. > > Signed-off-by: Peter Xu > -- > Now OOB should be okay with all known tests (except iotest qcow2, since > it is

Re: [Qemu-devel] storing machine data in qcow images?

On Wed, Jun 06, 2018 at 12:42:28PM +0100, Richard W.M. Jones wrote: > On Wed, Jun 06, 2018 at 12:14:07PM +0100, Dr. David Alan Gilbert wrote: > > The problem with having a separate file is that you either have to copy > > it around with the image or have an archive. If you have an archive > > you

Re: [Qemu-devel] 100% host cpu with gtk3

On Wed, Jun 06, 2018 at 06:43:57PM +0800, Fam Zheng wrote: > Hi Gerd, > > When using the gtk frontend, it seems there is a busy loop in libgtk > repeatedly > calling recvmsg, causing 100% cpu on the main thread. This started to appear > after I upgraded to Fedora 28. Is this a known problem? >

Re: [Qemu-devel] storing machine data in qcow images?

On Wed, Jun 06, 2018 at 03:45:10PM +0200, Michal Suchánek wrote: > > I think that *if* we want an 'appliance' format that stores a whole VM > in a single file to ease VM distribution then the logical place to look > in qemu is qcow. The reason have been explained at length. I rather disagree.

Re: [Qemu-devel] [PATCH] Remove COPYING.PYTHON

removed, and we are > not carrying any code under that license anymore. Remove > COPYING.PYTHON. > > Signed-off-by: Eduardo Habkost > --- > COPYING.PYTHON | 270 - > 1 file changed, 270 deletions(-) > delete mode 10064

Re: [Qemu-devel] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing

--- > qapi/block-core.json | 44 > block/qcow2.c| 3 +++ > 2 files changed, 43 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/p

Re: [Qemu-devel] [PATCH v2 05/10] qapi: Formalize qcow encryption probing

changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-http

[Qemu-devel] [PATCH] travis: display config.log when configure fails

When configure fails in CI systems we must be able to see the contents of the config.log file to diagnose the root cause. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 814be151f4

Re: [Qemu-devel] KVM Forum 2018: Call For Participation

A friendly reminder that the deadline for abstract submission is end of day this Thursday, June 14th. On Thu, May 17, 2018 at 12:52:35PM +0200, Paolo Bonzini wrote: > > KVM Forum 2018: Call For Participation > October 24-26, 2018 -

Re: [Qemu-devel] [PATCH v2 10/10] iotests: qcow2's encrypt.format is now optional

reasonably fast. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/087 | 65 +++--- > tests/qemu-iotests/087.out | 26 ++- > 2 files changed, 64 insertions(+), 27 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, D

Re: [Qemu-devel] [PATCH v3 5/7] hmp: Add info commands for preconfig

On Mon, Jun 11, 2018 at 11:33:42PM +0200, Igor Mammedov wrote: > On Mon, 11 Jun 2018 15:40:16 -0300 > Eduardo Habkost wrote: > > > On Mon, Jun 11, 2018 at 02:01:52PM +0200, Markus Armbruster wrote: > > > * Eduardo, why does "info numa" have no QMP equivalent? > > > > Nobody ever asked for one,

Re: [Qemu-devel] [RFC v2 04/12] Add vhost-user-backend

On Tue, Jun 12, 2018 at 04:53:54PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Jun 8, 2018 at 10:43 AM, Daniel P. Berrangé > wrote: > > On Fri, Jun 08, 2018 at 12:34:15AM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Mon, Jun 4, 2018

[Qemu-devel] [PATCH v3 0/3] glib: update the min required version

that are redundant given the new min version. Changed in v3: - Use #pragma instead of _Pragma - Move dockerfile deletion to earlier patch - Add missing osdep.h include - Reorder patches to preserve bisectability Daniel P. Berrangé (3): util: remove redundant include of glib.h and add osdep.h

[Qemu-devel] [PATCH 4/8] authz: add QAuthZSimple object type for trivial auth checks

In many cases a single VM will just need to whilelist a single identity as the allowed user of network services. This is especially the case for TLS live migration (optionally with NBD storage) where we just need to whitelist the x509 certificate distinguished name of the source QEMU host.

[Qemu-devel] [PATCH 1/8] util: add helper APIs for dealing with inotify

The inotify userspace API for reading events is quite horrible, so it is useful to wrap it in a more friendly API to avoid duplicating code across many users in QEMU. Signed-off-by: Daniel P. Berrangé --- MAINTAINERS| 6 ++ include/qemu/inotify.h | 49 +++ util

[Qemu-devel] [PATCH v3 1/3] util: remove redundant include of glib.h and add osdep.h

e location of the previous definition # define GLIB_VERSION_MIN_REQUIRED (GLIB_VERSION_CUR_STABLE) Furthermore, the osdep.h include should always be done directly from the .c file rather than indirectly via any .h file. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- in

[Qemu-devel] [PATCH 3/8] authz: add QAuthZ object as an authorization base class

From: "Daniel P. Berrange" The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server)

[Qemu-devel] [PATCH 8/8] authz: delete existing ACL implementation

From: "Daniel P. Berrange" The 'qemu_acl' type was a previous non-QOM based attempt to provide an authorization facility in QEMU. Because it is non-QOM based it cannot be created via the command line and requires special monitor commands to manipulate it. The new QAuthZ subclasses provide a

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote: > We banned use of certain g_assert_FOO() functions outside tests, and > made checkpatch.pl flag them (commit 6e9389563e5). We neglected to > purge existing uses. Do that now. > > Signed-off-by: Markus Armbruster > --- >

[Qemu-devel] [PATCH v3 2/3] glib: bump min required glib library version to 2.40

current LTS releases to be supported. Docker jobs that not longer satisfy this new min version are removed. [1] https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- configure| 6

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > All of the supported build platforms documented in qemu-doc.texi > should already support Python 2.7. > > Removing support for Python 2.6 will allow us to remove some > compatibility modules we carry in the QEMU tree: > > *

[Qemu-devel] [PATCH 5/8] authz: add QAuthZList object type for an access control list

From: "Daniel P. Berrange" Add a QAuthZList object type that implements the QAuthZ interface. This built-in implementation maintains a trivial access control list with a sequence of match rules and a final default policy. This replicates the functionality currently provided by the qemu_acl

[Qemu-devel] [PATCH 7/8] authz: add QAuthZPAM object type for authorizing using PAM

From: "Daniel P. Berrange" Add an authorization backend that talks to PAM to check whether the user identity is allowed. This only uses the PAM account validation facility, which is essentially just a check to see if the provided username is permitted access. It doesn't use the authentication or

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

On Fri, Jun 08, 2018 at 11:37:36AM -0300, Philippe Mathieu-Daudé wrote: > Cc'ing Eric > > On 06/08/2018 11:30 AM, Eduardo Habkost wrote: > > All of the supported build platforms documented in qemu-doc.texi > > should already support Python 2.7. > >

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

On Fri, Jun 08, 2018 at 11:55:59AM -0300, Eduardo Habkost wrote: > On Fri, Jun 08, 2018 at 03:37:47PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote: > > > All of the supported build platforms documented in qemu-doc.texi &g

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer

; --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.c

[Qemu-devel] [PATCH 0/8] Add a standard authorization framework

. A later series that follows will integrate this framework into the VNC, NBD, migration, and character device servers. Daniel P. Berrangé (8): util: add helper APIs for dealing with inotify hw/usb: switch MTP to use new inotify APIs authz: add QAuthZ object as an authorization base class

[Qemu-devel] [PATCH 2/8] hw/usb: switch MTP to use new inotify APIs

The internal inotify APIs allow alot of conditional statements to be cleared out, and provide a simpler callback for handling events. Signed-off-by: Daniel P. Berrangé --- hw/usb/dev-mtp.c | 238 +++ 1 file changed, 97 insertions(+), 141 deletions

[Qemu-devel] [PATCH 6/8] authz: add QAuthZListFile object type for a file access control list

olicy": "allow", "format": "exact" }, ], "policy": "deny" } This sets up an authorization rule that allows 'fred', 'bob' and anyone whose name starts with 'dan', except for 'danb'. Everyone unmatched is denied. The object can be l

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

On Thu, Jun 07, 2018 at 09:50:41AM +0200, Thomas Huth wrote: > On 07.06.2018 08:57, Markus Armbruster wrote: > > Thomas Huth writes: > > > >> On 05.06.2018 00:40, Eric Blake wrote: > >>> On 06/04/2018 05:34 AM, Thomas Huth wrote: > On 04.06.2018 09:18, Markus Armbruster wrote: > > Roman

Re: [Qemu-devel] [PATCH] file-posix: Consolidate the locking error message

On Thu, Jun 07, 2018 at 03:20:24PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Jun 01, 2018 at 05:18:35PM +0800, Fam Zheng wrote: > >> When hot-plugging a block device fails due to image locking errors, > >> users won't see the hel

Re: [Qemu-devel] storing machine data in qcow images?

On Thu, Jun 07, 2018 at 01:17:24PM +0200, Andrea Bolognani wrote: > On Thu, 2018-06-07 at 11:22 +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote: > > > While hints might be considered a reasonable fit for qcow2, I think >

[Qemu-devel] [PATCH v3 3/3] glib: enforce the minimum required version and warn about old APIs

to temporarily turn off the -Wdeprecated-declarations compiler warning, while a static inline compat function is implemented. This workaround is illustrated with the implementation of the g_strv_contains method to satisfy the test suite. Signed-off-by: Daniel P. Berrangé --- include/glib-compat.h

Re: [Qemu-devel] [PATCH v2 1/3] glib: bump min required glib library version to 2.40

On Thu, Jun 07, 2018 at 10:28:39AM +0200, Olaf Hering wrote: > Am Thu, 7 Jun 2018 09:25:24 +0100 > schrieb Daniel P. Berrangé : > > > https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms > > SLE12-SP2: 2.48.2 Thanks I'm adding that info Regards

Re: [Qemu-devel] [RFC v2 04/12] Add vhost-user-backend

On Fri, Jun 08, 2018 at 12:34:15AM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Jun 4, 2018 at 11:36 AM, Daniel P. Berrangé > wrote: > > On Fri, Jun 01, 2018 at 06:27:41PM +0200, Marc-André Lureau wrote: > >> Create a vhost-user-backend object that holds a conn

Re: [Qemu-devel] storing machine data in qcow images?

On Fri, Jun 08, 2018 at 09:21:30AM +0100, Dr. David Alan Gilbert wrote: > * Laszlo Ersek (ler...@redhat.com) wrote: > > On 06/07/18 12:54, Andrea Bolognani wrote: > > > On Thu, 2018-06-07 at 11:36 +0100, Daniel P. Berrangé wrote: > > >> On Thu, Jun 07, 2018 at 11:32:

Re: [Qemu-devel] [PATCH v2 0/2] vl: Partial support for non-scalar properties with -object

On Mon, May 28, 2018 at 11:31:03AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Just a ping to say I'd like us to restart work this patch and try to get > > it mergable for the 2.13 cycle, so I can rely it on for the ACL support > > I've h

Re: [Qemu-devel] Is there a way to package QEMU binaries?

On Thu, Jun 14, 2018 at 10:55:21AM +0800, Peter Xu wrote: > On Wed, Jun 13, 2018 at 10:28:09AM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 12:02:59PM +0800, Peter Xu wrote: > > > On Tue, Jun 12, 2018 at 09:52:45AM +0100, Peter Maydell wrote: > > > > O

Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management

On Tue, Jun 12, 2018 at 09:47:11PM +0300, Michael S. Tsirkin wrote: > This adds ability to expose host CPU power management capabilities to > guests. For intel guests, this is sufficient for guest to enable > low power CPU power management. For AMD guests it isn't sufficient, > deeper C-states are

Re: [Qemu-devel] [PATCH] ui: darwin: gtk: Add missing input keymap

CC'ing Gerd as ui/ tree maintainer. On Thu, Jun 14, 2018 at 09:23:55AM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 07:51:56PM -0400, Keno Fischer wrote: > > In appears the input keymap for osx was forgotten in the commit that > > converted the gtk frontend to ke

Re: [Qemu-devel] [PATCH] ui: darwin: gtk: Add missing input keymap

iel P. Berrange > Signed-off-by: Keno Fischer > --- > Makefile | 1 + > include/ui/input.h | 3 +++ > ui/input-keymap.c | 1 + > 3 files changed, 5 insertions(+) Reviewed-by: Daniel P. Berrangé I guess this shows just how (in-)frequently people try to compile th

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

On Thu, Jun 14, 2018 at 10:40:58AM +0200, Kevin Wolf wrote: > Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > > >> When you mix scalar and non-scalar keys, whether you get an "already > > >>

Re: [Qemu-devel] [PATCH 9/9] hw/arm/virt: Add virt-3.0 machine type

On Thu, Jun 14, 2018 at 10:56:20AM +0200, Laszlo Ersek wrote: > Hi Eric, > > On 06/14/18 08:27, Auger Eric wrote: > > Hi Laszlo, > > > > On 06/13/2018 11:05 PM, Laszlo Ersek wrote: > >> On 06/13/18 10:48, Eric Auger wrote: > >> > >>> PATCH: merge of ECAM and VCPU extension > >>> - Laszlo

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: > > > On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: > > > Hi Daniel > > > > > > On 06/13/2018 05:37 AM, Daniel P. Berrangé

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

On Mon, Jun 18, 2018 at 11:56:08AM +0100, Alex Bennée wrote: > > Thomas Huth writes: > > > On 15.06.2018 21:46, Alex Bennée wrote: > >> The fixed path and ports get in the way of running our tests and > >> builds in parallel. Instead of using TESTPATH we use mkdtemp() and > >> instead of a

[Qemu-devel] [PATCH v2] docs: add guidance on configuring CPU models for x86

on x86 hosts. It outlines which of the named CPU models are good choices, and describes which extra CPU flags should be enabled to allow the guest to mitigate hardware flaws. Signed-off-by: Daniel P. Berrangé --- Changed in v2: - Use texinfo so it can be pulled into main qemu-doc.texi - Build

Re: [Qemu-devel] [PATCH v7 12/54] tests/tcg/multiarch: don't hard code paths/ports for linux-test

On Mon, Jun 18, 2018 at 01:09:54PM +0200, Thomas Huth wrote: > On 18.06.2018 13:08, Daniel P. Berrangé wrote: > > On Mon, Jun 18, 2018 at 11:56:08AM +0100, Alex Bennée wrote: > >> > >> Thomas Huth writes: > >> > >>> On 15.06.2018 21:46, Alex B

Re: [Qemu-devel] [PATCH] Replaced git:// to https:// - resolved receiving sources behind some routers and HW-firewalls Fixed URLs to actual - replaced git.qemu-project.com to git.qemu.org Slightly fix

You need to trim the subject line so it is about 70 characters or less and then have a blank line On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote: > Signed-off-by: Iliya Dyachenko > --- > .gitmodules | 32 > 1 file changed, 16 insertions(+), 16

Re: [Qemu-devel] [PATCH 3/6] migration: add support for a "tls-authz" migration parameter

On Fri, Jun 15, 2018 at 06:54:23PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > From: "Daniel P. Berrange" > > > > The QEMU instance that runs as the server for the migration data > > transport (ie the targe

Re: [Qemu-devel] enabling smart-http git protocol on git.qemu.org

On Mon, Jun 18, 2018 at 09:54:10AM -0400, Jeff Cody wrote: > On Mon, Jun 18, 2018 at 11:55:05AM +0100, Peter Maydell wrote: > > On 18 June 2018 at 10:47, Daniel P. Berrangé wrote: > > > On Mon, Jun 18, 2018 at 12:32:01PM +0300, Iliya Dyachenko wrote: > > >>

Re: [Qemu-devel] Is there a way to package QEMU binaries?

On Wed, Jun 13, 2018 at 12:02:59PM +0800, Peter Xu wrote: > On Tue, Jun 12, 2018 at 09:52:45AM +0100, Peter Maydell wrote: > > On 12 June 2018 at 07:24, Peter Xu wrote: > > > For example, I wanted to compile QEMU once and install it on multiple > > > systems. What would be the suggested way to

Re: [Qemu-devel] [PATCH] qga: check bytes count read by guest-file-read

On Wed, Jun 13, 2018 at 11:46:57AM +0530, P J P wrote: > From: Prasad J Pandit > > While reading file content via 'guest-file-read' command, > 'qmp_guest_file_read' routine allocates buffer of count+1 > bytes. It could overflow for large values of 'count'. > Add check to avoid it. No objection

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: > The virtio-crypto driver currently propagates to the guest > all the cipher algorithms that the backend cryptodev can > support. But in certain cases where the guest has more > performant mechanism to handle some algorithms, it would be

  1   2   3   4   5   6   7   8   9   10   >