+-
block/copy-before-write.c | 2 +-
3 files changed, 15 insertions(+), 2 deletions(-)
Reviewed-by: Hanna Reitz
insertions(+)
Yes, really nice. Thanks.
Reviewed-by: Hanna Reitz
-bitmap.c | 6 ++
util/hbitmap.c | 33 +
4 files changed, 53 insertions(+)
Reviewed-by: Hanna Reitz
On 22.02.22 16:23, Peter Maydell wrote:
Coverity points out that we aren't checking the return value
from curl_easy_setopt() for any of the calls to it we make
in block/curl.c.
Tested with 'make check' and with some basic smoke test command lines
suggested by Dan:
qemu-img info
On 16.02.22 20:46, Vladimir Sementsov-Ogievskiy wrote:
Add helper that returns both status and output, to be used in the
following commit
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 4
1 file changed, 4 insertions(+)
diff --git
On 16.02.22 20:46, Vladimir Sementsov-Ogievskiy wrote:
We are on the way to implement internal-backup with fleecing scheme,
which includes backup job copying from fleecing block driver node
(which is target of copy-before-write filter) to final target of
backup. This job doesn't need own filter,
include/block/reqlist.h
create mode 100644 block/reqlist.c
Reviewed-by: Hanna Reitz
On 16.02.22 20:46, Vladimir Sementsov-Ogievskiy wrote:
Current scheme of image fleecing looks like this:
[guest][NBD export]
| |
|root | root
v v
[copy-before-write] ->
On 16.02.22 20:46, Vladimir Sementsov-Ogievskiy wrote:
The filter simply utilizes snapshot-access API of underlying block
Nit picking: Well, it isn’t really a filter. I understand where you’re
coming from, but by definition it isn’t a filter driver.
node.
In further patches we want to
(-)
Reviewed-by: Hanna Reitz
Add the missing error string
setup.
(We can't be specific about the cause of failure: the documentation
of curl_easy_init() just says "If this function returns NULL,
something went wrong".)
Signed-off-by: Peter Maydell
---
block/curl.c | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Hanna Reitz
On 16.02.22 20:46, Vladimir Sementsov-Ogievskiy wrote:
Note that reads zero areas (not dirty in the bitmap) fails, that's
correct.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/image-fleecing | 32 ++--
tests/qemu-iotests/tests/image-fleecing.out | 84
On 23.02.22 13:43, Thomas Huth wrote:
In TAP mode, the stdout is reserved for the TAP protocol, so we
have to make sure to mark other lines with a comment '#' character
at the beginning to avoid that the TAP parser at the other end
gets confused.
To test this condition, run "configure" for
On 23.02.22 13:31, Thomas Huth wrote:
iotest 040 already has some checks for the availability of the 'throttle'
driver, but some new code has been added in the course of time that
depends on 'throttle' but does not check for its availability. Add
a check to the TestCommitWithFilters class so
On 16.02.22 17:16, John Snow wrote:
On Tue, Feb 15, 2022, 6:57 PM Philippe Mathieu-Daudé
wrote:
On 16/2/22 00:53, John Snow wrote:
> On Tue, Feb 15, 2022 at 5:55 PM Eric Blake
wrote:
>>
>> On Tue, Feb 15, 2022 at 05:08:50PM -0500, John Snow wrote:
>>
Some test cases run in iotest 065 require zstd support. Skip them if
qemu-img reports it not to be available.
Reported-by: Thomas Huth
Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compression type")
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/065 | 11 -
excessive, given that this test is not in auto and thus
likely only run by developers who have zstd support compiled in.)
Fixes: 677e0bae686e7c670a71d1f ("iotest 303: explicit compression type")
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/303 | 15 +++
1 file changed, 11
to not be supported.
Hanna Reitz (2):
iotests/065: Check for zstd support
iotests/303: Check for zstd support
tests/qemu-iotests/065 | 11 ---
tests/qemu-iotests/303 | 15 +++
2 files changed, 19 insertions(+), 7 deletions(-)
--
2.34.1
its usage altogether.)
Signed-off-by: Hanna Reitz
---
v1: https://lists.nongnu.org/archive/html/qemu-block/2022-02/msg00675.html
v2:
- Delete .casenotrun before running a test: Writes to this file only
append data, so if we do not delete it before a test run, it may still
contain stale data
missing from its own headers.
Let meson.build actually chek for both STATX_MNT_ID and
statx.stx_mnt_id, and set CONFIG_STATX_MNT_ID if both are present.
Then, use this config macro in virtiofsd.
Closes: https://gitlab.com/qemu-project/qemu/-/issues/882
Signed-off-by: Hanna Reitz
---
meson.build
On 21.02.22 20:45, Peter Maydell wrote:
On Tue, 1 Feb 2022 at 11:25, Hanna Reitz wrote:
On 28.01.22 17:55, Peter Maydell wrote:
Coverity points out that we aren't checking the return value
from curl_easy_setopt() for any of the calls to it we make
in block/curl.c.
Fixes: Coverity CID 1459336
On 22.02.22 15:39, Vladimir Sementsov-Ogievskiy wrote:
21.02.2022 20:29, Hanna Reitz wrote:
Drop the use of OUTPUT_DIR (test/qemu-iotests under the build
directory), and instead write test output files (.out.bad, .notrun, and
.casenotrun) to TEST_DIR.
With this, the same test can be run
was
that we returned last time.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2058457
Signed-off-by: Hanna Reitz
---
Sadly, I didn't find a nice way to test this, primarily because I
believe reproducing this requires a bdrv_flush_all() to come from the
VM (without QMP command). The only way I know
On 22.02.22 16:55, Vladimir Sementsov-Ogievskiy wrote:
21.02.2022 20:08, Hanna Reitz wrote:
303 runs two test cases, one of which requires zstd support.
Unfortunately, given that this is not a unittest-style test, we cannot
easily skip that single case, and instead can only skip the whole test
to check for zstd support instead of checking for their own
qemu-img create’s output
- Have 065 fall back to zlib instead of skipping zstd test cases
Hanna Reitz (3):
iotests.py: Add supports_qcow2_zstd_compression()
iotests/065: Check for zstd support
iotests/303: Check for zstd support
On 22.02.22 16:44, Vladimir Sementsov-Ogievskiy wrote:
21.02.2022 20:08, Hanna Reitz wrote:
Some test cases run in iotest 065 require zstd support. Skip them if
qemu-img reports it not to be available.
Reported-by: Thomas Huth
Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compre
On 02.03.22 12:31, Vladimir Sementsov-Ogievskiy wrote:
02.03.2022 14:09, Hanna Reitz wrote:
On 22.02.22 16:55, Vladimir Sementsov-Ogievskiy wrote:
21.02.2022 20:08, Hanna Reitz wrote:
303 runs two test cases, one of which requires zstd support.
Unfortunately, given that this is not a unittest
Some test cases run in iotest 065 want to run with zstd compression just
for added coverage. Run them with zlib if there is no zstd support
compiled in.
Reported-by: Thomas Huth
Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compression type")
Signed-off-by: Hanna Reitz
---
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 21 +
1 file changed, 21 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 6027780180..ce60abcadc 100644
--- a/tests/qemu
excessive, given that this test is not in auto and thus
likely only run by developers who have zstd support compiled in.)
Fixes: 677e0bae686e7c670a71d1f ("iotest 303: explicit compression type")
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/303 | 4 +++-
1 file changed, 3 insertions(+),
On 03.03.22 12:05, Hanna Reitz wrote:
On 28.02.22 12:39, Vladimir Sementsov-Ogievskiy wrote:
The new block driver simply utilizes snapshot-access API of underlying
block node.
In further patches we want to use it like this:
[guest] [NBD export
On 03.03.22 12:44, Hanna Reitz wrote:
On 28.02.22 12:39, Vladimir Sementsov-Ogievskiy wrote:
Note that reads zero areas (not dirty in the bitmap) fails, that's
correct.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/image-fleecing | 32 ++--
tests/qemu
On 28.02.22 12:39, Vladimir Sementsov-Ogievskiy wrote:
Note that reads zero areas (not dirty in the bitmap) fails, that's
correct.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/image-fleecing | 32 ++--
tests/qemu-iotests/tests/image-fleecing.out | 84
On 28.02.22 12:39, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/tests/image-fleecing | 120 ++--
tests/qemu-iotests/tests/image-fleecing.out | 63 ++
2 files changed, 151 insertions(+), 32 deletions(-)
On 28.02.22 12:39, Vladimir Sementsov-Ogievskiy wrote:
The new block driver simply utilizes snapshot-access API of underlying
block node.
In further patches we want to use it like this:
[guest] [NBD export]
||
| root |
-nbd mainly does this to detect errors, though (while os_daemonize()
has the child explicitly signal success after set up); because we do not
redirect stderr after forking, error messages continue to appear on
whatever the parent's stderr was (until set up is complete).
Signed-off-by: Hanna Reitz
. qemu
is supposed to cancel the job so that it can quit as soon as possible
instead of waiting for the job to complete (which it did before 6.2).
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/185 | 190 -
tests/qemu-iotests/185.out | 48 ++
2
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/4:[down] 'os-posix: Add os_set_daemonize()'
002/4:[0006] [FC] 'qsd: Add pre-init argument parsing pass'
003/4:[0148] [FC] 'qsd: Add --daemonize'
004/4:[] [--] 'iotests/185: Add post-READY quit tests'
Hanna
-by: Hanna Reitz
---
include/sysemu/os-posix.h | 1 +
include/sysemu/os-win32.h | 5 +
os-posix.c| 6 ++
3 files changed, 12 insertions(+)
diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 2edf33658a..dd64fb401d 100644
--- a/include/sysemu/os-posix.h
+++ b
possible. (The
same caveat with --help applies: That means that "--blockdev inv-drv
--inv-arg" will now complain about --inv-arg, not inv-drv.)
This patch does make some references to --daemonize without having
implemented it yet, but that will happen in the next patch.
Signed-off-by: Hann
On 03.03.22 20:43, Vladimir Sementsov-Ogievskiy wrote:
v6:
11: add comment
15: limit to qcow2 with unsupported compat
fix style
16: fix style
change log('Backup finished ...') to assertion and comment
Thanks a lot!
Applied to my block branch:
On 03.03.22 17:56, Kevin Wolf wrote:
Am 16.02.2022 um 11:53 hat Hanna Reitz geschrieben:
bdrv_refresh_limits() recurses down to the node's children. That does
not seem necessary: When we refresh limits on some node, and then
recurse down and were to change one of its children's BlockLimits
On 17.02.22 22:02, John Snow wrote:
On Tue, Feb 15, 2022 at 12:14 PM Hanna Reitz wrote:
Ping
(I can take it too, if you’d like, John, but you’re listed as the only
maintainer for hw/ide, so... Just say the word, though!)
Sorry, I sent you a mail off-list at the time where I said you were
-iotests/tests/nbd-reconnect-on-open | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
Reviewed-by: Hanna Reitz
On 22.03.22 17:19, John Snow wrote:
On Tue, Mar 22, 2022, 10:22 AM Hanna Reitz wrote:
On 18.03.22 21:36, John Snow wrote:
> qemu-io fails on read/write with zero-length raw images, so skip
these
> when running the zero-length image tests.
>
> Signed-off-b
/tests/stream-error-on-reset | 4 ++--
10 files changed, 39 insertions(+), 58 deletions(-)
qemu_io_silent_check() was unused anyway, right...?
Reviewed-by: Hanna Reitz
On 18.03.22 21:36, John Snow wrote:
Howdy,
Heya,
[...]
- Uh, actually, test 040 fails with this patchset and I don't understand
if it's intentional, harmless, a test design problem, or worse:
==
ERROR:
On 21.03.22 10:17, Thomas Huth wrote:
On 21/03/2022 10.06, Hanna Reitz wrote:
On 18.03.22 18:36, Thomas Huth wrote:
On 18/03/2022 18.04, Hanna Reitz wrote:
On 10.03.22 08:50, Thomas Huth wrote:
If there is a failing iotest, the output is currently not logged to
the console anymore. To get
On 21.03.22 14:14, Hanna Reitz wrote:
On 18.03.22 22:14, John Snow wrote:
On Fri, Mar 18, 2022 at 9:36 AM Hanna Reitz wrote:
On 18.03.22 00:49, John Snow wrote:
Hiya!
This series effectively replaces qemu_img_pipe_and_status() with a
rewritten function named qemu_img() that raises
On 18.03.22 22:14, John Snow wrote:
On Fri, Mar 18, 2022 at 9:36 AM Hanna Reitz wrote:
On 18.03.22 00:49, John Snow wrote:
Hiya!
This series effectively replaces qemu_img_pipe_and_status() with a
rewritten function named qemu_img() that raises an exception on non-zero
return code by default
On 23.02.22 10:38, Thomas Huth wrote:
Though "make check-block" is currently already run via the meson test
runner, it still looks like an oddball in the output of "make check". It
would be nicer if the iotests would show up like the other tests suites.
My original plan was to add each iotests
--
tests/qemu-iotests/meson.build | 14 ++
2 files changed, 14 insertions(+), 26 deletions(-)
FWIW
Reviewed-by: Hanna Reitz
On 02.03.22 13:45, Hanna Reitz wrote:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
We have two tests (as far as I know) that use compression_type=zstd for
qcow2 but do not check whether that is actually supported. Thomas
reported this for 065
excessive, given that this test is not in auto and thus
likely only run by developers who have zstd support compiled in.)
Fixes: 677e0bae686e7c670a71d1f ("iotest 303: explicit compression type")
Signed-off-by: Hanna Reitz
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/303 |
athieu-Daudé
---
block/parallels-ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Hanna Reitz
On 21.03.22 18:26, Thomas Huth wrote:
On 21/03/2022 17.14, Hanna Reitz wrote:
On 23.02.22 10:38, Thomas Huth wrote:
Though "make check-block" is currently already run via the meson test
runner, it still looks like an oddball in the output of "make
check". It
would be
On 23.03.22 09:39, Thomas Huth wrote:
On 22/03/2022 18.42, John Snow wrote:
Quite a few of these tests have stale contact information. This patch
updates the stale ones that I happen to be aware of at the moment.
Signed-off-by: John Snow
---
tests/qemu-iotests/025 | 2 +-
:[] [--] 'iotests/303: Check for zstd support'
Hanna Reitz (3):
iotests.py: Add supports_qcow2_zstd_compression()
iotests/065: Check for zstd support
iotests/303: Check for zstd support
tests/qemu-iotests/065| 24 ++--
tests/qemu-iotests/303| 4 +++-
tests/qemu
Some test cases run in iotest 065 want to run with zstd compression just
for added coverage. Run them with zlib if there is no zstd support
compiled in.
Reported-by: Thomas Huth
Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compression type")
Signed-off-by: Hanna Reitz
---
Suggested-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 20
1 file changed, 20 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index fcec3e51e5..fe10a6cf05 100644
--- a/tests/qemu
irtio-blk,drive=drive0,share-rw=on')
try:
# Silence AQMP logging errors temporarily.
Probably should just be “QMP” now, too. Anyway:
Acked-by: Hanna Reitz
-with change_log_level('qemu.aqmp'):
+with change_log_level('qemu.qmp'):
On 21.03.22 22:08, John Snow wrote:
Copy the docstrings out of qemu.qmp, adjusting them as necessary to
more accurately reflect the current state of this class.
(Licensing: This is copying and modifying GPLv2-only licensed docstrings
into a GPLv2-only file.)
Signed-off-by: John Snow
-iotests/242 | 6 +++---
tests/qemu-iotests/255 | 4 +---
tests/qemu-iotests/303 | 4 ++--
3 files changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Hanna Reitz
be
invalid if read. Hence the errors.
Adjust the test to
be more explicit about what it expects to fail and why.
Signed-off-by: John Snow
---
tests/qemu-iotests/tests/image-fleecing | 28 +
1 file changed, 19 insertions(+), 9 deletions(-)
Reviewed-by: Hanna Reitz
deletions(-)
Reviewed-by: Hanna Reitz
outside of
QEMU (Where we will not have throttle groups) will succeed.
[Patch entirely written by Hanna but I don't have her S-o-B]
Er, well, not sure if this even meets the necessary threshold of
originality, so a Proposed-by would’ve been fine.
Anyway, here you go:
Signed-off-by: Hanna Reitz
On 24.03.22 11:36, Stefan Hajnoczi wrote:
On Wed, Mar 23, 2022 at 01:10:19PM +0100, Hanna Reitz wrote:
On 23.03.22 09:39, Thomas Huth wrote:
On 22/03/2022 18.42, John Snow wrote:
Quite a few of these tests have stale contact information. This patch
updates the stale ones that I happen
On 24.03.22 11:42, Peter Lieven wrote:
Am 24.03.22 um 11:40 schrieb Stefano Garzarella:
On Thu, Mar 24, 2022 at 10:52:04AM +0100, Peter Lieven wrote:
Am 22.03.22 um 10:38 schrieb Hanna Reitz:
On 21.03.22 09:31, Stefano Garzarella wrote:
On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven
node's immediate backing child when both jobs are done.
Signed-off-by: Hanna Reitz
---
block/stream.c | 11 ++-
tests/qemu-iotests/030 | 5 +
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/block/stream.c b/block/stream.c
index 3acb59fe6a..5c08208db9 100644
node's immediate backing child when both jobs are done.
Signed-off-by: Hanna Reitz
---
v2:
- Oops, the base can be NULL. Would have noticed if I had ran all test
cases from 030, and not just test_overlapping_5()...
That means that keeping a strong reference to the base node must be
conditional
these places are in fetch
all VM events, so they may have already fetched that event from the
queue.)
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/030 | 25 -
tests/qemu-iotests/041 | 26 +++---
2 files changed, 39 insertions(+), 12 deletions(-)
diff --git
On 28.03.22 09:44, Hanna Reitz wrote:
On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote:
24.03.2022 17:09, Hanna Reitz wrote:
When the stream block job cuts out the nodes between top and base in
stream_prepare(), it does not drain the subtree manually; it fetches
the
base node, and tries
On 25.03.22 17:37, Vladimir Sementsov-Ogievskiy wrote:
24.03.2022 17:09, Hanna Reitz wrote:
When the stream block job cuts out the nodes between top and base in
stream_prepare(), it does not drain the subtree manually; it fetches the
base node, and tries to insert it as the top node's backing
On 17.03.22 17:23, Emanuele Giuseppe Esposito wrote:
Am 09/03/2022 um 14:26 schrieb Emanuele Giuseppe Esposito:
* Drains allow the caller (either main loop or iothread running
the context) to wait all in_flights requests and operations
of a BDS: normal drains target a given node and is
On 30.03.22 13:55, Emanuele Giuseppe Esposito wrote:
Am 30/03/2022 um 12:53 schrieb Hanna Reitz:
On 17.03.22 17:23, Emanuele Giuseppe Esposito wrote:
Am 09/03/2022 um 14:26 schrieb Emanuele Giuseppe Esposito:
* Drains allow the caller (either main loop or iothread running
the context
-by: Kevin Wolf
Reviewed-by: Hanna Reitz
Message-id: 20211026175612.4127598-9-js...@redhat.com
Signed-off-by: John Snow
commit 1611e6cf4e7163f6102b37010a8b7e7120f468b5
Author: John Snow
Date: Thu Nov 18 15:46:18 2021 -0500
python/machine: handle "fast" QEMU te
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
We are going to add one more option of enum type. Let's refactor option
parsing so that we can simply work with BlockdevOptionsCbw object.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/copy-before-write.c | 68
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
Add new API, to make a time limited call of the coroutine.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qemu/coroutine.h | 13 ++
util/meson.build | 1 +
util/qemu-co-timeout.c | 89
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
Add possibility to limit block_copy() call in time. To be used in the
next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 26 +++---
block/copy-before-write.c | 2 +-
+
util/hbitmap.c | 25 ++
6 files changed, 43 insertions(+), 69 deletions(-)
Reviewed-by: Hanna Reitz
On 01.04.22 15:16, Hanna Reitz wrote:
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
Add possibility to limit block_copy() call in time. To be used in the
next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 26 +++---
block
on failure of copy-before-write operation.
#Default is @break-guest-write. (Since 7.0)
#
+# @cbw-timeout: Zero means no limit. Non-zero sets the timeout in seconds
+# for copy-before-write operation. Default 0. (Since 7.0)
*7.1, but:
Reviewed-b
On 01.04.22 15:24, Hanna Reitz wrote:
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
In some scenarios, when copy-before-write operations lasts too long
time, it's better to cancel it.
Most useful would be to use the new option together with
on-cbw-error=break-snapshot: this way if cbw
| 5 +
2 files changed, 133 insertions(+)
create mode 100755 tests/qemu-iotests/tests/copy-before-write
create mode 100644 tests/qemu-iotests/tests/copy-before-write.out
Reviewed-by: Hanna Reitz
| 78 +++
.../qemu-iotests/tests/copy-before-write.out | 4 +-
2 files changed, 80 insertions(+), 2 deletions(-)
Reviewed-by: Hanna Reitz
On 30.03.22 16:32, Eric Blake wrote:
On Tue, Mar 29, 2022 at 11:19:16AM +0200, Hanna Reitz wrote:
When rebuilding the refcount structures (when qemu-img check -r found
errors with refcount = 0, but reference count > 0), the new refcount
table defaults to being put at the image file en
On 30.03.22 17:07, Eric Blake wrote:
On Tue, Mar 29, 2022 at 11:19:17AM +0200, Hanna Reitz wrote:
One clear problem with how qcow2's refcount structure rebuild algorithm
used to be before "qcow2: Improve refcount structure rebuilding" was
that it is prone to failure for qcow2 image
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
Currently, behavior on copy-before-write operation failure is simple:
report error to the guest.
Let's implement alternative behavior: break the whole copy-before-write
process (and corresponding backup job or NBD client) but keep guest
On 01.04.22 18:08, Vladimir Sementsov-Ogievskiy wrote:
01.04.2022 16:16, Hanna Reitz wrote:
On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote:
Add possibility to limit block_copy() call in time. To be used in the
next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block
to rebuild_refcount_structure()'
Hanna Reitz (3):
qcow2: Improve refcount structure rebuilding
iotests/108: Test new refcount rebuild algorithm
qcow2: Add errp to rebuild_refcount_structure()
block/qcow2-refcount.c | 353 ++---
tests/qemu-iotests/108 | 259
071
Closes: https://gitlab.com/qemu-project/qemu/-/issues/941
Reviewed-by: Eric Blake
Signed-off-by: Hanna Reitz
---
block/qcow2-refcount.c | 332 +
1 file changed, 235 insertions(+), 97 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcoun
Instead of fprint()-ing error messages in rebuild_refcount_structure()
and its rebuild_refcounts_write_refblocks() helper, pass them through an
Error object to qcow2_check_refcounts() (which will then print it).
Suggested-by: Eric Blake
Signed-off-by: Hanna Reitz
---
block/qcow2-refcount.c
wed-by: Eric Blake
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/108 | 259 -
tests/qemu-iotests/108.out | 81
2 files changed, 339 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108
index 56339ab2c5..ed02
On 05.04.22 12:14, Kevin Wolf wrote:
Am 24.03.2022 um 13:57 hat Hanna Reitz geschrieben:
When the stream block job cuts out the nodes between top and base in
stream_prepare(), it does not drain the subtree manually; it fetches the
base node, and tries to insert it as the top node's backing node
On 05.04.22 13:47, Hanna Reitz wrote:
On 05.04.22 12:14, Kevin Wolf wrote:
[...]
At the same time they probably do too little, because what you're
describing you're protecting against is not I/O, but graph modifications
done by callbacks invoked in the AIO_WAIT_WHILE() when replacing
On 23.02.22 10:58, Thomas Huth wrote:
Quoting the TAP specification: "The plan tells how many tests will be
run [...]. It’s a check that the test file hasn’t stopped prematurely."
That's a good idea of course, so let's support that in the iotest
testrunner, too.
Signed-off-by: Thomas Huth
---
On 21.03.22 17:23, John Snow wrote:
On Mon, Mar 21, 2022, 11:50 AM Hanna Reitz wrote:
On 21.03.22 14:14, Hanna Reitz wrote:
> On 18.03.22 22:14, John Snow wrote:
>> On Fri, Mar 18, 2022 at 9:36 AM Hanna Reitz
wrote:
>>> On 18.03.22 00:49, John Snow wr
On 21.03.22 09:31, Stefano Garzarella wrote:
On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 17:47 schrieb Stefano Garzarella
:
On Fri, Mar 18, 2022 at 04:48:18PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 09:25 schrieb Stefano Garzarella
:
On Thu,
On 21.03.22 21:16, John Snow wrote:
V5 hotfix:
- Quote the subprocess.CompletedProcess[str] type annotations,
Python 3.6 chokes on them at runtime :(
- Reduce line length in the text decoration fn,
even though check-patch still doesn't like it.
- Reflow docstring for qemu_img.*
V5
e internal to
iotests.py and will be removed in subsequent patches.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.903471-15-js...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/065 | 4 ++--
tests/qemu-iotests/237 | 3 +--
tests/qemu-iote
601 - 700 of 1120 matches
Mail list logo
