[PULL 4/4] target/m68k: fix FPSR quotient byte for frem instruction

2023-01-16 Thread Laurent Vivier
byte accordingly. Signed-off-by: Mark Cave-Ayland Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1314 Reviewed-by: Richard Henderson Message-Id: <20230114232959.118224-5-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.

[PULL 0/4] M68k next patches

2023-01-16 Thread Laurent Vivier
The following changes since commit 886fb67020e32ce6a2cf7049c6f017acf1f0d69a: Merge tag 'pull-target-arm-20230113' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-01-13 14:12:43 +) are available in the Git repository at: https://github.com/vivier/qemu-m68k.git tags

[PULL 3/4] target/m68k: fix FPSR quotient byte for fmod instruction

2023-01-16 Thread Laurent Vivier
: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20230114232959.118224-4-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/target/m68k/fpu_helper.c b/targe

[PULL 1/4] target/m68k: pass quotient directly into make_quotient()

2023-01-16 Thread Laurent Vivier
From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <20230114232959.118224-2-mark.cave-ayl...@ilande.co.uk> Signed-off-by: Laurent Vivier --- target/m68k/fpu_helper.c | 20 +++- 1 file chang

[PULL 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-16 Thread Laurent Vivier
From: Mark Cave-Ayland This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id

Re: [PATCH v5] tests/qtest: netdev: test stream and dgram backends

2023-01-16 Thread Laurent Vivier
ping On 1/5/23 10:37, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v5: - disable test_stream_fd and test_dgram_fd on windows as socketpair() is not defined. - enable test_stream_unix_abstract only on linux as

Re: [PATCH v3] net: stream: add a new option to automatically reconnect

2023-01-16 Thread Laurent Vivier
ping On 1/5/23 14:13, Laurent Vivier wrote: In stream mode, if the server shuts down there is currently no way to reconnect the client to a new server without removing the NIC device and the netdev backend (or to reboot). This patch introduces a reconnect option that specifies a delay to try

Re: [PULL v4 76/83] vhost-user: Support vhost_dev_start

2023-01-11 Thread Laurent Vivier
On 1/9/23 11:55, Michael S. Tsirkin wrote: On Fri, Jan 06, 2023 at 03:21:43PM +0100, Laurent Vivier wrote: Hi, it seems this patch breaks vhost-user with DPDK. See https://bugzilla.redhat.com/show_bug.cgi?id=2155173 it seems QEMU doesn't receive the expected commands sequence: Rec

Re: [PULL v4 76/83] vhost-user: Support vhost_dev_start

2023-01-06 Thread Laurent Vivier
Hi, it seems this patch breaks vhost-user with DPDK. See https://bugzilla.redhat.com/show_bug.cgi?id=2155173 it seems QEMU doesn't receive the expected commands sequence: Received unexpected msg type. Expected 22 received 40 Fail to update device iotlb Received unexpected msg type. Expected 40

[PATCH v3] net: stream: add a new option to automatically reconnect

2023-01-05 Thread Laurent Vivier
new test in qtest to test the reconnect option and the connect/disconnect events. Signed-off-by: Laurent Vivier --- Based-on: <20230105093751.41-1-lviv...@redhat.com> v3: - add "since 8.0" in net.json v2: - rebase net/stream.c| 53 ++

[PATCH v5] tests/qtest: netdev: test stream and dgram backends

2023-01-05 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v5: - disable test_stream_fd and test_dgram_fd on windows as socketpair() is not defined. - enable test_stream_unix_abstract only on linux as "abstract" unix socket parameter is on

Re: [PATCH v4] tests/qtest: netdev: test stream and dgram backends

2023-01-04 Thread Laurent Vivier
On 1/4/23 19:37, Thomas Huth wrote: On 03/01/2023 12.00, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v4:    - rework EXPECT_STATE()    - use g_dir_make_tmp() v3: - Add "-M none" to avoid error:    &

Re: [PATCH v2 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-04 Thread Laurent Vivier
file changed, 13 insertions(+), 10 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH v4] tests/qtest: netdev: test stream and dgram backends

2023-01-03 Thread Laurent Vivier
On 1/3/23 15:08, Thomas Huth wrote: On 03/01/2023 12.00, Laurent Vivier wrote: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v4:    - rework EXPECT_STATE()    - use g_dir_make_tmp() v3: - Add "-M none" to avoid error:    &

Re: [PATCH v2] net: stream: add a new option to automatically reconnect

2023-01-03 Thread Laurent Vivier
On 1/3/23 15:28, Thomas Huth wrote: On 03/01/2023 15.22, Laurent Vivier wrote: In stream mode, if the server shuts down there is currently no way to reconnect the client to a new server without removing the NIC device and the netdev backend (or to reboot). This patch introduces a reconnect

[PATCH v2] net: stream: add a new option to automatically reconnect

2023-01-03 Thread Laurent Vivier
new test in qtest to test the reconnect option and the connect/disconnect events. Signed-off-by: Laurent Vivier --- Based-on: <20230103110049.120340-1-lviv...@redhat.com> v2: - rebase net/stream.c| 53 ++- qapi/net.json | 6 ++- qemu-opti

[PATCH v4] tests/qtest: netdev: test stream and dgram backends

2023-01-03 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v4: - rework EXPECT_STATE() - use g_dir_make_tmp() v3: - Add "-M none" to avoid error: "No machine specified, and there is no default" v2: - Fix ipv6

Re: [PATCH v3] tests/qtest: netdev: test stream and dgram backends

2023-01-02 Thread Laurent Vivier
On 12/12/22 14:20, Thomas Huth wrote: On 09/11/2022 14.03, Laurent Vivier wrote: [...] diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c new file mode 100644 index ..b6b59244a282 --- /dev/null +++ b/tests/qtest/netdev-socket.c @@ -0,0 +1,435 @@ +/* + * QTest

Re: [PATCH 4/4] target/m68k: fix FPSR quotient byte for frem instruction

2023-01-01 Thread Laurent Vivier
use it to set the quotient byte accordingly. Signed-off-by: Mark Cave-Ayland Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1314 --- target/m68k/fpu_helper.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : This enables the quotient parameter to be changed from int32_t to uint32_t and also allows the extra sign logic in make_quotient() to be removed. Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 15 +-- 1 file change

Re: [PATCH 3/4] target/m68k: fix FPSR quotient byte for fmod instruction

2023-01-01 Thread Laurent Vivier
Cave-Ayland --- target/m68k/fpu_helper.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH 1/4] target/m68k: pass quotient directly into make_quotient()

2023-01-01 Thread Laurent Vivier
Le 01/01/2023 à 15:43, Mark Cave-Ayland a écrit : Signed-off-by: Mark Cave-Ayland --- target/m68k/fpu_helper.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH 2/4] target/m68k: pass sign directly into make_quotient()

2023-01-01 Thread Laurent Vivier
changed, 5 insertions(+), 10 deletions(-) Reviewed-by: Laurent Vivier

Re: [PATCH] nubus-device: fix memory leak in nubus_device_realize

2022-12-22 Thread Laurent Vivier
ot;, nd->romfile); return; Reviewed-by: Laurent Vivier

Re: [PATCH] linux-user: Enhance /proc/cpuinfo output for sparc, hppa and m68k

2022-12-13 Thread Laurent Vivier
Le 13/12/2022 à 17:10, Helge Deller a écrit : The sparc, hppa and m68k architectures provide an own output for the emulated /proc/cpuinfo file. Some userspace applications count (even if that's not the recommended way) the number of lines which start with "processor:" and assume that this number

[Bug 1903470] Re: qemu 5.1.0: Add UNIX socket support for netdev socket

2022-12-06 Thread Laurent Vivier
This was added to support passt: https://passt.top -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1903470 Title: qemu 5.1.0: Add UNIX socket support for netdev socket Status in QEMU: Expired Bu

[Bug 1903470] Re: qemu 5.1.0: Add UNIX socket support for netdev socket

2022-12-06 Thread Laurent Vivier
This will be available in the next QEMU release (7.2) under a sligthly different form: "-netdev stream" for TCP socket and "-netdev dgram" for UDP socket. Both support inet and unix sockets. See qemu(1). -- You received this bug notification because you are a member of qemu- devel-ml, which is

[PATCH] net: stream: add a new option to automatically reconnect

2022-11-09 Thread Laurent Vivier
new test in qtest to test the reconnect option and the connect/disconnect events. Signed-off-by: Laurent Vivier --- Notes: Based-on: <20221109130301.790679-1-lviv...@redhat.com> net/stream.c| 53 ++- qapi/net.json | 6 ++- qemu-opti

Re: [PATCH] display: include dependencies explicitly

2022-11-09 Thread Laurent Vivier
S. Tsirkin Tested-by: Laurent Vivier --- hw/display/vga_int.h| 1 - include/qemu/typedefs.h | 2 ++ hw/display/ati_2d.c | 1 + hw/display/cirrus_vga.c | 1 + hw/display/cirrus_vga_isa.c | 1 + hw/display/vga-isa.c| 1 + hw/display/vga-mmio.c | 1 +

Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-09 Thread Laurent Vivier
This one breaks something for me: [3/65] Compiling C object libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o FAILED: libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o clang -m64 -mcx16 -Ilibhw-display-virtio-vga-gl.a.p -I. -I../../../Projects/qemu-upstream -Iqapi -Itrace -Iui -Iui/

[PATCH v3] tests/qtest: netdev: test stream and dgram backends

2022-11-09 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v3: - Add "-M none" to avoid error: "No machine specified, and there is no default" v2: - Fix ipv6 free port allocation - Check for IPv4, IPv6, AF_UNIX - Use g_m

Re: [PULL 0/2] Net patches

2022-11-08 Thread Laurent Vivier
) Laurent Vivier (1): tests/qtest: netdev: test stream and dgram backends This test does not pass in CI: https://gitlab.com/qemu-project/qemu/-/jobs/3290964536 https://gitlab.com/qemu-project/qemu/-/jobs/3290964524 https

[PULL 4/7] target/m68k: Rename qregs.def -> qregs.h.inc

2022-11-05 Thread Laurent Vivier
Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Message-Id: <20221025235006.7215-2-phi...@linaro.org> Signed-off-by: Laurent Vivier --- target/m68k/{qregs.def => qregs.h.inc} | 0 target/m68k/translate.c| 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-

[PULL 7/7] tests/unit: simpler variable sequence for test-io-channel

2022-11-05 Thread Laurent Vivier
From: Alex Bennée This avoids some compilers complaining about a potentially un-initialised [src|dst]argv. In retrospect using GString was overkill for what we are constructing. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id

[PULL 2/7] Fix some typos in documentation and comments

2022-11-05 Thread Laurent Vivier
From: Stefan Weil Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: Stefan Hajnoczi Message-Id: <20221030105944.311940-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- docs/devel/testi

[PULL 0/7] Trivial branch for 7.2 patches

2022-11-05 Thread Laurent Vivier
The following changes since commit 6295a58ad1b73985b9c32d184de7d2ed1fbe1774: Merge tag 'pull-target-arm-20221104' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-11-04 11:01:17 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git

[PULL 5/7] target/s390x: Rename insn-data/format.def -> insn-data/format.h.inc

2022-11-05 Thread Laurent Vivier
Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Message-Id: <20221025235006.7215-3-phi...@linaro.org> Signed-off-by: Laurent Vivier --- target/s390x/tcg/{insn-data.def => insn-data.h.inc}| 2 +- .../s390x/tcg/{insn-format.def => insn-format.h.inc} | 0 target/s390x/tcg

[PULL 6/7] target/tricore: Rename csfr.def -> csfr.h.inc

2022-11-05 Thread Laurent Vivier
Reviewed-by: Bastian Koppelmann Reviewed-by: Alex Bennée Message-Id: <20221025235006.7215-4-phi...@linaro.org> Signed-off-by: Laurent Vivier --- target/tricore/{csfr.def => csfr.h.inc} | 0 target/tricore/translate.c | 4 ++-- 2 files changed, 2 insertions(+), 2

[PULL 3/7] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-11-05 Thread Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé Message-Id: <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchu...@aol.com> Signed-off-by: Laurent Vivier --- hw/xen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/meson.build b/hw/xen/meson.build in

[PULL 1/7] qapi: virtio: Fix the introduced version

2022-11-05 Thread Laurent Vivier
From: Han Han The items of qapi/virtio.json are introduced at a5ebce38576. They will be in the version 7.2 not 7.1. Signed-off-by: Han Han Reviewed-by: Laurent Vivier Message-Id: <20221101014647.3000801-1-h...@redhat.com> Signed-off-by: Laurent Vivier --- qapi/virtio.jso

Re: [PULL 04/10] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

2022-11-04 Thread Laurent Vivier
Hi Stefan, Le 03/11/2022 à 17:17, Laurent Vivier a écrit : From: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +-

[PATCH v2] tests/qtest: netdev: test stream and dgram backends

2022-11-04 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: v2: - Fix ipv6 free port allocation - Check for IPv4, IPv6, AF_UNIX - Use g_mkdtemp() rather than g_file_open_tmp() - Use socketpair() in test_stream_fd() v1: compared to v14 of "qapi: net

Re: [PATCH] tests/qtest: netdev: test stream and dgram backends

2022-11-04 Thread Laurent Vivier
On 11/4/22 13:15, Michael S. Tsirkin wrote: On Fri, Nov 04, 2022 at 11:58:29AM +0100, Laurent Vivier wrote: On 11/4/22 10:41, Daniel P. Berrangé wrote: ... +static void test_stream_unix(void) +{ +QTestState *qts0, *qts1; +char *expect; +gchar *path; +int ret; + +ret

Re: [PATCH] tests/qtest: netdev: test stream and dgram backends

2022-11-04 Thread Laurent Vivier
On 11/4/22 10:41, Daniel P. Berrangé wrote: ... +static void test_stream_unix(void) +{ +QTestState *qts0, *qts1; +char *expect; +gchar *path; +int ret; + +ret = g_file_open_tmp("netdev-XX", &path, NULL); +g_assert_true(ret >= 0); +close(ret); This is creating a z

Re: [PATCH v4] linux-user: implement execveat

2022-11-04 Thread Laurent Vivier
; - gp += sizeof(abi_ulong), q++) { -if (get_user_ual(addr, gp) -|| !addr) -break; -unlock_user(*q, addr, 0); -} - -g_free(argp); -g_free(envp); -} -return ret; + return do_execveat(cpu_env, AT_FDCWD, arg1, arg2, arg3, 0); case TARGET_NR_chdir: if (!(p = lock_user_string(arg1))) return -TARGET_EFAULT; Reviewed-by: Laurent Vivier

Re: [PATCH v3] linux-user: implement execveat

2022-11-04 Thread Laurent Vivier
Le 04/11/2022 à 10:55, Drew DeVault a écrit : On Fri Nov 4, 2022 at 10:53 AM CET, Philippe Mathieu-Daudé wrote: Splitting this big patch would ease review: It's only +165/-131, are you sure it really needs to be split? 1/ Replace safe_execve() by safe_execveat() -safe_execve(exec_path,

[PATCH] tests/qtest: netdev: test stream and dgram backends

2022-11-04 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- Notes: compared to v14 of "qapi: net: add unix socket type support to netdev backend": - use IP addresses 127.0.0.1 and ::1 rather than localhost tests/qtest/meson.build | 1 + tests/qtest/netdev-sock

Re: [PATCH v2] linux-user: implement execveat

2022-11-03 Thread Laurent Vivier
Le 03/11/2022 à 15:57, Drew DeVault a écrit : References: https://gitlab.com/qemu-project/qemu/-/issues/1007 Signed-off-by: Drew DeVault --- linux-user/syscall.c | 204 +++ 1 file changed, 111 insertions(+), 93 deletions(-) diff --git a/linux-user/sysc

[PULL 05/10] libvhost-user: Fix format strings

2022-11-03 Thread Laurent Vivier
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-3...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subpr

[PULL 03/10] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-11-03 Thread Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé Message-Id: <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchu...@aol.com> Signed-off-by: Laurent Vivier --- hw/xen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/meson.build b/hw/xen/meson.build in

[PULL 08/10] target/s390x: Rename insn-data/format.def -> insn-data/format.h.inc

2022-11-03 Thread Laurent Vivier
Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Message-Id: <20221025235006.7215-3-phi...@linaro.org> Signed-off-by: Laurent Vivier --- target/s390x/tcg/{insn-data.def => insn-data.h.inc}| 2 +- .../s390x/tcg/{insn-format.def => insn-format.h.inc} | 0 target/s390x/tcg

[PULL 06/10] libvhost-user: Add format attribute to local function vu_panic

2022-11-03 Thread Laurent Vivier
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff -

[PULL 09/10] target/tricore: Rename csfr.def -> csfr.h.inc

2022-11-03 Thread Laurent Vivier
Reviewed-by: Bastian Koppelmann Reviewed-by: Alex Bennée Message-Id: <20221025235006.7215-4-phi...@linaro.org> Signed-off-by: Laurent Vivier --- target/tricore/{csfr.def => csfr.h.inc} | 0 target/tricore/translate.c | 4 ++-- 2 files changed, 2 insertions(+), 2

[PULL 04/10] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

2022-11-03 Thread Laurent Vivier
From: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subpr

[PULL 02/10] Fix some typos in documentation and comments

2022-11-03 Thread Laurent Vivier
From: Stefan Weil Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: Stefan Hajnoczi Message-Id: <20221030105944.311940-1...@weilnetz.de> Signed-off-by: Laurent Vivier --- docs/devel/testi

[PULL 10/10] tests/unit: simpler variable sequence for test-io-channel

2022-11-03 Thread Laurent Vivier
From: Alex Bennée This avoids some compilers complaining about a potentially un-initialised [src|dst]argv. In retrospect using GString was overkill for what we are constructing. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id

[PULL 07/10] target/m68k: Rename qregs.def -> qregs.h.inc

2022-11-03 Thread Laurent Vivier
Reviewed-by: Laurent Vivier Reviewed-by: Alex Bennée Message-Id: <20221025235006.7215-2-phi...@linaro.org> Signed-off-by: Laurent Vivier --- target/m68k/{qregs.def => qregs.h.inc} | 0 target/m68k/translate.c| 4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-

[PULL 01/10] qapi: virtio: Fix the introduced version

2022-11-03 Thread Laurent Vivier
From: Han Han The items of qapi/virtio.json are introduced at a5ebce38576. They will be in the version 7.2 not 7.1. Signed-off-by: Han Han Reviewed-by: Laurent Vivier Message-Id: <20221101014647.3000801-1-h...@redhat.com> Signed-off-by: Laurent Vivier --- qapi/virtio.jso

[PULL 00/10] Trivial branch for 7.2 patches

2022-11-03 Thread Laurent Vivier
The following changes since commit a11f65ec1b8adcb012b89c92819cbda4dc25aaf1: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2022-11-01 13:49:33 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git tags/trivial-branch-fo

Re: [PATCH] tests/unit: simpler variable sequence for test-io-channel

2022-11-03 Thread Laurent Vivier
Le 03/11/2022 à 12:32, Alex Bennée a écrit : Laurent Vivier writes: Le 03/11/2022 à 11:23, Alex Bennée a écrit : This avoids some compilers complaining about a potentially un-initialised [src|dst]argv. In retrospect using GString was overkill for what we are constructing. Signed-off-by

Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram backends

2022-11-03 Thread Laurent Vivier
On 11/3/22 12:07, Philippe Mathieu-Daudé wrote: On 3/11/22 10:33, Laurent Vivier wrote: On 10/28/22 07:04, Jason Wang wrote: 在 2022/10/21 17:09, Laurent Vivier 写道: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- I got this: 63/63 ERROR:../tests/qtest/netdev-socket.c:139

Re: [PATCH] tests/unit: simpler variable sequence for test-io-channel

2022-11-03 Thread Laurent Vivier
, " PIPE:%s,rdonly -", fifo); - -srcargv = g_strsplit(srcargs->str, " ", -1); -dstargv = g_strsplit(dstargs->str, " ", -1); - src = QIO_CHANNEL(qio_channel_command_new_spawn((const char **) srcargv, O_W

Re: [PATCH] tests/unit/test-io-channel-command: Silence GCC error "maybe-uninitialized"

2022-11-03 Thread Laurent Vivier
Le 02/11/2022 à 21:24, Alex Bennée a écrit : Bernhard Beschow writes: GCC issues a false positive warning, resulting in build failure with -Werror: In file included from /usr/lib/glib-2.0/include/glibconfig.h:9, from /usr/include/glib-2.0/glib/gtypes.h:34,

Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram backends

2022-11-03 Thread Laurent Vivier
On 10/28/22 07:04, Jason Wang wrote: 在 2022/10/21 17:09, Laurent Vivier 写道: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- I got this: 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed (resp == expect): ("st0: index=0,type=s

[PULL 1/4] linux-user/hppa: Detect glibc ABORT_INSTRUCTION and EXCP_BREAK handler

2022-11-03 Thread Laurent Vivier
off-by: Helge Deller Message-Id: Signed-off-by: Laurent Vivier --- linux-user/hppa/cpu_loop.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/linux-user/hppa/cpu_loop.c b/linux-user/hppa/cpu_loop.c index 1ef3b461911c..8ab133510602 100644 --- a/linux-user/h

[PULL 3/4] linux-user: Add strace output for timer_settime64() syscall

2022-11-03 Thread Laurent Vivier
From: Helge Deller Add missing timer_settime64() strace output and specify format for timer_settime(). Signed-off-by: Helge Deller Message-Id: Signed-off-by: Laurent Vivier --- linux-user/strace.list | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-user

[PULL 4/4] linux-user: always translate cmsg when recvmsg

2022-11-03 Thread Laurent Vivier
ng to access uninitialized memory if it expects cmsg. Always call the function that translate cmsg when recvmsg, because that function should be empty-cmsg-safe (it creates an empty cmsg in the target). Signed-off-by: Icenowy Zheng Reviewed-by: Laurent Vivier Message-Id: <20221028081220.1

[PULL 0/4] Linux user for 7.2 patches

2022-11-03 Thread Laurent Vivier
The following changes since commit a11f65ec1b8adcb012b89c92819cbda4dc25aaf1: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2022-11-01 13:49:33 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git tags/linux-user-for-7.

[PULL 2/4] linux-user: Add close_range() syscall

2022-11-03 Thread Laurent Vivier
From: Helge Deller Signed-off-by: Helge Deller Reviewed-by: Richard Henderson Message-Id: Signed-off-by: Laurent Vivier --- linux-user/strace.list | 3 +++ linux-user/syscall.c | 19 +++ 2 files changed, 22 insertions(+) diff --git a/linux-user/strace.list b/linux-user

Re: [PATCH 3/3] target/tricore: Rename csfr.def -> csfr.h.inc

2022-11-02 Thread Laurent Vivier
Le 26/10/2022 à 01:50, Philippe Mathieu-Daudé a écrit : We use the .h.inc extension to include C headers. To be consistent with the rest of the codebase, rename the C headers using the .def extension. IDE/tools using our .editorconfig / .gitattributes will leverage this consistency. Signed-off-

Re: [PATCH 2/3] target/s390x: Rename insn-data/format.def -> insn-data/format.h.inc

2022-11-02 Thread Laurent Vivier
Le 26/10/2022 à 01:50, Philippe Mathieu-Daudé a écrit : We use the .h.inc extension to include C headers. To be consistent with the rest of the codebase, rename the C headers using the .def extension. IDE/tools using our .editorconfig / .gitattributes will leverage this consistency. Signed-off-

Re: [PATCH 1/3] target/m68k: Rename qregs.def -> qregs.h.inc

2022-11-02 Thread Laurent Vivier
Le 26/10/2022 à 01:50, Philippe Mathieu-Daudé a écrit : We use the .h.inc extension to include C headers. To be consistent with the rest of the codebase, rename the C headers using the .def extension. IDE/tools using our .editorconfig / .gitattributes will leverage this consistency. Signed-off-

Re: [PATCH 3/3] libvhost-user: Add format attribute to local function vu_panic

2022-11-02 Thread Laurent Vivier
Le 22/04/2022 à 09:01, Stefan Weil a écrit : Signed-off-by: Stefan Weil --- It would be good to add format attributes to local functions, too (like it is done here) to avoid future format bugs. The changes here could be simplified by including a glib header, but from the comments I assumed tha

Re: [PATCH 2/3] libvhost-user: Fix format strings

2022-11-02 Thread Laurent Vivier
Le 22/04/2022 à 09:01, Stefan Weil a écrit : Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c index 2d29140a8f

Re: [PATCH 1/3] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

2022-11-02 Thread Laurent Vivier
Le 22/04/2022 à 09:01, Stefan Weil a écrit : Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil --- This patch was already sent to the list and got reviewed, but missed release 7.0.0. subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations

2022-11-02 Thread Laurent Vivier
Le 31/10/2022 à 22:35, Chuck Zmudzinski a écrit : When Qemu is built with --enable-xen and --disable-xen-pci-passthrough and the target os is linux, the build fails with: meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist. Fixes: 582ea95f5f93 ("meson: convert hw/xen") Signed-off-by:

Re: [PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

2022-11-02 Thread Laurent Vivier
Le 31/10/2022 à 14:17, Stefan Weil via a écrit : Am 31.10.22 um 11:28 schrieb Philippe Mathieu-Daudé: On 31/10/22 10:57, Stefan Weil via wrote: Signed-off-by: Stefan Weil ---   MAINTAINERS | 1 +   1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé Cc qemu-trivial If

Re: [PATCH v2] Fix some typos in documentation and comments

2022-11-02 Thread Laurent Vivier
Le 31/10/2022 à 14:22, Stefan Weil via a écrit : Am 31.10.22 um 08:35 schrieb Thomas Huth: On 30/10/2022 11.59, Stefan Weil wrote: Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil --- v2: Fixes from Peter Maydell's comments My focus was fixing typos which are r

Re: [PATCH] qapi: virtio: Fix the introduced version

2022-11-02 Thread Laurent Vivier
Le 01/11/2022 à 02:46, Han Han a écrit : The items of qapi/virtio.json are introduced at a5ebce38576. They will be in the version 7.2 not 7.1. Signed-off-by: Han Han --- qapi/virtio.json | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/

Re: [PATCH] tests/unit/test-io-channel-command: Silence GCC error "maybe-uninitialized"

2022-11-02 Thread Laurent Vivier
Le 01/11/2022 à 22:39, Bernhard Beschow a écrit : GCC issues a false positive warning, resulting in build failure with -Werror: In file included from /usr/lib/glib-2.0/include/glibconfig.h:9, from /usr/include/glib-2.0/glib/gtypes.h:34, from /usr/includ

Re: [PATCH] linux-user: always translate cmsg when recvmsg

2022-11-02 Thread Laurent Vivier
Le 28/10/2022 à 10:12, Icenowy Zheng a écrit : It's possible that a message contains both normal payload and ancillary data in the same message, and even if no ancillary data is available this information should be passed to the target, otherwise the target cmsghdr will be left uninitialized and

Re: [PATCH] linux-user: Add strace output for timer_settime64() syscall

2022-11-02 Thread Laurent Vivier
Le 24/10/2022 à 22:45, Helge Deller a écrit : Add missing timer_settime64() strace output and specify format for timer_settime(). Signed-off-by: Helge Deller diff --git a/linux-user/strace.list b/linux-user/strace.list index cd995e5d56..3a898e2532 100644 --- a/linux-user/strace.list +++ b/linu

Re: [PATCH] linux-user/hppa: Detect glibc ABORT_INSTRUCTION and EXCP_BREAK handler

2022-11-02 Thread Laurent Vivier
Le 27/10/2022 à 08:58, Helge Deller a écrit : The glibc on the hppa platform uses the "iitlbp %r0,(%sr0, %r0)" assembler instruction as ABORT_INSTRUCTION. If this (in userspace context) illegal assembler statement is found, dump the registers and report the failure to userspace the same way as th

Re: [PATCH v5] linux-user: Add close_range() syscall

2022-11-02 Thread Laurent Vivier
Le 25/10/2022 à 04:34, Helge Deller a écrit : Signed-off-by: Helge Deller --- Changes: v5: Simplify check of arg2 against target_fd_max even more v4: Fix check of arg2 v3: fd_trans_unregister() only called if close_range() doesn't fail v2: consider CLOSE_RANGE_CLOEXEC flag diff --git a/linux-us

Re: [PATCH] linux-user: always translate cmsg when recvmsg

2022-11-02 Thread Laurent Vivier
file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Laurent Vivier

Re: [PATCH] linux-user: implement execveat

2022-11-01 Thread Laurent Vivier
Le 31/10/2022 à 09:40, Drew DeVault a écrit : References: https://gitlab.com/qemu-project/qemu/-/issues/1007 Signed-off-by: Drew DeVault --- linux-user/syscall.c | 50 ++-- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/linux-user/syscal

Re: [PATCH] qapi: virtio: Fix the introduced version

2022-11-01 Thread Laurent Vivier
: Laurent Vivier

Re: [PATCH v2 0/2] linux-user: handle /proc/self/exe with execve() syscall

2022-10-26 Thread Laurent Vivier
Le 26/10/2022 à 17:25, Michael Tokarev a écrit : 27.09.2022 15:43, Laurent Vivier wrote: Use exec_path to re-execute the binary from /proc/self/exe Fix do_openat() that should not use execfd. v2: - don't use execfd as it can't be closed and is usable by the child Why can't

Re: [PATCH 1/3] target/m68k: Rename qregs.def -> qregs.h.inc

2022-10-26 Thread Laurent Vivier
global_mem_new_i64(cpu_env, \ offsetof(CPUM68KState, offset), #name); -#include "qregs.def" +#include "qregs.h.inc" #undef DEFO32 #undef DEFO64 Reviewed-by: Laurent Vivier

Re: [PULL 00/11] Trivial branch for 7.2 patches

2022-10-25 Thread Laurent Vivier
Le 25/10/2022 à 09:39, Laurent Vivier a écrit : The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6: Merge tag 'pull-target-arm-20221020' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 14:36:12 -0400) are available in the Git

[PULL 7/8] linux-user: Implement faccessat2

2022-10-25 Thread Laurent Vivier
cessat2) in syscall.c, adding defined(TARGET_NR_faccessat2) on print_faccessat()] Signed-off-by: Laurent Vivier --- linux-user/strace.c| 2 +- linux-user/strace.list | 3 +++ linux-user/syscall.c | 9 + 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/linux-user

[PULL 00/11] Trivial branch for 7.2 patches

2022-10-25 Thread Laurent Vivier
The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6: Merge tag 'pull-target-arm-20221020' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 14:36:12 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git

[PULL 00/11] Trivial branch for 7.2 patches

2022-10-25 Thread Laurent Vivier
The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6: Merge tag 'pull-target-arm-20221020' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 14:36:12 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git

[PULL 00/11] Trivial branch for 7.2 patches

2022-10-25 Thread Laurent Vivier
The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6: Merge tag 'pull-target-arm-20221020' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 14:36:12 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git

[PULL 00/11] Trivial branch for 7.2 patches

2022-10-25 Thread Laurent Vivier
The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6: Merge tag 'pull-target-arm-20221020' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 14:36:12 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git

[PULL 00/11] Trivial branch for 7.2 patches

2022-10-25 Thread Laurent Vivier
The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6: Merge tag 'pull-target-arm-20221020' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 14:36:12 -0400) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git

[PULL 4/8] linux-user: don't use AT_EXECFD in do_openat()

2022-10-25 Thread Laurent Vivier
exec_path. Signed-off-by: Laurent Vivier Message-Id: <20220927124357.688536-3-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a7a290

[PULL 3/8] linux-user: handle /proc/self/exe with execve() syscall

2022-10-25 Thread Laurent Vivier
If path is /proc/self/exe, use the executable path provided by exec_path. Don't use execfd as it is closed by loader_exec() and otherwise will survive to the exec() syscall and be usable child process. Signed-off-by: Laurent Vivier Message-Id: <20220927124357.688536-2-laur...@vivier.eu

[PULL 6/8] linux-user: remove conditionals for many fs.h ioctls

2022-10-25 Thread Laurent Vivier
definitions in syscall.c anyway thanks to the previous patch. Thus we can assume they always exist and remove the conditional checks. Signed-off-by: Daniel P. Berrangé Reviewed-by: Laurent Vivier Message-Id: <20221004093206.652431-3-berra...@redhat.com> Signed-off-by: Laurent Vivier --- linu

[PULL 1/8] linux-user: Fix more MIPS n32 syscall ABI issues

2022-10-25 Thread Laurent Vivier
eviewed-by: Jiaxun Yang Tested-by: Jiaxun Yang Tested-by: Andreas K. Huettel Message-Id: <20221006085500.290341-1-xe...@gentoo.org> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/linux-user/syscal

<    1   2   3   4   5   6   7   8   9   10   >