Lluís Vilanova writes:
[...]
Changes in v7:
* Fix backend/format to module name translations.
I'm really sorry for the late flooding. This time it's build-tested with future
series that use the now-fixed features.
Lluis
--
And it's much the same thing with knowledge, for whenever you
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/ust.py | 90 ++
1 files changed, 90 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/backend/ust.py
diff --git a/scripts/tracetool/backend/ust.py b/scripts
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/stderr.py | 56 +++
1 files changed, 56 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/backend/stderr.py
diff --git a/scripts/tracetool/backend/stderr.py
b
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/format/h.py | 45 +
1 files changed, 45 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/format/h.py
diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.objs |6
Makefile.target | 13 -
configure |4
scripts/tracetool | 648 -
scripts/tracetool.py
A full rewrite of the tracetool script using per-format and per-backend modules,
so that it's easier to read and extend it in the future.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
NOTE: This series applies in current master, ignoring the Rewrite tracetool
using python series
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/format/c.py | 20
1 files changed, 20 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/format/c.py
diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py
new file
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/format/h.py | 45 +
1 files changed, 45 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/format/h.py
diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/stderr.py | 56 +++
1 files changed, 56 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/backend/stderr.py
diff --git a/scripts/tracetool/backend/stderr.py
b
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.objs |6
Makefile.target | 13 -
configure |4
scripts/tracetool | 648 -
scripts/tracetool.py
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py| 32 +++-
scripts/tracetool/__init__.py | 11
scripts/tracetool/backend/dtrace.py | 97 +++
scripts/tracetool/format/d.py | 20
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
MAINTAINERS |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f83d07c2..0e66dd8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -548,6 +548,8 @@ Tracing
M: Stefan Hajnoczi stefa
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/ust.py | 90 ++
1 files changed, 90 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/backend/ust.py
diff --git a/scripts/tracetool/backend/ust.py b/scripts
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/simple.py | 55 +++
1 files changed, 55 insertions(+), 0 deletions(-)
create mode 100644 scripts/tracetool/backend/simple.py
diff --git a/scripts/tracetool/backend/simple.py
b
Lluís Vilanova writes:
Provides a generic event state description and a more detailed event control
and
query interface.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
ping
Changes in v4:
* Documentation fixes and (re)formatting.
Changes in v3:
* Add some assertions
Stefan Hajnoczi writes:
On Tue, May 8, 2012 at 3:38 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 8946a10
Stefan Hajnoczi writes:
On Tue, May 8, 2012 at 3:38 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Public backends are those printed by --list-backends and thus considered
valid
by the configure script.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py
Stefan Hajnoczi writes:
On Tue, May 8, 2012 at 3:38 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Provides a generic event state description and a more detailed event control
and
query interface.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
[...]
What is the point of sstate vs
Stefan Hajnoczi writes:
On Mon, Jun 11, 2012 at 12:12 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Stefan Hajnoczi writes:
On Tue, May 8, 2012 at 3:38 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Provides a generic event state description and a more detailed event
control and
query
Lluís Vilanova writes:
Stefan Hajnoczi writes:
On Tue, May 8, 2012 at 3:38 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/monitor.c b
(i.e., not
selectable by the user at configure time) that will generate the appropriate
event description information.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Changes in v5:
* Rebase on dbaf26b3 from master.
* Always initialize temporary 'ev' in 'trace_backend_init_events'.
* Make
backend (events-h frontend).
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile |5 +++
Makefile.objs| 21 ++
scripts/tracetool/backend/events.py | 23
scripts/tracetool/format/events_c.py | 39
This interface decouples event obtention from interaction.
Events can be obtained through three different methods:
* identifier
* name
* simple wildcard pattern
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
docs/tracing.txt | 42 --
trace/control-internal.h | 67
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index a3bc2c7..83ce956 100644
--- a/monitor.c
+++ b/monitor.c
@@ -589,10 +589,19 @@ static void do_trace_event_set_state
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
trace/default.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/trace/default.c b/trace/default.c
index c9b27a2..6e07a47 100644
--- a/trace/default.c
+++ b/trace/default.c
@@ -1,7 +1,7 @@
/*
* Default
Public backends are those printed by --list-backends and thus considered valid
by the configure script.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py |4 ++--
scripts/tracetool/backend/__init__.py | 16 +++-
scripts/tracetool
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/stderr.py | 27 ---
trace/stderr.c | 34 ++
2 files changed, 14 insertions(+), 47 deletions(-)
diff --git a/scripts/tracetool/backend
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/simple.py | 12 +---
trace/simple.c | 36 ---
trace/simple.h |6 +-
trace/stderr.h | 11
Stefan Hajnoczi writes:
On Wed, Jun 13, 2012 at 4:14 AM, 陳韋任 (Wei-Ren Chen)
che...@iis.sinica.edu.tw wrote:
I suspect that guest memory access (qemu_ld/qemu_st) account for the major
of
time spent in system mode. I would like to know precisely how much (if
possible).
We use tools like
(i.e., not
selectable by the user at configure time) that will generate the appropriate
event description information.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Changes in v6:
* Fixed typos in the documentation of the 'TraceEvent' struct.
Changes in v5:
* Rebase on dbaf26b3 from
Public backends are those printed by --list-backends and thus considered valid
by the configure script.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py |4 ++--
scripts/tracetool/backend/__init__.py | 16 +++-
scripts/tracetool
backend (events-h frontend).
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile |5 +++
Makefile.objs| 21 ++
scripts/tracetool/backend/events.py | 23
scripts/tracetool/format/events_c.py | 39
This interface decouples event obtention from interaction.
Events can be obtained through three different methods:
* identifier
* name
* simple wildcard pattern
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
docs/tracing.txt | 42 --
trace/control-internal.h | 67
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/simple.py | 12 +---
trace/simple.c | 36 ---
trace/simple.h |6 +-
trace/stderr.h | 11
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index a3bc2c7..83ce956 100644
--- a/monitor.c
+++ b/monitor.c
@@ -589,10 +589,19 @@ static void do_trace_event_set_state
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/stderr.py | 27 ---
trace/stderr.c | 34 ++
2 files changed, 14 insertions(+), 47 deletions(-)
diff --git a/scripts/tracetool/backend
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
trace/default.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/trace/default.c b/trace/default.c
index c9b27a2..6e07a47 100644
--- a/trace/default.c
+++ b/trace/default.c
@@ -1,7 +1,7 @@
/*
* Default
陳韋任 (Wei-Ren Chen) writes:
On Wed, Jun 13, 2012 at 12:43:28PM +0200, Laurent Desnogues wrote:
On Wed, Jun 13, 2012 at 5:14 AM, 陳韋任 (Wei-Ren Chen)
che...@iis.sinica.edu.tw wrote:
Hi all,
I suspect that guest memory access (qemu_ld/qemu_st) account for the
major of
time spent in
陳韋任 (Wei-Ren Chen) writes:
Unfortunately, I had the bad idea of rebasing all my series on top of the
latest
makefile changes, and I'll have to go through each patch to check it's still
working (I'm sure some of them broke).
Need some help? :)
Well, it's just a matter of going through
Laurent Desnogues writes:
On Fri, Jun 15, 2012 at 12:30 AM, Lluís Vilanova vilan...@ac.upc.edu wrote:
[...]
Now that I think of it, you will have problems generating code to surround
each
qemu_ld/st with a lightweight mechanism to get the time. In x86 it would be
rdtsc, but you want
陳韋任 (Wei-Ren Chen) writes:
The reason why we want to do the measuring is we want to use KVM (sounds
crazy
idea) MMU virtualization to speedup the guest - host memory address
translation.
I talked to some people on LinuxCon Japan, included Paolo, about this idea.
The
feedback I got is we
Blue Swirl writes:
On Mon, Jun 18, 2012 at 8:28 AM, 陳韋任 (Wei-Ren Chen)
che...@iis.sinica.edu.tw wrote:
The reason why we want to do the measuring is we want to use KVM (sounds
crazy
idea) MMU virtualization to speedup the guest - host memory address
translation.
I talked to some people
Michael Kang writes:
On Tue, Jun 19, 2012 at 4:26 AM, Lluís Vilanova vilan...@ac.upc.edu wrote:
[...]
I could understand having multiple 32bit regions in QEMU's virtual space (no
need for KVM), one per guest page table, and then simply adding an offset to
every memory access to redirect
Xin Tong writes:
i do not know. could be similar. I am doing architecture research. i
need traces of memory access for programming running under a full
system environment, so i wrote this.
i do nto seem to be able to access the linked provided from the link
you give me though.
Sorry, it's up again. The server is low on RAM and Linux' OOM killer kicks in
sometimes.
Lluis
陳韋任 (Wei-Ren Chen) writes:
Hi Liuis,
On Tue, Sep 04, 2012 at 10:08:09PM +0200, Lluís Vilanova wrote:
Hi there,
Given that right now I don't have enough time to write the paper that should
陳韋任 (Wei-Ren Chen) writes:
On Fri, Sep 21, 2012 at 03:39:32PM +0200, Lluís Vilanova wrote:
Sorry, it's up again. The server is low on RAM and Linux' OOM killer kicks in
sometimes.
Thanks. I am playing around your qemu-dbi, and has error below.
$ make
LINK i386-softmmu/qemu-system
Harsh Prateek Bora writes:
This patchset introduces 2 major updates:
1) Tracetool Improvements (Conversion from shell script to python)
2) Simpletrace v2 log format (Support for variable args, strings)
ping
Lluis
--
And it's much the same thing with knowledge, for whenever you learn
Pass all the relevant sub-directory make variables.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Cc: Anthony Liguori aligu...@us.ibm.com
Cc: Paul Brook p...@codesourcery.com
---
Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index
Harsh Bora writes:
On 03/01/2012 11:33 AM, Harsh Bora wrote:
On 02/29/2012 01:53 AM, Lluís Vilanova wrote:
Harsh Prateek Bora writes:
This patchset introduces 2 major updates:
1) Tracetool Improvements (Conversion from shell script to python)
2) Simpletrace v2 log format (Support
Benoît Canet writes:
Hello dear list,
I am looking for screenshots of QEMU running a large variety of guest.
The screenshots will be used in the new wiki theme matching the QEMU logo.
Work in progress of the new theme can be found here
: http://www.nodalink.com/qemu/Main_Page
Screenshot
Current code depends on variables defined in config-host.mak before it is
actually included.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Cc: Anthony Liguori aligu...@us.ibm.com
Cc: Paul Brook p...@codesourcery.com
---
Makefile | 15 ---
1 files changed, 8 insertions(+), 7
Stefan Hajnoczi writes:
On Mon, Mar 12, 2012 at 9:34 AM, Kevin Wolf kw...@redhat.com wrote:
It has happened more than once that patches that look perfectly sane
and work with simpletrace broke systemtap because they use 'next' as an
argument name for a tracing function. However, 'next' is a
Harsh Prateek Bora writes:
diff --git a/docs/tracing.txt b/docs/tracing.txt
index 95ca16c..ab9048c 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -39,12 +39,12 @@ generate code for the trace events. Trace events are
invoked directly from
source code like this:
#include
Yue Chen writes:
Thanks a lot. So any approach to get the dynamic or static whole memory
information of the guest OS ? Not the memory of each process.
Sorry for the confusion. I do use version 1.0.1. I mention not in 0.9.1
because
someone has already implemented the dynamic tracing in
Stefano Stabellini writes:
[...]
Patches are being posted to the list that don't get any reviews at all.
Other patches get reviewed the first time, then once they are reposted
they don't get any other reviews or acked-by or reviewed-by.
What are the different tags available and what is their
Anthony Liguori writes:
[...]
My understanding until now was that both Acked-by and Reviewed-by were tags
reserved to people with privileges to write into the repository.
That's interesting feedback. These are all documented throughly in Linux's
SubmittingPatches (which I think ours refers
Anthony Liguori writes:
[...]
For v2, I'm relying on a fork of gtk-doc that removes the underscore
requirements. I really hate to do this but I like it better than not having
documentation. I'm poking in the gtk+ community to see if there's an upstream
compromise possible.
I don't want to
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py | 18 --
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index 079ec7a..26a4c43 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
The first patch in the series (by Harsh Prateek) is a rewrite of the tracetool
shell script in python, which is easier to handle given the current complexity
of the script.
The following patches (by Lluís Vilanova) add a series of random code cleanups
and generalizations.
Signed-off-by: Lluís
Use different converters (depending on the 'disabled' property) regardless of
the output format.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py | 20 +++-
1 files changed, 11 insertions(+), 9
Harsh Prateek Bora writes:
This patchset introduces 2 major updates:
1) Tracetool Improvements (Conversion from shell script to python)
2) Simpletrace v2 log format (Support for variable args, strings)
Existing simple trace can log upto 6 args per trace event and does not
support strings in
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.objs|6
Makefile.target | 10 -
configure|7 -
scripts/tracetool| 648 --
scripts
Unifies the print+exit sequence into a single 'error' call.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py | 27 +++
1 files changed, 15 insertions(+), 12 deletions(-)
diff --git
An event number is implicit in its position on the list of events.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py | 21 +
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git
Adds an 'Arguments' class to describe event arguments.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py | 113 --
1 files changed, 54 insertions(+), 59 deletions
First, routines for format-specific code are not mandatory.
Second, all format-specific routines get the list of events as an argument.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py | 32
Using regular expressions yields more compact and error-proof code when breaking
the event properties into pieces.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py | 14 +++---
1 files changed, 7
Using regular expressions yields more compact and error-proof code when breaking
the lines into pieces.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py | 43 +++
1
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index 26a4c43..71ef16c 100755
Revives the functionality introduced by commit b7d66a76, which was temporarily
removed on the tracetool conversion performed during this series.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com
---
scripts/tracetool.py |7 +++
1
Adds decorators to establish which backend and/or format each routine is meant
to process.
With this, tables enumerating format and backend routines can be eliminated and
part of the usage message can be computed in a more generic way.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off
Lluís Vilanova writes:
NOTE: Applies on top of the tracetool improvements series.
Some trivial changes to handle tracetool-generated files more concisely.
Please disregard this series; it will be resent after acceptance of the
tracetool rewrite.
Thanks,
Lluis
--
And it's much the same
Lluís Vilanova writes:
NOTE: Applies on top of the tracetool-handling trivial changes.
Provides a generic event state description and a more detailed event control
and
query interface.
Please disregard this series; it will be resent after acceptance of the
tracetool rewrite.
Thanks
Lluís Vilanova writes:
NOTE: Depend's on Harsh's port of tractool to python.
A general overhaul of the pythonic tracetool script to allow simpler future
extensions.
Please disregard this series; it has been superseded by the latest tracetool
rewrite series.
Thanks,
Lluis
--
And it's
Provides a generic event state description and a more detailed event control and
query interface.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Changes in v4:
* Documentation fixes and (re)formatting.
Changes in v3:
* Add some assertions.
* Remove debugging printf's.
* Improve
Uses tracetool to generate a backend-independent tracing event description.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile |5 +++
Makefile.objs| 21 ++
scripts/tracetool/backend/events.py | 23
Public backends are those printed by --list-backends and thus considered valid
by the configure script.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py |4 ++--
scripts/tracetool/backend/__init__.py | 16 +++-
scripts/tracetool
This interface decouples event obtention from interaction.
Events can be obtained through three different methods:
* identifier
* name
* simple wildcard pattern
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
docs/tracing.txt | 42 --
trace/control-internal.h | 60
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/stderr.py | 27 ---
trace/stderr.c | 35 +++
2 files changed, 15 insertions(+), 47 deletions(-)
diff --git a/scripts/tracetool/backend
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/simple.py | 12 +--
trace/simple.c | 37 +--
trace/simple.h |6 +-
trace/stderr.h | 11 --
4
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
monitor.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 8946a10..86c2538 100644
--- a/monitor.c
+++ b/monitor.c
@@ -625,10 +625,19 @@ static void do_trace_event_set_state
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
trace/default.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/trace/default.c b/trace/default.c
index c9b27a2..3c41990 100644
--- a/trace/default.c
+++ b/trace/default.c
@@ -1,7 +1,7 @@
/*
* Default
of the event.
Prevent greedy matching from going too far by explicitly saying the name
cannot have a ''. This forces the regular expression engine to
backtrack to the desired match.
Reported-by: Bob Breuer breu...@mc.net
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
Reviewed-by: Lluís
Paolo Bonzini writes:
One source of complexity in the QEMU source is that we have a very
shallow tree for a source code of over 750,000 lines of code. In
fact, one third of these lines alone is in one directory, hw/.
As a prerequisite to cleaning up the structure, but as a worthwhile
step
Paolo Bonzini writes:
Il 04/06/2012 00:57, Anthony Liguori ha scritto:
As before, I dislike the use of the filename Makefile for files that
are not self-contained. If make is called from that deep directory, it
leads to undefined results. Either we must make sure through some clever
Stefan Hajnoczi writes:
Excellent, thank you!
There was a conflict qemu.git/master and Patch 1 which I have tried to
resolve. I also added commit descriptions to the first and last patches
to capture the rationale behind these changes.
Please check the tracing tree to confirm that you are
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 135cb72..8179966 100644
--- a/Makefile
+++ b/Makefile
@@ -23,7 +23,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
GENERATED_HEADERS
Some trivial changes to handle tracetool-generated files more concisely.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
NOTE: Applies on top of the tracetool rewrite.
Lluís Vilanova (2):
[trivial] Generic elimination of auto-generated files
[trivial] Simpler handling
Adds 'tracetool-gen' to generate files with tracetool into a temporary file, and
'tracetool-ci' to commit the generation from the temporaty file into the
actual destination file if there were any changes in the produced file.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.objs
...@linux.vnet.ibm.com
Reviewed-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/backend/dtrace.py |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/tracetool/backend/dtrace.py
b/scripts/tracetool/backend/dtrace.py
index cebbd57..9cab75c 100644
Stefan Hajnoczi writes:
On Sat, Apr 14, 2012 at 12:19:03AM +0200, Lluís Vilanova wrote:
-rm -f $(GENERATED_HEADERS)
-rm -f $(GENERATED_SOURCES)
+rm -f $(foreach f,$(GENERATED_HEADERS),$(f) $(f)-timestamp */$(f)
*/$(f)-timestamp)
+rm -f $(foreach f,$(GENERATED_SOURCES),$(f
Stefan Hajnoczi writes:
On Sat, Apr 14, 2012 at 12:19:08AM +0200, Lluís Vilanova wrote:
trace.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
-$(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
--format=h --backend=$(TRACE_BACKEND) $ $@, GEN trace.h
Stefan Hajnoczi writes:
On Wed, Apr 18, 2012 at 2:37 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Stefan Hajnoczi writes:
On Sat, Apr 14, 2012 at 12:19:03AM +0200, Lluís Vilanova wrote:
- rm -f $(GENERATED_HEADERS)
- rm -f $(GENERATED_SOURCES)
+ rm -f $(foreach f
Andreas Färber writes:
Am 18.04.2012 16:11, schrieb Stefan Hajnoczi:
On Wed, Apr 18, 2012 at 2:37 PM, Lluís Vilanova vilan...@ac.upc.edu wrote:
Stefan Hajnoczi writes:
On Sat, Apr 14, 2012 at 12:19:03AM +0200, Lluís Vilanova wrote:
-rm -f $(GENERATED_HEADERS)
-rm -f
Some trivial changes to handle tracetool-generated files more concisely.
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
NOTE: Applies on top of the tracetool rewrite.
Changes in v2:
* Only remove tracetool-generated files that were actually produced by the
top-level makefile.
* Dropped
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index 135cb72..5dd2a8c 100644
--- a/Makefile
+++ b/Makefile
@@ -23,7 +23,7 @@ ifeq ($(TRACE_BACKEND),dtrace)
GENERATED_HEADERS
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
---
Makefile.objs | 22 +++---
Makefile.target |4 ++--
rules.mak |3 +++
3 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
index 6d6f24d..70c5c79 100644
...@linux.vnet.ibm.com
Reviewed-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index cacfd99..c003cf6 100755
--- a/scripts/tracetool.py
+++ b/scripts
...@linux.vnet.ibm.com
Reviewed-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index cacfd99..c003cf6 100755
--- a/scripts/tracetool.py
+++ b/scripts
Stefan Hajnoczi writes:
In Python 2.5 keyword arguments were added to __import__(). Avoid using
them to achieve Python 2.4 compatibility.
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
Reviewed-by: Lluís Vilanova vilan...@ac.upc.edu
---
scripts/tracetool/__init__.py |2
301 - 400 of 1843 matches
Mail list logo
