Re: [Qemu-devel] [PATCH 1/2] qemu-char: Introduce Buffered driver

2010-11-10 Thread Luiz Capitulino
On Wed, 10 Nov 2010 14:33:47 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 10 Nov 2010 13:56:39 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 10 Nov 2010 10:26:15

[Qemu-devel] [PATCH v2 0/3]: QMP: Human Monitor passthrough

2010-11-10 Thread Luiz Capitulino
Simple example: - { execute: hmp_passthrough, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Please, check individual patches for details. Also note that this series depends on the script improvements one. changelog - v1 - v2 - A number of small cleanups and

[Qemu-devel] [PATCH] ioport: Fix duplicated code

2010-11-10 Thread Luiz Capitulino
Functions register_ioport_read() and register_ioport_write() are almost identical, the only difference is that they write to different arrays. Introduce register_ioport() to handle this difference and change both functions to use it instead of duplicating code. Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH 3/3] QMP/qmp-shell: Introduce HMP mode

2010-11-10 Thread Luiz Capitulino
e1000.0: model=e1000,macaddr=52:54:00:12:34:56 Devices not on any VLAN: (QEMU) Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-shell | 75 - 1 files changed, 74 insertions(+), 1 deletions(-) diff --git a/QMP/qmp

[Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-10 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 39

[Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-10 Thread Luiz Capitulino
to be used by the monitor's HMP passthrough via QMP feature, which needs to run monitor handlers without a backing device. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-char.c | 66 +++ qemu-char.h |6 + 2 files

[Qemu-devel] [PATCH v2] ioport: Fix duplicated code

2010-11-11 Thread Luiz Capitulino
Functions register_ioport_read() and register_ioport_write() are almost identical, the only difference is that they write to different arrays. Introduce register_ioport_rw() to handle this difference and change both functions to use it instead of duplicating code. Signed-off-by: Luiz Capitulino

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:30:26 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This driver handles in-memory chardev operations. That's, all writes to this driver are stored in an internal buffer and it doesn't talk to the external world

Re: [Qemu-devel] [PATCH v1 0/3]: QMP: Human Monitor passthrough

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 18:22:13 +0200 Avi Kivity a...@redhat.com wrote: On 10/29/2010 04:28 PM, Luiz Capitulino wrote: Simple example: - { execute: hmp_passthrough, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Why are the names so cryptic? - { execute

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:39:52 + Daniel P. Berrange berra...@redhat.com wrote: On Thu, Nov 11, 2010 at 10:30:47AM -0600, Anthony Liguori wrote: On 11/11/2010 09:55 AM, Daniel P. Berrange wrote: On Thu, Nov 11, 2010 at 04:47:41PM +0100, Markus Armbruster wrote: 3. Query Commands

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:47:41 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 10 Nov 2010 14:20:12 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: [...] diff --git a/qmp

Re: [Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 16:47:52 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-11 Thread Luiz Capitulino
On Thu, 11 Nov 2010 17:32:06 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 16:30:26 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This driver handles in-memory

[Qemu-devel] [PATCH v3 0/3]: QMP: Human Monitor passthrough

2010-11-11 Thread Luiz Capitulino
Simple example: - { execute: human-monitor-command, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Please, check individual patches for details. Also note that this series depends on the script improvements one. Also, Markus suggestion of having an assert() in

[Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-11 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 38

[Qemu-devel] [PATCH 3/3] QMP/qmp-shell: Introduce HMP mode

2010-11-11 Thread Luiz Capitulino
e1000.0: model=e1000,macaddr=52:54:00:12:34:56 Devices not on any VLAN: (QEMU) Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-shell | 75 - 1 files changed, 74 insertions(+), 1 deletions(-) diff --git a/QMP/qmp

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 11:16:54 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 17:32:06 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 16:30:26

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 11:21:57 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This driver handles in-memory chardev operations. That's, all writes to this driver are stored in an internal buffer and it doesn't talk to the external world

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 15:16:33 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:21:57 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: [...] +QString

[Qemu-devel] [PATCH] Makefile: Fix check dependency breakage

2010-11-12 Thread Luiz Capitulino
Commit b152aa84d52882bb1846485a89baf13aa07c86bc broke the unit-tests build, fix it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 02698e9..719aca9 100644

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 16:04:39 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 15:16:33 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:21:57

[Qemu-devel] Re: [RfC PATCH] spice: qmp windup: connection events info command.

2010-11-12 Thread Luiz Capitulino
On Thu, 11 Nov 2010 13:49:32 +0100 Gerd Hoffmann kra...@redhat.com wrote: Hi, Looking for comments especially from Luiz and Daniel (aka qmp and libvirt masters) ... This patch adds support for connection events to spice. The events are quite simliar to the vnc events. Unlike vnc

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 16:54:14 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 11:16:54 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 11 Nov 2010 17:32:06

Re: [Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-12 Thread Luiz Capitulino
On Fri, 12 Nov 2010 17:06:16 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 16:04:39 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 12 Nov 2010 15:16:33

[Qemu-devel] [PATCH 1/3] qemu-char: Introduce Memory driver

2010-11-16 Thread Luiz Capitulino
to be used by the monitor's HMP passthrough via QMP feature, which needs to run monitor handlers without a backing device. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-char.c | 64 +++ qemu-char.h |7 ++ 2 files

[Qemu-devel] [PATCH v4 0/3]: QMP: Human Monitor passthrough

2010-11-16 Thread Luiz Capitulino
Simple example: - { execute: human-monitor-command, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Please, check individual patches for details. Also note that this series depends on the script improvements one. Also, Markus suggestion of having an assert() in

[Qemu-devel] [PATCH 3/3] QMP/qmp-shell: Introduce HMP mode

2010-11-16 Thread Luiz Capitulino
e1000.0: model=e1000,macaddr=52:54:00:12:34:56 Devices not on any VLAN: (QEMU) Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-shell | 79 - 1 files changed, 78 insertions(+), 1 deletions(-) diff --git a/QMP/qmp

[Qemu-devel] [PATCH 2/3] QMP: Introduce Human Monitor passthrough command

2010-11-16 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 38

Re: [Qemu-devel] [PATCH v4 0/3]: QMP: Human Monitor passthrough

2010-11-17 Thread Luiz Capitulino
On Wed, 17 Nov 2010 11:27:31 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Simple example: - { execute: human-monitor-command, arguments: { command-line: print /i 10+25 } } - { return: 35\r\n } Please, check individual patches

[Qemu-devel] [PATCH 5/7] QMP: Introduce Human Monitor passthrough command

2010-11-17 Thread Luiz Capitulino
This command allows QMP clients to execute HMP commands. Please, check the documentation added to the qmp-commands.hx file for additional details about the interface and its limitations. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 38

[Qemu-devel] [PATCH 1/7] QMP: Revamp the Python class example

2010-11-17 Thread Luiz Capitulino
to 10 commits, it's really not worth it for a simple demo class. Highlights: o TCP sockets support o QMP events support o Add documentation o Fix a number of unhandled errors o Simplify methods that send commands to the Monitor Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP

[Qemu-devel] [PATCH 2/7] QMP: Revamp the qmp-shell script

2010-11-17 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-shell | 179 +--- 1 files changed, 144 insertions(+), 35 deletions(-) diff --git a/QMP/qmp-shell b/QMP/qmp-shell index a5b72d1..1fb7e76 100755 --- a/QMP/qmp-shell +++ b/QMP/qmp-shell @@ -1,8

[Qemu-devel] [PATCH 3/7] QMP: Drop vm-info example script

2010-11-17 Thread Luiz Capitulino
It's broken and not really useful, let's just drop it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/README |5 + QMP/vm-info | 33 - 2 files changed, 1 insertions(+), 37 deletions(-) delete mode 100755 QMP/vm-info diff --git a/QMP

[Qemu-devel] [PATCH 4/7] qemu-char: Introduce Memory driver

2010-11-17 Thread Luiz Capitulino
to be used by the monitor's HMP passthrough via QMP feature, which needs to run monitor handlers without a backing device. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-char.c | 64 +++ qemu-char.h |7 ++ 2 files

[Qemu-devel] [PATCH 6/7] QMP/qmp-shell: Introduce HMP mode

2010-11-17 Thread Luiz Capitulino
e1000.0: model=e1000,macaddr=52:54:00:12:34:56 Devices not on any VLAN: (QEMU) Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- QMP/qmp-shell | 79 - 1 files changed, 78 insertions(+), 1 deletions(-) diff --git a/QMP/qmp

Re: [Qemu-devel] Re: [PATCH 0/2] v8 Decouple block device removal from device removal

2010-11-19 Thread Luiz Capitulino
On Fri, 12 Nov 2010 18:38:57 +0100 Kevin Wolf kw...@redhat.com wrote: Am 12.11.2010 18:07, schrieb Ryan Harper: details, details, v8 This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires

Re: [Qemu-devel] Re: [PATCH 0/2] v8 Decouple block device removal from device removal

2010-11-19 Thread Luiz Capitulino
On Tue, 16 Nov 2010 15:01:12 +0100 Kevin Wolf kw...@redhat.com wrote: Am 16.11.2010 14:51, schrieb Luiz Capitulino: On Fri, 12 Nov 2010 18:38:57 +0100 Kevin Wolf kw...@redhat.com wrote: Am 12.11.2010 18:07, schrieb Ryan Harper: details, details, v8 This patch series decouples

Re: [Qemu-devel] [PULL] vhost, netdev, e1000, pci

2010-11-20 Thread Luiz Capitulino
On Tue, 16 Nov 2010 15:16:20 +0200 Michael S. Tsirkin m...@redhat.com wrote: Here are some fixes I collected in my tree. Please merge. The following changes since commit 5fc9cfedfa09199e10b5f9b67dcd286bfeae4f7a: Fold send_all() wrapper unix_write() into one function (2010-11-03 12:48:09

Re: [Qemu-devel] [PATCH v2] ioport: Fix duplicated code

2010-11-22 Thread Luiz Capitulino
On Fri, 19 Nov 2010 19:50:10 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 11/11/2010 08:03 AM, Luiz Capitulino wrote: Functions register_ioport_read() and register_ioport_write() are almost identical, the only difference is that they write to different arrays. Introduce

Re: [Qemu-devel] KVM call agenda for Nov 23

2010-11-23 Thread Luiz Capitulino
On Mon, 22 Nov 2010 17:00:41 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 11/22/2010 03:45 PM, Chris Wright wrote: * Juan Quintela (quint...@redhat.com) wrote: Please send in any agenda items you are interested in covering. usb-ccid - vcpu hard limits -

[Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type

2010-11-23 Thread Luiz Capitulino
On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped. Signed-off-by: Wen Congyang Nice catch. Was caused by 07de3e60b05 and hence affects

[Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type

2010-11-23 Thread Luiz Capitulino
On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped

[Qemu-devel] [PATCH 0/3] QMP: small fixes

2010-11-23 Thread Luiz Capitulino
Please, check individual patches for details.

[Qemu-devel] [PATCH 1/3] QMP: Fix default response regression

2010-11-23 Thread Luiz Capitulino
is emitted. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 8cee35d..c4efe58 100644 --- a/monitor.c +++ b/monitor.c @@ -4426,10 +4426,8 @@ static void qmp_call_query_cmd

[Qemu-devel] [PATCH 2/3] QMP: Drop dead code

2010-11-23 Thread Luiz Capitulino
it! Just drop it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 74 - 1 files changed, 34 insertions(+), 40 deletions(-) diff --git a/monitor.c b/monitor.c index c4efe58..30be273 100644 --- a/monitor.c +++ b

[Qemu-devel] [PATCH 3/3] QMP: Simplify monitor_json_emitter()

2010-11-23 Thread Luiz Capitulino
Use the ternary operator instead of an if (also fixes bad indentation). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 30be273..f6f2264 100644 --- a/monitor.c +++ b

[Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type

2010-11-24 Thread Luiz Capitulino
On Wed, 24 Nov 2010 09:28:54 +0800 Wen Congyang we...@cn.fujitsu.com wrote: At 2010年11月23日 21:31, Luiz Capitulino Write: On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang we...@cn.fujitsu.com wrote

[Qemu-devel] Re: [PATCH v2] correct migrate_set_speed's args_type

2010-11-25 Thread Luiz Capitulino
On Thu, 25 Nov 2010 09:06:05 +0800 Wen Congyang we...@cn.fujitsu.com wrote: The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped. This bug was caused by 07de3e60b05 and hence affects master only. Signed-off-by: Wen

[Qemu-devel] Re: [RfC PATCH] spice: qmp windup: connection events info command.

2010-11-25 Thread Luiz Capitulino
On Thu, 25 Nov 2010 12:42:52 +0100 Gerd Hoffmann kra...@redhat.com wrote: Hi, The first thing we have to check with Daniel is whether or not we're providing the info they would need/expect, Daniel? apart from that I have the following general comments: 1. It's missing

[Qemu-devel] [PULL 0/4]: Monitor queue

2010-12-06 Thread Luiz Capitulino
Anthony, QMP fixes pull request. The changes (since 2c90fe2b71df2534884bce96d90cbfcc93aeedb8) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git for-anthony Luiz Capitulino (3): QMP: Fix default response regression QMP: Drop dead code QMP

[Qemu-devel] [PATCH 3/4] QMP: Simplify monitor_json_emitter()

2010-12-06 Thread Luiz Capitulino
Use the ternary operator instead of an if (also fixes bad indentation). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 1e8b1fc..f1aebc1 100644 --- a/monitor.c +++ b

[Qemu-devel] [PATCH 2/4] QMP: Drop dead code

2010-12-06 Thread Luiz Capitulino
it! Just drop it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 74 - 1 files changed, 34 insertions(+), 40 deletions(-) diff --git a/monitor.c b/monitor.c index 1296c40..1e8b1fc 100644 --- a/monitor.c +++ b

[Qemu-devel] [PATCH 4/4] correct migrate_set_speed's args_type

2010-12-06 Thread Luiz Capitulino
-by: Luiz Capitulino lcapitul...@redhat.com --- qmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index e5f157f..3486223 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -495,7 +495,7 @@ EQMP { .name

[Qemu-devel] [PATCH 1/4] QMP: Fix default response regression

2010-12-06 Thread Luiz Capitulino
is emitted. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index ec31eac..1296c40 100644 --- a/monitor.c +++ b/monitor.c @@ -4464,10 +4464,8 @@ static void qmp_call_query_cmd

[Qemu-devel] [PATCH v1 00/25]: Monitor: First step on an internal QMP API

2010-12-06 Thread Luiz Capitulino
Today, when writing an info command that is used by QMP and HMP, the programmer has to implement: 1. The handler itself, that's the function that gathers data and returns it as QObjects 2. A pretty printing function, which is called by the human monitor to print the returned QObjects in

[Qemu-devel] [PATCH 02/25] QMP: Drop user_print usage from the qmp_query_cmds[] table

2010-12-06 Thread Luiz Capitulino
QMP doesn't use this field, it's only useful in the human monitor. NOTE: Other unused fields are going to be dropped by future commits. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git

[Qemu-devel] [PATCH 05/25] Monitor: Convert do_info_version_print() into do_info_version()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_version() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

2010-12-06 Thread Luiz Capitulino
Query handlers still carry their human monitor name. This commit renames all of them to a more QMP-like name. For example, do_info_version() is renamed to qmp_query_version(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- balloon.c |4 +- balloon.h |2 +- block.c

[Qemu-devel] [PATCH 10/25] Monitor: Convert monitor_print_cpus() into do_info_cpus()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_cpus() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH 09/25] Monitor: Move qmp_query_cpus() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change monitor_print_cpus() to call it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 78 ++-- 1 files changed, 39 insertions(+), 39 deletions(-) diff --git a/monitor.c b/monitor.c index

[Qemu-devel] [PATCH 03/25] Monitor: Drop balloon handlers comments

2010-12-06 Thread Luiz Capitulino
Commit 637503d122eb7656d91a8489e254d9e880be7504 dropped (duplicated) documentation from code, but it missed the balloon handlers. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- balloon.c | 24 1 files changed, 0 insertions(+), 24 deletions(-) diff --git

[Qemu-devel] [PATCH 06/25] Monitor: Convert qemu_chr_info_print() into qemu_chr_info()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_chardev() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |3 +-- qemu-char.c |8 ++-- qemu-char.h |2 +- 3 files changed, 8

[Qemu-devel] [PATCH 13/25] Monitor: Convert do_info_kvm_print() into do_info_kvm()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_kvm() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/monitor.c

[Qemu-devel] [PATCH 14/25] Monitor: Move qmp_query_status() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_status_print() to use it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 4286375..731cb35 100644 --- a/monitor.c +++ b

[Qemu-devel] [PATCH 04/25] Monitor: Move qmp_query_version() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_version_print() to call it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/monitor.c b/monitor.c index 481eab2..6252b3f 100644

[Qemu-devel] [PATCH 15/25] Monitor: Convert do_info_status_print() into do_info_status()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_status() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 18/25] Monitor: Move qmp_query_name() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_name_print() to call it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 59b3866..89325d8 100644 --- a/monitor.c +++ b

[Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv_stats()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_blockstats() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c |6 +- block.h |2 +- monitor.c |3 +-- 3 files changed, 7

[Qemu-devel] [PATCH 11/25] Monitor: Convert do_pci_info_print() into do_pci_info()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_pci() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/pci.c |7 ++- hw/pci.h |2 +- monitor.c |3 +-- 3 files changed, 8 insertions

[Qemu-devel] [PATCH 17/25] Monitor: Convert do_info_vnc_print() into do_info_vnc()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_vnc() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- console.h |2 +- monitor.c |3 +-- ui/vnc.c |9 +++-- 3 files changed, 9 insertions

[Qemu-devel] [PATCH 24/25] Monitor: Introduce do_info_balloon()

2010-12-06 Thread Luiz Capitulino
. This commit takes the first step towards this goal: it introduces do_info_ballon(), which is a regular info handler, except that it knows how to directly call an asynchronous QMP handler. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 20 +--- 1 files changed

[Qemu-devel] [PATCH 16/25] Monitor: Convert do_info_mice_print() into do_info_mice()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_mice() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- console.h |2 +- input.c |9 +++-- monitor.c |3 +-- 3 files changed, 9 insertions

[Qemu-devel] [PATCH 21/25] Monitor: Convert do_info_uuid_print() into do_info_uuid()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_uuid() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/monitor.c

[Qemu-devel] [PATCH 19/25] Monitor: Convert do_info_name_print() into do_info_name()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_name() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 22/25] Monitor: qmp_query_migrate(): Return {} for empty MigrationState

2010-12-06 Thread Luiz Capitulino
When no migration has been performed (ie. empty MigrationState), qmp_query_migrate() returns nothing. Let's do what other query handlers do: return an empty json-object. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- migration.c |5 + 1 files changed, 5 insertions(+), 0

[Qemu-devel] [PATCH 20/25] Monitor: Move qmp_query_uuid() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_uuid_print() to call it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 2d1f183..e9b07f3 100644 --- a/monitor.c +++ b

[Qemu-devel] [PATCH 25/25] Monitor: do_info(): Drop unused code

2010-12-06 Thread Luiz Capitulino
Last commits moved QMP calling code to the info handlers themselves, now do_info() does nothing with QMP anymore, just drop all QMP handling code from it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 42 ++ 1 files changed, 6

[Qemu-devel] [PATCH 07/25] Monitor: Convert bdrv_info_print() into bdrv_info()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_block() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- block.c |6 +- block.h |2 +- monitor.c |3 +-- 3 files changed, 7 insertions

[Qemu-devel] [PATCH 23/25] Monitor: Convert do_info_migrate_print() into do_info_migrate()

2010-12-06 Thread Luiz Capitulino
The new handler directly calls qmp_query_migrate() to gather data and then prints it. This change allows us to drop the user_print callback. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- migration.c |8 ++-- migration.h |2 +- monitor.c |3 +-- 3 files changed, 8

[Qemu-devel] [PATCH 12/25] Monitor: Move qmp_query_kvm() up in monitor.c

2010-12-06 Thread Luiz Capitulino
So that next commit can change do_info_kvm_print() to call it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/monitor.c b/monitor.c index 1fbe78b..e8f0562 100644 --- a/monitor.c

Re: [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers

2010-12-07 Thread Luiz Capitulino
On Tue, 7 Dec 2010 10:28:25 -0200 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: On Mon, Dec 6, 2010 at 4:23 PM, Luiz Capitulino lcapitul...@redhat.com wrote: Query handlers still carry their human monitor name. This commit renames all of them to a more QMP-like name

[Qemu-devel] Re: [PATCH] blockdev: check dinfo ptr before using

2010-12-09 Thread Luiz Capitulino
-off-by: Ryan Harper ry...@us.ibm.com Fixes my test case: Tested-by: Luiz Capitulino lcapitul...@redhat.com

[Qemu-devel] [PATCH] Fix segfault with ram_size 4095M without kvm

2010-12-09 Thread Luiz Capitulino
Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit on 32-bit hosts) on ram_size in the control path after we determine we're not using kvm Upstream qemu-kvm is affected if using the -no-kvm option;

[Qemu-devel] Re: [PATCH] Fix segfault with ram_size 4095M without kvm

2010-12-09 Thread Luiz Capitulino
On Wed, 08 Dec 2010 12:23:12 -0600 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On 12/08/2010 12:01 PM, Luiz Capitulino wrote: Currently, x86_64-softmmu qemu segfaults when trying to use 4095M memsize. This patch adds a simple check and error message (much like the 2047 limit

[Qemu-devel] Re: [PATCH 2/6] qemu, qmp: convert do_inject_nmi() to QObject

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:00 +0800 Lai Jiangshan la...@cn.fujitsu.com wrote: Convert do_inject_nmi() to QObject, we need to use it(via libvirt). Patches 0/6 and 1/6 are missing. Also, I see that you're converting two unrelated commands in the same series. Please, split into two series. It

[Qemu-devel] Re: [PATCH 6/6] qemu, qmp: Convert do_sendkey() to QObject, QError

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:40 +0800 Lai Jiangshan la...@cn.fujitsu.com wrote: Convert do_sendkey() to QObject,QError, we need to use it.(via libvirt) It is a trivial conversion, carefully converted the error reports. Trivial conversion doesn't seem to lead to a good interface for qmp,

[Qemu-devel] Re: [PATCH v2 1/2] QError: new QERR_INVALID_CPU_INDEX

2010-12-10 Thread Luiz Capitulino
On Fri, 10 Dec 2010 14:36:01 +0800 Lai Jiangshan la...@cn.fujitsu.com wrote: Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com As Markus said, we report this as an invalid parameter in do_cpu(), we can do the same for inject-nmi. --- diff --git a/qerror.c b/qerror.c index

[Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-10 Thread Luiz Capitulino
On Fri, 10 Dec 2010 14:36:08 +0800 Lai Jiangshan la...@cn.fujitsu.com wrote: +SQMP +inject_nmi +-- + +Inject an NMI on the given CPU (x86 only). + +Arguments: + +- cpu_index: the index of the CPU to be injected NMI (json-int) + +Example: + +- { execute: inject_nmi, arguments:

[Qemu-devel] Re: [PATCH] correct migrate_set_speed's args_type

2010-12-10 Thread Luiz Capitulino
On Fri, 10 Dec 2010 16:20:34 +0100 Markus Armbruster arm...@redhat.com wrote: [Note cc: Dan, Avi] Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 23 Nov 2010 10:43:48 -0200 Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 23 Nov 2010 13:41:26 +0800 Wen Congyang we

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 17:49:27 +0800 Lai Jiangshan la...@cn.fujitsu.com wrote: Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). changed from v1 Add document. Add error handling when the cpu index is invalid. changed from v2 use QERR_INVALID_PARAMETER_VALUE as

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 11:49:23 +0100 Markus Armbruster arm...@redhat.com wrote: Lai Jiangshan la...@cn.fujitsu.com writes: Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). changed from v1 Add document. Add error handling when the cpu index is invalid.

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 19:18:32 +0200 Avi Kivity a...@redhat.com wrote: On 12/15/2010 07:09 PM, Luiz Capitulino wrote: On Wed, 15 Dec 2010 17:49:27 +0800 Lai Jiangshanla...@cn.fujitsu.com wrote: Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt

[Qemu-devel] Re: [PATCH 2/3] Introduce do_snapshot_blkdev() and monitor command to handle it.

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 17:57:25 +0100 Jes Sorensen jes.soren...@redhat.com wrote: On 12/15/10 17:55, Kevin Wolf wrote: +int do_snapshot_blkdev(Monitor *mon, const QDict *qdict, QObject **ret_data) +{ +const char *device = qdict_get_str(qdict, device); +const char *filename =

Re: [Qemu-devel] [Qestion] What status of memory stats feature

2010-12-15 Thread Luiz Capitulino
2010/10/01 from Luiz Capitulino http://www.mail-archive.com/qemu-devel@nongnu.org/msg43024.html According to the related thread, the above patch avoids hanging user monitor, and people hope the memory stats feature will be able in the future. So I'd like to know the status

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 18:39:07 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 15 Dec 2010 11:49:23 +0100 Markus Armbruster arm...@redhat.com wrote: Lai Jiangshan la...@cn.fujitsu.com writes: Convert do_inject_nmi() to QObject

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 18:45:09 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Wed, 15 Dec 2010 19:18:32 +0200 Avi Kivity a...@redhat.com wrote: On 12/15/2010 07:09 PM, Luiz Capitulino wrote: On Wed, 15 Dec 2010 17:49:27 +0800 Lai

[Qemu-devel] [PATCH] Fix migrate set speed doc arg

2010-12-15 Thread Luiz Capitulino
. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qmp-commands.hx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 3486223..164ecbc 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -510,7 +510,7 @@ Set maximum speed

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 11:03:38 +0200 Avi Kivity a...@redhat.com wrote: On 12/15/2010 08:00 PM, Luiz Capitulino wrote: Looks like a GUI feature to me, Really? Can't see how you can build NMI to all CPUs from NMI this CPU. Or am I misunderstanding you? I guess so. Avi

[Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-16 Thread Luiz Capitulino
On Thu, 16 Dec 2010 12:51:14 +0200 Avi Kivity a...@redhat.com wrote: On 12/16/2010 12:48 PM, Luiz Capitulino wrote: Ok, I didn't know that, but I had another idea: the command could accept either a single cpu index or a list: { execute: inject-nmi, arguments: { cpus: 2

Re: [Qemu-devel] [Qestion] What status of memory stats feature

2010-12-16 Thread Luiz Capitulino
On Wed, 15 Dec 2010 16:58:03 -0600 Adam Litke a...@us.ibm.com wrote: On Wed, 2010-12-15 at 15:39 -0200, Luiz Capitulino wrote: On Wed, 15 Dec 2010 16:20:05 +0900 Ken'ichi Ohmichi oomi...@mxs.nes.nec.co.jp wrote: Hi, I tried to get the memory stats by using

<    1   2   3   4   5   6   7   8   9   10   >