From: Stefan Weil s...@weilnetz.de
Report from clang analyzer:
clock.c:42:15: warning:
Value stored to 'cpu' during its initialization is never read
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/i386/kvm/clock.c |2 +-
1 file changed, 1
From: Stefan Weil s...@weilnetz.de
tci.c is also a maintained part of the TCI implementation.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: Richard Henderson r...@twiddle.net
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
MAINTAINERS |1 +
1 file changed, 1 insertion(+)
diff
22.09.2013 12:30, Wenchao Xia пишет:
This is a quick way to update helper program when qemu main code
is changed or built, instead of adding new Makefile under test/qemu-iotest.
Why?
[]
+# Build the help program automatically
+
+all: $(QEMU_IOTESTS_HELPERS-y)
This appears to be somewhat
Please respond here or CC qemu-sta...@nongnu.org on any patches you
think should be included in the release. The cut-off date is
2013-09-30 for new patches.
Testing/feedback is greatly appreciated.
Thanks!
Please add this one from Michael Tokarev, too:
http://patchwork.ozlabs.org/patch/276560
25.09.2013 16:57, Michael Roth wrote:
Hi everyone,
The following new patches are queued for QEMU stable v1.6.1:
https://github.com/mdroth/qemu/commits/stable-1.6-staging
It looks like at least some stuff from the series
http://thread.gmane.org/gmane.comp.emulators.qemu/234440
is also
27.09.2013 12:07, Michael Tokarev пишет:
25.09.2013 16:57, Michael Roth wrote:
Hi everyone,
The following new patches are queued for QEMU stable v1.6.1:
https://github.com/mdroth/qemu/commits/stable-1.6-staging
It looks like at least some stuff from the series
http://thread.gmane.org
19.07.2013 23:11, Stefan Weil wrote:
Am 04.07.2013 10:53, schrieb M. Mohan Kumar:
Stefan Weil s...@weilnetz.de writes:
The leak was reported by cppcheck.
Function proxy_init also calls g_free for ctx-fs_root.
Avoid reuse of this memory by setting ctx-fs_root to NULL.
Signed-off-by: Stefan
21.07.2013 18:43, Stefan Weil wrote:
The global variable env was removed some time ago, so this name may be
used without any restriction now.
Thanks, applied to the trivial patches queue.
/mjt
23.07.2013 08:46, Stefan Weil wrote:
This was dead code.
Thanks, applied to the trivial patches queue.
/mjt
23.07.2013 21:00, Petar Jovanovic wrote:
From: Petar Jovanovic petar.jovano...@imgtec.com
sys_mremap missed 5th argument (new_address), which caused examples that
remap to a specific address to fail.
sys_splice missed 5th and 6th argument which caused different examples to
fail.
This
21.07.2013 18:58, Stefan Weil wrote:
Am 20.07.2013 16:24, schrieb Andreas Färber:
Anthony recently stated very clearly that in order for him to pick up a
patch it needs to have a Reviewed-by. This one only got an Acked-by.
No rule without exception. When I look at the list of patches
24.07.2013 16:44, Andreas Färber wrote:
Am 19.07.2013 11:11, schrieb Michael Tokarev:
---
NACK, this commit in the pull request is lacking Signed-off-bys!
The original patch (attachment in reply to slirp: reorder include to
fix FreeBSD build failure) had a misspelled Signed-off-By from
23.07.2013 21:33, Peter Maydell wrote:
On 23 July 2013 18:18, Michael Tokarev m...@tls.msk.ru wrote:
23.07.2013 21:00, Petar Jovanovic wrote:
From: Petar Jovanovic petar.jovano...@imgtec.com
sys_mremap missed 5th argument (new_address), which caused examples that
remap to a specific address
24.07.2013 21:48, Stefan Weil wrote:
All these typos were found by codespell.
sould - should
emperical - empirical
intialization - initialization
successfuly - successfully
gaurantee - guarantee
Fix also another error (before before) in the same context.
Thanks, applied to the trivial
25.07.2013 20:21, Stefan Weil wrote:
The macro g_assert_not_reached is a better self documenting replacement
for assert(0) or assert(false).
Thanks, applied to the trivial patches queue.
/mjt
26.07.2013 00:10, Stefan Weil wrote:
This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).
Removing it allows using -Wextra for QEMU code without suppressing too many
extra warnings.
Thanks, applied to
-by: Petar Jovanovic petar.jovano...@imgtec.com
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
linux-user/main.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 5309117
it is no longer
reasonable to disable them and the definition of NDEBUG can be removed.
Type u16 is also unused and therefore does not need a type definition.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
util/aes.c |5 -
1 file changed, 5 deletions
Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
target-mips/op_helper.c |1 -
1 file changed, 1 deletion(-)
diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index 5cf1c3f..b828375 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -1735,7
From: Liu Ping Fan qemul...@gmail.com
Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com
Reviewed-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
cpus.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpus.c b/cpus.c
index
We collected a few more trivial patches this week, including a compile
failure fix for 32bit builds by Stefan Weil.
Please pull.
The following changes since commit 200a06397f5d3e982028fd78b25b420507ade021:
Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging
From: Stefan Weil s...@weilnetz.de
The global variable env was removed some time ago, so this name may be
used without any restriction now.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
include/exec/poison.h |1 -
1 file changed, 1 deletion
...@weilnetz.de
Reviewed-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
block/vhdx.h |2 +-
docs/rdma.txt |2 +-
hw/virtio/virtio-balloon.c |4 ++--
hw/xen/xen_pt.c|3 ++-
migration-rdma.c |4
: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
qemu-options.hx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 2dbfd42..25ecb55 100644
Signed-off-by: Stefan Weil s...@weilnetz.de
Acked-by: Alexander Graf ag...@suse.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/ide/macio.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/ide/macio.c b/hw/ide/macio.c
index 38ad924..ef4ba2b 100644
--- a/hw
From: Stefan Weil s...@weilnetz.de
The leak was reported by cppcheck.
Function proxy_init also calls g_free for ctx-fs_root.
Avoid reuse of this memory by setting ctx-fs_root to NULL.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: Michael
From: Stefan Weil s...@weilnetz.de
The macro g_assert_not_reached is a better self documenting replacement
for assert(0) or assert(false).
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
blockdev.c |2 +-
hw/net/vmxnet3
From: Stefan Weil s...@weilnetz.de
This was dead code.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: Andreas Färber afaer...@suse.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/watchdog/watchdog.c |1 -
1 file changed, 1 deletion(-)
diff --git a/hw/watchdog/watchdog.c
On 29.07.2013 02:37, Aurelien Jarno wrote:
On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).
Removing it allows using -Wextra for QEMU code
Can we try to fix this for 1.6 please? :)
Or should I try to cook up a patch?
Thanks,
/mjt
04.07.2013 01:06, Michael Roth wrote:
On Wed, Jul 3, 2013 at 1:03 AM, Michael Tokarev m...@tls.msk.ru wrote:
Before
commit bd5c51ee6c4f1c79cae5ad2516d711a27b4ea8ec
Author: Michael Roth mdr
For the record, the difference between debian qemu 1.5.0-4 and 1.5.0-5
is the 1.5.1 patch - I applied it without actually changing the
upstream version number.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
So, what changed so you were able to boot from IDE without errors? As
far as I understand, your initial prob was I/O errors on IDE (virtual)
drive, but now you can boot it without errors. Or was it always SATA
not IDE?
The rdmsr/wrmsr are unrelated, I already told you that, it is accessing
Move qemu-ga build check out of if softmmu.. into if tools section.
We want to build qemu-ga for _guest_ even if system build isn't
done. It is controlled separately using --enable-guest-agent.
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
configure |8 +++-
1 file changed, 3
31.07.2013 14:24, Michael Tokarev wrote:
Move qemu-ga build check out of if softmmu.. into if tools section.
We want to build qemu-ga for _guest_ even if system build isn't
done. It is controlled separately using --enable-guest-agent.
Actually the more I think about it... Maybe it shouldn't
31.07.2013 16:03, Andreas Färber wrote:
Am 31.07.2013 13:05, schrieb Peter Maydell:
Actually the more I think about it... Maybe it shouldn't depend
on --enable-tools either, but should be an independent option.
Because it isn't really a tool.
This seems to me to be unnecessarily breaking
Move qemu-ga build check out of if softmmu.. into its own section.
We want to build qemu-ga for _guest_ even if system build isn't
done. It is controlled separately using --enable-guest-agent.
Additionally, give error message if guest agent is requested but
not supported.
Signed-off-by: Michael
Move qemu-ga build check out of if softmmu.. into its own section.
We want to build qemu-ga for _guest_ even if system build isn't
done. It is controlled separately using --enable-guest-agent.
Additionally, give error message if guest agent is requested but
not supported.
Signed-off-by: Michael
01.08.2013 14:12, Fam Zheng wrote:
The comment was truncated. Add the missing parts, especially explain why
we need zero_dry_run.
Thanks, applied to the trivial patches queue.
/mjt
Thanks, applied to the trivial patches queue.
/mjt
From: Fam Zheng f...@redhat.com
The comment was truncated. Add the missing parts, especially explain why
we need zero_dry_run.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
block/vmdk.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions
: drop kvm.h dependency
Michael Tokarev (1):
qemu-ga: build it even if !system
Richard W.M. Jones (1):
block/iscsi.c: Fix printf format error.
block/iscsi.c |4 +++-
block/vmdk.c |8 ++--
configure | 11 ---
memory.c |1 -
4 files changed, 17 insertions
-block_size, sector_num, nb_sectors);
^
This also splits the long line to comply with qemu coding guidelines.
Signed-off-by: Richard W.M. Jones rjo...@redhat.com
Reviewed-by: Stefan Weil s...@weilnetz.de
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Michael
Move qemu-ga build check out of if softmmu.. into its own section.
We want to build qemu-ga for _guest_ even if system build isn't
done. It is controlled separately using --enable-guest-agent.
Additionally, give error message if guest agent is requested but
not supported.
Signed-off-by: Michael
From: Michael S. Tsirkin m...@redhat.com
memory.c does not use any kvm specific interfaces,
don't include kvm.h
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Acked-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
memory.c |1 -
1 file changed, 1
01.08.2013 12:39, Paolo Bonzini wrote:
memory.c does not use any kvm specific interfaces,
don't include kvm.h
Thanks, applied to the trivial patches queue.
/mjt
The fix is in a62eaa26c1d6d48fbdc3ac1d32bd1314f5fdc8c9 ahci: Fix FLUSH
command, should be in 1.6 and 1.5.3.
** Changed in: qemu
Status: New = Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
We're going to a (hopefully) 3-week vacation starting
today, and I don't expect any internet access there.
So I wont be able to handle trivial-patches during
this time (till Aug-2013).
Thanks,
/mjt
I'm not sure x86*-linux-user targets are being tested at all. Last time
I checked, x86-64 variant crashed left and right to the point of being
completely unusable...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
04.11.2013 00:06, Jan Kiszka wrote:
On 2013-11-01 11:10, Michael Tokarev wrote:
[]
If Jan picks it up, that's fine. If not, I think it can go
to the trivial patches queue.
Works fine, applied to queues/slirp.
Okay, thank you Jan.
But this is not a trivial patch as the fix is not obvious
Thanks, applied to the trivial-patches queue.
/mjt
On 10/11/2013 11:52 AM, Cole Robinson wrote:
Using multiple calls to error_report here means every line is
prefaced with the (potentially long) pci-assign command line
arguments.
Use a single error_printf to preserve the intended formatting.
Since this code path is always preceded by an
05.11.2013 00:38, Laszlo Ersek wrote:
On 11/04/13 21:07, Peter Maydell wrote:
On 4 November 2013 19:51, Stefan Weil s...@weilnetz.de wrote:
With -Werror=sign-compare (not enabled by default), gcc shows these errors:
ui/gtk.c: In function ‘gtk_release_modifiers’:
ui/gtk.c:288:19: error:
06.11.2013 05:54, whitearchey wrote:
For now guest agent uses following command to shutdown system:
shutdown -P +0 blabla
but this syntax works only with shutdown command from systemd or upstart,
because SysV shutdown requires -h switch.
Following patch changes the command so it works with
06.11.2013 14:43, alex.ben...@linaro.org wrote:
From: Alex Bennée a...@bennee.com
This adds a build matrix definition for travis-ci.org []
Thanks, applied to the trivial-patches queue. With one tiny fix --
removed trailing whitespace in the line
- TARGETS=m68k-softmmu
/mjt
05.11.2013 19:26, Jan Krupa wrote:
On 11/01/2013 11:00 AM, Michael Tokarev wrote:
[]
Except of one question. Where we add these entries? Should we maybe
sort the table somehow, or introduce some more groups of chars?
(I'm fine with applying this to qemu-trivial as-is).
I agree
10.11.2013 21:49, Stefan Weil wrote:
While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny
(gcc-mingw32 4.4.2-3) shows these errors:
I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny
is an old-old-stable Debian release - it was before squeeze which
is now oldstable.
10.11.2013 17:20, Stefan Weil wrote:
This reduces the dependencies on trace.h.
Only two source files which need console.h also need trace.h.
Thanks, applied both patches to the trivial patches queue,
after actually verifying that the result is sane ;)
/mjt
10.11.2013 18:58, Stefan Weil пишет:
The local function console_print_text_attributes is no longer used since
commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.
Thanks, applied to the trivial-patches queue.
/mjt
10.11.2013 19:24, Stefan Weil wrote:
[]
Thanks, applied to the trivial-patches queue.
/mjt
06.11.2013 05:54, whitearchey wrote:
For now guest agent uses following command to shutdown system:
shutdown -P +0 blabla
but this syntax works only with shutdown command from systemd or upstart,
because SysV shutdown requires -h switch.
Following patch changes the command so it works with
expect any sideeffects.
[1] http://cgit.freedesktop.org/xorg/lib/libxkbcommon
Signed-off-by: Jan Krupa jkr...@suse.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
ui/vnc_keysym.h | 365 +++
1 file changed, 365 insertions(+)
diff --git a/ui
«
qga/vss-win32/requester.h:32:
error: expected »=«, »,«, »;«, »asm« or »__attribute__« before
»requester_deinit«
The macro STDAPI is unknown, so add the missing include file which
defines it.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
qga/vss
From: Jan Krupa jkr...@suse.com
This patch adds Czech keyboard layout to available keymap files
and Makefile.
Signed-off-by: Jan Krupa jkr...@suse.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
Makefile |2 +-
pc-bios/keymaps/cz | 94
From: Jan Krupa jkr...@suse.com
This patch adds missing Czech characters to the VNC keysym table.
Signed-off-by: Jan Krupa jkr...@suse.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
ui/vnc_keysym.h |8
1 file changed, 8 insertions(+)
diff --git a/ui/vnc_keysym.h b/ui
Here's a next trivial-patches pull request, for patches collected
in almost 3 weeks.
There's nothing extra-ordinary here, except of one thing: this is
keyboard maps handling series by Jan Krupa. While I don't expect
any breakage in this area, but the series introduces a new keymap
(cz), fixes
after U character
because strtol returns 0 in case the conversion was unsuccessful.
Signed-off-by: Jan Krupa jkr...@suse.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
ui/keymaps.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/ui/keymaps.c b/ui/keymaps.c
index f373cc5..80d658d
From: Stefan Weil s...@weilnetz.de
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
trace-events |5 +
ui/gtk.c | 19 +--
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/trace-events b/trace-events
index
From: Fam Zheng f...@redhat.com
Signed-off-by: Fam Zheng f...@redhat.com
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
qapi-schema.json |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index
From: Stefan Weil s...@weilnetz.de
This reduces the dependencies on trace.h.
Only one source file which needs hcd-ehci.h also needs trace.h.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/usb/hcd-ehci.c |1 +
hw/usb/hcd-ehci.h |1 -
2
From: Stefan Weil s...@weilnetz.de
The local function console_print_text_attributes is no longer used since
commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f.
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
)
Signed-off-by: Alex Bennée a...@bennee.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
.travis.yml | 71 +++
1 file changed, 71 insertions(+)
create mode 100644 .travis.yml
diff
-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
vl.c |1 +
1 file changed, 1 insertion(+)
diff --git a/vl.c b/vl.c
index 4ad15b8..b5ec266 100644
--- a/vl.c
+++ b/vl.c
@@ -4267,6 +4267,7 @@ int main(int argc, char **argv, char **envp)
/* init local
From: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Benoit Canet ben...@irqsave.net
Reviewed-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/usb/dev-network.c |1 -
1 file changed, 1 deletion
From: Stefan Weil s...@weilnetz.de
This reduces the dependencies on trace.h.
Only two source files which need console.h also need trace.h.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/display/vmware_vga.c |1 +
include/ui/console.h
From: Stefan Weil s...@weilnetz.de
Signed-off-by: Stefan Weil s...@weilnetz.de
Reviewed-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
trace-events |2 ++
ui/console.c | 11 +++
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git
-by: Michael Avdienko whitearc...@gmail.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
qga/commands-posix.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index f453132..10682f5 100644
--- a/qga/commands-posix.c
+++ b/qga/commands
call,
we don't lose the command line reporting.
Signed-off-by: Cole Robinson crobi...@redhat.com
Reviewed-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/i386/kvm/pci-assign.c | 36
1 file changed, 16 insertions
13.11.2013 22:05, Stefan Weil wrote:
[]
The two trace.h related patches moved include statements from .h files
to .c files.
I compiled the resulting code on 64 bit Linux, also with cross
compilation for
MinGW, so win* won't be a problem.
Nevertheless there remains a risk because my builds
14.11.2013 22:07, Stefan Weil wrote:
Commit 1d984a67a95d88f3e708b077dab8adeb47c38c93 added the -B switch
unconditionally. This breaks Python versions before 2.6 which don't
support that switch.
Now configure adds -B only if it is accepted by the Python interpreter.
This modification
-by: Michael Tokarev m...@tls.msk.ru
Cc: Luigi Rizzo ri...@iet.unipi.it
Cc: Stefan Weil s...@weilnetz.de
--
mjt: I want to apply this to trivial-patches for-1.7
---
hw/i386/Makefile.objs |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
16.11.2013 15:10, Peter Maydell wrote:
Just a question since we were discussing this on IRC -- are you going
to remove the non-buildfix/bugfix patches from the trivial queue so
the buildfixes go into 1.7?
Yes, please see
Michael Tokarev (1):
hw/i386/Makefile.obj: use $(PYTHON) to run .py scripts consistently
Stefan Hajnoczi (1):
usb: drop unused USBNetState.inpkt field
Stefan Weil (3):
qga: Fix compilation for old versions of MinGW
console: Remove unused debug code
configure: Use -B
17.11.2013 22:00, Stefan Weil wrote:
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCm68k-softmmu/hw/m68k/mcf5206.o
hw/i386/acpi-build.c: In function ‘build_append_nameseg’:
hw/i386/acpi-build.c:294:5: error:
function might be possible candidate for
17.11.2013 22:00, Stefan Weil wrote:
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqobject/qerror.o
qobject/qerror.c: In function ‘qerror_from_info’:
qobject/qerror.c:53:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
17.11.2013 22:19, Stefan Weil wrote:
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqga/commands.o
qga/commands.c: In function ‘slog’:
qga/commands.c:28:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
17.11.2013 22:00, Stefan Weil wrote:
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCm68k-softmmu/hw/m68k/mcf5206.o
hw/i386/acpi-build.c: In function ‘build_append_nameseg’:
hw/i386/acpi-build.c:294:5: error:
function might be possible candidate for
Here are a few remaining bits from the trivial patches queue.
Paolo already picked some so this time the queue is smaller than usual.
Please pull.
The following changes since commit c0caec178eadbbac4c672110c3914313091e0588:
Merge remote-tracking branch 'mst/tags/for_anthony' into staging
=suggest-attribute=format]
qerr-err_msg = g_strdup_vprintf(fmt, *va);
^
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
qobject/qerror.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qobject/qerror.c b/qobject
From: Fam Zheng f...@redhat.com
Signed-off-by: Fam Zheng f...@redhat.com
Reviewed-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
.gitignore |1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 5584b5f..1c9d63d 100644
:
format not a string literal and no format arguments [-Werror=format-security]
build_append_nameseg(method, name);
^
This is fixed here, too.
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/i386/acpi-build.c |5 +++--
1 file changed, 3
on the same config dir, it should not
be a problem.
The one-liner (not exactly 1 since it touches previous line too) is like
this:
Signed-off-By: Michael Tokarev m...@tls.msk.ru
diff --git a/net/slirp.c b/net/slirp.c
index 124e953..a22e976 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -549,7
Jan, there's one more samba-related fix for slirp, also from Michael Büsch.
Add my
Signed-off-By: Michael Tokarev m...@tls.msk.ru
if needed.
Thanks,
/mjt
06.11.2013 17:01, Michael Büsch wrote:
Package: qemu
Version: 1.6.0+dfsg-2
Severity: normal
Tags: patch
The smbd forked by qemu
[Rehashing a previous thread]
19.06.2013 20:58, Paolo Bonzini wrote:
Il 18/06/2013 19:34, Michael Tokarev ha scritto:
The following working patchset demonstrates a one step to plugins system:
it moves various dependent libraries and stuff out from libs_softmmu or
libs_tools to object-specific
30.06.2013 19:28, Andreas Färber wrote:
Am 18.06.2013 19:34, schrieb Michael Tokarev:
The following working patchset demonstrates a one step to plugins system:
it moves various dependent libraries and stuff out from libs_softmmu or
libs_tools to object-specific variables.
We did have a more
30.06.2013 19:51, Peter Maydell wrote:
On 30 June 2013 16:36, Michael Tokarev m...@tls.msk.ru wrote:
I don't understand. I for one like to see a plugins system used in qemu,
and except of the build system everything else is easy (and even nice,
there's even no need to load all plugins
01.07.2013 14:08, Paolo Bonzini wrote:
Il 30/06/2013 17:23, Michael Tokarev ha scritto:
Perhaps we can instead use something like
common.o: $(patsubst %,../%, $(common-obj-y))
$(LD) -r -o $@ $^
and then link common.o into the QEMU target. Libtool can also be used
to abstract ld -r
01.07.2013 17:39, Paolo Bonzini wrote:
What used to be there was something like
net-obj-y = foo.o bar.o
common-obj-y += $(addprefix net/, $(net-obj-y))
and this has been replaced by net/Makefile.objs and friends.
Maybe we should just list them all in a single makefile after all,
01.07.2013 18:46, Andreas Färber wrote:
[]
What's wrong with a single makefile for everything, except
of the need to use full pathnames from the top-level source
dir?
In short the problem we ran into was missing *.d inclusions.
This got fixed by automatically expanding net/ to -include
01.07.2013 18:53, Paolo Bonzini wrote:
[]
I don't think that's the problem. Simply I don't think that listing
1000 object files in a single makefile are manageable. Choosing the
right directory per-target is also much easier if you can just do
obj-y += hw/$(TARGET_BASE_ARCH)/
01.07.2013 19:20, Paolo Bonzini wrote:
Il 01/07/2013 17:06, Michael Tokarev ha scritto:
So instead of this, we may have in the top-level Makefile:
obj-i386-y += hw/i386/msi.o hw/i386/irq.o hw/i386/kvm.o
Or, if you prefer programmatic expansion,
list-i386-y += msi.o irq.o kvm.o
obj
201 - 300 of 6849 matches
Mail list logo
