Re: [Qemu-devel] [PATCH v2 2/2] qemu-ga: add guest-fstrim command

2012-06-13 Thread Michal Privoznik
-1588,1599-4026,4029-16383 # rm /run/media/pbonzini/test/file # ./qemu-ga /dev/fd/0 {execute:guest-fstrim} {return: {}} # cat map 1-612 Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Reviewed-by: Michal Privoznik mpriv...@redhat.com v1-v2: fix version number

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: fix segv after failure to open log file

2012-05-15 Thread Michal Privoznik
) { g_critical(unable to open specified log file: %s, strerror(errno)); goto out_bad; } +s-log_file = log_file; } } Reviewed-by: Michal Privoznik mpriv...@redhat.com

Re: [Qemu-devel] [PATCH 1.1] qemu-ga: align versioning with QEMU_VERSION

2012-05-15 Thread Michal Privoznik
-agent-core.h +++ b/qga/guest-agent-core.h @@ -13,7 +13,6 @@ #include qapi/qmp-core.h #include qemu-common.h -#define QGA_VERSION 1.0 #define QGA_READ_COUNT_DEFAULT 4096 typedef struct GAState GAState; Reviewed-by: Michal Privoznik mpriv...@redhat.com

Re: [Qemu-devel] [PATCH 0/2]: qemu-ga: make shutdown suspend synchronous

2012-05-14 Thread Michal Privoznik
On 11.05.2012 21:19, Luiz Capitulino wrote: The main motivation for this series is fixing two possible race conditions in the guest-suspend-* API due to the complexity that arose from the way we handle terminated children processes today. Full details in the first patch. This series applies

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-23 Thread Michal Privoznik
On 20.04.2012 15:36, Luiz Capitulino wrote: On Fri, 20 Apr 2012 14:07:16 +0200 Michal Privoznik mpriv...@redhat.com wrote: But, I think if we tell users we'll *only* send response on error, we should do our part to *not* send the responses, rather than relying on them having implemented

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Michal Privoznik
On 19.04.2012 21:34, Luiz Capitulino wrote: On Thu, 19 Apr 2012 13:57:48 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On Thu, Apr 19, 2012 at 02:36:53PM -0300, Luiz Capitulino wrote: Michael, I'm going to revive this topic one more time. I was working on v2 of my fixes to the

Re: [Qemu-devel] [libvirt] [PATCH 7/8] block: add witness argument to drive-reopen

2012-04-17 Thread Michal Privoznik
On 17.04.2012 14:09, Eric Blake wrote: [adding libvir-list for some interesting discussions on potential libvirt design issues] On 04/17/2012 12:47 AM, Paolo Bonzini wrote: Il 16/04/2012 23:55, Eric Blake ha scritto: Do transient guests have persistent storage for them in /var while they

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michal Privoznik
On 25.03.2012 03:19, Brad Smith wrote: On 20/03/12 9:28 AM, Brad Smith wrote: On 20/03/12 6:14 AM, Michal Privoznik wrote: On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michal Privoznik
On 26.03.2012 17:18, Anthony Liguori wrote: On 03/26/2012 10:15 AM, Michael Roth wrote: On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote: Yup, I can't confirm the BSD fix atm though, only that it doesn't break builds on linux/w32. Send anyway or wait for confirmation?

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-20 Thread Michal Privoznik
On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break the tree. Can you please be more specific? It works for me so I don't have a clue what are you referring to. I mean, what

[Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michal Privoznik
Currently, the implementation of that command is full of Linux specific code. Before any brave man will step into and port it to other OSes, make this function Linux only. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- qga/commands-posix.c | 11 +++ 1 files changed, 11

Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michal Privoznik
On 20.03.2012 17:10, Michael Roth wrote: On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: Currently, the implementation of that command is full of Linux specific code. Before any brave man will step into and port it to other OSes, make this function Linux only. Signed-off

[Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michal Privoznik
Hi guys, I was just implementing support for guest-sync-delimited into libvirt. My intent is to issue this command prior any other command to determine if GA is available or not. The big advantage is - it doesn't change the state of the guest so from libvirt POV it's harmless. The other big

Re: [Qemu-devel] Guest-sync-delimited and sentinel issue

2012-03-16 Thread Michal Privoznik
On 16.03.2012 15:49, Michael Roth wrote: On Fri, Mar 16, 2012 at 01:47:42PM +0100, Michal Privoznik wrote: Hi guys, I was just implementing support for guest-sync-delimited into libvirt. My intent is to issue this command prior any other command to determine if GA is available

Re: [Qemu-devel] [PATCH v6] qemu-ga: Add guest-network-get-interfaces command

2012-03-06 Thread Michal Privoznik
On 29.02.2012 17:02, Michal Privoznik wrote: This command returns an array of: [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] for each interface in the system. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- diff to v5

Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7

2012-03-05 Thread Michal Privoznik
On 02.03.2012 16:49, Hans de Goede wrote: VCARD_ATR_PREFIX is used as part of an array initializer so it should not have () around it, so far this happened to work, but gcc-4.7 does not like it. Neither do gcc-4.6.2.

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-29 Thread Michal Privoznik
On 28.02.2012 18:41, Luiz Capitulino wrote: Hmm, I know Michal already sent a new version with my suggestions, but you're right, splitting out the commands simplified both the responses, and makes it easier to discover whether or not that information is available, since you can look for the

[Qemu-devel] [PATCH v6] qemu-ga: Add guest-network-get-interfaces command

2012-02-29 Thread Michal Privoznik
This command returns an array of: [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] for each interface in the system. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- diff to v5: -another change of command diff to v4: -change return type

[Qemu-devel] [PATCH v5] qemu-ga: Add guest-network-info command

2012-02-28 Thread Michal Privoznik
This command returns an array of: [ifname, hwaddr, [ipaddr, ipaddr_family, prefix] ] for each interface in the system. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- diff to v4: -change return type diff to v3: -use ctpop32() instead

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-27 Thread Michal Privoznik
On 23.02.2012 15:20, Luiz Capitulino wrote: On Sun, 19 Feb 2012 12:15:43 +0100 Michal Privoznik mpriv...@redhat.com wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4

Re: [Qemu-devel] [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Michal Privoznik
On 24.02.2012 10:19, Stefan Hajnoczi wrote: This is a reminder that QEMU will apply for Google Summer of Code 2012 and we need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! http://wiki.qemu.org/Google_Summer_of_Code_2012 Please add yourself to the wiki now if

[Qemu-devel] qemu-ga error reporting

2012-02-23 Thread Michal Privoznik
Hi guys, I ran into weird issue. Issuing unknown-command on qemu monitor gives this: {error: {class: CommandNotFound, desc: The command unknown-command has not been found, data: {name: unknown-command}}} However, issuing the very same on GA socket gets me: {error: {class: CommandNotFound,

Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-22 Thread Michal Privoznik
On 19.02.2012 12:15, Michal Privoznik wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com

[Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command

2012-02-19 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- diff to v3: -use ctpop32() instead of separate

Re: [Qemu-devel] [PATCH] qemu-ga: Add guest-getip command

2012-02-17 Thread Michal Privoznik
On 16.02.2012 21:10, Michael Roth wrote: On Thu, Feb 16, 2012 at 06:25:03PM +0100, Michal Privoznik wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported

[Qemu-devel] [PATCH v2] qemu-ga: Add guest-network-info command

2012-02-17 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- diff to v1: -move from guest-getip to guest-network

Re: [Qemu-devel] [PATCH v2] qemu-ga: Add guest-network-info command

2012-02-17 Thread Michal Privoznik
On 17.02.2012 12:35, Michal Privoznik wrote: This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com

[Qemu-devel] [PATCH v3] qemu-ga: Add guest-network-info command

2012-02-17 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- diff to v2: -Properly set IP addr family for IPv6

[Qemu-devel] [PATCH] qemu-ga: Add guest-getip command

2012-02-16 Thread Michal Privoznik
This command returns an array of: [ifname, ipaddr, ipaddr_family, prefix, hwaddr] for each interface in the system that has an IP address. Currently, only IPv4 and IPv6 are supported. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- qapi-schema-guest.json | 16 + qga/guest

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-sync-delimited

2012-02-07 Thread Michal Privoznik
On 07.02.2012 02:09, Michael Roth wrote: guest-sync leaves it as an exercise to the user as to how to reliably obtain the response to guest-sync if the client had previously read in a partial response (due qemu-ga previously being restarted mid-sentence due to reboot, forced restart, etc).

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-30 Thread Michal Privoznik
On 30.01.2012 15:44, Luiz Capitulino wrote: On Mon, 30 Jan 2012 07:54:56 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/30/2012 06:57 AM, Luiz Capitulino wrote: On Thu, 26 Jan 2012 16:57:01 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/26/2012 01:35 PM, Luiz

Re: [Qemu-devel] [libvirt] [PATCH RFC 0/4] Allow hibernation on guests

2012-01-26 Thread Michal Privoznik
On 26.01.2012 20:35, Luiz Capitulino wrote: On Thu, 26 Jan 2012 08:18:03 -0700 Eric Blake ebl...@redhat.com wrote: [adding qemu-devel] On 01/26/2012 07:46 AM, Daniel P. Berrange wrote: One thing, that you'll probably notice is this 'set-support-level' command. Basically, it tells GA what

[Qemu-devel] Is guest agent socket being closed upon reboot?

2012-01-16 Thread Michal Privoznik
Hi, I'd like you to ask if/why is guest agent socked being closed upon guest reboot. I am using virtserialport to talk to guest agent: -chardev socket,id=charchannel0,path=/var/lib/libvirt/qemu/f16x86_64.agent,server,nowait -device

[Qemu-devel] Is guest agent socket being closed upon reboot?

2012-01-16 Thread Michal Privoznik
Hi, I'd like you to ask if/why is guest agent socked being closed upon guest reboot. I am using virtserialport to talk to guest agent: -chardev socket,id=charchannel0,path=/var/lib/libvirt/qemu/f16x86_64.agent,server,nowait -device

<    1   2   3   4