[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino wrote: >> >> TODO: I have no clue on how to create a timestamp string when using Windows. > > So, what happens on windows? > I've found some code in bdrv_snapshot_dump() that formats a timestamp when using Windows. I will use it as a basis. > Als

Re: [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 6:45 AM, Markus Armbruster wrote: > Why? > > I figure the next patch wants it, but if that's the reason, the commit > message should state it. > To better identify what happened and where, IMHO.

[Qemu-devel] Re: KVM call agenda for August 3

2010-08-02 Thread Miguel Di Ciurcio Filho
On Mon, Aug 2, 2010 at 8:46 PM, Juan Quintela wrote: > > Please send in any agenda items you are interested in covering. > I would like to briefly RFC about some snapshot issues that I have being dealing, for the conversion of savevm/loadvm to QMP. They are listed here: http://wiki.qemu.org/Feat

[Qemu-devel] [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-03 Thread Miguel Di Ciurcio Filho
like lvscan and lvdisplay. One very simple, the other one show full information. * Better distinguish ids and names I would like to suggest split functions like bdrv_snapshot_find() to something more strict, like bdrv_snapshot_find_by_id() and bdrv_snapshot_find_by_name() Signed-off-by: Miguel D

Re: [Qemu-devel] [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-04 Thread Miguel Di Ciurcio Filho
On Tue, Aug 3, 2010 at 5:55 PM, Blue Swirl wrote: >> +    if (strlen(current_snapshot_id) > 0) { >> +        pstrcpy(sn->parent_id_str, sizeof(sn->parent_id_str), >> current_snapshot_id); >> +    } else { >> +        pstrcpy(sn->parent_id_str, sizeof(sn->parent_id_str), >> "---00

[Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting

2010-08-04 Thread Miguel Di Ciurcio Filho
n "savevm: Generate a name when run without one" Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx |7 --- savevm.c| 19 ++- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 2af3de6..68

[Qemu-devel] [PATCH 1/3] monitor: make 'info snapshots' show only fully available snapshots

2010-08-04 Thread Miguel Di Ciurcio Filho
ATE VM CLOCK 31.5M 2010-07-26 17:26:49 00:00:13.245 41.5M 2010-07-26 19:01:00 00:00:46.763 Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c | 59 +++ 1 files changed, 43 insertions(+), 16 deleti

[Qemu-devel] [PATCH 0/3] snapshots: various updates

2010-08-04 Thread Miguel Di Ciurcio Filho
ing errors and do not rename the name of variables Regards, Miguel Miguel Di Ciurcio Filho (3): monitor: make 'info snapshots' show only fully available snapshots savevm: Generate a name when run without one savevm: prevent snapshot overwriting q

[Qemu-devel] [PATCH 2/3] savevm: Generate a name when run without one

2010-08-04 Thread Miguel Di Ciurcio Filho
to expose this kind of internals to the user. Signed-off-by: Miguel Di Ciurcio Filho --- savevm.c | 29 - 1 files changed, 20 insertions(+), 9 deletions(-) diff --git a/savevm.c b/savevm.c index 9291cfb..025bee6 100644 --- a/savevm.c +++ b/savevm.c @@ -1799,8 +

[Qemu-devel] [PATCH 0/2] QMP: update 'query-version'

2010-08-09 Thread Miguel Di Ciurcio Filho
mu": {"micro": 50, "minor": 13, "major": 0}, "package": ""}, "capabilities": []}} Clients will no longer need to parse the entire string. Regards, Miguel --- Miguel Di Ciurcio Filho (2): QMP: update 'query-version

[Qemu-devel] [PATCH 1/2] QMP: update 'query-version' documentation

2010-08-09 Thread Miguel Di Ciurcio Filho
Update the documentation of 'query-version' to output the string version broken down. Signed-off-by: Miguel Di Ciurcio Filho --- qemu-monitor.hx | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 2af3de

[Qemu-devel] [PATCH 2/2] QMP/monitor: update do_info_version() to output broken down version string

2010-08-09 Thread Miguel Di Ciurcio Filho
This code was originally developed by Daniel P. Berrange Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index c313d5a..e82c48f 100644 --- a/monitor.c +++ b/monitor.c

Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

2010-08-13 Thread Miguel Di Ciurcio Filho
On Thu, Aug 12, 2010 at 3:56 PM, malc wrote: > > While intentions of this are good, i believe this goes too far, i doubt > that the proposed additions are enforcable and have no doubts that they > will be widely ignored and at the same time provide more grounds for > whining. Furthermore the exist

[Qemu-devel] Re: [RFC] qcow2: Add snapshot inherantance and uuid identification

2010-08-17 Thread Miguel Di Ciurcio Filho
On Tue, Aug 3, 2010 at 2:19 PM, Miguel Di Ciurcio Filho wrote: > As discussed on today's call, here is a prototype to support snapshots > inherantance in qcow2 and to use uuid as identification mechanism. > Bump. Just a friendly reminder of this RFC, now that everybody is back from

[Qemu-devel] [PATCH] net: Convert do_info_network() to QObject

2010-04-03 Thread Miguel Di Ciurcio Filho
Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit should not change user output. Signed-off-by: Miguel Di Ciurcio Filho --- This is my initial contribution, aiming at participating in Summer of Code. monitor.c |3 +- net.c | 75

[Qemu-devel] [PATCH 0/22] Convert do_info_network() to QObject/QMP

2010-04-08 Thread Miguel Di Ciurcio Filho
The VLANClientState structure has the member info_str, a simple string that is filled with information about NIC devices and used on monitor calls. There is no coherent formatting of this string by all the NIC devices, making it difficult to parse and represent this information over QMP. Patch 0

[Qemu-devel] [PATCH 01/22] QObject API: add qdict_to_qstring() function

2010-04-08 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SPACE key2=value2 SPACE key3=value3 Handy for debugging and other things. Signed-off-by: Miguel Di Ciurcio Filho --- qdict.c | 39 +++ qdict.h |3 +++ 2 files

[Qemu-devel] [PATCH 02/22] net: replace qemu_nic_format_info_str and VLANClientState->info_str by QDicts

2010-04-08 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting info_str, so it is difficult to extract information and transmit it over QMP. This patch changes info_str from a simple string to a QDict. Patches that convert the devices to this new format will follow. Signed-off-by: Miguel Di Ciurcio Filho

[Qemu-devel] [PATCH 03/22] net: dp8393x: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/dp8393x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dp8393x.c b/hw/dp8393x.c index e65e4d1..ebb41a2 100644 --- a/hw/dp8393x.c +++ b/hw/dp8393x.c @@ -904,7 +904,7 @@ void dp83932_init(NICInfo *nd, target_phys_addr_t

[Qemu-devel] [PATCH 04/22] net: e1000: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/e1000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index fd3059a..7cbff0d 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -1125,7 +1125,7 @@ static int pci_e1000_init(PCIDevice *pci_dev) d->

[Qemu-devel] [PATCH 05/22] net: eepro100: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/eepro100.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 7db6fb5..329fe15 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -47,6 +47,8 @@ #include "pci.h" #incl

[Qemu-devel] [PATCH 06/22] net: ne2000: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/ne2000-isa.c |2 +- hw/ne2000.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index 03a5a1f..d5403d9 100644 --- a/hw/ne2000-isa.c +++ b/hw/ne2000-isa.c @@ -84,7 +84,7 @@ static int

[Qemu-devel] [PATCH 07/22] net: pcnet: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/pcnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pcnet.c b/hw/pcnet.c index 5e63eb5..7df39c4 100644 --- a/hw/pcnet.c +++ b/hw/pcnet.c @@ -1897,7 +1897,7 @@ int pcnet_common_init(DeviceState *dev, PCNetState *s

[Qemu-devel] [PATCH 09/22] net: mcf_fec: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/mcf_fec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c index 4e7fbed..1e592d2 100644 --- a/hw/mcf_fec.c +++ b/hw/mcf_fec.c @@ -476,5 +476,5 @@ void mcf_fec_init(NICInfo *nd, target_phys_addr_t

[Qemu-devel] [PATCH 10/22] net: mipsnet: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/mipsnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/mipsnet.c b/hw/mipsnet.c index a066f63..96bb588 100644 --- a/hw/mipsnet.c +++ b/hw/mipsnet.c @@ -280,7 +280,7 @@ void mipsnet_init (int base, qemu_irq irq, NICInfo

[Qemu-devel] [PATCH 08/22] net: lan9118: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/lan9118.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/lan9118.c b/hw/lan9118.c index 16d3330..07f9429 100644 --- a/hw/lan9118.c +++ b/hw/lan9118.c @@ -232,7 +232,7 @@ static void lan9118_update(lan9118_state *s

[Qemu-devel] [PATCH 11/22] net: rtl8139: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/rtl8139.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 72e2242..ee4fc5d 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -3382,7 +3382,7 @@ static int pci_rtl8139_init(PCIDevice *dev

[Qemu-devel] [PATCH 12/22] net: smc91c111: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/smc91c111.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/smc91c111.c b/hw/smc91c111.c index c1a88c9..767fc19 100644 --- a/hw/smc91c111.c +++ b/hw/smc91c111.c @@ -721,7 +721,7 @@ static int smc91c111_init1(SysBusDevice

[Qemu-devel] [PATCH 13/22] net: stellaris_enet: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/stellaris_enet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/stellaris_enet.c b/hw/stellaris_enet.c index d1d755e..cf28670 100644 --- a/hw/stellaris_enet.c +++ b/hw/stellaris_enet.c @@ -416,7 +416,7 @@ static int

[Qemu-devel] [PATCH 14/22] net: usb-net: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/usb-net.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-net.c b/hw/usb-net.c index ff0ca44..1583425 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -1454,7 +1454,7 @@ static int usb_net_initfn(USBDevice *dev

[Qemu-devel] [PATCH 15/22] net: virtio-net: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/virtio-net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 970ba06..482a176 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -89,7 +89,7 @@ static void virtio_net_set_config

[Qemu-devel] [PATCH 17/22] net: dump: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/dump.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/net/dump.c b/net/dump.c index 6db7ecf..dea7f7d 100644 --- a/net/dump.c +++ b/net/dump.c @@ -27,6 +27,9 @@ #include "sysemu.h" #include "qemu-err

[Qemu-devel] [PATCH 16/22] net: xilinx_ethlite: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/xilinx_ethlite.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_ethlite.c b/hw/xilinx_ethlite.c index 37e33ec..345aea7 100644 --- a/hw/xilinx_ethlite.c +++ b/hw/xilinx_ethlite.c @@ -230,7 +230,7 @@ static int

[Qemu-devel] [PATCH 18/22] net: slirp: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..4036b92 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,8 @@ #include "monitor.h" #include "syse

[Qemu-devel] [PATCH 19/22] net: socket: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/socket.c | 47 ++- 1 files changed, 34 insertions(+), 13 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..3521e21 100644 --- a/net/socket.c +++ b/net/socket.c @@ -28,6 +28,10

[Qemu-devel] [PATCH 20/22] net: tap: replace qemu_format_nic_info_str by info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap-win32.c |9 ++--- net/tap.c | 18 +- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..8e0ad2d 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c

[Qemu-devel] [PATCH 21/22] net: vde: replace qemu_format_nic_info_str by info_dict

2010-04-08 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/vde.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..f582878 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include "qemu-char.h" #include "qemu-comm

[Qemu-devel] [PATCH 22/22] monitor/net: Convert do_info_network() to QObject/QMP

2010-04-08 Thread Miguel Di Ciurcio Filho
Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit slightly changes the monitor output when 'info network' is used. Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |3 +- net.c

[Qemu-devel] [PATCH v3 12/12] net: Remove info_str from VLANClientState, not needed anymore

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net.c |9 - net.h |2 -- 2 files changed, 0 insertions(+), 11 deletions(-) diff --git a/net.c b/net.c index 46e8873..5dfe24d 100644 --- a/net.c +++ b/net.c @@ -168,15 +168,6 @@ int parse_host_port(struct sockaddr_in *saddr, const char

[Qemu-devel] [PATCH v3 11/12] monitor/net: Convert do_info_network() to QObject/QMP

2010-04-15 Thread Miguel Di Ciurcio Filho
Devices not on any VLAN: Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c |3 +- net.c | 127 net.h |3 +- 3 files changed, 122 insertions(+), 11 deletions(-) diff --git a/monitor.c b/monitor.c index 4c6275e..3478

[Qemu-devel] [PATCH v3 10/12] net: xen: use info_dict instead of info_str

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/xen_nic.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/xen_nic.c b/hw/xen_nic.c index 08055b8..d51839d 100644 --- a/hw/xen_nic.c +++ b/hw/xen_nic.c @@ -43,6 +43,8 @@ #include "net/checksum.h" #include &

[Qemu-devel] [PATCH v3 09/12] net: socket: use info_dict instead of info_str

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/socket.c | 47 --- 1 files changed, 32 insertions(+), 15 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..fa5d24d 100644 --- a/net/socket.c +++ b/net/socket.c @@ -28,6 +28,10

[Qemu-devel] [PATCH v3 07/12] net: vde: use info_dict instead of info_str

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/vde.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..f582878 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include "qemu-char.h" #include "qemu-comm

[Qemu-devel] [PATCH v3 08/12] net: dump: use info_dict instead of info_str

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/dump.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/net/dump.c b/net/dump.c index 6db7ecf..dea7f7d 100644 --- a/net/dump.c +++ b/net/dump.c @@ -27,6 +27,9 @@ #include "sysemu.h" #include "qemu-err

[Qemu-devel] [PATCH v3 04/12] net: various devices: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-15 Thread Miguel Di Ciurcio Filho
These are simple one line changes to replace qemu_format_nic_info_str. Signed-off-by: Miguel Di Ciurcio Filho --- hw/dp8393x.c|2 +- hw/e1000.c |2 +- hw/lan9118.c|4 ++-- hw/mcf_fec.c|2 +- hw/mipsnet.c|2 +- hw/ne2000-isa.c

[Qemu-devel] [PATCH v3 06/12] net: tap/tap-win32: use info_dict instead of info_str

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap-win32.c |9 ++--- net/tap.c | 18 +- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..a54cd31 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c

[Qemu-devel] [PATCH v3 03/12] net: eepro100: replace qemu_format_nic_info_str by qemu_format_nic_info_dict

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/eepro100.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 7db6fb5..457bda8 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -1978,8 +1978,14 @@ static int nic_init(PCIDevice

[Qemu-devel] [PATCH v3 05/12] net: slirp: use info_dict instead of info_str

2010-04-15 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..eb9d261 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,9 @@ #include "monitor.h" #include

[Qemu-devel] [PATCH v3 01/12] QObject API: add qdict_to_qstring() function

2010-04-15 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SPACE key2=value2 SPACE key3=value3 Handy for debugging and other things. Signed-off-by: Miguel Di Ciurcio Filho --- qdict.c | 41 + qdict.h |3 +++ 2

[Qemu-devel] [PATCH v3 02/12] net: add qemu_nic_format_info_dict and VLANClientState->info_dict

2010-04-15 Thread Miguel Di Ciurcio Filho
-off-by: Miguel Di Ciurcio Filho --- net.c | 16 net.h |2 ++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index d7d76eb..8c02f28 100644 --- a/net.c +++ b/net.c @@ -35,6 +35,8 @@ #include "sysemu.h" #include "qemu-comm

[Qemu-devel] [PATCH v3 00/12] Convert do_info_network() to QObject/QMP

2010-04-15 Thread Miguel Di Ciurcio Filho
The VLANClientState structure has the member info_str, a simple string that is filled with information about NIC devices and used on monitor calls. There is no coherent formatting of this string by all the NIC devices, making it difficult to parse and represent this information over QMP. Patch 01

[Qemu-devel] Bug in net/socket.c: info_str is overwritten

2010-05-06 Thread Miguel Di Ciurcio Filho
Hi there, I'm working on the conversion of the 'info network' command do QMP, and I think I've found some problems. Running qemu like this: qemu -net socket,listen=: In net/socket.c, the function net_socket_listen_init() [1] is called and a listening socket is created. There is nothing regis

Re: [Qemu-devel] [RFC] New Monitor command: 'info netdevices'

2010-05-14 Thread Miguel Di Ciurcio Filho
On Fri, May 14, 2010 at 6:46 AM, Markus Armbruster wrote: > > There's also > > 3. Convert it anyway.  Clean up the mess.  Change the output. > I agree. It seams to me that no one is concerned with any Monitor output change with this particular command. Plus, no one have shown any concerns about

[Qemu-devel] [PATCH] net: Remove dead code from net/socket.c

2010-05-14 Thread Miguel Di Ciurcio Filho
is dead. Signed-off-by: Miguel Di Ciurcio Filho --- net/socket.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..b72a2de 100644 --- a/net/socket.c +++ b/net/socket.c @@ -267,11 +267,6 @@ static NetSocketState

[Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c

2010-05-14 Thread Miguel Di Ciurcio Filho
On Fri, May 14, 2010 at 2:03 PM, Jan Kiszka wrote: >> >> In both cases the info_str string is written inside >> net_socket_fd_init_(stream|dgram), and after that, it is >> overwritten on a subsequent snprintf() in net_socket_accept(). >> > > There is non-zero time window between registration and a

[Qemu-devel] [PATCH v4 10/10] monitor/net: introduce 'info netdevices' with QMP support

2010-05-18 Thread Miguel Di Ciurcio Filho
"downscript":"/etc/kvm/kvm-ifdown", "model":"tap", "ifname":"tap0" } }, { "name":"e1000.0", "vlan":0, &qu

[Qemu-devel] [PATCH v4 09/10] net: socket: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/socket.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index 1c4e153..5be1b54 100644 --- a/net/socket.c +++ b/net/socket.c @@ -28,6 +28,7 @@ #include "net.h"

[Qemu-devel] [PATCH v4 08/10] net: slirp: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/slirp.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b41c60a..a6e25ff 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -32,6 +32,9 @@ #include "monitor.h" #include

[Qemu-devel] [PATCH v4 06/10] net: vde: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/vde.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/net/vde.c b/net/vde.c index 0b46fa6..6a3d0ba 100644 --- a/net/vde.c +++ b/net/vde.c @@ -31,6 +31,9 @@ #include "qemu-char.h" #include &quo

[Qemu-devel] [PATCH v4 04/10] net: xen: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- hw/xen_nic.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/xen_nic.c b/hw/xen_nic.c index 08055b8..1820059 100644 --- a/hw/xen_nic.c +++ b/hw/xen_nic.c @@ -321,6 +321,11 @@ static int net_init(struct XenDevice *xendev

[Qemu-devel] [PATCH v4 05/10] net: tap/tap-win32: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/tap-win32.c |9 - net/tap.c | 18 +- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 74348da..54c6725 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c

[Qemu-devel] [PATCH v4 02/10] net: introduce qemu_nic_format_info_dict and VLANClientState->info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle the information of a NIC. Signed-off-by: Miguel Di Ciurcio Filho --- net.c | 17

[Qemu-devel] [PATCH v4 07/10] net: dump: introduce info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
Signed-off-by: Miguel Di Ciurcio Filho --- net/dump.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/net/dump.c b/net/dump.c index 6db7ecf..32514ad 100644 --- a/net/dump.c +++ b/net/dump.c @@ -26,6 +26,9 @@ #include "qemu-common.h" #include

[Qemu-devel] [PATCH v4 03/10] net: various devices: add qemu_format_nic_info_dict

2010-05-18 Thread Miguel Di Ciurcio Filho
These are simple one line additions of qemu_format_nic_info_dict. Signed-off-by: Miguel Di Ciurcio Filho --- hw/dp8393x.c|1 + hw/e1000.c |1 + hw/eepro100.c |2 ++ hw/lan9118.c|2 ++ hw/mcf_fec.c|1 + hw/mipsnet.c|1 + hw

[Qemu-devel] [PATCH v4 01/10] QObject API: introduce qdict_to_qstring() function

2010-05-18 Thread Miguel Di Ciurcio Filho
This is a helper function that converts a QDict to a QString, using the format: key1=value1 SEP key2=value2 SEP key3=value3 Handy for debugging and formating the Monitor output. Signed-off-by: Miguel Di Ciurcio Filho --- qdict.c | 55

[Qemu-devel] [PATCH v4 0/10] Introduce 'info netdevices' with QMP support

2010-05-18 Thread Miguel Di Ciurcio Filho
The VLANClientState structure has the member info_str, a simple string that is filled with information about NIC devices and used on monitor calls. There is no coherent formatting of this string by all the NIC devices, making it difficult to parse and represent this information over QMP. To make

Re: [Qemu-devel] [RFC] Bug Day - June 1st, 2010

2010-05-19 Thread Miguel Di Ciurcio Filho
On Wed, May 19, 2010 at 2:04 AM, Aurelien Jarno wrote: > > The idea is nice, but would it be possible to hold this on a week-end, > I personally won't be able to attend such thing on a day week. > > Or maybe holding that on two days: friday and saturday so that people > can participate at least on

<    1   2